docs(tested): robust buffer access off and on on an RTX 4090, plain, with DLSS Frame Generation and with the renderer's own #460
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!460
Loading…
Reference in a new issue
No description provided.
Delete branch "Jiro113/Longshot:docs/tested-robust-buffers-4090"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why
Longshot asks robust buffer access for the whole device by default (the Debug tab's Robust buffers row,
robust_buffers,RX_VK_ROBUST), and nobody had timed what that costs. Asking it for some pipelines only (VK_EXT_pipeline_robustness, in Vulkan 1.4's core) was claimed in the team chat as a way to win that cost back, so the cost was measured first: 24 runs on an RTX 4090 resolve a cost of at most about 0.8 % of GPU time (plain, and in Kokiri Forest with DLSS Frame Generation), and the two frame generation series cannot exclude up to about 3 % in Hyrule Field. The switch was not written.What changed
docs/tested/, one per run (2026-11-14-robust-buffers-native-jiro113-run01torun10,-dlssg-run01torun08,-framegen-run01torun06); the frozen table is untouched and no assembled view is committed. No code changes: the per-pipeline switch was not written.What the runs found. Each run starts the game once with
RX_VK_ROBUST=0or=1, stands still in Kokiri Forest and then in Hyrule Field (child) for 15 s and then 90 s measured, at 5120x1440. GPU time is the mean of the log'sGPU timelines over the window (the log prints one decimal; a window holds about 70 lines); each cell is the median of the runs' windows, with their mean and count in parentheses. Lower is better.Plain: Render resolution 100 % (the scene drawn at 5120x1440), no DLSS or FSR, no frame generation, V-Sync Auto (mailbox), 10 runs.
0caf0618,RX_VK_ROBUST=00caf0618,RX_VK_ROBUST=1DLSS Quality (3414x960 to 5120x1440) and DLSS Frame Generation 2x, V-Sync Off, 8 runs.
5e072fc8,RX_VK_ROBUST=05e072fc8,RX_VK_ROBUST=1The renderer's own frame generation 2x, Render resolution 100 %, no DLSS or FSR, V-Sync Off, 6 runs.
5e072fc8,RX_VK_ROBUST=05e072fc8,RX_VK_ROBUST=1In each table the baseline is the
RX_VK_ROBUST=0column. A switch on one build, so the comparison is the switch off against on, not main against a change.How far these go:
Flags and settings
None: no flag is added or changed. The runs use the existing
RX_VK_ROBUST(the options file'srobust_buffers: 0 Auto (on), 1 Off, 2 On), and the default stays on.Measurements
A docs change: measured by its check (CONTRIBUTING.md, "Measurements":
docs, test output on main and with this PR).main:
5e072fc8(2026-11-14)this PR: docs/tested-robust-buffers-4090 @
f78bfe72Hardware: RTX 4090 24 GB, NVIDIA 621.24, Core i9-13900K, 64 GB, Windows 11 Home 26300
Scene: none (game-free checks)
Method: both checks run twice on main and three times on this branch, alternating, on the same PC, with llvm-mingw's compilers on the PATH; the table gives the counts that came back each time but one (below)
How to reproduce:
python -I -B tests/test_tested_configurations.py,python -I -B tests/run_all.py,python -I scripts/tested_configurations.py5e072fc8f78bfe72tests/test_tested_configurations.pyscripts/tested_configurations.py's view dated 2026tests/run_all.pyThe same eight fail on main on this Windows PC:
test_bake_portability,test_bug_report,test_framegen_resources,test_lift_cache,test_module_ids,test_oot_state_tap,test_pad_layoutandtest_tested_configurations. The last one's failure is its stand-in for a redirected pipe, which writes\r\non Windows where the test expects\n; it builds its own files and reads none of this PR's. The test that reads the repository's fragments,test_repository_fragments_validate_and_source_suffix_is_preserved, passes with the 24 new files.The ninth failure, in one run of three on this branch, is
tests/test_control.py: its 27 cases passed and its test program then exited with 3221225477 (an access violation). It passed three times of three run by itself and in the next whole run; a docs file is not something it reads.The runs' method. One PC, one afternoon (12:15 to 15:40 local), a 2560x720 window on a 5120x1440 screen at 120 Hz, SDR; Quality preset Auto (this PC), anisotropic 16x, Reflex Off (no
NVIDIA Reflex: online in any log);HOS_FPS_MAX=1000,HOS_PRESENT_TRACEon. The scene's size is read from the textures each run made: 5120x1440 in the plain and the renderer's own series, 3414x960 with DLSS.scripts/dev_packs.py rt, llvm-mingw, no pack over them):0caf0618made without the NVIDIA DLSS SDK for the plain series,5e072fc8made with it for the two others. The same runtime in both arms of a series.scripts/longshot_ctl.py launch --run, Continue,longshot_ctl.py teleport KokiriForest_Child --arrive 60, 15 s to settle, 90 s measured with nothing sent to the game, then the same inHyruleField_Child.RX_VK_ROBUST=0and=1, interleaved (plain: on, off, on, off, off, on, on, off, off, on; DLSS Frame Generation: on, off, off, on, off, on, on, off; the renderer's own: off, on, on, off, on, off). The log saysvk: robust buffer access onin every on run and in no off run.RX_VK_DLSS=1 RX_VK_FRAMEGEN_MULT=2 RX_VK_IMMEDIATE=1(DLSS Quality 3414x960 to 5120x1440; the log'sof the last 600 presents ... made by DLSS-Glines say 599 to 600 in every window); the renderer's ownRX_VK_DLSS=0 RX_VK_DLSS_FG=0 RX_VK_FRAMEGEN_MULT=2 RX_VK_IMMEDIATE=1(no NGX line in the log; itsframe interpolationlines count 31,066 to 33,379 frames shown on time over a run's two windows and 0 to 2 late). V-Sync Off is not the default: V-Sync Auto holds DLSS Frame Generation to the screen's rate.From the middle of a Hyrule Field window, one run of each arm (the log's counters; with either maker the
frame interpolationline counts the frames shown):Testing
Tested: the game-free checks above, on Windows 11 with an RTX 4090 (NVIDIA 621.24). The 24 runs are in the game: Kokiri Forest and Hyrule Field (child), standing still, on the same PC; each file's numbers are written from its run's log and present trace by a script, not typed.
Not tested: the website's catalogue built from these files. What the runs leave open: any GPU that isn't NVIDIA's, a card with less than 24 GB, Linux, FSR and the other upscalers without frame generation (with
RX_VK_DLSS=0the Auto preset rendered at 100 %), a moving camera or a fight, and what robust buffer access guards against when it is off.Needs other testers: None for this PR, which only records runs. The cost on AMD and Intel drivers is unmeasured; no request is open for it.
Screenshots
Nothing on screen.
Risk and rollback
Docs only: nothing the game or the build reads. Reverting the commit removes the 24 files.
Reviewer notes
Issues
None.
Checklist
For everyone
type(scope): description).main.python -I -B tests/run_all.pyrun and passing (any failure that also fails onmainis named above).third_party/untouched (a new folder with aPROVENANCE.mdinstead).If applicable
Assisted-by:/Co-Authored-By:trailers.docs/tested/for each new measured run (format indocs/tested-configurations.md; no appended row or assembled view).🤖 Generated with Claude Code
WIP: docs(tested): robust buffer access off and on on an RTX 4090, plain, with DLSS Frame Generation and with the renderer's ownto docs(tested): robust buffer access off and on on an RTX 4090, plain, with DLSS Frame Generation and with the renderer's ownAdded to the description: a few log lines (counters only) from the middle of a Hyrule Field window, one run of each arm in each series, so the numbers in the tables can be read against the lines they come from. Nothing else changed; the branch is still at
f78bfe72.Taking an independent review of the reported run records, pair arithmetic and bounded claims at
f78bfe721e. I will validate the fragments and methodology; I am not repeating the RTX4090 sessions. Matrix broadcast is queued for the next permitted hourly slot.Independent docs/data review at
f78bfe721e: no blocking findings.All24 new fragments validate with the existing repository check (1 passed, no skips); the frozen catalogue and code are untouched. Recomputed the six arm counts, means, medians and neighbour-pair deltas from the committed three-decimal window means, matching the reported precision. The two Hyrule windows in native run6 explain its arm count and reproduce the run-level -0.23% pair. Methods distinguish window means from run medians and native rendering from NGX/renderer frame generation; disturbances, drift, teleport failure and exclusions are disclosed.
Nonblocking wording note: the0.8% /3% ranges describe observed central differences and spread, rather than statistical upper confidence bounds. Keeping that distinction explicit avoids implying a guaranteed maximum cost.
I did not independently repeat the GPU sessions or inspect their private raw logs, build the website, run the full suite, or validate other hardware/drivers. This approval covers the committed records, arithmetic and bounded methodology; it is not new GPU evidence or a robustness-off safety result.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.