fix(website): the download page's logo and favicon load, it looks like the site, and it links the docs #257
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!257
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:fix/download-page"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Why
https://longshot.magicbean.dev/download/ shows a broken image where its logo should be, and has no favicon: it asks for
/logo.webpand/favicon-32.png, which the site never had. It also looked like a different site (a brown theme, no header) and didn't point to the install guide or help.What changed
page()inwebsite/worker/index.ts, the shell of every/downloadpage:/branding/longshot.png, the site's own logo;src/styles/theme.css), in its dark and light themes, following the theme picked on the site (Starlight'sstarlight-themein localStorage) or else the system's;downloadPage(): a Then list after the buttons linking Requirements, Get started, Antivirus and SmartScreen, and Help; the README link is replaced by those site pages; the channels are cards.The channel rules, the redirects and every URL under
/downloadare unchanged.Flags and settings
None.
Measurements
Not a performance change. What counts is whether the page's images load.
main:
fbd42024(the live site, 2026-11-13)this PR: fix/download-page @
6749d5d0Hardware: n/a (a web page)
Scene: https://longshot.magicbean.dev/download/
Method: the image URLs each version's HTML asks for, fetched from the live site with curl
How to reproduce:
curl -sI https://longshot.magicbean.dev/logo.webp, and the same for each URL belowfbd420246749d5d0/logo.webp→/branding/longshot.png)/favicon-32.png→/branding/longshot.png)Testing
Tested: the Worker rendered
/downloadoffline (Node, stubbedcacheswith an rc and a nightly), screenshotted in headless Chromium at 1200 px dark and at 390 px light: logo, header, buttons, Then list and channel cards render; no horizontal scroll at phone width. The live page's 404s for/logo.webpand/favicon-32.pngchecked with curl;/branding/longshot.pnganswers 200.Not tested: the deployed Worker (the preview upload from
website.ymlwill show it);npm run checkinwebsite/andpython -I -B tests/run_all.pynot run on this PC.Needs other testers: None.
Screenshots
main @
fbd42024, the live page (dark, 1200 px): the logo is a broken imagethis PR @
6749d5d0, dark, 1200 pxthis PR @
6749d5d0, light, 390 px (a phone)Risk and rollback
Only the HTML of the
/downloadpages changes; the download links are untouched. Reverting the commit is enough.Issues
None.
Checklist
For everyone
type(scope): description).main.python -I -B tests/run_all.pyrun and passing (any failure that also fails onmainis named above). Not run on this PC: needs someone to run it (andnpm run checkinwebsite/).third_party/untouched (a new folder with aPROVENANCE.mdinstead).If applicable
Assisted-by:/Co-Authored-By:trailers.🤖 Generated with Claude Code
WIP: fix(website): the download page's logo and favicon load, it looks like the site, and it links the docsto fix(website): the download page's logo and favicon load, it looks like the site, and it links the docs