test(input): the pads-after-menu check follows Sprint's SPRINT_L3, in its constants and its bitmask #2215
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!2215
Loading…
Reference in a new issue
No description provided.
Delete branch "dazemc/Longshot:fix/pads-after-menu-sprint-l3"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
tests/test_pads_after_menu.pycutsread_input's pad block andpad_sprint_down()out ofhost/nn_hid.c, with its own stand-ins. Its prelude carried a hand-copiedenum { SPRINT_PAD = 2 }. #2038 made the left stick's press a Sprint input of its own,SPRINT_L3, andpad_sprint_down()now uses it, so the check has not compiled since:SPRINT_L3 undeclared.What changed: the check cuts
nn_hid.c's own enum (SPRINT_KEY,SPRINT_PAD,SPRINT_L3) the way it already cuts theHOS_*enums fromvk_api.h, and the hand-copiedSPRINT_PADis gone. The next Sprint constant cannot drift from the check. It asserts the same behaviour as before; no assertion is removed.No product change: the branch is
a2dc5385plus two test commits (the constants, then the bitmask the first run caught), and differs frommainonly intests/test_pads_after_menu.py.Testing
Tested: the full suite,
--jobs 5in a 12 GiB memory scope with the pinned headers: here 912 passed, 22 failed, 18 skipped in 399 s againstmain @ a2dc5385's 911 / 23 / 18. The 22 failing names are exactlya2dc5385's 23 lesstests/test_pads_after_menu.py, which this updates; no name here is absent from the baseline and none is new.The first run, at
298986e4(--jobs 3, 8 GiB), was911 / 23 / 18withtest_pads_after_menu.pystill red atFAIL:342 game(s) == 0 && sprint_now == SPRINT_PAD: the constants fix had let the check compile for the first time since #2038, which exposed a second stale expectation — the left stick's press returnsSPRINT_PAD | SPRINT_L3(#2038'spad_sprint_down()).3d7704ebexpects both bits, which is why the fix is two commits.Still to test: None.
Measurements
Verdict: the check compiles and passes again:
test_pads_after_menu.pygoes from a compile error to a pass, the suite is912 / 22 / 18against the baseline's911 / 23 / 18, and no other failing name moves.a2dc53853d7704ebtest_pads_after_menu.pySPRINT_L3 undeclared(compile)Risks
A test-only change: nothing the game runs changes. If the enum gains a constant, the check takes it with no edit; if
pad_sprint_down()starts reading something the prelude lacks, the compile says which line.#152(WIP) edits this same file, in a different hunk: it addsstate = "static volatile LONG pad_count_now;\n" + statenear line 156, while this change removes the hand-copied enum from the prelude (line 87) and adds the cut enum tocode(near line 168). The two do not overlap.Checklist
Ready for review
main; the title is a Conventional Commit. (the branch isa2dc5385plus two test commits, same topic)3d7704eb)mise run testpasses (any failure that also fails onmainis named). (--jobs 5, 12 GiB scope, pinned headers: 912 / 22 / 18 in 399 s against main's 911 / 23 / 18; the 22 are the baseline's 23 lesstests/test_pads_after_menu.py, with no new name. The first run, at298986e4, is in Testing.)main, or Measurements says why there is nothing to measure. (both runs are in Measurements)third_party/untouched; nothing GPL-incompatible.When it applies
tests/that reads changed source is updated, not weakened. (the constants are cut fromnn_hid.c; no assertion removed)Assisted-by:/Co-Authored-By:trailers. The head addsAssisted-by: DeepSeek V4.1 Flash 1017 (opencode-go)in an empty commit (message-only: no file changed); its tree6280eceac7db695ff772a99326d6062393499bc4is the same object as3d7704eb's, so the runs and checks above describe the head's tree.Ready to merge
main, measured again or a comment says why the numbers still hold. (CI has not run on this head)@review
Recommendation: Approve. The change restores the check without changing player code, and the reported run shows it passing against a failing baseline. CI is still running. Nothing blocking is left. Recommend approval; not approved on the forge.
The test now takes Sprint constants from the host source and expects both bits for a left-stick press. This restores coverage of pad input after the menu without changing the game.
@fixwill do (1)Checks: Still running:
CI / Conventional Commit title (pull_request),CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request),CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request),CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request),CI / Workflow lint (actionlint) (pull_request),CI / Website build and checks (pull_request),Guide screenshots / Guide images and local UI source review (pull_request),Third-party parts / As their notes say (pull_request),Third-party parts / The same as upstream (pull_request).More: does it help, other systems, switches, what was read
Does it help: Yes: the author reports that the test changes from a compile failure on base
a2dc5385to a pass on head3d7704eb; the full suite changes from 911 passed, 23 failed and 18 skipped to 912 passed, 22 failed and 18 skipped.Other systems: The diff changes only a game-free test. It does not change gameplay, rendering, platform code, saves, audio or input handling.
Switches: None added, changed or removed.
Reviewed:
3d7704eb82againsta2dc538590: Read AGENTS.md, CONTRIBUTING.md, docs/dev/standards.md, the pull request template, both commits, the complete changed test and the relevant host input code. Skimmed the Sprint test and test runner. docs/review-checklist.md and ../Tooling/AGENTS.md were unavailable; no generated files, translations or recorded runs were changed.; nothing run (a code review).Checked and fine:
Testing: No code or tests were run, as requested. The author's baseline and head results were reviewed; the listed CI checks are still running.
Overlaps and merge order: The description identifies WIP PR #152 as editing a different hunk of the same test; it reports no textual overlap.
Automated code review by BeanBot (gpt-6.1-terra), asked for by llun. Nothing was run; a maintainer decides.
The
When it appliessection has noAI assistance recordedbox, and neither commit (3d7704eb,298986e4) has anAssisted-by:trailer. Add them (and theA fixbox if the updated check counts).AI-assistance box added with real evidence: head
663f0e1bis an empty, message-only commit carryingAssisted-by: DeepSeek V4.1 Flash 1017 (opencode-go); tree6280eceac7db695ff772a99326d6062393499bc4is the same object as3d7704eb's, so the runs still describe the head's tree. Pushed fast-forward, no force.View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.