MagicBeanDev/Longshot

Watch

Fork 101

WIP: build(release): the RTX 5090 fork list's note says what its build changed #221

Closed

dukenheimer wants to merge 1 commit from dukenheimer/Longshot:docs/pipeline-note-2143 into main

dukenheimer commented

2026-11-13 15:28:41 +00:00

Contributor

Why

Follow-up to https://github.com/NotRexed/Hookshot/pull/2143, which merged before reviewers' question about brett-d-rtx-5090-fork-fg-2x was answered: what was the "fork" build? Moved from https://github.com/NotRexed/Hookshot/pull/2703.

What changed

pipeline states: assets/pipeline_states/contrib/brett-d-rtx-5090-fork-fg-2x.md, the list's note only, says what its build was: local builds of main at 0828863 (9 Nov) plus changes that don't touch what goes into a record (DLSS-NR and an FXAA option in the window-scaling pass, a sampler cache and its descriptor-reuse check, a texture budget, menu rows and a voice feature). No changes to shader translation, program variants, target formats or draw state. The list itself is unchanged.

Flags and settings

None.

Measurements

main: Longshot main dd02c6c (2026-11-13)
this PR: docs/pipeline-note-2143
Hardware: not applicable
Scene: not applicable
Method: a note in a list's description; nothing to measure
How to reproduce: python -I nx2/pipeline_states.py check

	main @ `dd02c6c`	this PR @ the branch
pipeline_states.py check	passes	passes

python -I nx2/pipeline_states.py check   (passed on the Hookshot PR; the note is the only change)

Testing

Tested: python -I nx2/pipeline_states.py check on the Hookshot PR; the list's records are unchanged.

Not tested: nothing this could affect: the note isn't read by the build.

Needs other testers:

None.

Screenshots

Nothing on screen

Risk and rollback

None: a note. Reverting the commit is enough.

Reviewer notes

Cherry-picked unchanged onto Longshot main.

Issues

See https://github.com/NotRexed/Hookshot/issues/2034

Checklist

For everyone

One topic.
The title is a Conventional Commit (type(scope): description).
Rebased on current main.
python -I -B tests/run_all.py run and passing (any failure that also fails on main is named above).
Tested in the game, or what wasn't is named under Testing.
Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests).
Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported.
No game files, dumps, build output or generated files.
third_party/ untouched (a new folder with a PROVENANCE.md instead).
The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

## Why Follow-up to https://github.com/NotRexed/Hookshot/pull/2143, which merged before reviewers' question about `brett-d-rtx-5090-fork-fg-2x` was answered: what was the "fork" build? Moved from https://github.com/NotRexed/Hookshot/pull/2703. ## What changed - pipeline states: `assets/pipeline_states/contrib/brett-d-rtx-5090-fork-fg-2x.md`, the list's note only, says what its build was: local builds of main at 0828863 (9 Nov) plus changes that don't touch what goes into a record (DLSS-NR and an FXAA option in the window-scaling pass, a sampler cache and its descriptor-reuse check, a texture budget, menu rows and a voice feature). No changes to shader translation, program variants, target formats or draw state. The list itself is unchanged. ## Flags and settings None. ## Measurements main: Longshot main dd02c6c (2026-11-13) this PR: docs/pipeline-note-2143 Hardware: not applicable Scene: not applicable Method: a note in a list's description; nothing to measure How to reproduce: `python -I nx2/pipeline_states.py check` | | main @ dd02c6c | this PR @ the branch | |---|---|---| | pipeline_states.py check | passes | passes | ``` python -I nx2/pipeline_states.py check (passed on the Hookshot PR; the note is the only change) ``` ## Testing **Tested:** `python -I nx2/pipeline_states.py check` on the Hookshot PR; the list's records are unchanged. **Not tested:** nothing this could affect: the note isn't read by the build. **Needs other testers:** - None. ## Screenshots Nothing on screen ## Risk and rollback None: a note. Reverting the commit is enough. ## Reviewer notes Cherry-picked unchanged onto Longshot main. ## Issues See https://github.com/NotRexed/Hookshot/issues/2034 ## Checklist ### For everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`). - [x] Rebased on current `main`. - [ ] `python -I -B tests/run_all.py` run and passing (any failure that also fails on `main` is named above). - [x] Tested in the game, or what wasn't is named under Testing. - [x] Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests). - [x] Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported. - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

dukenheimer added 1 commit

2026-11-13 15:28:41 +00:00

build(release): say what the fork list's build changed (nothing a record holds)

PR description / Description follows the template (pull_request_target) Successful in 4s

Details

Website / Website on Cloudflare (pull_request_target) Has been skipped

Details

CI / Conventional Commit title (pull_request) Has been cancelled

Details

CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled

Details

CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled

Details

CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled

Details

CI / Workflow lint (actionlint) (pull_request) Has been cancelled

Details

Third-party parts / As their notes say (pull_request) Has been cancelled

Details

Third-party parts / The same as upstream (pull_request) Has been cancelled

Details

ad7241499d

Co-authored-by: Copilot App <[email protected]>
(cherry picked from commit dcd7f830636769b7cd74d1767385abf68bf9a57c)

mooki added the

area/renderer

kind

chore

labels

2026-11-14 01:45:14 +00:00

mooki added the

priority

low

label

2026-11-14 04:18:14 +00:00

mooki added the

area/install

label

2026-11-14 16:27:34 +00:00

mooki added the

platform/linux

platform/windows

labels

2026-11-14 18:22:27 +00:00

dukenheimer commented

2026-11-15 06:13:10 +00:00

Author

Contributor

Closing: the RTX 5090 fork-list note was for Hookshot's release builds and doesn't apply to Longshot's release process.

dukenheimer closed this pull request

2026-11-15 06:13:10 +00:00

malon referenced this pull request

2026-11-15 15:11:03 +00:00

Game: Keeps on crashing in death mountain #817

PR description / Description follows the template (pull_request_target) Successful in 4s

Details

Website / Website on Cloudflare (pull_request_target) Has been skipped

Details

CI / Conventional Commit title (pull_request) Has been cancelled

Details

CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled

Details

CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled

Details

CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled

Details

CI / Workflow lint (actionlint) (pull_request) Has been cancelled

Details

Third-party parts / As their notes say (pull_request) Has been cancelled

Details

Third-party parts / The same as upstream (pull_request) Has been cancelled

Details

Pull request closed

Please reopen this pull request to perform a merge.

No reviewers

No labels

beanstalk: approved @ 1697603

beanstalk: approved @ 2c5a62e

beanstalk: approved @ 4fd82b7

beanstalk: approved @ 64d6d09

beanstalk: approved @ 6f91fae

beanstalk: approved @ 70a78f9

beanstalk: approved @ 8015c9a

beanstalk: approved @ 8d361dc

beanstalk: approved @ 9d8356e

beanstalk: approved @ abf2227

beanstalk: approved @ d82f202

beanstalk: approved @ e5f1e40

beanstalk: approved @ ee8ab5f

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

MagicBeanDev/Longshot!221

No description provided.

Rows
Columns