WIP: fix(dev): a timed run's noise names the queue's jobs that ran beside it #2187
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!2187
Loading…
Reference in a new issue
No description provided.
Delete branch "dyst/Longshot:fix/queue-noise-beside"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
A timed run's history keeps how busy the rest of the PC was, so a noisy measurement shows. Two of those readings, the CPU pressure and the load, come from Linux alone and are always 0 on Windows. And the queue's own other jobs running beside a timed run were never noted. A light job starts beside a timing one. In two
dev.py abseries for #2185, another session's runtime builds ran beside three runs and prepared shaders on the GPU: those runs gave 27.9, 29.1 and 41.1 fps against 65 to 72, with the noise all zeros.The noise now names each other queue job active while the timed run ran (
"jobs_beside": ["rt-pr1937 (light)"]), on every system. The run's line then says the PC was busy while it measured.Read first:
Noiseand_keep_apartinscripts/devtools/jobqueue.py.Testing
Tested: not run yet.
tests/test_job_queue.pyhas a case for the record's new field. Not run yet.Still to test:
dev.py queue historyto name that job underjobs_beside, and the run's line to say the PC was busy (by hand)Measurements
Nothing to measure: what the queue records, not how a run goes.
Risks
A timed run with a job beside it now ends with the "busy while it measured" line; nothing is refused or moved. Reverting is enough.
Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named). Not run yet.main, or Measurements says why there is nothing to measure.third_party/untouched; nothing GPL-incompatible.When it applies
Assisted-by:/Co-Authored-By:trailers.Ready to merge
main, measured again or a comment says why the numbers still hold.🤖 Generated with Claude Code
A timed run's history kept the PC's CPU pressure and load, both read from Linux alone, and the builds outside the queue. On Windows the first two are always 0, and the queue's own jobs beside a timed run were never noted: a light job starts beside a timing one, and two series of dev.py ab had runs spoiled by another session's runtime builds (their shader preparation took the GPU; 27.9 and 29.1 fps against 65 to 68) with the noise all zeros. The noise now names each other job active while the timed run ran ("name (mode)"), on every system, and the run's line says the PC was busy when there was one. Co-Authored-By: Claude Opus 5.5 <[email protected]>View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.