feat(input): Sprint's Toggle arms and disarms from Link's state, on by default #2168

Merged
HumanBean merged 3 commits from llun/Longshot:feat/sprint-toggle-link-state into main 2026-11-22 00:16:57 +00:00
Member

Summary

Sprint's Toggle now arms and disarms from Link himself, as Hotoni describes it for their sprint mod (the rules
below are theirs), and it is on by default.

  • One press arms it. It stays on while Link runs: the run, the post-roll run, a roll, a jump, a landing, a slide,
    and a turn or a U-turn.
  • It ends by itself when Link stops: after 4 game frames standing still once he has run, or 90 frames after a press
    made standing still (so a press before you start moving isn't lost). Standing still also covers Link stuck in his
    Walk state without moving (held against a wall, or a stick resting a little off its centre), after 16 frames of it
    followed by the standing-still wait, so a U-turn's short stop in Walk keeps the sprint.
  • It ends on any other action: an attack, Z-targeting (ZL), an item, talking or a cutscene (an event), climbing, a
    ledge, swimming, Epona, the ocarina. The next press ends it too.
  • Menus, the game's pause and the focus lost no longer end it. It's decided from Link's state, not from the input:
    Insert open or the window behind another one (with no controller playing in the background) holds it as it is; the
    game's pause and its panel (Plus, Minus) hold it while the game stops under them; a load holds it. Back in the game,
    Link has the same 90 frames to move again. The menus keep their own input as before: a press of Sprint's in Insert or
    the pause menu isn't Sprint's, and one held as a menu closes starts nothing.
  • Toggle on by default. Options files from before (options_version 6 and older) wrote toggle_sprint=0 whether it
    was chosen or not; they now come up with the Toggle on. Hold is still one click away on the Controls page, and works
    as before. Reset and Reset to defaults put Sprint's Toggle back on.

How to see it on main: Sprint On, Toggle on, run into a wall and stay against it: the sprint never ends, and
moving away later is still the sprint (one way to get #2146's report). Or open Insert, the pause menu, or click
another window: the toggled sprint is gone. A test run's exclusive bridge input (longshot_ctl.py) ends it as soon as
its SPRINT is let go, so a toggled sprint can't be checked headless on main.

How: host/oot_sprint.c. hos_sprint_input's blocked is now flags: SPRINT_BLOCKED takes no press and no
longer ends a toggled sprint; SPRINT_AWAY holds it; SPRINT_PAUSE (Plus or Minus pressed) allows time for the game's pause or panel to open.
Their screen updates signal when they are open and when they close, including while Link is stationary. Walk under STILL_SPEED (0.5 m/s) across the ground for
STILL_WALK_FRAMES is standing; his position is the state tap's (+0x31c in the actor at Link +0x18).
host/nn_hid.c stops resetting the toggled sprint with the buttons' toggles. The state ids are the game's own state
table's, read from its names (Walk 1, Wait 40, Rolling 99, TurnAround 21, Turn 22, QuickTurn 188; anything unlisted,
like LockOnMove 66, BasicAttack 112, Talk 75, Climb 70, Swim 84, UseItem 238, ends it). Each start and end of a toggled
sprint is logged with its reason and Link's state id (input: a toggled sprint ends: Link stopped (Link's state 40)),
for reports like #2146 that came with no log. All the numbers are named constants (WAIT_STOP_FRAMES 4,
WAIT_START_FRAMES 90, STILL_SPEED, STILL_WALK_FRAMES 16, PAUSE_OPEN_FRAMES 30), counted in 60 Hz game
frames so 120 or 240 fps behave as 60.

Also: the Toggle and Reset cells' help in all 13 languages, the user guide's Sprint paragraph and table row.

Read first: host/oot_sprint.c (hos_sprint_input, hos_sprint_step, state_kind), the Sprint block of
npad_states in host/nn_hid.c, menu_init's options_version 7 in gpu/vk/vk_menu.cpp.

Refs #2146 (the toggle staying on after Link stops: fixed for Link stuck in Walk; I couldn't reproduce the report's
exact case on main, see Testing). Fixes the focus part of #2060 ("tabbing out cancels Sprint Toggle"); its dialogue
part stays as it is on purpose: talking ends a toggled sprint, as the spec asks. Follows #1929, #1948, #1977 and
#2038.

Testing

Tested: Windows 11, NVIDIA GeForce RTX 5080 (driver 621.24), the game built from this branch over the shared base
of main @ dd5ffe6a2, headless through the job queue (--mode shared) and the control bridge, from the repository's
market-entrance save, in Hyrule Field, child and adult Link (the bridge's age switch). Link's state id and position
read each frame through mem_read, his speed from them, and the log's toggled-sprint lines:

Spec line Child Adult
Press, run, stop: back to normal speed sprint 5.31 m/s, let go: ends: Link stopped (Link's state 40), run again 4.50 6.37, ends the same, run again 5.40
A press while standing, run 60 frames later 5.31 (armed) 6.37
... run 150 frames later ends: Link did not start moving after the press, 4.50 the same, 5.40
A roll, a jump, a landing kept through the roll; ended only when the second roll ran into a wall (Walk without moving) kept through rolls, a slide and a fall
A U-turn, then running back kept, 5.31 after kept, 6.37 after
The next press ends: the next press, 4.50 the same, 5.40
ZL ends: ZL held (LockOnMove 66), 4.50 the same
The game's pause (Plus), the stick held through it kept kept
... the stick let go to pause, standing 40 frames after, then run kept, 5.32 kept, 6.37
The focus lost (input with the window behind, then 120 frames standing with none) kept, 5.31 after kept, 6.37 after
An event (the field's map change) ends: an event (a conversation, a cutscene) the same
Hold mode (Toggle off) 5.31 while held, 4.50 after; held with the stick let go: Wait, no sprint (child only)
An options file from before (options_version=6, toggle_sprint=0) comes up toggled: press, run, stop as above (child only)

Not covered in the game: an attack, an item, climbing and talking (the repository's saves have no sword or items, so B
does nothing there), and opening Insert (the bridge can't open it, and a headless window takes no keys): the game-free
test covers them and they are in Still to test.

On main @ 5726eff4 (its base alone, before this branch's rebase), Hold mode the same way: the sprint 5.31 m/s against a 4.50 m/s run (child);
the stick let go while Sprint stays held, Walk turns to Wait 4 frames later. A toggled sprint couldn't be driven
headless on main (the exclusive bridge input ended it at once), so #2146's report itself wasn't reproduced; the
Walk-without-moving case it can come from was, in the game-free test.

The checks:

  • tests/test_sprint.py (8 tests, host/oot_sprint.c against its fake game): fails on main at the first new rule
    (a blocked read ends a toggled sprint), and each new rule fails there alone too (a pause ends it 4 frames after
    Link is back; Walk without moving never ends it); passes here. Undoing each key line (if (event || !toggle), the
    resumed grace, the Walk-still rule) makes it fail. Windows clang, and Linux gcc (WSL Ubuntu 24.04; its C++ cases
    skip there, no g++).
  • tests/test_menu_keys.py: the Toggle on by default, Reset and Reset to defaults putting it back on, a file from
    before options_version 7 coming up on, Hold chosen now kept; fails on main, passes here (clang++).
  • tests/test_input_background.py (sprint-toggle: Insert, Plus and the focus lost end nothing, and what
    npad_states hands over), test_walk_key, test_menu_i18n: updated, pass but for what fails on main too.
  • The whole suite on main @ dd5ffe6a2 and here (Windows, clang): 717 passed, 97 failed, 135 skipped both, the 97 the same set (this PC's toolchain: no Vulkan headers, no g++ for some fixtures; listed in a comment), none failing only here.

Still to test:

  • Windows, an Xbox controller and the keyboard, by hand (llun): Sprint On, Toggle on (the default): press L3 or Shift
    and run, stop: back to normal speed; press while standing, start within a second and a half: sprint. Attack with a
    sword, aim with ZL, use an item, climb, talk: each ends it. Open the pause menu, Insert and alt-tab mid-sprint, come
    back with the stick held: still sprinting. Toggle off: only while held.
  • Linux: the build and the same checks with a controller (@Beanstalk build and start on Linux, then Sprint's Toggle: sprint, stop, pause and resume).

Measurements

Nothing to measure: per update of Link, two more guest reads (his position) beside the state chain #2038 already reads, and no switch is added.

Risks

  • What players notice after updating: Sprint's Toggle is on (for a file from before, too); a toggled sprint now stops
    when Link stops and survives menus, pauses and alt-tab. A player who wants Hold turns the Toggle cell off once.
  • The game's pause and panel are detected from their screen updates; changes to those updates could affect whether a
    toggled sprint is held through them.
  • The state ids and the position offset are game 1.1.1's, as #2038's are. A revert brings back main's Toggle.

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit.
  • Tested on my own PC, in the game for a change the game runs, as Testing says.
  • mise run test passes (any failure that also fails on main is named).
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • A fix: a game-free test that fails on main and passes here.
  • A check under tests/ that reads changed source is updated, not weakened.
  • Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. (Windows: built; Linux: only
    host/oot_sprint.c compiled by its check with gcc, the Linux build is on the Test Farm under Still to test)
  • Docs updated.
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested.
  • Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers").
  • Approved in review, every comment answered.
  • CI passes on the head; on current main, measured again or a comment says why the numbers still hold.

🤖 Generated with Claude Code

## Summary Sprint's **Toggle** now arms and disarms from Link himself, as Hotoni describes it for their sprint mod (the rules below are theirs), and it is **on by default**. - **One press arms it.** It stays on while Link runs: the run, the post-roll run, a roll, a jump, a landing, a slide, and a turn or a U-turn. - **It ends by itself when Link stops**: after 4 game frames standing still once he has run, or 90 frames after a press made standing still (so a press before you start moving isn't lost). Standing still also covers Link stuck in his Walk state without moving (held against a wall, or a stick resting a little off its centre), after 16 frames of it followed by the standing-still wait, so a U-turn's short stop in Walk keeps the sprint. - **It ends on any other action**: an attack, Z-targeting (ZL), an item, talking or a cutscene (an event), climbing, a ledge, swimming, Epona, the ocarina. **The next press** ends it too. - **Menus, the game's pause and the focus lost no longer end it.** It's decided from Link's state, not from the input: Insert open or the window behind another one (with no controller playing in the background) holds it as it is; the game's pause and its panel (Plus, Minus) hold it while the game stops under them; a load holds it. Back in the game, Link has the same 90 frames to move again. The menus keep their own input as before: a press of Sprint's in Insert or the pause menu isn't Sprint's, and one held as a menu closes starts nothing. - **Toggle on by default.** Options files from before (`options_version` 6 and older) wrote `toggle_sprint=0` whether it was chosen or not; they now come up with the Toggle on. Hold is still one click away on the Controls page, and works as before. Reset and Reset to defaults put Sprint's Toggle back on. **How to see it on `main`:** Sprint On, Toggle on, run into a wall and stay against it: the sprint never ends, and moving away later is still the sprint (one way to get #2146's report). Or open Insert, the pause menu, or click another window: the toggled sprint is gone. A test run's exclusive bridge input (`longshot_ctl.py`) ends it as soon as its `SPRINT` is let go, so a toggled sprint can't be checked headless on `main`. **How:** `host/oot_sprint.c`. `hos_sprint_input`'s `blocked` is now flags: `SPRINT_BLOCKED` takes no press and no longer ends a toggled sprint; `SPRINT_AWAY` holds it; `SPRINT_PAUSE` (Plus or Minus pressed) allows time for the game's pause or panel to open. Their screen updates signal when they are open and when they close, including while Link is stationary. Walk under `STILL_SPEED` (0.5 m/s) across the ground for `STILL_WALK_FRAMES` is standing; his position is the state tap's (`+0x31c` in the actor at Link `+0x18`). `host/nn_hid.c` stops resetting the toggled sprint with the buttons' toggles. The state ids are the game's own state table's, read from its names (Walk 1, Wait 40, Rolling 99, TurnAround 21, Turn 22, QuickTurn 188; anything unlisted, like LockOnMove 66, BasicAttack 112, Talk 75, Climb 70, Swim 84, UseItem 238, ends it). Each start and end of a toggled sprint is logged with its reason and Link's state id (`input: a toggled sprint ends: Link stopped (Link's state 40)`), for reports like #2146 that came with no log. All the numbers are named constants (`WAIT_STOP_FRAMES` 4, `WAIT_START_FRAMES` 90, `STILL_SPEED`, `STILL_WALK_FRAMES` 16, `PAUSE_OPEN_FRAMES` 30), counted in 60 Hz game frames so 120 or 240 fps behave as 60. Also: the Toggle and Reset cells' help in all 13 languages, the user guide's Sprint paragraph and table row. Read first: `host/oot_sprint.c` (`hos_sprint_input`, `hos_sprint_step`, `state_kind`), the Sprint block of `npad_states` in `host/nn_hid.c`, `menu_init`'s `options_version` 7 in `gpu/vk/vk_menu.cpp`. Refs #2146 (the toggle staying on after Link stops: fixed for Link stuck in Walk; I couldn't reproduce the report's exact case on `main`, see Testing). Fixes the focus part of #2060 ("tabbing out cancels Sprint Toggle"); its dialogue part stays as it is on purpose: talking ends a toggled sprint, as the spec asks. Follows #1929, #1948, #1977 and #2038. ## Testing **Tested:** Windows 11, NVIDIA GeForce RTX 5080 (driver 621.24), the game built from this branch over the shared base of `main` @ dd5ffe6a2, headless through the job queue (`--mode shared`) and the control bridge, from the repository's `market-entrance` save, in Hyrule Field, child and adult Link (the bridge's age switch). Link's state id and position read each frame through `mem_read`, his speed from them, and the log's toggled-sprint lines: | Spec line | Child | Adult | |---|---|---| | Press, run, stop: back to normal speed | sprint 5.31 m/s, let go: `ends: Link stopped (Link's state 40)`, run again 4.50 | 6.37, ends the same, run again 5.40 | | A press while standing, run 60 frames later | 5.31 (armed) | 6.37 | | ... run 150 frames later | `ends: Link did not start moving after the press`, 4.50 | the same, 5.40 | | A roll, a jump, a landing | kept through the roll; ended only when the second roll ran into a wall (Walk without moving) | kept through rolls, a slide and a fall | | A U-turn, then running back | kept, 5.31 after | kept, 6.37 after | | The next press | `ends: the next press`, 4.50 | the same, 5.40 | | ZL | `ends: ZL held` (LockOnMove 66), 4.50 | the same | | The game's pause (Plus), the stick held through it | kept | kept | | ... the stick let go to pause, standing 40 frames after, then run | kept, 5.32 | kept, 6.37 | | The focus lost (input with the window behind, then 120 frames standing with none) | kept, 5.31 after | kept, 6.37 after | | An event (the field's map change) | `ends: an event (a conversation, a cutscene)` | the same | | Hold mode (Toggle off) | 5.31 while held, 4.50 after; held with the stick let go: Wait, no sprint | (child only) | | An options file from before (`options_version=6`, `toggle_sprint=0`) | comes up toggled: press, run, stop as above | (child only) | Not covered in the game: an attack, an item, climbing and talking (the repository's saves have no sword or items, so B does nothing there), and opening Insert (the bridge can't open it, and a headless window takes no keys): the game-free test covers them and they are in Still to test. On `main` @ 5726eff4 (its base alone, before this branch's rebase), Hold mode the same way: the sprint 5.31 m/s against a 4.50 m/s run (child); the stick let go while Sprint stays held, Walk turns to Wait 4 frames later. A toggled sprint couldn't be driven headless on `main` (the exclusive bridge input ended it at once), so #2146's report itself wasn't reproduced; the Walk-without-moving case it can come from was, in the game-free test. The checks: - `tests/test_sprint.py` (8 tests, `host/oot_sprint.c` against its fake game): fails on `main` at the first new rule (a blocked read ends a toggled sprint), and each new rule fails there alone too (a pause ends it 4 frames after Link is back; Walk without moving never ends it); passes here. Undoing each key line (`if (event || !toggle)`, the resumed grace, the Walk-still rule) makes it fail. Windows clang, and Linux gcc (WSL Ubuntu 24.04; its C++ cases skip there, no g++). - `tests/test_menu_keys.py`: the Toggle on by default, Reset and Reset to defaults putting it back on, a file from before `options_version` 7 coming up on, Hold chosen now kept; fails on `main`, passes here (clang++). - `tests/test_input_background.py` (`sprint-toggle`: Insert, Plus and the focus lost end nothing, and what `npad_states` hands over), `test_walk_key`, `test_menu_i18n`: updated, pass but for what fails on `main` too. - The whole suite on `main` @ dd5ffe6a2 and here (Windows, clang): 717 passed, 97 failed, 135 skipped both, the 97 the same set (this PC's toolchain: no Vulkan headers, no g++ for some fixtures; listed in a comment), none failing only here. **Still to test:** - Windows, an Xbox controller and the keyboard, by hand (llun): Sprint On, Toggle on (the default): press L3 or Shift and run, stop: back to normal speed; press while standing, start within a second and a half: sprint. Attack with a sword, aim with ZL, use an item, climb, talk: each ends it. Open the pause menu, Insert and alt-tab mid-sprint, come back with the stick held: still sprinting. Toggle off: only while held. - Linux: the build and the same checks with a controller (`@Beanstalk build and start on Linux, then Sprint's Toggle: sprint, stop, pause and resume`). ## Measurements Nothing to measure: per update of Link, two more guest reads (his position) beside the state chain #2038 already reads, and no switch is added. ## Risks - What players notice after updating: Sprint's Toggle is on (for a file from before, too); a toggled sprint now stops when Link stops and survives menus, pauses and alt-tab. A player who wants Hold turns the Toggle cell off once. - The game's pause and panel are detected from their screen updates; changes to those updates could affect whether a toggled sprint is held through them. - The state ids and the position offset are game 1.1.1's, as #2038's are. A revert brings back `main`'s Toggle. ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. - [x] Tested on my own PC, in the game for a change the game runs, as Testing says. - [x] `mise run test` passes (any failure that also fails on `main` is named). - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [x] A fix: a game-free test that fails on `main` and passes here. - [x] A check under `tests/` that reads changed source is updated, not weakened. - [ ] Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. (Windows: built; Linux: only `host/oot_sprint.c` compiled by its check with gcc, the Linux build is on the Test Farm under Still to test) - [x] Docs updated. - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. ### Ready to merge - [ ] Everything in Still to test has run, its results in Tested. - [ ] Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers"). - [ ] Approved in review, every comment answered. - [ ] CI passes on the head; on current `main`, measured again or a comment says why the numbers still hold. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
tests/test_sprint.py runs host/oot_sprint.c against its fake game with the
rules from Hotoni's description of their sprint mod: a toggled sprint goes on
through Insert open, the focus lost (SPRINT_AWAY), a test run's own input and
the game's pause or a load, with the 90 frames a press gives to start moving
when Link is back; it ends when Link stands still in Walk (against a wall), and
at once for an attack, Z-targeting, climbing, a ledge, talking, swimming, an
item, the ocarina and Epona, with the game's own state ids. Held is unchanged.
tests/test_menu_keys.py: Sprint's Toggle is on by default, Reset puts it back
on, and a file from before options_version 7 (toggle_sprint=0 written whether
chosen or not) comes up with it on.

On main each fails for its reason: Insert open ends the toggled sprint, a
pause ends it 4 frames after Link is back, Walk without moving never ends it,
and Reset and the default leave Toggle off.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
feat(input): Sprint's Toggle arms and disarms from Link's state, on by default
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 19s
Website / Website on Cloudflare (pull_request_target) Has been skipped
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 34s
CI / Website build and checks (pull_request) Failing after 35s
CI / Workflow lint (actionlint) (pull_request) Successful in 36s
Third-party parts / As their notes say (pull_request) Successful in 39s
PR description / Description follows the template (pull_request_target) Successful in 22s
beanstalk/approval can't be tested as asked: see the farm's comment
297ebed56b
Based on Hotoni's description of their sprint mod: one press arms it; it stays
on while Link runs (the run, the post-roll run, a roll, a jump, a landing, a
turn or a U-turn) and ends when he stops (4 game frames standing still once he
has run, 90 after a press made standing still) or does anything else (an
attack, Z-targeting, an item, talking, climbing, swimming, a ledge, Epona, a
cutscene), or at the next press. Menus, the game's pause and the focus lost no
longer end it: they are the input's, not Link's.

- host/oot_sprint.c: hos_sprint_input's blocked is flags. SPRINT_BLOCKED takes
  no press and no longer ends a toggled sprint (a test run's exclusive input
  ended it as soon as its SPRINT was let go); SPRINT_AWAY (Insert open, the
  focus lost with no pads behind other windows) holds it as it is;
  SPRINT_PAUSE (Plus or Minus pressed) holds it while the game stops under its
  pause or panel, where Link's update goes on with his state and place frozen
  bit for bit (PAUSE_OPEN_FRAMES for it to open). Back from any of them, or
  after a load, Link has the 90 frames a press gives to move again.
  Walk with Link moving under STILL_SPEED (0.5 m/s) for STILL_WALK_FRAMES (16)
  counts as standing: held against a wall, or with a stick resting off its
  centre, Walk never became Wait and a toggled sprint never ended (one way to
  get issue 2146's "stays active after Link stops"); a U-turn's 6 still frames
  and TurnAround, Turn and QuickTurn keep it. A toggled sprint's start and end
  are logged with the reason and Link's state id.
- host/nn_hid.c: the Toggle's sprint is no longer reset by Insert, Plus or
  Minus or the focus lost; sprint_away and Plus or Minus pressed are handed
  over instead.
- gpu/vk: Sprint's Toggle on by default (Options, the host's default, Reset and
  Reset to defaults), with options_version 7 moving a file's toggle_sprint=0
  from before to on; the Toggle and Reset cells' help in all 13 languages.
- docs/user: the guide's Sprint paragraph, row and the Toggle column.
- tests: the input fixture expects the new flags and nothing ended by Insert,
  Plus or the focus lost; test_walk_key reads the Toggle's new default.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Member

Tested in game: Windows 11, RTX 5080 (driver 621.24), built from 297ebed5 over the shared base of main @ dd5ffe6a2, headless through the job queue and the control bridge, market-entrance save, Hyrule Field, child and adult Link: press, run, stop ends it (back to the plain run); a press while standing holds 90 frames; rolls, a U-turn, the game's pause (stick held or let go), the focus lost and a load keep it; the next press, ZL and an event end it; Hold mode and an options file from before (Toggle comes up on) as expected. Each start and end read from the game's log with Link's state id. Not in the game: attack, item, climb, talk and Insert (no sword or items in the repo's saves; the bridge can't open Insert).

Tested in game: Windows 11, RTX 5080 (driver 621.24), built from 297ebed5 over the shared base of main @ dd5ffe6a2, headless through the job queue and the control bridge, market-entrance save, Hyrule Field, child and adult Link: press, run, stop ends it (back to the plain run); a press while standing holds 90 frames; rolls, a U-turn, the game's pause (stick held or let go), the focus lost and a load keep it; the next press, ZL and an event end it; Hold mode and an options file from before (Toggle comes up on) as expected. Each start and end read from the game's log with Link's state id. Not in the game: attack, item, climb, talk and Insert (no sword or items in the repo's saves; the bridge can't open Insert).
Author
Member

The whole suite (tests/run_all.py, Windows 11, clang from the builder's llvm-mingw) on main @ dd5ffe6a2 and on this branch @ 297ebed5: 717 passed, 97 failed, 135 skipped on both, the same 97. None fails only here. They are this PC's setup (no Vulkan headers, fixtures that fall back to a missing g++, and the like), not this change:

test_appimage_player_build.py test_auto_handheld.py test_bug_report_defaults.py test_build_long_paths.py 
test_capture_read_once.py test_close_waits_for_save.py test_cmpflags.py test_compile_retry_jobs.py 
test_compile_stops_on_exception.py test_compile_zero_byte.py test_crash_dialog.py test_crash_record.py 
test_crt_options.py test_damage_debug_menu.py test_damaged_rom_files.py test_dev_build.py test_dev_migrate.py 
test_dev_packs.py test_device_lost_exit.py test_discover.py test_display_startup_failure.py test_dlss_feature_size.py 
test_failed_compile_keeps_objects.py test_fastfp_fma.py test_finish_output.py test_flush_nothing_held.py 
test_fma_soft.py test_fpx_sticky.py test_fpxkeep.py test_frame_overlap.py test_framegen_preset.py 
test_fs_save_commit.py test_game_menu_mouse_buttons.py test_gpu_wait_stats.py test_guest_copies.py 
test_guest_imported.py test_hdr_encode.py test_high_fps_fixes.py test_host_guest_writes.py test_input_background.py 
test_input_movie.py test_intel_prepare_side_by_side.py test_libc_hooks.py test_lift_cache.py 
test_lift_cleanup_error.py test_lift_lookups.py test_linux_preflight.py test_linux_pressure.py test_long_paths.py 
test_lower_atomg_cas.py test_make_game_cache.py test_make_game_ngx.py test_menu_env_overrides.py test_menu_i18n.py 
test_menu_modules.py test_menu_slider_ends.py test_menu_text_field.py test_mesh_conv.py test_mise_build.py 
test_missing_nup.py test_mods_list.py test_ngx_sdk.py test_oot_shadow_fit.py test_pads_after_menu.py 
test_pending_guest_import.py test_perf_report.py test_pipeline_play_cache.py test_prepare_cache_save.py 
test_prepare_stall.py test_present_ahead.py test_present_device_loss.py test_profiling_mode.py 
test_psychov35_fsr3_fg.py test_readback_timeout_source.py test_reflex_swapchain_lifetime.py 
test_renderer_new_handler.py test_renhdrum.py test_rumble_menu.py test_run_all_mingw.py test_run_all_output.py 
test_sdiv_overflow.py test_slow_frames.py test_song_note_cue.py test_sparse_mirror.py test_spawn_emit.py 
test_submit_oom.py test_switch_table.py test_tls_objects.py test_upscaler_round_trip.py test_upscaler_rows.py 
test_vbytes.py test_vcore_escape.py test_vcore_mask0.py test_vecfp.py test_vfpx_elem.py test_walk.py 
test_xinput_thread.py 

🤖 Generated with Claude Code

The whole suite (`tests/run_all.py`, Windows 11, clang from the builder's llvm-mingw) on `main` @ dd5ffe6a2 and on this branch @ 297ebed5: 717 passed, 97 failed, 135 skipped on both, the same 97. None fails only here. They are this PC's setup (no Vulkan headers, fixtures that fall back to a missing g++, and the like), not this change: ``` test_appimage_player_build.py test_auto_handheld.py test_bug_report_defaults.py test_build_long_paths.py test_capture_read_once.py test_close_waits_for_save.py test_cmpflags.py test_compile_retry_jobs.py test_compile_stops_on_exception.py test_compile_zero_byte.py test_crash_dialog.py test_crash_record.py test_crt_options.py test_damage_debug_menu.py test_damaged_rom_files.py test_dev_build.py test_dev_migrate.py test_dev_packs.py test_device_lost_exit.py test_discover.py test_display_startup_failure.py test_dlss_feature_size.py test_failed_compile_keeps_objects.py test_fastfp_fma.py test_finish_output.py test_flush_nothing_held.py test_fma_soft.py test_fpx_sticky.py test_fpxkeep.py test_frame_overlap.py test_framegen_preset.py test_fs_save_commit.py test_game_menu_mouse_buttons.py test_gpu_wait_stats.py test_guest_copies.py test_guest_imported.py test_hdr_encode.py test_high_fps_fixes.py test_host_guest_writes.py test_input_background.py test_input_movie.py test_intel_prepare_side_by_side.py test_libc_hooks.py test_lift_cache.py test_lift_cleanup_error.py test_lift_lookups.py test_linux_preflight.py test_linux_pressure.py test_long_paths.py test_lower_atomg_cas.py test_make_game_cache.py test_make_game_ngx.py test_menu_env_overrides.py test_menu_i18n.py test_menu_modules.py test_menu_slider_ends.py test_menu_text_field.py test_mesh_conv.py test_mise_build.py test_missing_nup.py test_mods_list.py test_ngx_sdk.py test_oot_shadow_fit.py test_pads_after_menu.py test_pending_guest_import.py test_perf_report.py test_pipeline_play_cache.py test_prepare_cache_save.py test_prepare_stall.py test_present_ahead.py test_present_device_loss.py test_profiling_mode.py test_psychov35_fsr3_fg.py test_readback_timeout_source.py test_reflex_swapchain_lifetime.py test_renderer_new_handler.py test_renhdrum.py test_rumble_menu.py test_run_all_mingw.py test_run_all_output.py test_sdiv_overflow.py test_slow_frames.py test_song_note_cue.py test_sparse_mirror.py test_spawn_emit.py test_submit_oom.py test_switch_table.py test_tls_objects.py test_upscaler_round_trip.py test_upscaler_rows.py test_vbytes.py test_vcore_escape.py test_vcore_mask0.py test_vecfp.py test_vfpx_elem.py test_walk.py test_xinput_thread.py ``` 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Author
Member

@Beanstalk build and start on Linux, then Sprint On with its Toggle on (the default): press Sprint and run, stop (back to the plain run), and open and close the pause menu mid-sprint (still sprinting after).

@Beanstalk build and start on Linux, then Sprint On with its Toggle on (the default): press Sprint and run, stop (back to the plain run), and open and close the pause menu mid-sprint (still sprinting after).
Member

Beanstalk test farm

Commit 56a6972 · approved by nobody yet · dashboard

A member of BigBeans can review this commit and comment @Beanstalk to test it.

<!-- beanstalk:sticky --> ### Beanstalk test farm Commit `56a6972` · approved by nobody yet · [dashboard](https://beanstalk.magicbean.dev/prs/2168) A member of `BigBeans` can review this commit and comment `@Beanstalk` to test it.
Author
Member
@review
BeanBot left a comment

Recommendation: Request changes. The new pause detection can leave Sprint armed indefinitely after the game resumes, and the Sprint row’s reset control cannot restore its new default in a common case.

Sprint Toggle now follows Link’s movement and survives menus, focus loss, pauses and loads; it also becomes the default when Sprint is enabled. The change adds state tracking and changes existing Hold users to Toggle on upgrade.

@fix will do (4)

  1. L1 host/oot_sprint.c:263: Unchanged position and state do not establish that the pause is still open. (more on the line)
  2. L2 gpu/vk/vk_menu.cpp:5337: The reset action now restores Sprint Toggle to on, but control_column_enabled still enables the reset cell when the toggle is on instead of when it differs from its default. (more on the line)
  3. L5: The check Guide screenshots / Guide images and local UI source review (pull_request) fails on this head and passes on the base branch: Failing after 34s.
  4. L6: The check CI / Website build and checks (pull_request) fails on this head and passes on the base branch: Failing after 35s.

Before merging: testing (2) (runs on the systems it can change; it doesn't hold the recommendation)

  • L3 (minor) host/nn_hid.c:1656: The reported bridge run does not exercise physical keyboard or controller input, Insert, or the untested action transitions. (more on the line)
  • L4 (minor) host/nn_hid.c:1656: The Linux host build and controller game run remain outstanding. (more on the line)
More: does it help, other systems, switches, what was read

Does it help: Unproven for the reported issue: the author could not reproduce its exact case on main. The reported Windows game run shows the new stop, pause and focus behavior in the tested field scenarios, but physical input and several actions remain untested.

Other systems: The input and Link update paths affect Windows and Linux, keyboard, controllers, background input, the control bridge and Hold mode. The reported run used the bridge on Windows; physical controls and the Linux build and game run remain outstanding. No renderer or GPU-specific code changed.

Switches: No environment switches added, changed or removed. The saved Sprint Toggle option changes from off to on by default; version 6 and older files are migrated to on, including players previously using Hold. The Sprint feature itself remains off by default.

Reviewed: 297ebed56b against dd5ffe6a29: Read the repository rules and PR template, commit messages, changed host logic, menu migration and reset code, and the relevant test and input call sites. Skimmed the translated strings and guide changes. The full large menu and HID files and the unchanged portions of the tests were not read in full; Tooling’s AGENTS.md was unavailable in the checkout.; nothing run (a code review).

Checked and fine:

  • Both commits record AI assistance.
  • No game files, generated shader files, third-party files or renderer API definitions appear in the diff.
  • The reported Windows bridge run covers child and adult movement, stopping, ZL, pause, focus loss and an event.
  • The two head-only CI failures are already recorded in the supplied CI results.

Testing: Read-only review; no builds, tests or project scripts were run. The author reports Windows bridge runs and game-free checks; physical Windows input and Linux remain to be tested.

Overlaps and merge order: none found


Automated code review by BeanBot (gpt-6.1-terra), asked for by llun. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** The new pause detection can leave Sprint armed indefinitely after the game resumes, and the Sprint row’s reset control cannot restore its new default in a common case. Sprint Toggle now follows Link’s movement and survives menus, focus loss, pauses and loads; it also becomes the default when Sprint is enabled. The change adds state tracking and changes existing Hold users to Toggle on upgrade. **`@fix` will do (4)** 1. **L1** `host/oot_sprint.c:263`: Unchanged position and state do not establish that the pause is still open. (more on the line) 2. **L2** `gpu/vk/vk_menu.cpp:5337`: The reset action now restores Sprint Toggle to on, but control_column_enabled still enables the reset cell when the toggle is on instead of when it differs from its default. (more on the line) 3. **L5**: The check `Guide screenshots / Guide images and local UI source review (pull_request)` fails on this head and passes on the base branch: Failing after 34s. 4. **L6**: The check `CI / Website build and checks (pull_request)` fails on this head and passes on the base branch: Failing after 35s. **Before merging: testing (2)** (runs on the systems it can change; it doesn't hold the recommendation) - **L3** (minor) `host/nn_hid.c:1656`: The reported bridge run does not exercise physical keyboard or controller input, Insert, or the untested action transitions. (more on the line) - **L4** (minor) `host/nn_hid.c:1656`: The Linux host build and controller game run remain outstanding. (more on the line) <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Unproven for the reported issue: the author could not reproduce its exact case on main. The reported Windows game run shows the new stop, pause and focus behavior in the tested field scenarios, but physical input and several actions remain untested. **Other systems:** The input and Link update paths affect Windows and Linux, keyboard, controllers, background input, the control bridge and Hold mode. The reported run used the bridge on Windows; physical controls and the Linux build and game run remain outstanding. No renderer or GPU-specific code changed. **Switches:** No environment switches added, changed or removed. The saved Sprint Toggle option changes from off to on by default; version 6 and older files are migrated to on, including players previously using Hold. The Sprint feature itself remains off by default. **Reviewed:** 297ebed56b93 against dd5ffe6a2907: Read the repository rules and PR template, commit messages, changed host logic, menu migration and reset code, and the relevant test and input call sites. Skimmed the translated strings and guide changes. The full large menu and HID files and the unchanged portions of the tests were not read in full; Tooling’s AGENTS.md was unavailable in the checkout.; nothing run (a code review). **Checked and fine:** - Both commits record AI assistance. - No game files, generated shader files, third-party files or renderer API definitions appear in the diff. - The reported Windows bridge run covers child and adult movement, stopping, ZL, pause, focus loss and an event. - The two head-only CI failures are already recorded in the supplied CI results. **Testing:** Read-only review; no builds, tests or project scripts were run. The author reports Windows bridge runs and game-free checks; physical Windows input and Linux remain to be tested. **Overlaps and merge order:** none found </details> --- <sub>Automated code review by BeanBot (gpt-6.1-terra), asked for by llun. Nothing was run; a maintainer decides.</sub>
@ -5327,3 +5335,3 @@
if (host->reset_binding(button)) {
blocked_reset_row = -1;
if (has_toggle(button)) toggle_set(button, false);
if (has_toggle(button)) toggle_set(button, toggle_default(button));
Member

L2: The reset action now restores Sprint Toggle to on, but control_column_enabled still enables the reset cell when the toggle is on instead of when it differs from its default. With default Sprint bindings and Toggle off, the reset arrow is disabled, so a player cannot restore its default through the row; with Toggle on it remains enabled even when everything is already default. Compare the toggle with toggle_default in the enable predicate and exercise the real predicate in the test.

**L2**: The reset action now restores Sprint Toggle to on, but control_column_enabled still enables the reset cell when the toggle is on instead of when it differs from its default. With default Sprint bindings and Toggle off, the reset arrow is disabled, so a player cannot restore its default through the row; with Toggle on it remains enabled even when everything is already default. Compare the toggle with toggle_default in the enable predicate and exercise the real predicate in the test.
@ -1652,0 +1653,4 @@
const int sprint_reset = InterlockedExchange(&sprint_reset_pending, 0);
/* (away: the player's input does not reach the game, Insert open or the focus lost with no pads behind other
windows; a test run's own input, which keeps the player out, reaches it behind them) */
const int sprint_away = menu_open || (!sprint_excluded && !sprint_front && !pads_behind);
Member

L3 (minor): The reported bridge run does not exercise physical keyboard or controller input, Insert, or the untested action transitions. Run the described Windows keyboard and controller checks, including attack, item, climb, talk and menu entry and exit.

**L3** (minor): The reported bridge run does not exercise physical keyboard or controller input, Insert, or the untested action transitions. Run the described Windows keyboard and controller checks, including attack, item, climb, talk and menu entry and exit.
Member

L4 (minor): The Linux host build and controller game run remain outstanding. Verify Sprint start, stop, pause and resume on Linux as requested in the pull request.

**L4** (minor): The Linux host build and controller game run remain outstanding. Verify Sprint start, stop, pause and resume on Linux as requested in the pull request.
@ -172,0 +260,4 @@
if (__atomic_exchange_n(&pause_pressed, 0, __ATOMIC_RELAXED) && LOAD(toggled) && on) paused = 1, pause_wait = 0;
if (paused == 1 && !frozen && (pause_wait += frame_step_frames()) > PAUSE_OPEN_FRAMES) paused = 0;
if (paused && frozen && on && LOAD(toggled)) {
paused = 2, moved = 0, wait_frames = 0;
Member

L1: Unchanged position and state do not establish that the pause is still open. If Link is standing when the pause closes, this branch continues returning indefinitely: the 90-frame grace never counts down, Sprint presses are discarded, and ZL is ignored until Link moves or changes state. Use an actual pause/menu signal to distinguish a closed pause from stationary gameplay, and test closing it without changing Link’s state or position.

**L1**: Unchanged position and state do not establish that the pause is still open. If Link is standing when the pause closes, this branch continues returning indefinitely: the 90-frame grace never counts down, Sprint presses are discarded, and ZL is ignored until Link moves or changes state. Use an actual pause/menu signal to distinguish a closed pause from stationary gameplay, and test closing it without changing Link’s state or position.
Author
Member
@fix
fix(input): bound sprint pause hold and restore reset defaults
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 11s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 19s
CI / Workflow lint (actionlint) (pull_request) Successful in 22s
CI / Website build and checks (pull_request) Failing after 24s
Third-party parts / As their notes say (pull_request) Successful in 26s
PR description / Description follows the template (pull_request_target) Failing after 11s
beanstalk/approval not approved yet
56a69721c6
As the review on #2168 asked.
BeanBot left a comment

Recommendation: Approve. The code is ready: only testing is left. The reported game run shows the main sprint behavior working, but physical input and the Linux build and controller run remain unverified. Recommend approval; not approved on the forge.

What @fix changed
I changed this pull request: the new head is 56a69721c6. It was already up to date with main. I edited its description to match the change.

Changed

  • Website graphics settings build: Updated docs/user/graphics-and-controls.md:116 and website/src/repo-docs/graphics-settings.ts:259 to account for the ReShade actions and selector; added coverage in website/tests/graphics-settings.test.ts:129. No checks were run.
  • gpu/vk/vk_menu.cpp:1667: Compare each Toggle with its default in the reset predicate and exercise the real predicate in tests/test_menu_keys.py:111. Tests were not run.
  • Detect pause closure while Link is stationary: host/oot_menu.c:18 supplies pause and panel screen updates on Windows and Linux; host/oot_sprint.c:246 uses them to release Sprint when the menu closes. tests/test_sprint.py:500 covers a long pause, stationary closure, Sprint, ZL and the grace period. Tests were not run, as requested.

Not done

  • Guide screenshot source review: The affected screenshot and changed UI sources still need comparison before their review fingerprints can be updated. The CI check remains open.

Nothing was built or run: the checks run again on the new head.

Sprint Toggle follows Link’s state, survives menus and focus loss, and defaults to on when Sprint is enabled. It adds state and menu tracking, and existing players who prefer Hold must select it again.

Before merging: testing (2) (runs on the systems it can change; it doesn't hold the recommendation)

  • L3 (minor) host/nn_hid.c:1656: The reported bridge run does not exercise physical keyboard or controller input, Insert, or the untested action transitions. Run the described Windows keyboard and controller checks, including attack, item, climb, talk and menu entry and exit.
  • L4 (minor) host/nn_hid.c:1656: The Linux host build and controller game run remain outstanding. Verify Sprint start, stop, pause and resume on Linux as requested in the pull request.

Checks: they run again on this head (Guide screenshots / Guide images and local UI source review (pull_request), CI / Website build and checks (pull_request) failed on the last one); a failure shows on the pull request.

Also noticed (5; not asked for, not blocking)
  • The website graphics-settings changes address ReShade rows alongside the Sprint change.
  • The fix report mentions a guide screenshot review whose result is not supplied.
  • The pull request description still describes detecting pause from Link’s frozen state and position, although the code now uses menu screen updates.
  • The recorded user-guide screenshot source review remains outstanding.
  • CI has not yet run on this head.
More: does it help, other systems, switches, what was read

Does it help: Yes for the tested paths: the reported Windows bridge run shows sprint ending on a stop and surviving pause and focus loss. Physical input and several action transitions have not yet been checked in game.

Other systems: The input and menu hooks run on Windows and Linux and affect keyboard and controller input. Windows bridge results cover part of the behavior; the physical input and Linux paths remain outstanding. The change also updates the website’s settings reader.

Switches: No environment switch added or changed. Sprint remains off by default; its Toggle now defaults to on, including for options files from version 6 and earlier. Hold remains selectable.

Reviewed: 56a69721c6 against dd5ffe6a29: Read AGENTS.md, CONTRIBUTING.md, the pull request template, host/oot_sprint.c and the relevant input, menu and website reader code. Reviewed the diff and skimmed translations and test changes; the large changed files and tests were not all read in full.; nothing run (a code review).

Checked and fine:

  • The reset predicate compares each control’s Toggle with its own default.
  • The pause and panel screen hooks are present on both Windows and Linux.

Testing: No commands that build or run tests were executed. The author reports a Windows bridge run and the same 97 suite failures on the base and branch; physical Windows input and Linux verification remain outstanding.

Overlaps and merge order: none found


Automated code review by BeanBot (gpt-6.1-terra), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.

**Recommendation: Approve.** The code is ready: only testing is left. The reported game run shows the main sprint behavior working, but physical input and the Linux build and controller run remain unverified. Recommend approval; not approved on the forge. **What `@fix` changed** I changed this pull request: the new head is 56a69721c655. It was already up to date with `main`. I edited its description to match the change. **Changed** - **Website graphics settings build**: Updated docs/user/graphics-and-controls.md:116 and website/src/repo-docs/graphics-settings.ts:259 to account for the ReShade actions and selector; added coverage in website/tests/graphics-settings.test.ts:129. No checks were run. - **gpu/vk/vk_menu.cpp:1667**: Compare each Toggle with its default in the reset predicate and exercise the real predicate in tests/test_menu_keys.py:111. Tests were not run. - **Detect pause closure while Link is stationary**: host/oot_menu.c:18 supplies pause and panel screen updates on Windows and Linux; host/oot_sprint.c:246 uses them to release Sprint when the menu closes. tests/test_sprint.py:500 covers a long pause, stationary closure, Sprint, ZL and the grace period. Tests were not run, as requested. **Not done** - **Guide screenshot source review**: The affected screenshot and changed UI sources still need comparison before their review fingerprints can be updated. The CI check remains open. Nothing was built or run: the checks run again on the new head. Sprint Toggle follows Link’s state, survives menus and focus loss, and defaults to on when Sprint is enabled. It adds state and menu tracking, and existing players who prefer Hold must select it again. **Before merging: testing (2)** (runs on the systems it can change; it doesn't hold the recommendation) - **L3** (minor) `host/nn_hid.c:1656`: The reported bridge run does not exercise physical keyboard or controller input, Insert, or the untested action transitions. Run the described Windows keyboard and controller checks, including attack, item, climb, talk and menu entry and exit. - **L4** (minor) `host/nn_hid.c:1656`: The Linux host build and controller game run remain outstanding. Verify Sprint start, stop, pause and resume on Linux as requested in the pull request. **Checks:** they run again on this head (`Guide screenshots / Guide images and local UI source review (pull_request)`, `CI / Website build and checks (pull_request)` failed on the last one); a failure shows on the pull request. <details> <summary>Also noticed (5; not asked for, not blocking)</summary> - The website graphics-settings changes address ReShade rows alongside the Sprint change. - The fix report mentions a guide screenshot review whose result is not supplied. - The pull request description still describes detecting pause from Link’s frozen state and position, although the code now uses menu screen updates. - The recorded user-guide screenshot source review remains outstanding. - CI has not yet run on this head. </details> <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Yes for the tested paths: the reported Windows bridge run shows sprint ending on a stop and surviving pause and focus loss. Physical input and several action transitions have not yet been checked in game. **Other systems:** The input and menu hooks run on Windows and Linux and affect keyboard and controller input. Windows bridge results cover part of the behavior; the physical input and Linux paths remain outstanding. The change also updates the website’s settings reader. **Switches:** No environment switch added or changed. Sprint remains off by default; its Toggle now defaults to on, including for options files from version 6 and earlier. Hold remains selectable. **Reviewed:** 56a69721c655 against dd5ffe6a2907: Read AGENTS.md, CONTRIBUTING.md, the pull request template, host/oot_sprint.c and the relevant input, menu and website reader code. Reviewed the diff and skimmed translations and test changes; the large changed files and tests were not all read in full.; nothing run (a code review). **Checked and fine:** - The reset predicate compares each control’s Toggle with its own default. - The pause and panel screen hooks are present on both Windows and Linux. **Testing:** No commands that build or run tests were executed. The author reports a Windows bridge run and the same 97 suite failures on the base and branch; physical Windows input and Linux verification remain outstanding. **Overlaps and merge order:** none found </details> --- <sub>Automated code review by BeanBot (gpt-6.1-terra), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.</sub>
HumanBean changed title from WIP: feat(input): Sprint's Toggle arms and disarms from Link's state, on by default to feat(input): Sprint's Toggle arms and disarms from Link's state, on by default 2026-11-22 00:16:38 +00:00
HumanBean deleted branch feat/sprint-toggle-link-state 2026-11-22 00:16:59 +00:00
Author
Member

Replies to BeanBot's review (00:08), checked against main @ 9e10f6f72, which holds this PR as a053f9e12 (the review's fix commit 56a69721 included, unchanged but for one test line from #2171):

L1, pausing can leave Sprint armed. Leaving it armed through a pause is the design. The rules come from Hotoni's description of their sprint mod: "Menus, a pause or losing focus do NOT cancel it: it is decided from Link's state, not from the input layer." The real defect inside the point was right, though: with the hold keyed to Link's state and place being frozen, a pause closed with Link standing still kept holding, so the 90-frame grace never ran and a Sprint press or ZL did nothing until he moved. 56a69721 fixed that, and it is on main. The hold now follows the pause menu's and the panel's own screen updates (host/oot_menu.c, sprint_menu_tick) and ends at Link's first update after they stop; from there the grace counts down, and presses and ZL work again (tests/test_sprint.py closes a pause with Link standing still).

L2, the row's reset control. Fixed in 56a69721, on main: control_column_enabled compares Sprint's Toggle with toggle_default (gpu/vk/vk_menu.cpp:1672), and tests/test_menu_keys.py runs the real predicate. It passes with clang++ on Windows.

L3, physical input and the untested actions. The user played 85e4cfef by hand on Windows 11 with an RTX 5080. In its log, each press started a toggled sprint and the next ended it; a jump attack ended it (Link's state 114), ZL ended it twice, and Link stopping ended one started by a press while standing. No sprint ended while a menu was open. Items, climbing, talking and Insert don't appear in that log, so they stay to test by hand. Earlier, the headless bridge runs covered stop, grace, rolls, a U-turn, pause, focus loss, the next press, ZL and an event for child and adult Link. They ran on the version before 56a69721, so that commit's screen signal had the hand test only.

L4, Linux. Not run. Beanstalk said the farm can't turn Sprint on, so the Linux build and a controller run stay with a person on Linux.

L5, the guide screenshots check. It fails the same way on main @ 9e10f6f72 (10 entries for settings-graphics.png, including sources this PR doesn't touch, like gpu/vk/vk_texture.h and gpu/vk/device_policy.h): its review hashes are stale on main. The job runs only on pull requests that touch those sources, which is why it showed here. It needs a person to review the picture and record new hashes; the check won't do that itself.

L6, the website build. 56a69721 taught the settings page's parser the ReShade rows that broke it, and #2171 brought main's website build back to passing.

🤖 Generated with Claude Code

Replies to BeanBot's review (00:08), checked against `main` @ 9e10f6f72, which holds this PR as a053f9e12 (the review's fix commit 56a69721 included, unchanged but for one test line from #2171): **L1, pausing can leave Sprint armed.** Leaving it armed through a pause is the design. The rules come from Hotoni's description of their sprint mod: *"Menus, a pause or losing focus do NOT cancel it: it is decided from Link's state, not from the input layer."* The real defect inside the point was right, though: with the hold keyed to Link's state and place being frozen, a pause closed with Link standing still kept holding, so the 90-frame grace never ran and a Sprint press or ZL did nothing until he moved. 56a69721 fixed that, and it is on `main`. The hold now follows the pause menu's and the panel's own screen updates (`host/oot_menu.c`, `sprint_menu_tick`) and ends at Link's first update after they stop; from there the grace counts down, and presses and ZL work again (`tests/test_sprint.py` closes a pause with Link standing still). **L2, the row's reset control.** Fixed in 56a69721, on `main`: `control_column_enabled` compares Sprint's Toggle with `toggle_default` (`gpu/vk/vk_menu.cpp:1672`), and `tests/test_menu_keys.py` runs the real predicate. It passes with clang++ on Windows. **L3, physical input and the untested actions.** The user played 85e4cfef by hand on Windows 11 with an RTX 5080. In its log, each press started a toggled sprint and the next ended it; a jump attack ended it (`Link's state 114`), ZL ended it twice, and Link stopping ended one started by a press while standing. No sprint ended while a menu was open. Items, climbing, talking and Insert don't appear in that log, so they stay to test by hand. Earlier, the headless bridge runs covered stop, grace, rolls, a U-turn, pause, focus loss, the next press, ZL and an event for child and adult Link. They ran on the version before 56a69721, so that commit's screen signal had the hand test only. **L4, Linux.** Not run. Beanstalk said the farm can't turn Sprint on, so the Linux build and a controller run stay with a person on Linux. **L5, the guide screenshots check.** It fails the same way on `main` @ 9e10f6f72 (10 entries for `settings-graphics.png`, including sources this PR doesn't touch, like `gpu/vk/vk_texture.h` and `gpu/vk/device_policy.h`): its review hashes are stale on `main`. The job runs only on pull requests that touch those sources, which is why it showed here. It needs a person to review the picture and record new hashes; the check won't do that itself. **L6, the website build.** 56a69721 taught the settings page's parser the ReShade rows that broke it, and #2171 brought `main`'s website build back to passing. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!2168
No description provided.