fix(build): prefer llvm-nm for symbol version checks #2087
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!2087
Loading…
Reference in a new issue
No description provided.
Delete branch "0xadb/Longshot:fix/linux-versioned-nm-imports"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
On openSUSE, GNU
nmomits libc symbol version suffixes in the import output used by the VK symbol check. The build then treats valid libc imports as unresolved and stops with hundreds of false errors. Preferllvm-nmwhen available, retaining GNUnmas the fallback. The added regression test covers both tool selection and fallback behavior. See #267 for an earlier, broaderreadelf-first approach to the same symbol-version issue; this PR records the successful launcher build usingllvm-nm.Testing
Tested: openSUSE Tumbleweed-Slowroll, NVIDIA GeForce RTX 4090, NVIDIA 620.70.06: built the stable v3.0.0 game with
llvm-nmselected, then launched it successfully. The launcher build completed and the game process started.Still to test:
mise run testsuite: rerun on this branch and currentmainto identify pre-existing failures (by hand).Focused regression test:
python3 -I -B tests/test_vk_symbol_check.py(2 tests passed). The regression test was also run against currentmainand reproduced the false unresolvedmallocimport.Measurements
Verdict: no runtime or performance change; this only selects which symbol-inspection utility runs during the build. The regression test reproduces the false positive on
mainand passes with this fix.1dbf91508ec5da5834mallocunresolved with GNUnmoutputllvm-nmoutput preservingmalloc@GLIBC_2.2.5; GNUnmremains a fallbackRisks
The build uses
llvm-nmwhen installed; systems without it continue usingnm. The selected utility only affects the build-time symbol check. It does not change game code, output binaries, saves, options or runtime behavior. If a platform'sllvm-nmoutput differs unexpectedly, the regression check will need to be adjusted for that supported output.Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named).main, or Measurements says why there is nothing to measure.third_party/untouched; nothing GPL-incompatible.When it applies
mainand passes here.tests/that reads changed source is updated, not weakened.Ready to merge
main, measured again or a comment says why the numbers still hold.Tested in game: openSUSE Tumbleweed-Slowroll, NVIDIA GeForce RTX 4090, NVIDIA 620.70.06: Launcher stable v3.0.0 build completed with llvm-nm selected, and the game process started successfully.
Possibly related, for context:
ed2860e554c5da58344dWIP: fix(build): prefer llvm-nm for symbol version checksto fix(build): prefer llvm-nm for symbol version checks