WIP: perf(vk): a descriptor build asks its diagnostics' switches once, not at every texture binding #2057
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!2057
Loadingโฆ
Reference in a new issue
No description provided.
Delete branch "siantm/Longshot:perf/vk-desc-diag-once"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Every texture and image binding in
build_descriptors(gpu/vk/vk_draw.cpp) asked five things that are the same for the whole build and off in play:dump_on(twice),log_img_wanted(asnprintfof the program's key whenRX_VK_LOG_IMGis set),watch_prog, andtrace_tex_wanted, which walked its list even withRX_VK_TRACE_TEXunset. The build now asks them once before its first stage (trace_tex_onreadsRX_VK_TRACE_TEXonce) and the loops read the answers. The same diagnostics when they are on; the result expected is less work a binding.No switch; a revert gives back main's code.
From 2816697a on
exp/x86-asm-sync.Read first: the answers made before the stage loop of
build_descriptorsandtrace_tex_oningpu/vk/vk_draw.cpp.Testing
Tested: Windows 11, i7-9700, RTX 4060, the builder's llvm-mingw clang 23; head
4827e543on main @75317e1f. Every check ran throughtests/run_all.py --strict --exactin build jobs of the PC's job queue, in a hidden console (logt-dc3-vk-desc-diag-once):tests/test_desc_diag_once.py(new: the answers made once before the stage loop, none of the calls left in the texture and image loops): pass.--changed 75317e1f; its own are among them): 142 passed, 19 failed. Failed:tests/test_sampler_admission.py,tests/test_fsr_uniform_ownership.py,tests/test_pipeline_play_cache.py,tests/test_draw_stream_visibility.py,tests/test_device_lost_exit.py,tests/test_dev_packs.py,tests/test_draw_binds.py,tests/test_frame_overlap.py,tests/test_linux_pressure.py,tests/test_mesh_conv.py,tests/test_prepare_cache_save.py,tests/test_recorder_own_idle.py,tests/test_upscaler_rows.py,tests/test_vk_occlusion_queries.py: each fails on main @75317e1ftoo (the same checks on main in the same queue batch, logt-dc3-base).tests/test_recording_admission.pyfails on main @75317e1ftoo, now and then: its "worker slot ownership" case failed on main in 7 of 10 runs made alternately with this branch's (logst-dc5-base-ra-*), with the same message.tests/test_jobs_wait_runs_queued.py,tests/test_fallback_buffer_cleanup.py,tests/test_mesh_args_cleanup.pyandtests/test_pipeline_cache_save.pyalso failed in that run, each stopped at its 60-second limit, and passed when run again on this head (logt-dc4-vk-desc-diag-once).It has NOT run in the game on this PC yet.
Still to test:
75317e1fagainst this PR, each warmed a minute in the scene first, then interleaved (main, this PR, this PR, main), two runs each, expecting the same picture and the replay's time a frame the same as or lower than main's; then once withRX_VK_TRACE_TEXandRX_VK_LOG_IMGset, expecting their log lines as on main (by hand)tests/test_desc_diag_once.pywith--cxx g++and--cxx clang++, expecting PASS (by hand)Measurements
Verdict: a build with 8-32 texture bindings takes 2.5-3.5x less time in its diagnostics' asks (45-188 ns less a build), with one texture 1.24-1.33x (2-3 ns); a build with no texture or image binding is 2.7-3.1 ns slower (0.47-0.50x: the four asks made once and not needed). A micro-benchmark on authored input; not measured in play.
Micro-benchmark (
vk_desc_diag_once_bench.py: a script on this PC, not in this PR): the switches' functions cut out ofvk_draw.cppandvk_dump.hand compiled in the same file as the bindings, as in the build; the bindings' diagnostic lines as each side has them, every switch unset as in play; the rest of a binding an authored view lookup; 512 builds a repetition; three rounds run alone in this PC's job queue (2026-11-22, 01:21-01:23 UTC; logbench-vk-walks.log), the builder's llvm-mingw clang 23.1.5 at -O2 for baseline x86-64 and at -O2 -march=native (this PC's i7-9700, as the game is built here), 301 repetitions a case, old and new taking turns on the same authored inputs, their results equal at every repetition. Each cell: ns per build, the median of the three rounds' medians, in parentheses the lowest and highest of them; ฮ: old over new (above 1, this PR is quicker).75317e1f4827e543Risks
A diagnostic whose answer changes during one build (a frame dump that starts in the middle of a build) is now seen from the next build on: a dump could miss one build's bindings. In play all of them are off. A revert is enough (no switch). The renderer is compiled again after updating.
Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named). Not yet: only the checks in Testing ran.main, or Measurements says why there is nothing to measure. Not yet (Measurements).third_party/untouched; nothing GPL-incompatible.When it applies
Assisted-by:/Co-Authored-By:trailers.@Beanstalk This changes the renderer's descriptor builds so their diagnostic is checked once (gpu/vk). No switch: a revert gives back main's code. It has not run in the game on these PCs yet. Please play Kokiri Forest and Hyrule Field, two minutes each, the PR against main on the same PC, with a picture in each compared with main's, on Linux with NVIDIA, Linux with AMD (RADV), Windows with Intel and the Steam Deck. The same picture as main, no crash, device lost, validation error or FATAL line; frame time p99 equal to main's or better, within the run-to-run spread.
@siantm only members of
BigBeanscan start the farm. One of them can approve this request by reacting ๐ to it or to this comment.@Beanstalk This replaces my request 65771 on this head, so that it follows the farm's picture and hardware rules. This makes a descriptor build ask its diagnostics' switches once instead of at every texture binding (gpu/vk). No switch: a revert gives back main's code. Please start from the kokiri-start save and take the picture right after it loads and settles, before any input, with a main-against-itself picture on the same PC at that point; then, for frame times only, play Kokiri Forest and Hyrule Field, two minutes each; at least two starts a side, interleaved, the PR against main on the same PC, on Windows with an RTX 4070, Windows with an Arc B580, Linux with an RX 6600 (RADV) and the Steam Deck. The same picture as main within main's own difference from itself; frame time p99 equal to main's or better, within the run-to-run spread. The log must have no FATAL, device lost or validation error line.
@siantm only members of
BigBeanscan start the farm. One of them can approve this request by reacting ๐ to it or to this comment.Measurements: a micro-benchmark on authored input (old against new, three rounds, x86-64 baseline and -march=native; not measured in play) and the Verdict rewritten to match.
@Beanstalk One correction to my request 69702 above, for its picture point: please take each picture 5 s (300 frames at 60 fps) after the first frame whose picture is not a single uniform colour, with no input in between, and take the main-against-itself picture from the same point. A picture taken during the load's fade-in from black is not comparable: run 70269 on #2156 caught the fade in 3 of 4 starts.
@siantm only members of
BigBeanscan start the farm. One of them can approve this request by reacting ๐ to it or to this comment.View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.