WIP: perf(vk): a program keeps its vertex stage's place for vertex_info #2056
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!2056
Loading…
Reference in a new issue
No description provided.
Delete branch "siantm/Longshot:perf/vk-vertex-place"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
vertex_info(gpu/vk/vk_draw.cpp: the stage a graphics pipeline's vertex input comes from) walked the program's stages at every draw that missedpipe_fast, reading the first line of each stage (about 840 bytes apart). Its first call now finds the place and keeps it in the program (Program::vertex_at,gpu/vk/vk_shader.h, -1 until looked for); later calls read it. A program's stages never change once it is made, so the answer is the same; the result expected was fewer cache misses a draw, but a micro-benchmark shows no gain in time (Measurements).No switch; a revert gives back main's code.
From f61b2820 on
exp/x86-asm-sync.Read first:
vertex_infoingpu/vk/vk_draw.cppandProgram::vertex_atingpu/vk/vk_shader.h.Testing
Tested: Windows 11, i7-9700, RTX 4060, the builder's llvm-mingw clang 23; head
b92f4ef7on main @75317e1f. Every check ran throughtests/run_all.py --strict --exactin build jobs of the PC's job queue, in a hidden console (logt-dc3-vk-vertex-place):tests/test_vertex_at.py(new: cutsvertex_infoand runs it over 20,000 random stage lists against the scan it was);tests/test_fallback_pipeline_state.pyandtests/test_pipeline_key_values.py(their stand-in Programs gainvertex_at, as they cutvertex_info): pass.--changed 75317e1f; its own are among them): 151 passed, 15 failed. Failed:tests/test_sampler_admission.py,tests/test_fsr_uniform_ownership.py,tests/test_pipeline_play_cache.py,tests/test_draw_stream_visibility.py,tests/test_device_lost_exit.py,tests/test_draw_binds.py,tests/test_dev_packs.py,tests/test_frame_overlap.py,tests/test_linux_pressure.py,tests/test_mesh_conv.py,tests/test_prepare_cache_save.py,tests/test_recorder_own_idle.py,tests/test_upscaler_rows.py,tests/test_vk_occlusion_queries.py: each fails on main @75317e1ftoo (the same checks on main in the same queue batch, logt-dc3-base).tests/test_recording_admission.pyfails on main @75317e1ftoo, now and then: its "worker slot ownership" case failed on main in 7 of 10 runs made alternately with this branch's (logst-dc5-base-ra-*), with the same message.It has NOT run in the game on this PC yet.
Still to test:
75317e1fagainst this PR, each warmed a minute in the scene first, then interleaved (main, this PR, this PR, main), two runs each, expecting the same picture and the replay's time a frame the same as or lower than main's (by hand)tests/test_vertex_at.py,tests/test_fallback_pipeline_state.py,tests/test_pipeline_key_values.pywith--cxx g++and--cxx clang++, expecting PASS (by hand)Measurements
Verdict: no gain: the kept place is slower than the walk in 9 of the 10 cases (0.90-0.97x, 0.8-12 ns a call more) and level in one (cold, vertex third: 1.02x in the baseline build). On these figures the PR saves nothing; it is worth keeping only if the in-game A/B shows a gain, which these figures do not predict. A micro-benchmark on authored input; not measured in play.
Micro-benchmark (
vk_vertex_place_bench.py: a script on this PC, not in this PR):vertex_infocut out ofvk_draw.cppat both commits, followed by whatkey_inputsreads of the Info it gives (the 16 generic loads); vk_shader.h'sStagewith Eden's realShader::Info(848 bytes a stage), the Program with the head'svertex_at; three rounds run alone in this PC's job queue (2026-11-22, 01:21-01:23 UTC; logbench-vk-walks.log), the builder's llvm-mingw clang 23.1.5 at -O2 for baseline x86-64 and at -O2 -march=native (this PC's i7-9700, as the game is built here), 301 repetitions a case, old and new taking turns on the same authored inputs, their results equal at every repetition. Each cell: ns per call, the median of the three rounds' medians, in parentheses the lowest and highest of them; Δ: old over new (above 1, this PR is quicker).75317e1fb92f4ef7Risks
A program whose stages changed after its first draw would keep a stale place: none does (a program is made whole before it is ready). What could show is a draw with the wrong vertex input; a revert is enough (no switch). The renderer is compiled again after updating; no cache or setting changes (the place is not saved with the program).
Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named). Not yet: only the checks in Testing ran.main, or Measurements says why there is nothing to measure. Not yet (Measurements).third_party/untouched; nothing GPL-incompatible.When it applies
tests/that reads changed source is updated, not weakened.Assisted-by:/Co-Authored-By:trailers.@Beanstalk This changes the renderer's pipeline lookups for draws past the fast path (gpu/vk). No switch: a revert gives back main's code. It has not run in the game on these PCs yet. Please play Kokiri Forest and Hyrule Field, two minutes each, the PR against main on the same PC, with a picture in each compared with main's, on Linux with NVIDIA, Linux with AMD (RADV), Windows with Intel and the Steam Deck. The same picture as main, no crash, device lost, validation error or FATAL line; frame time p99 equal to main's or better, within the run-to-run spread.
@siantm only members of
BigBeanscan start the farm. One of them can approve this request by reacting 👍 to it or to this comment.@Beanstalk This replaces my request 65769 on this head, so that it follows the farm's picture and hardware rules. This makes a program keep its vertex stage's place for vertex_info, on the pipeline lookups of draws past the fast path (gpu/vk). No switch: a revert gives back main's code. Please start from the kokiri-start save and take the picture right after it loads and settles, before any input, with a main-against-itself picture on the same PC at that point; then, for frame times only, play Kokiri Forest and Hyrule Field, two minutes each; at least two starts a side, interleaved, the PR against main on the same PC, on Windows with an RTX 4070, Windows with an Arc B580, Linux with an RX 6600 (RADV) and the Steam Deck. The same picture as main within main's own difference from itself; frame time p99 equal to main's or better, within the run-to-run spread. The log must have no FATAL, device lost or validation error line.
@siantm only members of
BigBeanscan start the farm. One of them can approve this request by reacting 👍 to it or to this comment.Measurements: a micro-benchmark on authored input (old against new, three rounds, x86-64 baseline and -march=native; not measured in play) and the Verdict rewritten to match: no gain; the Summary's expectation sentence says so.
@Beanstalk One correction to my request 69700 above, for its picture point: please take each picture 5 s (300 frames at 60 fps) after the first frame whose picture is not a single uniform colour, with no input in between, and take the main-against-itself picture from the same point. A picture taken during the load's fade-in from black is not comparable: run 70269 on #2156 caught the fade in 3 of 4 starts.
@siantm only members of
BigBeanscan start the farm. One of them can approve this request by reacting 👍 to it or to this comment.@siantm — your own Measurements say "no gain: the kept place is slower than the walk in 9 of the 10 cases (0.90-0.97x …). On these figures the PR saves nothing", and the PR has not run in the game yet.
Do you want to close/drop #2056 rather than carry it further, or is a second measurement (or the in-game A/B) planned?
No action from us either way; just flagging it so it does not sit in the queue looking like a merge candidate.
@dazemc Thanks, and that reading is right: on the micro-benchmark this saves nothing (the kept place is slower than the walk in 9 of 10 cases). One more measurement is planned before I decide: an in-game comparison of main with and without this change (8 runs a side, Kokiri Forest, read on draw and game time), which waits for its build. If that shows no gain either, I will close this. It is not a merge candidate as it stands.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.