WIP: perf(vk): a draw takes its targets by reference and their colour types as worked out at their resolution #2048
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!2048
Loading…
Reference in a new issue
No description provided.
Delete branch "siantm/Longshot:perf/vk-targets-kept"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
draw()(gpu/vk/vk_draw.cpp) copied the thread's resolved render targets twice a draw (targets(), thenbare_targets()) and worked out their colour types (color_types_of) at every draw. WithRX_VK_BIND_CHANGEDon it takes them by reference (draw_targets: the thread's resolved ones, or the viewport's area in a scratch for a draw with no target) and the colour types from a memo made again whenevertargets()resolves anew (targets_gen). The result expected is less copying a draw. Not here: the branch also skipped the upscalers' scene notes for draws whose targets cannot be the scene; on maintemporal_scene_formatalso takes R16G16B16A16 targets, so those calls stay as main has them.Depends on #2047 (the switch
RX_VK_BIND_CHANGED): its commit shows in this diff until it merges.Switch:
RX_VK_BIND_CHANGED(kill, on).=0: copied and worked out at every draw, main's code.From bd3ea307 on
exp/x86-asm-sync.Read first:
draw_targets,targets_memo_ofand their use at the start ofdraw()ingpu/vk/vk_draw.cpp.Testing
Tested: Windows 11, i7-9700, RTX 4060, the builder's llvm-mingw clang 23; head
3432e729on #2047's headaebcf746(on main @75317e1f). Every check ran throughtests/run_all.py --strict --exactin build jobs of the PC's job queue, in a hidden console (logt-dc3-vk-targets-kept):tests/test_targets_kept.py(new:draw_targets,draw_targets_copied,TargetsMemoandtargets_memo_ofwith stand-ins over 200,000 random target changes, viewports and new submissions against the copies andcolor_types_of; the generation intargets()and the switch indraw()): pass.--changed aebcf746; its own are among them): 157 passed, 20 failed. Failed:tests/test_sampler_admission.py,tests/test_fsr_uniform_ownership.py,tests/test_pipeline_play_cache.py,tests/test_draw_stream_visibility.py,tests/test_device_lost_exit.py,tests/test_dev_packs.py,tests/test_draw_binds.py,tests/test_dev_ab.py,tests/test_crash_dialog.py,tests/test_frame_overlap.py,tests/test_linux_pressure.py,tests/test_mesh_conv.py,tests/test_prepare_cache_save.py,tests/test_present_queue_default.py,tests/test_recorder_own_idle.py,tests/test_target_reuse_memory.py,tests/test_upscaler_rows.py,tests/test_vk_occlusion_queries.py: each fails on main @75317e1ftoo (the same checks on main in the same queue batch, logt-dc3-base).tests/test_fallback_buffer_cleanup.pyandtests/test_pipeline_cache_save.pyalso failed in that run, each stopped at its 60-second limit, and passed when run again on this head (logt-dc4-vk-targets-kept).It has NOT run in the game on this PC yet.
Still to test:
RX_VK_BIND_CHANGED=0and this PR with it unset (on), each warmed a minute in the scene first, then interleaved (base, =0, unset, unset, =0, base), two runs each, expecting the same picture all three ways (no draw into a wrong target) and unset the replay's time a frame the same as or lower than the base's (by hand)RX_VK_BIND_CHANGED=0and unset, warmed, in ABBA order, expecting the same picture every way and no crash or validation error (@Beanstalk linux+nvidia, linux+amd, windows+amd, windows+intel, steamdeck: Kokiri Forest a minute, the push-constants PR alone against this PR with RX_VK_BIND_CHANGED=0 and unset, ABBA, the same picture)tests/test_targets_kept.pywith--cxx g++and--cxx clang++, expecting PASS (by hand)Measurements
Verdict: not measured: no micro-benchmark of this port and no run in the game on this PC yet; the in-game A/B is in Still to test.
RX_VK_BIND_CHANGEDships on (kind kill), the branch's default; it is not measured on main.Risks
The reference to the thread's resolved targets must stand for the whole draw: nothing in
draw()resolves targets again after its start (the test reads it). A stale colour-type memo would give a pipeline of the wrong formats (a validation error or a wrong picture). Turned off byRX_VK_BIND_CHANGED=0. The renderer is compiled again after updating.Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named). Not yet: only the checks in Testing ran.main, or Measurements says why there is nothing to measure. Not yet (Measurements).third_party/untouched; nothing GPL-incompatible.When it applies
gpu/vk/switches.def. Its row is in; not measured yet.tests/that reads changed source is updated, not weakened.Assisted-by:/Co-Authored-By:trailers.push_constants pushed the program's whole block (page table, task first, render area, fallback addresses) at every draw whose program reads it, though the draws of a pass push the same block one after another. It now leaves the push out when the last block this thread recorded was the same bytes, for the same stages, into the same command buffer (push_standing). vk_work.h counts every vkCmdPushConstants on the thread (push_epoch), so a push of anyone's in between makes the next draw push again. The block is forgotten where the command buffer's may be something else: at each recording's begin (binds_begin_recording), a masked clear, the temporal upscalers' stand-ins, each dispatch's end (its stand-ins call NGX / FidelityFX, which push past vk_work.h), and (new here, beside the branch's sites) in descriptors_disturbed, which every upscaler and library pass on main calls after recording its own pipelines. A direct mesh draw no longer pushes entry 0's first a second time: it is in the block just sent or left standing. The first of RX_VK_BIND_CHANGED's parts on the branch (bd3ea307, "draw-binds"); its other parts follow as their own commits. Its index-buffer part (bind at the pool buffer's start, draw from the first index) is main's RX_VK_INDEX_REBASE already and is not ported. Switch: RX_VK_BIND_CHANGED, kill, on by default (the branch's default); =0 (or false, off, no) pushes at every draw as before. Read once, at its first use. Row in gpu/vk/switches.def. Not measured on its own on the branch ("the saving is not measured yet"); not measured in play. Test: tests/test_push_changed.py runs push_standing (cut from the source) and reads the wiring: vk_work.h's count, the check before the push, the block kept after it, every place it is forgotten, the mesh first; and the switch's reader runs in fresh processes (unset, 0, off, false, 1, on and another value, twice each, set again after its first read). The three fixtures that compile draw_begin_recording stand in binds_begin_recording. Assisted-by: Claude CodePossibly related, for context:
@Beanstalk This changes the renderer so that every draw's render targets are kept when they did not change (gpu/vk), behind RX_VK_BIND_CHANGED, a kill switch on by default; RX_VK_BIND_CHANGED=0 is main's way. It is on #2047, whose commit is in its diff. It has not run in the game on these PCs yet. Please play Kokiri Forest and Hyrule Field, two minutes each, the PR against main on the same PC, on the PR's side with the switch unset and with RX_VK_BIND_CHANGED=0, with a picture in each compared with main's, on Linux with NVIDIA, Linux with AMD (RADV) and the Steam Deck. The same picture, no crash, device lost, validation error or FATAL line; unset, frame time p99 equal to main's or better and to the switch off.
@siantm only members of
BigBeanscan start the farm. One of them can approve this request by reacting 👍 to it or to this comment.View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.