fix(website): the progress feed's requests allow 120 s, so a busy forge's pull request list no longer stops the deploy #2034

Merged
HumanBean merged 1 commit from HumanBean/Longshot:fix/website-feed-timeout into main 2026-11-21 07:37:32 +00:00
Owner

Summary

The website has not been deploying. Its build collects the progress feed from the forge's API and gives each request
30 seconds. With the forge busy, listing 100 open pull requests takes 23 to 70 seconds (timed by hand on 2026-11-21),
so all three attempts time out, the feed comes out empty, and npm run check refuses the deploy, as it should with an
empty feed. Push deploys 45137 and
45251 failed this way; an hourly run that got a
faster answer deployed.

This gives each request 120 seconds (REQUEST_TIMEOUT_MS in website/src/lib/progress-request.ts) and says so in
website/PROGRESS.md. The retries, their waits and the check that refuses an empty feed are unchanged. The worst case
is three 120 s attempts on one request, well inside the job's 20 minutes.

Read website/src/lib/progress-request.ts.

Testing

Tested: game-free, nothing for the game to run. Timed the collector's own requests against git.magicbean.dev
(/pulls?state=open&sort=recentupdate&limit=100: 23 s, and 28 to 70 s for smaller lists earlier); the failing runs'
logs show three 30 s timeouts on /pulls each. CI's website build and checks run on this PR; the existing
website/tests/progress-request.test.ts checks the retries and fresh timeout signals and does not depend on the
value.

Still to test:

  • Forgejo, after merge: the push's Website on Cloudflare run deploys while the forge is busy, expecting no
    TimeoutError on /pulls (by hand, from the run's log)

Measurements

Nothing to measure: a build-time request timeout on the website, not the game.

Risks

A forge that is down, not slow, now takes up to six minutes per request to fail instead of 1.5, and the deploy still
fails as before. A revert is enough. Players notice nothing but the site updating again.

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit.
  • Tested on my own PC, in the game for a change the game runs, as Testing says.
  • mise run test passes (any failure that also fails on main is named). CI's run on this PR.
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • Docs updated.
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested.
  • Approved in review, every comment answered.
  • CI passes on the head; on current main, measured again or a comment says why the numbers still hold.

πŸ€– Generated with Claude Code

## Summary The website has not been deploying. Its build collects the progress feed from the forge's API and gives each request 30 seconds. With the forge busy, listing 100 open pull requests takes 23 to 70 seconds (timed by hand on 2026-11-21), so all three attempts time out, the feed comes out empty, and `npm run check` refuses the deploy, as it should with an empty feed. Push deploys [45137](https://git.magicbean.dev/MagicBeanDev/Longshot/actions/runs/45137) and [45251](https://git.magicbean.dev/MagicBeanDev/Longshot/actions/runs/45251) failed this way; an hourly run that got a faster answer deployed. This gives each request 120 seconds (`REQUEST_TIMEOUT_MS` in `website/src/lib/progress-request.ts`) and says so in `website/PROGRESS.md`. The retries, their waits and the check that refuses an empty feed are unchanged. The worst case is three 120 s attempts on one request, well inside the job's 20 minutes. Read `website/src/lib/progress-request.ts`. ## Testing **Tested:** game-free, nothing for the game to run. Timed the collector's own requests against git.magicbean.dev (`/pulls?state=open&sort=recentupdate&limit=100`: 23 s, and 28 to 70 s for smaller lists earlier); the failing runs' logs show three 30 s timeouts on `/pulls` each. CI's website build and checks run on this PR; the existing `website/tests/progress-request.test.ts` checks the retries and fresh timeout signals and does not depend on the value. **Still to test:** - Forgejo, after merge: the push's Website on Cloudflare run deploys while the forge is busy, expecting no `TimeoutError` on `/pulls` (by hand, from the run's log) ## Measurements Nothing to measure: a build-time request timeout on the website, not the game. ## Risks A forge that is down, not slow, now takes up to six minutes per request to fail instead of 1.5, and the deploy still fails as before. A revert is enough. Players notice nothing but the site updating again. ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. - [x] Tested on my own PC, in the game for a change the game runs, as Testing says. - [x] `mise run test` passes (any failure that also fails on `main` is named). CI's run on this PR. - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [x] Docs updated. - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. ### Ready to merge - [ ] Everything in Still to test has run, its results in Tested. - [ ] Approved in review, every comment answered. - [ ] CI passes on the head; on current `main`, measured again or a comment says why the numbers still hold. πŸ€– Generated with [Claude Code](https://claude.com/claude-code)
fix(website): the progress feed's requests allow 120 s, so a busy forge's pull request list no longer stops the deploy
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 17s
CI / Workflow lint (actionlint) (pull_request) Successful in 29s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 30s
Third-party parts / As their notes say (pull_request) Successful in 32s
PR description / Description follows the template (pull_request_target) Successful in 7s
CI / Website build and checks (pull_request) Successful in 9m51s
49ad8f5f8a
Listing 100 open pull requests took 23 to 70 s on 2026-11-21, past the 30 s each request allowed: all three
attempts timed out, the feed came out empty and npm run check refused the deploy (runs 45137, 45251).

Co-Authored-By: Claude Opus 5.5 <[email protected]>
HumanBean changed title from WIP: fix(website): the progress feed's requests allow 120 s, so a busy forge's pull request list no longer stops the deploy to fix(website): the progress feed's requests allow 120 s, so a busy forge's pull request list no longer stops the deploy 2026-11-21 06:48:58 +00:00
Author
Owner
@review
Member

The ChatGPT usage limit is reached (it resets Nov 25th, 2026 1:04 AM), so this review is paused. It runs by itself once the limit lifts (tried again every 30 minutes); nothing needs asking again.


Automated code review by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

The ChatGPT usage limit is reached (it resets Nov 25th, 2026 1:04 AM), so this review is paused. It runs by itself once the limit lifts (tried again every 30 minutes); nothing needs asking again. --- <sub>Automated code review by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
BeanBot left a comment

Recommendation: Request changes. The longer timeout covers the reported 23–70 second responses, but the fix has no regression test that would fail with the old 30-second limit. A successful collection with the changed timeout is also still unproven.

The website build gives each Forgejo progress-feed request 120 seconds instead of 30, allowing slower responses to complete. Failed requests can delay a build by up to six minutes per request.

@fix will do (1)

  1. L1 website/src/lib/progress-request.ts:20: There is no regression test for the longer request deadline: the existing tests pass with the old 30-second timeout because they inject immediate failures and never check when the signal expires. (more on the line)

For the author (1) (a run, a measurement or a decision)

  • L2 (minor) website/src/lib/progress-request.ts:9: The reported timings establish that 30 seconds is too short, but they do not show this commit completing the collector and publication check when the forge is busy. (more on the line)

Checks: Still running: CI / Website build and checks (pull_request).

More: does it help, other systems, switches, what was read

Does it help: Unproven: the reported Forgejo requests took 23–70 seconds and failed runs logged three 30-second timeouts, but no successful collection or deployment with this commit is reported.

Other systems: The timeout applies to every progress-feed API request and response body, including sequential pagination and releases. The website deployment and PR preview use the same collector; the game and launcher do not. The 20-minute job limit also includes installation, other requests, checks and upload.

Switches: None.

Reviewed: 49ad8f5f8a against e6196f0f54: Read AGENTS.md, CONTRIBUTING.md, docs/dev/standards.md, the PR template, both changed files, the commit, progress-request tests, the full collector, its JSON endpoint and the website workflow. Searched for other callers and timeout settings. docs/review-checklist.md and ../Tooling/AGENTS.md were absent. No recorded runs, translations or generated files were changed; CI results and PR-supplied run reports were reviewed.; nothing run (a code review).

Checked and fine:

  • The timeout signal is created afresh for each retry and also covers JSON body consumption.
  • Retry counts and backoff are unchanged, and the documentation matches the new deadline.
  • The commit records AI assistance; the diff contains no game-derived files, generated files, API version changes or switch changes.

Testing: Read-only review; no code or tests were run. CI's website build and checks were still running in the supplied status.

Overlaps and merge order: Not checked; the network is closed.


Automated code review by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** The longer timeout covers the reported 23–70 second responses, but the fix has no regression test that would fail with the old 30-second limit. A successful collection with the changed timeout is also still unproven. The website build gives each Forgejo progress-feed request 120 seconds instead of 30, allowing slower responses to complete. Failed requests can delay a build by up to six minutes per request. **`@fix` will do (1)** 1. **L1** `website/src/lib/progress-request.ts:20`: There is no regression test for the longer request deadline: the existing tests pass with the old 30-second timeout because they inject immediate failures and never check when the signal expires. (more on the line) **For the author (1)** (a run, a measurement or a decision) - **L2** (minor) `website/src/lib/progress-request.ts:9`: The reported timings establish that 30 seconds is too short, but they do not show this commit completing the collector and publication check when the forge is busy. (more on the line) **Checks:** Still running: `CI / Website build and checks (pull_request)`. <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Unproven: the reported Forgejo requests took 23–70 seconds and failed runs logged three 30-second timeouts, but no successful collection or deployment with this commit is reported. **Other systems:** The timeout applies to every progress-feed API request and response body, including sequential pagination and releases. The website deployment and PR preview use the same collector; the game and launcher do not. The 20-minute job limit also includes installation, other requests, checks and upload. **Switches:** None. **Reviewed:** 49ad8f5f8a64 against e6196f0f5413: Read AGENTS.md, CONTRIBUTING.md, docs/dev/standards.md, the PR template, both changed files, the commit, progress-request tests, the full collector, its JSON endpoint and the website workflow. Searched for other callers and timeout settings. docs/review-checklist.md and ../Tooling/AGENTS.md were absent. No recorded runs, translations or generated files were changed; CI results and PR-supplied run reports were reviewed.; nothing run (a code review). **Checked and fine:** - The timeout signal is created afresh for each retry and also covers JSON body consumption. - Retry counts and backoff are unchanged, and the documentation matches the new deadline. - The commit records AI assistance; the diff contains no game-derived files, generated files, API version changes or switch changes. **Testing:** Read-only review; no code or tests were run. CI's website build and checks were still running in the supplied status. **Overlaps and merge order:** Not checked; the network is closed. </details> --- <sub>Automated code review by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
@ -6,1 +6,4 @@
// A request's time, its JSON body included. A busy forge can take more than 30 s to list 100 open pull requests
// (23 to 70 s on 2026-11-21), and an empty feed stops the deploy.
const REQUEST_TIMEOUT_MS = 120000;
Member

L2 (minor): The reported timings establish that 30 seconds is too short, but they do not show this commit completing the collector and publication check when the forge is busy. Run the changed build under those conditions and record the result and duration before merging.

**L2** (minor): The reported timings establish that 30 seconds is too short, but they do not show this commit completing the collector and publication check when the forge is busy. Run the changed build under those conditions and record the result and duration before merging.
@ -14,3 +18,3 @@
let retry = false;
try {
response = await fetcher(url, { headers, signal: AbortSignal.timeout(30000), redirect: 'error' });
response = await fetcher(url, { headers, signal: AbortSignal.timeout(REQUEST_TIMEOUT_MS), redirect: 'error' });
Member

L1: There is no regression test for the longer request deadline: the existing tests pass with the old 30-second timeout because they inject immediate failures and never check when the signal expires. Add a game-free test that simulates a response taking more than 30 seconds but less than 120 seconds, including body reading, and fails if the old deadline is restored.

**L1**: There is no regression test for the longer request deadline: the existing tests pass with the old 30-second timeout because they inject immediate failures and never check when the signal expires. Add a game-free test that simulates a response taking more than 30 seconds but less than 120 seconds, including body reading, and fails if the old deadline is restored.
HumanBean deleted branch fix/website-feed-timeout 2026-11-21 07:37:35 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!2034
No description provided.