WIP: perf(nvn): ReportCounter reads its first-report flag before the locked exchange #1955

Draft
siantm wants to merge 2 commits from siantm/Longshot:perf/nvn-report-counter-flag into main
Contributor

Summary

nvnCommandBufferReportCounter (host/nvn_native.c) logs the first report of each counter type the game asks for,
with its caller. It found the first one with a locked exchange on seen[type] at every report, a write to one cache
line that every thread recording command buffers shares, long after each type had been seen. The flag is now read
first and the exchange made only while it is clear: the same log lines, and no locked write once a type has been seen.

From a7d746ac on exp/x86-asm-sync (its other half, the handle binds' records, is its own PR).

Read first: the seen block in nvnCommandBufferReportCounter, host/nvn_native.c.

Testing

Tested: Windows 11, i7-9700, RTX 4060 (NVIDIA 610.88), llvm-mingw clang 23.1.5; game-free checks and a
micro-benchmark only. This change has not run in the game on this PC yet (the run is queued: Still to test). It has no
test of its own: the log lines are the same and no check cuts nvnCommandBufferReportCounter; what was checked instead
is the run of every check that reads host/nvn_native.c, and the micro-benchmark in Measurements. In a hidden console
of its own, in one job of the PC's job queue (fb-1954-2), on this branch rebased onto main @ 6e1521a7 (with #1949),
head 38094d72:

  • python -I -B tests/run_all.py --strict --changed origin/main at 38094d72 (the checks that read a changed file,
    8 at once): 18 passed, 2 failed, 1 skipped (test_tracy_funcs.py: Linux only). The 2 failing checks
    (test_dev_packs.py, test_host_guest_writes.py) fail on main @ 6e1521a7 too, run by name in the same queue
    job, with the same messages; none fails on this branch alone.

Still to test:

  • Windows 11, this PC (i7-9700, RTX 4060 (NVIDIA 610.88)): Castle Town's market, 60 s, this PR and main interleaved,
    no switches set, expecting the same nvn: the game reports counter type lines and fps and frame times within the
    runs' spread or better (by hand, queued)
  • Linux, NVIDIA and AMD (Mesa RADV), and the Steam Deck: Castle Town's market for two minutes, this PR against main,
    expecting the same frame times as main or better and no crash (@Beanstalk play Castle Town's market for two minutes
    on Linux and the Steam Deck, this PR against main, comparing frame times)

Measurements

Verdict: micro-benchmark only, not measured in play yet: a report of a type already seen took 4.96 ns on one thread
on main and 0.80 ns here, and 67.86 ns against 0.85 ns a thread with four threads reporting at once.

Setup: Windows 11, i7-9700, llvm-mingw clang 23.1.5, -O2 -march=native as the host is built; the first-report test as
two lines copied into the benchmark, main's (a locked exchange at every report) and this PR's (a read first), on 1
and 4 threads reporting a type already seen side by side; 21 interleaved rounds, the median and the rounds' range of
each thread's ns a report, in one job of the PC's job queue (microbench.py reportflag). Measured with main @
8859673e and this change as it was there (791d6da5); the rebase onto fc4a6769 changed none of its lines.

Before: main @ 8859673e After: this PR @ 791d6da5 (the same change on 8859673e)
a report of a seen type, 1 thread, ns (median of 21 rounds, range) 4.96 (4.78 to 5.30) 0.80 (0.75 to 1.18)
a report of a seen type, 4 threads, ns a thread (median of 21 rounds, range) 67.86 (54.68 to 86.55) 0.85 (0.76 to 1.27)
ReportCounter's flag, 1 thread(s)        main           median     4.96 ns  (rounds 4.78 to 5.30)
ReportCounter's flag, 1 thread(s)        PR             median     0.80 ns  (rounds 0.75 to 1.18)
ReportCounter's flag, 4 thread(s)        main           median    67.86 ns  (rounds 54.68 to 86.55)
ReportCounter's flag, 4 thread(s)        PR             median     0.85 ns  (rounds 0.76 to 1.27)

Risks

Two threads that report a new type at once can both read the flag clear; the exchange still lets only one of them log,
as before. No switch: a revert is enough. Players notice nothing (no saves, longshot_options.ini or caches change).

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit.
  • Tested on my own PC, in the game for a change the game runs, as Testing says.
  • mise run test passes (any failure that also fails on main is named).
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • A check under tests/ that reads changed source is updated, not weakened.
  • Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths.
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested.
  • Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers").
  • Approved in review, every comment answered.
  • CI passes on the head; on current main, measured again or a comment says why the numbers still hold.
## Summary `nvnCommandBufferReportCounter` (`host/nvn_native.c`) logs the first report of each counter type the game asks for, with its caller. It found the first one with a locked exchange on `seen[type]` at every report, a write to one cache line that every thread recording command buffers shares, long after each type had been seen. The flag is now read first and the exchange made only while it is clear: the same log lines, and no locked write once a type has been seen. From a7d746ac on `exp/x86-asm-sync` (its other half, the handle binds' records, is its own PR). Read first: the `seen` block in `nvnCommandBufferReportCounter`, `host/nvn_native.c`. ## Testing **Tested:** Windows 11, i7-9700, RTX 4060 (NVIDIA 610.88), llvm-mingw clang 23.1.5; game-free checks and a micro-benchmark only. This change has not run in the game on this PC yet (the run is queued: Still to test). It has no test of its own: the log lines are the same and no check cuts `nvnCommandBufferReportCounter`; what was checked instead is the run of every check that reads `host/nvn_native.c`, and the micro-benchmark in Measurements. In a hidden console of its own, in one job of the PC's job queue (fb-1954-2), on this branch rebased onto `main` @ 6e1521a7 (with #1949), head 38094d72: - `python -I -B tests/run_all.py --strict --changed origin/main` at 38094d72 (the checks that read a changed file, 8 at once): 18 passed, 2 failed, 1 skipped (`test_tracy_funcs.py`: Linux only). The 2 failing checks (`test_dev_packs.py`, `test_host_guest_writes.py`) fail on `main` @ 6e1521a7 too, run by name in the same queue job, with the same messages; none fails on this branch alone. **Still to test:** - Windows 11, this PC (i7-9700, RTX 4060 (NVIDIA 610.88)): Castle Town's market, 60 s, this PR and `main` interleaved, no switches set, expecting the same `nvn: the game reports counter type` lines and fps and frame times within the runs' spread or better (by hand, queued) - Linux, NVIDIA and AMD (Mesa RADV), and the Steam Deck: Castle Town's market for two minutes, this PR against `main`, expecting the same frame times as `main` or better and no crash (@Beanstalk play Castle Town's market for two minutes on Linux and the Steam Deck, this PR against main, comparing frame times) ## Measurements **Verdict:** micro-benchmark only, not measured in play yet: a report of a type already seen took 4.96 ns on one thread on `main` and 0.80 ns here, and 67.86 ns against 0.85 ns a thread with four threads reporting at once. Setup: Windows 11, i7-9700, llvm-mingw clang 23.1.5, `-O2 -march=native` as the host is built; the first-report test as two lines copied into the benchmark, `main`'s (a locked exchange at every report) and this PR's (a read first), on 1 and 4 threads reporting a type already seen side by side; 21 interleaved rounds, the median and the rounds' range of each thread's ns a report, in one job of the PC's job queue (`microbench.py reportflag`). Measured with `main` @ 8859673e and this change as it was there (791d6da5); the rebase onto fc4a6769 changed none of its lines. | | Before: main @ 8859673e | After: this PR @ 791d6da5 (the same change on 8859673e) | |---|---|---| | a report of a seen type, 1 thread, ns (median of 21 rounds, range) | 4.96 (4.78 to 5.30) | 0.80 (0.75 to 1.18) | | a report of a seen type, 4 threads, ns a thread (median of 21 rounds, range) | 67.86 (54.68 to 86.55) | 0.85 (0.76 to 1.27) | ``` ReportCounter's flag, 1 thread(s) main median 4.96 ns (rounds 4.78 to 5.30) ReportCounter's flag, 1 thread(s) PR median 0.80 ns (rounds 0.75 to 1.18) ReportCounter's flag, 4 thread(s) main median 67.86 ns (rounds 54.68 to 86.55) ReportCounter's flag, 4 thread(s) PR median 0.85 ns (rounds 0.76 to 1.27) ``` ## Risks Two threads that report a new type at once can both read the flag clear; the exchange still lets only one of them log, as before. No switch: a revert is enough. Players notice nothing (no saves, `longshot_options.ini` or caches change). ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. - [ ] Tested on my own PC, in the game for a change the game runs, as Testing says. - [ ] `mise run test` passes (any failure that also fails on `main` is named). - [ ] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [x] A check under `tests/` that reads changed source is updated, not weakened. - [ ] Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. ### Ready to merge - [ ] Everything in Still to test has run, its results in Tested. - [ ] Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers"). - [ ] Approved in review, every comment answered. - [ ] CI passes on the head; on current `main`, measured again or a comment says why the numbers still hold.
perf(nvn): ReportCounter reads its first-report flag before the locked exchange
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 8s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
CI / Website build and checks (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
8fdb2327c2
nvnCommandBufferReportCounter logs the first report of each counter type with its caller, through a locked exchange
on seen[type] at every report, on one cache line every recording thread shares. The flag is now read first and the
exchange made only while it is clear: the same log lines, no locked write once a type has been seen.

From a7d746ac on exp/x86-asm-sync.

Assisted-by: Claude Code
BeanBot left a comment

Recommendation: Wait. The relaxed load removes the recurring locked write and preserves one log entry per counter type. The isolated flag is faster, but the player benefit and in-game behavior still need verification on a buildable base.

Repeat counter reports avoid taking exclusive ownership of a shared cache line. The code adds one load and branch to the first-report path and keeps the same counter records and diagnostics.

Does it help: Unproven in play. In 21 interleaved Windows 11 microbenchmark rounds on an i7-9700, the median for the copied flag check fell from 4.96 to 0.80 ns on one thread and from 67.86 to 0.85 ns per thread with four threads. The reported ranges were separate. The comparison used main 8859673e and PR 791d6da5. It measures the flag check in isolation, so the cost of the full call and the effect on frame times remain unknown.
Other systems: The flag is private to host-side logging on Windows and Linux. The recorded type, address and conditional-write marker feed the same Vulkan replay paths for timestamps, dynamic resolution and occlusion queries. The timing change can affect CPU contention across GPU vendors and on Steam Deck. The diff adds no resource lifetime, memory budget, cache, save, audio or input changes.
Switches: None.

Reviewed: 8fdb2327c2 against 2e1f6c32d3: Read the full diff and commit, the full changed ReportCounter function, the call and record paths it relies on, the Linux atomic shim, and the Vulkan counter consumers. Read AGENTS.md, CONTRIBUTING.md, the Forgejo template, the developer standards and measurement guidance. The checkout has no docs/review-checklist.md or adjacent Tooling checkout. Skimmed the rest of host/nvn_native.c, related checks, local run records and relevant history. The benchmark source and raw output were unavailable beyond the PR excerpt. No translations or generated files changed.; nothing run (a code review).
Checked and fine:

  • The unsigned type check bounds both accesses to the 64-entry array. The exchange still elects one winner if two threads read zero, and the flag publishes no other state.
  • The flag is statically initialized, uses atomic accesses on both supported platforms, and needs no new CPU feature, allocation, lock, or cleanup.
  • The source-reading checks reviewed exercise other functions or replay code. This hunk changes none of their extraction points.
  • The single commit matches the stated scope and carries the Assisted-by trailer. The diff contains no game-derived artifacts, third-party edits, generated files, API changes or executable tooling.

Waiting on the author (a run, a measurement or a decision; no edit does it)

  • The tight loop repeatedly hits a warm, already-seen flag. If actual Market frames issue few reports or recording threads rarely contend on the same flag, the nanosecond saving can disappear into frame-time noise. After rebasing, compare the PR and its buildable merge base in interleaved runs with the same scene, build and player settings. Report the counter path's cost, average FPS, 1% lows, and median and p99 frame times in the Market and a heavy scene.
  • The PR opened before the required local game run, and the proposed test of this head inherits the extra brace in vk_replay.cpp that #1949 fixes on main. Rebase onto main with #1949, verify the one-time counter diagnostics on the author's Windows PC, and record Tier 1 results. Include Windows AMD coverage alongside the listed Linux NVIDIA, RADV and Steam Deck runs.
  • The earlier Windows changed-file run leaves full-suite and head CI coverage outstanding. Run the repository checks and get passing CI on the rebased head, with Windows and Linux build evidence. Record the disposition of any failures or skips against the matching base.

Testing: Read-only review. The author reports 18 passed, two failed and one skipped on d6867876. The two failures, test_dev_packs.py and test_host_guest_writes.py, also failed on fc4a6769. No game run or CI result was supplied for 8fdb2327. The source-check checklist item is inapplicable because the reviewed checks cut other functions.
Overlaps and merge order: Use main containing #1949 before testing or merging. The handle-bind companion is mentioned in the PR description, but local history shows no dependency or required merge order for it.


Automated code review by BeanBot (gpt-6.2-sol), on the pull request's opening. Nothing was run; a maintainer decides.

**Recommendation: Wait.** The relaxed load removes the recurring locked write and preserves one log entry per counter type. The isolated flag is faster, but the player benefit and in-game behavior still need verification on a buildable base. Repeat counter reports avoid taking exclusive ownership of a shared cache line. The code adds one load and branch to the first-report path and keeps the same counter records and diagnostics. **Does it help:** Unproven in play. In 21 interleaved Windows 11 microbenchmark rounds on an i7-9700, the median for the copied flag check fell from 4.96 to 0.80 ns on one thread and from 67.86 to 0.85 ns per thread with four threads. The reported ranges were separate. The comparison used main 8859673e and PR 791d6da5. It measures the flag check in isolation, so the cost of the full call and the effect on frame times remain unknown. **Other systems:** The flag is private to host-side logging on Windows and Linux. The recorded type, address and conditional-write marker feed the same Vulkan replay paths for timestamps, dynamic resolution and occlusion queries. The timing change can affect CPU contention across GPU vendors and on Steam Deck. The diff adds no resource lifetime, memory budget, cache, save, audio or input changes. **Switches:** None. **Reviewed:** 8fdb2327c2ca against 2e1f6c32d30e: Read the full diff and commit, the full changed ReportCounter function, the call and record paths it relies on, the Linux atomic shim, and the Vulkan counter consumers. Read AGENTS.md, CONTRIBUTING.md, the Forgejo template, the developer standards and measurement guidance. The checkout has no docs/review-checklist.md or adjacent Tooling checkout. Skimmed the rest of host/nvn_native.c, related checks, local run records and relevant history. The benchmark source and raw output were unavailable beyond the PR excerpt. No translations or generated files changed.; nothing run (a code review). **Checked and fine:** - The unsigned type check bounds both accesses to the 64-entry array. The exchange still elects one winner if two threads read zero, and the flag publishes no other state. - The flag is statically initialized, uses atomic accesses on both supported platforms, and needs no new CPU feature, allocation, lock, or cleanup. - The source-reading checks reviewed exercise other functions or replay code. This hunk changes none of their extraction points. - The single commit matches the stated scope and carries the Assisted-by trailer. The diff contains no game-derived artifacts, third-party edits, generated files, API changes or executable tooling. **Waiting on the author** (a run, a measurement or a decision; no edit does it) - The tight loop repeatedly hits a warm, already-seen flag. If actual Market frames issue few reports or recording threads rarely contend on the same flag, the nanosecond saving can disappear into frame-time noise. After rebasing, compare the PR and its buildable merge base in interleaved runs with the same scene, build and player settings. Report the counter path's cost, average FPS, 1% lows, and median and p99 frame times in the Market and a heavy scene. - The PR opened before the required local game run, and the proposed test of this head inherits the extra brace in vk_replay.cpp that #1949 fixes on main. Rebase onto main with #1949, verify the one-time counter diagnostics on the author's Windows PC, and record Tier 1 results. Include Windows AMD coverage alongside the listed Linux NVIDIA, RADV and Steam Deck runs. - The earlier Windows changed-file run leaves full-suite and head CI coverage outstanding. Run the repository checks and get passing CI on the rebased head, with Windows and Linux build evidence. Record the disposition of any failures or skips against the matching base. **Testing:** Read-only review. The author reports 18 passed, two failed and one skipped on d6867876. The two failures, test_dev_packs.py and test_host_guest_writes.py, also failed on fc4a6769. No game run or CI result was supplied for 8fdb2327. The source-check checklist item is inapplicable because the reviewed checks cut other functions. **Overlaps and merge order:** Use main containing #1949 before testing or merging. The handle-bind companion is mentioned in the PR description, but local history shows no dependency or required merge order for it. --- <sub>Automated code review by BeanBot (gpt-6.2-sol), on the pull request's opening. Nothing was run; a maintainer decides.</sub>
@ -1924,2 +1924,2 @@
static volatile LONG seen[64];
if (U32(1) < 64 && !InterlockedExchange(&seen[U32(1)], 1))
static volatile LONG seen[64]; /* (looked at before the exchange: a locked exchange on every report, on a line all
recording threads share, was a third of the call) */
Member

The benchmark times the flag check in isolation. Drop the one-third figure here or cite a measurement of the full call.

The benchmark times the flag check in isolation. Drop the one-third figure here or cite a measurement of the full call.
siantm force-pushed perf/nvn-report-counter-flag from 8fdb2327c2
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 8s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
CI / Website build and checks (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to 38094d7226
Some checks reported errors
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 4s
Website / Website on Cloudflare (pull_request_target) Has been skipped
beanstalk/linux+nvidia 0/1 pass, 2 error
beanstalk/linux+radv 0/1 pass, 2 error
beanstalk/windows+intel 0/1 pass, 0 running, 2 queued
beanstalk/approval approved by futondestroyer (reviewed)
beanstalk/steamdeck 0/1 pass, 0 running, 2 queued
2026-11-21 02:53:55 +00:00
Compare
Author
Contributor

Thank you for the review. Pushed: the branch is now rebased onto current main @ 6e1521a7, which has #1949 (the vk_replay.cpp brace), head 38094d72 (was 8fdb2327). git range-diff shows the PR's own commit unchanged by the rebase.

  • Inline, host/nvn_native.c:1925 (the one-third figure): agreed, the micro-benchmark timed only the flag check, not the whole call. 38094d72 takes the share out of the comment: it now says only that, once a type has been seen, its reports make no locked write to the shared line. Measurements already calls its numbers a micro-benchmark of the flag check alone; the description is unchanged there.
  • Review, waiting on the author: all three items are pending and listed under Still to test (no edit does them): interleaved in-game runs against the merge base in the Market and a heavy area (counter-path cost, average fps, 1 % lows, median and p99 frame times); the local game run with the counter lines checked and the Tier 1 results, Windows AMD included; the full checks and CI on this rebased head with the Windows and Linux builds. None of these has run yet.

Checked at 38094d72 through the PC's job queue: tests/run_all.py --strict --changed origin/main (job fb-1954-2): 18 passed, 2 failed, 1 skipped. The 2 failures (test_dev_packs.py, test_host_guest_writes.py) fail on main @ 6e1521a7 with the same messages. The description's Tested now names this base and head; nothing has run in the game.

Thank you for the review. Pushed: the branch is now rebased onto current `main` @ 6e1521a7, which has #1949 (the `vk_replay.cpp` brace), head 38094d72 (was 8fdb2327). `git range-diff` shows the PR's own commit unchanged by the rebase. - [Inline, `host/nvn_native.c:1925`](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1955#issuecomment-61939) (the one-third figure): agreed, the micro-benchmark timed only the flag check, not the whole call. 38094d72 takes the share out of the comment: it now says only that, once a type has been seen, its reports make no locked write to the shared line. Measurements already calls its numbers a micro-benchmark of the flag check alone; the description is unchanged there. - [Review](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1955#issuecomment-61940), waiting on the author: all three items are pending and listed under Still to test (no edit does them): interleaved in-game runs against the merge base in the Market and a heavy area (counter-path cost, average fps, 1 % lows, median and p99 frame times); the local game run with the counter lines checked and the Tier 1 results, Windows AMD included; the full checks and CI on this rebased head with the Windows and Linux builds. None of these has run yet. Checked at 38094d72 through the PC's job queue: `tests/run_all.py --strict --changed origin/main` (job fb-1954-2): 18 passed, 2 failed, 1 skipped. The 2 failures (`test_dev_packs.py`, `test_host_guest_writes.py`) fail on `main` @ 6e1521a7 with the same messages. The description's Tested now names this base and head; nothing has run in the game.
Author
Contributor

@Beanstalk This makes NVN's ReportCounter read its first-report flag before the locked exchange (host/nvn_native.c), so the exchange runs only for the first report of each counter type. It has not run in the game here with this head yet. Please play Castle Town Market for 2 minutes on Linux with NVIDIA, on Linux with AMD (RADV), on Windows with an Intel GPU and on the Steam Deck, the PR against main. No crash; the log's "nvn: the game reports counter type" lines must be the same on both sides, once per type; frame time p99 equal to main's or better, within the spread.

@Beanstalk This makes NVN's ReportCounter read its first-report flag before the locked exchange (host/nvn_native.c), so the exchange runs only for the first report of each counter type. It has not run in the game here with this head yet. Please play Castle Town Market for 2 minutes on Linux with NVIDIA, on Linux with AMD (RADV), on Windows with an Intel GPU and on the Steam Deck, the PR against main. No crash; the log's "nvn: the game reports counter type" lines must be the same on both sides, once per type; frame time p99 equal to main's or better, within the spread.
Member

@siantm only members of BigBeans can start the farm. One of them can approve this request by reacting 👍 to it or to this comment.

@siantm only members of `BigBeans` can start the farm. One of them can approve this request by reacting 👍 to it or to this comment.
futondestroyer left a comment

Recommendation: Wait for gameplay and performance evidence. The new base contains the renderer build fix, and the updated comment drops the unsupported estimate of the flag's share of the full call. The flag change itself carries over unchanged. Renderer build fix

The type bound guards both accesses to the 64-entry array. If two recorders see zero, the exchange still selects one logger. The flag carries no data from the logging thread, so the relaxed load is sufficient. The type, address and conditional-write marker continue to feed the same Vulkan counter replay, including timestamps and occlusion. The change adds no switches.

Gameplay benefit remains unproven. In the author's 21 interleaved Windows microbenchmark rounds, the steady-state flag check went from 4.96 to 0.80 ns on one thread and from 67.86 to 0.85 ns per thread on four contending threads. Use the exact rebased pair for warmed, interleaved Market and heavy-scene runs. Record average FPS, 1% lows, median and p99 frame times, and verify one diagnostic per observed type below 64 on each fresh start. A separate HOS_HLE_STATS=1 pass can count nvnCommandBufferReportCounter calls in each scene. Keep it off for the frame-time comparison because the diagnostic adds atomics to the host-call path.

Testing. The author reports 18 changed-file checks passed, two failures with matching base failures, and one Linux-only check skipped on the rebased head. The description check passed and the other CI checks remain pending. The existing Market Test Farm request can cover Linux NVIDIA, RADV and Steam Deck, plus Windows Intel if an opted-in volunteer matches. Windows AMD coverage, the author's own Windows gameplay run, the full suite and exact-head build evidence are still open. Check the farm plan before treating any result as Market gameplay evidence. Existing Test Farm request

Reviewed the entire diff for 38094d7226b0 against 6e1521a70a32 with revision-matched Graphify maps and source inspection of the NVN dispatch and record path, platform atomics, and Vulkan consumers. Source review only.

**Recommendation: Wait for gameplay and performance evidence.** The new base contains the renderer build fix, and the updated comment drops the unsupported estimate of the flag's share of the full call. The flag change itself carries over unchanged. [Renderer build fix](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1949) The type bound guards both accesses to the 64-entry array. If two recorders see zero, the exchange still selects one logger. The flag carries no data from the logging thread, so the relaxed load is sufficient. The type, address and conditional-write marker continue to feed the same Vulkan counter replay, including timestamps and occlusion. The change adds no switches. **Gameplay benefit remains unproven.** In the author's 21 interleaved Windows microbenchmark rounds, the steady-state flag check went from 4.96 to 0.80 ns on one thread and from 67.86 to 0.85 ns per thread on four contending threads. Use the exact rebased pair for warmed, interleaved Market and heavy-scene runs. Record average FPS, 1% lows, median and p99 frame times, and verify one diagnostic per observed type below 64 on each fresh start. A separate `HOS_HLE_STATS=1` pass can count `nvnCommandBufferReportCounter` calls in each scene. Keep it off for the frame-time comparison because the diagnostic adds atomics to the host-call path. **Testing.** The author reports 18 changed-file checks passed, two failures with matching base failures, and one Linux-only check skipped on the rebased head. The description check passed and the other CI checks remain pending. The existing Market Test Farm request can cover Linux NVIDIA, RADV and Steam Deck, plus Windows Intel if an opted-in volunteer matches. Windows AMD coverage, the author's own Windows gameplay run, the full suite and exact-head build evidence are still open. Check the farm plan before treating any result as Market gameplay evidence. [Existing Test Farm request](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1955#issuecomment-62724) Reviewed the entire diff for `38094d7226b0` against `6e1521a70a32` with revision-matched Graphify maps and source inspection of the NVN dispatch and record path, platform atomics, and Vulkan consumers. Source review only.
Member

Beanstalk test farm · 🔄 testing (4 of 4 reports so far)

Commit 38094d7 · approved by futondestroyer (👍 on siantm's request) (reviewed) · dashboard

⚠️ Note: The farm cannot compare arbitrary counter-type log sets or enforce one line per observed type; the log probe only checks for the diagnostic's presence and marks its absence unjudged.
⚠️ Note: The 5% p99 allowance is a fixed proxy for run-to-run spread, not a statistical test of that spread. The two-minute measurement is stationary after a short movement through the Market.

Started at 03:04 UTC.

Target Result Reports Frame time p99 (ms), main → PR VRAM peak (MB) Crashes
linux+nvidia ⚠️ couldn't be judged (an outlier) 2 1 2 — — none
linux+radv ⚠️ couldn't be judged 2 1 2 — — none
windows+intel ⏳ queued 0 of 1 — — —
steamdeck ⏳ queued 0 of 1 — — —

Couldn't be judged: the tester's PC could not finish the test. The farm tries another PC, or the same one after a fix; it says nothing about the PR on its own.

  • linux+nvidia, report 1: Insufficient frame-time evidence for 1 required comparison(s). See rule results. a step ran out of time at step 2 (wait map Market_Child): timeout: not met in time (then the game was in play on KokiriForest_Child)
  • linux+nvidia, report 2: Insufficient frame-time evidence for 1 required comparison(s). See rule results. a step ran out of time at step 2 (wait map Market_Child): timeout: not met in time (then the game was in play on KokiriForest_Child)
  • linux+radv, report 1: the main base failed (exit 1): build.py stopped (exit status 1): <data>/bases/main/work/sa/build/obj/code_hot_5.split.c:47749:31: error: called object type 'int' is not a function or function pointer
  • linux+radv, report 2: Insufficient frame-time evidence for 1 required comparison(s). See rule results. a step ran out of time at step 2 (wait map Market_Child): timeout: not met in time (then the game was in play on KokiriForest_Child)
What was tested

What will be tested · AI plan (gpt-6.1-terra)

Compare the PR with main in Castle Town Market on Linux NVIDIA, Linux RADV, Windows Intel and Steam Deck. Each side gets two interleaved runs with a two-minute frame-time measurement; the plan fails on a crash or a p99 regression over 5%. The Windows Intel target will wait for a matching tester. Each tester's game runs take roughly 30 minutes. No tester online now matches windows+intel: that target waits for one.

  • Where: linux+nvidia (1-2 reports), linux+radv (1-2 reports), windows+intel (1-2 reports), steamdeck (1-2 reports).
  • castle-town-market: from the repository's save kokiri-start, then teleport to Market, move the stick, take the picture market to compare with main, measure market for 2 min (after 10 s warm-up); 2 runs on each side.
  • Measured: crashes, frame times, stutters and hitches, draws and frame rate, the game's log (an expected line that never appears: could not be judged).
  • The PR fails if: it crashes; or a picture differs from main by more than 5%; or frame time (p99) is more than 5% above main; or expected log lines missing is above 0.
  • Time: about 29 min of game runs per tester (4 game starts), plus the two builds.
Measurements on `linux+nvidia`, for the PR description

Verdict: could not be judged on linux+nvidia (2 reports): required frame-time comparison inconclusive (fewer than two usable starts per side).

Hardware: 1: linux+nvidia+nvidia-proprietary+dgpu NVIDIA GeForce RTX 5070, 620.70.6 AMD Ryzen 5 9600X 6-Core Processor, 32 GB RAM; 2: linux+nvidia+nvidia-proprietary+dgpu NVIDIA GeForce GTX 1060, 580.178.4 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz, 24 GB RAM
Scene: castle-town-market, from the repository's save kokiri-start; each cell's settings and switches as the table names them
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); castle-town-market: 2 game starts a side, market 120 s after 10 s warm-up; each number the median of the runs, then of 2 reports
How to reproduce: the farm's plan above (@Beanstalk on this PR runs it again)

Before: main @ 6e1521a After: this PR @ 38094d7
castle-town-market · expected log lines missing 0.0 0.0

Flags and settings

None: the plan varied no setting, switch or build option.

As Markdown for the PR description:

## Measurements

**Verdict:** could not be judged on linux+nvidia (2 reports): required frame-time comparison inconclusive (fewer than two usable starts per side).

Hardware: 1: linux+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 5070, 620.70.6` `AMD Ryzen 5 9600X 6-Core Processor, 32 GB RAM`; 2: linux+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce GTX 1060, 580.178.4` `Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz, 24 GB RAM`  
Scene: castle-town-market, from the repository's save kokiri-start; each cell's settings and switches as the table names them  
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); castle-town-market: 2 game starts a side, market 120 s after 10 s warm-up; each number the median of the runs, then of 2 reports  
How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again)

| | Before: main @ 6e1521a | After: this PR @ 38094d7 |
|---|---|---|
| castle-town-market · expected log lines missing | 0.0 | 0.0 |

**Flags and settings**

None: the plan varied no setting, switch or build option.
Measurements on `linux+radv`, for the PR description

Verdict: could not be judged on linux+radv (2 reports): required frame-time comparison inconclusive (fewer than two usable starts per side).

Hardware: 1: linux+amd+radv+dgpu AMD Radeon RX 9070 XT (RADV GFX1201), 26.1.99 AMD Ryzen 7 5700X3D 8-Core Processor, 32 GB RAM; 2: linux+amd+radv+dgpu AMD Radeon RX 580 Series (RADV POLARIS10), 26.2.7 AMD Ryzen 5 5500F 6-Core Processor, 32 GB RAM
Scene: castle-town-market, from the repository's save kokiri-start; each cell's settings and switches as the table names them
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); castle-town-market: 2 game starts a side, market 120 s after 10 s warm-up; each number the median of the runs, then of 2 reports
How to reproduce: the farm's plan above (@Beanstalk on this PR runs it again)

Before: main @ 6e1521a After: this PR @ 38094d7
castle-town-market · expected log lines missing 0.0 0.0

Flags and settings

None: the plan varied no setting, switch or build option.

As Markdown for the PR description:

## Measurements

**Verdict:** could not be judged on linux+radv (2 reports): required frame-time comparison inconclusive (fewer than two usable starts per side).

Hardware: 1: linux+amd+radv+dgpu `AMD Radeon RX 9070 XT (RADV GFX1201), 26.1.99` `AMD Ryzen 7 5700X3D 8-Core Processor, 32 GB RAM`; 2: linux+amd+radv+dgpu `AMD Radeon RX 580 Series (RADV POLARIS10), 26.2.7` `AMD Ryzen 5 5500F 6-Core Processor, 32 GB RAM`  
Scene: castle-town-market, from the repository's save kokiri-start; each cell's settings and switches as the table names them  
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); castle-town-market: 2 game starts a side, market 120 s after 10 s warm-up; each number the median of the runs, then of 2 reports  
How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again)

| | Before: main @ 6e1521a | After: this PR @ 38094d7 |
|---|---|---|
| castle-town-market · expected log lines missing | 0.0 | 0.0 |

**Flags and settings**

None: the plan varied no setting, switch or build option.
The testers' hardware
Target Report Ran on
linux+nvidia 1 linux+nvidia+nvidia-proprietary+dgpu NVIDIA GeForce RTX 5070, 620.70.6 AMD Ryzen 5 9600X 6-Core Processor, 32 GB RAM
linux+nvidia 2 linux+nvidia+nvidia-proprietary+dgpu NVIDIA GeForce GTX 1060, 580.178.4 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz, 24 GB RAM
linux+radv 1 linux+amd+radv+dgpu AMD Radeon RX 9070 XT (RADV GFX1201), 26.1.99 AMD Ryzen 7 5700X3D 8-Core Processor, 32 GB RAM
linux+radv 2 linux+amd+radv+dgpu AMD Radeon RX 580 Series (RADV POLARIS10), 26.2.7 AMD Ryzen 5 5500F 6-Core Processor, 32 GB RAM
<!-- beanstalk:sticky --> ### Beanstalk test farm · 🔄 testing (4 of 4 reports so far) Commit `38094d7` · approved by futondestroyer (👍 on siantm's request) (reviewed) · [dashboard](https://beanstalk.magicbean.dev/prs/1955) ⚠️ **Note:** The farm cannot compare arbitrary counter-type log sets or enforce one line per observed type; the log probe only checks for the diagnostic's presence and marks its absence unjudged. ⚠️ **Note:** The 5% p99 allowance is a fixed proxy for run-to-run spread, not a statistical test of that spread. The two-minute measurement is stationary after a short movement through the Market. Started at 03:04 UTC. | Target | Result | Reports | Frame time p99 (ms), main → PR | VRAM peak (MB) | Crashes | | --- | --- | --- | --- | --- | --- | | `linux+nvidia` | ⚠️ couldn't be judged (an outlier) | 2 [1](https://beanstalk.magicbean.dev/reports/rp_ce9d3a5b62de9b1b) [2](https://beanstalk.magicbean.dev/reports/rp_d4ccfedbe1569681) | — | — | none | | `linux+radv` | ⚠️ couldn't be judged | 2 [1](https://beanstalk.magicbean.dev/reports/rp_607343a079d2dad4) [2](https://beanstalk.magicbean.dev/reports/rp_d75027fcc9e251bf) | — | — | none | | `windows+intel` | ⏳ queued | 0 of 1 | — | — | — | | `steamdeck` | ⏳ queued | 0 of 1 | — | — | — | **Couldn't be judged**: the tester's PC could not finish the test. The farm tries another PC, or the same one after a fix; it says nothing about the PR on its own. - `linux+nvidia`, [report 1](https://beanstalk.magicbean.dev/reports/rp_ce9d3a5b62de9b1b): `Insufficient frame-time evidence for 1 required comparison(s). See rule results. a step ran out of time at step 2 (wait map Market_Child): timeout: not met in time (then the game was in play on KokiriForest_Child)` - `linux+nvidia`, [report 2](https://beanstalk.magicbean.dev/reports/rp_d4ccfedbe1569681): `Insufficient frame-time evidence for 1 required comparison(s). See rule results. a step ran out of time at step 2 (wait map Market_Child): timeout: not met in time (then the game was in play on KokiriForest_Child)` - `linux+radv`, [report 1](https://beanstalk.magicbean.dev/reports/rp_607343a079d2dad4): `the main base failed (exit 1): build.py stopped (exit status 1): <data>/bases/main/work/sa/build/obj/code_hot_5.split.c:47749:31: error: called object type 'int' is not a function or function pointer` - `linux+radv`, [report 2](https://beanstalk.magicbean.dev/reports/rp_d75027fcc9e251bf): `Insufficient frame-time evidence for 1 required comparison(s). See rule results. a step ran out of time at step 2 (wait map Market_Child): timeout: not met in time (then the game was in play on KokiriForest_Child)` <details><summary>What was tested</summary> **What will be tested** · AI plan (`gpt-6.1-terra`) Compare the PR with main in Castle Town Market on Linux NVIDIA, Linux RADV, Windows Intel and Steam Deck. Each side gets two interleaved runs with a two-minute frame-time measurement; the plan fails on a crash or a p99 regression over 5%. The Windows Intel target will wait for a matching tester. Each tester's game runs take roughly 30 minutes. No tester online now matches windows+intel: that target waits for one. - **Where:** linux+nvidia (1-2 reports), linux+radv (1-2 reports), windows+intel (1-2 reports), steamdeck (1-2 reports). - **castle-town-market:** from the repository's save `kokiri-start`, then teleport to Market, move the stick, take the picture market to compare with main, measure market for 2 min (after 10 s warm-up); 2 runs on each side. - **Measured:** crashes, frame times, stutters and hitches, draws and frame rate, the game's log (an expected line that never appears: could not be judged). - **The PR fails if:** it crashes; or a picture differs from main by more than 5%; or frame time (p99) is more than 5% above main; or expected log lines missing is above 0. - **Time:** about 29 min of game runs per tester (4 game starts), plus the two builds. </details> <details><summary>Measurements on `linux+nvidia`, for the PR description</summary> **Verdict:** could not be judged on linux+nvidia (2 reports): required frame-time comparison inconclusive (fewer than two usable starts per side). Hardware: 1: linux+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 5070, 620.70.6` `AMD Ryzen 5 9600X 6-Core Processor, 32 GB RAM`; 2: linux+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce GTX 1060, 580.178.4` `Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz, 24 GB RAM` Scene: castle-town-market, from the repository's save kokiri-start; each cell's settings and switches as the table names them Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); castle-town-market: 2 game starts a side, market 120 s after 10 s warm-up; each number the median of the runs, then of 2 reports How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again) | | Before: main @ 6e1521a | After: this PR @ 38094d7 | |---|---|---| | castle-town-market · expected log lines missing | 0.0 | 0.0 | **Flags and settings** None: the plan varied no setting, switch or build option. As Markdown for the PR description: ```markdown ## Measurements **Verdict:** could not be judged on linux+nvidia (2 reports): required frame-time comparison inconclusive (fewer than two usable starts per side). Hardware: 1: linux+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 5070, 620.70.6` `AMD Ryzen 5 9600X 6-Core Processor, 32 GB RAM`; 2: linux+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce GTX 1060, 580.178.4` `Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz, 24 GB RAM` Scene: castle-town-market, from the repository's save kokiri-start; each cell's settings and switches as the table names them Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); castle-town-market: 2 game starts a side, market 120 s after 10 s warm-up; each number the median of the runs, then of 2 reports How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again) | | Before: main @ 6e1521a | After: this PR @ 38094d7 | |---|---|---| | castle-town-market · expected log lines missing | 0.0 | 0.0 | **Flags and settings** None: the plan varied no setting, switch or build option. ``` </details> <details><summary>Measurements on `linux+radv`, for the PR description</summary> **Verdict:** could not be judged on linux+radv (2 reports): required frame-time comparison inconclusive (fewer than two usable starts per side). Hardware: 1: linux+amd+radv+dgpu `AMD Radeon RX 9070 XT (RADV GFX1201), 26.1.99` `AMD Ryzen 7 5700X3D 8-Core Processor, 32 GB RAM`; 2: linux+amd+radv+dgpu `AMD Radeon RX 580 Series (RADV POLARIS10), 26.2.7` `AMD Ryzen 5 5500F 6-Core Processor, 32 GB RAM` Scene: castle-town-market, from the repository's save kokiri-start; each cell's settings and switches as the table names them Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); castle-town-market: 2 game starts a side, market 120 s after 10 s warm-up; each number the median of the runs, then of 2 reports How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again) | | Before: main @ 6e1521a | After: this PR @ 38094d7 | |---|---|---| | castle-town-market · expected log lines missing | 0.0 | 0.0 | **Flags and settings** None: the plan varied no setting, switch or build option. As Markdown for the PR description: ```markdown ## Measurements **Verdict:** could not be judged on linux+radv (2 reports): required frame-time comparison inconclusive (fewer than two usable starts per side). Hardware: 1: linux+amd+radv+dgpu `AMD Radeon RX 9070 XT (RADV GFX1201), 26.1.99` `AMD Ryzen 7 5700X3D 8-Core Processor, 32 GB RAM`; 2: linux+amd+radv+dgpu `AMD Radeon RX 580 Series (RADV POLARIS10), 26.2.7` `AMD Ryzen 5 5500F 6-Core Processor, 32 GB RAM` Scene: castle-town-market, from the repository's save kokiri-start; each cell's settings and switches as the table names them Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); castle-town-market: 2 game starts a side, market 120 s after 10 s warm-up; each number the median of the runs, then of 2 reports How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again) | | Before: main @ 6e1521a | After: this PR @ 38094d7 | |---|---|---| | castle-town-market · expected log lines missing | 0.0 | 0.0 | **Flags and settings** None: the plan varied no setting, switch or build option. ``` </details> <details><summary>The testers' hardware</summary> | Target | Report | Ran on | | --- | --- | --- | | `linux+nvidia` | [1](https://beanstalk.magicbean.dev/reports/rp_ce9d3a5b62de9b1b) | linux+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 5070, 620.70.6` `AMD Ryzen 5 9600X 6-Core Processor, 32 GB RAM` | | `linux+nvidia` | [2](https://beanstalk.magicbean.dev/reports/rp_d4ccfedbe1569681) | linux+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce GTX 1060, 580.178.4` `Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz, 24 GB RAM` | | `linux+radv` | [1](https://beanstalk.magicbean.dev/reports/rp_607343a079d2dad4) | linux+amd+radv+dgpu `AMD Radeon RX 9070 XT (RADV GFX1201), 26.1.99` `AMD Ryzen 7 5700X3D 8-Core Processor, 32 GB RAM` | | `linux+radv` | [2](https://beanstalk.magicbean.dev/reports/rp_d75027fcc9e251bf) | linux+amd+radv+dgpu `AMD Radeon RX 580 Series (RADV POLARIS10), 26.2.7` `AMD Ryzen 5 5500F 6-Core Processor, 32 GB RAM` | </details>
Author
Contributor

@futondestroyer, on your review: there is no code change this round, so the head stays 38094d72, the commit the farm run you approved is testing. None of the following has run yet:

  • Warmed, interleaved runs of this head against main @ 6e1521a7 in the Market and in a heavy scene (average fps, 1 % lows, median and p99 frame times). The pack of main @ 6e1521a7 they need is waiting in this PC's job queue.
  • One nvn: the game reports counter type line per observed type below 64 on each fresh start, and a separate HOS_HLE_STATS=1 pass that counts nvnCommandBufferReportCounter calls in each scene, kept out of the frame-time runs. Both are asked of whoever does the game runs on this PC, with the pair above.
  • Windows with an AMD GPU, my own Windows game run, the full suite and CI on this head.
@futondestroyer, on [your review](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1955#issuecomment-62853): there is no code change this round, so the head stays 38094d72, the commit the farm run you approved is testing. None of the following has run yet: - Warmed, interleaved runs of this head against `main` @ 6e1521a7 in the Market and in a heavy scene (average fps, 1 % lows, median and p99 frame times). The pack of `main` @ 6e1521a7 they need is waiting in this PC's job queue. - One `nvn: the game reports counter type` line per observed type below 64 on each fresh start, and a separate `HOS_HLE_STATS=1` pass that counts `nvnCommandBufferReportCounter` calls in each scene, kept out of the frame-time runs. Both are asked of whoever does the game runs on this PC, with the pair above. - Windows with an AMD GPU, my own Windows game run, the full suite and CI on this head.
Some checks reported errors
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Website build and checks (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 4s
Website / Website on Cloudflare (pull_request_target) Has been skipped
beanstalk/linux+nvidia 0/1 pass, 2 error
beanstalk/linux+radv 0/1 pass, 2 error
beanstalk/windows+intel 0/1 pass, 0 running, 2 queued
beanstalk/approval approved by futondestroyer (reviewed)
beanstalk/steamdeck 0/1 pass, 0 running, 2 queued
This pull request is marked as a work in progress.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'perf/nvn-report-counter-flag:siantm-perf/nvn-report-counter-flag'
git switch 'siantm-perf/nvn-report-counter-flag'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1955
No description provided.