fix(vk): a program cache format change keeps the programs, the driver's pipelines and the notes #1926

Merged
HumanBean merged 2 commits from madebyjordan/Longshot:fix/pipelines-outlive-cache-format into main 2026-11-21 00:46:04 +00:00
Member

Summary

What was wrong: after updating to nightly-622, players with full shader caches saw the preparation start again and crawl. On my PC (RX 6700 XT) the launcher's preparation took 83 minutes (18:30 to 19:53, after a 30-minute build). People on Discord report the same.

The cause, my own #1809:

  • #1809 raised kProgramCacheFormat from 1 to 3. That's a change to how longshot_programs.bin lays out a record; the SPIR-V it holds is identical.
  • But every cache file is stamped with program_cache_stamp(), which mixes the format into the translator's stamp.
  • So the first start of nightly-622 threw away far more than the program file:
    • the driver's pipeline cache (longshot_vk_pipelines.bin, 1.88 GB here);
    • the pipeline notes (longshot_pipelines.bin, truncated to its head);
    • the precompile's .built record;
    • the prediction's keys and sample;
    • the module identifiers.
  • The preparation then compiled every pipeline with nothing in the driver's cache, though every one of those pipelines was still good.
  • #1809's Risks said "every player prepares once after updating", from a dev runtime's translation-only preparation (118.7 s). The launcher's --compile-shaders most path, where the cost is, wasn't measured. That's my mistake.

How to see it on main: take a folder prepared by nightly-618 or earlier and update it to nightly-622. The first start logs vk: pipeline cache: N files made for another translator dropped, although the translator's stamped files (nx2/translator_files.py) are byte-identical between nightly-612 and nightly-622. The preparation then builds every pipeline cold.

What this changes:

  • The pipeline side is judged by a new pipelines_stamp_ok(), which takes this translator's stamp under the current program cache format or any earlier one. What these files hold (pipelines, program keys and variants, module identifiers) depends on the SPIR-V, not on the program file's layout.
  • The program file and longshot_prepared.bin still start over with the format: the programs are translated again (about 2 minutes), and the preparation finds every pipeline in the driver's cache. (An earlier head also adopted format-1 program files as they were. #1448 has since moved the translator's stamp, so no format-1 file can be of a current translator any more, and that code would never run: it's gone. BeanBot's review and fix for it are answered by its removal.)
  • Another translator still drops everything here, as before. #1927 carries the pipeline side across a translator change too.

The result: a future format bump costs a translation pass (about 2 minutes here) and a warm against a full driver cache, instead of a cold compile of every pipeline. Players who already started 622 have lost theirs; this can't bring them back. The next nightly also moves the translator's stamp (#1448): keeping the caches across that is #1927 with LongshotLauncher #220.

Read first:

  • gpu/vk/vk_progcache.cpp: program_cache_stamp_of, pipelines_stamp_ok, and the header comment's rule: a format bump can no longer drop the pipeline side, so a change to the SPIR-V, the keys or the variants belongs in the translator's stamp.
  • gpu/vk/pcache_stamp.h (check's also) and gpu/vk/module_ids.h (open's also).
  • gpu/vk/vk_draw.cpp: every reader of a pipeline-side head.

See #1510 (mooki's proposal to take sizeof(Program) out of the same stamp, the other way it drops every cache needlessly) and #1809.

Testing

Tested: Windows 11 Home 26200, AMD Radeon RX 6700 XT, Ryzen 5 5600.

  • In the game, on the launcher's path (longshot.exe --prepare-shaders --compile-shaders most, as make_game.py runs it). This was a dev runtime of the stacked branch #1927, which contains this one, with a test-only commit raising kProgramCacheFormat to 4: a format bump on one translator.

    • Its cache/ was seeded with a copy of my prepared nightly-622 folder's caches: format 3, 1.88 GB driver cache, 1 GB notes.
    • It ran from a new folder path, so AMD's own driver cache was cold, as after an update's folder rename.
    • The log: no files made for another translator dropped line; pipeline notes ...: stamped as the notes' own; program cache ...: 0 program keys kept (translated again, as intended).
    • Then prepared 38809 shader programs ... in 125.3 s and precompile: 38024 noted pipelines ... built into the pipeline cache ... (0 and 0 not made ...) in 6.7 s, with the pipeline cache not written: nothing new (every pipeline a hit).
    • About 2¼ minutes in all, against 83 minutes for nightly-622 on the same PC.
  • New check, its own commit: tests/test_pipelines_outlive_cache_format.py, with clang++ and g++ from llvm-mingw.

    • It compiles the real pcache_drop_stale() and notes_open_locked(), cut from vk_draw.cpp, with program_cache_stamp() cut from vk_progcache.cpp, as builds of one translator at format 1, the current format minus one, and the current one, plus a build of another translator.
    • An older build writes a stamped pipeline cache and three notes; the newer one opens them.
    • It also checks that every other reader of the pipeline side judges its head by pipelines_stamp_ok.
    • On main (a104182b), it fails: format 1 → 3 gives pipeline cache dropped (-1 bytes), 0 notes kept, notes file 16 bytes, and all six other readers are still on the exact stamp.
    • Here, it passes: pipeline cache kept (3000 bytes), 3 notes kept, notes file 400 bytes, and another translator is still dropped.
  • Broken variants of the fix, each caught:

    • only the current format accepted;
    • every stamp accepted (another translator is then kept);
    • the notes reopened on the exact stamp (the notes are then truncated);
    • pipe_notes_refs left on the exact stamp.
  • Checks that read the changed source:

    • Updated, not weakened: test_pcache_stamp (plus check's also), test_module_ids (plus open's also, appended to as it is), test_program_cache_format (plus the rule for earlier formats), test_predicted_check (now "another translator"), and stand-ins in test_note_refs_once, test_precompile_warm_computes and test_state_list_part_record.
    • They follow the move into program_cache_stamp_of: test_dev_packs and test_native_float_atomic_add. The latter was run with the cpm headers; Windows skips it by default.
  • The whole suite (tests/run_all.py --strict, what mise run test runs; Windows, llvm-mingw), on this head and on main 87c0d7b4: 709 passed, 143 failed, 48 skipped here; 708, 143, 48 on main. The same 143 fail and the same 48 skip on both (tools this PC lacks, such as the Vulkan headers and spirv-val, and Windows-only differences); the one more pass is this PR's check. Rebased onto 87c0d7b4 (#1448) with no conflict.

  • Compiled whole: vk_progcache.cpp, vk_programs.cpp and vk_draw.cpp with -fsyntax-only -Wall -Wextra and the build's include folders. They give the same 132 warnings and the same 4 errors as main (the errors come from target flags my command lacks).

  • Cold review by a second agent (code only). It found nothing unsafe:

    • format 2 never shipped;
    • #1809 touched no stamped translator file, so program keys, variants, NvnState and PipeNote are unchanged;
    • SPIR-V words are stored unchanged, so module identifiers stay valid;
    • every other program_cache_stamp() user is handled.

    It caught test_dev_packs, test_native_float_atomic_add and the untested readers, all fixed here.

Still to test:

  • linux and windows nvidia: a folder prepared by nightly-622, then this branch with kProgramCacheFormat raised by one: expecting no files made for another translator dropped line and a preparation of minutes, not a cold compile (@Beanstalk)

Measurements

Verdict: after a format bump the launcher's preparation takes about 2¼ minutes instead of 83: the driver cache and the notes are kept, so only the programs are translated again.

Setup: Windows 11, RX 6700 XT, Ryzen 5 5600; the launcher's preparation (--prepare-shaders --compile-shaders most) over a folder prepared by nightly-622, AMD's own driver cache cold (a new folder path). One run each, since the gap is 37×.

Before: main @ fb14ba0b (nightly-622, the format bump from 1 to 3) After: this PR @ 744a2329 (run as #1927's 06028484, which contains it, plus a test commit raising the format from 3 to 4)
driver pipeline cache dropped (1.88 GB) kept
translation every program every program, 125.3 s
noted pipelines 38,024 compiled cold 38,024 from the cache, 6.7 s
the preparation in all 83 min about 2¼ min

Risks

  • What players notice: at the next format bump, the preparation translates the programs again (about 2 minutes) instead of compiling every pipeline. Today's players: nothing changes, their files are format 3, as this build's are.
  • What could break: a pipeline-side file of an earlier format being read as good. Nothing in those files depends on the program file's layout (Summary, and the cold review's check). From now on, a change that alters the SPIR-V, the keys or the variants must move the translator's stamp, not only the format. The header comment says so.
  • Downgrade: a build of an earlier format reads a pipeline stamp file this build left as it found it, so it keeps the driver cache too.
  • To turn it off: a revert. There's no switch.

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit.
  • Tested on my own PC, in the game for a change the game runs, as Testing says.
  • mise run test passes (any failure that also fails on main is named).
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • A fix: a game-free test that fails on main and passes here.
  • A check under tests/ that reads changed source is updated, not weakened.
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested.
  • Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers").
  • Approved in review, every comment answered.
  • CI passes on the head; on current main, measured again or a comment says why the numbers still hold.

🤖 Generated with Claude Code

## Summary **What was wrong:** after updating to nightly-622, players with full shader caches saw the preparation start again and crawl. On my PC (RX 6700 XT) the launcher's preparation took **83 minutes** (18:30 to 19:53, after a 30-minute build). People on Discord report the same. **The cause, my own #1809:** - #1809 raised `kProgramCacheFormat` from 1 to 3. That's a change to how `longshot_programs.bin` lays out a record; the SPIR-V it holds is identical. - But every cache file is stamped with `program_cache_stamp()`, which mixes the format into the translator's stamp. - So the first start of nightly-622 threw away far more than the program file: - the driver's pipeline cache (`longshot_vk_pipelines.bin`, 1.88 GB here); - the pipeline notes (`longshot_pipelines.bin`, truncated to its head); - the precompile's `.built` record; - the prediction's keys and sample; - the module identifiers. - The preparation then compiled every pipeline with nothing in the driver's cache, though every one of those pipelines was still good. - #1809's Risks said "every player prepares once after updating", from a dev runtime's translation-only preparation (118.7 s). The launcher's `--compile-shaders most` path, where the cost is, wasn't measured. That's my mistake. **How to see it on main:** take a folder prepared by nightly-618 or earlier and update it to nightly-622. The first start logs `vk: pipeline cache: N files made for another translator dropped`, although the translator's stamped files (`nx2/translator_files.py`) are byte-identical between nightly-612 and nightly-622. The preparation then builds every pipeline cold. **What this changes:** - **The pipeline side** is judged by a new `pipelines_stamp_ok()`, which takes this translator's stamp under the current program cache format or any earlier one. What these files hold (pipelines, program keys and variants, module identifiers) depends on the SPIR-V, not on the program file's layout. - **The program file** and `longshot_prepared.bin` still start over with the format: the programs are translated again (about 2 minutes), and the preparation finds every pipeline in the driver's cache. (An earlier head also adopted format-1 program files as they were. #1448 has since moved the translator's stamp, so no format-1 file can be of a current translator any more, and that code would never run: it's gone. BeanBot's review and fix for it are answered by its removal.) - Another translator still drops everything here, as before. #1927 carries the pipeline side across a translator change too. **The result:** a future format bump costs a translation pass (about 2 minutes here) and a warm against a full driver cache, instead of a cold compile of every pipeline. Players who already started 622 have lost theirs; this can't bring them back. The next nightly also moves the translator's stamp (#1448): keeping the caches across that is #1927 with LongshotLauncher #220. Read first: - `gpu/vk/vk_progcache.cpp`: `program_cache_stamp_of`, `pipelines_stamp_ok`, and the header comment's rule: a format bump can no longer drop the pipeline side, so a change to the SPIR-V, the keys or the variants belongs in the translator's stamp. - `gpu/vk/pcache_stamp.h` (`check`'s `also`) and `gpu/vk/module_ids.h` (`open`'s `also`). - `gpu/vk/vk_draw.cpp`: every reader of a pipeline-side head. See #1510 (mooki's proposal to take `sizeof(Program)` out of the same stamp, the other way it drops every cache needlessly) and #1809. ## Testing **Tested:** Windows 11 Home 26200, AMD Radeon RX 6700 XT, Ryzen 5 5600. - **In the game, on the launcher's path** (`longshot.exe --prepare-shaders --compile-shaders most`, as `make_game.py` runs it). This was a dev runtime of the stacked branch #1927, which contains this one, with a test-only commit raising `kProgramCacheFormat` to 4: a format bump on one translator. - Its `cache/` was seeded with a copy of my prepared nightly-622 folder's caches: format 3, 1.88 GB driver cache, 1 GB notes. - It ran from a new folder path, so AMD's own driver cache was cold, as after an update's folder rename. - The log: no `files made for another translator dropped` line; `pipeline notes ...: stamped as the notes' own`; `program cache ...: 0 program keys kept` (translated again, as intended). - Then `prepared 38809 shader programs ... in 125.3 s` and `precompile: 38024 noted pipelines ... built into the pipeline cache ... (0 and 0 not made ...) in 6.7 s`, with `the pipeline cache not written: nothing new` (every pipeline a hit). - **About 2¼ minutes in all, against 83 minutes for nightly-622 on the same PC.** - **New check, its own commit:** `tests/test_pipelines_outlive_cache_format.py`, with clang++ and g++ from llvm-mingw. - It compiles the real `pcache_drop_stale()` and `notes_open_locked()`, cut from `vk_draw.cpp`, with `program_cache_stamp()` cut from `vk_progcache.cpp`, as builds of one translator at format 1, the current format minus one, and the current one, plus a build of another translator. - An older build writes a stamped pipeline cache and three notes; the newer one opens them. - It also checks that every other reader of the pipeline side judges its head by `pipelines_stamp_ok`. - **On main (`a104182b`), it fails:** format 1 → 3 gives `pipeline cache dropped (-1 bytes), 0 notes kept, notes file 16 bytes`, and all six other readers are still on the exact stamp. - **Here, it passes:** `pipeline cache kept (3000 bytes), 3 notes kept, notes file 400 bytes`, and another translator is still `dropped`. - **Broken variants of the fix, each caught:** - only the current format accepted; - every stamp accepted (another translator is then kept); - the notes reopened on the exact stamp (the notes are then truncated); - `pipe_notes_refs` left on the exact stamp. - **Checks that read the changed source:** - Updated, not weakened: `test_pcache_stamp` (plus `check`'s `also`), `test_module_ids` (plus `open`'s `also`, appended to as it is), `test_program_cache_format` (plus the rule for earlier formats), `test_predicted_check` (now "another translator"), and stand-ins in `test_note_refs_once`, `test_precompile_warm_computes` and `test_state_list_part_record`. - They follow the move into `program_cache_stamp_of`: `test_dev_packs` and `test_native_float_atomic_add`. The latter was run with the cpm headers; Windows skips it by default. - **The whole suite** (`tests/run_all.py --strict`, what `mise run test` runs; Windows, llvm-mingw), on this head and on main `87c0d7b4`: 709 passed, 143 failed, 48 skipped here; 708, 143, 48 on main. The same 143 fail and the same 48 skip on both (tools this PC lacks, such as the Vulkan headers and spirv-val, and Windows-only differences); the one more pass is this PR's check. Rebased onto `87c0d7b4` (#1448) with no conflict. - **Compiled whole:** `vk_progcache.cpp`, `vk_programs.cpp` and `vk_draw.cpp` with `-fsyntax-only -Wall -Wextra` and the build's include folders. They give the same 132 warnings and the same 4 errors as main (the errors come from target flags my command lacks). - **Cold review** by a second agent (code only). It found nothing unsafe: - format 2 never shipped; - #1809 touched no stamped translator file, so program keys, variants, `NvnState` and `PipeNote` are unchanged; - SPIR-V words are stored unchanged, so module identifiers stay valid; - every other `program_cache_stamp()` user is handled. It caught `test_dev_packs`, `test_native_float_atomic_add` and the untested readers, all fixed here. **Still to test:** - linux and windows nvidia: a folder prepared by nightly-622, then this branch with `kProgramCacheFormat` raised by one: expecting no `files made for another translator dropped` line and a preparation of minutes, not a cold compile (@Beanstalk) ## Measurements **Verdict:** after a format bump the launcher's preparation takes about 2¼ minutes instead of 83: the driver cache and the notes are kept, so only the programs are translated again. Setup: Windows 11, RX 6700 XT, Ryzen 5 5600; the launcher's preparation (`--prepare-shaders --compile-shaders most`) over a folder prepared by nightly-622, AMD's own driver cache cold (a new folder path). One run each, since the gap is 37×. | | Before: main @ fb14ba0b (nightly-622, the format bump from 1 to 3) | After: this PR @ 744a2329 (run as #1927's 06028484, which contains it, plus a test commit raising the format from 3 to 4) | |---|---|---| | driver pipeline cache | dropped (1.88 GB) | kept | | translation | every program | every program, 125.3 s | | noted pipelines | 38,024 compiled cold | 38,024 from the cache, 6.7 s | | the preparation in all | **83 min** | **about 2¼ min** | ## Risks - **What players notice:** at the next format bump, the preparation translates the programs again (about 2 minutes) instead of compiling every pipeline. Today's players: nothing changes, their files are format 3, as this build's are. - **What could break:** a pipeline-side file of an earlier format being read as good. Nothing in those files depends on the program file's layout (Summary, and the cold review's check). From now on, a change that alters the SPIR-V, the keys or the variants must move the translator's stamp, not only the format. The header comment says so. - **Downgrade:** a build of an earlier format reads a pipeline stamp file this build left as it found it, so it keeps the driver cache too. - **To turn it off:** a revert. There's no switch. ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. - [x] Tested on my own PC, in the game for a change the game runs, as Testing says. - [x] `mise run test` passes (any failure that also fails on `main` is named). - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [x] A fix: a game-free test that fails on `main` and passes here. - [x] A check under `tests/` that reads changed source is updated, not weakened. - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. ### Ready to merge - [ ] Everything in Still to test has run, its results in Tested. - [ ] Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers"). - [ ] Approved in review, every comment answered. - [ ] CI passes on the head; on current `main`, measured again or a comment says why the numbers still hold. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
#1809 raised kProgramCacheFormat from 1 to 3, which changes how
longshot_programs.bin lays out a stage stored in the shader store, not
the SPIR-V. Every cache file is stamped with program_cache_stamp() (the
translator's stamp mixed with the format), so nightly-622's first start
dropped the driver's pipeline cache, truncated the pipeline notes and
started the program file over: every program translated again and every
pipeline compiled again cold.

The check compiles the real pcache_drop_stale() and notes_open_locked()
as two builds of one translator, format 1 and the current one: the second
must keep the first's pipeline cache and notes; another translator must
still drop them. Every other reader of the pipeline side must judge its
head by pipelines_stamp_ok. And program_file_head(), which disk_init
asks, must adopt a format 1 program file of this translator with no
store, and start over on format 2, another translator, a compressed
file, a store named, a head cut short or another magic. It fails on
main: the pipeline cache dropped, the notes cut to their head, no
adoption.

Assisted-by: Claude Code (Claude Opus 5.5)
fix(vk): a program cache format change keeps the programs, the driver's pipelines and the notes
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 9s
CI / Workflow lint (actionlint) (pull_request) Successful in 15s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 16s
Third-party parts / As their notes say (pull_request) Successful in 18s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Failing after 9s
CI / Website build and checks (pull_request) Has been cancelled
37715c273d
kProgramCacheFormat is about how longshot_programs.bin lays out a record;
the SPIR-V, the program keys and their variants, and so every pipeline
the driver keeps, are the same across a format change. But every file of
the caches was judged by program_cache_stamp(), the translator's stamp
mixed with the format, so #1809's 1 -> 3 made nightly-622's first start
translate every program again and compile every pipeline again cold:
hours on AMD, for programs and pipelines the player already had.

The program file: a format 1 file of this translator, with no store, is
adopted as it is (program_file_head; its head stamped as this format's
before anything is appended, or the file started over if that write
fails). Formats 2 and 3 only added the shader store's kind of stage code;
a format 1 stage ([u64 words][words]) is read as it always was. Format 2
never shipped and its references carry no hash: never adopted. Nor a
compressed file (RX_VK_PROGRAM_CACHE_ZSTD).

The pipeline side: pipelines_stamp_ok() takes this translator's stamp
under the current format or any earlier one (their stamps made once),
and the pipeline cache's files (pcache_stamp::check's `also`, the stamp
file left as it was, so a build of that format keeps them too), the
notes (read, reopened for play's new ones, their references), the
precompile's .built record, the prediction's keys and sample, and
longshot_module_ids.bin (module_ids::Store::open's `also`) are judged by
it. Files written now keep the current stamp. longshot_prepared.bin
still starts over with the format: the preparation runs, finding every
program kept and every pipeline in the driver's cache. Another
translator still drops them all, as before.

A format bump can no longer drop the pipeline side: vk_progcache.cpp's
header says a change to the SPIR-V, the keys or the variants belongs in
the translator's stamp. test_dev_packs, test_native_float_atomic_add and
test_program_cache_format follow program_cache_stamp's move into
program_cache_stamp_of and the head's into program_file_head.

Assisted-by: Claude Code (Claude Opus 5.5)
Author
Member

Tested in game: Windows 11, RX 6700 XT: the launcher's preparation (--prepare-shaders --compile-shaders most) of a dev runtime of the stacked translator branch (contains this one) with kProgramCacheFormat raised to 4, over a copy of my prepared nightly-622 caches, AMD's own driver cache cold: no 'dropped' line, notes kept and restamped, 38809 programs translated in 125.3 s, 38024 noted pipelines from the cache in 6.7 s: about 2 1/4 minutes against 83 for nightly-622.

Tested in game: Windows 11, RX 6700 XT: the launcher's preparation (--prepare-shaders --compile-shaders most) of a dev runtime of the stacked translator branch (contains this one) with kProgramCacheFormat raised to 4, over a copy of my prepared nightly-622 caches, AMD's own driver cache cold: no 'dropped' line, notes kept and restamped, 38809 programs translated in 125.3 s, 38024 noted pipelines from the cache in 6.7 s: about 2 1/4 minutes against 83 for nightly-622.
Member

Possibly related, for context:

  • issue #1551 Windows on ARM (Snapdragon X Elite, Adreno X1-85): "Loading pipelines" takes ~42 min on every start, pipeline cache is not reused — Repeated pipeline loading/cache reuse issue may overlap with retaining pipeline cache across format changes
  • issue #1706 Install: Intel Arc A730 shader and pipeline preparation takes hours — Extreme shader/pipeline preparation duration may be mitigated by preserving caches
Possibly related, for context: - issue #1551 Windows on ARM (Snapdragon X Elite, Adreno X1-85): "Loading pipelines" takes ~42 min on every start, pipeline cache is not reused — Repeated pipeline loading/cache reuse issue may overlap with retaining pipeline cache across format changes - issue #1706 Install: Intel Arc A730 shader and pipeline preparation takes hours — Extreme shader/pipeline preparation duration may be mitigated by preserving caches
BeanBot left a comment

Recommendation: Request changes. Format-1 adoption remains enabled after any future program-cache format bump, even when the new format changes the record layout. The actual adoption and restamping path also lacks a behavior test or an in-game run.

The change keeps pipeline-side caches across program-cache format changes and adopts compatible format-1 program files. That could avoid long shader preparation, but unconditional future adoption risks reading incompatible records, and the main migration path has not been demonstrated end to end.

Does it help: Unproven for the affected format-1 upgrade. The author reports about 2¼ minutes versus 83 minutes on an RX 6700 XT, but those are single runs of different format transitions and the faster run used a stacked branch. It did not exercise format-1 adoption.
Other systems: The change affects pipeline caches, notes, predictions and module identifiers on Windows and Linux across GPU vendors. The reported run covers Windows AMD; Linux, NVIDIA, Steam Deck and an actual format-1 upgrade remain unverified. The module-identifier reader still checks the driver UUID.
Switches: None added, changed or removed.

Reviewed: 37715c273d against a104182b40: Read AGENTS.md, CONTRIBUTING.md, the PR template, standards, commits and the production diff. Read the changed cache headers and relevant loader, stamp and notes code; skimmed the changed tests and the remaining large production files. Tooling's AGENTS.md was unavailable beside the checkout, and docs/review-checklist.md was absent. Not all changed code files were read in full.; nothing run (a code review).
Checked and fine:

  • The pipeline cache retains the earlier stamp, allowing an older build to recognize it.
  • The program-cache file lock covers scanning and restamping.
  • No generated files or third-party files are changed.

Blocking (to change before merge)

  1. gpu/vk/vk_progcache.cpp:99: Format-1 adoption is unconditional on the current format. If a future format 4 changes the record layout while leaving the translator unchanged, a player upgrading directly from format 1 will have the old file restamped as format 4 and read with the new layout. Restrict adoption to explicitly compatible destination formats, and make a future format bump require an explicit compatibility decision.
  2. tests/test_pipelines_outlive_cache_format.py:120: The adoption check calls only the header classifier; it does not exercise disk_init, restamping, loading inline stages or appending and reopening records. A broken adoption implementation can pass this check. Add a game-free test that loads a representative format-1 file through the real migration path, verifies its programs and appended records after reopening, and fails on the base.

Suggestions (the author may take or leave)

  • Measure the actual format-1 upgrade against the base with repeated comparable runs, including cold and warm startup and cache sizes.

Testing: No code, tests or project scripts were run, as requested. The author's reported checks and hardware run were reviewed as evidence.
Overlaps and merge order: The description mentions #1510, #1809 and a stacked #NEXT; their current status and merge order could not be verified offline.


Automated code review by BeanBot (gpt-6.1-terra), on the pull request's opening. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** Format-1 adoption remains enabled after any future program-cache format bump, even when the new format changes the record layout. The actual adoption and restamping path also lacks a behavior test or an in-game run. The change keeps pipeline-side caches across program-cache format changes and adopts compatible format-1 program files. That could avoid long shader preparation, but unconditional future adoption risks reading incompatible records, and the main migration path has not been demonstrated end to end. **Does it help:** Unproven for the affected format-1 upgrade. The author reports about 2¼ minutes versus 83 minutes on an RX 6700 XT, but those are single runs of different format transitions and the faster run used a stacked branch. It did not exercise format-1 adoption. **Other systems:** The change affects pipeline caches, notes, predictions and module identifiers on Windows and Linux across GPU vendors. The reported run covers Windows AMD; Linux, NVIDIA, Steam Deck and an actual format-1 upgrade remain unverified. The module-identifier reader still checks the driver UUID. **Switches:** None added, changed or removed. **Reviewed:** 37715c273d0f against a104182b4037: Read AGENTS.md, CONTRIBUTING.md, the PR template, standards, commits and the production diff. Read the changed cache headers and relevant loader, stamp and notes code; skimmed the changed tests and the remaining large production files. Tooling's AGENTS.md was unavailable beside the checkout, and docs/review-checklist.md was absent. Not all changed code files were read in full.; nothing run (a code review). **Checked and fine:** - The pipeline cache retains the earlier stamp, allowing an older build to recognize it. - The program-cache file lock covers scanning and restamping. - No generated files or third-party files are changed. **Blocking** (to change before merge) 1. gpu/vk/vk_progcache.cpp:99: Format-1 adoption is unconditional on the current format. If a future format 4 changes the record layout while leaving the translator unchanged, a player upgrading directly from format 1 will have the old file restamped as format 4 and read with the new layout. Restrict adoption to explicitly compatible destination formats, and make a future format bump require an explicit compatibility decision. 2. tests/test_pipelines_outlive_cache_format.py:120: The adoption check calls only the header classifier; it does not exercise disk_init, restamping, loading inline stages or appending and reopening records. A broken adoption implementation can pass this check. Add a game-free test that loads a representative format-1 file through the real migration path, verifies its programs and appended records after reopening, and fails on the base. **Suggestions** (the author may take or leave) - Measure the actual format-1 upgrade against the base with repeated comparable runs, including cold and warm startup and cache sizes. **Testing:** No code, tests or project scripts were run, as requested. The author's reported checks and hardware run were reviewed as evidence. **Overlaps and merge order:** The description mentions #1510, #1809 and a stacked #NEXT; their current status and merge order could not be verified offline. --- <sub>Automated code review by BeanBot (gpt-6.1-terra), on the pull request's opening. Nothing was run; a maintainer decides.</sub>
@ -82,0 +96,4 @@
FileHead program_file_head(bool whole, uint32_t magic, uint32_t want_magic, uint32_t store, uint64_t kept, bool zstd) {
if (!whole || magic != want_magic) return FileHead::Over;
if (kept == program_cache_stamp()) return FileHead::Take;
if (!zstd && !store && kept == program_cache_stamp_of(1)) return FileHead::Adopt;
Member

This also adopts format 1 after any future format bump. If format 4 changes the record layout without changing the translator, a direct format-1 upgrade will restamp incompatible records as format 4. Please limit adoption to explicitly compatible destination formats and require a decision at the next bump.

This also adopts format 1 after any future format bump. If format 4 changes the record layout without changing the translator, a direct format-1 upgrade will restamp incompatible records as format 4. Please limit adoption to explicitly compatible destination formats and require a decision at the next bump.
@ -0,0 +117,4 @@
return 2;
}
"""
Member

This exercises the header decision but not the migration itself. Please test a representative format-1 file through disk_init, including loading its inline stages, restamping, appending and reopening, so the check catches a broken adoption path.

This exercises the header decision but not the migration itself. Please test a representative format-1 file through disk_init, including loading its inline stages, restamping, appending and reopening, so the check catches a broken adoption path.
HumanBean changed title from WIP: fix(vk): a program cache format change keeps the programs, the driver's pipelines and the notes to fix(vk): a program cache format change keeps the programs, the driver's pipelines and the notes 2026-11-21 00:04:07 +00:00
Owner
@fix
Member

I changed this pull request as the review asked: the new head is f5d014207c.

Changed

  • Format-1 adoption and migration test: Restricted adoption to format 3 and added a compile-time check requiring a decision on the next format bump (gpu/vk/vk_progcache.cpp:59). Added a game-free test covering disk initialization, restamping, inline-stage loading, appending and reopening (tests/test_pipelines_outlive_cache_format.py:160). Nothing was run, as requested.
  • Format-1 migration fixture: tests/test_pipelines_outlive_cache_format.py:172: Defined the historical record and Shader::Info layout independently, used the real shader type in the reader, and checked a descriptor after adoption and reopening. Nothing was run.

Nothing was built or run: check the change. It will be reviewed again.


Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

I changed this pull request as the review asked: the new head is f5d014207cdb. **Changed** - **Format-1 adoption and migration test**: Restricted adoption to format 3 and added a compile-time check requiring a decision on the next format bump (gpu/vk/vk_progcache.cpp:59). Added a game-free test covering disk initialization, restamping, inline-stage loading, appending and reopening (tests/test_pipelines_outlive_cache_format.py:160). Nothing was run, as requested. - **Format-1 migration fixture: tests/test_pipelines_outlive_cache_format.py:172**: Defined the historical record and Shader::Info layout independently, used the real shader type in the reader, and checked a descriptor after adoption and reopening. Nothing was run. Nothing was built or run: check the change. It will be reviewed again. --- <sub>Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
fix(vk): guard format-1 cache adoption and test migration
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Failing after 27s
CI / Conventional Commit title (pull_request) Successful in 24s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 36s
CI / Workflow lint (actionlint) (pull_request) Successful in 39s
Third-party parts / As their notes say (pull_request) Successful in 46s
CI / Website build and checks (pull_request) Has been cancelled
f5d014207c
As the review on #1926 asked.
BeanBot left a comment

Recommendation: Request changes. Keeping compatible caches addresses the cause of the long preparation, but the Builder can still overwrite compatible notes and several game-free checks break at this head. The reported timing used a different format transition on a stacked build, and current main changes the translator stamp this migration requires.

The renderer keeps pipeline caches, notes, prediction files and module identifiers across program-cache format bumps when the translator stamp matches. It also adopts inline format-1 program records into format 3. This can save translation and cold pipeline compilation, at the cost of keeping larger local cache files and maintaining an explicit migration path.

Does it help: Unproven for the release upgrade. The author reports 83 minutes on nightly-622 for 1→3 and about 2¼ minutes on a stacked #1927 dev build for 3→4 on the same Windows RX 6700 XT. The faster run translated 38,809 programs in 125.3 seconds and warmed 38,024 noted pipelines in 6.7 seconds. Each side ran once. The comparison does not exercise format-1 adoption or identify the gain on this head against its base. Current main also changes the translator stamp.
Other systems: The change reaches pipeline load and warm-up, load-at-create, prediction and module ID lookup on every Vulkan vendor and both OSes. The Vulkan cache still checks the vendor, device and cache UUID, and module IDs still check the algorithm UUID. The Builder's optional seed copy can replace old notes before the renderer checks them. Adoption keeps the old inline SPIR-V on disk even with the shared store enabled. Linux, RADV, NVIDIA and Steam Deck runtime coverage remains pending. The diff leaves replay ordering, saves, audio and input code untouched.
Switches: None added, changed or removed. The migration fixture disables the existing shader store for its test processes.

Reviewed: f5d014207c against a104182b40: Read AGENTS.md, CONTRIBUTING.md, the Forgejo PR template, developer standards, the relevant replay rules and test and measurement guidance. Read all commits and changed hunks, both cache headers in full, the new test in full, and the affected runtime readers, writers, stamp inputs, Builder seed path and source-cut harnesses. Read affected sections of vk_draw.cpp, vk_progcache.cpp, vk_programs.cpp and vk_shader.h and skimmed their other sections and the unchanged portions of the existing changed tests. Reviewed the supplied comments and stale review. No docs/review-checklist.md or sibling Tooling checkout was available.; nothing run (a code review).
Checked and fine:

  • Adoption is restricted to format 3, with a compile-time guard that requires a compatibility decision at the next bump. Compressed caches, format-2 program files and format-1 program files naming a store remain excluded.
  • The existing process lock covers scanning and restamping. The driver cache's stamp stays readable by the older build.
  • The renderer's pipeline readers retain their existing record-size and payload checks. The prepare record remains format-specific.
  • The change has one topic and a Conventional Commit title. It contains no game data, generated output, third-party modifications or public renderer API changes. The new harness uses temporary files and a local compiler.

Blocking (to change before merge)

  1. gpu/vk/vk_draw.cpp:1077: The existing pipeline-play-cache fixture extracts pcache_drop_stale through pcache_init.inc. Its stand-in only declares a two-argument pcache_stamp::check and has no pipelines_stamp_ok, so the fixture stops compiling. Update tests/pipeline_play_cache_test.cpp for both interfaces and keep its existing cache cases.
  2. gpu/vk/vk_draw.cpp:11295: tests/test_prepare_cache_save.py extracts predicted_keys_read into a fixture that defines only program_cache_stamp. Its generated C++ now calls an undeclared pipelines_stamp_ok. Update the fixture and keep its valid, stale and malformed completion-record cases.
  3. tests/test_pipelines_outlive_cache_format.py:67: The pipeline/notes harness extracts notes_open_locked, which calls _fseeki64. This generated source has no Linux mapping to fseeko, so it fails to compile there before testing cache reuse. Add the same non-Windows mapping the migration harness inherits.
  4. tests/test_pipelines_outlive_cache_format.py:416: On the base, check_heads records the missing classifier, then check_migration raises ValueError while searching for enum class FileHead. The pipeline cases never run, so the final test fails for a missing source marker instead of demonstrating the cache loss. Run the behavioral cases on the base and let the migration harness exercise the base disk_init and report the lost format-1 record.
  5. gpu/vk/vk_draw.cpp:1868: The renderer preserves notes only if the Builder has left them in place. When the tools include longshot_pipelines_seed.bin, nx2/make_game.py:1557 compares the two stamps byte for byte and overwrites an existing format-1 list with a format-3 seed before preparation. A player loses their learned notes on that path even when both stamps describe the same translator. Defer seed replacement until the renderer can check compatibility, or make the Builder preserve compatible notes, and cover that update path.

Waiting on the author (a run, a measurement or a decision; no edit does it)

  • Current main includes #1448, which changes stamped vk_shader.cpp. Once this PR lands on that main, a pre-#1809 folder will have a different translator stamp and the PR's same-translator migration will reject it. Update the release-upgrade claim and record the intended merge order with #1927. Measure the actual supported upgrade against current main with identical copied caches and matched builds, at least two interleaved runs per side, including cold and warm startup and cache sizes.
  • gpu/vk/vk_progcache.cpp:326: Adoption keeps the full inline program file even when the shared shader store is on. The repository cites a fully populated program file of 6.9 GB. On a nearly full disk or with several game folders, this can retain gigabytes that the base rebuild would move into the shared store. The reported run kept zero program keys, so it cannot measure this cost. Report the per-folder and shared-store sizes after real migration and warm startup, and account for the cost in the merge decision.
  • The adoption and append fixture was added after the reported runs and the full changed renderer files have no successful compile result on this head. Provide passing lint and strict test results, successful Windows and Linux builds, and the required Tier 1 runs. Exercise actual format-1 adoption with the default store enabled, plus the Linux, NVIDIA and Steam Deck paths affected by cache retention.

Testing: Read-only review. No builds, tests or project scripts were run. The author's reported cache-retention checks and Windows AMD timing predate the migration fixture changes at f5d014207c.
Overlaps and merge order: #1809 introduced the format bump. #1927 is stacked on this work according to the PR body. Land this prerequisite first if the changes remain separate, and measure the combined release path against current main. #1448 is already on local main and changes the translator stamp. #1940 is also on local main and touches the pipeline warm/save path. The status of #1510 was unavailable offline.


Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** Keeping compatible caches addresses the cause of the long preparation, but the Builder can still overwrite compatible notes and several game-free checks break at this head. The reported timing used a different format transition on a stacked build, and current main changes the translator stamp this migration requires. The renderer keeps pipeline caches, notes, prediction files and module identifiers across program-cache format bumps when the translator stamp matches. It also adopts inline format-1 program records into format 3. This can save translation and cold pipeline compilation, at the cost of keeping larger local cache files and maintaining an explicit migration path. **Does it help:** Unproven for the release upgrade. The author reports 83 minutes on nightly-622 for 1→3 and about 2¼ minutes on a stacked #1927 dev build for 3→4 on the same Windows RX 6700 XT. The faster run translated 38,809 programs in 125.3 seconds and warmed 38,024 noted pipelines in 6.7 seconds. Each side ran once. The comparison does not exercise format-1 adoption or identify the gain on this head against its base. Current main also changes the translator stamp. **Other systems:** The change reaches pipeline load and warm-up, load-at-create, prediction and module ID lookup on every Vulkan vendor and both OSes. The Vulkan cache still checks the vendor, device and cache UUID, and module IDs still check the algorithm UUID. The Builder's optional seed copy can replace old notes before the renderer checks them. Adoption keeps the old inline SPIR-V on disk even with the shared store enabled. Linux, RADV, NVIDIA and Steam Deck runtime coverage remains pending. The diff leaves replay ordering, saves, audio and input code untouched. **Switches:** None added, changed or removed. The migration fixture disables the existing shader store for its test processes. **Reviewed:** f5d014207cdb against a104182b4037: Read AGENTS.md, CONTRIBUTING.md, the Forgejo PR template, developer standards, the relevant replay rules and test and measurement guidance. Read all commits and changed hunks, both cache headers in full, the new test in full, and the affected runtime readers, writers, stamp inputs, Builder seed path and source-cut harnesses. Read affected sections of vk_draw.cpp, vk_progcache.cpp, vk_programs.cpp and vk_shader.h and skimmed their other sections and the unchanged portions of the existing changed tests. Reviewed the supplied comments and stale review. No docs/review-checklist.md or sibling Tooling checkout was available.; nothing run (a code review). **Checked and fine:** - Adoption is restricted to format 3, with a compile-time guard that requires a compatibility decision at the next bump. Compressed caches, format-2 program files and format-1 program files naming a store remain excluded. - The existing process lock covers scanning and restamping. The driver cache's stamp stays readable by the older build. - The renderer's pipeline readers retain their existing record-size and payload checks. The prepare record remains format-specific. - The change has one topic and a Conventional Commit title. It contains no game data, generated output, third-party modifications or public renderer API changes. The new harness uses temporary files and a local compiler. **Blocking** (to change before merge) 1. gpu/vk/vk_draw.cpp:1077: The existing pipeline-play-cache fixture extracts pcache_drop_stale through pcache_init.inc. Its stand-in only declares a two-argument pcache_stamp::check and has no pipelines_stamp_ok, so the fixture stops compiling. Update tests/pipeline_play_cache_test.cpp for both interfaces and keep its existing cache cases. 2. gpu/vk/vk_draw.cpp:11295: tests/test_prepare_cache_save.py extracts predicted_keys_read into a fixture that defines only program_cache_stamp. Its generated C++ now calls an undeclared pipelines_stamp_ok. Update the fixture and keep its valid, stale and malformed completion-record cases. 3. tests/test_pipelines_outlive_cache_format.py:67: The pipeline/notes harness extracts notes_open_locked, which calls _fseeki64. This generated source has no Linux mapping to fseeko, so it fails to compile there before testing cache reuse. Add the same non-Windows mapping the migration harness inherits. 4. tests/test_pipelines_outlive_cache_format.py:416: On the base, check_heads records the missing classifier, then check_migration raises ValueError while searching for enum class FileHead. The pipeline cases never run, so the final test fails for a missing source marker instead of demonstrating the cache loss. Run the behavioral cases on the base and let the migration harness exercise the base disk_init and report the lost format-1 record. 5. gpu/vk/vk_draw.cpp:1868: The renderer preserves notes only if the Builder has left them in place. When the tools include longshot_pipelines_seed.bin, nx2/make_game.py:1557 compares the two stamps byte for byte and overwrites an existing format-1 list with a format-3 seed before preparation. A player loses their learned notes on that path even when both stamps describe the same translator. Defer seed replacement until the renderer can check compatibility, or make the Builder preserve compatible notes, and cover that update path. **Waiting on the author** (a run, a measurement or a decision; no edit does it) - Current main includes #1448, which changes stamped vk_shader.cpp. Once this PR lands on that main, a pre-#1809 folder will have a different translator stamp and the PR's same-translator migration will reject it. Update the release-upgrade claim and record the intended merge order with #1927. Measure the actual supported upgrade against current main with identical copied caches and matched builds, at least two interleaved runs per side, including cold and warm startup and cache sizes. - gpu/vk/vk_progcache.cpp:326: Adoption keeps the full inline program file even when the shared shader store is on. The repository cites a fully populated program file of 6.9 GB. On a nearly full disk or with several game folders, this can retain gigabytes that the base rebuild would move into the shared store. The reported run kept zero program keys, so it cannot measure this cost. Report the per-folder and shared-store sizes after real migration and warm startup, and account for the cost in the merge decision. - The adoption and append fixture was added after the reported runs and the full changed renderer files have no successful compile result on this head. Provide passing lint and strict test results, successful Windows and Linux builds, and the required Tier 1 runs. Exercise actual format-1 adoption with the default store enabled, plus the Linux, NVIDIA and Steam Deck paths affected by cache retention. **Testing:** Read-only review. No builds, tests or project scripts were run. The author's reported cache-retention checks and Windows AMD timing predate the migration fixture changes at f5d014207cdb. **Overlaps and merge order:** #1809 introduced the format bump. #1927 is stacked on this work according to the PR body. Land this prerequisite first if the changes remain separate, and measure the combined release path against current main. #1448 is already on local main and changes the translator stamp. #1940 is also on local main and touches the pipeline warm/save path. The status of #1510 was unavailable offline. --- <sub>Automated code review by BeanBot (gpt-6.2-sol), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.</sub>
@ -1073,3 +1075,3 @@
static const bool dropped = [] {
const std::string dir = cache_path(""); // (where pcache_init keeps them: the game folder's cache/, vk_paths.h)
const pcache_stamp::Dropped gone = pcache_stamp::check(dir, program_cache_stamp());
const pcache_stamp::Dropped gone = pcache_stamp::check(dir, program_cache_stamp(), pipelines_stamp_ok);
Member

The pipeline-play-cache fixture extracts this call. Update its two-argument check stub and supply pipelines_stamp_ok so the generated C++ compiles.

The pipeline-play-cache fixture extracts this call. Update its two-argument check stub and supply pipelines_stamp_ok so the generated C++ compiles.
@ -1864,2 +1866,3 @@
}
const bool same = head[0] == stamp && head[1] == sizeof(PipeNote);
// (a head of this translator under an earlier program cache format is the same: its notes are about the pipelines, kept)
const bool same = pipelines_stamp_ok(head[0]) && head[1] == sizeof(PipeNote);
Member

With a shipped seed, nx2/make_game.py:1557 can overwrite the player's compatible format-1 notes before this runs. Preserve them through the Builder path too.

With a shipped seed, nx2/make_game.py:1557 can overwrite the player's compatible format-1 notes before this runs. Preserve them through the Builder path too.
@ -11290,3 +11293,3 @@
if (FILE* f = fopen(predicted_keys_path().c_str(), "rb")) {
uint64_t head[2]{};
if (fread(head, 8, 2, f) == 2 && head[0] == program_cache_stamp() && head[1] <= (64u << 20) &&
if (fread(head, 8, 2, f) == 2 && pipelines_stamp_ok(head[0]) && head[1] <= (64u << 20) &&
Member

The Builder cache-save fixture extracts this reader and has no pipelines_stamp_ok. Update the fixture and keep its stale and malformed record cases.

The Builder cache-save fixture extracts this reader and has no pipelines_stamp_ok. Update the fixture and keep its stale and malformed record cases.
@ -279,6 +323,19 @@ void disk_init() {
}
fclose(f);
}
if (good && adopted) {
Member

The adopted file keeps all inline SPIR-V even with the shared store on. Measure the per-folder and shared-store sizes after an actual format-1 migration.

The adopted file keeps all inline SPIR-V even with the shared store on. Measure the per-folder and shared-store sizes after an actual format-1 migration.
@ -0,0 +64,4 @@
va_end(a);
std::printf("\n");
}
static void cut_part_record(const std::string&, size_t, size_t) {}
Member

The extracted notes opener calls _fseeki64. Map it to fseeko in this harness on Linux.

The extracted notes opener calls _fseeki64. Map it to fseeko in this harness on Linux.
@ -0,0 +413,4 @@
("another translator: dropped", new, other, "drop"),
("another translator and format 1: dropped", old, other, "drop"),
]
failed += ["the program file's head: " + r for r in check_heads(args.cxx, tmp, progcache_src, now)]
Member

On base, check_migration raises on the missing FileHead marker before the pipeline cases run. Make the base test reach the behavioral assertions.

On base, check_migration raises on the missing FileHead marker before the pipeline cases run. Make the base test reach the behavioral assertions.
madebyjordan force-pushed fix/pipelines-outlive-cache-format from f5d014207c
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Failing after 27s
CI / Conventional Commit title (pull_request) Successful in 24s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 36s
CI / Workflow lint (actionlint) (pull_request) Successful in 39s
Third-party parts / As their notes say (pull_request) Successful in 46s
CI / Website build and checks (pull_request) Has been cancelled
to 744a2329f0
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 8s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 15s
CI / Workflow lint (actionlint) (pull_request) Successful in 16s
Third-party parts / As their notes say (pull_request) Successful in 19s
PR description / Description follows the template (pull_request_target) Successful in 10s
CI / Website build and checks (pull_request) Failing after 12s
2026-11-21 00:24:01 +00:00
Compare
Author
Member

@HumanBean thanks for sending BeanBot's fix. I've replaced its commit (f5d01420) rather than kept it: the adoption it guarded is gone from this PR. #1448 (merged) moved the translator's stamp, so no format-1 program file can belong to a current translator any more, and the adoption path could never run. Its guard and test had nothing left to guard. BeanBot's migration test also didn't compile here (it redefined format 1's Shader::Info by hand, which the translator stamp already pins). Both blocking points are answered by the removal. What's left: a format bump keeps the driver's pipelines and the notes (pipelines_stamp_ok), with the in-game numbers in Testing. Rebased onto 87c0d7b4 (head 744a2329). The full suite (run_all --strict) fails the same 143 checks as main on this PC, plus one more passing. The more urgent half is #1927 with LongshotLauncher #220: the next nightly moves the translator (#1448), and without them every player's update compiles every pipeline cold again.

@HumanBean thanks for sending BeanBot's fix. I've replaced its commit (f5d01420) rather than kept it: the adoption it guarded is gone from this PR. #1448 (merged) moved the translator's stamp, so no format-1 program file can belong to a current translator any more, and the adoption path could never run. Its guard and test had nothing left to guard. BeanBot's migration test also didn't compile here (it redefined format 1's Shader::Info by hand, which the translator stamp already pins). Both blocking points are answered by the removal. What's left: a format bump keeps the driver's pipelines and the notes (pipelines_stamp_ok), with the in-game numbers in Testing. Rebased onto 87c0d7b4 (head 744a2329). The full suite (run_all --strict) fails the same 143 checks as main on this PC, plus one more passing. The more urgent half is #1927 with LongshotLauncher #220: the next nightly moves the translator (#1448), and without them every player's update compiles every pipeline cold again.
HumanBean deleted branch fix/pipelines-outlive-cache-format 2026-11-21 00:46:04 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1926
No description provided.