fix(queue): the RAM file system rule is checked on a made-up mount table on Windows too #1915
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1915
Loading…
Reference in a new issue
No description provided.
Delete branch "siantm/Longshot:fix/queue-ram-check-windows"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
tests/test_job_queue.pyfails on Windows onmain: itstest_ram_file_systemhandson_rama made-up mount table(
/on btrfs,/tmpon tmpfs,/tmp/diskon ext4) and expects/tmp/xto be on a RAM file system, but on Windowson_ramanswers "no" before it looks at the table, and would resolve the test's path against the drive. The failurehas been named as "also fails on main" in several pull requests (#1100, #1816).
With a table given,
on_ramnow applies the longest-mount rule to the path as it is, on any OS. With none (everycaller but the test:
dev.py's builds, the queue'sTMPDIRmove,dev.py migrate) it is as before: "no" on Windows,/proc/mountsand the real path elsewhere.To see it on
main:python -I -B tests/test_job_queue.pyon Windows.Read first:
on_raminscripts/devtools/common.py(the whole change, 4 lines).Testing
Tested: Windows 11, Python 3.14.7 (the Builder's):
python -I -B tests/test_job_queue.py -vonmain@8859673eandon this branch @
ff798113, each in a hidden console of its own, in one build job of the PC's job queue:main: 21 tests, 18 passed, 2 failed (test_ram_file_system,WindowsPlayersReal.test_a_build_outside_the_queue), 1 skipped.WindowsPlayersReal.test_a_build_outside_the_queue, which fails onmainthe same way:heavy_procsreturned no process for the test's stand-in build), 1 skipped.No game run: the change is in a developer tool's test path, and on Windows nothing that calls
on_ramwithout a tablechanges its answer.
Still to test:
tests/run_all.py --strict) here and onmain@8859673e, expecting no failurehere that
maindoes not have (by hand, queued)python3 -I -B tests/test_job_queue.py, expecting it to pass as onmain(the real path is still usedwhen no table is given) (by hand: the Test Farm runs game scenarios only, not a game-free test)
Measurements
Verdict: the check that failed on Windows passes; no other result of the file changes.
Setup: Windows 11, i7-9700, Python 3.14.7;
python -I -B tests/test_job_queue.py -v, one run each side, through thePC's job queue
8859673eff798113tests/test_job_queue.py(21 tests)Environment.test_ram_file_systemAssertionError: False is not true)WindowsPlayersReal.test_a_build_outside_the_queuemain)Risks
None for players:
scripts/devtools/is not part of the game or its build. A revert is enough. A caller that passed atable on Linux now has its path taken as it is (not resolved through symlinks); only the test passes one.
Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named). (the whole suite is queued: Still to test)main, or Measurements says why there is nothing to measure.third_party/untouched; nothing GPL-incompatible.When it applies
mainand passes here.Assisted-by:/Co-Authored-By:trailers.Ready to merge
main, measured again or a comment says why the numbers still hold.siantm referenced this pull request2026-11-20 20:45:51 +00:00
Recommendation: Wait. The existing Windows test now passes, and the production callers retain their previous behavior. The planned Linux and full-suite runs and passing CI are still needed before merge.
This lets the RAM filesystem test apply its synthetic mount table on Windows, at the cost of treating paths supplied with a table as literal paths on Linux too. The only in-tree caller supplying a table is the test, so no production behavior change was found.
Does it help: Yes. The PR reports that test_ram_file_system failed on base
8859673eand passed onff798113on the same Windows 11 PC; the separate WindowsPlayersReal failure occurred on both. This is a correctness fix, not a performance change.Other systems: Windows production calls still return false without a table. Linux build checks, queue temporary-directory handling, and migration still resolve real paths and read the real mount table; the planned Linux test remains outstanding. GPU vendors, game runtime, saves, audio and input do not use this path.
Switches: None.
Reviewed:
ff7981136fagainst8859673e4b: Read scripts/devtools/common.py, AGENTS.md, CONTRIBUTING.md, docs/dev/standards.md and the PR template in full; read the complete diff and commit and the relevant test and caller sections. Skimmed the reported runs. Other portions of the test and caller files were not read in full. docs/review-checklist.md and the sibling Tooling AGENTS.md were absent; the network was unavailable.; nothing run (a code review).Checked and fine:
Testing: Read-only review; no tests or project scripts were run. Await the stated Linux test, full suite comparison and passing CI on the head; the existing unrelated Windows failure is named in the PR.
Overlaps and merge order: No overlapping pull requests were supplied; the closed network prevented checking.
Automated code review by BeanBot (gpt-6.1-terra), on the pull request's opening. Nothing was run; a maintainer decides.
Still to test: the items for hardware this PC lacks go to the Test Farm (@Beanstalk form).
@siantm only members of
BigBeanscan start the farm. One of them can approve this request by reacting 👍 to it or to this comment.The Test Farm request in my previous comment was not meant: the farm plays game scenarios and times builds, comparing this PR's game against main's, and this change is in a developer tool that the game does not run (no plan of the farm's runs a test file or the job queue). The Linux and other-GPU items in Still to test are back to by hand. Nothing for a BigBean to approve here.
WIP: fix(queue): the RAM file system rule is checked on a made-up mount table on Windows tooto fix(queue): the RAM file system rule is checked on a made-up mount table on Windows too