fix(vk): FSR 3.1 frame generation's images let go when another one makes the frames #1869

Merged
HumanBean merged 1 commit from GummiNaomi/Longshot:fix/fsr-idle-own-use into main 2026-11-20 15:19:10 +00:00
Member

Summary

#1158 lets frame generation's images go 120 presents after nothing uses them. For FSR 3.1's own images it counted the
wrong thing: any present that recorded made frames counted as FSR in use, whichever one made them. So after a player
used FSR 3.1 FG and then chose Built-in FG (or DLSS FG), FSR 3.1's images were never let go: at 2560x1440 2x that is
about 150 MiB of VRAM kept for the rest of the run. futondestroyer found this in review 1583 (comment 38853) and
TrashPanda in review 1644. futondestroyer's comment 47385 asked to count FSR's actual use, a reset or a history-only
present included, rather than the frame finally shown.

To see it on main: play in a window with Upscaler DLSS, Frame generation 2x, Frame generation by FSR 3.1 FG. Then
switch Frame generation by to Built-in FG and keep playing. The log never shows vk: fsr3fi: frame generation off: its ... images let go, and the GPU's memory doesn't go down.

What changes: fsr3fi_frames now marks the present (fsr_given) just before each fsr3fi::generate call, once its
inputs are taken. A reset or a history-only call (no frame to make) counts too, and so does a present whose FSR result
isn't shown. framegen_idle takes that mark, clears it for the next present and counts FSR's own idle presents by it.
The shared images still count any recorded present as in use, so #1158's queue-before-idle protection stays as it was.
Both counts are now one small rule with no Vulkan in it (framegen_idle_rule::step).

The result: 120 presents after the switch to Built-in FG, the log shows its 35 images let go and the GPU's memory
drops by 150-160 MiB, with no frame-time hitch.

Read first: gpu/vk/framegen_idle.h (step), framegen_idle and fsr3fi_frames in gpu/vk/vk_framegen.cpp.
mooki's point (comment 47180) is in too: the header now gives the log line's size for the built-in images, about 112 MB
at 2560x1440 2x and 823 MB at 4K 8x, not 150 and 800.

See #1158.

Testing

Tested: Windows 11 Pro 26200, RTX 4070 SUPER, NVIDIA 617.42, in the game in a window (frame generation doesn't run
headless), at this head and at main 89c3d21e built from the same base. The kokiri-start save, standing. The rows were
set through the control bridge: Upscaler NVIDIA DLSS, Frame generation 2x, Frame generation by FSR 3.1 FG. FSR 3.1 made
600 of 600 presents' frames, then Frame generation by was set to Built-in FG for 45 s. With this PR, vk: fsr3fi: frame generation off: its 35 images let go appears in both runs and the GPU's memory steps down at that point. On main the
line never appears and the memory doesn't step. Nothing looked wrong in either build, and no device loss.
Two more runs of this PR added a third step: Frame generation by set back to FSR 3.1 FG after the release. FSR 3.1 made
its images again (1 made frame(s) at 2560x1440), it made 598-600 of each 600 presents' frames again, and there was
no device loss.

Checks:

  • Windows: tests/test_framegen_idle.py, tests/test_vram_held_idle.py, tests/test_fsr3fi_hud_mask.py and
    tests/test_switch_table.py pass.
  • Windows: a syntax-only compile of gpu/vk/vk_framegen.cpp with the builder's flags has no errors.
  • WSL Ubuntu 24.04, g++: run_all.py --changed 89c3d21e gives 26 passed, 2 failed, 1 skipped. The 2 failures,
    tests/test_crt_options.py and tests/test_present_source_crop.py, fail on main too.
  • WSL Ubuntu 24.04, g++, the whole run_all.py (what mise run test runs, here without --strict and without
    test-deps' glslang and Python packages): this head gives 743 passed, 69 failed, 69 skipped; main 89c3d21e gives
    742 passed, 69 failed, 70 skipped. The same 69 fail on both: the box's tools, listed below. The extra pass is
    tests/test_framegen_idle.py, which now takes run_all's compiler (g++ here) and runs on Linux.
The 69 checks that fail on main 89c3d21e too (WSL)

missing, nx2/test_mesh_first_types.py, and in tests/: test_appimage_player_build, test_bug_report_defaults,
test_capture_read_once, test_capture_readback_visibility, test_crash_dialog, test_crt_options, test_damage_debug_menu,
test_dev_ab, test_dev_packs, test_discover, test_display_startup_failure, test_dlss_feature_size, test_draw_binds,
test_draw_stream_visibility, test_early_split_before_draw, test_failed_compile_keeps_objects, test_frame_overlap,
test_fsr_image_retirement, test_fsr_uniform_ownership, test_guest_imported, test_high_fps_fixes, test_hold_gpu,
test_host_guest_writes, test_hud_layout_row, test_image_view_retry, test_libc_hooks, test_lift_cache, test_lift_lookups,
test_link_skip, test_linux_pressure, test_linux_tools, test_linux_update, test_log_open_failure, test_longshot_saves,
test_low_vram_texture_mips, test_make_game_cache, test_make_game_ngx, test_mise_build, test_missing_nup, test_mods_list,
test_mods_size_table, test_ngx_sdk, test_pass_barrier, test_pending_guest_import, test_pipeline_play_cache,
test_prepare_cache_save, test_present_queue_default, test_present_source_crop, test_profiling_mode,
test_psychov35_fsr3_fg, test_readback_early, test_readback_late, test_readback_timeout_source, test_replay_write_order,
test_sampler_admission, test_slow_frames, test_song_note_cue, test_split_before_draw, test_staging_burst,
test_texel_buffer_ownership, test_thinlto_tls, test_ub_update_batch, test_upscaler_rows, test_vcore_escape,
test_vk_occlusion_queries, test_walk, test_walk_key.

The new checks fail on main:

  • tests/test_framegen_idle.py runs the FSR sequences: FSR for 1 present, then 120 presents by another; an FSR reset or
    history-only present at 119; the row turned Off or to another one during an FSR present. With FSR's count fed
    recorded again (main's wiring), 2 of them fail.
  • tests/test_fsr3fi_hud_mask.py checks the mark. Run against main's source, its new history-only check fails.

Still to test:

  • An RTX 40 or 50 where DLSS FG is offered: FSR 3.1 FG, then DLSS FG for a minute, expecting the same its ... images let go line about 2 s after the switch (by hand). This PC's builds didn't offer DLSS FG, so only Built-in FG was
    the other one here.
  • Any GPU: FSR 3.1 FG, then Frame generation Off, expecting the line about 2 s later, the built-in images'
    frame interpolation off line, and nothing wrong on screen (by hand).
  • A Steam Deck or Linux AMD: FSR 3.1 FG, then Built-in FG, then FSR 3.1 FG again, expecting the line once and FSR's
    frames again after it (@Beanstalk linux: FSR 3.1 FG then Built-in FG then FSR 3.1 FG, the fsr3fi lines).

Measurements

Verdict: after a switch from FSR 3.1 FG to Built-in FG at 2560x1440 2x, FSR 3.1's 35 images are let go 120 presents
later: the GPU's memory steps down 150-160 MiB, where main keeps them for the run. The frame time around the release
doesn't change.

Setup: Windows 11 Pro 26200, RTX 4070 SUPER 12 GB, NVIDIA 617.42, Ryzen 9 9950X3D (SMT off), 32 GB. Windowed
2560x1440, mailbox, uncapped. The kokiri-start save, standing. Upscaler NVIDIA DLSS, Frame generation 2x, Frame
generation by FSR 3.1 FG for 40 s, then Built-in FG for 45 s. Runs were interleaved main, PR, PR, main. GPU memory is
nvidia-smi's memory.used, sampled once a second with the game's present number, and the step is the two samples
either side of present +120 after the switch. Frame times are from RX_VK_FRAME_TRACE, by present number.

Before: main @ 89c3d21e After: this PR @ c2e7a8fc
fsr3fi: frame generation off: its N images let go after the switch none (runs 1, 4) its 35 images let go (runs 2, 3)
GPU memory, the sample before the release to the one after (MiB) 8962 → 8962, 8866 → 8867 (0, +1) 9007 → 8847, 8943 → 8793 (-160, -150)
Slowest frame, presents +60 to +260 after the switch 10.75, 10.81 ms 11.40, 10.91 ms
600 presents before the switch (FSR 3.1 FG): mean / p99 11.00 / 12.18, 11.09 / 12.43 ms 11.02 / 12.19, 11.01 / 12.30 ms
Presents +200 to +800 (Built-in FG): mean / p99 9.18 / 10.17, 9.29 / 10.40 ms 9.24 / 10.34, 9.23 / 10.45 ms

The two turn-back-on runs of this PR (Built-in FG, then FSR 3.1 FG again) gave the same release step: 8831 → 8677
and 8789 → 8636 MiB (-154, -153).

In every run, main's and this PR's alike, the GPU's memory also moves by up to about 150 MiB a few thousand presents
later (8996 → 9059 → 8868, for example). That is the scene's own textures, not the release: it is why the table takes
the step at the release itself rather than the whole run's average.

Risks

What could break: FSR 3.1's images are now let go after a switch to another frame generation, where before they
were kept. Choosing FSR 3.1 FG again makes them again on its next present. That is the path a resize already takes
(fsr3fi::prepare), with no device wait: fsr3fi::release hands the images to its retirement list, which frees them
once the GPU is past them. Turned back on in two runs, the images were made again within about 16 presents (the GPU's memory up 150-170 MiB).
The slowest frame then was 13.0-13.2 ms, against 12.4-12.9 ms for FSR 3.1 FG's p99 after it. The shared images and #1158's hang protection are unchanged.

Turning it off: there is no switch; a revert is enough.

After updating: nothing changes in saves, longshot_options.ini or the caches.

Still held: FSR 3.1's HUD mask images (hud.before/after/source/hudless/fit/layer in vk_framegen.cpp)
are still kept after a switch away from FSR 3.1 FG, as on main. They are replaced only on a size change. They're left
for a separate change: framegen_hud_before makes them on the replay's worker threads, and freeing them needs
hud_free_dead to run outside hud_source. So it isn't the same small change.

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit.
  • Tested on my own PC, in the game for a change the game runs, as Testing says.
  • mise run test passes (any failure that also fails on main is named).
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • A fix: a game-free test that fails on main and passes here.
  • A check under tests/ that reads changed source is updated, not weakened.
  • Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. (Built on Windows only: the WSL box has
    g++ but not the Linux build's clang, lld, VMA headers or FFmpeg, and fetching them was not done.)
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested.
  • Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers").
  • Approved in review, every comment answered.
  • CI passes on the head; on current main, measured again or a comment says why the numbers still hold.

🤖 Generated with Claude Code

## Summary #1158 lets frame generation's images go 120 presents after nothing uses them. For FSR 3.1's own images it counted the wrong thing: any present that recorded made frames counted as FSR in use, whichever one made them. So after a player used FSR 3.1 FG and then chose Built-in FG (or DLSS FG), FSR 3.1's images were never let go: at 2560x1440 2x that is about 150 MiB of VRAM kept for the rest of the run. futondestroyer found this in review 1583 (comment 38853) and TrashPanda in review 1644. futondestroyer's comment 47385 asked to count FSR's actual use, a reset or a history-only present included, rather than the frame finally shown. **To see it on main:** play in a window with Upscaler DLSS, Frame generation 2x, Frame generation by FSR 3.1 FG. Then switch Frame generation by to Built-in FG and keep playing. The log never shows `vk: fsr3fi: frame generation off: its ... images let go`, and the GPU's memory doesn't go down. **What changes:** `fsr3fi_frames` now marks the present (`fsr_given`) just before each `fsr3fi::generate` call, once its inputs are taken. A reset or a history-only call (no frame to make) counts too, and so does a present whose FSR result isn't shown. `framegen_idle` takes that mark, clears it for the next present and counts FSR's own idle presents by it. The shared images still count any recorded present as in use, so #1158's queue-before-idle protection stays as it was. Both counts are now one small rule with no Vulkan in it (`framegen_idle_rule::step`). **The result:** 120 presents after the switch to Built-in FG, the log shows `its 35 images let go` and the GPU's memory drops by 150-160 MiB, with no frame-time hitch. Read first: `gpu/vk/framegen_idle.h` (`step`), `framegen_idle` and `fsr3fi_frames` in `gpu/vk/vk_framegen.cpp`. mooki's point (comment 47180) is in too: the header now gives the log line's size for the built-in images, about 112 MB at 2560x1440 2x and 823 MB at 4K 8x, not 150 and 800. See #1158. ## Testing **Tested:** Windows 11 Pro 26200, RTX 4070 SUPER, NVIDIA 617.42, in the game in a window (frame generation doesn't run headless), at this head and at main `89c3d21e` built from the same base. The kokiri-start save, standing. The rows were set through the control bridge: Upscaler NVIDIA DLSS, Frame generation 2x, Frame generation by FSR 3.1 FG. FSR 3.1 made 600 of 600 presents' frames, then Frame generation by was set to Built-in FG for 45 s. With this PR, `vk: fsr3fi: frame generation off: its 35 images let go` appears in both runs and the GPU's memory steps down at that point. On main the line never appears and the memory doesn't step. Nothing looked wrong in either build, and no device loss. Two more runs of this PR added a third step: Frame generation by set back to FSR 3.1 FG after the release. FSR 3.1 made its images again (`1 made frame(s) at 2560x1440`), it made 598-600 of each 600 presents' frames again, and there was no device loss. Checks: - Windows: `tests/test_framegen_idle.py`, `tests/test_vram_held_idle.py`, `tests/test_fsr3fi_hud_mask.py` and `tests/test_switch_table.py` pass. - Windows: a syntax-only compile of `gpu/vk/vk_framegen.cpp` with the builder's flags has no errors. - WSL Ubuntu 24.04, g++: `run_all.py --changed 89c3d21e` gives 26 passed, 2 failed, 1 skipped. The 2 failures, `tests/test_crt_options.py` and `tests/test_present_source_crop.py`, fail on main too. - WSL Ubuntu 24.04, g++, the whole `run_all.py` (what `mise run test` runs, here without `--strict` and without test-deps' glslang and Python packages): this head gives 743 passed, 69 failed, 69 skipped; main `89c3d21e` gives 742 passed, 69 failed, 70 skipped. The same 69 fail on both: the box's tools, listed below. The extra pass is `tests/test_framegen_idle.py`, which now takes run_all's compiler (g++ here) and runs on Linux. <details><summary>The 69 checks that fail on main 89c3d21e too (WSL)</summary> `missing`, `nx2/test_mesh_first_types.py`, and in `tests/`: test_appimage_player_build, test_bug_report_defaults, test_capture_read_once, test_capture_readback_visibility, test_crash_dialog, test_crt_options, test_damage_debug_menu, test_dev_ab, test_dev_packs, test_discover, test_display_startup_failure, test_dlss_feature_size, test_draw_binds, test_draw_stream_visibility, test_early_split_before_draw, test_failed_compile_keeps_objects, test_frame_overlap, test_fsr_image_retirement, test_fsr_uniform_ownership, test_guest_imported, test_high_fps_fixes, test_hold_gpu, test_host_guest_writes, test_hud_layout_row, test_image_view_retry, test_libc_hooks, test_lift_cache, test_lift_lookups, test_link_skip, test_linux_pressure, test_linux_tools, test_linux_update, test_log_open_failure, test_longshot_saves, test_low_vram_texture_mips, test_make_game_cache, test_make_game_ngx, test_mise_build, test_missing_nup, test_mods_list, test_mods_size_table, test_ngx_sdk, test_pass_barrier, test_pending_guest_import, test_pipeline_play_cache, test_prepare_cache_save, test_present_queue_default, test_present_source_crop, test_profiling_mode, test_psychov35_fsr3_fg, test_readback_early, test_readback_late, test_readback_timeout_source, test_replay_write_order, test_sampler_admission, test_slow_frames, test_song_note_cue, test_split_before_draw, test_staging_burst, test_texel_buffer_ownership, test_thinlto_tls, test_ub_update_batch, test_upscaler_rows, test_vcore_escape, test_vk_occlusion_queries, test_walk, test_walk_key. </details> The new checks fail on main: - `tests/test_framegen_idle.py` runs the FSR sequences: FSR for 1 present, then 120 presents by another; an FSR reset or history-only present at 119; the row turned Off or to another one during an FSR present. With FSR's count fed `recorded` again (main's wiring), 2 of them fail. - `tests/test_fsr3fi_hud_mask.py` checks the mark. Run against main's source, its new history-only check fails. **Still to test:** - An RTX 40 or 50 where DLSS FG is offered: FSR 3.1 FG, then DLSS FG for a minute, expecting the same `its ... images let go` line about 2 s after the switch (by hand). This PC's builds didn't offer DLSS FG, so only Built-in FG was the other one here. - Any GPU: FSR 3.1 FG, then Frame generation Off, expecting the line about 2 s later, the built-in images' `frame interpolation off` line, and nothing wrong on screen (by hand). - A Steam Deck or Linux AMD: FSR 3.1 FG, then Built-in FG, then FSR 3.1 FG again, expecting the line once and FSR's frames again after it (@Beanstalk linux: FSR 3.1 FG then Built-in FG then FSR 3.1 FG, the fsr3fi lines). ## Measurements **Verdict:** after a switch from FSR 3.1 FG to Built-in FG at 2560x1440 2x, FSR 3.1's 35 images are let go 120 presents later: the GPU's memory steps down 150-160 MiB, where main keeps them for the run. The frame time around the release doesn't change. Setup: Windows 11 Pro 26200, RTX 4070 SUPER 12 GB, NVIDIA 617.42, Ryzen 9 9950X3D (SMT off), 32 GB. Windowed 2560x1440, mailbox, uncapped. The kokiri-start save, standing. Upscaler NVIDIA DLSS, Frame generation 2x, Frame generation by FSR 3.1 FG for 40 s, then Built-in FG for 45 s. Runs were interleaved main, PR, PR, main. GPU memory is nvidia-smi's `memory.used`, sampled once a second with the game's present number, and the step is the two samples either side of present +120 after the switch. Frame times are from `RX_VK_FRAME_TRACE`, by present number. | | Before: main @ 89c3d21e | After: this PR @ c2e7a8fc | |---|---|---| | `fsr3fi: frame generation off: its N images let go` after the switch | none (runs 1, 4) | `its 35 images let go` (runs 2, 3) | | GPU memory, the sample before the release to the one after (MiB) | 8962 → 8962, 8866 → 8867 (0, +1) | 9007 → 8847, 8943 → 8793 (-160, -150) | | Slowest frame, presents +60 to +260 after the switch | 10.75, 10.81 ms | 11.40, 10.91 ms | | 600 presents before the switch (FSR 3.1 FG): mean / p99 | 11.00 / 12.18, 11.09 / 12.43 ms | 11.02 / 12.19, 11.01 / 12.30 ms | | Presents +200 to +800 (Built-in FG): mean / p99 | 9.18 / 10.17, 9.29 / 10.40 ms | 9.24 / 10.34, 9.23 / 10.45 ms | The two turn-back-on runs of this PR (Built-in FG, then FSR 3.1 FG again) gave the same release step: 8831 → 8677 and 8789 → 8636 MiB (-154, -153). In every run, main's and this PR's alike, the GPU's memory also moves by up to about 150 MiB a few thousand presents later (8996 → 9059 → 8868, for example). That is the scene's own textures, not the release: it is why the table takes the step at the release itself rather than the whole run's average. ## Risks **What could break:** FSR 3.1's images are now let go after a switch to another frame generation, where before they were kept. Choosing FSR 3.1 FG again makes them again on its next present. That is the path a resize already takes (`fsr3fi::prepare`), with no device wait: `fsr3fi::release` hands the images to its retirement list, which frees them once the GPU is past them. Turned back on in two runs, the images were made again within about 16 presents (the GPU's memory up 150-170 MiB). The slowest frame then was 13.0-13.2 ms, against 12.4-12.9 ms for FSR 3.1 FG's p99 after it. The shared images and #1158's hang protection are unchanged. **Turning it off:** there is no switch; a revert is enough. **After updating:** nothing changes in saves, `longshot_options.ini` or the caches. **Still held:** FSR 3.1's HUD mask images (`hud.before`/`after`/`source`/`hudless`/`fit`/`layer` in `vk_framegen.cpp`) are still kept after a switch away from FSR 3.1 FG, as on main. They are replaced only on a size change. They're left for a separate change: `framegen_hud_before` makes them on the replay's worker threads, and freeing them needs `hud_free_dead` to run outside `hud_source`. So it isn't the same small change. ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. - [x] Tested on my own PC, in the game for a change the game runs, as Testing says. - [x] `mise run test` passes (any failure that also fails on `main` is named). - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [x] A fix: a game-free test that fails on `main` and passes here. - [x] A check under `tests/` that reads changed source is updated, not weakened. - [ ] Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. (Built on Windows only: the WSL box has g++ but not the Linux build's clang, lld, VMA headers or FFmpeg, and fetching them was not done.) - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. ### Ready to merge - [ ] Everything in Still to test has run, its results in Tested. - [ ] Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers"). - [ ] Approved in review, every comment answered. - [ ] CI passes on the head; on current `main`, measured again or a comment says why the numbers still hold. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(vk): FSR 3.1's frame interpolation images let go by FSR's own use, not by any recorded set
Some checks reported errors
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 12s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Failing after 15s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 19s
CI / Workflow lint (actionlint) (pull_request) Successful in 20s
Third-party parts / As their notes say (pull_request) Successful in 21s
beanstalk/approval approved by GummiNaomi (reviewed)
beanstalk/linux 0/1 pass, 2 error
beanstalk/steamdeck 0/1 pass, 0 running, 0 queued
CI / Website build and checks (pull_request) Failing after 2m0s
c2e7a8fc3d
Follow-up to #1158 (merged as 382a3d67), from its reviews: framegen_idle fed FSR's idle count `recorded`, which is
true for every set framegen_record made, the built-in interpolation's and
DLSS-G's too. After FSR 3.1 had made its images and another one was chosen,
its count stayed 0 and fsr3fi::release never ran: the images were kept for
the run.

Now fsr3fi_frames marks the present (fsr_given) right before each
fsr3fi::generate call, once its inputs are taken: a reset or its history
alone counts too, whichever made frames are shown. framegen_idle takes the
mark and clears it for the next present, and feeds it to FSR's count; the
shared images keep `recorded`, so the queue-before-idle protection stands.
The two counts are one rule (framegen_idle.h step), which
tests/test_framegen_idle.py compiles and runs: FSR for 1 present then 120
by another (the 120th lets FSR's go, the shared stay), an FSR reset or
history-only present at 119, and the row changed to Off or another one
during an FSR present. With FSR's count fed `recorded` again, two of them
fail. tests/test_fsr3fi_hud_mask.py, which runs fsr3fi_frames, gets the
flag's stand-in and checks it: set by a present with inputs, its history
alone too, not by one without. tests/test_framegen_idle.py takes run_all's
compiler, so it runs on Linux too.

Assisted-by: Claude Opus 5.5
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Member

@Beanstalk linux and steamdeck: in a window, Upscaler as available, Frame generation 2x by FSR 3.1 FG for 40 s, then Built-in FG for 45 s, then FSR 3.1 FG again for 30 s, RX_VK_FRAME_TRACE=1. Expecting fsr3fi: frame generation off: its N images let go once, about 120 presents after the switch to Built-in FG, FSR 3.1's frames made again after the switch back, no device loss, and no frame-time spike at the release.

(Earlier runs on #1846 and #1847 today ended in error before building: the farm's checkout of main failed git rev-parse --verify HEAD^{commit} in packs.py's cmd_base, so nothing was measured there.)

@Beanstalk linux and steamdeck: in a window, Upscaler as available, Frame generation 2x by FSR 3.1 FG for 40 s, then Built-in FG for 45 s, then FSR 3.1 FG again for 30 s, `RX_VK_FRAME_TRACE=1`. Expecting `fsr3fi: frame generation off: its N images let go` once, about 120 presents after the switch to Built-in FG, FSR 3.1's frames made again after the switch back, no device loss, and no frame-time spike at the release. (Earlier runs on #1846 and #1847 today ended in `error` before building: the farm's checkout of main failed `git rev-parse --verify HEAD^{commit}` in packs.py's cmd_base, so nothing was measured there.)
Member

Beanstalk test farm

Commit c2e7a8f · tier reviewed · approved by GummiNaomi · dashboard

What will be tested · AI plan (gpt-6.1-terra)

On Linux and Steam Deck, this plan attempts the requested 40-second FSR 3.1, 45-second Built-in, and 30-second FSR 3.1 sequence in Kokiri Forest, taking about 13 minutes per tester. It checks the release log count, device loss, frame times, and screenshots against main. The farm runs without a window, however, and the PR says frame generation does not run headless; the requested frame trace is also unavailable under farm rules. Consequently, a missing release will fail the plan, but the result cannot establish the 120-present timing or confirm that FSR-generated frames resume.

  • Where: linux (1-2 reports), steamdeck (1-2 reports).
  • framegen-switch: from the repository's save kokiri-start (settings fullscreen=0, frame_generation=2, frame_generation_by=1), then measure fsr-before for 40 s (after 0 s warm-up), take the picture fsr-before to compare with main, set frame_generation_by to 0, measure builtin for 45 s (after 0 s warm-up), take the picture builtin to compare with main, set frame_generation_by to 1, measure fsr-after for 30 s (after 0 s warm-up), take the picture fsr-after to compare with main; 1 run on each side.
  • Measured: crashes, frame times, stutters and hitches, the game's log, numbers from the game's log.
  • The PR fails if: it crashes; or a picture differs from main by more than 10%; or frame time (p99) is more than 20% above main; or forbidden log lines is above 0; or value_fsr_releases is above 1; or value_fsr_releases is below 1; or worst frame time in the whole run is more than 25% above main.
  • Time: about 14 min of game runs per tester (2 game starts), plus the two builds.

Done (started 13:14 UTC). Comment @Beanstalk to run it again.

Target Reports Crash Frame p99 (ms) vs main VRAM peak (MB) vs main Result
linux 0/1 — — — error
steamdeck 0/1 — — — queued
<!-- beanstalk:sticky --> ### Beanstalk test farm Commit `c2e7a8f` · tier **reviewed** · approved by GummiNaomi · [dashboard](https://beanstalk.magicbean.dev/prs/1869) **What will be tested** · AI plan (`gpt-6.1-terra`) On Linux and Steam Deck, this plan attempts the requested 40-second FSR 3.1, 45-second Built-in, and 30-second FSR 3.1 sequence in Kokiri Forest, taking about 13 minutes per tester. It checks the release log count, device loss, frame times, and screenshots against main. The farm runs without a window, however, and the PR says frame generation does not run headless; the requested frame trace is also unavailable under farm rules. Consequently, a missing release will fail the plan, but the result cannot establish the 120-present timing or confirm that FSR-generated frames resume. - **Where:** linux (1-2 reports), steamdeck (1-2 reports). - **framegen-switch:** from the repository's save `kokiri-start` (settings fullscreen=0, frame_generation=2, frame_generation_by=1), then measure fsr-before for 40 s (after 0 s warm-up), take the picture fsr-before to compare with main, set frame_generation_by to 0, measure builtin for 45 s (after 0 s warm-up), take the picture builtin to compare with main, set frame_generation_by to 1, measure fsr-after for 30 s (after 0 s warm-up), take the picture fsr-after to compare with main; 1 run on each side. - **Measured:** crashes, frame times, stutters and hitches, the game's log, numbers from the game's log. - **The PR fails if:** it crashes; or a picture differs from main by more than 10%; or frame time (p99) is more than 20% above main; or forbidden log lines is above 0; or value_fsr_releases is above 1; or value_fsr_releases is below 1; or worst frame time in the whole run is more than 25% above main. - **Time:** about 14 min of game runs per tester (2 game starts), plus the two builds. Done (started 13:14 UTC). Comment `@Beanstalk` to run it again. | Target | Reports | Crash | Frame p99 (ms) vs main | VRAM peak (MB) vs main | Result | | --- | --- | --- | --- | --- | --- | | linux | 0/1 | — | — | — | error | | steamdeck | 0/1 | — | — | — | queued |
HumanBean deleted branch fix/fsr-idle-own-use 2026-11-20 15:19:10 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1869
No description provided.