fix(build): the game's window and taskbar icon is Longshot's, not the old Hookshot one #1764

Merged
llun merged 1 commit from dyst/Longshot:fix/brand-icon into main 2026-11-19 17:41:58 +00:00
Member

Type: fix · Risk: low · Tested on: Windows 11, RTX 3080, Ryzen 9 3900X · Needs: nothing

TL;DR

The game's window and taskbar have shown the old blue Hookshot icon since the project became Longshot, in every build, 3.0.0 included. The icon file was renamed in the rename commit but its picture was never replaced. This makes it again from assets/longshot.png, the green Longshot logo the README and the start-up screen already use, and adds a check that the icon is that picture, so the next logo change can't leave it behind.

Breakdown

  • Who it helps: every player: the window, the taskbar and the exe show Longshot's icon.
  • What was wrong: builder/setup/longshot.ico, which every build links into the game's exe, is byte for byte the hookshot.ico it was renamed from in e2a4d453 ("Rename the project to Longshot"); that commit gave the PNGs the new art but not the .ico.
  • What changes: the .ico, made again from assets/longshot.png with nx2/make_icon.py (its seven sizes, Pillow 13.0.0 as pinned); tests/test_exe_icon.py checks its 32 and 256 pixel images against the logo.
  • What does not change: any code; how the icon is linked (nx2/build.py exe_resources) or loaded (host/display.c).
  • How it was checked: the test fails on main and passes here; the new icon's images looked at; nx2/make_icon.py assets/longshot.png <folder> makes the same file byte for byte.
  • What is still open: a look at a built game's window and taskbar.
  • Risk: low: one image file and a check.

Why

Players see the Hookshot icon on Longshot. git show --stat e2a4d453 lists builder/setup/{hookshot.ico => longshot.ico} with no size change, beside the new assets/longshot.png; nothing has touched the .ico since. tests/test_exe_icon.py checked that the icon was well formed and linked, not which picture it held, so nothing failed.

How to reproduce

Seen on: any Windows build since the rename, 3.0.0 included
Settings and switches: none
Steps: start the game and look at its window's icon and its taskbar button, or open builder/setup/longshot.ico
Expected: the green Longshot logo (assets/longshot.png)
Actual: the blue Hookshot icon

What changed

The icon file is made again from the logo, and the icon test now checks the picture as well as the file's form. No code changes.

  • builder/setup/longshot.ico: made again from assets/longshot.png (python nx2/make_icon.py assets/longshot.png work, then work/longshot.ico copied here), the same sizes as before (16 to 256 pixels, PNG images).
  • tests/test_exe_icon.py: check_picture decodes the .ico's 32 and 256 pixel images and assets/longshot.png (a small PNG reader of its own: the builders that make releases have no Pillow), shrinks each to 16 by 16 and fails above a distance of 12, naming the command that makes the icon again. The new icon is at 7.8 and 1.7, the Hookshot icon at 35.

Measurements

Verdict: nothing to measure: an image file, no code.

Flags and settings

None.

Testing

Tested:

  • python -I -B tests/test_exe_icon.py: fails on main ("the .ico's 32 pixel image is not assets/longshot.png (distance 35.2, above 12)") and passes here.

  • The new .ico's 32 and 256 pixel images looked at: the green Longshot logo.

  • python nx2/make_icon.py assets/longshot.png <folder> with Pillow 13.0.0 writes this .ico byte for byte.

  • python -I -B tests/run_all.py (Windows, the Builder's llvm-mingw): 690 passed, 41 failed, 125 skipped. Against main 868f6be8's 40, the one more is tests/test_high_fps_fixes.py (test_music_manager_flags), which fails the same on main 819a5967, this branch's base; tests/test_exe_icon.py passes.

Not tested: the icon in a running game's window and taskbar: the test reads back the .res the build links (icon group 1, every image of the .ico), which is what host/display.c loads.

Must be tested:

  • Windows, any PC: a build of this branch, started, expecting the green Longshot logo as its window's and taskbar button's icon (by hand).

Risks

What could break: nothing that runs: the build links the same file under the same name.

Turning it off: revert the commit.

Compatibility: none: a build links the new icon; saves, settings and the translation are unchanged.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A game-free test added for the fix, failing on main and passing here.

🤖 Generated with Claude Code

**Type:** fix · **Risk:** low · **Tested on:** Windows 11, RTX 3080, Ryzen 9 3900X · **Needs:** nothing ## TL;DR The game's window and taskbar have shown the old blue Hookshot icon since the project became Longshot, in every build, 3.0.0 included. The icon file was renamed in the rename commit but its picture was never replaced. This makes it again from `assets/longshot.png`, the green Longshot logo the README and the start-up screen already use, and adds a check that the icon is that picture, so the next logo change can't leave it behind. ## Breakdown - **Who it helps:** every player: the window, the taskbar and the exe show Longshot's icon. - **What was wrong:** `builder/setup/longshot.ico`, which every build links into the game's exe, is byte for byte the `hookshot.ico` it was renamed from in e2a4d453 ("Rename the project to Longshot"); that commit gave the PNGs the new art but not the .ico. - **What changes:** the .ico, made again from `assets/longshot.png` with `nx2/make_icon.py` (its seven sizes, Pillow 13.0.0 as pinned); `tests/test_exe_icon.py` checks its 32 and 256 pixel images against the logo. - **What does not change:** any code; how the icon is linked (`nx2/build.py` `exe_resources`) or loaded (`host/display.c`). - **How it was checked:** the test fails on main and passes here; the new icon's images looked at; `nx2/make_icon.py assets/longshot.png <folder>` makes the same file byte for byte. - **What is still open:** a look at a built game's window and taskbar. - **Risk:** low: one image file and a check. ## Why Players see the Hookshot icon on Longshot. `git show --stat e2a4d453` lists `builder/setup/{hookshot.ico => longshot.ico}` with no size change, beside the new `assets/longshot.png`; nothing has touched the .ico since. `tests/test_exe_icon.py` checked that the icon was well formed and linked, not which picture it held, so nothing failed. ## How to reproduce **Seen on:** any Windows build since the rename, 3.0.0 included **Settings and switches:** none **Steps:** start the game and look at its window's icon and its taskbar button, or open `builder/setup/longshot.ico` **Expected:** the green Longshot logo (`assets/longshot.png`) **Actual:** the blue Hookshot icon ## What changed The icon file is made again from the logo, and the icon test now checks the picture as well as the file's form. No code changes. - `builder/setup/longshot.ico`: made again from `assets/longshot.png` (`python nx2/make_icon.py assets/longshot.png work`, then `work/longshot.ico` copied here), the same sizes as before (16 to 256 pixels, PNG images). - `tests/test_exe_icon.py`: `check_picture` decodes the .ico's 32 and 256 pixel images and `assets/longshot.png` (a small PNG reader of its own: the builders that make releases have no Pillow), shrinks each to 16 by 16 and fails above a distance of 12, naming the command that makes the icon again. The new icon is at 7.8 and 1.7, the Hookshot icon at 35. ## Measurements **Verdict:** nothing to measure: an image file, no code. ### Flags and settings None. ## Testing **Tested:** - `python -I -B tests/test_exe_icon.py`: fails on main ("the .ico's 32 pixel image is not assets/longshot.png (distance 35.2, above 12)") and passes here. - The new .ico's 32 and 256 pixel images looked at: the green Longshot logo. - `python nx2/make_icon.py assets/longshot.png <folder>` with Pillow 13.0.0 writes this .ico byte for byte. - `python -I -B tests/run_all.py` (Windows, the Builder's llvm-mingw): 690 passed, 41 failed, 125 skipped. Against main 868f6be8's 40, the one more is `tests/test_high_fps_fixes.py` (`test_music_manager_flags`), which fails the same on main 819a5967, this branch's base; `tests/test_exe_icon.py` passes. **Not tested:** the icon in a running game's window and taskbar: the test reads back the .res the build links (icon group 1, every image of the .ico), which is what `host/display.c` loads. **Must be tested:** - Windows, any PC: a build of this branch, started, expecting the green Longshot logo as its window's and taskbar button's icon (by hand). ## Risks **What could break:** nothing that runs: the build links the same file under the same name. **Turning it off:** revert the commit. **Compatibility:** none: a build links the new icon; saves, settings and the translation are unchanged. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A game-free test added for the fix, failing on `main` and passing here. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(build): the game's window and taskbar icon is Longshot's, not the old Hookshot one
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 8s
Website / Website on Cloudflare (pull_request_target) Has been skipped
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 11s
CI / Workflow lint (actionlint) (pull_request) Successful in 12s
Third-party parts / As their notes say (pull_request) Successful in 13s
PR description / Description follows the template (pull_request_target) Successful in 5s
60dc36b999
builder/setup/longshot.ico, which every build links into the game's exe (nx2/build.py exe_resources, icon 1 of the
window: host/display.c), was renamed from hookshot.ico when the project became Longshot and kept its picture: the
blue Hookshot. It is made again from assets/longshot.png (nx2/make_icon.py, Pillow 13.0.0 as pinned), and
tests/test_exe_icon.py now checks that its 32 and 256 pixel images are that picture, decoded without Pillow.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
dyst changed title from WIP: fix(build): the game's window and taskbar icon is Longshot's, not the old Hookshot one to fix(build): the game's window and taskbar icon is Longshot's, not the old Hookshot one 2026-11-19 17:40:41 +00:00
llun approved these changes 2026-11-19 17:41:54 +00:00
llun merged commit f505340bbe into main 2026-11-19 17:41:58 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1764
No description provided.