fix(dev): a Tracy pack builds the game, also from an unchanged tree #1741
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1741
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:fix/tracy-pack-route"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Linux (a development script, no GPU involved) · Needs: none
TL;DR
Building a test pack with the Tracy profiler turned on (
LONGSHOT_TRACY=1) gave a pack with no profiler in it whenever the change touched only the renderer, or nothing at all, so a capture recorded nothing. Packs with the profiler on now always build the game, where the profiler's client lives. A new check fails onmainand passes here.Breakdown
dev_packs.py pack).pack_routesent aLONGSHOT_TRACY=1pack of an unchanged or renderer-only tree to the renderer-only build, or to no build, but Tracy's client is in the game's executable.LONGSHOT_TRACYset (and not0) routes the pack to the game build, asRX_PGOalready did.tests/test_vk_pgo.py'spack_routetable: the first fails onmain, all pass here; a Tracy pack built this way recorded captures in the game on my lab PC.Why
LONGSHOT_TRACY=1 dev_packs.py pack <base> tracyof a tree with no change (to profilemainitself) said there was nothing to build, and a renderer-only change built the renderer alone. Either way the pack's game had no Tracy client, andtracy-capturewaited for a connection that never came.How to reproduce
Seen on: Linux, any GPU
Settings and switches:
LONGSHOT_TRACY=1Steps:
LONGSHOT_TRACY=1 python -I scripts/dev_packs.py pack <base> tracyfrom a checkout at the base's commit, then run it withtracy-capture -a 127.0.0.1Expected: a pack with the Tracy client; the capture fills
Actual: "nothing to build" (or a renderer-only pack); the capture records nothing
What changed
pack_routeroutes aLONGSHOT_TRACYpack to the game.pack_routeinscripts/dev_packs.py:LONGSHOT_TRACY(set, not""or0) returns"game", besideRX_PGO.tests/test_vk_pgo.py: three cases in thepack_routetable (an unchanged tree, a renderer-only tree, andLONGSHOT_TRACY=0staying off).Measurements
Verdict: nothing to measure: a development script and its check.
Flags and settings
None.
Testing
Tested:
tests/test_vk_pgo.pyon Linux: fails onmain(FAIL: pack_route: a Tracy pack of an unchanged tree builds the game), passes here. With the fix,LONGSHOT_TRACY=1 dev_packs.py packof an unchanged tree built the game, and Tracy captures of Kokiri Forest recorded the game's and the renderer's zones (Linux, RX 580, Mesa RADV 26.2.6).tests/run_all.py --changedalso passes, apart fromtest_dev_packs.py("a game patch shows in the objects") andtest_switch_table.py, which fail the same way onmainon that PC.Not tested: Windows (the routing is the same Python on both).
Must be tested: None.
Risks
What could break: nothing outside
dev_packs.py packwithLONGSHOT_TRACYset.Turning it off: revert the commit.
Compatibility: Nothing changes.
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.mainand passing here.tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
https://claude.ai/code/session_016o1k1NeAdSovkHa9ukS7YM
WIP: fix(dev): a Tracy pack builds the game, also from an unchanged treeto fix(dev): a Tracy pack builds the game, also from an unchanged treeChecklist: ticked the box for the updated check under tests/ (test_vk_pgo.py reads scripts/dev_packs.py).