fix(vk): capture the HUD-less picture for FSR frame generation at native resolution #1691
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1691
Loading…
Reference in a new issue
No description provided.
Delete branch "futondestroyer/Longshot:fix-fsr-fg-native-hud"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Windows 11, RTX 4070, NVIDIA 621.01 · Needs: Windows, RX 9070 XT with FSR 4 native AA
TL;DR
The HUD could smear at 100% render resolution with FSR 3.1 frame generation because the game renders the picture at its final size and Longshot missed the opportunity to copy it before the HUD was drawn. The fix lets the known full-size gameplay pass supply that copy. A game-free test reproduces the missing copy on main. In a local native-resolution run, the HUD was marked on 0 of 600 presents with RC8 and 600 of 600 with the patch. The reporter’s AMD configuration still needs a visual check.
Breakdown
Why
FSR 3.1 frame generation interpolates a copy of the game world before the HUD is drawn and restores the current HUD afterward. Without that copy it uses the presented image and can drag the HUD with the scene. The 100% render-resolution path could miss the copy. See #1565 and the related FSR HUD fixes #1464, #1487 and #1538.
How to reproduce
Seen on: Windows 11 build 26200, Radeon RX 9070 XT, AMD driver 26.10.1, reported in #1565.
Settings and switches: FSR 4 at native render resolution, Frame generation 2×, Frame generation by FSR 3.1 FG, 1920×1080.
Steps: Play in Hyrule Field with the HUD visible. Pan the camera across a high-contrast background. Check that the FPS counter identifies FSR 3.1 FG, then inspect the minimap and button labels during camera movement.
Expected: HUD elements stay attached to the screen as the world moves.
Actual: The reporter sees smearing around the HUD. The source regression fixture independently shows that the known full-size dispatch returns no pre-HUD image on main.
What changed
gpu/vk/vk_draw.cppaccepts the selected output mip at equal width and height whengameplay_network()recognizes the dispatch. Inferred dispatches still require a wider output.tests/test_fsr3fi_hud_capture.pycompiles the actual capture selector from source. It tests the known native pass, inferred equal-sized dispatches, unequal height, smaller output, mip size, existing scaled capture, unrelated formats, and disabling FSR frame generation.Measurements
Verdict: Native gameplay capture is restored in the game-free test and confirmed by gameplay counters. The local gameplay run measured HUD marking and FSR generation counts. Performance and the visual outcome on the reporter’s AMD configuration remain open.
83b161e3478e556fGameplay hardware and scene: Windows 11, GeForce RTX 4070, NVIDIA 621.01, Kokiri Forest. 1920×1080, DLAA at native render resolution, pre-bloom DLAA forced off, FSR 3.1 FG 2×.
Gameplay baseline: Pinned RC8 host and renderer at
2f1c0c9c. The patch run used the same RC8 host and ABI-34 renderer built from the fix; the renderer is based on newer main. The independent game-free fixture above compares exact main and the patch.Flags and settings
None.
Testing
Tested: In Kokiri Forest, native DLAA and FSR 3.1 FG 2× were active with both renderers. HUD markings rose from 0/600 on stock RC8 to 600/600 in both observed patched windows. The fixture passed with Windows llvm-mingw on the patch and failed for the expected reason with the fixture alone on main. The Windows NGX renderer built and linked. The HUD-less color and normal upscale fallback fixtures passed. The existing PsychoV35 FSR FG fixture fails to compile on both this branch and main because its stubs lack
present,VK_NULL_HANDLEandhudless.Not tested: Visual inspection of matched generated frames, Radeon gameplay, performance impact, Linux, the wider game-free suite, and GLSL recompilation. The HUD-less color check verified the existing SPIR-V header’s source hash.
Must be tested:
Risks
What could break: The added native-resolution copy uses GPU time and memory bandwidth in this mode. If the wrong play image were selected, FSR could misclassify some pixels as HUD. The fix requires a recognized gameplay key, compatible color formats and exact dimensions.
Turning it off: Revert this commit.
Compatibility: No setting, save, shader cache format or renderer API change.
Issues
See #1565.
Checklist
Everyone
When it applies
Assisted-by:.Tested in game: Windows 11, RTX 4070, NVIDIA 621.01, Kokiri Forest at 1920x1080 with native DLAA and FSR 3.1 FG at 2x. Stock RC8 host and renderer marked the HUD on 0 of 600 presents with 600 actual FSR-generated presents. On the same API-34 host, the patched
478e556frenderer marked the HUD on 600 of 600 presents while FSR made all 600. The exact RX 9070 XT visual check and performance measurement are pending.@Beanstalk
Beanstalk test farm
Commit
478e556· tier reviewed · approved by llun · dashboardWhat will be tested · AI plan (
gpt-6.1-terra)Compare 2× frame-generation modes during camera movement in Hyrule Field, using no upscaling as a native-resolution control. The run takes about 12 minutes and checks screenshots, frame times and VRAM; crashes or significant regressions fail. FSR 4 Native AA and generated-frame HUD counters cannot be verified by this plan.
0or1.kokiri-start(settings dlss=6, fps_counter=1, frame_generation=2), then teleport to Hyrule Field, move the stick, take the picture hud-after-pan to compare with main, measure field for 20 s (after 5 s warm-up); 1 run on each side for each of 2 cells (1 game start a run).Done (started 01:37 UTC, last report 01:38 UTC). Comment
@Beanstalkto run it again.NVIDIA GeForce RTX 3050 Ti Laptop GPU, 621.24.0frame_generation_by=0frame_generation_by=1Measurements · any
Verdict: could not be judged on any (1/1 report).
Hardware: 1: windows+nvidia+nvidia-proprietary+dgpu
NVIDIA GeForce RTX 3050 Ti Laptop GPU, 621.24.0AMD Ryzen 7 5800H with Radeon Graphics, 16 GB RAMScene: field-hud-pan, from the repository's save kokiri-start (dlss=6, fps_counter=1, frame_generation=2); each cell's settings and switches as the table names them
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); field-hud-pan: 1 game start a side, field 20 s after 5 s warm-up; each number the median of the runs, then of 1 report
How to reproduce: the farm's plan above (
@Beanstalkon this PR runs it again)Nothing was measured: no metric came back.
Flags and settings
frame_generation_by0,1Markdown for the PR description
WIP: fix(vk): capture the HUD-less picture for FSR frame generation at native resolutionto fix(vk): capture the HUD-less picture for FSR frame generation at native resolutionmooki referenced this pull request2026-11-19 02:00:05 +00:00
mooki referenced this pull request2026-11-19 02:03:41 +00:00