docs(vk): RX_VK_READBACK_LATE=3980,40,2000 on a discrete RADV card (RX 9070 XT) #1668
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1668
Loading…
Reference in a new issue
No description provided.
Delete branch "Molier/Longshot:docs/readback-late-radv"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Longshot already has
RX_VK_READBACK_LATE(#238, kept by #1763's renderer-threads rewrite:gpu/vk/switches.defrow and
vk_replay.cpp'sreadback_late_wantedare unchanged onmain @ 89c3d21e— verified by reading both): arule names GPU-result readbacks read without their write-back wait, off by default except the culling camera block
(0x3980 bytes, read without its wait on every PC) and, on handhelds, the newest submission's results too. This PR
only adds a second, independent measurement: on a discrete RADV card (RX 9070 XT),
RX_VK_LOG_READBACK_RANGES=1found the same dominant non-meter range (0x3980) the Steam Deck OLED PR found, plus two further sizes worth a rule
on this card (0x40, 0x2000); the exposure meter's own ranges are correctly left out by the switch's existing rule.
No code change — the switch, its rule syntax and the logging already do everything this needs. The text now lives in
docs/dev/reference/threads.md(#1802 moveddocs/development.mdthere) plus a newdocs/tested/entry.Still true after #1763: verified by reading
gpu/vk/vk_replay.cpp:3407(readback_late_wanted) andgpu/vk/switches.def'sRX_VK_READBACK_LATErow onupstream/main @ 89c3d21e— the default behaviour this PR'snumbers were measured against has not changed.
Testing
Tested: no code changed; this is a documentation-only update. No test in the current suite validates
docs/tested/'s format (tests/test_tested_configurations.py, named in the original commit, does not exist onmain @ 89c3d21eor in this rebase — the file this PR adds,docs/tested/2026-11-16-readback-late-oscar-run01.md,follows the existing entries' table format in that folder by eye).
Still to test: nothing further; this documents a measurement already taken.
Measurements
Verdict: the measured rule (
RX_VK_READBACK_LATE=3980,40,2000) helped on a discrete RADV card, on top of theexisting default.
Setup: Linux, headless, RX 9070 XT 16 GB (RADV/Mesa), Ryzen 7 5800X; 2560x1440, render resolution fixed 100%, frame
generation off, uncapped; a heavy six-leg route (Market/Castle Town/Hyrule Field x2) and a moving Hyrule Field route,
3 interleaved runs an arm, median frame time.
(c1_field, run_b and load fell inside the 3-run noise band and are not claimed.) No exposure pulse found by a direct
visual compare; a luma check across the pairs could not separate a small exposure shift from camera jitter from one
run each, so that part is not established, not ruled out (noted in
docs/tested/).Risks
None: no code change, a documentation addition naming a rule a player or tester can already set today. The luma
caveat above is written into the
docs/tested/entry so a reader does not take "no exposure pulse" as fully proven.Checklist
Ready for review
main; the title is a Conventional Commit.main).main(see Measurements; the switch's default is unchanged by #1763).third_party/untouched.When it applies
docs/dev/reference/threads.mdfor #1802).Assisted-by:trailers.Ready to merge
be03f400aa33dbda90b233dbda90b214eac40d86Rebased onto
main@89c3d21e.RX_VK_READBACK_LATE's default andreadback_late_wantedare unchanged by #1763, so the measurement this documents still applies. The paragraph it extends moved todocs/dev/reference/threads.mdin #1802; the added sentence moved with it.View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.