fix(vk): perf_report.cpp includes psapi.h again, so the Windows renderer compiles #1665
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1665
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:fix/perf-report-psapi"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Linux, the Windows renderer cross-built with llvm-mingw 20261104 · Needs: nothing more
TL;DR
The Windows renderer has not compiled since #1530: it removed
perf_report.cpp's#include <psapi.h>, andram_used_gbstill usesPROCESS_MEMORY_COUNTERS_EX. The v3.0.0-rc.8 release run stops in its Windows Vulkan back end job. This puts the include back.Breakdown
perf_report.cpp:90: error: unknown type name 'PROCESS_MEMORY_COUNTERS_EX'(release run 38467).#include <psapi.h>under_WIN32, as before #1530.longshot_vk.dlllinked.Why
Release run 38467 (v3.0.0-rc.8 on
10fab152) failed in "Windows Vulkan back end (llvm-mingw)":What changed
gpu/vk/perf_report.cpp:#include <psapi.h>under#ifdef _WIN32.Measurements
Nothing to measure: a compile fix.
Flags and settings
None.
Testing
Tested: the Vulkan back end cross-built for Windows from this branch:
RX_VK_ONLY=1 RX_RELEASE=1 RX_TARGET=windows LONGSHOT_MINGW=<llvm-mingw 20261104> python -I nx2/build.py --standalone, through the job queue: compiled in 278 s, 0 failed,longshot_vk.dlllinked.Not tested: a run in the game and
tests/run_all.py: no game runs or tests on this PC. Opened without a game run at the maintainer's request, to unblock the release.Must be tested: by hand on Windows, any GPU: the game starts and the performance summary's RAM reads as before, on the next nightly.
Risks
What could break: nothing; the file had this include until #1530.
Turning it off: revert the commit.
Compatibility: Nothing changes.
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.🤖 Generated with Claude Code
mooki referenced this pull request2026-11-18 23:19:34 +00:00
mooki referenced this pull request2026-11-19 02:05:59 +00:00