build(windows): the builder no longer downloads emsdk, which the Windows build never uses #1620

Merged
HumanBean merged 1 commit from TrashPanda/Longshot:build/windows-no-emsdk into main 2026-11-18 17:03:37 +00:00
Contributor

Type: build · Risk: low · Tested on: Linux (cross build for Windows), game-free checks · Needs: Windows, any GPU: a fresh builder install and a build

TL;DR

Every Windows install of Longshot downloads a 115 MiB compiler package (emsdk) that the Windows build never uses: the builder compiles everything with its own llvm-mingw. This PR stops downloading it. Each new Windows install, and each launcher update that brings a new tools set, saves 115 MiB of download (29% of the Windows tools) and 286 MiB unpacked. That helps most on slow connections and small disks. A new check shows that every tool the build looks up comes from llvm-mingw. The renderer cross-builds for Windows with an emsdk folder that is empty.

Breakdown

  • Who it helps: every Windows player who installs the builder or updates to a version with new tools, most of all on a slow or metered connection or a small drive.
  • What was wrong: tools.lock still listed Hookshot v2.1.0's emsdk for Windows, from before the builder bundled llvm-mingw, and the setup, the launcher and dev_build.py download everything the lock lists.
  • What changes: the Windows tools are llvm-mingw, Python, cpm and third-party; the builder sets RX_CPM and no longer EMSDK.
  • What does not change: the compiler, its flags, the game it builds, the shader-cache key the launcher compares (WindowsCompiler is llvm-mingw and cpm already), the Linux tools (their emsdk is the AppImage's LLVM and stays), and the Visual Studio route (LONGSHOT_MSVC=1) for developers, which still finds emsdk at C:\emsdk or EMSDK.
  • How it was checked: a new game-free check (fails on main, passes here), tests/run_all.py (no new failures), and the Windows renderer DLL cross-built from Linux with llvm-mingw and an empty EMSDK: compiled and linked.
  • What is still open: a native Windows build from a fresh install of this branch's tools (this PC has no Windows): the Test Farm is asked below.
  • Risk: low: if some Windows path did still need emsdk, the build would stop with "No C compiler was found"; reverting the lock line brings it back.

Why

The Windows builder has bundled llvm-mingw since it stopped needing Visual Studio, and nx2/make_game.py bundled_mingw always points the build at it. With LONGSHOT_MINGW set, third_party/a64-kit/tools/toolchain.py find takes clang, clang++, lld and every llvm-* tool from llvm-mingw's bin before it ever looks in EMSDK. The emsdk that tools.lock still lists for Windows (hookshot-v2.1.0, 120,100,315 bytes zipped) is a leftover of Hookshot's builder, and every Windows install downloads it, checks it and unpacks it for nothing.

Found in a code audit of build and download size for players on modest PCs and connections. No issue asks for this; the tracker, the team room and Hookshot's pull requests were searched (emsdk, llvm-mingw, tools.lock): nothing found.

What changed

The Windows lines of tools.lock lose emsdk, and nothing that sets up or runs the Windows build expects it any more. A new check holds that in place.

  • tools.lock: the tool emsdk hookshot-v2.1.0 windows-x64 ... line is gone; the header says why. scripts/tools.py REQUIRED["windows-x64"] no longer lists it, so the release workflow's check --require does not ask for it.
  • builder/LongshotBuilder/Runner.cs: the builder sets RX_CPM from its tools folder and no longer EMSDK. scripts/dev_build.py WINDOWS_TOOL_ENV follows it (it stopped a Windows dev build when the folder was missing). builder/setup/setup.c's comment no longer lists emsdk.
  • tests/test_windows_toolchain.py (new): scans the build's Python (nx2, scripts, builder, the a64-kit's tools) for every find("<tool>") and checks each is in llvm-mingw 20261104's bin (listed from the release zip; the check says to list it again when tools.lock bumps llvm-mingw). Then it runs toolchain.find for each with RX_TARGET=windows, a made-up llvm-mingw and an EMSDK that holds nothing, and expects llvm-mingw's every time. It fails on main (the lock's Windows emsdk) and passes here. The tools found today: clang, clang++, lld, llvm-cxxfilt, llvm-profdata.
  • tests/test_tools_lock.py, tests/test_dev_build.py: follow the lock and the builder (no Windows emsdk, no EMSDK).
  • docs/releases.md, docs/development.md, RELEASING.md: Windows has no emsdk.

The LongshotLauncher needs no change: it installs what tools.lock lists, sets EMSDK only when an emsdk folder is there (Core/MakeGameCommand.cs), and its Windows shader-cache key is llvm-mingw and cpm already (Core/ShaderCaches.cs WindowsCompiler).

Measurements

Verdict: it helps: a fresh Windows install downloads 115 MiB less (413.5 MB down to 293.4 MB of tools, -29%) and keeps 286 MiB less on disk; the build is unchanged (the same compiler, llvm-mingw's).

Hardware: Linux, AMD Zen 5 CPU (a download and build-tools change: no GPU involved)
Scene: none (no game run: the game's code and flags are unchanged)
Method: the sizes from tools.lock and the release zip; the unpacked size from the zip's index; the build with RX_TARGET=windows and an empty EMSDK
How to reproduce: python -I -B tests/test_windows_toolchain.py; the cross build command under Testing

Before: main @ 4408ce0d After: this PR @ e784c0d4
Windows tools downloaded on a fresh install 413,510,043 bytes (llvm-mingw, python, emsdk, cpm, third-party) 293,409,728 bytes (-29%)
emsdk download 120,100,315 bytes (115 MiB) none
emsdk unpacked on disk 299,492,821 bytes (286 MiB), 299 files none
$ awk '$1=="tool" && $4=="windows-x64" {s+=$6; n=n" "$2} END {print s, n}' tools.lock
413510043  llvm-mingw python emsdk cpm third-party      (main)
293409728  llvm-mingw python cpm third-party            (this PR)
emsdk-windows-x64 hookshot-v2.1.0 zip index: 299492821 bytes in 299 files

$ python -I -B tests/test_windows_toolchain.py
PASS: the Windows build's 5 tools (clang, clang++, lld, llvm-cxxfilt, llvm-profdata) are llvm-mingw's; no emsdk
(on main: FAIL: tools.lock has an emsdk for Windows again: nothing of the Windows build uses it)

$ RX_VK_ONLY=1 RX_RELEASE=1 RX_TARGET=windows LONGSHOT_MINGW=<llvm-mingw-20261104-ucrt-ubuntu-22.04-x86_64> EMSDK=<an empty folder> RX_CPM=<cpm> python -I nx2/build.py --standalone
210 files, 1 jobs, -D_CRT_SECURE_NO_WARNINGS -DLONGSHOT_NATIVE_CPU=znver5_znver5_d04790af63 -O1 -DA64_POLLING -DA64_WRITE_TRACK
compiled in 198s, 0 failed
linked .../sa/build/longshot_vk.dll: 14 MB (0s)

Flags and settings

None: no switch, menu row, ini key or build flag changes. The builder stops setting the EMSDK environment variable for the Windows build, which only the Visual Studio route reads.

Testing

Tested: Linux (Zen 5), no game run: the game's code, flags and compiler are unchanged, and the change is the Windows builder's download list.

  • python -I -B tests/test_windows_toolchain.py: passes here, fails on main for the reason above.
  • python -I -B tests/run_all.py (rebased on 876dc360, the 4 checks this PR touches re-run after the rebase onto 4408ce0d): 646 passed, 34 failed, 101 skipped. The same 34 fail on main 876dc360 (run with --exact on a clean checkout). They come from this PC (a .nup that is not a complete dump, missing packages) and none reads a file this PR changes: test_bug_report_defaults, test_cpu_report, test_crt_options, test_damage_debug_menu, test_dev_packs, test_discover, test_display_startup_failure, test_dlss_feature_size, test_failed_compile_keeps_objects, test_guest_imported, test_hud_layout_row, test_invalidate_quick, test_invalidate_vcore, test_libc_hooks, test_lift_lookups, test_linux_pressure, test_linux_preflight, test_linux_update, test_log_open_failure, test_mirror_budget, test_missing_nup, test_mods_size_table, test_pending_guest_import, test_pipeline_play_cache, test_present_thread, test_profiling_mode, test_psychov35_fsr3_fg, test_readback_timeout_source, test_run_all_changed, test_slow_frames, test_switch_table, test_upscaler_rows, test_walk, test_walk_key. The 101 skipped lack the Vulkan or SPIR-V headers or numpy on the runner's path, or are Windows only.
  • The Windows renderer DLL, cross-built from Linux through the job queue with llvm-mingw 20261104 (tools.lock's version) and EMSDK set to an empty folder: 210 files compiled, longshot_vk.dll linked (log above).

Not tested: a native Windows build from a fresh builder install of this branch's tools: this PC has no Windows. The Windows code paths are the same ones the cross build takes (toolchain.find with LONGSHOT_MINGW), and bundled_mingw sets that on every Windows build that is not LONGSHOT_MSVC=1.

Must be tested:

  • windows, any GPU: install the builder from this branch's tools.lock in a fresh folder (no other Longshot version beside it, so no emsdk is taken from one), build the game and start it, expecting no emsdk folder under LongshotBuilder/tools, the build to finish as on main, and the game to start (Test Farm: @Beanstalk windows, a fresh builder install of this PR and a full build, no emsdk in the tools folder).

Risks

What could break: a Windows build path that still looks up a tool llvm-mingw lacks would stop with "No C compiler was found". The new check fails as soon as the build's Python looks up such a tool. One case is left: a builder whose llvm-mingw folder is missing entirely and that is not LONGSHOT_MSVC=1 fell back to the Visual Studio route before. It failed there for players anyway ("The Windows SDK was not found"), and it now fails one step earlier with the missing-compiler message.

Turning it off: revert the commit (the emsdk package version stays in the organization's Packages, unchanged).

Compatibility: older installed versions keep their own emsdk folder; a new version's tools no longer include one. Shader and pipeline caches are not affected: the launcher's Windows compiler key is llvm-mingw and cpm, unchanged. Nothing changes for saves, options or the vk ABI.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Docs updated.

🤖 Generated with Claude Code

**Type:** build · **Risk:** low · **Tested on:** Linux (cross build for Windows), game-free checks · **Needs:** Windows, any GPU: a fresh builder install and a build ## TL;DR Every Windows install of Longshot downloads a 115 MiB compiler package (emsdk) that the Windows build never uses: the builder compiles everything with its own llvm-mingw. This PR stops downloading it. Each new Windows install, and each launcher update that brings a new tools set, saves 115 MiB of download (29% of the Windows tools) and 286 MiB unpacked. That helps most on slow connections and small disks. A new check shows that every tool the build looks up comes from llvm-mingw. The renderer cross-builds for Windows with an emsdk folder that is empty. ## Breakdown - **Who it helps:** every Windows player who installs the builder or updates to a version with new tools, most of all on a slow or metered connection or a small drive. - **What was wrong:** tools.lock still listed Hookshot v2.1.0's emsdk for Windows, from before the builder bundled llvm-mingw, and the setup, the launcher and dev_build.py download everything the lock lists. - **What changes:** the Windows tools are llvm-mingw, Python, cpm and third-party; the builder sets `RX_CPM` and no longer `EMSDK`. - **What does not change:** the compiler, its flags, the game it builds, the shader-cache key the launcher compares (`WindowsCompiler` is llvm-mingw and cpm already), the Linux tools (their `emsdk` is the AppImage's LLVM and stays), and the Visual Studio route (`LONGSHOT_MSVC=1`) for developers, which still finds emsdk at `C:\emsdk` or `EMSDK`. - **How it was checked:** a new game-free check (fails on `main`, passes here), `tests/run_all.py` (no new failures), and the Windows renderer DLL cross-built from Linux with llvm-mingw and an empty `EMSDK`: compiled and linked. - **What is still open:** a native Windows build from a fresh install of this branch's tools (this PC has no Windows): the Test Farm is asked below. - **Risk:** low: if some Windows path did still need emsdk, the build would stop with "No C compiler was found"; reverting the lock line brings it back. ## Why The Windows builder has bundled llvm-mingw since it stopped needing Visual Studio, and `nx2/make_game.py` `bundled_mingw` always points the build at it. With `LONGSHOT_MINGW` set, `third_party/a64-kit/tools/toolchain.py` `find` takes clang, clang++, lld and every `llvm-*` tool from llvm-mingw's `bin` before it ever looks in `EMSDK`. The emsdk that tools.lock still lists for Windows (`hookshot-v2.1.0`, 120,100,315 bytes zipped) is a leftover of Hookshot's builder, and every Windows install downloads it, checks it and unpacks it for nothing. Found in a code audit of build and download size for players on modest PCs and connections. No issue asks for this; the tracker, the team room and Hookshot's pull requests were searched (emsdk, llvm-mingw, tools.lock): nothing found. ## What changed The Windows lines of tools.lock lose emsdk, and nothing that sets up or runs the Windows build expects it any more. A new check holds that in place. - **tools.lock**: the `tool emsdk hookshot-v2.1.0 windows-x64 ...` line is gone; the header says why. `scripts/tools.py` `REQUIRED["windows-x64"]` no longer lists it, so the release workflow's `check --require` does not ask for it. - **builder/LongshotBuilder/Runner.cs**: the builder sets `RX_CPM` from its tools folder and no longer `EMSDK`. `scripts/dev_build.py` `WINDOWS_TOOL_ENV` follows it (it stopped a Windows dev build when the folder was missing). `builder/setup/setup.c`'s comment no longer lists emsdk. - **tests/test_windows_toolchain.py** (new): scans the build's Python (`nx2`, `scripts`, `builder`, the a64-kit's `tools`) for every `find("<tool>")` and checks each is in llvm-mingw 20261104's `bin` (listed from the release zip; the check says to list it again when tools.lock bumps llvm-mingw). Then it runs `toolchain.find` for each with `RX_TARGET=windows`, a made-up llvm-mingw and an `EMSDK` that holds nothing, and expects llvm-mingw's every time. It fails on `main` (the lock's Windows emsdk) and passes here. The tools found today: clang, clang++, lld, llvm-cxxfilt, llvm-profdata. - **tests/test_tools_lock.py**, **tests/test_dev_build.py**: follow the lock and the builder (no Windows emsdk, no `EMSDK`). - **docs/releases.md**, **docs/development.md**, **RELEASING.md**: Windows has no emsdk. The LongshotLauncher needs no change: it installs what tools.lock lists, sets `EMSDK` only when an `emsdk` folder is there (`Core/MakeGameCommand.cs`), and its Windows shader-cache key is llvm-mingw and cpm already (`Core/ShaderCaches.cs` `WindowsCompiler`). ## Measurements **Verdict:** it helps: a fresh Windows install downloads 115 MiB less (413.5 MB down to 293.4 MB of tools, -29%) and keeps 286 MiB less on disk; the build is unchanged (the same compiler, llvm-mingw's). Hardware: Linux, AMD Zen 5 CPU (a download and build-tools change: no GPU involved) Scene: none (no game run: the game's code and flags are unchanged) Method: the sizes from tools.lock and the release zip; the unpacked size from the zip's index; the build with `RX_TARGET=windows` and an empty `EMSDK` How to reproduce: `python -I -B tests/test_windows_toolchain.py`; the cross build command under Testing | | Before: main @ 4408ce0d | After: this PR @ e784c0d4 | |---|---|---| | Windows tools downloaded on a fresh install | 413,510,043 bytes (llvm-mingw, python, emsdk, cpm, third-party) | 293,409,728 bytes (-29%) | | emsdk download | 120,100,315 bytes (115 MiB) | none | | emsdk unpacked on disk | 299,492,821 bytes (286 MiB), 299 files | none | ``` $ awk '$1=="tool" && $4=="windows-x64" {s+=$6; n=n" "$2} END {print s, n}' tools.lock 413510043 llvm-mingw python emsdk cpm third-party (main) 293409728 llvm-mingw python cpm third-party (this PR) emsdk-windows-x64 hookshot-v2.1.0 zip index: 299492821 bytes in 299 files $ python -I -B tests/test_windows_toolchain.py PASS: the Windows build's 5 tools (clang, clang++, lld, llvm-cxxfilt, llvm-profdata) are llvm-mingw's; no emsdk (on main: FAIL: tools.lock has an emsdk for Windows again: nothing of the Windows build uses it) $ RX_VK_ONLY=1 RX_RELEASE=1 RX_TARGET=windows LONGSHOT_MINGW=<llvm-mingw-20261104-ucrt-ubuntu-22.04-x86_64> EMSDK=<an empty folder> RX_CPM=<cpm> python -I nx2/build.py --standalone 210 files, 1 jobs, -D_CRT_SECURE_NO_WARNINGS -DLONGSHOT_NATIVE_CPU=znver5_znver5_d04790af63 -O1 -DA64_POLLING -DA64_WRITE_TRACK compiled in 198s, 0 failed linked .../sa/build/longshot_vk.dll: 14 MB (0s) ``` ### Flags and settings None: no switch, menu row, ini key or build flag changes. The builder stops setting the `EMSDK` environment variable for the Windows build, which only the Visual Studio route reads. ## Testing **Tested:** Linux (Zen 5), no game run: the game's code, flags and compiler are unchanged, and the change is the Windows builder's download list. - `python -I -B tests/test_windows_toolchain.py`: passes here, fails on `main` for the reason above. - `python -I -B tests/run_all.py` (rebased on 876dc360, the 4 checks this PR touches re-run after the rebase onto 4408ce0d): 646 passed, 34 failed, 101 skipped. The same 34 fail on `main` 876dc360 (run with `--exact` on a clean checkout). They come from this PC (a .nup that is not a complete dump, missing packages) and none reads a file this PR changes: test_bug_report_defaults, test_cpu_report, test_crt_options, test_damage_debug_menu, test_dev_packs, test_discover, test_display_startup_failure, test_dlss_feature_size, test_failed_compile_keeps_objects, test_guest_imported, test_hud_layout_row, test_invalidate_quick, test_invalidate_vcore, test_libc_hooks, test_lift_lookups, test_linux_pressure, test_linux_preflight, test_linux_update, test_log_open_failure, test_mirror_budget, test_missing_nup, test_mods_size_table, test_pending_guest_import, test_pipeline_play_cache, test_present_thread, test_profiling_mode, test_psychov35_fsr3_fg, test_readback_timeout_source, test_run_all_changed, test_slow_frames, test_switch_table, test_upscaler_rows, test_walk, test_walk_key. The 101 skipped lack the Vulkan or SPIR-V headers or numpy on the runner's path, or are Windows only. - The Windows renderer DLL, cross-built from Linux through the job queue with llvm-mingw 20261104 (tools.lock's version) and `EMSDK` set to an empty folder: 210 files compiled, `longshot_vk.dll` linked (log above). **Not tested:** a native Windows build from a fresh builder install of this branch's tools: this PC has no Windows. The Windows code paths are the same ones the cross build takes (`toolchain.find` with `LONGSHOT_MINGW`), and `bundled_mingw` sets that on every Windows build that is not `LONGSHOT_MSVC=1`. **Must be tested:** - windows, any GPU: install the builder from this branch's tools.lock in a fresh folder (no other Longshot version beside it, so no emsdk is taken from one), build the game and start it, expecting no `emsdk` folder under `LongshotBuilder/tools`, the build to finish as on `main`, and the game to start (Test Farm: @Beanstalk windows, a fresh builder install of this PR and a full build, no emsdk in the tools folder). ## Risks **What could break:** a Windows build path that still looks up a tool llvm-mingw lacks would stop with "No C compiler was found". The new check fails as soon as the build's Python looks up such a tool. One case is left: a builder whose `llvm-mingw` folder is missing entirely and that is not `LONGSHOT_MSVC=1` fell back to the Visual Studio route before. It failed there for players anyway ("The Windows SDK was not found"), and it now fails one step earlier with the missing-compiler message. **Turning it off:** revert the commit (the emsdk package version stays in the organization's Packages, unchanged). **Compatibility:** older installed versions keep their own emsdk folder; a new version's tools no longer include one. Shader and pipeline caches are not affected: the launcher's Windows compiler key is llvm-mingw and cpm, unchanged. Nothing changes for saves, options or the vk ABI. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Docs updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
build(windows): the builder no longer downloads emsdk, which the Windows build never uses
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
beanstalk/approval not approved yet
e784c0d4b7
Every Windows install of the builder (its setup, the launcher, dev_build.py) downloaded tools.lock's
windows-x64 emsdk: 120,100,315 bytes (115 MiB) zipped. Nothing on the Windows build path reads it. The
builder's own llvm-mingw is LONGSHOT_MINGW (nx2/make_game.py bundled_mingw), and with it set,
toolchain.find takes clang, clang++, lld and llvm-* from llvm-mingw's bin before it looks in EMSDK.
Those are the only tools the build looks up (clang, clang++, lld, llvm-cxxfilt, llvm-profdata), and
llvm-mingw 20261104 has all of them. The launcher's shader-cache key for Windows already names only
llvm-mingw and cpm (LongshotLauncher Core/ShaderCaches.cs WindowsCompiler).

- tools.lock: the windows-x64 emsdk line is gone; scripts/tools.py REQUIRED no longer asks for it.
- builder/LongshotBuilder/Runner.cs and scripts/dev_build.py WINDOWS_TOOL_ENV set RX_CPM alone, no EMSDK.
- tests/test_windows_toolchain.py: every tool the build's Python looks up is in llvm-mingw's bin (listed
  from the 20261104 release), and toolchain.find gives llvm-mingw's with an EMSDK that holds nothing.
  It fails on main (the lock's Windows emsdk). test_tools_lock and test_dev_build follow the lock.
- docs/releases.md, docs/development.md, RELEASING.md: Windows has no emsdk.

The Visual Studio route (LONGSHOT_MSVC=1, a developer's) still finds emsdk at C:\emsdk or EMSDK as before.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Contributor

@Beanstalk windows, any GPU: install the Longshot Builder from this PR's tools.lock into a fresh folder, with no other Longshot version beside it (so no emsdk is taken from one), then build the game and start it. Expected: no emsdk folder under LongshotBuilder/tools, the build finishes as it does on main, and the game starts to its title screen.

@Beanstalk windows, any GPU: install the Longshot Builder from this PR's tools.lock into a fresh folder, with no other Longshot version beside it (so no emsdk is taken from one), then build the game and start it. Expected: no emsdk folder under LongshotBuilder/tools, the build finishes as it does on main, and the game starts to its title screen.
Member

@TrashPanda only members of BigBeans can start the farm. One of them can approve this request by reacting 👍 to it or to this comment.

@TrashPanda only members of `BigBeans` can start the farm. One of them can approve this request by reacting 👍 to it or to this comment.
TrashPanda changed title from WIP: build(windows): the builder no longer downloads emsdk, which the Windows build never uses to build(windows): the builder no longer downloads emsdk, which the Windows build never uses 2026-11-18 16:53:51 +00:00
HumanBean deleted branch build/windows-no-emsdk 2026-11-18 17:03:37 +00:00
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
beanstalk/approval not approved yet
Some workflows are waiting to be reviewed.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1620
No description provided.