feat(prompts): hand-drawn DualSense and Xbox pictures for the System page, and the game's own tint #1589

Merged
HumanBean merged 8 commits from madebyjordan/Longshot:feat/dualsense-picture into main 2026-11-18 17:02:18 +00:00
Member

Type: feat · Risk: low · Tested on: Windows 11, RX 6700 XT · Needs: Linux, any GPU

TL;DR

The pause menu's System page drew the PlayStation and Xbox controllers as generic pads, and several label lines pointed at the wrong control (the d-pad's at the left stick, R2's and RT's at empty space). This PR replaces them with pictures drawn by hand in the game's style, a DualSense for both PlayStation faces and an Xbox One pad for Xbox, with every line on its control. It also fixes how the page colours a controller picture, so these and the Steam Deck's match the game's Pro Controller. Checked in the game on Windows for PS5, PS4 and Xbox, before and after, with a new test for the colours.

Breakdown

  • Who it helps: anyone playing with a PlayStation or Xbox controller, and anyone on the Steam Deck face (colours only).
  • What was wrong: the PlayStation and Xbox pictures were generated from font glyphs; three of the page's line textures are the game's own, drawn for the Switch Pro Controller's layout; and the page's tint was a straight-line fit the game's own colours don't follow.
  • What changes: a hand-drawn DualSense for both PlayStation faces and a hand-drawn Xbox One pad for the Xbox face, each with lines drawn to it, and the tint taken grey by grey from the game's own picture.
  • What does not change: the Switch face (byte-identical prompts), the Steam Deck picture and lines (only its colours), the icons, settings and saves.
  • How it was checked: in-game runs to the System page (main and this PR, PS5, PS4 and Xbox), a new game-free test failing on main and passing here, the prompt checks and the whole suite.
  • What is still open: a Linux run; the Steam Deck face keeps the game's fixed L, R, ZR and d-pad lines (#1211); the Steam Deck and DualShock 4 pictures.
  • Risk: low: build-time images only; a wrong part would put a line beside its control, which the screenshots show it doesn't.

Why

On the System page (Basic Controls) with Button prompts on PlayStation 5, the controller was a generic pad generated from Kenney's glyph: no DualSense shape, stacked shoulder plates, a house icon for the PS button. The page's lines followed the Switch Pro Controller: the d-pad's frame and line sat on the left stick, R2's line ended in the air above the right shoulder, and L1 and L2 ended on one point. The PlayStation 4 face showed the same generated kind of picture. On Xbox the picture was a generated Xbox Series pad with a house for the Xbox button; LT's and LB's lines ended on one point and RT's dot sat in the air above the right shoulder.

The tinted copy every drawn picture gets was off as well: the game turns its black outlines a brown lighter than the body and the body almost black, which a straight-line fit can't do, so the outlines went black, the body brown-grey and the buttons dull.

This builds on #406 (Stellarznith), which started the hand-drawn DualSense and the hand-given line textures: its two commits are kept, rebased onto main, under their author. See #1211 for the general fix the lines still need on the other faces.

The other controllers are planned the same way: the DualSense was chosen first, the Xbox pad followed and is in this PR too; the Steam Deck and a DualShock 4 for the PS4 face are next (the DualSense serves both PlayStation faces until then).

How to reproduce

Seen on: Windows 11, RX 6700 XT, AMD 26.10.1 (any PC: the images are made at the build)
Settings and switches: Button prompts = PlayStation 5 (button_prompts=4) or Xbox (2)
Steps: load a save, open the pause menu, ZR to the System page
Expected: a DualSense (an Xbox pad), each label's line ending on its control
Actual: a generic pad; PS5: the d-pad's frame round the left stick, R2's dot in the air, L1 and L2 on one point; Xbox: LT and LB on one point, RT's dot in the air

What changed

The pictures are Jordan's (madebyjordan): drawn in the game's greys like its Pro Controller, so the page tints them as it does the game's own. The page's two routed line textures follow its parts, and the three the router doesn't draw are given for it. The tint takes each grey's colour from the game's own picture pair.

  • tint: picture_layers in nx2/prompt_assets.py builds a table of the median tinted colour of each grey the game's Pro Controller pair drew enough of (20+ pixels), and blends between them, instead of a line fitted per channel. Measured on the game's own pair: mean error 8.0 → 1.4 of 255, 95th percentile 19.2 → 4.3. #406's by_hand (a hand-given picture kept its own colours) is gone: a picture in colours of its own gives its Controller_Pro1.png by hand, which the overrides already take.
  • picture: nx2/prompt_faces/ps4/ and ps5/Controller_Pro.png (1160x680; the controller 857x585 at 151,48, as wide as the game's Pro Controller); _DUALSENSE parts in nx2/prompt_faces.py, shared by both faces.
  • Xbox picture: nx2/prompt_faces/xbox/Controller_Pro.png (1160x680, an Xbox One pad, the controller 860x608 at 152,35, in the same greys) and its _XBOX parts, with its own ControllerGuide_Pro_02 to 04 drawn the same way as the DualSense's. A bumper's line ends on the band under its trigger's hump, inside the trigger's line: the Menu line leaves no other way to RB without a crossing.
  • lines: ControllerGuide_Pro_00/01 are routed from the parts again (#406 gave them by hand, which kept them from following the controls). ControllerGuide_Pro_02 (ZR), 03 (the d-pad's frame and line) and 04 (L and R) are given for this picture, drawn with the router's own guide_line and guide_frame to its parts at the game's rows (333, 1016, 446): lines only. guide_layers_of keeps the game's labels' bars under them at the build, so nothing of the game's is in git; hand_layers (the overrides, moved out of face_layers) leaves those three to it. A hand-given one is size-checked first and written whole even with no line in it; a face that gives them without the Controller_Pro.png they were drawn for stops the build rather than falling back to the generated picture.
  • tests: tests/test_prompt_picture_tint.py: a synthetic pair with the colours measured on the game's Pro Controller, a few stray pixels, a blended edge and a part the tinted copy leaves clear, and greys checked against their rounded blend; fails on main (grey #00 is tinted (0, 0, 0), the game's is (26, 19, 10)), and catches a nearest-grey lookup, the mean, no edge filter, the plain picture's alpha alone and truncation (each tried). tests/test_prompt_hand_guides.py: 02 to 04 keep the game's bars and cover its lines (fails with the overrides putting them back raw).
  • docs: nx2/prompt_faces/README.md (the hand-given 02 to 04, drawing in the game's greys); docs/tested/2026-11-18-dualsense-picture-jordan-run01.md and 2026-11-18-xbox-picture-jordan-run01.md.

Measurements

Verdict: it works: on PS5 and PS4 the System page shows the DualSense, on Xbox the Xbox One pad, with every line on its control and none crossing on Xbox; the Switch face's prompts are byte-identical to main's. The tint's error against the game's own pair drops from 8.0 to 1.4 (mean, of 255).

The numbers still hold on main 876dc360, which this PR is now on: its one commit since 430eef4f (#1569, the build's package extraction) changes no prompt file (nx2/prompt_assets.py, prompt_faces.py, prompt_draw.py and prompt_faces/ are the same), so main's prompts are made by the same code.

Hardware: Windows 11 Home 26200, AMD Radeon RX 6700 XT 12 GB, AMD 26.10.1, Ryzen 5 5600, 16 GB
Scene: a copied save in Kakariko Village, the pause menu's System page; 1920x1080 offscreen (HOS_HEADLESS), the folder's options otherwise
Method: one run per side and face (main PS5, this PR PS5, PS4, then main Xbox, PS4; this PR's Xbox once the picture was in, run twice as the first missed its ZR presses) in a copy of the nightly-484-430eef4f game folder, only its prompts/ swapped (this PR's made by nx2/prompt_assets.py); presses by HOS_INPUT_SCRIPT on the frame clock, a capture every 60 presents; the log's prompts: lines. Prompts output compared file by file with main's from the same RomFS.
How to reproduce: python -I nx2/prompt_assets.py --romfs <romfs> --out <game folder>/prompts, set button_prompts=4 (PS5), 3 (PS4) or 2 (Xbox), load a save, PLUS, then ZR to System

Before: main @ 430eef4f After: this PR @ ab11ff63
PS5 picture generated pad; d-pad frame on the left stick, R2 in the air, L1 = L2 the DualSense; every line on its control
PS4 picture generated DualShock 4 pad; the same misplaced d-pad and R2 lines the DualSense, the same lines as PS5
Xbox picture generated Xbox Series pad, brown-grey; LT = LB, RT in the air the Xbox One pad in the game's tint; every line on its control
prompts: <face> textures ps5 1914, ps4 2106, xbox 2201 runs ps5 2488, ps4 2488, xbox 2652 runs
Prompts output against main's switch identical; steamdeck differs in Controller_Pro1 only; ps4, ps5 and xbox new
Tint error on the game's own pair (of 255) mean 8.0, p95 19.2 mean 1.4, p95 4.3
main:     [hos ARes Loading 1] prompts: ps5 textures, 1914 runs for this pad's controls
this PR:  [hos ARes Loading 1] prompts: ps5 textures, 2488 runs for this pad's controls
this PR:  [hos ARes Loading 1] prompts: ps4 textures, 2488 runs for this pad's controls
main:     [hos ARes Loading 0] prompts: xbox textures, 2201 runs for this pad's controls
this PR:  [hos ARes Loading 0] prompts: xbox textures, 2652 runs for this pad's controls
tests/test_prompt_picture_tint.py, main:    FAIL: grey #00 is tinted (0, 0, 0), the game's is (26, 19, 10)
tests/test_prompt_picture_tint.py, this PR: ok: the tinted copy takes the game's colour for each grey (outlines, body, buttons, symbols, and between)

The PlayStation screenshots are of 659c6bdf, before the Xbox picture and a rebase onto main 876dc360; the PlayStation and Steam Deck prompts are byte-identical at ab11ff63.

The System page with Button prompts = PlayStation 5, the same save and spot, Before: main @ 430eef4f above, After: this PR @ 659c6bdf below:

The System page, PlayStation 5: Before: main @ 430eef4f, After: this PR @ 659c6bdf

The picture at 2x. Before: the d-pad's frame on the left stick, R2's dot in the air, L1 and L2 on one point. After: every line on its control.

PlayStation 5 at 2x: Before: main @ 430eef4f, After: this PR @ 659c6bdf

PlayStation 4 (the same picture now):

PlayStation 4 at 2x: Before: main @ 430eef4f, After: this PR @ 659c6bdf

The System page with Button prompts = Xbox, Before: main @ 430eef4f above, After: this PR @ ab11ff63 below:

The System page, Xbox: Before: main @ 430eef4f, After: this PR @ ab11ff63

The Xbox picture at 2x. Before: LT's and LB's lines on one point, RT's dot in the air. After: every line on its control, none crossing.

Xbox at 2x: Before: main @ 430eef4f, After: this PR @ ab11ff63

Flags and settings

None.

Testing

Tested: On Windows 11 Home 26200, RX 6700 XT, AMD 26.10.1: headless runs to the pause menu's System page from a copied save, this PR's prompts against the nightly-484-430eef4f folder's own (main 430eef4f), PS5, PS4 and Xbox (this PR's Xbox run with this head's prompts): the screenshots above. Game-free: tests/test_prompt_picture_tint.py fails on main and at its own commit and passes from the fix on; every check that reads the prompt files passes with --strict (test_prompt_guide_lines, test_prompt_font_bind, test_prompt_skip, test_prompt_speed, test_prompts_live, test_prompt_auto_face, test_appimage_prompt_fonts, test_lift_cache, test_build_long_paths and the two new ones); the whole suite, python -I -B tests/run_all.py with llvm-mingw from the nightly-484 toolchain: 683 passed, 51 failed, 48 skipped here against main's 681 / 51 / 48 on the same PC, the same 51 failing on both (FSR, pipeline cache, the tested-configurations CRLF check and other checks that fail on this Windows PC on main too). The prompts output compared file by file with main's from the same RomFS; the in-game runs used an earlier state of this branch whose prompts are byte-identical to this head's (the review's changes touch no image); after the Xbox picture and the rebase onto main 876dc360 the prompt checks were run again, all passing. A second agent reviewed the branch cold; its findings (looser tests, an untested override skip, an empty tint table's message, an all-black hand texture skipping its size check, a silent fallback to the generated picture) are fixed here.

Not tested: Linux (the images are made by the same Python on both, nothing platform-specific changed); the Steam Deck face in the game (only its picture's colours change, by the same tint as the others'); 4K and ultrawide (the page's textures are fixed-size; nothing here changes how they're drawn).

Must be tested:

  • Linux, any GPU: build, set Button prompts to PlayStation 5, then Xbox, open the pause menu's System page, expecting the DualSense, then the Xbox pad, with every line on its control as in the screenshots (Test Farm: @Beanstalk linux, the pause menu's System page with Button prompts = PlayStation 5 and Xbox).

Risks

What could break: the System page's controller picture and lines on the PlayStation and Xbox faces, and the picture's colours on the Steam Deck face. A part out of place would put a line beside its control; the screenshots show none. The d-pad's line crosses the Move line: on a DualSense the left stick sits below the d-pad while its label sits above the d-pad's, so the lines have to cross until the labels follow the controller (#1211; #406's picture crosses them the same way). The Steam Deck face still has the game's fixed L, R, ZR and d-pad lines (#1211).

Turning it off: revert the commits (the PlayStation and Xbox faces go back to the generated pictures).

Compatibility: nothing for saves, options or caches; a build regenerates the button prompts (their stamp covers these files).

Issues

See #1211
See #406

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen.
  • A file in docs/tested/ for each new measured run (format in docs/tested-configurations.md).
  • A game-free test added for the fix, failing on main and passing here.
  • Docs updated.

Reviewer notes

  • One topic: the hand-drawn controller pictures and the tint they are drawn for. They are drawn in the game's greys and look right only with the game's tint; the tint fix also corrects the Steam Deck picture's colours, and is its own commit (test, then fix) to read or take apart. The Xbox picture is its own commit too.
  • Built on #406: its two commits are here, rebased onto main under their author; this PR replaces its picture and its hand-given 00/01 line textures and its by_hand, and keeps its HAND_GUIDES (the way 02 to 04 are given). If #406 lands first this rebases cleanly onto it.
  • The pictures show the PlayStation logo on the PS button, as #406's does, and the Xbox logo on the Xbox button. nx2/prompt_faces.py keeps the makers' logos out of the icons (every face keeps the game's Home icon); say if the pictures should drop them too.
  • One picture serves both PlayStation faces for now; a DualShock 4 for the PS4 face is among the planned ones.

🤖 Generated with Claude Code

**Type:** feat · **Risk:** low · **Tested on:** Windows 11, RX 6700 XT · **Needs:** Linux, any GPU ## TL;DR The pause menu's System page drew the PlayStation and Xbox controllers as generic pads, and several label lines pointed at the wrong control (the d-pad's at the left stick, R2's and RT's at empty space). This PR replaces them with pictures drawn by hand in the game's style, a DualSense for both PlayStation faces and an Xbox One pad for Xbox, with every line on its control. It also fixes how the page colours a controller picture, so these and the Steam Deck's match the game's Pro Controller. Checked in the game on Windows for PS5, PS4 and Xbox, before and after, with a new test for the colours. ## Breakdown - **Who it helps:** anyone playing with a PlayStation or Xbox controller, and anyone on the Steam Deck face (colours only). - **What was wrong:** the PlayStation and Xbox pictures were generated from font glyphs; three of the page's line textures are the game's own, drawn for the Switch Pro Controller's layout; and the page's tint was a straight-line fit the game's own colours don't follow. - **What changes:** a hand-drawn DualSense for both PlayStation faces and a hand-drawn Xbox One pad for the Xbox face, each with lines drawn to it, and the tint taken grey by grey from the game's own picture. - **What does not change:** the Switch face (byte-identical prompts), the Steam Deck picture and lines (only its colours), the icons, settings and saves. - **How it was checked:** in-game runs to the System page (main and this PR, PS5, PS4 and Xbox), a new game-free test failing on main and passing here, the prompt checks and the whole suite. - **What is still open:** a Linux run; the Steam Deck face keeps the game's fixed L, R, ZR and d-pad lines (#1211); the Steam Deck and DualShock 4 pictures. - **Risk:** low: build-time images only; a wrong part would put a line beside its control, which the screenshots show it doesn't. ## Why On the System page (Basic Controls) with Button prompts on PlayStation 5, the controller was a generic pad generated from Kenney's glyph: no DualSense shape, stacked shoulder plates, a house icon for the PS button. The page's lines followed the Switch Pro Controller: the d-pad's frame and line sat on the left stick, R2's line ended in the air above the right shoulder, and L1 and L2 ended on one point. The PlayStation 4 face showed the same generated kind of picture. On Xbox the picture was a generated Xbox Series pad with a house for the Xbox button; LT's and LB's lines ended on one point and RT's dot sat in the air above the right shoulder. The tinted copy every drawn picture gets was off as well: the game turns its black outlines a brown lighter than the body and the body almost black, which a straight-line fit can't do, so the outlines went black, the body brown-grey and the buttons dull. This builds on #406 (Stellarznith), which started the hand-drawn DualSense and the hand-given line textures: its two commits are kept, rebased onto main, under their author. See #1211 for the general fix the lines still need on the other faces. The other controllers are planned the same way: the DualSense was chosen first, the Xbox pad followed and is in this PR too; the Steam Deck and a DualShock 4 for the PS4 face are next (the DualSense serves both PlayStation faces until then). ## How to reproduce **Seen on:** Windows 11, RX 6700 XT, AMD 26.10.1 (any PC: the images are made at the build) **Settings and switches:** Button prompts = PlayStation 5 (`button_prompts=4`) or Xbox (`2`) **Steps:** load a save, open the pause menu, ZR to the System page **Expected:** a DualSense (an Xbox pad), each label's line ending on its control **Actual:** a generic pad; PS5: the d-pad's frame round the left stick, R2's dot in the air, L1 and L2 on one point; Xbox: LT and LB on one point, RT's dot in the air ## What changed The pictures are Jordan's (madebyjordan): drawn in the game's greys like its Pro Controller, so the page tints them as it does the game's own. The page's two routed line textures follow its parts, and the three the router doesn't draw are given for it. The tint takes each grey's colour from the game's own picture pair. - tint: `picture_layers` in `nx2/prompt_assets.py` builds a table of the median tinted colour of each grey the game's Pro Controller pair drew enough of (20+ pixels), and blends between them, instead of a line fitted per channel. Measured on the game's own pair: mean error 8.0 → 1.4 of 255, 95th percentile 19.2 → 4.3. #406's `by_hand` (a hand-given picture kept its own colours) is gone: a picture in colours of its own gives its `Controller_Pro1.png` by hand, which the overrides already take. - picture: `nx2/prompt_faces/ps4/` and `ps5/Controller_Pro.png` (1160x680; the controller 857x585 at 151,48, as wide as the game's Pro Controller); `_DUALSENSE` parts in `nx2/prompt_faces.py`, shared by both faces. - Xbox picture: `nx2/prompt_faces/xbox/Controller_Pro.png` (1160x680, an Xbox One pad, the controller 860x608 at 152,35, in the same greys) and its `_XBOX` parts, with its own `ControllerGuide_Pro_02` to `04` drawn the same way as the DualSense's. A bumper's line ends on the band under its trigger's hump, inside the trigger's line: the Menu line leaves no other way to RB without a crossing. - lines: `ControllerGuide_Pro_00`/`01` are routed from the parts again (#406 gave them by hand, which kept them from following the controls). `ControllerGuide_Pro_02` (ZR), `03` (the d-pad's frame and line) and `04` (L and R) are given for this picture, drawn with the router's own `guide_line` and `guide_frame` to its parts at the game's rows (333, 1016, 446): lines only. `guide_layers_of` keeps the game's labels' bars under them at the build, so nothing of the game's is in git; `hand_layers` (the overrides, moved out of `face_layers`) leaves those three to it. A hand-given one is size-checked first and written whole even with no line in it; a face that gives them without the `Controller_Pro.png` they were drawn for stops the build rather than falling back to the generated picture. - tests: `tests/test_prompt_picture_tint.py`: a synthetic pair with the colours measured on the game's Pro Controller, a few stray pixels, a blended edge and a part the tinted copy leaves clear, and greys checked against their rounded blend; fails on main (`grey #00 is tinted (0, 0, 0), the game's is (26, 19, 10)`), and catches a nearest-grey lookup, the mean, no edge filter, the plain picture's alpha alone and truncation (each tried). `tests/test_prompt_hand_guides.py`: 02 to 04 keep the game's bars and cover its lines (fails with the overrides putting them back raw). - docs: `nx2/prompt_faces/README.md` (the hand-given 02 to 04, drawing in the game's greys); `docs/tested/2026-11-18-dualsense-picture-jordan-run01.md` and `2026-11-18-xbox-picture-jordan-run01.md`. ## Measurements **Verdict:** it works: on PS5 and PS4 the System page shows the DualSense, on Xbox the Xbox One pad, with every line on its control and none crossing on Xbox; the Switch face's prompts are byte-identical to main's. The tint's error against the game's own pair drops from 8.0 to 1.4 (mean, of 255). The numbers still hold on main 876dc360, which this PR is now on: its one commit since 430eef4f (#1569, the build's package extraction) changes no prompt file (`nx2/prompt_assets.py`, `prompt_faces.py`, `prompt_draw.py` and `prompt_faces/` are the same), so main's prompts are made by the same code. Hardware: Windows 11 Home 26200, AMD Radeon RX 6700 XT 12 GB, AMD 26.10.1, Ryzen 5 5600, 16 GB Scene: a copied save in Kakariko Village, the pause menu's System page; 1920x1080 offscreen (`HOS_HEADLESS`), the folder's options otherwise Method: one run per side and face (main PS5, this PR PS5, PS4, then main Xbox, PS4; this PR's Xbox once the picture was in, run twice as the first missed its ZR presses) in a copy of the nightly-484-430eef4f game folder, only its `prompts/` swapped (this PR's made by `nx2/prompt_assets.py`); presses by `HOS_INPUT_SCRIPT` on the frame clock, a capture every 60 presents; the log's `prompts:` lines. Prompts output compared file by file with main's from the same RomFS. How to reproduce: `python -I nx2/prompt_assets.py --romfs <romfs> --out <game folder>/prompts`, set `button_prompts=4` (PS5), `3` (PS4) or `2` (Xbox), load a save, PLUS, then ZR to System | | Before: main @ 430eef4f | After: this PR @ ab11ff63 | |---|---|---| | PS5 picture | generated pad; d-pad frame on the left stick, R2 in the air, L1 = L2 | the DualSense; every line on its control | | PS4 picture | generated DualShock 4 pad; the same misplaced d-pad and R2 lines | the DualSense, the same lines as PS5 | | Xbox picture | generated Xbox Series pad, brown-grey; LT = LB, RT in the air | the Xbox One pad in the game's tint; every line on its control | | `prompts: <face> textures` | ps5 1914, ps4 2106, xbox 2201 runs | ps5 2488, ps4 2488, xbox 2652 runs | | Prompts output against main's | | switch identical; steamdeck differs in `Controller_Pro1` only; ps4, ps5 and xbox new | | Tint error on the game's own pair (of 255) | mean 8.0, p95 19.2 | mean 1.4, p95 4.3 | ``` main: [hos ARes Loading 1] prompts: ps5 textures, 1914 runs for this pad's controls this PR: [hos ARes Loading 1] prompts: ps5 textures, 2488 runs for this pad's controls this PR: [hos ARes Loading 1] prompts: ps4 textures, 2488 runs for this pad's controls main: [hos ARes Loading 0] prompts: xbox textures, 2201 runs for this pad's controls this PR: [hos ARes Loading 0] prompts: xbox textures, 2652 runs for this pad's controls tests/test_prompt_picture_tint.py, main: FAIL: grey #00 is tinted (0, 0, 0), the game's is (26, 19, 10) tests/test_prompt_picture_tint.py, this PR: ok: the tinted copy takes the game's colour for each grey (outlines, body, buttons, symbols, and between) ``` The PlayStation screenshots are of 659c6bdf, before the Xbox picture and a rebase onto main 876dc360; the PlayStation and Steam Deck prompts are byte-identical at ab11ff63. The System page with Button prompts = PlayStation 5, the same save and spot, `Before: main @ 430eef4f` above, `After: this PR @ 659c6bdf` below: ![The System page, PlayStation 5: Before: main @ 430eef4f, After: this PR @ 659c6bdf](https://git.magicbean.dev/attachments/d5eb1562-d098-4115-a9be-7d2d41f36a51) The picture at 2x. Before: the d-pad's frame on the left stick, R2's dot in the air, L1 and L2 on one point. After: every line on its control. ![PlayStation 5 at 2x: Before: main @ 430eef4f, After: this PR @ 659c6bdf](https://git.magicbean.dev/attachments/71d597d2-0cf6-4b78-983b-ef733fe3c77f) PlayStation 4 (the same picture now): ![PlayStation 4 at 2x: Before: main @ 430eef4f, After: this PR @ 659c6bdf](https://git.magicbean.dev/attachments/ad571daf-145d-4f30-8aa3-4c533250e6e2) The System page with Button prompts = Xbox, `Before: main @ 430eef4f` above, `After: this PR @ ab11ff63` below: ![The System page, Xbox: Before: main @ 430eef4f, After: this PR @ ab11ff63](https://git.magicbean.dev/attachments/8270c446-bc2f-4536-8a58-7232a3f722e3) The Xbox picture at 2x. Before: LT's and LB's lines on one point, RT's dot in the air. After: every line on its control, none crossing. ![Xbox at 2x: Before: main @ 430eef4f, After: this PR @ ab11ff63](https://git.magicbean.dev/attachments/b2e50058-ce37-44f9-99aa-eeeebe0f8a6e) ### Flags and settings None. ## Testing **Tested:** On Windows 11 Home 26200, RX 6700 XT, AMD 26.10.1: headless runs to the pause menu's System page from a copied save, this PR's prompts against the nightly-484-430eef4f folder's own (main 430eef4f), PS5, PS4 and Xbox (this PR's Xbox run with this head's prompts): the screenshots above. Game-free: `tests/test_prompt_picture_tint.py` fails on main and at its own commit and passes from the fix on; every check that reads the prompt files passes with `--strict` (`test_prompt_guide_lines`, `test_prompt_font_bind`, `test_prompt_skip`, `test_prompt_speed`, `test_prompts_live`, `test_prompt_auto_face`, `test_appimage_prompt_fonts`, `test_lift_cache`, `test_build_long_paths` and the two new ones); the whole suite, `python -I -B tests/run_all.py` with llvm-mingw from the nightly-484 toolchain: 683 passed, 51 failed, 48 skipped here against main's 681 / 51 / 48 on the same PC, the same 51 failing on both (FSR, pipeline cache, the tested-configurations CRLF check and other checks that fail on this Windows PC on main too). The prompts output compared file by file with main's from the same RomFS; the in-game runs used an earlier state of this branch whose prompts are byte-identical to this head's (the review's changes touch no image); after the Xbox picture and the rebase onto main 876dc360 the prompt checks were run again, all passing. A second agent reviewed the branch cold; its findings (looser tests, an untested override skip, an empty tint table's message, an all-black hand texture skipping its size check, a silent fallback to the generated picture) are fixed here. **Not tested:** Linux (the images are made by the same Python on both, nothing platform-specific changed); the Steam Deck face in the game (only its picture's colours change, by the same tint as the others'); 4K and ultrawide (the page's textures are fixed-size; nothing here changes how they're drawn). **Must be tested:** - Linux, any GPU: build, set Button prompts to PlayStation 5, then Xbox, open the pause menu's System page, expecting the DualSense, then the Xbox pad, with every line on its control as in the screenshots (Test Farm: @Beanstalk linux, the pause menu's System page with Button prompts = PlayStation 5 and Xbox). ## Risks **What could break:** the System page's controller picture and lines on the PlayStation and Xbox faces, and the picture's colours on the Steam Deck face. A part out of place would put a line beside its control; the screenshots show none. The d-pad's line crosses the Move line: on a DualSense the left stick sits below the d-pad while its label sits above the d-pad's, so the lines have to cross until the labels follow the controller (#1211; #406's picture crosses them the same way). The Steam Deck face still has the game's fixed L, R, ZR and d-pad lines (#1211). **Turning it off:** revert the commits (the PlayStation and Xbox faces go back to the generated pictures). **Compatibility:** nothing for saves, options or caches; a build regenerates the button prompts (their stamp covers these files). ## Issues See #1211 See #406 ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen. - [x] A file in `docs/tested/` for each new measured run (format in `docs/tested-configurations.md`). - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] Docs updated. ## Reviewer notes - One topic: the hand-drawn controller pictures and the tint they are drawn for. They are drawn in the game's greys and look right only with the game's tint; the tint fix also corrects the Steam Deck picture's colours, and is its own commit (test, then fix) to read or take apart. The Xbox picture is its own commit too. - Built on #406: its two commits are here, rebased onto main under their author; this PR replaces its picture and its hand-given 00/01 line textures and its `by_hand`, and keeps its `HAND_GUIDES` (the way 02 to 04 are given). If #406 lands first this rebases cleanly onto it. - The pictures show the PlayStation logo on the PS button, as #406's does, and the Xbox logo on the Xbox button. `nx2/prompt_faces.py` keeps the makers' logos out of the icons (every face keeps the game's Home icon); say if the pictures should drop them too. - One picture serves both PlayStation faces for now; a DualShock 4 for the PS4 face is among the planned ones. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
The PlayStation 5 prompt face draws its pause menu controller picture with
Kenney's PlayStation 5 glyph, scaled and placed by nx2/prompt_faces.py's
`drawing` numbers. It reads as a generic gamepad: the DualSense's own shape,
its light bar and its sticks are not there, and the page's leader lines are
routed to Kenney's proportions.

This gives that face a hand-drawn picture and the page's five leader line
textures, all in nx2/prompt_faces/ps5/ (the folder nx2/prompt_faces/README.md
documents), and makes the picture's own parts match:

- nx2/prompt_faces/ps5/Controller_Pro.png (1160x680 RGBA): a DualSense front
  view, drawn for this. The page's tinted copy and the shadow are still made
  from it.
- nx2/prompt_faces/ps5/ControllerGuide_Pro_0{0..4}.png (1555x1511, grey):
  the page's leader lines, drawn for this picture, so each line ends on the
  control its label names.
- nx2/prompt_assets.py: a picture given by hand is its own tinted copy. The
  page's tinted copy is fitted from the game's grey picture to its brown one,
  which takes a hand-drawn picture's colours away (the DualSense's light bar
  is blue). A hand-given guide texture is written whole, and the two the
  router draws are left to it when both are given.
- nx2/prompt_faces.py: the ps5 face's `parts` follow the new picture (sticks,
  d-pad, face buttons, shoulders, touchpad, mute), as its README requires.

Nothing else changes: the Switch, Xbox, PlayStation 4 and Steam Deck faces
keep their generated pictures, icons and lines, and the game's own textures
stay where a face does not override them.

Assisted-by: DeepSeek Harness
Assisted-by: DeepSeek Harness
A face's controller picture is drawn in grey like the game's Pro Controller,
and the page's tinted copy (Controller_Pro1) is made from the game's own
grey/tinted pair. The game's tint is not a straight line of the grey: its
black outlines turn a brown lighter than the #333333 body, which turns almost
black. picture_layers fits a line through the pair, which crushes the outlines
to black, lights the body and dims the buttons on every drawn face (PlayStation,
Xbox, Steam Deck).

Game-free: a synthetic pair with the colours measured on the game's Pro
Controller, with a few stray pixels, a blended edge and a part the tinted copy
leaves clear; the greys between two of the pair's are checked against their
rounded blend. Fails on main: grey #00 is tinted (0, 0, 0), the game's is
(26, 19, 10).

Co-Authored-By: Claude Opus 5.5 <[email protected]>
picture_layers made the page's tinted copy of a face's picture with a line
fitted per channel through the game's grey/tinted pair. The game's tint is no
line: black outlines become #1a130a, lighter than the body's #333333 that
becomes #0d0a09, and the #646464 buttons #544935. The line crushed the outlines
to black, lit the body and dimmed the buttons (mean error 8.0 of 255 on the
game's own Pro Controller, 19.2 at the 95th percentile).

The copy now takes, for each grey, the median colour the game's pair gives it,
blended between the greys the game drew enough of (mean error 1.4, 95th
percentile 4.3). It is made for every drawn face: the Xbox and Steam Deck
pictures change colour only.

A hand-given picture is tinted the same way again (#406's by_hand left a
picture given by hand in its own colours): a picture in colours of its own
gives its Controller_Pro1.png by hand, which the overrides already take.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
The System page's controller picture for both PlayStation faces is a DualSense
drawn by hand by Jordan (madebyjordan), in the game's greys like its Pro
Controller (body #333333, buttons #646464, black outlines), so the page tints
it as it does the game's own (the previous commit). It replaces the DualSense
of #406 (Stellarznith), whose picture kept its own colours, and the generated
Kenney picture of the PlayStation 4 face. The other faces are unchanged.

- nx2/prompt_faces/ps4/ and ps5/Controller_Pro.png: the picture (1160x680,
  the controller 857x585 at 151,48, as wide as the game's Pro Controller).
- nx2/prompt_faces.py: both faces' parts (_DUALSENSE) measured on it.
- ControllerGuide_Pro_00 and 01 are routed from those parts again (#406 gave
  them by hand, which kept them from following the controls).
- ControllerGuide_Pro_02 to 04 (ZR, the d-pad's frame and line, L and R, the
  lines the router doesn't draw) are given by hand for this picture, drawn with
  the router's own guide_line and guide_frame to its parts from the game's
  rows (333, 1016, 446): lines only. The game's labels' bars are kept under
  them at the build (guide_layers_of), so nothing of the game's is in git, and
  hand_layers (the overrides, out of face_layers) leaves them as they are. A
  hand-given one is written whole even with no line in it, after its size is
  checked; a face that gives them without the picture they were drawn for stops
  the build. Before, those three were the game's own, drawn for the Pro
  Controller, which put the d-pad's frame on the DualSense's left stick and
  ZR's dot in the air (#1211).
- tests/test_prompt_hand_guides.py: the three keep the game's bars and cover
  its lines (fails with the overrides putting them back raw).
- README: the hand-given 02 to 04, and drawing a picture in the game's greys.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
docs(testing): the DualSense picture's run on Windows (RX 6700 XT)
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 8s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 11s
CI / Workflow lint (actionlint) (pull_request) Successful in 12s
Third-party parts / As their notes say (pull_request) Successful in 12s
Website / Website on Cloudflare (pull_request_target) Has been skipped
beanstalk/approval needs a second approval (sensitive paths)
PR description / Description follows the template (pull_request_target) Successful in 6s
659c6bdf24
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Member

Tested in game: Windows 11 Home 26200, RX 6700 XT, AMD 26.10.1: the pause menu's System page from a Kakariko Village save with Button prompts on PlayStation 5, PlayStation 4 and Xbox, against main 430eef4f's prompts in the same nightly-484 folder. PS5 and PS4 show the drawn DualSense with every line on its control (L2, L1, Create, the d-pad's frame, both sticks, R2, R1, Options, the face buttons); main puts the d-pad's frame on the left stick and R2's dot in the air. Xbox: the same picture in the game's own colours. Log: prompts: ps5 textures, 2488 runs (main 1914). No crash.

Tested in game: Windows 11 Home 26200, RX 6700 XT, AMD 26.10.1: the pause menu's System page from a Kakariko Village save with Button prompts on PlayStation 5, PlayStation 4 and Xbox, against main 430eef4f's prompts in the same nightly-484 folder. PS5 and PS4 show the drawn DualSense with every line on its control (L2, L1, Create, the d-pad's frame, both sticks, R2, R1, Options, the face buttons); main puts the d-pad's frame on the left stick and R2's dot in the air. Xbox: the same picture in the game's own colours. Log: prompts: ps5 textures, 2488 runs (main 1914). No crash.
Author
Member

@Beanstalk linux, any GPU: build this PR, set Button prompts to PlayStation 5, load a save and open the pause menu's System page (PLUS, then ZR to System). Expect the drawn DualSense with every label's line ending on its control (L2, L1, Create, the d-pad's frame, both sticks, R2, R1, Options, the face buttons' frame) and the log line prompts: ps5 textures, 2488 runs.

@Beanstalk linux, any GPU: build this PR, set Button prompts to PlayStation 5, load a save and open the pause menu's System page (PLUS, then ZR to System). Expect the drawn DualSense with every label's line ending on its control (L2, L1, Create, the d-pad's frame, both sticks, R2, R1, Options, the face buttons' frame) and the log line `prompts: ps5 textures, 2488 runs`.
Member

@madebyjordan approval of 659c6bd recorded. This diff touches sensitive paths, so a second member of BigBeans must approve it too.

@madebyjordan approval of `659c6bd` recorded. This diff touches sensitive paths, so a second member of `BigBeans` must approve it too.
Member

Beanstalk test farm

Commit ab11ff6 · tier untrusted · approved by madebyjordan · dashboard

This diff touches sensitive paths, so it needs two members of BigBeans: nx2/prompt_assets.py, nx2/prompt_faces.py, nx2/prompt_faces/README.md, nx2/prompt_faces/ps4/ControllerGuide_Pro_02.png, nx2/prompt_faces/ps4/ControllerGuide_Pro_03.png, nx2/prompt_faces/ps4/ControllerGuide_Pro_04.png, nx2/prompt_faces/ps4/Controller_Pro.png, nx2/prompt_faces/ps5/ControllerGuide_Pro_02.png, nx2/prompt_faces/ps5/ControllerGuide_Pro_03.png, nx2/prompt_faces/ps5/ControllerGuide_Pro_04.png

A member of BigBeans can review this commit and comment @Beanstalk to test it.

<!-- beanstalk:sticky --> ### Beanstalk test farm Commit `ab11ff6` · tier **untrusted** · approved by madebyjordan · [dashboard](https://beanstalk.magicbean.dev/prs/1589) This diff touches sensitive paths, so it needs two members of `BigBeans`: `nx2/prompt_assets.py`, `nx2/prompt_faces.py`, `nx2/prompt_faces/README.md`, `nx2/prompt_faces/ps4/ControllerGuide_Pro_02.png`, `nx2/prompt_faces/ps4/ControllerGuide_Pro_03.png`, `nx2/prompt_faces/ps4/ControllerGuide_Pro_04.png`, `nx2/prompt_faces/ps4/Controller_Pro.png`, `nx2/prompt_faces/ps5/ControllerGuide_Pro_02.png`, `nx2/prompt_faces/ps5/ControllerGuide_Pro_03.png`, `nx2/prompt_faces/ps5/ControllerGuide_Pro_04.png` A member of `BigBeans` can review this commit and comment `@Beanstalk` to test it.
madebyjordan changed title from WIP: feat(prompts): a hand-drawn DualSense for the PlayStation faces' System page, and the game's own tint to feat(prompts): a hand-drawn DualSense for the PlayStation faces' System page, and the game's own tint 2026-11-18 14:46:55 +00:00
madebyjordan force-pushed feat/dualsense-picture from 659c6bdf24
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 8s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 11s
CI / Workflow lint (actionlint) (pull_request) Successful in 12s
Third-party parts / As their notes say (pull_request) Successful in 12s
Website / Website on Cloudflare (pull_request_target) Has been skipped
beanstalk/approval needs a second approval (sensitive paths)
PR description / Description follows the template (pull_request_target) Successful in 6s
to ab11ff6341
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 7s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 11s
CI / Workflow lint (actionlint) (pull_request) Successful in 11s
Third-party parts / As their notes say (pull_request) Successful in 12s
PR description / Description follows the template (pull_request_target) Successful in 4s
beanstalk/approval needs a second approval (sensitive paths)
Website / Website on Cloudflare (pull_request_target) Has been skipped
2026-11-18 16:37:52 +00:00
Compare
madebyjordan changed title from feat(prompts): a hand-drawn DualSense for the PlayStation faces' System page, and the game's own tint to feat(prompts): hand-drawn DualSense and Xbox pictures for the System page, and the game's own tint 2026-11-18 16:40:36 +00:00
Author
Member

Added Jordan's hand-drawn Xbox One pad for the Xbox face (5356cff4, with its tested file in ab11ff63), and rebased onto main 876dc360 (no prompt file changed there). Tested in game: Windows 11 Home 26200, RX 6700 XT, AMD 26.10.1, the System page with Button prompts on Xbox. Every line ends on its control (LT, LB, View, the left stick, the d-pad's frame, RT, RB, Menu, the face buttons, the right stick) and none crosses another. Main put LT and LB on one point and RT's dot in the air. Log: prompts: xbox textures, 2652 runs (main 2201). No crash. The PlayStation and Steam Deck prompts are byte-identical to 659c6bdf's. Screenshots are in the description.

🤖 Generated with Claude Code

Added Jordan's hand-drawn Xbox One pad for the Xbox face (5356cff4, with its tested file in ab11ff63), and rebased onto main 876dc360 (no prompt file changed there). Tested in game: Windows 11 Home 26200, RX 6700 XT, AMD 26.10.1, the System page with Button prompts on Xbox. Every line ends on its control (LT, LB, View, the left stick, the d-pad's frame, RT, RB, Menu, the face buttons, the right stick) and none crosses another. Main put LT and LB on one point and RT's dot in the air. Log: `prompts: xbox textures, 2652 runs` (main 2201). No crash. The PlayStation and Steam Deck prompts are byte-identical to 659c6bdf's. Screenshots are in the description. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Author
Member

@Beanstalk linux, any GPU: build this PR, set Button prompts to PlayStation 5, load a save and open the pause menu's System page (PLUS, then ZR to System), then the same with Button prompts on Xbox. Expect the drawn DualSense, then the drawn Xbox One pad, with every label's line ending on its control, and the log lines prompts: ps5 textures, 2488 runs and prompts: xbox textures, 2652 runs.

@Beanstalk linux, any GPU: build this PR, set Button prompts to PlayStation 5, load a save and open the pause menu's System page (PLUS, then ZR to System), then the same with Button prompts on Xbox. Expect the drawn DualSense, then the drawn Xbox One pad, with every label's line ending on its control, and the log lines `prompts: ps5 textures, 2488 runs` and `prompts: xbox textures, 2652 runs`.
Member

@madebyjordan approval of ab11ff6 recorded. This diff touches sensitive paths, so a second member of BigBeans must approve it too.

@madebyjordan approval of `ab11ff6` recorded. This diff touches sensitive paths, so a second member of `BigBeans` must approve it too.
HumanBean deleted branch feat/dualsense-picture 2026-11-18 17:02:18 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1589
No description provided.