feat(vk): a Present queue row on the Debug tab, for the presents' own GPU queue #1554
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1554
Loading…
Reference in a new issue
No description provided.
Delete branch "pmwork-personal/Longshot:feat/present-queue-debug-row"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: feat · Risk: low · Tested on: Windows 11, RTX 5090 (NVIDIA 621.24) · Needs: the tester's RTX 5080, to trace the present queue's lost GPU with the row
TL;DR
Since #1549 the presents' own GPU queue is off by default, and only a line in
longshot_env.txtturned it on. The Insertmenu's Debug tab now has it as Present queue (Off by default, applied after a restart), so a player can try it and a
tester can switch it while we trace why it loses the GPU on an RTX 5080 with frame generation on.
Breakdown
some cards), and the trace of its lost GPU on an RTX 5080.
RX_VK_PRESENT_QUEUE=1in a file.present_queue=inlongshot_options.ini, read bycreate_deviceat thestart;
RX_VK_PRESENT_QUEUEstill decides over it.suite as on main.
RX_VK_PRESENT_QUEUE=1does on main.Why
#1549 made the presents' compute queue opt-in again after a tester's RTX 5080 lost the GPU with it and frame generation on
(the crashes stopped with
RX_VK_PRESENT_QUEUE=0; #1491 looks the same). Why it does that is not known: other games presenton the graphics queue, and the fault was never placed. Tracing it needs the tester to switch the queue, one setting at a
time, and a menu row is easier for a player than a line in a file. The queue also still helps on an RTX 5090 (V-Sync Off,
fixed multiplier: made frames on the screen under 2 ms after the one before from a third to 0.1%), where a player can keep
it with this row.
See #1549, #1476, #1491.
How to reproduce
Seen on: any PC; main
79d4a143Settings and switches: the Insert menu's Debug tab
Steps: open the Insert menu, go to the Debug tab.
Expected: a row to turn the presents' own queue on.
Actual: none; only
RX_VK_PRESENT_QUEUE=1inlongshot_env.txtturns it on.What changed
The Debug tab gets a Present queue row; the renderer reads it at the start, the switch over it.
gpu/vk/vk_menu.cpp: the row (Off or On,restart, preset-exempt), after Robust buffers; withRX_VK_PRESENT_QUEUEset (the old README's way, in some
longshot_env.txtfiles) the row shows the switch's value, cannot be changed and saysso, as ASTC as RGBA8's row with
RX_VK_ASTC_RGBA8;gpu/vk/vk_menu.h:Options::present_queue, 0.gpu/vk/vk_main.cppcreate_device: withRX_VK_PRESENT_QUEUEunset or empty,present_queue=fromlongshot_options.ini(read at the start, asrobust_buffers=: the menu's options are not loaded yet).gpu/vk/switches.def:RX_VK_PRESENT_QUEUEis aplayerswitch over the row, asRX_VK_ROBUST.README.md(the Debug tab's list, the frame generation note: with the row On and no way to the menu after a lost GPU,RX_VK_PRESENT_QUEUE=0inlongshot_env.txtoverrides it) anddocs/development.md(the switch's row) name the row;the log's
presents on a queue of their ownline names it too.tests/test_present_queue_default.py: the compiled queue choice also gets an options file:present_queue=1takes thecompute family,
0or none leaves it, the switch decides over the row, an empty switch leaves it to the row; and therow's text and its display while the switch holds it. Fails on main: "the Debug tab's Present queue On, the switch
unset: family -1, expected 2".
Measurements
Nothing to measure: the row turns on what
RX_VK_PRESENT_QUEUE=1turns on (measured in #1476), Off is main's default.Flags and settings
One menu row and its ini key are added; one switch changes its kind.
present_queuelongshot_options.inikeycreate_deviceat the startRX_VK_PRESENT_QUEUETesting
Tested:
tests/test_present_queue_default.pypasses here and fails on main (Windows, llvm-mingw clang 23).python -I -B tests/run_all.pyon 567d09f9 (Windows, llvm-mingw): 666 passed, 55 failed, 50 skipped; the same 55 failon main 79d4a143's parent run (none reads a file this PR changes, or each fails there for its own reason, as
test_damage_debug_menu's Frame pacing and Threaded rendering rows and test_switch_table's host switches).
Not testable by hand: the RTX 5080 where the queue loses the GPU.
Not tested: the row in the game: its line on the Debug tab, its save, and a restart with it On giving the log's
presents on a queue of their own.Must be tested:
vk: presents on a queue of their own; Off again, restart: it does not; withRX_VK_PRESENT_QUEUE=0set the row's On is overridden; expectingeach of those (by hand: me, before this is marked ready).
Risks
What could break: nothing that I know of: Off is main's default, and the row only stands in for the switch.
Turning it off: set the row Off (the default), or
RX_VK_PRESENT_QUEUE=0.Compatibility:
longshot_options.inigainspresent_queue=0; an older build ignores it. Saves, caches and the vk ABIas before.
Issues
See #1549, #1476, #1491
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.mainand passing here.🤖 Generated with Claude Code
Assisted-by: Claude Code
Co-Authored-By: Claude Opus 5.5 [email protected]
WIP: feat(vk): a Present queue row on the Debug tab, for the presents' own GPU queueto feat(vk): a Present queue row on the Debug tab, for the presents' own GPU queue