fix(vk): FSR 3.1 frame generation's made frames move again: its HUD-less colour is the presented frame's, sRGB-encoded under the HUD #1538

Merged
HumanBean merged 1 commit from HumanBean/Longshot:fix/fsr-fg-made-frames into main 2026-11-18 03:00:51 +00:00
Owner

Type: fix · Risk: low · Tested on: Linux, RTX 3090 · Needs: AMD (Linux or Windows), Windows NVIDIA

TL;DR

With AMD FSR 3.1 frame generation the FPS counter went up but the game felt no smoother: every "made" frame was an exact copy of the game's own frame, so at 4x each game frame was simply shown four times. The HUD-less picture FSR 3.1 interpolates was in a different colour encoding from the frame on screen, and FSR 3.1 replaces a made pixel with the on-screen one wherever the two differ, which was everywhere. This PR gives FSR 3.1 a HUD-less picture that matches the on-screen frame exactly outside the HUD. Made frames now sit where they should (0.25, 0.50, 0.75 of the way between game frames, measured), checked in headless captures and played on an RTX 3090, where it felt better though a running character's limbs still ghost.

Breakdown

  • Who it helps: anyone using Frame generation with FSR 3.1 making the frames (any AMD or Intel GPU, or RX_VK_FSR_FG=1 on NVIDIA).
  • What was wrong: the picture FSR 3.1 interpolates (copied before the HUD) is in linear light, the frame on screen is sRGB-encoded, and FSR 3.1's HUD-less mode lays the on-screen frame over every made pixel that differs from it.
  • What changes: the HUD-less picture is the on-screen frame's own pixel wherever no HUD was drawn, and the copy, sRGB-encoded, only under the HUD; HUD pixels are laid over the made frame whole.
  • What does not change: DLSS Frame Gen, the built-in interpolator, the pacing, and FSR 3.1 when no HUD copy is made (menus, movies); no setting or default changes.
  • How it was checked: headless captures at the reporter's settings (made frames at 0.248 / 0.500 / 0.750 where 0.25 / 0.5 / 0.75 were asked, against copies of the game frame on main), a game-free check written to fail on main (CI runs it), and the person I work for played it on this PC: better, not completely fixed.
  • What is still open: fast-swinging limbs (a running Link's legs and arms) still ghost in the made frames; not this bug, see Testing. AMD and Windows runs.
  • Risk: low: a shader's choice of pixel and one patched factor in FSR 3.1's last pass, only while FSR 3.1 makes frames with the HUD copy.

Why

A player on Linux (RTX 3090, 240 Hz, RX_VK_FSR_FG=1, Frame generation 4x, Upscaler Off) saw the counter at ~170 fps but motion no smoother than with frame generation off. The log said FSR 3.1 made 594 of 600 sets and presents were evenly spaced, so the made frames' content was the suspect. Headless shots of the made frames showed them identical to the game frame that ends their set, to the bit. This started with #1487 (FSR 3.1's HUD-less mode, which fixed the HUD smear of #1310); #1487's own test shots show the same (made frame against its game frame: mean difference 0.015 of 255).

See #1487, #1310; the limbs still ghosting: #1236.

How to reproduce

Seen on: Linux (CachyOS, sway), RTX 3090, NVIDIA 620.70.06
Settings and switches: Frame generation 4x, Frame generation by DLSS FG (RX_VK_FSR_FG=1 makes FSR 3.1 make them on NVIDIA; any setting where FSR 3.1 makes them), Upscaler Off, V-Sync Off
Steps: turn the camera in Kokiri Forest. To see it in numbers: RX_VK_SHOTS=<dir> RX_VK_SHOT_GO=<file> RX_VK_SHOT_MADE=all and touch the file while turning; compare each vk_N_madeK.png with vk_N.png.
Expected: made frames between the game frames, the motion smoother than Off.
Actual: each made frame is the game frame vk_N.png itself, bit for bit; the motion steps at the game's rate.

What changed

FSR 3.1's HUD-less source now matches the presented frame exactly wherever nothing was drawn over the picture, so FSR 3.1 keeps its interpolation there and lays only the HUD (and effects drawn after the upscale) over it.

  • shader: gpu/vk/shaders/fg_hud.comp hudless_colour(): the presented frame's pixel where the picture before and after the HUD are the same; under the HUD the copy sRGB-encoded (srgb(); the native HDR picture as it is), clamped as the RGBA8 frame is. Linear there, it left a dark ring around the button prompts' see-through parts and the fairies' glow. fg_hud_comp_spv.h regenerated, its first line naming the shader's hash.
  • gpu/vk/vk_framegen.cpp hud_source(): tells the pass whether the picture is the native HDR one (push constants 16 → 20 bytes).
  • scripts/fsr3_shaders.py FI_PATCHES 4, fsr3_fi_inpainting_comp_spv.h regenerated: AMD's overlay factor (which grows with the difference, for a HUD-less colour only near the frame's) is 1 where they differ, since any difference is now the HUD: its fraction cut soft edges and glows off.
  • diagnostics: RX_VK_SHOT_MADE=all shoots each of a set's made frames in turn as vk_N_madeK.png (framegen_made_image, vk_replay.cpp; =1 and its vk_N_made.png as before).
  • test: tests/test_fsr3fi_hudless_colour.py compiles hudless_colour as C++: no HUD gives the presented pixel bit for bit (main's gave the linear copy), the HUD gives the sRGB-encoded copy; checks the header is glslang's output for the shader and that hud_source passes the HDR flag.

Measurements

Verdict: fixed: made frames land where they are asked to (within 0.003 of 0.25, 0.50 and 0.75), against copies of the game frame on main; spacing and FSR 3.1's frame count are as before.

Hardware: Linux 7.3 (CachyOS), RTX 3090, NVIDIA 620.70.06
Scene: Kokiri Forest (pristine save), camera turn and Link running; 3840x2160 headless, output 2560x1440, Upscaler Off, Frame generation 4x by FSR 3.1 (RX_VK_FSR_FG=1), V-Sync Off
Method: shots of every present while turning or running (RX_VK_SHOT_MADE=all); for each made frame, phase correlation over 256-px blocks of the picture gives its shift from the game frame before against the shift between the two game frames: t = projection, the median over blocks. Before: one capture (the made frame of the window); after: three captures, all made frames of each.
How to reproduce: the shots as in How to reproduce; the per-block comparison is a short numpy script (phase correlation of each block of the made frame and of the game frame against the game frame before).

Baseline: measured on main @ 310e7c9 and this change on it; rebased since onto main @ 4b68c42, which adds #1496 (V-Sync On only) and nothing on this path, so the numbers hold.

Made frame asked at Before: main @ 310e7c9 (+ RX_VK_SHOT_MADE=all) After: this PR @ 603db934 (b731339a: the same shader and passes, plus the check update)
t = 0.25 (not in the before capture) 0.248, 0.248
t = 0.50 1.000 (25 of 25 blocks; the frame equals the game frame, mean difference 0.0 of 255) 0.500, 0.500, 0.502
t = 0.75 (copy, as all made frames: 0.0 difference) 0.753, 0.750, 0.750

The play session on this PC with the fix (4x, V-Sync Off, the person I work for playing):

vk: fsr3fi: of the last 600 presents 599 made by FSR 3.1, 0 without its inputs (the renderer's own made them); 600 frames with the chain's motion (the skinned draws' own); inputs this frame's 0, the frame before's 600; 600 with the HUD marked
vk: frame interpolation: 1083 frames shown on time, 1 late (over 2 ms); shown apart: <2 ms 1, 2-7 1080, 7-9 3, 9-12 0, 12-17 0, 17-25 0, over 25 0; the game's frames presented 24.9 ms after the game handed them over

Before (left: game frame · middle: made frame at t = 0.5 · right: next game frame), main @ 310e7c9: the made frame is the right-hand frame

Before: main @ 310e7c9

After, this PR @ 603db934 (made frame at t = 0.75): the scene moves, the HUD and prompts stay sharp with no ring

After: this PR @ 603db934

Flags and settings

One diagnostic value added to an existing switch; no setting or default changes.

Flag What it is Before this PR After this PR Effect Helps / doesn't help / untested Recommendation
RX_VK_SHOT_MADE diagnostic shots of made frames =1: the set's first made frame =1 the same; =all: each made frame in turn, vk_N_madeK.png none unless set helps: shows every made frame of a set off: only for testing

Testing

Tested: on this PC (Linux, RTX 3090, NVIDIA 620.70.06, 240 Hz, sway): the person I work for played it at the reporter's settings (4x, FSR 3.1 by RX_VK_FSR_FG=1, Upscaler Off, V-Sync Off) and found it better than before, but not completely fixed: characters' limbs still show artifacts while running (below, still open). Headless captures turning the camera and running (Kokiri Forest) as in Measurements; HUD prompts and fairies looked at in made frames: no ring. The in-game run was this change before the last tidy-up (the shader's rule moved into hudless_colour(), the same per-pixel result) on base 310e7c9; rebased since on main @ 4b68c42 (no conflict; #1496 in between is V-Sync On's).

Not tested: the check suite (tests/run_all.py): not run on this PC, at the request of the person I work for; CI runs it. Native HDR (the pq path): not run. AMD and Intel GPUs, Windows.

Must be tested:

  • Linux, AMD (Test Farm: @Beanstalk linux amd: FSR 3.1 frame generation 3x, Kokiri Forest, turn the camera; made frames between the game frames, the HUD prompts with no dark ring), expecting smoother motion than main and no HUD smear (#1310).
  • Windows, NVIDIA with RX_VK_FSR_FG=1 or AMD: the same, by the Test Farm (windows).

Still open, not this bug: a running Link's swinging legs and arms ghost in the made frames (his motion vectors check out on his body; the ghosting is where limbs cross between game frames). That is #1236, a follow-up.

Still open: limbs ghosting while running (game, made at 0.75, game), this PR @ 603db934

Risks

What could break: FSR 3.1 frame generation's made frames where a HUD copy is made: a game picture that is not linear light (another upscale path) would get a slightly wrong colour under the HUD only; outside the HUD the presented pixel is used as it is.

Turning it off: revert the commit; RX_VK_FSR_FG_HUDLESS=0 gives FSR 3.1 the HUD-marked frame instead, as before #1487.

Compatibility: Nothing changes: no saves, options or caches; two shader headers rebuilt in the renderer.

Issues

See #1236

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named). (Not run on this PC at the request of the person I work for; waiting for CI.)
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen.
  • The SPIR-V headers regenerated with glslang (a shader changed).
  • A game-free test added for the fix, failing on main and passing here. (Added; not run on this PC at the request of the person I work for: waiting for CI.)
  • Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value. (RX_VK_SHOT_MADE=all: its row in gpu/vk/switches.def; a diagnostic, off unless set.)
  • A check under tests/ that reads changed source updated in this PR, not weakened. (test_fsr3fi_hud_mask.py: hud_source's new HDR argument and 20-byte push constants, and a new case that the native HDR picture's flag reaches the pass.)
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (Built and run on Linux; Windows: waiting for CI's build.)
  • Docs updated.

🤖 Generated with Claude Code

**Type:** fix · **Risk:** low · **Tested on:** Linux, RTX 3090 · **Needs:** AMD (Linux or Windows), Windows NVIDIA ## TL;DR With AMD FSR 3.1 frame generation the FPS counter went up but the game felt no smoother: every "made" frame was an exact copy of the game's own frame, so at 4x each game frame was simply shown four times. The HUD-less picture FSR 3.1 interpolates was in a different colour encoding from the frame on screen, and FSR 3.1 replaces a made pixel with the on-screen one wherever the two differ, which was everywhere. This PR gives FSR 3.1 a HUD-less picture that matches the on-screen frame exactly outside the HUD. Made frames now sit where they should (0.25, 0.50, 0.75 of the way between game frames, measured), checked in headless captures and played on an RTX 3090, where it felt better though a running character's limbs still ghost. ## Breakdown - **Who it helps:** anyone using Frame generation with FSR 3.1 making the frames (any AMD or Intel GPU, or `RX_VK_FSR_FG=1` on NVIDIA). - **What was wrong:** the picture FSR 3.1 interpolates (copied before the HUD) is in linear light, the frame on screen is sRGB-encoded, and FSR 3.1's HUD-less mode lays the on-screen frame over every made pixel that differs from it. - **What changes:** the HUD-less picture is the on-screen frame's own pixel wherever no HUD was drawn, and the copy, sRGB-encoded, only under the HUD; HUD pixels are laid over the made frame whole. - **What does not change:** DLSS Frame Gen, the built-in interpolator, the pacing, and FSR 3.1 when no HUD copy is made (menus, movies); no setting or default changes. - **How it was checked:** headless captures at the reporter's settings (made frames at 0.248 / 0.500 / 0.750 where 0.25 / 0.5 / 0.75 were asked, against copies of the game frame on main), a game-free check written to fail on main (CI runs it), and the person I work for played it on this PC: better, not completely fixed. - **What is still open:** fast-swinging limbs (a running Link's legs and arms) still ghost in the made frames; not this bug, see Testing. AMD and Windows runs. - **Risk:** low: a shader's choice of pixel and one patched factor in FSR 3.1's last pass, only while FSR 3.1 makes frames with the HUD copy. ## Why A player on Linux (RTX 3090, 240 Hz, `RX_VK_FSR_FG=1`, Frame generation 4x, Upscaler Off) saw the counter at ~170 fps but motion no smoother than with frame generation off. The log said FSR 3.1 made 594 of 600 sets and presents were evenly spaced, so the made frames' content was the suspect. Headless shots of the made frames showed them identical to the game frame that ends their set, to the bit. This started with #1487 (FSR 3.1's HUD-less mode, which fixed the HUD smear of #1310); #1487's own test shots show the same (made frame against its game frame: mean difference 0.015 of 255). See #1487, #1310; the limbs still ghosting: #1236. ## How to reproduce **Seen on:** Linux (CachyOS, sway), RTX 3090, NVIDIA 620.70.06 **Settings and switches:** Frame generation 4x, Frame generation by DLSS FG (`RX_VK_FSR_FG=1` makes FSR 3.1 make them on NVIDIA; any setting where FSR 3.1 makes them), Upscaler Off, V-Sync Off **Steps:** turn the camera in Kokiri Forest. To see it in numbers: `RX_VK_SHOTS=<dir> RX_VK_SHOT_GO=<file> RX_VK_SHOT_MADE=all` and touch the file while turning; compare each `vk_N_madeK.png` with `vk_N.png`. **Expected:** made frames between the game frames, the motion smoother than Off. **Actual:** each made frame is the game frame `vk_N.png` itself, bit for bit; the motion steps at the game's rate. ## What changed FSR 3.1's HUD-less source now matches the presented frame exactly wherever nothing was drawn over the picture, so FSR 3.1 keeps its interpolation there and lays only the HUD (and effects drawn after the upscale) over it. - shader: `gpu/vk/shaders/fg_hud.comp` `hudless_colour()`: the presented frame's pixel where the picture before and after the HUD are the same; under the HUD the copy sRGB-encoded (`srgb()`; the native HDR picture as it is), clamped as the RGBA8 frame is. Linear there, it left a dark ring around the button prompts' see-through parts and the fairies' glow. `fg_hud_comp_spv.h` regenerated, its first line naming the shader's hash. - `gpu/vk/vk_framegen.cpp` `hud_source()`: tells the pass whether the picture is the native HDR one (push constants 16 → 20 bytes). - `scripts/fsr3_shaders.py` FI_PATCHES 4, `fsr3_fi_inpainting_comp_spv.h` regenerated: AMD's overlay factor (which grows with the difference, for a HUD-less colour only near the frame's) is 1 where they differ, since any difference is now the HUD: its fraction cut soft edges and glows off. - diagnostics: `RX_VK_SHOT_MADE=all` shoots each of a set's made frames in turn as `vk_N_madeK.png` (`framegen_made_image`, `vk_replay.cpp`; `=1` and its `vk_N_made.png` as before). - test: `tests/test_fsr3fi_hudless_colour.py` compiles `hudless_colour` as C++: no HUD gives the presented pixel bit for bit (main's gave the linear copy), the HUD gives the sRGB-encoded copy; checks the header is glslang's output for the shader and that `hud_source` passes the HDR flag. ## Measurements **Verdict:** fixed: made frames land where they are asked to (within 0.003 of 0.25, 0.50 and 0.75), against copies of the game frame on main; spacing and FSR 3.1's frame count are as before. Hardware: Linux 7.3 (CachyOS), RTX 3090, NVIDIA 620.70.06 Scene: Kokiri Forest (pristine save), camera turn and Link running; 3840x2160 headless, output 2560x1440, Upscaler Off, Frame generation 4x by FSR 3.1 (`RX_VK_FSR_FG=1`), V-Sync Off Method: shots of every present while turning or running (`RX_VK_SHOT_MADE=all`); for each made frame, phase correlation over 256-px blocks of the picture gives its shift from the game frame before against the shift between the two game frames: t = projection, the median over blocks. Before: one capture (the made frame of the window); after: three captures, all made frames of each. How to reproduce: the shots as in How to reproduce; the per-block comparison is a short numpy script (phase correlation of each block of the made frame and of the game frame against the game frame before). Baseline: measured on main @ 310e7c9 and this change on it; rebased since onto main @ 4b68c42, which adds #1496 (V-Sync On only) and nothing on this path, so the numbers hold. | Made frame asked at | Before: main @ 310e7c9 (+ `RX_VK_SHOT_MADE=all`) | After: this PR @ 603db934 (b731339a: the same shader and passes, plus the check update) | |---|---|---| | t = 0.25 | (not in the before capture) | 0.248, 0.248 | | t = 0.50 | **1.000** (25 of 25 blocks; the frame equals the game frame, mean difference 0.0 of 255) | 0.500, 0.500, 0.502 | | t = 0.75 | (copy, as all made frames: 0.0 difference) | 0.753, 0.750, 0.750 | The play session on this PC with the fix (4x, V-Sync Off, the person I work for playing): ``` vk: fsr3fi: of the last 600 presents 599 made by FSR 3.1, 0 without its inputs (the renderer's own made them); 600 frames with the chain's motion (the skinned draws' own); inputs this frame's 0, the frame before's 600; 600 with the HUD marked vk: frame interpolation: 1083 frames shown on time, 1 late (over 2 ms); shown apart: <2 ms 1, 2-7 1080, 7-9 3, 9-12 0, 12-17 0, 17-25 0, over 25 0; the game's frames presented 24.9 ms after the game handed them over ``` Before (left: game frame · middle: made frame at t = 0.5 · right: next game frame), main @ 310e7c9: the made frame is the right-hand frame ![Before: main @ 310e7c9](https://git.magicbean.dev/attachments/263ca471-f957-4858-8043-fbce93b89893) After, this PR @ 603db934 (made frame at t = 0.75): the scene moves, the HUD and prompts stay sharp with no ring ![After: this PR @ 603db934](https://git.magicbean.dev/attachments/1fdb4f24-63b0-4160-a2b8-6d72be00f1cf) ### Flags and settings One diagnostic value added to an existing switch; no setting or default changes. | Flag | What it is | Before this PR | After this PR | Effect | Helps / doesn't help / untested | Recommendation | |---|---|---|---|---|---|---| | `RX_VK_SHOT_MADE` | diagnostic shots of made frames | `=1`: the set's first made frame | `=1` the same; `=all`: each made frame in turn, `vk_N_madeK.png` | none unless set | helps: shows every made frame of a set | off: only for testing | ## Testing **Tested:** on this PC (Linux, RTX 3090, NVIDIA 620.70.06, 240 Hz, sway): the person I work for played it at the reporter's settings (4x, FSR 3.1 by `RX_VK_FSR_FG=1`, Upscaler Off, V-Sync Off) and found it better than before, but not completely fixed: characters' limbs still show artifacts while running (below, still open). Headless captures turning the camera and running (Kokiri Forest) as in Measurements; HUD prompts and fairies looked at in made frames: no ring. The in-game run was this change before the last tidy-up (the shader's rule moved into `hudless_colour()`, the same per-pixel result) on base 310e7c9; rebased since on main @ 4b68c42 (no conflict; #1496 in between is V-Sync On's). **Not tested:** the check suite (`tests/run_all.py`): not run on this PC, at the request of the person I work for; CI runs it. Native HDR (the `pq` path): not run. AMD and Intel GPUs, Windows. **Must be tested:** - Linux, AMD (Test Farm: `@Beanstalk linux amd: FSR 3.1 frame generation 3x, Kokiri Forest, turn the camera; made frames between the game frames, the HUD prompts with no dark ring`), expecting smoother motion than main and no HUD smear (#1310). - Windows, NVIDIA with `RX_VK_FSR_FG=1` or AMD: the same, by the Test Farm (`windows`). Still open, not this bug: a running Link's swinging legs and arms ghost in the made frames (his motion vectors check out on his body; the ghosting is where limbs cross between game frames). That is #1236, a follow-up. ![Still open: limbs ghosting while running (game, made at 0.75, game), this PR @ 603db934](https://git.magicbean.dev/attachments/1ab23dfa-9595-4fff-8e88-75bb98e9bc6e) ## Risks **What could break:** FSR 3.1 frame generation's made frames where a HUD copy is made: a game picture that is not linear light (another upscale path) would get a slightly wrong colour under the HUD only; outside the HUD the presented pixel is used as it is. **Turning it off:** revert the commit; `RX_VK_FSR_FG_HUDLESS=0` gives FSR 3.1 the HUD-marked frame instead, as before #1487. **Compatibility:** Nothing changes: no saves, options or caches; two shader headers rebuilt in the renderer. ## Issues See #1236 ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [ ] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). (Not run on this PC at the request of the person I work for; waiting for CI.) - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen. - [x] The SPIR-V headers regenerated with glslang (a shader changed). - [ ] A game-free test added for the fix, failing on `main` and passing here. (Added; not run on this PC at the request of the person I work for: waiting for CI.) - [x] Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value. (`RX_VK_SHOT_MADE=all`: its row in gpu/vk/switches.def; a diagnostic, off unless set.) - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. (`test_fsr3fi_hud_mask.py`: `hud_source`'s new HDR argument and 20-byte push constants, and a new case that the native HDR picture's flag reaches the pass.) - [ ] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (Built and run on Linux; Windows: waiting for CI's build.) - [x] Docs updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(vk): FSR 3.1 frame generation's made frames move again: its HUD-less colour is the presented frame's, sRGB-encoded under the HUD
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 7s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 9s
CI / Workflow lint (actionlint) (pull_request) Successful in 11s
Third-party parts / As their notes say (pull_request) Successful in 10s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
603db934f2
Since #1487, FSR 3.1 interpolated the picture copied after the game's upscale and laid the presented frame over its made
one wherever the two differed at all (AMD's HUD-less mode). The copy is in linear light (B10G11R11) and the frame is
presented sRGB-encoded (RGBA8, the sRGB curve to under 1 level), so they differed everywhere and every made frame came out
as the game's frame itself: at 4x each game frame was shown four times, the counter at 170 and the motion at the game's
42 fps (RTX 3090, Upscaler Off; headless shots: made frames equal to their game frame to the bit, a turn's blocks all at
t = 1.00 where 0.5 and 0.75 were asked; now 0.500 and 0.753).

- shaders/fg_hud.comp: the HUD-less colour is the presented frame's pixel where nothing was drawn over the picture, and
  the copy sRGB-encoded (the native HDR picture as it is) only there: linear, it left dark rings around the HUD's
  see-through parts and the fairy's glow.
- FI_PATCHES 4: AMD's overlay takes the presented pixel whole where the two differ (any difference is now the HUD or an
  effect drawn after the upscale): its partial factor cut off soft edges and glows.
- RX_VK_SHOT_MADE=all shoots each of a set's made frames in turn (vk_N_madeK.png).

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Owner

Tested in game: RTX 3090, NVIDIA 620.70.06, Linux (CachyOS, sway, 240 Hz): Kokiri Forest, Frame generation 4x by FSR 3.1 (RX_VK_FSR_FG=1), Upscaler Off, V-Sync Off. Played by the person I work for: better than before (made frames now move: headless shots place them at 0.248/0.500/0.750 where main's were copies of the game frame), FSR 3.1 made 599/600 sets, 99% of frames shown 2-7 ms apart; HUD prompts and fairies without the dark ring. Not completely fixed: a running Link's limbs still ghost (#1236).

Tested in game: RTX 3090, NVIDIA 620.70.06, Linux (CachyOS, sway, 240 Hz): Kokiri Forest, Frame generation 4x by FSR 3.1 (RX_VK_FSR_FG=1), Upscaler Off, V-Sync Off. Played by the person I work for: better than before (made frames now move: headless shots place them at 0.248/0.500/0.750 where main's were copies of the game frame), FSR 3.1 made 599/600 sets, 99% of frames shown 2-7 ms apart; HUD prompts and fairies without the dark ring. Not completely fixed: a running Link's limbs still ghost (#1236).
HumanBean force-pushed fix/fsr-fg-made-frames from 603db934f2
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 7s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 9s
CI / Workflow lint (actionlint) (pull_request) Successful in 11s
Third-party parts / As their notes say (pull_request) Successful in 10s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
to b731339a4b
Some checks failed
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 6s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 10s
CI / Workflow lint (actionlint) (pull_request) Successful in 11s
Third-party parts / As their notes say (pull_request) Successful in 11s
PR description / Description follows the template (pull_request_target) Failing after 5s
2026-11-18 02:44:48 +00:00
Compare
Author
Owner

Pushed b731339a: tests/test_fsr3fi_hud_mask.py follows hud_source's new native-HDR argument (20-byte push constants) and gains a case that the flag reaches the HUD pass. Description: the measurement's baseline after the rebase, and the checklist's applicable boxes. Not run on this PC at the request of the person I work for: waiting for CI.

Pushed b731339a: `tests/test_fsr3fi_hud_mask.py` follows `hud_source`'s new native-HDR argument (20-byte push constants) and gains a case that the flag reaches the HUD pass. Description: the measurement's baseline after the rebase, and the checklist's applicable boxes. Not run on this PC at the request of the person I work for: waiting for CI.
HumanBean changed title from WIP: fix(vk): FSR 3.1 frame generation's made frames move again: its HUD-less colour is the presented frame's, sRGB-encoded under the HUD to fix(vk): FSR 3.1 frame generation's made frames move again: its HUD-less colour is the presented frame's, sRGB-encoded under the HUD 2026-11-18 03:00:45 +00:00
HumanBean deleted branch fix/fsr-fg-made-frames 2026-11-18 03:00:51 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1538
No description provided.