fix(fps): the Shadow Temple's barge carries Link and the enemies above 100 fps #1528

Merged
llun merged 2 commits from CraftyCorvid/Longshot:fix/floor-carry-above-60 into main 2026-11-18 04:52:39 +00:00
Contributor

Type: fix · Risk: low · Tested on: Linux, RTX 5090 · Needs: none

TL;DR

Above 100 FPS, Link and the Stalfos standing on the Shadow Temple's barge slid to its back as it moved. The game carries a
character standing on a moving floor by the floor's velocity, but on a frame under 10 ms it keeps only a tenth of it (a
guard for slowed time at 60 FPS), and above 100 FPS every frame is under 10 ms. Now that test is the one the game would make
at 60 FPS. At 140 FPS neither Link nor the Stalfos slide; a new test fails on main and passes here.

Breakdown

  • Who it helps: anyone who rides the Shadow Temple's barge (or any moving floor) with the frame rate cap above 60.
  • What was wrong: three character update modules scale a floor's velocity by 0.1 when the physics' 1/dt is over 100,
    which at 60 FPS means slowed time, but above 100 FPS is every frame.
  • What changes: above a 60 cap, the test is 1/dt times the frame's step over 100, the game's test as at 60 FPS.
  • What does not change: a cap of 60, frames of a 60 FPS one or longer, slowed time below 0.6, saves and options.
  • How it was checked: a game-free test (a tenth on main at 101 to 1000 FPS, the whole velocity here) and the barge ridden
    at 140 FPS, where the game's test held 13,800 times and the whole velocity carried every time.
  • What is still open: Windows in the game, and other moving floors (same code, not ridden).
  • Risk: low: only the carry of a character on a moving floor above 100 FPS changes.

Why

On the Shadow Temple's barge, with the Game frame rate cap above 60 and the game running above 100 FPS, Link and the
enemies that spawn on it (Stalfos) slide to its back as it moves; at 60 they stand still on it. Fixes #439.

The findings on #439 (#439 (comment)) put it in Havok's
contact coupling; it turned out to be the game's own carry code, before the physics step.

How to reproduce

Seen on: CachyOS Linux (kernel 7.3), RTX 5090, NVIDIA 620.70.06
Settings and switches: Game frame rate cap Uncapped (about 140 FPS there), everything else default
Steps: in the Shadow Temple, stand on the barge's Triforce mark, play Zelda's Lullaby, and stand still as it moves
Expected: Link (and the Stalfos that drop on it) move with the barge, as at a cap of 60
Actual: they keep about a tenth of its velocity and slide to its back rail

What changed

A character standing on a moving floor is carried by the floor's velocity, which one of three update modules adds to the
character's (f_80159dc0, the one that runs for Link; f_8015d490; f_838baa40). Each first compares the physics time
object's 1/dt ([[[0x84c9df00]]+0xc0]+0x28) with 100.0 and, above it, multiplies the floor's velocity by 0.1 (the float at
0x83e60fb4). At 60 FPS 1/dt is 60, so this only fires when the physics' time is slowed below 0.6 of real time. Above
100 FPS it fires on every frame. The branch to the tenth now also asks the host: above a 60 cap, 1/dt times the frame's
step (the game's time object's, [[0x84c9e890]]+0x10, 0.5 at 120 FPS) over 100. That is the game's test as it would be at
60 FPS, so slowed time still takes the tenth. At a cap of 60 the game's verdict stands; on a frame of a 60 FPS one or
longer the product is at least 1/dt, so it is the game's too.

  • lift: nx2/oot_patches.py patch_floor_carry: in each of the three modules, the branch after the 1/dt test (by its label,
    once in its function) gains && hos_oot_floor_carry_slow(...); report warns when fewer than three are found.
  • host: host/oot_high_fps.h oot_floor_carry_slow (the rule, and why at the top of the file); host/oot_high_fps.c
    hos_oot_floor_carry_slow (reads the frame's step as the horse's jump fix does; HOS_FPS_LOG counts the tenths kept).
  • test: tests/test_floor_carry_step.py.
  • docs: the README's frame rate cap row.

How it was found (a local diagnostic build, not in this PR, driven through the control bridge):

  • Each frame it logged Link's and the barge's physics velocities. Link's was exactly the barge's (-3.500 m/s) on frames of
    10 ms or more, and exactly a tenth (-0.3500) on shorter ones, switching frame by frame around 100 FPS whatever he had
    before.
  • A hardware write watchpoint on Link's Havok motion showed the game itself writing the tenth before the step (through
    f_804f5030, from the velocity request the character update f_80150180 makes).
  • A hook after each of the character's modules showed f_80159dc0 turning the floor's velocity into a tenth of it.

Measurements

Verdict: fixed. At 140 FPS neither Link nor the Stalfos slide, and the game's under-10 ms test, which held 13,800 times
in that ride, never kept the tenth; the game-free test fails on main for this bug and passes here.

Hardware: CachyOS Linux (kernel 7.3), RTX 5090, NVIDIA 620.70.06
Scene: the Shadow Temple's barge from a save on it; Game frame rate cap Uncapped (about 140 FPS), 120, 144 and 60
Method: tests/test_floor_carry_step.py (gcc and clang); in the game, a diagnostic build on main's code logging Link's and
the barge's physics velocities each frame, then this branch ridden uncapped with HOS_FPS_LOG=1
How to reproduce: python -I -B tests/test_floor_carry_step.py; in the game, the steps above
Baseline: the in-game before is that diagnostic build (logging, and a cap set from a file; no change to the game) on
main 310e7c9d; the after is this branch's fix at
310e7c9d, both built as dev packs over a base of 71b1edd8. The branch is now rebased onto 4b68c42b, which touches none of
the files this PR changes; the test fails at its commit and passes at the fix there too.

Before: main @ 4b68c42b (with the test, 48e556f3) After: this PR @ d54442c0
test_floor_carry_step.py fails: all three modules carry a tenth at 101, 120, 144, 240 and 1000 FPS, and at 120 FPS with time at 0.7 passes (51 checks); the unpatched updates fail the 120 FPS check
Link on the moving barge, in the game his velocity a tenth of the barge's on every frame under 10 ms (the share switches at 1/dt 100, at any step either side) the barge's on every frame; at 140 FPS Link and the Stalfos stand still on it
Before, test (48e556f3 on main 4b68c42b):
FAIL: 120 fps: module 0 carried 0.1 of the floor's velocity (expected 1.0)
FAIL: 120 fps, time at 0.7: module 0 carried 0.1 of the floor's velocity (expected 1.0)
FAIL: a moving floor's carry above 60 fps (the patch is missing)

After, test (d54442c0):
PASS: a moving floor's carry (51 checks)
PASS: the unpatched updates compile and fail the 120 fps check (a tenth of the floor's velocity)
PASS: scoped, idempotent, and a changed anchor is left alone with a warning

Before, in the game (diagnostic build; dt the physics frame time, next the velocity the game hands the physics, returned its
velocity after the step, dx Link's movement over the frame):
f3106 dt 0.01125 | next -3.5001 -> returned -3.5002 | dx -0.0450 = -3.999 m/s
f3107 dt 0.00998 | next -3.5002 -> returned -0.3501 | dx -0.0390 = -3.907 m/s
f3108 dt 0.00999 | next -0.3501 -> returned -0.3500 | dx -0.0030 = -0.300 m/s
f3111 dt 0.01023 | next -0.3499 -> returned -3.5010 | dx -0.0040 = -0.391 m/s
f3112 dt 0.01003 | next -3.5010 -> returned -3.4997 | dx -0.0360 = -3.589 m/s

After, in the game (this branch, HOS_FPS_LOG=1, uncapped):
oot: a moving floor's carry: the slow-time tenth kept 0 of 13200 times (1/dt 134.4, the frame's step 0.446)
oot: a moving floor's carry: the slow-time tenth kept 0 of 13800 times (1/dt 137.4, the frame's step 0.437)

Flags and settings

None (HOS_FPS_LOG, the existing diagnostic switch, gets one more line).

Testing

Tested:

  • In the game, Linux, RTX 5090, NVIDIA 620.70.06, this branch (at 310e7c9d) built as a dev pack over a base of 71b1edd8:
    the lift reports "a moving floor's carry above 60 fps" in code_001.c and code_050.c, and no warning (all three
    modules found). Riding the barge uncapped at about 140 FPS, Link and the Stalfos that drop on it stood still on it. In a
    driven ride at about 100 FPS (another game held the CPU), Link moved at the barge's 3.5 m/s at caps 60, 120, 144 and
    uncapped. A diagnostic build with the same rule logged 400 frames under 10 ms, the full velocity on 398 of them (on the other
    two the physics' time was under 0.6 of the frame's, so the rule kept the game's tenth).
  • tests/test_floor_carry_step.py with gcc and clang: fails at 48e556f3 (the test alone, on main), passes at d54442c0.
    Broken on purpose it fails: the tenth always kept (120 FPS), never kept above 60 (slowed time), the rule at a cap of 60
    too (a cap of 60 with a time object at 0.5), 1/dt divided by the step, a threshold of 166.7.
  • python -I -B tests/run_all.py (Linux): 630 passed, 37 failed, 102 skipped (Vulkan and SPIR-V headers missing here). The
    37 also fail on main 4b68c42b (run there), for reasons in files this PR doesn't touch (test_dev_packs, which reads the
    patch file, fails the same way on main: "a game patch shows in the objects"): test_bug_report_defaults,
    test_compute_warm_apart, test_cpu_report, test_crt_options, test_damage_debug_menu, test_dev_packs, test_discover,
    test_display_startup_failure, test_dlss_feature_size, test_failed_compile_keeps_objects, test_guest_imported,
    test_hud_layout_row, test_invalidate_quick, test_invalidate_vcore, test_libc_hooks, test_lift_lookups,
    test_linux_preflight, test_linux_pressure, test_linux_update, test_log_open_failure, test_mirror_budget, test_missing_nup,
    test_mods_size_table, test_pending_guest_import, test_pipeline_play_cache, test_present_thread, test_profiling_mode,
    test_psychov35_fsr3_fg, test_readback_timeout_source, test_run_all_changed, test_slow_frames, test_switch_table,
    test_target_image_pool, test_upscaler_rows, test_vcore_escape, test_walk, test_walk_key.
  • host/oot_high_fps.c compiled alone (-fsyntax-only -Wall -Wextra, the build's include folders) with gcc and clang for
    Linux and with llvm-mingw clang (tools.lock's, 20261104) and MinGW gcc for Windows: no warnings, as on main.

Not tested:

  • Windows in the game (no platform-specific code; its host file compiles with llvm-mingw).
  • Other moving floors and platforms (the same three modules carry any character on one); slowed time in the game (the
    game-free test covers it above 60 and at 60).
  • No cold review by a second agent (the person I work for chose to skip it for this PR).

Must be tested: None.

Risks

What could break: how a character standing on a moving floor is carried above a 60 FPS cap, on frames under 10 ms. Slowed
time below 0.6 of real time still takes the game's tenth (the rule assumes the game's time object's step is the frame's own,
as the horse's jump fix does); at a cap of 60 and on frames of a 60 FPS one or longer nothing changes.

Turning it off: revert the commit, or a cap of 60.

Compatibility: Nothing changes for saves, options or caches; an update translates the game's code again, as for any
change to the lift's patches.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A game-free test added for the fix, failing on main and passing here.
  • A check under tests/ that reads changed source updated in this PR, not weakened. (None needed: the checks that
    read host/oot_high_fps.* or nx2/oot_patches.py, test_high_fps_fixes.py, test_horse_jump_step.py and
    test_patch_hooks_defined.py among them, pass unchanged.)
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths.
  • Docs updated.

🤖 Generated with Claude Code

**Type:** fix · **Risk:** low · **Tested on:** Linux, RTX 5090 · **Needs:** none ## TL;DR Above 100 FPS, Link and the Stalfos standing on the Shadow Temple's barge slid to its back as it moved. The game carries a character standing on a moving floor by the floor's velocity, but on a frame under 10 ms it keeps only a tenth of it (a guard for slowed time at 60 FPS), and above 100 FPS every frame is under 10 ms. Now that test is the one the game would make at 60 FPS. At 140 FPS neither Link nor the Stalfos slide; a new test fails on main and passes here. ## Breakdown - **Who it helps:** anyone who rides the Shadow Temple's barge (or any moving floor) with the frame rate cap above 60. - **What was wrong:** three character update modules scale a floor's velocity by 0.1 when the physics' 1/dt is over 100, which at 60 FPS means slowed time, but above 100 FPS is every frame. - **What changes:** above a 60 cap, the test is 1/dt times the frame's step over 100, the game's test as at 60 FPS. - **What does not change:** a cap of 60, frames of a 60 FPS one or longer, slowed time below 0.6, saves and options. - **How it was checked:** a game-free test (a tenth on main at 101 to 1000 FPS, the whole velocity here) and the barge ridden at 140 FPS, where the game's test held 13,800 times and the whole velocity carried every time. - **What is still open:** Windows in the game, and other moving floors (same code, not ridden). - **Risk:** low: only the carry of a character on a moving floor above 100 FPS changes. ## Why On the Shadow Temple's barge, with the Game frame rate cap above 60 and the game running above 100 FPS, Link and the enemies that spawn on it (Stalfos) slide to its back as it moves; at 60 they stand still on it. Fixes #439. The findings on #439 (https://git.magicbean.dev/MagicBeanDev/Longshot/issues/439#issuecomment-44400) put it in Havok's contact coupling; it turned out to be the game's own carry code, before the physics step. ## How to reproduce **Seen on:** CachyOS Linux (kernel 7.3), RTX 5090, NVIDIA 620.70.06 **Settings and switches:** Game frame rate cap Uncapped (about 140 FPS there), everything else default **Steps:** in the Shadow Temple, stand on the barge's Triforce mark, play Zelda's Lullaby, and stand still as it moves **Expected:** Link (and the Stalfos that drop on it) move with the barge, as at a cap of 60 **Actual:** they keep about a tenth of its velocity and slide to its back rail ## What changed A character standing on a moving floor is carried by the floor's velocity, which one of three update modules adds to the character's (`f_80159dc0`, the one that runs for Link; `f_8015d490`; `f_838baa40`). Each first compares the physics time object's 1/dt (`[[[0x84c9df00]]+0xc0]+0x28`) with 100.0 and, above it, multiplies the floor's velocity by 0.1 (the float at `0x83e60fb4`). At 60 FPS 1/dt is 60, so this only fires when the physics' time is slowed below 0.6 of real time. Above 100 FPS it fires on every frame. The branch to the tenth now also asks the host: above a 60 cap, 1/dt times the frame's step (the game's time object's, `[[0x84c9e890]]+0x10`, 0.5 at 120 FPS) over 100. That is the game's test as it would be at 60 FPS, so slowed time still takes the tenth. At a cap of 60 the game's verdict stands; on a frame of a 60 FPS one or longer the product is at least 1/dt, so it is the game's too. - lift: `nx2/oot_patches.py` `patch_floor_carry`: in each of the three modules, the branch after the 1/dt test (by its label, once in its function) gains `&& hos_oot_floor_carry_slow(...)`; `report` warns when fewer than three are found. - host: `host/oot_high_fps.h` `oot_floor_carry_slow` (the rule, and why at the top of the file); `host/oot_high_fps.c` `hos_oot_floor_carry_slow` (reads the frame's step as the horse's jump fix does; `HOS_FPS_LOG` counts the tenths kept). - test: `tests/test_floor_carry_step.py`. - docs: the README's frame rate cap row. How it was found (a local diagnostic build, not in this PR, driven through the control bridge): - Each frame it logged Link's and the barge's physics velocities. Link's was exactly the barge's (-3.500 m/s) on frames of 10 ms or more, and exactly a tenth (-0.3500) on shorter ones, switching frame by frame around 100 FPS whatever he had before. - A hardware write watchpoint on Link's Havok motion showed the game itself writing the tenth before the step (through `f_804f5030`, from the velocity request the character update `f_80150180` makes). - A hook after each of the character's modules showed `f_80159dc0` turning the floor's velocity into a tenth of it. ## Measurements **Verdict:** fixed. At 140 FPS neither Link nor the Stalfos slide, and the game's under-10 ms test, which held 13,800 times in that ride, never kept the tenth; the game-free test fails on `main` for this bug and passes here. Hardware: CachyOS Linux (kernel 7.3), RTX 5090, NVIDIA 620.70.06 Scene: the Shadow Temple's barge from a save on it; Game frame rate cap Uncapped (about 140 FPS), 120, 144 and 60 Method: `tests/test_floor_carry_step.py` (gcc and clang); in the game, a diagnostic build on `main`'s code logging Link's and the barge's physics velocities each frame, then this branch ridden uncapped with `HOS_FPS_LOG=1` How to reproduce: `python -I -B tests/test_floor_carry_step.py`; in the game, the steps above Baseline: the in-game before is that diagnostic build (logging, and a cap set from a file; no change to the game) on `main` 310e7c9d; the after is this branch's fix at 310e7c9d, both built as dev packs over a base of 71b1edd8. The branch is now rebased onto 4b68c42b, which touches none of the files this PR changes; the test fails at its commit and passes at the fix there too. | | Before: main @ 4b68c42b (with the test, 48e556f3) | After: this PR @ d54442c0 | |---|---|---| | `test_floor_carry_step.py` | fails: all three modules carry a tenth at 101, 120, 144, 240 and 1000 FPS, and at 120 FPS with time at 0.7 | passes (51 checks); the unpatched updates fail the 120 FPS check | | Link on the moving barge, in the game | his velocity a tenth of the barge's on every frame under 10 ms (the share switches at 1/dt 100, at any step either side) | the barge's on every frame; at 140 FPS Link and the Stalfos stand still on it | ``` Before, test (48e556f3 on main 4b68c42b): FAIL: 120 fps: module 0 carried 0.1 of the floor's velocity (expected 1.0) FAIL: 120 fps, time at 0.7: module 0 carried 0.1 of the floor's velocity (expected 1.0) FAIL: a moving floor's carry above 60 fps (the patch is missing) After, test (d54442c0): PASS: a moving floor's carry (51 checks) PASS: the unpatched updates compile and fail the 120 fps check (a tenth of the floor's velocity) PASS: scoped, idempotent, and a changed anchor is left alone with a warning Before, in the game (diagnostic build; dt the physics frame time, next the velocity the game hands the physics, returned its velocity after the step, dx Link's movement over the frame): f3106 dt 0.01125 | next -3.5001 -> returned -3.5002 | dx -0.0450 = -3.999 m/s f3107 dt 0.00998 | next -3.5002 -> returned -0.3501 | dx -0.0390 = -3.907 m/s f3108 dt 0.00999 | next -0.3501 -> returned -0.3500 | dx -0.0030 = -0.300 m/s f3111 dt 0.01023 | next -0.3499 -> returned -3.5010 | dx -0.0040 = -0.391 m/s f3112 dt 0.01003 | next -3.5010 -> returned -3.4997 | dx -0.0360 = -3.589 m/s After, in the game (this branch, HOS_FPS_LOG=1, uncapped): oot: a moving floor's carry: the slow-time tenth kept 0 of 13200 times (1/dt 134.4, the frame's step 0.446) oot: a moving floor's carry: the slow-time tenth kept 0 of 13800 times (1/dt 137.4, the frame's step 0.437) ``` ### Flags and settings None (`HOS_FPS_LOG`, the existing diagnostic switch, gets one more line). ## Testing **Tested:** - In the game, Linux, RTX 5090, NVIDIA 620.70.06, this branch (at 310e7c9d) built as a dev pack over a base of 71b1edd8: the lift reports "a moving floor's carry above 60 fps" in `code_001.c` and `code_050.c`, and no warning (all three modules found). Riding the barge uncapped at about 140 FPS, Link and the Stalfos that drop on it stood still on it. In a driven ride at about 100 FPS (another game held the CPU), Link moved at the barge's 3.5 m/s at caps 60, 120, 144 and uncapped. A diagnostic build with the same rule logged 400 frames under 10 ms, the full velocity on 398 of them (on the other two the physics' time was under 0.6 of the frame's, so the rule kept the game's tenth). - `tests/test_floor_carry_step.py` with gcc and clang: fails at 48e556f3 (the test alone, on `main`), passes at d54442c0. Broken on purpose it fails: the tenth always kept (120 FPS), never kept above 60 (slowed time), the rule at a cap of 60 too (a cap of 60 with a time object at 0.5), 1/dt divided by the step, a threshold of 166.7. - `python -I -B tests/run_all.py` (Linux): 630 passed, 37 failed, 102 skipped (Vulkan and SPIR-V headers missing here). The 37 also fail on `main` 4b68c42b (run there), for reasons in files this PR doesn't touch (test_dev_packs, which reads the patch file, fails the same way on `main`: "a game patch shows in the objects"): test_bug_report_defaults, test_compute_warm_apart, test_cpu_report, test_crt_options, test_damage_debug_menu, test_dev_packs, test_discover, test_display_startup_failure, test_dlss_feature_size, test_failed_compile_keeps_objects, test_guest_imported, test_hud_layout_row, test_invalidate_quick, test_invalidate_vcore, test_libc_hooks, test_lift_lookups, test_linux_preflight, test_linux_pressure, test_linux_update, test_log_open_failure, test_mirror_budget, test_missing_nup, test_mods_size_table, test_pending_guest_import, test_pipeline_play_cache, test_present_thread, test_profiling_mode, test_psychov35_fsr3_fg, test_readback_timeout_source, test_run_all_changed, test_slow_frames, test_switch_table, test_target_image_pool, test_upscaler_rows, test_vcore_escape, test_walk, test_walk_key. - `host/oot_high_fps.c` compiled alone (`-fsyntax-only -Wall -Wextra`, the build's include folders) with gcc and clang for Linux and with llvm-mingw clang (tools.lock's, 20261104) and MinGW gcc for Windows: no warnings, as on `main`. **Not tested:** - Windows in the game (no platform-specific code; its host file compiles with llvm-mingw). - Other moving floors and platforms (the same three modules carry any character on one); slowed time in the game (the game-free test covers it above 60 and at 60). - No cold review by a second agent (the person I work for chose to skip it for this PR). **Must be tested:** None. ## Risks **What could break:** how a character standing on a moving floor is carried above a 60 FPS cap, on frames under 10 ms. Slowed time below 0.6 of real time still takes the game's tenth (the rule assumes the game's time object's step is the frame's own, as the horse's jump fix does); at a cap of 60 and on frames of a 60 FPS one or longer nothing changes. **Turning it off:** revert the commit, or a cap of 60. **Compatibility:** Nothing changes for saves, options or caches; an update translates the game's code again, as for any change to the lift's patches. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. (None needed: the checks that read `host/oot_high_fps.*` or `nx2/oot_patches.py`, `test_high_fps_fixes.py`, `test_horse_jump_step.py` and `test_patch_hooks_defined.py` among them, pass unchanged.) - [x] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. - [x] Docs updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Three characters' update modules carry a character standing on a moving floor by the floor's
velocity, but scale it by 0.1 when the physics' 1/dt is over 100. Above 100 fps every frame is
under 10 ms, so Link and the enemies on the Shadow Temple's barge kept a tenth of its velocity. The
check runs authored updates of the three modules through patch_file with the host's function cut
from host/oot_high_fps.c; on main they carry a tenth at 101 to 1000 fps.

Assisted-by: Claude Code (Claude Opus 5.5)
Co-Authored-By: Claude Opus 5.5 <[email protected]>
fix(fps): the Shadow Temple's barge carries Link and the enemies above 100 fps
Some checks are pending
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Conventional Commit title (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
d54442c0c0
A character standing on a moving floor is carried by the floor's velocity, added by one of three
update modules (f_80159dc0, f_8015d490, f_838baa40). Each scales it by 0.1 when the physics time
object's 1/dt is over 100: at 60 fps, time slowed below 0.6 of real time. Above 100 fps every frame
trips it, so Link and the Stalfos on the barge kept a tenth of its velocity and slid to its back.
The branch to the tenth now also asks the host: above a 60 fps cap, 1/dt times the frame's step
(the game's time object's) over 100, the game's test as it would be at 60 fps. At a cap of 60, and on
frames of a 60 fps one or longer, the game's test is unchanged.

Fixes #439

Assisted-by: Claude Code (Claude Opus 5.5)
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Contributor

Tested in game: RTX 5090, NVIDIA 620.70.06, Linux (CachyOS): the Shadow Temple's barge, Game frame rate cap Uncapped (about 140 fps): after Zelda's Lullaby, Link and the Stalfos stood still on the moving barge (on main they slide to its back); HOS_FPS_LOG: the game's under-10 ms test held 13,800 times and the full velocity carried every time. Built as a dev pack over a base of 71b1edd8.

Tested in game: RTX 5090, NVIDIA 620.70.06, Linux (CachyOS): the Shadow Temple's barge, Game frame rate cap Uncapped (about 140 fps): after Zelda's Lullaby, Link and the Stalfos stood still on the moving barge (on main they slide to its back); HOS_FPS_LOG: the game's under-10 ms test held 13,800 times and the full velocity carried every time. Built as a dev pack over a base of 71b1edd8.
CraftyCorvid changed title from WIP: fix(fps): the Shadow Temple's barge carries Link and the enemies above 100 fps to fix(fps): the Shadow Temple's barge carries Link and the enemies above 100 fps 2026-11-18 02:21:59 +00:00
llun approved these changes 2026-11-18 04:52:34 +00:00
llun merged commit 4f7555271b into main 2026-11-18 04:52:39 +00:00
Some checks are pending
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
CI / Conventional Commit title (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
Some workflows are waiting to be reviewed.
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1528
No description provided.