docs(guide): the Graphics guide image is retained after #1309, #1362 and #1464 #1466

Merged
llun merged 1 commit from mooki/Longshot:docs/guide-graphics-retention-1309 into main 2026-11-17 21:19:06 +00:00
Member

Type: docs · Risk: low · Tested on: Linux x86-64, no GPU (the picture is drawn in memory by SDL2's software renderer; the checks need no game) · Needs: any PC with a browser (the site's Settings page), and a maintainer's look at the pictures

TL;DR

The guide-screenshot check is red on main itself, so every pull request inherits the failure: #1309, #1362 and #1464 changed seven source files that the Graphics guide picture is recorded against, and no merge carried a review. I did the review: the Graphics view rendered from main and from the last commit the check passed on differ only in the build's version text (976 of 921,600 pixels). So the picture is kept, and this pull request updates its record (seven hashes, ten headers that were never listed, a dated note), which makes the check pass again. Two questions for maintainers at the end would stop it going red for changes that cannot touch the picture.

Breakdown

  • Who it helps: every author with an open pull request (the failure is not theirs, and each has to explain it), and the guide's readers: the record that says the picture was reviewed is true again.
  • What was wrong: the Graphics picture is recorded against the SHA-256 of 67 source files. #1309 (the switch table, 16:05 UTC) changed two of them, #1362 (18:53 UTC) three, one of them again, and #1464 (20:00 UTC) three more; the check compares hashes only, so it asks for a review, and nobody did one. The last green commit is b50f49771 (#1383), whose own change advanced this record.
  • What changes: two files. In manifest.json, settings-graphics.png's reviewed_source: seven hashes advance (menu_i18n.h, vk_framegen.h, vk_fsr3fi.h, vk_internal.h, vk_menu.cpp, vk_reflex.h, vk_texture.h), ten headers join the list (the ones device_policy.h brings in since #1309), and the review revision (the SHA-256 of the sorted file/hash lines) is recomputed. In source-review-fullscreen-monitor.md, a dated "Retention after #1309" section says what was compared and found.
  • What does not change: the PNG and its hash, its capture revision and fixture hashes, the capture conditions, the other six images' entries, the checker, the workflow, the guide's text and alt text, any source file.
  • How it was checked: the check on main, on four other commits, and here (exact lines below); the helper's renders from b50f49771, 67efc4d3e (#1309), c14641a6f (#1362) and 597c5a4e0 (#1464) compared pixel by pixel and looked at; the two other steps of the workflow's check (14 and 4 tests); the whole suite here and on main, by name; the description checker.
  • What is still open: no website build (its packages are not on this PC); Windows and Intel (the picture is the UI-only fixture); a maintainer's look at the pictures below, as the README's "Completing a refresh" asks of a retention.
  • Risk: low. Nothing runs differently. A wrong "retained" would leave the guide showing a view the menu no longer has; I read every row of the pictures for that, and the first Graphics view is unchanged.

Why

main fails its own Guide images check, and every pull request shows the same red status that has nothing to do with it. The Graphics picture in the settings guide is recorded against the source files it is drawn from (reviewed_source.files); when one changes, scripts/check_guide_screenshots.py --review-sources prints REVIEW REQUIRED and exits 1 until someone compares the picture with a rendering of the new source and either retains it or recaptures it (docs/images/guide/README.md, "Capture and maintenance", step 5). #1383 did that at 16:02 UTC today (b50f49771); three minutes later #1309 merged vk_internal.h and vk_reflex.h changes, at 18:53 UTC #1362 merged changes to vk_internal.h, vk_menu.cpp and menu_i18n.h, and at 20:00 UTC #1464 merged changes to vk_framegen.h, vk_fsr3fi.h and vk_texture.h. #1144 (16 Nov) was the same repair for one file and was closed as superseded on 17 Nov ("Reopen if the check goes red for the same reason again"); this is that case. The trackers (issues and pull requests, open and closed) were searched for "guide screenshots", "guide images", "review-sources" and "retention": no open issue or pull request is about this failure; #1144 and #1383 are the earlier ones.

What changed

The Graphics picture is retained. Its review record now names the content that was compared, and the review is written down.

  • docs/images/guide/manifest.json, settings-graphics.png → reviewed_source: revision is now sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a (it was sha256:275a1444…); files has the new hashes of gpu/vk/menu_i18n.h, gpu/vk/vk_framegen.h, gpu/vk/vk_fsr3fi.h, gpu/vk/vk_internal.h, gpu/vk/vk_menu.cpp, gpu/vk/vk_reflex.h, gpu/vk/vk_texture.h and ten new entries (astc_bc_policy.h, device_policy.h, fallback_size_policy.h, gpu_clock.h, mesh_mode.h, mirror_budget.h, retired_give_back.h, target_pool.h, texture_budget.h, vram_compact.h, all in gpu/vk/): 77 files instead of 67. The helper's compiler pass finds them because #1309's vk_internal.h now includes device_policy.h; they were not recorded before. Nothing else in the file changes (the JSON round-trips exactly, so the diff is only those lines).
  • docs/images/guide/source-review-fullscreen-monitor.md: a "Retention after #1309 (2026-11-17)" section (+30 lines): what was rendered and compared, what each changed input is (#1309: the include and three members in Device, a comment that lost a switch name, a comment in vk_reflex.h; #1362: swap_slots, kPresentSlotsMax, present_slots_for, and one sentence added to the hints of the two values of the Frame pacing row and their translations, a row on the Debug tab, not on the Graphics tab; #1464: the declarations framegen_hud_before, a hud_mask member and texture_alive), why the ten headers join, and what is not claimed.
  • Unchanged on purpose: settings-graphics.png (sha256 3531f6ab…), captured_source, fixture_files, capture, the entry's review.notes, docs/graphics-and-controls.md and its alt text and caption ("development build 54d25c79"), the checker, the workflow and the README.

Measurements

Verdict: the check fails on main (exit 1, 7 lines) and passes with this PR (exit 0). The Graphics view rendered from main differs from the render of the last green commit (b50f49771, before #1309) in 976 of 921,600 pixels, all in the banner's version text, so the picture is retained. Nothing else to measure in the game: a record and a note change no code.

Hardware: Linux 7.2.15, Intel i9-13900K, 93 GB; an RTX 4090 is in the PC but not used (nothing here opens a GPU)
Scene: none; the Graphics view of the menu fixture, 1280x720, rendered by SDL2's software renderer
Method: scripts/check_guide_screenshots.py --review-sources on six commits; the capture helper's renders of five, compared pixel by pixel (results by commit under "How it was tested", 2 and 4); one run each (all deterministic: main rendered twice gave byte-identical PNGs and menu-capture.json)
How to reproduce: below, under "How it was tested"

Before: main @ dcb7b47c2 After: this PR @ 9fd31222d
scripts/check_guide_screenshots.py --review-sources exit 1: REVIEW REQUIRED for menu_i18n.h, vk_framegen.h, vk_fsr3fi.h, vk_internal.h, vk_menu.cpp, vk_reflex.h, vk_texture.h exit 0
tests/test_guide_screenshots.py passes (in the whole suite) 14 tests OK
tests/test_launcher_capture.py passes (in the whole suite) 4 tests OK
whole tests/run_all.py 614 passed, 30 failed, 82 skipped (main 597c5a4e0) 614 passed, 30 failed, 82 skipped (this PR on 597c5a4e0); the same 30 fail, by name
Graphics view rendered by the capture helper from main, a7d8f675…: differs from the render of b50f49771 (94a3b352…) in 976 pixels, all in the banner's version text the picture itself is unchanged (settings-graphics.png, 3531f6ab…)

The check rows are from dcb7b47c2 and 9fd31222d; the whole-suite and render rows are from 597c5a4e0 and this PR on it (27a147927). Main has moved since (#1454: the PR template, the description checker and their test; #718: vk_draw.cpp and a test), with no recorded input and no guide file, and the last rebase left the patch unchanged (git range-diff =): the check and the two guide tests were rerun on the new base, the suite and the renders carried, not rerun.

The check on main, whole, as the program printed it (python3 -I -B scripts/check_guide_screenshots.py --review-sources, exit 1):

ASSET OK: launcher-home.png (960x600)
NOT CHECKED: launcher-home.png: Launcher UI sources; supply --launcher-source CHECKOUT
ASSET OK: launcher-saves.png (960x600)
NOT CHECKED: launcher-saves.png: Launcher UI sources; supply --launcher-source CHECKOUT
ASSET OK: launcher-import.png (960x600)
NOT CHECKED: launcher-import.png: Launcher UI sources; supply --launcher-source CHECKOUT
ASSET OK: settings-graphics.png (1280x720)
ASSET OK: launcher-manage-saves.png (960x600)
NOT CHECKED: launcher-manage-saves.png: Launcher UI sources; supply --launcher-source CHECKOUT
ASSET OK: launcher-game-files.png (960x600)
NOT CHECKED: launcher-game-files.png: Launcher UI sources; supply --launcher-source CHECKOUT
ASSET OK: launcher-import-confirm.png (960x600)
NOT CHECKED: launcher-import-confirm.png: Launcher UI sources; supply --launcher-source CHECKOUT
REVIEW REQUIRED: settings-graphics.png: gpu/vk/menu_i18n.h changed since reviewed revision sha256:275a1444253595310fb7c021e58311b86b4e95ae111fa63d236395c285e4d678
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_framegen.h changed since reviewed revision sha256:275a1444253595310fb7c021e58311b86b4e95ae111fa63d236395c285e4d678
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_fsr3fi.h changed since reviewed revision sha256:275a1444253595310fb7c021e58311b86b4e95ae111fa63d236395c285e4d678
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_internal.h changed since reviewed revision sha256:275a1444253595310fb7c021e58311b86b4e95ae111fa63d236395c285e4d678
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_menu.cpp changed since reviewed revision sha256:275a1444253595310fb7c021e58311b86b4e95ae111fa63d236395c285e4d678
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_reflex.h changed since reviewed revision sha256:275a1444253595310fb7c021e58311b86b4e95ae111fa63d236395c285e4d678
REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_texture.h changed since reviewed revision sha256:275a1444253595310fb7c021e58311b86b4e95ae111fa63d236395c285e4d678
Guide screenshot check failed: 7 issue(s). Review the affected UI and guide before updating review hashes.

On this PR's head (exit 0; the six Launcher pictures are NOT CHECKED here and on main alike: there is no Launcher checkout in CI):

ASSET OK: settings-graphics.png (1280x720)
Guide screenshot checks passed for the inputs checked above; NOT CHECKED items remain outstanding.

Pictures

PICTURE: GuideFix-graphics-renders.jpg - Left: the Graphics view rendered by the capture helper from b50f49771 (main before #1309, the last commit the check passed on); middle: rendered from 597c5a4e0 (main with #1309, #1362 and #1464); right: the middle picture dimmed, with the 976 pixels that differ from the left one in red. The same tabs, rows (Quality preset Custom, Aspect ratio 16:9, Output resolution 2048x1152 (reduced), Custom output size None, Profile Docked, Upscaler Game's own, Render resolution Auto (dynamic), Sharpness 0%, Frame generation Off, Game frame rate cap 60 (the console's)), help panel and button prompts in both; the only red is in the top left banner.
PICTURE: GuideFix-graphics-banner.jpg - The banner enlarged, the same three pictures: "Longshot nightly-404-5d8293da-2-gb50f49771" on the left render, "Longshot nightly-407-67efc4d3-7-g597c5a4e0" on the middle one, and the red pixels (x 126 to 260, y 25 to 38) of the difference at the bottom: the build's version text is the whole difference.

Flags and settings

None.

How it was tested

Everything here was run by an AI agent (Claude Sonnet 5.5) working for me; the commands are given so anyone can rerun them. The commit hashes are the ones on the forge. I started on main c14641a6f (17 Nov 2026, 13:35 US Central time) with four changed inputs; main then moved three more times, to 7bb06359c (#1453, no recorded input), to 597c5a4e0 (#1464, three more recorded inputs: the review was extended and the commit amended) and to dcb7b47c2 (#1454 and #718, no recorded input). The renders and the whole-suite results below are from 597c5a4e0 and this PR on it; the check and the two guide tests were rerun on dcb7b47c2 and this head 9fd31222d (see the history under Testing).

1. Environment

Linux 7.2.15 (Arch, x86-64), Intel i9-13900K, 93 GB; the load average was 11 at the start and 20 to 30 later (other jobs on the PC; the checks and renders ran in the idle scheduling class). clang 23.1.3, SDL2 2.32.74 (this is sdl2-compat on SDL3 3.4.18), libpng 1.6.59, Vulkan headers from /usr/include (headers only, no Vulkan runtime or device), Python 3.14.8 for the checker and 3.12.16 for the suite. The manifest records clang 23.1.6, SDL2 2.32.10 and libpng 1.6.57 for the published PNG: a different toolchain, which matters below. No GPU, window or game was started.

2. What the check does, and where it first fails

  1. Read .forgejo/workflows/guide-screenshots.yml: it runs scripts/check_guide_screenshots.py --review-sources, then tests/test_guide_screenshots.py and tests/test_launcher_capture.py, on every pull request and every push to main. It never builds the fixture or opens a game file.
  2. Read scripts/check_guide_screenshots.py: for each image it checks the PNG's size and SHA-256, then with --review-sources the SHA-256 of every file in reviewed_source.files and fixture_files against the working tree. A difference is a REVIEW REQUIRED line; a missing Launcher checkout is NOT CHECKED, which does not fail. It compares hashes only: it never looks at a picture.
  3. Made detached worktrees of main (git fetch forge main, git worktree add --detach <dir> <commit>) at 597c5a4e0 and c14641a6f, and of b50f49771, 67efc4d3e and 7fd3e2ace, and ran the check in each: the table below.
  4. Read what changed in the seven files since b50f49771 (git diff b50f49771 597c5a4e0 -- <the seven files>): #1309 in vk_internal.h (#include "device_policy.h"; Device gets driver, facts, policy; a comment loses a switch name) and vk_reflex.h (a comment); #1362 in vk_internal.h (swap_slots, kPresentSlotsMax, present_slots_for), vk_menu.cpp (the hn_pace hint strings) and menu_i18n.h (those strings' translations); #1464 in vk_framegen.h (framegen_hud_before), vk_fsr3fi.h (a hud_mask member) and vk_texture.h (texture_alive): declarations and comments, which the menu fixture neither calls nor draws. hn_pace belongs to the Frame pacing row, which is declared with TAB_DEBUG (vk_menu.cpp line 1777): not a row of the Graphics tab this picture shows.

What the check said on each commit (python3 -I -B scripts/check_guide_screenshots.py --review-sources, seven worktrees):

Commit what it is check, exit REVIEW REQUIRED lines
b50f49771 #1383, the last review (before #1309) 0 none
67efc4d3e #1309 1 vk_internal.h, vk_reflex.h
7fd3e2ace #1277, the merge the picture was captured for 0 none
c14641a6f main after #1362 and #1359 1 menu_i18n.h, vk_internal.h, vk_menu.cpp, vk_reflex.h
597c5a4e0 main after #1464 1 menu_i18n.h, vk_framegen.h, vk_fsr3fi.h, vk_internal.h, vk_menu.cpp, vk_reflex.h, vk_texture.h
dcb7b47c2 main now (#1454 and #718 on top) 1 the same seven
9fd31222d this PR, on dcb7b47c2 (27a147927 on 597c5a4e0 gave the same) 0 none

3. The renders: the project's UI-only capture helper

The helper is scripts/screenshots/capture_menu.py, with the fixture scripts/screenshots/menu.cpp (both on the forge; the guide README's "UI-only settings fixture" describes them). It compiles the real gpu/vk/vk_menu.cpp, the translation code and the bundled Dear ImGui against the fixture, calls the menu's draw function with fixed illustrative settings, and writes the result with SDL2's software renderer: 1280x720, Medium menu scale, English, the bundled Libertinus fonts over a solid RGB 16,18,21 background, explicit 16:9, the compiled Options defaults, no GPU capabilities, no saved options, no game; the environment has every HOS_*, RX_* and LONGSHOT_* variable removed and HOS_DISPLAY_MODES=1280x720, and it runs in an empty temporary folder. It refuses a source with uncommitted capture inputs. The banner's text is git describe of the source plus " (UI fixture)", from -DLONGSHOT_VERSION.

I ran main's copy of the helper, so the fixture is the same for every render and only the source differs:

python -I scripts/screenshots/capture_menu.py --source <worktree of the commit> --vulkan-headers /usr/include --output <new folder>

once each for b50f49771, 67efc4d3e, c14641a6f, 597c5a4e0 and 7fd3e2ace, and once more for c14641a6f into a second folder: the second render's three PNGs (Graphics, Audio, Controls) and menu-capture.json are byte for byte equal to the first's, so a render is repeatable on this PC. The image's recorded capture source, 54d25c79, is no longer on the forge (#1277's head moved: the pull request's head is c0dfffe73 now), so the comparison base is the last commit the check passed on; 7fd3e2ace, #1277's squash on main, stands in for the capture source below.

4. The comparison: every number from the files

I compared the renders with a small script (PIL and NumPy only for decoding and counting; it is attached below): for each pair, the number of pixels where any channel differs, the largest channel difference, and the bounding box of those pixels. Where a pair differs in several places (the published PNG against a render), I grouped the differing pixels into boxes of 8 by 8 pixel blocks within two blocks of each other with a longer version of the same script, to say where.

compare_renders.py
import sys
import numpy as np
from PIL import Image

def load(path):
    im = Image.open(path).convert('RGB')
    assert im.size == (1280, 720)
    return np.asarray(im).astype(np.int16)

a, b = load(sys.argv[1]), load(sys.argv[2])
d = np.abs(a - b).max(axis=2)
ys, xs = np.nonzero(d)
print(f'{len(ys)} of {d.size} pixels differ, largest channel difference {d.max()}')
if len(ys):
    print(f'bounding box x {xs.min()}..{xs.max()}, y {ys.min()}..{ys.max()}')

Results (all pairs rendered on this PC with main's helper; PNG sha256: b50f49771 94a3b352…, 67efc4d3e cf24f221…, c14641a6f 2e25da3d…, 597c5a4e0 a7d8f675…, 7fd3e2ace 6268e1f0…, published 3531f6ab…):

pair differing pixels where
b50f49771 and 597c5a4e0 976 of 921,600 x 126..260, y 25..38: the banner's version text; nothing else
b50f49771 and 67efc4d3e (#1309 alone) 1,248 x 72..260, y 25..38: the same text (its describe string is nightly-407-67efc4d3, shown as "Nightly 407 · 67efc4d3")
67efc4d3e and c14641a6f (#1362 and #1359) 1,203 the same text
c14641a6f and 597c5a4e0 (#1464) 425 x 189..260, y 25..35: the same text
b50f49771 and c14641a6f 986 x 126..260, y 25..38: the same text
7fd3e2ace (#1277) and 597c5a4e0 919 the same text
published PNG and the 597c5a4e0 render 60,454 row borders and glyph edges, the help panel, the footer's prompts, the banner
published PNG and the 7fd3e2ace render 60,473 the same places

The last two rows are why the comparison is between renders. The PNG on main differs from a render of #1277's own merge commit on this PC's toolchain in 60,473 pixels (the rows and the help are drawn a pixel differently; the labels, values and layout read the same), so a render of any commit differs from the PNG by about as much, and that difference is not from #1309, #1362 or #1464. I did not find the cause by experiment: the toolchain here differs from the recorded one in the compiler, in SDL2 (an sdl2-compat on SDL3 against 2.32.10) and in libpng, and I have not rendered with the recorded versions. It is labelled as inferred.

Looking at the pictures. I opened each render at full size (b50f49771, 67efc4d3e, c14641a6f, 597c5a4e0, 7fd3e2ace) and the published PNG, and compared them with the pixel boxes above: tabs Graphics, Audio, Gameplay, Controls, Debug; Quality preset selected on Custom; the rows Aspect ratio (16:9 or Monitor's shape), Output resolution 2048x1152 (reduced), Custom output size None, Profile (Docked or Handheld), Upscaler Game's own, Render resolution Auto (dynamic), Sharpness 0%, then "Frame generation and latency": Frame generation Off, Game frame rate cap 60 (the console's); the help panel "Quality preset: Sets the scaling rows and Shadow resolution for a GPU with that much memory. The Upscaler and Frame generation stay yours." with its note; and the prompts Choose, Change, Compact (RShift), Tabs (Q E) and Close (Esc). They are the same in all of them, and they are what the guide's alt text names ("Quality preset selected, setting rows on the left, help on the right, and keyboard navigation along the bottom"). Only the banner's version text differs.

5. Advancing the record

  1. The helper writes menu-capture.json with source_files: the repository files the compiler used for that render (-MM) plus the Libertinus fonts, each with its SHA-256. For 597c5a4e0 that is 77 files: the 67 of the old record and ten more; #1464 adds none.
  2. A small script of mine copied the new list into reviewed_source.files (asserting that each hash equals the file's own SHA-256 and that the manifest is in json.dumps(indent=2) form, so nothing else moves) and set revision to the SHA-256 of the sorted path=hash lines, each with a final newline, as the README says. I checked the formula first: applied to the old 67 entries it gives exactly the recorded sha256:275a1444….
  3. The seven changed files and the ten added ones are exactly the sets the comparison of the helper's lists gives: b50f49771 to 67efc4d3e: vk_internal.h, vk_reflex.h changed, the ten added; 67efc4d3e to c14641a6f: menu_i18n.h, vk_internal.h, vk_menu.cpp changed, none added; c14641a6f to 597c5a4e0: vk_framegen.h, vk_fsr3fi.h, vk_texture.h changed, none added.
  4. Wrote the note in source-review-fullscreen-monitor.md in the form of its earlier sections, dated.
  5. Committed as the user with the two assistance trailers (git interpret-trailers --parse lists both).

6. The checks after the change

  • python3 -I -B scripts/check_guide_screenshots.py --review-sources on 27a147927 (on 597c5a4e0) and on 9fd31222d (on dcb7b47c2): exit 0 both times (lines above).
  • tests/test_guide_screenshots.py (14 tests) and tests/test_launcher_capture.py (4 tests), through the workbench's idle gate (a wrapper that runs CPU-only jobs in the idle scheduling class, in one of three test slots, behind any timing hold; https://github.com/mooki000/ls-workbench): both OK.
  • The whole suite, python -I -B tests/run_all.py --jobs 8 --junit <file>, through the same gate, in a worktree of this PR on 597c5a4e0 and in one of main 597c5a4e0: 614 passed, 30 failed, 82 skipped on each (108 s and 132 s); the same 30 fail on both by name (below). The 82 skipped are the same on both: 65 need the Vulkan headers or the SPIR-V headers, which this run's tool search did not find (it prints "not found here: vulkan_headers" and "not found here: spirv_headers"); the rest need Windows, the game's dump or a GPU. I compared the two JUnit files by test name: no test changed status. Not rerun after the later rebases (patch identical, no recorded input in main's new commits).
  • python -I -B scripts/check_pr_description.py --file <this body> --diff <git diff --src-prefix=a/ --dst-prefix=b/ main..HEAD> --title <title>: run on this text (result under "Testing").

The 30 failures on both (main 597c5a4e0 and this PR on it), named: test_bug_report_defaults, test_cpu_report, test_crt_options, test_damage_debug_menu, test_display_startup_failure, test_dlss_feature_size, test_failed_compile_keeps_objects, test_framegen_preset, test_guest_imported, test_hud_layout_row, test_invalidate_vcore, test_linux_preflight, test_linux_pressure, test_linux_update, test_mirror_budget, test_missing_nup, test_mods_size_table, test_pending_guest_import, test_pipeline_play_cache, test_present_thread, test_profiling_mode, test_readback_timeout_source, test_rumble_menu, test_run_all_changed, test_slow_frames, test_target_image_pool, test_upscaler_round_trip, test_upscaler_rows, test_vcore_escape, test_walk_key. None was looked into: a change of one JSON file and one Markdown file cannot reach them, and they fail on main the same way.

7. Overlaps, and the tracker

  • The tracker: searched as said under Why.
  • Overlaps: the 338 open pull requests' file lists (the forge's pulls/N/files, 50 a page) were scanned for the guide's files (docs/images/guide/*, the checker, the workflow, the capture helper and fixture) and for the four headers changed when the scan was made (#1309's and #1362's). Of those that carry a guide edit, I fetched the heads (git fetch forge +refs/pull/N/head:refs/remotes/pr/N) and ran git merge-tree --write-tree --name-only of each head against forge main and against this branch; the trial merges of the five of ours were repeated on this head; the result and what it means is under Overlaps. One pull request, #768, returned no file list on the first pass; its diff holds none of those files.

8. How to rerun it

git fetch forge main
git worktree add --detach ../ls-main 597c5a4e0
git worktree add --detach ../ls-before b50f49771
python -I scripts/screenshots/capture_menu.py --source ../ls-before --vulkan-headers /usr/include --output /tmp/render-before
python -I scripts/screenshots/capture_menu.py --source ../ls-main   --vulkan-headers /usr/include --output /tmp/render-main
python compare_renders.py /tmp/render-before/settings-graphics.png /tmp/render-main/settings-graphics.png
python -I -B scripts/check_guide_screenshots.py --review-sources
python -I -B tests/test_guide_screenshots.py && python -I -B tests/test_launcher_capture.py

(capture_menu.py is run from the checkout that has this PR, so the fixture is the same for both renders; it needs a C++20 compiler, pkg-config, SDL2 and libpng development files and the Vulkan headers.)

9. What was not tested

See "Not tested" under Testing.

Testing

Tested: on Linux x86-64 (kernel 7.2.15), clang 23.1.3, SDL2 2.32.74 (sdl2-compat), libpng 1.6.59, no GPU, on 17 Nov 2026, base main dcb7b47c2, head 9fd31222d. For this docs-only change "tested on my own PC" is the checks I ran, and they are these: the Guide images check on seven commits (main fails with 7 lines, this PR passes); the capture helper's renders from b50f49771, 67efc4d3e, c14641a6f, 597c5a4e0 and 7fd3e2ace, compared by pixel and looked at; tests/test_guide_screenshots.py (14) and tests/test_launcher_capture.py (4) pass; the whole tests/run_all.py on this PR and on main, both on 597c5a4e0: 614 passed, 30 failed, 82 skipped on both, the same 30 by name (listed above; none is this PR's). check_pr_description.py --file <this body> --diff <the diff>: passes (run on the final text, with the checker of dcb7b47c2, before the handover).

History: the commit was first made on c14641a6f (9db835e58, four inputs), rebased onto 7bb06359c (7586502e3, patch identical; #1453 touches no recorded input), then onto 597c5a4e0, where #1464 changed three more recorded inputs: the review was extended (a render of 597c5a4e0, its comparison, three more hashes, the note) and the commit amended into 27a147927. Last, rebased onto dcb7b47c2 (#1454 and #718: neither touches a recorded input or a guide file): head 9fd31222d, patch identical to 27a147927 (git range-diff =). Rerun there: the check (exit 0; on main dcb7b47c2 it still says the same 7 lines) and the two guide tests (14 and 4 OK). Carried, not rerun: the renders, the pixel comparisons and the whole suite (from 597c5a4e0). Windows: not applicable. Game: not applicable (docs only).

Not tested: the website build and website/tests/guide-screenshots.test.ts (the site's packages are not installed on this PC; the PNG is unchanged, so what the site copies is unchanged); Windows and Intel (the picture is the UI-only fixture, not a live Vulkan frame, as its caption says; the Windows-target syntax check does not apply: no C or C++, Python or workflow file changes); a render with the toolchain recorded for the PNG (clang 23.1.6, SDL2 2.32.10, libpng 1.6.57); rows below the first Graphics view and the other tabs (the picture does not show them, and this review does not look at them); no game was run, none is needed for a record and a note.

Must be tested:

  • Any PC with a browser, by hand: build and open the Settings page as website/README.md says, at desktop width and at 360 to 390 px, in both themes, expecting the Graphics picture to load from the site's own files with its caption "development build 54d25c79" unchanged and readable (by hand: look at the picture and its caption, as the guide README's "Completing a refresh" asks; nothing about the picture changed, so this is the README's standing step, not a new risk).
  • A maintainer, by hand: look at GuideFix-graphics-renders.jpg above and say whether "only the version text differs" is a retention you accept, expecting a yes or a recapture request (a person; the README says a hash match is not a visual review).

Risks

What could break: nothing at run time: a JSON record and a Markdown file. The one way to be wrong is the retention itself: if a reader sees a difference I did not (I compared every pixel of the first Graphics view between four commits, and read the rows), the guide would show a stale picture; the answer then is a recapture, which the README describes. A second, smaller one: the list now has 77 files, so a change to any of the ten new headers asks for a review again, as the other 67 do. Costs: none that I know of: nothing the game runs changes, so no speed, latency, memory or setup is affected, and nothing was measured because there is nothing to measure.

Turning it off: revert the commit; the check is red again on main, as now.

Compatibility: Nothing changes for a player or for the website: the PNG, its hash, its alt text and its caption are the same.

Overlaps

From a scan of the file lists of the 338 open pull requests, then a trial merge (git merge-tree --write-tree --name-only) of each head that edits the guide's manifest against main and against this branch (the five of ours repeated on this commit before the last rebase, which did not change the patch), reading the conflict hunks (only a conflict that shows with this branch and not with main is an overlap):

Pull request its guide commit with this branch
#1358 (ours), #1411 (ours), #1426 (ours) last commit of each head (9872740e8, 92a6c5950, 4221dd097): the same kind of commit as this one (hashes and a "Retention after" section) each merges with main alone; with this branch the two files of its docs commit conflict. Read for #1426: in manifest.json the revision line and the lines of vk_internal.h, vk_menu.cpp and vk_menu.h (the same entry), in the note file both add a section at the end; the other two conflict in the same two files
#61 and #562 (ours; their rebased branches with a docs commit are local so far: c80312e60, 8b3a36cc4) a docs commit each, the same kind the same two files conflict
#68 (ours, co-op) recaptures the picture (a sixth tab) and has its own manifest entry manifest.json conflicts with this branch and not with main: it replaces the whole entry, so it takes its own on rebase
#1408 (ours), #1372, #1125, #405 edit the manifest conflict with main already, in the same files, and the same list of files with this branch (hunks not read: the conflict exists on main): not an overlap of this PR

Once this merges, the five docs commits of #1358, #1411, #1426, #61 and #562 are redone on top of it, and each loses the part that covers main's changes (the seven hashes of #1309, #1362 and #1464 and the ten new headers). They do not disappear: each of the five changes recorded inputs of its own, so the check on each head minus its docs commit, merged onto this branch, still asks for: #1358 fps_stats.h, vk_api.h, vk_menu.cpp, vk_menu.h; #1411 oot_cheat_items.h, vk_api.h, vk_menu.cpp; #1426 vk_api.h, vk_menu.cpp, vk_menu.h; #61 menu_i18n.h, vk_api.h, vk_menu.cpp, vk_menu.h; #562 fps_stats.h, menu_i18n.h, vk_menu.cpp, vk_menu.h (checked by extracting each merge's tree and running the checker on it). This PR touches none of the five.

Questions for you

The recurring cost is that the check goes red on every API bump or policy header change whose picture is unchanged: since 15 Nov (#264, d7aeaa269) 240 commits reached main, 56 of them changed one of the files the check records, and the review each time is "render both, look, they differ only in the version text" (this PR; #1144; the five of ours). Two ways to cut it, as questions:

  1. Should the comparison mask the build's version text (or the helper capture with a fixed version string)? A compare step next to the helper (render two revisions, ignore the banner's version box, exit 1 on any other pixel), or a fixed -DLONGSHOT_VERSION so that unchanged UI gives a byte-identical PNG on one toolchain, would turn today's look into a command that an author, a reviewer or a CI job runs, and the review note could quote its output. It would catch: any change in the first Graphics view (a row, a value, a help sentence, the prompts, the layout) between two revisions on the same toolchain. It would not: stop the check going red, because the checker compares file hashes and never looks at a picture (the CI runner has no compiler, SDL2 or libpng, and the workflow says it does not build the fixture): by itself it makes each review cheaper, not rarer; see anything the first view does not show (rows below it, other tabs, a help text of a row that is not selected: #1362's change is of that kind); work against the published PNG (a render here differs from it in about 60,000 pixels on another toolchain, so it has to be two renders on one toolchain); or notice a real change in the masked box (a longer version string that overflows the banner). A fixed version string also means the banner stops naming a build, so the PNG and its caption "development build 54d25c79" need one recapture.
  2. Should headers that hold no menu layout leave the Graphics image's reviewed sources, gpu/vk/vk_api.h first, or should the list be the menu's own files only? The ten I mean by "the menu's own files" are, in gpu/vk/: vk_menu.cpp, vk_menu.h (it holds Options and its defaults), menu_i18n.h, vk_menu_i18n.cpp, vk_menu_i18n.h, vk_menu_hit.h, menu_restart.h, upscaler_rows.h, display_modes.h and monitor_choice.h; it is my reading, a starting list, not a decision. Of the 56 commits above, 28 changed none of them; vk_api.h is in 13 (every ABI bump; two of the 13 changed nothing else the check records), vk_internal.h in 16, and five of today's seven red lines (vk_internal.h, vk_reflex.h, vk_framegen.h, vk_fsr3fi.h, vk_texture.h) are headers that draw nothing. It would catch: every change to the files that define the rows, labels, hints, defaults and layout, which is where a picture goes stale, and it would stop the check going red for the other 28. It would not: catch a change in a dropped header that alters what the menu draws without touching the menu's files: vk_menu.cpp uses types and constants from vk_api.h (MkwVkMonitor, MkwVkSetting, MkwVkPointer, HOS_TEXT_KEY), so a changed field or key constant there could change a row with no hash asking; it needs someone to own the line between "draws" and "does not draw" and revisit it when a dependency arrives, where the helper's compiler-derived list is complete by construction; and it would still ask for a review when a menu file only changes another tab's text (as #1362 did on the Debug tab). The two combine: (2) makes the check ask less often, (1) makes each remaining review a command.

This PR only restores the record; neither change is in it.

Issues

See #1144 (closed, superseded) and #1383, which kept this record green until #1309.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why. (Docs only, nothing the game runs: the checks I ran are what Testing's Tested says.)
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks. (Nothing the game runs changes; Risks says so.)
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main. (Based on dcb7b47c2, forge main when this was written.)
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named). (614 passed, 30 failed, 82 skipped here and on main, both on 597c5a4e0; the same 30 fail on both, named under How it was tested, 6.)
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen. (The two pictures above: the same view rendered from b50f49771 and from 597c5a4e0; the change itself is a record and shows nothing on screen.)
  • Docs updated.

New on this forge; not opened on GitHub.

**Type:** docs · **Risk:** low · **Tested on:** Linux x86-64, no GPU (the picture is drawn in memory by SDL2's software renderer; the checks need no game) · **Needs:** any PC with a browser (the site's Settings page), and a maintainer's look at the pictures ## TL;DR The guide-screenshot check is red on `main` itself, so every pull request inherits the failure: #1309, #1362 and #1464 changed seven source files that the Graphics guide picture is recorded against, and no merge carried a review. I did the review: the Graphics view rendered from main and from the last commit the check passed on differ only in the build's version text (976 of 921,600 pixels). So the picture is kept, and this pull request updates its record (seven hashes, ten headers that were never listed, a dated note), which makes the check pass again. Two questions for maintainers at the end would stop it going red for changes that cannot touch the picture. ## Breakdown - **Who it helps:** every author with an open pull request (the failure is not theirs, and each has to explain it), and the guide's readers: the record that says the picture was reviewed is true again. - **What was wrong:** the Graphics picture is recorded against the SHA-256 of 67 source files. #1309 (the switch table, 16:05 UTC) changed two of them, #1362 (18:53 UTC) three, one of them again, and #1464 (20:00 UTC) three more; the check compares hashes only, so it asks for a review, and nobody did one. The last green commit is `b50f49771` (#1383), whose own change advanced this record. - **What changes:** two files. In `manifest.json`, `settings-graphics.png`'s `reviewed_source`: seven hashes advance (`menu_i18n.h`, `vk_framegen.h`, `vk_fsr3fi.h`, `vk_internal.h`, `vk_menu.cpp`, `vk_reflex.h`, `vk_texture.h`), ten headers join the list (the ones `device_policy.h` brings in since #1309), and the review revision (the SHA-256 of the sorted file/hash lines) is recomputed. In `source-review-fullscreen-monitor.md`, a dated "Retention after #1309" section says what was compared and found. - **What does not change:** the PNG and its hash, its capture revision and fixture hashes, the capture conditions, the other six images' entries, the checker, the workflow, the guide's text and alt text, any source file. - **How it was checked:** the check on main, on four other commits, and here (exact lines below); the helper's renders from `b50f49771`, `67efc4d3e` (#1309), `c14641a6f` (#1362) and `597c5a4e0` (#1464) compared pixel by pixel and looked at; the two other steps of the workflow's check (14 and 4 tests); the whole suite here and on main, by name; the description checker. - **What is still open:** no website build (its packages are not on this PC); Windows and Intel (the picture is the UI-only fixture); a maintainer's look at the pictures below, as the README's "Completing a refresh" asks of a retention. - **Risk:** low. Nothing runs differently. A wrong "retained" would leave the guide showing a view the menu no longer has; I read every row of the pictures for that, and the first Graphics view is unchanged. ## Why `main` fails its own Guide images check, and every pull request shows the same red status that has nothing to do with it. The Graphics picture in the settings guide is recorded against the source files it is drawn from (`reviewed_source.files`); when one changes, `scripts/check_guide_screenshots.py --review-sources` prints `REVIEW REQUIRED` and exits 1 until someone compares the picture with a rendering of the new source and either retains it or recaptures it (`docs/images/guide/README.md`, "Capture and maintenance", step 5). #1383 did that at 16:02 UTC today (`b50f49771`); three minutes later #1309 merged `vk_internal.h` and `vk_reflex.h` changes, at 18:53 UTC #1362 merged changes to `vk_internal.h`, `vk_menu.cpp` and `menu_i18n.h`, and at 20:00 UTC #1464 merged changes to `vk_framegen.h`, `vk_fsr3fi.h` and `vk_texture.h`. #1144 (16 Nov) was the same repair for one file and was closed as superseded on 17 Nov ("Reopen if the check goes red for the same reason again"); this is that case. The trackers (issues and pull requests, open and closed) were searched for "guide screenshots", "guide images", "review-sources" and "retention": no open issue or pull request is about this failure; #1144 and #1383 are the earlier ones. ## What changed The Graphics picture is retained. Its review record now names the content that was compared, and the review is written down. - `docs/images/guide/manifest.json`, `settings-graphics.png` → `reviewed_source`: `revision` is now `sha256:006bc2510d667d862da9190b16a64059c80e8a2b8d824f213cd4e1bd92f1439a` (it was `sha256:275a1444…`); `files` has the new hashes of `gpu/vk/menu_i18n.h`, `gpu/vk/vk_framegen.h`, `gpu/vk/vk_fsr3fi.h`, `gpu/vk/vk_internal.h`, `gpu/vk/vk_menu.cpp`, `gpu/vk/vk_reflex.h`, `gpu/vk/vk_texture.h` and ten new entries (`astc_bc_policy.h`, `device_policy.h`, `fallback_size_policy.h`, `gpu_clock.h`, `mesh_mode.h`, `mirror_budget.h`, `retired_give_back.h`, `target_pool.h`, `texture_budget.h`, `vram_compact.h`, all in `gpu/vk/`): 77 files instead of 67. The helper's compiler pass finds them because #1309's `vk_internal.h` now includes `device_policy.h`; they were not recorded before. Nothing else in the file changes (the JSON round-trips exactly, so the diff is only those lines). - `docs/images/guide/source-review-fullscreen-monitor.md`: a "Retention after #1309 (2026-11-17)" section (+30 lines): what was rendered and compared, what each changed input is (#1309: the include and three members in `Device`, a comment that lost a switch name, a comment in `vk_reflex.h`; #1362: `swap_slots`, `kPresentSlotsMax`, `present_slots_for`, and one sentence added to the hints of the two values of the Frame pacing row and their translations, a row on the Debug tab, not on the Graphics tab; #1464: the declarations `framegen_hud_before`, a `hud_mask` member and `texture_alive`), why the ten headers join, and what is not claimed. - Unchanged on purpose: `settings-graphics.png` (`sha256 3531f6ab…`), `captured_source`, `fixture_files`, `capture`, the entry's `review.notes`, `docs/graphics-and-controls.md` and its alt text and caption ("development build 54d25c79"), the checker, the workflow and the README. ## Measurements **Verdict:** the check fails on main (exit 1, 7 lines) and passes with this PR (exit 0). The Graphics view rendered from main differs from the render of the last green commit (`b50f49771`, before #1309) in 976 of 921,600 pixels, all in the banner's version text, so the picture is retained. Nothing else to measure in the game: a record and a note change no code. Hardware: Linux 7.2.15, Intel i9-13900K, 93 GB; an RTX 4090 is in the PC but not used (nothing here opens a GPU) Scene: none; the Graphics view of the menu fixture, 1280x720, rendered by SDL2's software renderer Method: `scripts/check_guide_screenshots.py --review-sources` on six commits; the capture helper's renders of five, compared pixel by pixel (results by commit under "How it was tested", 2 and 4); one run each (all deterministic: main rendered twice gave byte-identical PNGs and `menu-capture.json`) How to reproduce: below, under "How it was tested" | | Before: main @ dcb7b47c2 | After: this PR @ 9fd31222d | |---|---|---| | `scripts/check_guide_screenshots.py --review-sources` | exit 1: `REVIEW REQUIRED` for `menu_i18n.h`, `vk_framegen.h`, `vk_fsr3fi.h`, `vk_internal.h`, `vk_menu.cpp`, `vk_reflex.h`, `vk_texture.h` | exit 0 | | `tests/test_guide_screenshots.py` | passes (in the whole suite) | 14 tests OK | | `tests/test_launcher_capture.py` | passes (in the whole suite) | 4 tests OK | | whole `tests/run_all.py` | 614 passed, 30 failed, 82 skipped (main `597c5a4e0`) | 614 passed, 30 failed, 82 skipped (this PR on `597c5a4e0`); the same 30 fail, by name | | Graphics view rendered by the capture helper | from main, a7d8f675…: differs from the render of `b50f49771` (94a3b352…) in 976 pixels, all in the banner's version text | the picture itself is unchanged (`settings-graphics.png`, 3531f6ab…) | The check rows are from `dcb7b47c2` and `9fd31222d`; the whole-suite and render rows are from `597c5a4e0` and this PR on it (`27a147927`). Main has moved since (#1454: the PR template, the description checker and their test; #718: `vk_draw.cpp` and a test), with no recorded input and no guide file, and the last rebase left the patch unchanged (`git range-diff` `=`): the check and the two guide tests were rerun on the new base, the suite and the renders carried, not rerun. The check on main, whole, as the program printed it (`python3 -I -B scripts/check_guide_screenshots.py --review-sources`, exit 1): ``` ASSET OK: launcher-home.png (960x600) NOT CHECKED: launcher-home.png: Launcher UI sources; supply --launcher-source CHECKOUT ASSET OK: launcher-saves.png (960x600) NOT CHECKED: launcher-saves.png: Launcher UI sources; supply --launcher-source CHECKOUT ASSET OK: launcher-import.png (960x600) NOT CHECKED: launcher-import.png: Launcher UI sources; supply --launcher-source CHECKOUT ASSET OK: settings-graphics.png (1280x720) ASSET OK: launcher-manage-saves.png (960x600) NOT CHECKED: launcher-manage-saves.png: Launcher UI sources; supply --launcher-source CHECKOUT ASSET OK: launcher-game-files.png (960x600) NOT CHECKED: launcher-game-files.png: Launcher UI sources; supply --launcher-source CHECKOUT ASSET OK: launcher-import-confirm.png (960x600) NOT CHECKED: launcher-import-confirm.png: Launcher UI sources; supply --launcher-source CHECKOUT REVIEW REQUIRED: settings-graphics.png: gpu/vk/menu_i18n.h changed since reviewed revision sha256:275a1444253595310fb7c021e58311b86b4e95ae111fa63d236395c285e4d678 REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_framegen.h changed since reviewed revision sha256:275a1444253595310fb7c021e58311b86b4e95ae111fa63d236395c285e4d678 REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_fsr3fi.h changed since reviewed revision sha256:275a1444253595310fb7c021e58311b86b4e95ae111fa63d236395c285e4d678 REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_internal.h changed since reviewed revision sha256:275a1444253595310fb7c021e58311b86b4e95ae111fa63d236395c285e4d678 REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_menu.cpp changed since reviewed revision sha256:275a1444253595310fb7c021e58311b86b4e95ae111fa63d236395c285e4d678 REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_reflex.h changed since reviewed revision sha256:275a1444253595310fb7c021e58311b86b4e95ae111fa63d236395c285e4d678 REVIEW REQUIRED: settings-graphics.png: gpu/vk/vk_texture.h changed since reviewed revision sha256:275a1444253595310fb7c021e58311b86b4e95ae111fa63d236395c285e4d678 Guide screenshot check failed: 7 issue(s). Review the affected UI and guide before updating review hashes. ``` On this PR's head (exit 0; the six Launcher pictures are `NOT CHECKED` here and on main alike: there is no Launcher checkout in CI): ``` ASSET OK: settings-graphics.png (1280x720) Guide screenshot checks passed for the inputs checked above; NOT CHECKED items remain outstanding. ``` ### Pictures PICTURE: GuideFix-graphics-renders.jpg - Left: the Graphics view rendered by the capture helper from `b50f49771` (main before #1309, the last commit the check passed on); middle: rendered from `597c5a4e0` (main with #1309, #1362 and #1464); right: the middle picture dimmed, with the 976 pixels that differ from the left one in red. The same tabs, rows (Quality preset Custom, Aspect ratio 16:9, Output resolution 2048x1152 (reduced), Custom output size None, Profile Docked, Upscaler Game's own, Render resolution Auto (dynamic), Sharpness 0%, Frame generation Off, Game frame rate cap 60 (the console's)), help panel and button prompts in both; the only red is in the top left banner. PICTURE: GuideFix-graphics-banner.jpg - The banner enlarged, the same three pictures: "Longshot nightly-404-5d8293da-2-gb50f49771" on the left render, "Longshot nightly-407-67efc4d3-7-g597c5a4e0" on the middle one, and the red pixels (x 126 to 260, y 25 to 38) of the difference at the bottom: the build's version text is the whole difference. ### Flags and settings None. ## How it was tested Everything here was run by an AI agent (Claude Sonnet 5.5) working for me; the commands are given so anyone can rerun them. The commit hashes are the ones on the forge. I started on main `c14641a6f` (17 Nov 2026, 13:35 US Central time) with four changed inputs; main then moved three more times, to `7bb06359c` (#1453, no recorded input), to `597c5a4e0` (#1464, three more recorded inputs: the review was extended and the commit amended) and to `dcb7b47c2` (#1454 and #718, no recorded input). The renders and the whole-suite results below are from `597c5a4e0` and this PR on it; the check and the two guide tests were rerun on `dcb7b47c2` and this head `9fd31222d` (see the history under Testing). ### 1. Environment Linux 7.2.15 (Arch, x86-64), Intel i9-13900K, 93 GB; the load average was 11 at the start and 20 to 30 later (other jobs on the PC; the checks and renders ran in the idle scheduling class). clang 23.1.3, SDL2 2.32.74 (this is `sdl2-compat` on SDL3 3.4.18), libpng 1.6.59, Vulkan headers from `/usr/include` (headers only, no Vulkan runtime or device), Python 3.14.8 for the checker and 3.12.16 for the suite. The manifest records clang 23.1.6, SDL2 2.32.10 and libpng 1.6.57 for the published PNG: a different toolchain, which matters below. No GPU, window or game was started. ### 2. What the check does, and where it first fails 1. Read `.forgejo/workflows/guide-screenshots.yml`: it runs `scripts/check_guide_screenshots.py --review-sources`, then `tests/test_guide_screenshots.py` and `tests/test_launcher_capture.py`, on every pull request and every push to main. It never builds the fixture or opens a game file. 2. Read `scripts/check_guide_screenshots.py`: for each image it checks the PNG's size and SHA-256, then with `--review-sources` the SHA-256 of every file in `reviewed_source.files` and `fixture_files` against the working tree. A difference is a `REVIEW REQUIRED` line; a missing Launcher checkout is `NOT CHECKED`, which does not fail. It compares hashes only: it never looks at a picture. 3. Made detached worktrees of main (`git fetch forge main`, `git worktree add --detach <dir> <commit>`) at `597c5a4e0` and `c14641a6f`, and of `b50f49771`, `67efc4d3e` and `7fd3e2ace`, and ran the check in each: the table below. 4. Read what changed in the seven files since `b50f49771` (`git diff b50f49771 597c5a4e0 -- <the seven files>`): #1309 in `vk_internal.h` (`#include "device_policy.h"`; `Device` gets `driver`, `facts`, `policy`; a comment loses a switch name) and `vk_reflex.h` (a comment); #1362 in `vk_internal.h` (`swap_slots`, `kPresentSlotsMax`, `present_slots_for`), `vk_menu.cpp` (the `hn_pace` hint strings) and `menu_i18n.h` (those strings' translations); #1464 in `vk_framegen.h` (`framegen_hud_before`), `vk_fsr3fi.h` (a `hud_mask` member) and `vk_texture.h` (`texture_alive`): declarations and comments, which the menu fixture neither calls nor draws. `hn_pace` belongs to the Frame pacing row, which is declared with `TAB_DEBUG` (`vk_menu.cpp` line 1777): not a row of the Graphics tab this picture shows. What the check said on each commit (`python3 -I -B scripts/check_guide_screenshots.py --review-sources`, seven worktrees): | Commit | what it is | check, exit | `REVIEW REQUIRED` lines | |---|---|---|---| | `b50f49771` | #1383, the last review (before #1309) | 0 | none | | `67efc4d3e` | #1309 | 1 | `vk_internal.h`, `vk_reflex.h` | | `7fd3e2ace` | #1277, the merge the picture was captured for | 0 | none | | `c14641a6f` | main after #1362 and #1359 | 1 | `menu_i18n.h`, `vk_internal.h`, `vk_menu.cpp`, `vk_reflex.h` | | `597c5a4e0` | main after #1464 | 1 | `menu_i18n.h`, `vk_framegen.h`, `vk_fsr3fi.h`, `vk_internal.h`, `vk_menu.cpp`, `vk_reflex.h`, `vk_texture.h` | | `dcb7b47c2` | main now (#1454 and #718 on top) | 1 | the same seven | | `9fd31222d` | this PR, on `dcb7b47c2` (`27a147927` on `597c5a4e0` gave the same) | 0 | none | ### 3. The renders: the project's UI-only capture helper The helper is `scripts/screenshots/capture_menu.py`, with the fixture `scripts/screenshots/menu.cpp` (both on the forge; the guide README's "UI-only settings fixture" describes them). It compiles the real `gpu/vk/vk_menu.cpp`, the translation code and the bundled Dear ImGui against the fixture, calls the menu's draw function with fixed illustrative settings, and writes the result with SDL2's software renderer: 1280x720, Medium menu scale, English, the bundled Libertinus fonts over a solid RGB 16,18,21 background, explicit 16:9, the compiled `Options` defaults, no GPU capabilities, no saved options, no game; the environment has every `HOS_*`, `RX_*` and `LONGSHOT_*` variable removed and `HOS_DISPLAY_MODES=1280x720`, and it runs in an empty temporary folder. It refuses a source with uncommitted capture inputs. The banner's text is `git describe` of the source plus " (UI fixture)", from `-DLONGSHOT_VERSION`. I ran main's copy of the helper, so the fixture is the same for every render and only the source differs: ```sh python -I scripts/screenshots/capture_menu.py --source <worktree of the commit> --vulkan-headers /usr/include --output <new folder> ``` once each for `b50f49771`, `67efc4d3e`, `c14641a6f`, `597c5a4e0` and `7fd3e2ace`, and once more for `c14641a6f` into a second folder: the second render's three PNGs (Graphics, Audio, Controls) and `menu-capture.json` are byte for byte equal to the first's, so a render is repeatable on this PC. The image's recorded capture source, `54d25c79`, is no longer on the forge (#1277's head moved: the pull request's head is `c0dfffe73` now), so the comparison base is the last commit the check passed on; `7fd3e2ace`, #1277's squash on main, stands in for the capture source below. ### 4. The comparison: every number from the files I compared the renders with a small script (PIL and NumPy only for decoding and counting; it is attached below): for each pair, the number of pixels where any channel differs, the largest channel difference, and the bounding box of those pixels. Where a pair differs in several places (the published PNG against a render), I grouped the differing pixels into boxes of 8 by 8 pixel blocks within two blocks of each other with a longer version of the same script, to say where. <details><summary>compare_renders.py</summary> ```python import sys import numpy as np from PIL import Image def load(path): im = Image.open(path).convert('RGB') assert im.size == (1280, 720) return np.asarray(im).astype(np.int16) a, b = load(sys.argv[1]), load(sys.argv[2]) d = np.abs(a - b).max(axis=2) ys, xs = np.nonzero(d) print(f'{len(ys)} of {d.size} pixels differ, largest channel difference {d.max()}') if len(ys): print(f'bounding box x {xs.min()}..{xs.max()}, y {ys.min()}..{ys.max()}') ``` </details> Results (all pairs rendered on this PC with main's helper; PNG sha256: `b50f49771` 94a3b352…, `67efc4d3e` cf24f221…, `c14641a6f` 2e25da3d…, `597c5a4e0` a7d8f675…, `7fd3e2ace` 6268e1f0…, published 3531f6ab…): | pair | differing pixels | where | |---|---|---| | `b50f49771` and `597c5a4e0` | 976 of 921,600 | x 126..260, y 25..38: the banner's version text; nothing else | | `b50f49771` and `67efc4d3e` (#1309 alone) | 1,248 | x 72..260, y 25..38: the same text (its describe string is `nightly-407-67efc4d3`, shown as "Nightly 407 · 67efc4d3") | | `67efc4d3e` and `c14641a6f` (#1362 and #1359) | 1,203 | the same text | | `c14641a6f` and `597c5a4e0` (#1464) | 425 | x 189..260, y 25..35: the same text | | `b50f49771` and `c14641a6f` | 986 | x 126..260, y 25..38: the same text | | `7fd3e2ace` (#1277) and `597c5a4e0` | 919 | the same text | | published PNG and the `597c5a4e0` render | 60,454 | row borders and glyph edges, the help panel, the footer's prompts, the banner | | published PNG and the `7fd3e2ace` render | 60,473 | the same places | The last two rows are why the comparison is between renders. The PNG on main differs from a render of #1277's own merge commit on this PC's toolchain in 60,473 pixels (the rows and the help are drawn a pixel differently; the labels, values and layout read the same), so a render of any commit differs from the PNG by about as much, and that difference is not from #1309, #1362 or #1464. I did not find the cause by experiment: the toolchain here differs from the recorded one in the compiler, in SDL2 (an sdl2-compat on SDL3 against 2.32.10) and in libpng, and I have not rendered with the recorded versions. It is labelled as inferred. **Looking at the pictures.** I opened each render at full size (`b50f49771`, `67efc4d3e`, `c14641a6f`, `597c5a4e0`, `7fd3e2ace`) and the published PNG, and compared them with the pixel boxes above: tabs Graphics, Audio, Gameplay, Controls, Debug; Quality preset selected on Custom; the rows Aspect ratio (16:9 or Monitor's shape), Output resolution 2048x1152 (reduced), Custom output size None, Profile (Docked or Handheld), Upscaler Game's own, Render resolution Auto (dynamic), Sharpness 0%, then "Frame generation and latency": Frame generation Off, Game frame rate cap 60 (the console's); the help panel "Quality preset: Sets the scaling rows and Shadow resolution for a GPU with that much memory. The Upscaler and Frame generation stay yours." with its note; and the prompts Choose, Change, Compact (RShift), Tabs (Q E) and Close (Esc). They are the same in all of them, and they are what the guide's alt text names ("Quality preset selected, setting rows on the left, help on the right, and keyboard navigation along the bottom"). Only the banner's version text differs. ### 5. Advancing the record 1. The helper writes `menu-capture.json` with `source_files`: the repository files the compiler used for that render (`-MM`) plus the Libertinus fonts, each with its SHA-256. For `597c5a4e0` that is 77 files: the 67 of the old record and ten more; #1464 adds none. 2. A small script of mine copied the new list into `reviewed_source.files` (asserting that each hash equals the file's own SHA-256 and that the manifest is in `json.dumps(indent=2)` form, so nothing else moves) and set `revision` to the SHA-256 of the sorted `path=hash` lines, each with a final newline, as the README says. I checked the formula first: applied to the old 67 entries it gives exactly the recorded `sha256:275a1444…`. 3. The seven changed files and the ten added ones are exactly the sets the comparison of the helper's lists gives: `b50f49771` to `67efc4d3e`: `vk_internal.h`, `vk_reflex.h` changed, the ten added; `67efc4d3e` to `c14641a6f`: `menu_i18n.h`, `vk_internal.h`, `vk_menu.cpp` changed, none added; `c14641a6f` to `597c5a4e0`: `vk_framegen.h`, `vk_fsr3fi.h`, `vk_texture.h` changed, none added. 4. Wrote the note in `source-review-fullscreen-monitor.md` in the form of its earlier sections, dated. 5. Committed as the user with the two assistance trailers (`git interpret-trailers --parse` lists both). ### 6. The checks after the change - `python3 -I -B scripts/check_guide_screenshots.py --review-sources` on `27a147927` (on `597c5a4e0`) and on `9fd31222d` (on `dcb7b47c2`): exit 0 both times (lines above). - `tests/test_guide_screenshots.py` (14 tests) and `tests/test_launcher_capture.py` (4 tests), through the workbench's idle gate (a wrapper that runs CPU-only jobs in the idle scheduling class, in one of three test slots, behind any timing hold; https://github.com/mooki000/ls-workbench): both `OK`. - The whole suite, `python -I -B tests/run_all.py --jobs 8 --junit <file>`, through the same gate, in a worktree of this PR on `597c5a4e0` and in one of main `597c5a4e0`: 614 passed, 30 failed, 82 skipped on each (108 s and 132 s); the same 30 fail on both by name (below). The 82 skipped are the same on both: 65 need the Vulkan headers or the SPIR-V headers, which this run's tool search did not find (it prints "not found here: vulkan_headers" and "not found here: spirv_headers"); the rest need Windows, the game's dump or a GPU. I compared the two JUnit files by test name: no test changed status. Not rerun after the later rebases (patch identical, no recorded input in main's new commits). - `python -I -B scripts/check_pr_description.py --file <this body> --diff <git diff --src-prefix=a/ --dst-prefix=b/ main..HEAD> --title <title>`: run on this text (result under "Testing"). The 30 failures on both (main `597c5a4e0` and this PR on it), named: `test_bug_report_defaults`, `test_cpu_report`, `test_crt_options`, `test_damage_debug_menu`, `test_display_startup_failure`, `test_dlss_feature_size`, `test_failed_compile_keeps_objects`, `test_framegen_preset`, `test_guest_imported`, `test_hud_layout_row`, `test_invalidate_vcore`, `test_linux_preflight`, `test_linux_pressure`, `test_linux_update`, `test_mirror_budget`, `test_missing_nup`, `test_mods_size_table`, `test_pending_guest_import`, `test_pipeline_play_cache`, `test_present_thread`, `test_profiling_mode`, `test_readback_timeout_source`, `test_rumble_menu`, `test_run_all_changed`, `test_slow_frames`, `test_target_image_pool`, `test_upscaler_round_trip`, `test_upscaler_rows`, `test_vcore_escape`, `test_walk_key`. None was looked into: a change of one JSON file and one Markdown file cannot reach them, and they fail on main the same way. ### 7. Overlaps, and the tracker - The tracker: searched as said under Why. - Overlaps: the 338 open pull requests' file lists (the forge's `pulls/N/files`, 50 a page) were scanned for the guide's files (`docs/images/guide/*`, the checker, the workflow, the capture helper and fixture) and for the four headers changed when the scan was made (#1309's and #1362's). Of those that carry a guide edit, I fetched the heads (`git fetch forge +refs/pull/N/head:refs/remotes/pr/N`) and ran `git merge-tree --write-tree --name-only` of each head against forge main and against this branch; the trial merges of the five of ours were repeated on this head; the result and what it means is under Overlaps. One pull request, #768, returned no file list on the first pass; its diff holds none of those files. ### 8. How to rerun it ```sh git fetch forge main git worktree add --detach ../ls-main 597c5a4e0 git worktree add --detach ../ls-before b50f49771 python -I scripts/screenshots/capture_menu.py --source ../ls-before --vulkan-headers /usr/include --output /tmp/render-before python -I scripts/screenshots/capture_menu.py --source ../ls-main --vulkan-headers /usr/include --output /tmp/render-main python compare_renders.py /tmp/render-before/settings-graphics.png /tmp/render-main/settings-graphics.png python -I -B scripts/check_guide_screenshots.py --review-sources python -I -B tests/test_guide_screenshots.py && python -I -B tests/test_launcher_capture.py ``` (`capture_menu.py` is run from the checkout that has this PR, so the fixture is the same for both renders; it needs a C++20 compiler, pkg-config, SDL2 and libpng development files and the Vulkan headers.) ### 9. What was not tested See "Not tested" under Testing. ## Testing **Tested:** on Linux x86-64 (kernel 7.2.15), clang 23.1.3, SDL2 2.32.74 (sdl2-compat), libpng 1.6.59, no GPU, on 17 Nov 2026, base main `dcb7b47c2`, head `9fd31222d`. For this docs-only change "tested on my own PC" is the checks I ran, and they are these: the Guide images check on seven commits (main fails with 7 lines, this PR passes); the capture helper's renders from `b50f49771`, `67efc4d3e`, `c14641a6f`, `597c5a4e0` and `7fd3e2ace`, compared by pixel and looked at; `tests/test_guide_screenshots.py` (14) and `tests/test_launcher_capture.py` (4) pass; the whole `tests/run_all.py` on this PR and on main, both on `597c5a4e0`: 614 passed, 30 failed, 82 skipped on both, the same 30 by name (listed above; none is this PR's). `check_pr_description.py --file <this body> --diff <the diff>`: passes (run on the final text, with the checker of `dcb7b47c2`, before the handover). **History:** the commit was first made on `c14641a6f` (`9db835e58`, four inputs), rebased onto `7bb06359c` (`7586502e3`, patch identical; #1453 touches no recorded input), then onto `597c5a4e0`, where #1464 changed three more recorded inputs: the review was extended (a render of `597c5a4e0`, its comparison, three more hashes, the note) and the commit amended into `27a147927`. Last, rebased onto `dcb7b47c2` (#1454 and #718: neither touches a recorded input or a guide file): head `9fd31222d`, patch identical to `27a147927` (`git range-diff` `=`). Rerun there: the check (exit 0; on main `dcb7b47c2` it still says the same 7 lines) and the two guide tests (14 and 4 OK). Carried, not rerun: the renders, the pixel comparisons and the whole suite (from `597c5a4e0`). Windows: not applicable. Game: not applicable (docs only). **Not tested:** the website build and `website/tests/guide-screenshots.test.ts` (the site's packages are not installed on this PC; the PNG is unchanged, so what the site copies is unchanged); Windows and Intel (the picture is the UI-only fixture, not a live Vulkan frame, as its caption says; the Windows-target syntax check does not apply: no C or C++, Python or workflow file changes); a render with the toolchain recorded for the PNG (clang 23.1.6, SDL2 2.32.10, libpng 1.6.57); rows below the first Graphics view and the other tabs (the picture does not show them, and this review does not look at them); no game was run, none is needed for a record and a note. **Must be tested:** - Any PC with a browser, by hand: build and open the Settings page as `website/README.md` says, at desktop width and at 360 to 390 px, in both themes, expecting the Graphics picture to load from the site's own files with its caption "development build 54d25c79" unchanged and readable (by hand: look at the picture and its caption, as the guide README's "Completing a refresh" asks; nothing about the picture changed, so this is the README's standing step, not a new risk). - A maintainer, by hand: look at `GuideFix-graphics-renders.jpg` above and say whether "only the version text differs" is a retention you accept, expecting a yes or a recapture request (a person; the README says a hash match is not a visual review). ## Risks **What could break:** nothing at run time: a JSON record and a Markdown file. The one way to be wrong is the retention itself: if a reader sees a difference I did not (I compared every pixel of the first Graphics view between four commits, and read the rows), the guide would show a stale picture; the answer then is a recapture, which the README describes. A second, smaller one: the list now has 77 files, so a change to any of the ten new headers asks for a review again, as the other 67 do. **Costs:** none that I know of: nothing the game runs changes, so no speed, latency, memory or setup is affected, and nothing was measured because there is nothing to measure. **Turning it off:** revert the commit; the check is red again on main, as now. **Compatibility:** Nothing changes for a player or for the website: the PNG, its hash, its alt text and its caption are the same. ## Overlaps From a scan of the file lists of the 338 open pull requests, then a trial merge (`git merge-tree --write-tree --name-only`) of each head that edits the guide's manifest against main and against this branch (the five of ours repeated on this commit before the last rebase, which did not change the patch), reading the conflict hunks (only a conflict that shows with this branch and not with main is an overlap): | Pull request | its guide commit | with this branch | |---|---|---| | #1358 (ours), #1411 (ours), #1426 (ours) | last commit of each head (`9872740e8`, `92a6c5950`, `4221dd097`): the same kind of commit as this one (hashes and a "Retention after" section) | each merges with main alone; with this branch the two files of its docs commit conflict. Read for #1426: in `manifest.json` the `revision` line and the lines of `vk_internal.h`, `vk_menu.cpp` and `vk_menu.h` (the same entry), in the note file both add a section at the end; the other two conflict in the same two files | | #61 and #562 (ours; their rebased branches with a docs commit are local so far: `c80312e60`, `8b3a36cc4`) | a docs commit each, the same kind | the same two files conflict | | #68 (ours, co-op) | recaptures the picture (a sixth tab) and has its own manifest entry | `manifest.json` conflicts with this branch and not with main: it replaces the whole entry, so it takes its own on rebase | | #1408 (ours), #1372, #1125, #405 | edit the manifest | conflict with main already, in the same files, and the same list of files with this branch (hunks not read: the conflict exists on main): not an overlap of this PR | Once this merges, the five docs commits of #1358, #1411, #1426, #61 and #562 are redone on top of it, and each loses the part that covers main's changes (the seven hashes of #1309, #1362 and #1464 and the ten new headers). They do not disappear: each of the five changes recorded inputs of its own, so the check on each head minus its docs commit, merged onto this branch, still asks for: #1358 `fps_stats.h`, `vk_api.h`, `vk_menu.cpp`, `vk_menu.h`; #1411 `oot_cheat_items.h`, `vk_api.h`, `vk_menu.cpp`; #1426 `vk_api.h`, `vk_menu.cpp`, `vk_menu.h`; #61 `menu_i18n.h`, `vk_api.h`, `vk_menu.cpp`, `vk_menu.h`; #562 `fps_stats.h`, `menu_i18n.h`, `vk_menu.cpp`, `vk_menu.h` (checked by extracting each merge's tree and running the checker on it). This PR touches none of the five. ## Questions for you The recurring cost is that the check goes red on every API bump or policy header change whose picture is unchanged: since 15 Nov (#264, `d7aeaa269`) 240 commits reached main, 56 of them changed one of the files the check records, and the review each time is "render both, look, they differ only in the version text" (this PR; #1144; the five of ours). Two ways to cut it, as questions: 1. **Should the comparison mask the build's version text (or the helper capture with a fixed version string)?** A compare step next to the helper (render two revisions, ignore the banner's version box, exit 1 on any other pixel), or a fixed `-DLONGSHOT_VERSION` so that unchanged UI gives a byte-identical PNG on one toolchain, would turn today's look into a command that an author, a reviewer or a CI job runs, and the review note could quote its output. *It would catch:* any change in the first Graphics view (a row, a value, a help sentence, the prompts, the layout) between two revisions on the same toolchain. *It would not:* stop the check going red, because the checker compares file hashes and never looks at a picture (the CI runner has no compiler, SDL2 or libpng, and the workflow says it does not build the fixture): by itself it makes each review cheaper, not rarer; see anything the first view does not show (rows below it, other tabs, a help text of a row that is not selected: #1362's change is of that kind); work against the published PNG (a render here differs from it in about 60,000 pixels on another toolchain, so it has to be two renders on one toolchain); or notice a real change in the masked box (a longer version string that overflows the banner). A fixed version string also means the banner stops naming a build, so the PNG and its caption "development build 54d25c79" need one recapture. 2. **Should headers that hold no menu layout leave the Graphics image's reviewed sources, `gpu/vk/vk_api.h` first, or should the list be the menu's own files only?** The ten I mean by "the menu's own files" are, in `gpu/vk/`: `vk_menu.cpp`, `vk_menu.h` (it holds `Options` and its defaults), `menu_i18n.h`, `vk_menu_i18n.cpp`, `vk_menu_i18n.h`, `vk_menu_hit.h`, `menu_restart.h`, `upscaler_rows.h`, `display_modes.h` and `monitor_choice.h`; it is my reading, a starting list, not a decision. Of the 56 commits above, 28 changed none of them; `vk_api.h` is in 13 (every ABI bump; two of the 13 changed nothing else the check records), `vk_internal.h` in 16, and five of today's seven red lines (`vk_internal.h`, `vk_reflex.h`, `vk_framegen.h`, `vk_fsr3fi.h`, `vk_texture.h`) are headers that draw nothing. *It would catch:* every change to the files that define the rows, labels, hints, defaults and layout, which is where a picture goes stale, and it would stop the check going red for the other 28. *It would not:* catch a change in a dropped header that alters what the menu draws without touching the menu's files: `vk_menu.cpp` uses types and constants from `vk_api.h` (`MkwVkMonitor`, `MkwVkSetting`, `MkwVkPointer`, `HOS_TEXT_KEY`), so a changed field or key constant there could change a row with no hash asking; it needs someone to own the line between "draws" and "does not draw" and revisit it when a dependency arrives, where the helper's compiler-derived list is complete by construction; and it would still ask for a review when a menu file only changes another tab's text (as #1362 did on the Debug tab). The two combine: (2) makes the check ask less often, (1) makes each remaining review a command. This PR only restores the record; neither change is in it. ## Issues See #1144 (closed, superseded) and #1383, which kept this record green until #1309. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. (Docs only, nothing the game runs: the checks I ran are what Testing's Tested says.) - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. (Nothing the game runs changes; Risks says so.) - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. (Based on `dcb7b47c2`, forge main when this was written.) - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). (614 passed, 30 failed, 82 skipped here and on main, both on `597c5a4e0`; the same 30 fail on both, named under How it was tested, 6.) - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Screenshots of the same spot, captioned like the Measurements columns, for a change that shows on screen. (The two pictures above: the same view rendered from `b50f49771` and from `597c5a4e0`; the change itself is a record and shows nothing on screen.) - [x] Docs updated. New on this forge; not opened on GitHub.
docs(guide): the Graphics guide image is retained after #1309, #1362 and #1464
All checks were successful
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 13s
CI / Workflow lint (actionlint) (pull_request) Successful in 25s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 27s
Website / Website on Cloudflare (pull_request_target) Has been skipped
Third-party parts / As their notes say (pull_request) Successful in 43s
PR description / Description follows the template (pull_request_target) Successful in 3s
9fd31222df
scripts/check_guide_screenshots.py --review-sources failed on main (7 REVIEW REQUIRED lines): the reviewed inputs vk_internal.h and
vk_reflex.h changed in #1309; vk_internal.h, vk_menu.cpp and menu_i18n.h in #1362; vk_framegen.h, vk_fsr3fi.h and vk_texture.h in
#1464. The maintained helper (scripts/screenshots/capture_menu.py) rendered the Graphics view from b50f49771 (the last commit the
check passed on), from 67efc4d3e (#1309), from c14641a6f (#1362) and from main 597c5a4e0 (#1464): the renderings differ only in the
banner's version text, so the image is retained and not recaptured. manifest.json: the reviewed hashes of settings-graphics.png
advance, the review revision (sha256 of the sorted file=hash lines) with them, and the file list gains the ten headers
device_policy.h brings in; source-review-fullscreen-monitor.md records the review. The PNG, its capture revision and the fixture are
unchanged.

Assisted-by: Claude Sonnet 5.5
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
mooki changed title from WIP: docs(guide): the Graphics guide image is retained after #1309, #1362 and #1464 to docs(guide): the Graphics guide image is retained after #1309, #1362 and #1464 2026-11-17 20:15:27 +00:00
Collaborator

Possibly related, for context:

  • PR #1408 feat(vk): bug reports and the log say where Link stands (map, x y z, facing, age, time of day) — Also updates the Graphics-image review record in manifest.json, so the changes may conflict.
Possibly related, for context: - PR #1408 feat(vk): bug reports and the log say where Link stands (map, x y z, facing, age, time of day) — Also updates the Graphics-image review record in manifest.json, so the changes may conflict.
llun approved these changes 2026-11-17 21:18:53 +00:00
llun merged commit 415a8944c3 into main 2026-11-17 21:19:06 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1466
No description provided.