test(release): run_all finds openssl (Git for Windows' own too) and skips test_release without one #144

Open

d4nkn3ss wants to merge 1 commit from d4nkn3ss/Longshot:fix/run-all-openssl into main

pull from: d4nkn3ss/Longshot:fix/run-all-openssl

merge into: MagicBeanDev:main

MagicBeanDev:main

Conversation 0 Commits 1 Files changed 4 +32 -6

d4nkn3ss commented 2026-11-13 06:34:02 +00:00

Contributor

• Copy link
• Copy Markdown

Why

On Windows, tests/test_release.py errors from PowerShell or cmd ("the openssl command line is needed") instead of being skipped, because openssl is on PATH only inside Git Bash. Every other check whose tool is missing is skipped and says so.

What changed

• tests: tests/run_all.py's find_tools() gains openssl: on PATH, else Git for Windows' own usr\bin\openssl.exe next to the git on PATH (git_openssl()), which every Windows checkout has.
• tests: tests/test_release.py declares RUN_ALL_ARGS = ["--openssl", "{openssl}"], and with --openssl puts that folder first on PATH for release.py's openssl calls; with none found, run_all skips it ("not found here: openssl").
• tests: tests/test_run_all_declarations.py's TOOLS gains openssl (it checks the set matches find_tools()).
• docs: the tool list in CONTRIBUTING.md and run_all.py's docstring.

Flags and settings

None

Measurements

main: e28236b4 (2026-11-12)
this PR: fix/run-all-openssl @ 33dbc033
Hardware: Windows 11, Python 3.12 from python.org, Git for Windows 2.56.1; PowerShell (openssl not on PATH)
Scene: n/a (game-free)
Method: python -I -B tests/run_all.py test_release from PowerShell on both sides, and once with Git off PATH
How to reproduce: on Windows, from PowerShell, python -I -B tests/run_all.py test_release

	main @ e28236b4	this PR @ 33dbc033
test_release's key tests (Keys), openssl not on PATH	3 ERROR: "the openssl command line is needed"	run (Git's openssl) and pass
test_release with no openssl at all (Git off PATH)	errors	skipped: "not found here: openssl"
tests/run_all.py run_all (the runner's own tests)	3 passed	3 passed

Testing

Tested: the rows above on Windows 11.

Full suite: python -I -B tests/run_all.py on this branch @ 33dbc033: 500 passed, 3 failed, 35 skipped, the same three as main @ e28236b4: tests/test_check_third_party.py (#80), tests/test_setup_runtime.py (#118) and tests/test_release.py, whose two remaining failures are #119 (the SHA256SUMS fixture) and #145 (the git-cliff stand-in).

Not tested: Linux: openssl is on PATH there, so which("openssl") finds it as before and git_openssl() isn't reached.

Needs other testers: None

Screenshots

Nothing on screen

Risk and rollback

Tests only; reverting the commit is enough.

Issues

None

Checklist

For everyone

• One topic.
• The title is a Conventional Commit (type(scope): description).
• Rebased on current main.
• python -I -B tests/run_all.py run and passing (any failure that also fails on main is named above).
• Tested in the game, or what wasn't is named under Testing. (Test-only change: nothing in the game.)
• Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests).
• Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported. (A test result: the same on every run.)
• No game files, dumps, build output or generated files.
• third_party/ untouched (a new folder with a PROVENANCE.md instead).
• The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

If applicable

• AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
• A check under tests/ that reads changed source updated in this PR, not weakened.
• Docs updated.

🤖 Generated with Claude Code

## Why On Windows, `tests/test_release.py` errors from PowerShell or cmd ("the openssl command line is needed") instead of being skipped, because `openssl` is on PATH only inside Git Bash. Every other check whose tool is missing is skipped and says so. ## What changed - tests: `tests/run_all.py`'s `find_tools()` gains `openssl`: on PATH, else Git for Windows' own `usr\bin\openssl.exe` next to the git on PATH (`git_openssl()`), which every Windows checkout has. - tests: `tests/test_release.py` declares `RUN_ALL_ARGS = ["--openssl", "{openssl}"]`, and with `--openssl` puts that folder first on PATH for `release.py`'s `openssl` calls; with none found, `run_all` skips it ("not found here: openssl"). - tests: `tests/test_run_all_declarations.py`'s `TOOLS` gains `openssl` (it checks the set matches `find_tools()`). - docs: the tool list in `CONTRIBUTING.md` and `run_all.py`'s docstring. ## Flags and settings None ## Measurements main: e28236b4 (2026-11-12) this PR: fix/run-all-openssl @ 33dbc033 Hardware: Windows 11, Python 3.12 from python.org, Git for Windows 2.56.1; PowerShell (openssl not on PATH) Scene: n/a (game-free) Method: `python -I -B tests/run_all.py test_release` from PowerShell on both sides, and once with Git off PATH How to reproduce: on Windows, from PowerShell, `python -I -B tests/run_all.py test_release` | | main @ e28236b4 | this PR @ 33dbc033 | |---|---|---| | `test_release`'s key tests (`Keys`), openssl not on PATH | 3 ERROR: "the openssl command line is needed" | run (Git's openssl) and pass | | `test_release` with no openssl at all (Git off PATH) | errors | skipped: "not found here: openssl" | | `tests/run_all.py run_all` (the runner's own tests) | 3 passed | 3 passed | ## Testing **Tested:** the rows above on Windows 11. **Full suite:** `python -I -B tests/run_all.py` on this branch @ 33dbc033: 500 passed, 3 failed, 35 skipped, the same three as main @ e28236b4: `tests/test_check_third_party.py` (#80), `tests/test_setup_runtime.py` (#118) and `tests/test_release.py`, whose two remaining failures are #119 (the SHA256SUMS fixture) and #145 (the git-cliff stand-in). **Not tested:** Linux: `openssl` is on PATH there, so `which("openssl")` finds it as before and `git_openssl()` isn't reached. **Needs other testers:** None ## Screenshots Nothing on screen ## Risk and rollback Tests only; reverting the commit is enough. ## Issues None ## Checklist ### For everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`). - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` run and passing (any failure that also fails on `main` is named above). - [x] Tested in the game, or what wasn't is named under Testing. (Test-only change: nothing in the game.) - [x] Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests). - [x] Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported. (A test result: the same on every run.) - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### If applicable - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Docs updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

d4nkn3ss referenced this pull request 2026-11-13 06:34:16 +00:00

test(release): the git-cliff stand-in is a .cmd on Windows, which can start it #145

d4nkn3ss referenced this pull request 2026-11-13 07:24:12 +00:00

fix(release): the Windows zip carries tools/version.txt, so a release's game and builder know their version #149

d4nkn3ss referenced this pull request 2026-11-13 07:30:02 +00:00

fix(setup): the setup copies the Builder from a zip unpacked deeper than MAX_PATH #151

d4nkn3ss referenced this pull request 2026-11-13 07:51:20 +00:00

docs(design): fog and exposure use the game's own values; the removed OoT factors are no longer needed #159

d4nkn3ss force-pushed fix/run-all-openssl from 33dbc03343 to d7f50a4f5b 2026-11-13 08:35:05 +00:00 Compare

HumanBean referenced this pull request from a commit 2026-11-13 09:06:04 +00:00

fix(release): the Windows zip carries tools/version.txt, so a release's game and builder know their version (#149)

d4nkn3ss referenced this pull request 2026-11-13 11:00:25 +00:00

fix(vk): Auto (this PC) reads the primary monitor when there's no window, so an update no longer lowers the resolution #176

d4nkn3ss referenced this pull request 2026-11-13 11:05:08 +00:00

test(builder): the DLSS update fixture no longer requires the removed self-update's download to be cleared #179

HumanBean referenced this pull request from a commit 2026-11-13 11:09:25 +00:00

fix(vk): Auto (this PC) reads the primary monitor when there's no window, so an update no longer lowers the resolution (#176)

HumanBean referenced this pull request from a commit 2026-11-13 11:10:00 +00:00

test(builder): the DLSS update fixture no longer requires the removed self-update's download to be cleared (#179)

d4nkn3ss referenced this pull request 2026-11-13 12:35:39 +00:00

test(input): the display-pointer fixture defines rx_option, which mouse_capture now asks (#178) #187

d4nkn3ss referenced this pull request 2026-11-13 13:09:59 +00:00

test(vk): the texture-staging fixture defines logf_at and LogLevel, which the cut code now calls #195

HumanBean referenced this pull request from a commit 2026-11-13 16:38:19 +00:00

test(input): the display-pointer fixture defines rx_option, which mouse_capture now asks (#178) (#187)

HumanBean referenced this pull request from a commit 2026-11-13 17:01:43 +00:00

docs(design): fog and exposure use the game's own values; the removed OoT factors are no longer needed (#159)

Some checks are pending

Hide checks

CI / Conventional Commit title (pull_request) Blocked by required conditions

Details

CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions

Details

CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions

Details

CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions

Details

CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions

Details

Third-party parts / As their notes say (pull_request) Blocked by required conditions

Details

Third-party parts / The same as upstream (pull_request) Blocked by required conditions

Details

Website / Website on Cloudflare (pull_request) Blocked by required conditions

Details

PR description / Description follows the template (pull_request_target) Successful in 10s

Details

This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.

Some workflows are waiting to be reviewed.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u 'fix/run-all-openssl:d4nkn3ss-fix/run-all-openssl'

git switch 'd4nkn3ss-fix/run-all-openssl'

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area/accessibility

Barriers for people with disabilities

  

area/audio

Sound and music

  

area/input

Controllers, keyboard, mouse

  

area/install

Installing, updating, building from your game

  

area/menu

In-game menu and settings

  

area/renderer

Vulkan renderer, shaders, effects

  

area/saves

Save files

  

area/upscaling

DLSS, FSR, frame generation

  

good first issue

A good start for a new contributor

  

gpu/amd

AMD GPUs

  

gpu/igpu

Integrated GPUs

  

gpu/intel

Intel GPUs

  

gpu/nvidia

NVIDIA GPUs

  

help wanted

Extra hands or knowledge wanted

  

kind

bug

Something doesn't work as it should

  

kind

chore

Build, CI, dependencies, tidying

  

kind

docs

Documentation

  

kind

feature

A new feature or an improvement

  

kind

performance

Frame rate, frame time, loading, memory

  

kind

question

A question rather than a change

  

needs measurements

Waiting for before/after measurements

  

platform/linux

Linux only

  

platform/steam-deck

Steam Deck

  

platform/windows

Windows only

  

preview

Maintainers: deploy a preview of this PR's website (read its changes first). Removed after the run.

  

priority

critical

Crashes, data loss, or blocks most players

  

priority

high

Important: next in line

  

priority

low

Nice to have

  

status

blocked

Waits on something else first

  

status

confirmed

Reproduced or agreed on

  

status

duplicate

Already reported or proposed

  

status

invalid

Not a problem in this project

  

status

needs-info

Waiting for more information from the reporter

  

status

wontfix

Will not be worked on

  

testing wanted

Wanted: a test on other hardware (posts a test request in #test-requests)

No labels

area/accessibility

area/audio

area/input

area/install

area/menu

area/renderer

area/saves

area/upscaling

good first issue

gpu/amd

gpu/igpu

gpu/intel

gpu/nvidia

help wanted

kind

bug

kind

chore

kind

docs

kind

feature

kind

performance

kind

question

needs measurements

platform/linux

platform/steam-deck

platform/windows

preview

priority

critical

priority

high

priority

low

status

blocked

status

confirmed

status

duplicate

status

invalid

status

needs-info

status

wontfix

testing wanted

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

MagicBeanDev/Longshot!144

No description provided.