test(builder): the DLSS update fixture no longer requires the removed self-update's download to be cleared

d4nkn3ss commented

2026-11-13 11:05:08 +00:00

Contributor

Why

tests/test_builder_dlss_update.py fails on main on Windows (Linux skips it), so the check of the Windows Builder's update decision (DLSS, FSR 4, shader arguments) hasn't been guarding anything since #161.

What changed

tests: tests/builder_dlss_update_test.cs, the fixture test_builder_dlss_update.py compiles around the real UpdateBuild(), no longer starts with a download object and no longer requires UpdateBuild() to clear it. #161 removed the builder's self-update, with its download field and the download = null UpdateBuild() used to run, so the fixture's "Update setup changed." fired on every run. The keepRows check stays.

Flags and settings

None

Measurements

main: fabcd2c0 (2026-11-13)
this PR: fix/test-builder-update-fixture @ 5def3b41
Hardware: Windows 11, .NET SDK 8.0.301, Python 3.12
Scene: n/a (game-free)
Method: python -I -B tests/test_builder_dlss_update.py --dotnet <dotnet.exe> on both sides
How to reproduce: on Windows with the .NET 8 SDK, the command above

	main @ `fabcd2c0`	this PR @ `5def3b41`
`tests/test_builder_dlss_update.py`	`Unhandled exception. System.Exception: Update setup changed.` at `Window.Run` (the fixture), exit 376250453	`Builder DLSS update checks passed (63 assertions).`

Testing

Tested: the row above on Windows 11.

Full suite: python -I -B tests/run_all.py on this branch @ 5def3b41, Windows 11: 500 passed, 2 failed, 34 skipped: tests/test_check_third_party.py (#80) and tests/test_release.py (#119, #144, #145), both failing on main the same way.

Not tested: Linux and macOS: the check skips itself there (RUN_ALL_SKIP), as before.

Needs other testers: None

Screenshots

Nothing on screen

Risk and rollback

Test-only; reverting the commit is enough.

Issues

None

Checklist

For everyone

One topic.
The title is a Conventional Commit (type(scope): description).
Rebased on current main.
python -I -B tests/run_all.py run and passing (any failure that also fails on main is named above).
Tested in the game, or what wasn't is named under Testing. (Test-only change: nothing in the game.)
Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests).
Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported. (A test result: the same on every run.)
No game files, dumps, build output or generated files.
third_party/ untouched (a new folder with a PROVENANCE.md instead).
The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

If applicable

AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
A check under tests/ that reads changed source updated in this PR, not weakened.

🤖 Generated with Claude Code

## Why `tests/test_builder_dlss_update.py` fails on `main` on Windows (Linux skips it), so the check of the Windows Builder's update decision (DLSS, FSR 4, shader arguments) hasn't been guarding anything since #161. ## What changed - tests: `tests/builder_dlss_update_test.cs`, the fixture `test_builder_dlss_update.py` compiles around the real `UpdateBuild()`, no longer starts with a `download` object and no longer requires `UpdateBuild()` to clear it. #161 removed the builder's self-update, with its `download` field and the `download = null` `UpdateBuild()` used to run, so the fixture's "Update setup changed." fired on every run. The `keepRows` check stays. ## Flags and settings None ## Measurements main: fabcd2c0 (2026-11-13) this PR: fix/test-builder-update-fixture @ 5def3b41 Hardware: Windows 11, .NET SDK 8.0.301, Python 3.12 Scene: n/a (game-free) Method: `python -I -B tests/test_builder_dlss_update.py --dotnet <dotnet.exe>` on both sides How to reproduce: on Windows with the .NET 8 SDK, the command above | | main @ fabcd2c0 | this PR @ 5def3b41 | |---|---|---| | `tests/test_builder_dlss_update.py` | `Unhandled exception. System.Exception: Update setup changed.` at `Window.Run` (the fixture), exit 376250453 | `Builder DLSS update checks passed (63 assertions).` | ## Testing **Tested:** the row above on Windows 11. **Full suite:** `python -I -B tests/run_all.py` on this branch @ 5def3b41, Windows 11: 500 passed, 2 failed, 34 skipped: `tests/test_check_third_party.py` (#80) and `tests/test_release.py` (#119, #144, #145), both failing on `main` the same way. **Not tested:** Linux and macOS: the check skips itself there (`RUN_ALL_SKIP`), as before. **Needs other testers:** None ## Screenshots Nothing on screen ## Risk and rollback Test-only; reverting the commit is enough. ## Issues None ## Checklist ### For everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`). - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` run and passing (any failure that also fails on `main` is named above). - [x] Tested in the game, or what wasn't is named under Testing. (Test-only change: nothing in the game.) - [x] Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests). - [x] Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported. (A test result: the same on every run.) - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### If applicable - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

d4nkn3ss added 1 commit

2026-11-13 11:05:09 +00:00

test(builder): the DLSS update fixture no longer requires the removed self-update's download to be cleared

CI / Conventional Commit title (pull_request) Blocked by required conditions

Details

CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions

Details

CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions

Details

CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions

Details

CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions

Details

Third-party parts / As their notes say (pull_request) Blocked by required conditions

Details

Third-party parts / The same as upstream (pull_request) Blocked by required conditions

Details

PR description / Description follows the template (pull_request_target) Successful in 12s

Details

5def3b4194

#161 removed the Windows builder's self-update, with its `download` field and the `download = null` UpdateBuild used to
run, but tests/builder_dlss_update_test.cs still began with a `download` object and threw "Update setup changed." unless
UpdateBuild had cleared it, so test_builder_dlss_update failed on main (Windows only; Linux skips it). The fixture keeps
the keepRows check; its 63 assertions pass again.

Co-Authored-By: Claude Opus 5.5 <[email protected]>