fix(docs): one row a file for the tested runs of #1255 and #1256 #1378

Merged
HumanBean merged 1 commit from GummiNaomi/Longshot:fix/tested-one-row-a-file into main 2026-11-17 15:57:30 +00:00
Member

Type: fix · Risk: low · Tested on: Windows 11 (the checks; no game needed) · Needs: nothing

Why

My mistake, in #1255 and #1256: four of the files they added under docs/tested/ hold several rows (two each for the dead targets' runs, six each for the shadow-map slots' runs). A fragment is the header, the separator and exactly one row (docs/tested/README.md, #96), so since they were merged scripts/tested_configurations.py stops with

ValueError: 2026-11-16-shadow-map-slots-gumminaomi-on.md: expected the standard header, separator and exactly one row (LF)

and tests/test_tested_configurations.py fails on main for everyone. The combined catalogue is rendered by the same script. I did not see it because that test already failed on my PC for another reason (its pipe check, with Windows line endings), and I read the failure as the old one.

How to reproduce

Seen on: any OS, no GPU involved; main @ 544229a2
Settings and switches: defaults
Steps: python -I -B tests/test_tested_configurations.py, or python -I scripts/tested_configurations.py
Expected: the test passes and the script prints the catalogue
Actual: the ValueError above, from read_row

What changed

Each row of those four files is a file of its own; no row's text is changed.

  • docs: 2026-11-16-dead-targets-every-present-gumminaomi-old.md and -new.md become -old1.md, -old2.md, -new1.md, -new2.md; 2026-11-16-shadow-map-slots-gumminaomi-off.md and -on.md become -off1.md to -off6.md and -on1.md to -on6.md. Each row already names its run (prdn-..., prsl-...), so the rows stay distinguishable.

Measurements

Nothing to measure: sixteen rows moved to sixteen files.

Flags and settings

None.

Testing

Tested: Windows 11: python -I scripts/tested_configurations.py prints the catalogue with this change and raises the ValueError above on main @ 544229a2. python -I -B tests/test_tested_configurations.py: 24 of 25 pass with this change (23 on main); the one left, test_cli_ascii_pipe_emits_the_arrow_containing_source_as_utf8, fails on this PC on main too (the script's output through a pipe has Windows line endings here). python -I -B tests/run_all.py with clang here, this PR @ c6189282: 393 passed, 107 failed, 221 skipped; main @ 544229a2 in the same session: 392 passed, 108 failed, 221 skipped. Nothing fails here that does not fail on main (this PC's toolchain: no gcc, Windows line endings, fixtures needing tools not installed); the one more on main was tests/test_gpu_hang_watch.py in that run.

Not tested: Linux, where the remaining check should pass too; the website's build.

Must be tested:

  • Linux, no GPU needed: python -I -B tests/test_tested_configurations.py, expecting all 25 to pass (by hand, or the pull request's own checks: look at that test's line)

Risks

What could break: nothing I can name: no row's text changes, only which file holds it.

Turning it off: revert the commit.

Compatibility: Nothing changes. Links to the four old file names, if any exist outside the repository, stop working.

Issues

None found for this. #1255 and #1256 added the files; #96 is the rule.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A file in docs/tested/ for each new measured run (format in docs/tested-configurations.md).
  • Docs updated.

🤖 Generated with Claude Code

**Type:** fix · **Risk:** low · **Tested on:** Windows 11 (the checks; no game needed) · **Needs:** nothing ## Why My mistake, in #1255 and #1256: four of the files they added under `docs/tested/` hold several rows (two each for the dead targets' runs, six each for the shadow-map slots' runs). A fragment is the header, the separator and exactly one row (`docs/tested/README.md`, #96), so since they were merged `scripts/tested_configurations.py` stops with ``` ValueError: 2026-11-16-shadow-map-slots-gumminaomi-on.md: expected the standard header, separator and exactly one row (LF) ``` and `tests/test_tested_configurations.py` fails on main for everyone. The combined catalogue is rendered by the same script. I did not see it because that test already failed on my PC for another reason (its pipe check, with Windows line endings), and I read the failure as the old one. ## How to reproduce **Seen on:** any OS, no GPU involved; main @ 544229a2 **Settings and switches:** defaults **Steps:** `python -I -B tests/test_tested_configurations.py`, or `python -I scripts/tested_configurations.py` **Expected:** the test passes and the script prints the catalogue **Actual:** the `ValueError` above, from `read_row` ## What changed Each row of those four files is a file of its own; no row's text is changed. - docs: `2026-11-16-dead-targets-every-present-gumminaomi-old.md` and `-new.md` become `-old1.md`, `-old2.md`, `-new1.md`, `-new2.md`; `2026-11-16-shadow-map-slots-gumminaomi-off.md` and `-on.md` become `-off1.md` to `-off6.md` and `-on1.md` to `-on6.md`. Each row already names its run (`prdn-...`, `prsl-...`), so the rows stay distinguishable. ## Measurements Nothing to measure: sixteen rows moved to sixteen files. ### Flags and settings None. ## Testing **Tested:** Windows 11: `python -I scripts/tested_configurations.py` prints the catalogue with this change and raises the `ValueError` above on main @ 544229a2. `python -I -B tests/test_tested_configurations.py`: 24 of 25 pass with this change (23 on main); the one left, `test_cli_ascii_pipe_emits_the_arrow_containing_source_as_utf8`, fails on this PC on main too (the script's output through a pipe has Windows line endings here). `python -I -B tests/run_all.py` with clang here, this PR @ c6189282: 393 passed, 107 failed, 221 skipped; main @ 544229a2 in the same session: 392 passed, 108 failed, 221 skipped. Nothing fails here that does not fail on main (this PC's toolchain: no gcc, Windows line endings, fixtures needing tools not installed); the one more on main was `tests/test_gpu_hang_watch.py` in that run. **Not tested:** Linux, where the remaining check should pass too; the website's build. **Must be tested:** - Linux, no GPU needed: `python -I -B tests/test_tested_configurations.py`, expecting all 25 to pass (by hand, or the pull request's own checks: look at that test's line) ## Risks **What could break:** nothing I can name: no row's text changes, only which file holds it. **Turning it off:** revert the commit. **Compatibility:** Nothing changes. Links to the four old file names, if any exist outside the repository, stop working. ## Issues None found for this. #1255 and #1256 added the files; #96 is the rule. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A file in `docs/tested/` for each new measured run (format in `docs/tested-configurations.md`). - [x] Docs updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(docs): one row a file for the tested runs of #1255 and #1256
All checks were successful
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 8s
PR description / Description follows the template (pull_request_target) Successful in 12s
CI / Workflow lint (actionlint) (pull_request) Successful in 19s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 20s
Third-party parts / As their notes say (pull_request) Successful in 23s
Website / Website on Cloudflare (pull_request_target) Has been skipped
c6189282dc
Four of the docs/tested files those two pull requests added hold several
rows (two each for the dead targets' runs, six each for the shadow-map
slots'). A fragment is the header, the separator and exactly one row
(docs/tested/README.md, #96), so scripts/tested_configurations.py
stopped with "expected the standard header, separator and exactly one
row" and tests/test_tested_configurations.py failed on main.

Each row is a file of its own now (-old1, -old2, -new1, -new2; -off1 to
-off6, -on1 to -on6); no row's text is changed.

Assisted-by: Claude Mythos 5.2
Co-Authored-By: Claude Mythos 5.2 <[email protected]>
Collaborator

Possibly related, for context:

  • PR #493 test(docs): make the UTF-8 pipe fixture portable on Windows — Open PR fixes the same Windows catalogue test failure mentioned here; may overlap on tested-configurations work.
  • issue #482 Tests: catalogue UTF-8 pipe fixture assumes LF on Windows — Open issue tracks the Windows UTF-8 pipe test failure described as the remaining test failure.
Possibly related, for context: - PR #493 test(docs): make the UTF-8 pipe fixture portable on Windows — Open PR fixes the same Windows catalogue test failure mentioned here; may overlap on tested-configurations work. - issue #482 Tests: catalogue UTF-8 pipe fixture assumes LF on Windows — Open issue tracks the Windows UTF-8 pipe test failure described as the remaining test failure.
TrashPanda approved these changes 2026-11-17 09:11:58 +00:00
TrashPanda left a comment

Each of the sixteen measured rows is now its own file, and the row text is unchanged. I read head c6189282. It applies onto current main. This can merge as it is.

docs/tested/ allows a header, the separator and one row. The four files from #1255 and #1256 held two or six rows, so the catalogue script stopped on main. The sixteen files are that shape, in LF, and each name carries the row's date. Nothing else in the tree still names the four old files. The Windows pipe check that still fails on this PC is the one that already fails on main, and this change does not touch it.

Each of the sixteen measured rows is now its own file, and the row text is unchanged. I read head `c6189282`. It applies onto current main. This can merge as it is. `docs/tested/` allows a header, the separator and one row. The four files from #1255 and #1256 held two or six rows, so the catalogue script stopped on main. The sixteen files are that shape, in LF, and each name carries the row's date. Nothing else in the tree still names the four old files. The Windows pipe check that still fails on this PC is the one that already fails on main, and this change does not touch it.
Contributor

Linux check for the item in “Must be tested”, at exact head c6189282dcff4254764ad9b0c3cfe0ed75854a17:

  • python -I -B tests/test_tested_configurations.py: 25 tests, OK, exit 0.
  • On main 544229a260c5f5008f241b9cf48ae6b01c1602b9, with the same interpreter/environment policy: 25 tests, one error, exit 1. The error is the committed multi-row fragment rejected by read_row, not a parser defect.
  • The actual scripts/tested_configurations.py CLI, both stdout and --output, exits 0 at this head; their UTF-8 output bytes agree.

This is a focused source-only replay pinned to the public Git tree/blobs, including the complete tested-fragment corpus, frozen source page, script and test. Those inputs remained unchanged during execution. It is not a full checkout/full-suite run, website build, Windows test, game run or validation of the historical performance measurements. No branch or source changes made.

Linux check for the item in “Must be tested”, at exact head `c6189282dcff4254764ad9b0c3cfe0ed75854a17`: - `python -I -B tests/test_tested_configurations.py`: 25 tests, OK, exit 0. - On main `544229a260c5f5008f241b9cf48ae6b01c1602b9`, with the same interpreter/environment policy: 25 tests, one error, exit 1. The error is the committed multi-row fragment rejected by `read_row`, not a parser defect. - The actual `scripts/tested_configurations.py` CLI, both stdout and `--output`, exits 0 at this head; their UTF-8 output bytes agree. This is a focused source-only replay pinned to the public Git tree/blobs, including the complete tested-fragment corpus, frozen source page, script and test. Those inputs remained unchanged during execution. It is not a full checkout/full-suite run, website build, Windows test, game run or validation of the historical performance measurements. No branch or source changes made.
HumanBean deleted branch fix/tested-one-row-a-file 2026-11-17 15:57:33 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1378
No description provided.