perf(vk): a freed sparse mirror's buffer is kept for the next mirror of its size, not destroyed (RX_VK_SPARSE_SPARE_MB) #1359
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
4 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1359
Loading…
Reference in a new issue
No description provided.
Delete branch "GummiNaomi/Longshot:perf/sparse-mirror-buffers"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: perf · Risk: medium · Tested on: Windows 11, RTX 4070 SUPER (NVIDIA 617.42); the Test Farm: Windows, RX 9070 XT; Linux, RTX 4070 and RTX 3080 Ti · Needs: a person's eyes on a long session; an Intel card; RADV; a Steam Deck; a card of 8 GB or less
Why
Walking from Castle Town into Hyrule Field and back stutters, and part of it is in no column of the frame trace: three frames of 65 to 70 ms in one run had "nothing over 1 ms" in their row.
A profile of that walk (
HOS_PROFILE=1) shows where they are. In each of them the render thread sits in the driver undermemory_begin_submission, at the callsparse_reapmakes todestroy_sparse_buffer:vkDestroyBufferof a sparse VRAM mirror's buffer. With timing lines around the two calls (not in this PR), one run of that walk (95 s, two area changes):Such a buffer holds address space and no memory (its blocks are bound one by one), and the sizes come again: 174 of 405 were of 4 MB, 61 of 8 MB. The game lets go of its pools and makes them again at an area change, and each time the mirror's buffer was destroyed and a new one of the same size created.
Related: #792 (the images' destruction on a thread of its own: the same driver cost for images; this is the mirrors' buffers, which that PR does not reach).
What changed
A freed sparse mirror's buffer is kept for the next mirror of its size instead of being destroyed.
gpu/vk/sparse_spare.h(new) is the list of spare buffers: a mirror takes the spare created with exactly its size, the one kept last; over the cap the oldest go.gpu/vk/vk_memory.cpp):sparse_reap: a freed mirror's buffer, once the GPU is past it and its binds (the same wait as before), has what is bound to it unbound, every such buffer's blocks in onevkQueueBindSparse, and goes to the spares. Its blocks' memory is freed once that unbind is done on the GPU, as a released block's already is. If the bind fails, the buffers are destroyed and their memory freed, as before.mirror_freenotes what is bound to the buffer (its blocks, and released blocks still bound) before it empties the lists.mirror_maketakes a spare before it creates a buffer (sparse_buffer_for), and a buffer it gives up without binding anything goes back to the spares (sparse_buffer_unused).spare_doomed), never at once.sparseAddressSpaceSize. A spare holds no memory.RX_VK_SPARSE_SPARE_MB=<MB>;0keeps none and destroys every buffer at once, as before. The log saysvk: sparse mirrors' buffers are kept for the next mirror of their sizeat the first one, and every 1200 submissionsvk: sparse mirrors' buffers: N taken from the spares, N made new; N kept as spares, N destroyed.tests/test_sparse_spare.py(new) compiles and runs the list (what a size takes, the cap, which spares go for a new one, what is never kept) and readsvk_memory.cppfor the rules above (no buffer destroyed before its unbinding is done, the memory freed only after it,mirror_makenever past the spares).tests/test_sparse_mirror.pyfollows one moved line.docs/development.mdand ingpu/vk/switches.def; six files underdocs/tested/.Measurements
Verdict: on the walk out of Castle Town and back, the time spent in frames of 50 ms or more falls from 2.0 s to 1.55 s a run (1,868, 2,111 and 2,005 ms against 1,551, 1,479 and 1,696 ms: no overlap), and the frames of 100 ms or more from 4-7 to 3-5. The driver's time in these buffers falls from about 910 ms to 245 ms a run, and the 52-64 ms batches of destructions are gone. The binds cost about 50 ms more a run.
Hardware: Windows 11 Pro 26200, RTX 4070 SUPER 12 GB (NVIDIA 617.42), Ryzen 9 9950X3D (16 cores, SMT off), 32 GB
Scene: save set "First Step into Hyrule Town": out through the south gate into Hyrule Field and in again, two area changes (a scripted route on the wall clock, 95 s), 2560x1440, DLAA, frame generation off, uncapped
Method: headless runs, one build, the two sides in turn, three runs each; the frame trace (
RX_VK_FRAME_TRACE=1, both sides) from 3 s after the save's load-in on (the load-in is the first frame of 300 ms or more; it came between 28.8 and 31.5 s of frame time in these runs); the binds from the log'svk: sparse mirrors:lineBaseline: main's behaviour is this PR with
RX_VK_SPARSE_SPARE_MB=0(every buffer destroyed at once insparse_reap, as main does); both sides are one build, main8e9cfc3awith this change. The branch was then moved onto main6d72ca93(the switch table's row added), built and run once more there, one pair: 2,022 ms against 1,449 ms in frames of 50 ms or more, 7 against 4 frames of 100 ms or more. It was moved once more onto main544229a2and committed (3f72adcc), built (with the link fix for the MSVC target in the working tree, a pull request of its own) and run once more, one pair: 1,759 ms against 1,707 ms, 7 against 4 frames of 100 ms or more, 266 buffers taken from the spares and 116 made new, none destroyedHow to reproduce:
RX_VK_SPARSE_SPARE_MB=0against no switch, on the route above;HOS_PROFILE=1andscripts/profile_report.pyfor the stutters' stacksRX_VK_SPARSE_SPARE_MB=0: this PR @3f72adcc(three runs)3f72adcc(three runs)The worst frame of a run is the load into the field, which has much else in it (uploads, programs, the game's own loading); it does not move, and neither does the save's load-in.
Corrected on 17 Nov. The first version of these numbers counted from a fixed 32 s of frame time, as "past the load-in". The load-in does not come at a fixed time: in the first "before" run it came at 31.1 s, and 615 ms of its long frames were counted (2,483 ms then, 1,868 ms now, and 6 frames of 100 ms or more then, 4 now); the same in the "before" runs of the two single pairs on the later bases (3,244 and 2,363 ms then, 2,022 and 1,759 ms now). The other runs are as they were. The gain is about 0.45 s a run, not the 0.56 s first given;
docs/tested/has the corrected rows (the second commit). Over all nine pairs of this change measured so far (these three, the three with timing lines below, three single ones): 1,759 to 2,215 ms before, 1,264 to 1,707 ms after.A longer session through several areas, one tour a side: the repository's
kokiri-startsave, then the control bridge's debug teleport round the Market, Hyrule Field, Kakariko, Kokiri Forest, the Lost Woods and Zora's River, 20 s in each, 72 teleports in 20 minutes (scripts/longshot_ctl.py, its test profile: 1920x1080, headless, uncapped). Counted from 600 frames after the save's arrival to the end. One pair, so a direction: about a tenth less time in long frames; most of an area change's long frames are its textures (115,000 uploads a tour), which this does not touch.RX_VK_SPARSE_SPARE_MB=0: this PR @3f72adcc(one tour)3f72adcc(one tour)The driver's time in the two calls, from three earlier pairs of the same change with timing lines around
vkCreateBufferandvkDestroyBuffer(the lines are not in this PR; both sides had them):RX_VK_SPARSE_SPARE_MB=0: this PR @3f72adccwith timing lines (three runs)3f72adccwith timing lines (three runs)Picture checks, both sides:
RX_VK_SPARSE_SPARE_MB=0: this PR @3f72adccwith timing lines3f72adccwith timing linesThe flip count varies this much by itself on this route (13 to 72 a run on either side of earlier changes); no frame flashed.
Flags and settings
One new switch, on by default.
RX_VK_SPARSE_SPARE_MB0: none kept, as beforeTesting
Tested: Windows 11, RTX 4070 SUPER, NVIDIA 617.42: the runs above (four pairs of the route with the timing lines, three without, one more on each of the two later bases, two rounds of the gate's flicker test), no error or device loss in any log.
tests/test_sparse_spare.pyandtests/test_sparse_mirror.pypass at3f72adcc. The full run below was not repeated after the last move (main6d72ca93to544229a2, one pull request that touchesgpu/vk/vk_main.cppand its test).python -I -B tests/run_all.pywith clang on this PC, on main6d72ca93with this change: 393 passed, 107 failed, 221 skipped; main6d72ca93here: 393 passed, 106 failed, 221 skipped (this PC's toolchain: no gcc, Windows line endings, fixtures needing tools not installed). The one more istests/test_longshot_ctl.py, which failed under the full run's load and passes alone, twice, with this change and on main; the other 106 are main's. One of those istests/test_switch_table.py, over another switch (RX_VK_PGO_FILE has a row and nothing reads it); with this PR's row taken out it namesRX_VK_SPARSE_SPARE_MBtoo, so the row is read.A 20-minute tour of six areas a side (72 teleports each, the table above): no error or device loss on either side, every teleport arrived (three of the 144 were still loading 20 s after they were sent, in Kakariko, and went on), and with the default the spares' list stayed at its cap or under it, its oldest buffers destroyed as the cap asks (63 in the tour). Headless: nobody looked at the picture of the tour.
The Test Farm, this PR @
3f72adcagainst main @544229a, a teleport from the Market to Hyrule Field and back from a new save, with the default and withRX_VK_SPARSE_SPARE_MB=0(four reports; the table and the links are in the comment of 17 Nov below):=0.Not tested: an Intel card, RADV, the Steam Deck; a card of 8 GB or less; a session of hours; a person watching a long session (the tour above is headless); frame generation on; the gate walk itself on any card but the RTX 4070 SUPER (the farm teleports, and has no sum of the long frames' time); whether other drivers have this cost at all (the reuse is harmless where they don't, but it is not measured there).
Must be tested:
vk: sparse mirrors' buffers:line with "destroyed" a small part of "kept as spares"vk: sparse VRAM mirrors (RX_VK_MIRROR_SPARSE): on): Castle Town out into Hyrule Field and back, expecting no crash and no flashing or wrong lighting after the area change (Test Farm: @Beanstalk linux amd, the area change both ways)Risks
What could break: a buffer is now used again by another pool's mirror where it used to be destroyed. If a spare were taken while the GPU still read the old mirror through it, the old frame's work would read the new pool's data: wrong lighting or geometry for a frame. The wait before a buffer leaves the dead list is the one that guarded its destruction, and the flicker test found no difference, but that is one driver. A driver that handles unbinding a range differently from destroying the buffer could behave differently (a failed bind falls back to destroying). The spares hold up to 4 GB of sparse address space, no memory.
Turning it off:
RX_VK_SPARSE_SPARE_MB=0.Compatibility: Nothing changes.
Issues
None found for this (searched
sparse buffer,destroy_sparse_buffer,sparse_reap,sparse mirror). #792 is the nearest.Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.docs/tested/for each new measured run (format indocs/tested-configurations.md).tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
Possibly related, for context:
@Beanstalk windows amd and linux: an area change both ways, from Castle Town out into Hyrule Field and back into the town (two area changes or more in one run), once with this PR's default and once with
RX_VK_SPARSE_SPARE_MB=0(the behaviour before it). Expecting: no crash or device loss; the same picture on both after each area change (no flashing, no wrong lighting or geometry); hitches at the area changes no longer than on main (here, on NVIDIA on Windows: about 0.6 s less time in frames of 50 ms or more over the two changes, and no 52-64 ms stall when the old area's buffers are let go). The change only does something where the log saysvk: sparse VRAM mirrors (RX_VK_MIRROR_SPARSE): on; if a tester's log does not have that line, please say so, as that run then shows nothing either way. With the default the log should also havevk: sparse mirrors' buffers: N taken from the spares, ...with "0 destroyed" or a small number.🤖 Generated with Claude Code
Beanstalk test farm · an earlier run: commit
3f72adc(the newer results are in a comment below)Commit
3f72adc· tier reviewed · approved by GummiNaomi · dashboardWhat will be tested · AI plan (
gpt-6.1-terra)On Windows AMD and Linux, the plan teleports from Market to Hyrule Field and back on main and the PR, using both the default spare-buffer behavior and a zero cap on the PR. The two configurations take about 25 minutes per machine and compare post-load pictures and load times while recording frame hitches and sparse-mirror activation. Crashes, device loss, missing sparse-mirror activation, substantial picture differences, or slower loads fail the run; without the activation line, the run is inconclusive for this change. Teleports do not reproduce the original gate walk, and the farm cannot isolate buffer-destruction stalls or total time in frames over 50 ms.
0(PR only).Done (started 06:13 UTC, last report 07:24 UTC). Comment
@Beanstalkto run it again.AMD Radeon RX 9070 XT, 2.0.416; 2: windows+amd+amd-proprietary+dgpuAMD Radeon RX 9070 XT, 2.0.416NVIDIA GeForce RTX 4070, 615.71.9; 2: linux+nvidia+nvidia-proprietary+dgpuNVIDIA GeForce RTX 3080 Ti, 620.70.6Measurements · windows+amd
Verdict: fail on windows+amd (2/1 report):
default-spares crash;default-spares load_time_max_s.max_delta_pct (+23.0%);zero-spares crashfailed.Hardware: 1: windows+amd+amd-proprietary+dgpu
AMD Radeon RX 9070 XT, 2.0.416AMD Ryzen 7 5800X3D 8-Core Processor, 32 GB RAM; 2: windows+amd+amd-proprietary+dgpuAMD Radeon RX 9070 XT, 2.0.416AMD Ryzen 9 5900X 12-Core Processor, 32 GB RAMScene: default-spares, from a new save; zero-spares, from a new save; each cell's settings and switches as the table names them
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); default-spares: 1 game start a side, field 20 s after 0 s warm-up, market 20 s after 0 s warm-up; zero-spares: 1 game start a side, field 20 s after 0 s warm-up, market 20 s after 0 s warm-up; each number the median of the runs, then of 2 reports
How to reproduce: the farm's plan above (
@Beanstalkon this PR runs it again)544229a3f72adcRX_VK_SPARSE_SPARE_MB=0 (PR only)· longest load (s)RX_VK_SPARSE_SPARE_MB=0 (PR only)· forbidden log linesRX_VK_SPARSE_SPARE_MB=0 (PR only)· expected log lines missingRX_VK_SPARSE_SPARE_MB=0 (PR only)· field · frame time (p99) (ms)RX_VK_SPARSE_SPARE_MB=0 (PR only)· market · frame time (p99) (ms)Flags and settings
RX_VK_SPARSE_SPARE_MB0Markdown for the PR description
Measurements · linux
Verdict: pass on linux (2/1 report): no rule failed and no PR run crashed.
Hardware: 1: linux+nvidia+nvidia-proprietary+dgpu
NVIDIA GeForce RTX 4070, 615.71.9AMD Ryzen 7 5800X3D 8-Core Processor, 64 GB RAM; 2: linux+nvidia+nvidia-proprietary+dgpuNVIDIA GeForce RTX 3080 Ti, 620.70.6AMD Ryzen 9 3900X 12-Core Processor, 48 GB RAMScene: default-spares, from a new save; zero-spares, from a new save; each cell's settings and switches as the table names them
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); default-spares: 1 game start a side, field 20 s after 0 s warm-up, market 20 s after 0 s warm-up; zero-spares: 1 game start a side, field 20 s after 0 s warm-up, market 20 s after 0 s warm-up; each number the median of the runs, then of 2 reports
How to reproduce: the farm's plan above (
@Beanstalkon this PR runs it again)544229a3f72adcRX_VK_SPARSE_SPARE_MB=0 (PR only)· longest load (s)RX_VK_SPARSE_SPARE_MB=0 (PR only)· forbidden log linesRX_VK_SPARSE_SPARE_MB=0 (PR only)· expected log lines missingRX_VK_SPARSE_SPARE_MB=0 (PR only)· field · frame time (p99) (ms)RX_VK_SPARSE_SPARE_MB=0 (PR only)· market · frame time (p99) (ms)Flags and settings
RX_VK_SPARSE_SPARE_MB0Markdown for the PR description
The Test Farm's four reports, read one by one (its summary line says "fail" for windows+amd; the reports say why, and it is not this change):
RX_VK_SPARSE_SPARE_MB=0. No crash.=0run. The rule fails because a PR run crashed. With main crashing the same way there, I read it as that PC's or main's, not this change's; it also means this PC shows nothing about the change.=0: pictures diff 0, no crash.Hitches, one game start a side, so a direction and no more (the
=0pairs, where the PR does what main does, differ by as much in places):544229a3f72adcRX_VK_SPARSE_SPARE_MB=0on the PR, the field's worst frameSo far: no crash that main does not also have, the same picture on an AMD card on Windows and on NVIDIA on Linux, and the mirrors are sparse on the AMD card, so the change was in use there. The farm teleports between the Market and Hyrule Field from a new save; it does not walk through the gate, and it cannot count the time in frames of 50 ms or more.
Two things in those reports are main's and may want an issue from someone who can see the crash logs: main @
544229acrashing on the RX 9070 XT with the 5900X in both scenarios, and once on the RTX 4070 on Linux.Still open for this PR: a long played session (in hand), an Intel card, RADV, the Steam Deck, a card of 8 GB or less.
🤖 Generated with Claude Code
A correction to this PR's numbers, mine to make: the first version overstated the gain.
The runs were counted "from 32 s of frame time on", as past the save's load-in. The load-in does not come at a fixed time. In these runs it came between 28.8 and 31.5 s, and where it came late, part of its long frames fell after 32 s and were counted as the area change's:
RX_VK_SPARSE_SPARE_MB=0, three runs: time in frames of 50 ms or more6d72ca933f72adccSo the change takes about 0.45 s a run off the long frames of this walk (2.0 s to 1.55 s), not 0.56 s, and "about 0.6 s" in my request to the Test Farm above was too much. What stands: over all nine pairs measured so far no "before" run is as low as any "after" run (1,759 to 2,215 ms against 1,264 to 1,707 ms), the 52-64 ms batches of destructions are gone, and the driver's time in these buffers falls from about 910 to 245 ms a run (the timing-line runs, which this does not touch). The last single pair is close (1,759 against 1,707 ms).
The description's Measurements section and the six
docs/tested/rows are corrected (761fab7b, rows only; the code is3f72adccas measured). The first commit's message still has the old figures; I have not rewritten it, since that takes a force push. The load-in itself is the same on both sides (1,852 to 1,954 ms of long frames before, 1,813 to 1,885 after).How it was found: a profile of the same walk for the next piece of work listed every long frame with its time, and one run's load-in sat on the wrong side of the line.
🤖 Generated with Claude Code
Beanstalk test farm · an earlier run: commit
761fab7(the newer results are in a comment below)Commit
761fab7· tier reviewed · approved by GummiNaomi · dashboardWhat will be tested · AI plan (
gpt-6.1-terra)On Linux RADV, the plan teleports from the Market to Hyrule Field and back on main and the PR, once with the PR default and once with spare buffers disabled. It takes about 20 minutes per tester, comparing pictures after each change and checking for crashes and device loss. The log records whether sparse mirrors are on; if they are not, the run cannot exercise the changed behavior. The screenshots sample the scenes but cannot rule out transient flashing, and the longer watched session remains separate.
0(PR only).kokiri-start, then teleport to Market, teleport to Hyrule Field, take the picture field to compare with main, take the picture market to compare with main; 1 run on each side.kokiri-start, then teleport to Market, teleport to Hyrule Field, take the picture field to compare with main, take the picture market to compare with main; 1 run on each side.Done (started 10:40 UTC, last report 10:54 UTC). Comment
@Beanstalkto run it again.AMD Radeon RX 7900 XT (RADV NAVI31), 26.2.6; 2: linux+amd+radv+dgpuAMD Radeon RX 7900 XTX (RADV NAVI31), 26.2.7Measurements · linux+radv
Verdict: could not be judged on linux+radv (2/1 report).
Hardware: 1: linux+amd+radv+dgpu
AMD Radeon RX 7900 XT (RADV NAVI31), 26.2.6AMD Ryzen 7 5700X3D 8-Core Processor, 32 GB RAM; 2: linux+amd+radv+dgpuAMD Radeon RX 7900 XTX (RADV NAVI31), 26.2.7AMD Ryzen 7 5800X3D 8-Core Processor, 64 GB RAMScene: default-round-trip, from the repository's save kokiri-start; no-spares-round-trip, from the repository's save kokiri-start; each cell's settings and switches as the table names them
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); default-round-trip: 1 game start a side; no-spares-round-trip: 1 game start a side; each number the median of the runs, then of 2 reports
How to reproduce: the farm's plan above (
@Beanstalkon this PR runs it again)544229a761fab7RX_VK_SPARSE_SPARE_MB=0 (PR only)· forbidden log linesFlags and settings
RX_VK_SPARSE_SPARE_MB0Markdown for the PR description
WIP: perf(vk): a freed sparse mirror's buffer is kept for the next mirror of its size, not destroyed (RX_VK_SPARSE_SPARE_MB)to perf(vk): a freed sparse mirror's buffer is kept for the next mirror of its size, not destroyed (RX_VK_SPARSE_SPARE_MB)A freed sparse mirror's buffer is kept for the next mirror of the same size, and it is not destroyed until its unbind has finished. I read head
761fab7b. It applies onto current main. The RADV or Deck run, and a watched session, are still open, so this is not an approval.The reap waits for the same completed value as before, unbinds every kept buffer's blocks in one bind, and only then puts the buffer on the spare list. Its memory is freed once that unbind's timeline value is reached. A spare is destroyed only after that value, including one dropped because the list is over its cap. The cap is 4096 MB of address space, and never more than a quarter of the device's sparse address space.
RX_VK_SPARSE_SPARE_MB=0destroys every buffer at once, as before. The list is only touched while the pool lock is held. The played code is3f72adcc; the tip corrects the measured rows. On that build the walk out of Castle Town spends about 0.45 s less in frames of 50 ms or more, and the batches of destructions are gone. The Test Farm's Linux NVIDIA runs and one Windows AMD card showed the same picture and no crash this change adds. Must be tested still asks for a person watching a session of half an hour or more, and for Linux with RADV or a Steam Deck.For the open item the review names:
@Beanstalk linux radv: an area change both ways between the Market and Hyrule Field (two area changes or more in one run), once with this PR's default and once with
RX_VK_SPARSE_SPARE_MB=0. Expecting: no crash or device loss, and the same picture on both after each area change (no flashing, no wrong lighting or geometry). The change only does something where the log saysvk: sparse VRAM mirrors (RX_VK_MIRROR_SPARSE): on: if a RADV tester's log does not have that line, that is the answer for that card (nothing to keep, nothing changed), and worth saying.The watched session of half an hour or more is still to come, by hand.
🤖 Generated with Claude Code
The two RADV reports (rp_916defd98d889788, rp_736485a70ee11a86: RX 7900 XT and RX 7900 XTX) judged nothing: a step of the plan ran out of time in both scenarios, the one with
RX_VK_SPARSE_SPARE_MB=0too, which is main's own behaviour. What they do show: no crash on either card, and sparse mirrors on with RADV (vk: sparse mirrors: 49, 846 MB with memory of 1016 MB), so the change is in use there. Once more, with the steps of the first plan, which ran through:@Beanstalk linux radv: from a new save, teleport to the Market, then teleport to Hyrule Field, take a picture there and measure for 20 s, then teleport to the Market, take a picture and measure for 20 s; once with this PR's default and once with
RX_VK_SPARSE_SPARE_MB=0. Expecting: no crash or device loss, and the same pictures as main after each teleport.🤖 Generated with Claude Code
Beanstalk test farm
Commit
761fab7· tier reviewed · approved by GummiNaomi · dashboardWhat will be tested · AI plan (
gpt-6.1-terra)On Linux with RADV, a new save teleports through the Market to Hyrule Field and back, using the PR default and the zero-spare setting. Each visit to the field and final Market is pictured and measured for 20 seconds against main; the two configurations require separate starts and take about 26 minutes in total. A crash, device loss, or picture differing from main fails the plan.
0(PR only).Done (started 12:23 UTC, last report 12:39 UTC). Run 2: re-planned by GummiNaomi. Comment
@Beanstalkto run it again.AMD Radeon RX 7900 XTX (RADV NAVI31), 26.2.7; 2: linux+amd+radv+dgpuAMD Radeon RX 7900 XT (RADV NAVI31), 26.2.6Measurements · linux+radv
Verdict: could not be judged on linux+radv (2/1 report).
Hardware: 1: linux+amd+radv+dgpu
AMD Radeon RX 7900 XTX (RADV NAVI31), 26.2.7AMD Ryzen 7 5800X3D 8-Core Processor, 64 GB RAM; 2: linux+amd+radv+dgpuAMD Radeon RX 7900 XT (RADV NAVI31), 26.2.6AMD Ryzen 7 5700X3D 8-Core Processor, 32 GB RAMScene: default-spares, from a new save; no-spares, from a new save; each cell's settings and switches as the table names them
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); default-spares: 1 game start a side, field 20 s after 0 s warm-up, market 20 s after 0 s warm-up; no-spares: 1 game start a side, field 20 s after 0 s warm-up, market 20 s after 0 s warm-up; each number the median of the runs, then of 2 reports
How to reproduce: the farm's plan above (
@Beanstalkon this PR runs it again)544229a761fab7RX_VK_SPARSE_SPARE_MB=0 (PR only)· forbidden log linesFlags and settings
RX_VK_SPARSE_SPARE_MB0Markdown for the PR description
View command line instructions
Manual merge helper
Use this merge commit message when completing the merge manually.
Checkout
From your project repository, check out a new branch and test the changes.