WIP: feat(gameplay): an Auto-jump row: running or rolling off an edge jumps, as on the N64 #1327
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1327
Loading…
Reference in a new issue
No description provided.
Delete branch "kingo/Longshot:feat/auto-jump"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: feat · Risk: low · Tested on: Windows 11, RTX 5060 Ti 8 GB · Needs: Linux, any pad
Why
On the N64, Link jumps on his own when he runs or rolls off an edge: rocks in Zora's Domain, platforms, ledges. The remake drops him instead and leaves the jump to a button (Swap Jump Controls is its only option), so the edge-to-edge platforming players know by muscle memory needs a press each time. Searched the tracker (auto-jump, autojump, "auto jump", "jump off", ledge, cliff, pchtxt): nothing builds it in. A community Auto Jump
.pchtxtmod exists (https://gamebanana.com/mods/739034) and is used as an example in the Mods work (#134, #1036); a menu row works without a mod, with the game's own jump and ledge grab, and walks still drop.What changed
A new row in Gameplay, Auto-jump: Off (the default, the game as now) or On.
With On, where Link's AI selectors pick their fall on losing the ground, they pick their jump instead (the selectors' names are the game's own, from its node name strings; nothing decompiled is used):
f_808170d0atL_808175a0f_80814b20f_80814b20atL_80814c18f_8081d450*(controller+40)+472, the controller found asoot_player_controllerfinds it). Measured in game: a walk 4.45 to 4.56, a run 5.30 to 5.31, so 5.0 sits between. No controller found: the game's fall.host/oot_autojump.cdecides (hos_oot_autojump),nx2/oot_patches.pypatch_autojumpputs the four calls in; each site keeps the game's own pick when the row is off.gpu/vk/vk_menu.cpp(opts.auto_jump, after Skip opening), read by the host asHOS_OPT_AUTO_JUMP(73; 62 to 72, 80, 88 and 90 are taken). README's option table has its line.Measurements
Verdict: nothing to measure: a gameplay option, off by default; with it on, one function call where Link loses the ground.
Flags and settings
One new menu row.
auto_jump=in longshot_options.ini)Testing
Tested: Windows 11 Pro 26200, RTX 5060 Ti 8 GB, a pad through SDL, the Sacred Forest Meadow (a test build of this change with log lines at each site). With On: running off edges jumped (10 edges logged, the runs at speed 5.30 to 5.31); walking off dropped (4.50 to 4.56); rolling off jumped (7 rolls); ledge grabs and ladders worked as before. Off: he falls, as now.
Video: the row turned on, then edges walked, run and rolled off
tests/test_oot_autojump.py(new; fails on main: no row): the row, its id and default, the four sites patched once each and left alone when their anchor moved, the game's fall kept when off, andhost/oot_autojump.ccompiled with a stub option. Run with the checks it touches (test_option_ids,test_readme_menu_rows,test_oot_damage,test_opening_skip): all pass. The full suite is not run yet (the game was open); it will be before this leaves WIP.Not tested: Linux; adult Link (the run speed may differ: the walk/run gap is from child Link); other selectors that also fall (Charge, lock-on, BackFlip, SideStep, Land): off an edge from those he still falls.
Must be tested:
Risks
What could break: with On, a run off an edge where a fall was wanted jumps (as on the N64). With Off nothing changes: each site keeps the game's pick.
Turning it off: the row's Off, or revert the commit.
Compatibility: one new line in longshot_options.ini; nothing else changes.
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
Tested in game: Windows 11 Pro 26200, RTX 5060 Ti 8 GB (NVIDIA), a pad through SDL, Sacred Forest Meadow as child Link: with Auto-jump On, running off edges jumped (speed 5.30-5.31), walking off dropped (4.50-4.56), rolling off jumped; ledge grabs and ladders worked; Off falls as before.
Brought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.