WIP: feat(host): the host's switches join the table: every HOS_ and LONGSHOT_ name the game reads has a row #1326
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1326
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:feat/host-switch-table"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: feat · Risk: low · Tested on: Linux, RTX 3090 · Needs: a Windows build
Why
#1300 gave every renderer switch a row, so a log shows what a run set and a misspelt name is said. The host reads 216 more names (
HOS_,LONGSHOT_) with the same problem: a bug report's log does not say which were set, and a typo does nothing silently. Track F of the renderer rework plan. Stacked on #1309 and the second kill-switch batch: review the last commit only.What changed
gpu/vk/switches.defgains the host's 216 switches, each read once from its code: 90 diagnostics, 50 that turn something off, 24 player settings, 24 numbers, 20 that turn on something nobody ships, 8 that follow the PC.gpu/vk/switches.h: the start'svk: switches setline now names host switches too, and aHOS_name that is no switch gets its line. ALONGSHOT_name that is no switch is passed over, because the launcher and the Builder set names of their own.host/hos_main.c: the three removedHOS_names (HOS_FIX_RES,HOS_RECORD_STUTTERS,HOS_SCENE_NATIVE) becomeGONErows; its own list keeps onlyTOTK_MINIMAL_LAYOUT.tests/test_switch_table.pyscans for all three families.docs/development.mdandAGENTS.mdsay a newHOS_orLONGSHOT_read needs a row.No switch's behaviour changes.
Measurements
Nothing to measure: one more log line at the start.
Testing
Tested: Linux, RTX 3090 (NVIDIA 620.70): built as a dev pack; one session through Kokiri Forest, Hyrule Field and the Market with a made-up name and a removed one set. The log said:
Not tested:
tests/run_all.pywas not run on this PC;tests/test_switch_table.pyhas not run with the host's rows._WIN32blocks were found by the same text scan, but nothing was compiled there.Must be tested:
switches setline: the launcher's ownHOS_settings should appear as switches, and none as "not a switch of this build". If one does, the table lacks a row.Risks
What could break: a wrong row misdescribes a switch in the log; a missing row calls a real switch a stranger. Neither changes what the game does.
Turning it off: revert the commit.
Compatibility: none: no cache, no interface, no setting changes.
Issues
See #1300
Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named). Not run on this PC; left to the forge's checks.third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
https://claude.ai/code/session_017vw8dzCsAL3UdW7ft8ptL9
Tested in game: Linux, RTX 3090, NVIDIA 620.70: one session through Kokiri Forest, Hyrule Field and the Market; the start's log named the 11 switches set with their kinds, called HOS_NOT_A_SWITCH a stranger and HOS_FIX_RES removed.
HumanBean referenced this pull request2026-11-17 03:43:56 +00:00
Folded into #1309, which now carries this commit with the others of the same topic. Closing this one.
Closed: its commit is in #1309 now.
Pull request closed