WIP: refactor(vk): 18 more kill switches and their older paths are deleted from the smaller renderer files #1325
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1325
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:refactor/kill-switches-2"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: refactor · Risk: medium · Tested on: Linux, RTX 3090 · Needs: Windows (AMD or Intel); a card with 8 GB or less
Why
Track F of the renderer rework plan: the kill switches cut down to the ones that decide something. This is the second batch, the smaller renderer files, after the four large ones. Stacked on #1309: its commit is this branch's parent, so review the last commit only. See #1300 (the table).
What changed
18 more kill switches are gone with the older paths they selected. A run that sets none of them does what it did before; a run that still sets one is told at the start what became of it.
RX_VK_ALLOWED_AT_COUNT,B2T_CPU,BLOCK_BUFFERS,DLSS_ACTORS,DLSS_HDR,DLSS_IDLE_RELEASE,FALLBACK_LOADED,FSR4_UNROLL,IMAGES_VRAM_ONLY,JOB_STEAL,MODULE_IDS,NO_IMAGE_POOL,NO_MESH_WARNING,NO_READBACK_WAIT,PRESENT_AHEAD,REFLEX_SUBMIT_IDS,STARTUP_SCREEN,TARGET_BLOCKS(allRX_VK_), fromvk_vma.cpp,vk_main.cpp,vk_temporal.cpp,vk_xfer.cpp,vk_dlss.cpp,vk_fsr4.cpp,vk_jobs.cpp,vk_reflex.cpp,vk_framegen.cpp,vk_programs.cpp,vk_progcache.cpp,fallback_loaded.hand four call sites in the large files.gpu/vk/switches.def: each is aGONErow dated 2026-11-16; 460 renderer switches are left.RX_VK_AUTO_PRESET,RX_VK_AUTO_TUNE,RX_VK_SPARSE,RX_VK_DLSS_ACTOR_LIVE).docs/development.mdloses 5 rows and 7 clauses.Made as #1309 was: an agent made the deletions, a second read every hunk against the old text. It found no change of behaviour and one fixture that would no longer compile, fixed.
One thing a player could notice:
RX_VK_NO_MESH_WARNINGonly hid a message box. On Windows, a GPU without mesh shaders run withRX_VK_NO_MESH_FALLBACKset now always shows it.Measurements
Verdict: nothing to measure against: no path a default run takes changed. One session ran as a check that it draws and holds its frame rate; its numbers are inside the spread of main's sessions in #1309.
Hardware: CachyOS (kernel 7.3.3), RTX 3090 24 GB, NVIDIA 620.70, Ryzen 9 7900X, 32 GB
Scene: Kokiri Forest, Hyrule Field, the Market; 2560x1440, no upscaler,
HOS_FPS_MAX=1000; one session, standing then turning in each.Flags and settings
18 switches removed, none added or changed.
Testing
Tested: Linux, RTX 3090 (NVIDIA 620.70): built as a dev pack over base
8e9cfc3a; one session through the three areas. Every scene drew with main's draw counts and GPU times, the run ended on its own, and the log has no error line. Set on purpose,RX_VK_JOB_STEAL=0was answered at the start with itsGONEline.Not tested:
tests/run_all.pywas not run on this PC. 12 test files were edited by reading alone.vk_vma.cpp's five removals decide where images are allocated under VRAM pressure, which this PC never reaches.Must be tested:
@Beanstalk windows amd and windows intel: main against this PR, Kokiri Forest, Hyrule Field, the Market)scripts/memtour.py.Risks
What could break: a deletion that kept the wrong side changes behaviour for everyone on that path; the ones this PC does not run are the upscalers and low VRAM.
Turning it off: revert the commit.
Compatibility: a run that sets a removed switch gets the default and a log line. No cache is rebuilt,
MKWVK_API_VERSIONstays.Issues
See #1300
Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named). Not run on this PC; left to the forge's checks.third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.tests/that reads changed source updated in this PR, not weakened.🤖 Generated with Claude Code
https://claude.ai/code/session_017vw8dzCsAL3UdW7ft8ptL9
Tested in game: Linux, RTX 3090, NVIDIA 620.70: one session through Kokiri Forest, Hyrule Field and the Market at 2560x1440; every scene drew with main's draw counts and GPU times, no error line, and RX_VK_JOB_STEAL=0 got its removed-switch line.
HumanBean referenced this pull request2026-11-17 03:43:56 +00:00
Folded into #1309, which now carries this commit with the others of the same topic. Closing this one.
Closed: its commit is in #1309 now.
Pull request closed