fix(release): preserve the supplied ZIP release tag #1313
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
3 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1313
Loading…
Reference in a new issue
No description provided.
Delete branch "NitnekLeBorgne/Longshot-contributions:fix/builder-zip-release-tag-20261117"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Linux and native Windows, game-free contributor-tool fixtures; no GPU/driver exercised · Needs: none
Why
A reused or prepopulated Builder package can put an old nested version into a newly tagged ZIP, so the two version entries disagree. This is a robustness fix; a fresh CI package may never hit it and no affected shipped release is claimed.
The issue tracker was searched again on 2026-11-17 using version.txt/release tag; no matching issue was found in the returned, observational corpus. This is not a claim about hidden/deleted issues; no issue closure is claimed.
How to reproduce
Seen on: Linux and native Windows, offline fixtures; GPU and driver not involved.
Settings and switches: Private synthetic fixtures; no game settings or GAME_PATHS inputs.
Steps: Use tests/test_builder_zip_version.py with the tiny package containing tools/version.txt=v2.0.0, then invoke the real builder ZIP CLI with release argument v3.0.0-rc.2. Run
python -I -B -m unittest discover -s tests -p test_builder_zip_version.pyagainst baseline production plus the added tests, then the combined candidate.Expected: Both VERSION and LongshotBuilder/tools/version.txt contain the supplied v3.0.0-rc.2; neighboring payload remains unchanged.
Actual: The CLI exits 0 but VERSION is v3.0.0-rc.2 and the nested version remains v2.0.0.
What changed
Keep the two generated release-version entries authoritative while adding ordinary payload entries with setdefault. Neighboring files named version.txt remain ordinary payload. The patch is limited to the following production/test pair, both Git mode
100644.scripts/builder_package.py— make_zip().tests/test_builder_zip_version.py— supported failure and neighboring controls.Rebased onto main
544229a260c5f5008f241b9cf48ae6b01c1602b9. Test-only commit:40cd93a325b01fe60fabb36c52ef3f6d85009db4. Final fix head:95ed88f20596d8d1d3b0287e5c87b17e415abfbd. The changed file bytes/modes remain identical to the independently reviewed version; complete current-base trees and parent chains were verified. Fresh normal qualification uses this actual HEAD.Measurements
Nothing to measure: this is a contributor-tool correctness fix, not a gameplay, rendering or performance change.
Flags and settings
None
Testing
Tested: Linux: 9 unique candidate methods PASS: 4 new ZIP-version + 5 existing recomplauncher JSON methods. Original logic produces two targeted assertion failures and two passing controls; replay of the combined patch passes 4/4. Native Windows: 4 ZIP-version methods PASS; native exit 0. Public scripts ran with
python -I -Band owned fixtures. Native receipts: Job final 0, complete stdout/stderr, no controller errors; all 818 source paths unchanged. V5's three native controls and 60-child burst passed independent verification. Validated short-lived-process metadata gaps remain: no universal visibility or filesystem/network sandbox claim. The retained native receipt is from original head3263f960419d2997b264850bb0fbc3199d78857b; the production/test bytes, modes and native dependency closure used there are unchanged by this rebase. No new Windows run is claimed.Fresh normal Linux qualification on the pinned current base and actual rebased candidate used
python -I -B tests/run_all.py --jobs 2 --junit ..., identical interpreter/environment policy and real Git HEAD/index:544229a260c5f5008f241b9cf48ae6b01c1602b9: 721 checks, 571 PASS / 42 FAIL / 108 SKIP, native exit 1.95ed88f20596d8d1d3b0287e5c87b17e415abfbd: 722 checks, 572 PASS / 42 FAIL / 108 SKIP, native exit 1.tests/test_builder_zip_version.py. All 721 common statuses, skip reasons and complete failure payloads agree after narrowly recorded diagnostic-noise handling: owned source/run paths, source-proven temporary file/directory suffixes, unittest elapsed times, one GCC intermediate object and one synthetic-fixture backup directory. Assertion values, failure identities, symbols, numeric offsets and statuses are not normalized. The GCC/linker error still nameschoose_face,hos_options_file,.text+0xa1aand exit 1; a separate retained compiler/assembler/linker trace proves this toolchain's temporary-object provenance. No universal no-regressions claim.The 42 normal failures also observed on this current-main qualification are named here, as the template permits; the normal suite is not green:
tests/test_bug_report.pytests/test_bug_report_defaults.pytests/test_cpu_report.pytests/test_crash_groups.pytests/test_crt_options.pytests/test_damage_debug_menu.pytests/test_discover.pytests/test_display_startup_failure.pytests/test_dlss_feature_size.pytests/test_failed_compile_keeps_objects.pytests/test_framegen_preset.pytests/test_guest_imported.pytests/test_hardware_report.pytests/test_hud_layout_row.pytests/test_invalidate_vcore.pytests/test_lift_lookups.pytests/test_link_skip.pytests/test_linux_pressure.pytests/test_linux_update.pytests/test_longshot_saves.pytests/test_mirror_budget.pytests/test_missing_nup.pytests/test_mods_size_table.pytests/test_pending_guest_import.pytests/test_pipeline_play_cache.pytests/test_present_thread.pytests/test_profiling_mode.pytests/test_readback_timeout_source.pytests/test_renderer_new_handler.pytests/test_rumble_menu.pytests/test_run_all_changed.pytests/test_slow_frames.pytests/test_switch_table.pytests/test_target_image_pool.pytests/test_tested_configurations.pytests/test_upscaler_round_trip.pytests/test_upscaler_rows.pytests/test_vcore_escape.pytests/test_vk_occlusion_queries.pytests/test_vk_swapchain_compat.pytests/test_walk.pytests/test_walk_key.pyNot tested: Full Windows suite, real SDK/release installation, gameplay/GPU or hosted-CI equivalence. These source/fixture-only limits do not invent extra native-test obligations. Hosted checks are tracked on the final exact public head; readiness is not approval, a full CI PASS or merge eligibility.
Must be tested: None additional for this two-file contributor-tool change. The normal-runner exception is explicitly limited to the named current-main failures above, with source-only context disclosed; it is not a waiver for a new candidate failure or an unknown comparison.
Risks
What could break: ZIP-entry collision precedence. Payload, uniqueness, deterministic repeated output and input-tree immutability are checked with tiny fixtures; no real release or SDK is qualified.
Turning it off: Revert the fix and its associated test commit.
Compatibility: No game runtime, saves, options, shader/pipeline cache or vk ABI changes; only the stated contributor-tool behavior changes. No GAME_PATHS directory is touched and no in-game run is claimed.
Checklist
The normal runner remains native exit 1; its named current-main failures use the template's explicit exception, not a full-suite PASS claim. Tracker search and the GPL-3.0-or-later diff/provenance check are complete. No incompatible dependency, third-party code, dump or decompiled/generated game content is introduced.
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.mainand passing here.tests/that reads changed source updated in this PR, not weakened.The retained behavioral RED uses identical baseline production and regression-test bytes; the rebased normal run verifies the final source on the current-base context. No host C/C++, shader, game switch or visible-game change applies.
Possibly related, for context:
3263f9604195ed88f205Rebased onto main
544229a260c5f5008f241b9cf48ae6b01c1602b9with both reviewed file bytes and modes preserved. New head:95ed88f20596d8d1d3b0287e5c87b17e415abfbd. Fresh source-only Linux normal qualification is 572 PASS / 42 named FAIL / 108 SKIP versus current main 571 / 42 / 108; both native exit 1. The new regression module passes; common failure/skip diagnostics match after narrowly documented temporary-path and timing handling, without hiding assertion numbers or linker symbols. The description now names the current-main failures and keeps the qualification limits explicit. The retained native Windows 4-method proof covers the unchanged source closure; no new Windows, gameplay or full-CI result is claimed.WIP: fix(release): preserve the supplied ZIP release tagto fix(release): preserve the supplied ZIP release tagBrought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.