WIP: perf(vk): enable storage table loop and mesh optimizer on AMD RDNA 4 #1308

Draft
gmourao wants to merge 1 commit from gmourao/Longshot:perf/vk-rdna4-table-loop-mesh-opt into main
First-time contributor

Type: perf · Risk: low · Tested on: Windows 11, AMD Radeon RX 9060 XT (isolated in-game run + unit/C++ checks on d79a0580; awaiting interleaved 2+2 main vs PR runs) · Needs: Windows, RDNA 4 / RDNA 2; Linux, RDNA 4 (RADV)

Why

On AMD RDNA 4 GPUs running AMD's proprietary Windows driver (LLPC), unrolled storage buffer lookup tables in global-memory access helpers generate huge SPIR-V shaders (>100k instructions), and Task/Mesh pipelines are built with VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT by default. Enabling the storage table loop and the driver's mesh shader optimizer specifically on AMD RDNA 4 (RX 9 / GFX12) avoids those slow unoptimized paths while leaving GCN, RDNA 1-3, RADV, Intel, NVIDIA, and compute fallback behavior unchanged.

What changed

Added an RDNA 4 detection helper and scoped both global_table_loop (on AMD proprietary) and the default mesh_opt flag in build_graphics() to RDNA 4 GPUs, preserving environment variable overrides, compute fallback policy, and existing test-extraction boundaries.

  • device: is_rdna4() in gpu/vk/vk_internal.h matches AMD (0x1002) devices whose deviceName contains RX 9 or GFX12 (matching auto_profile() in gpu/vk/vk_main.cpp).
  • coopmat: table_loop_wanted() in gpu/vk/vk_coopmat.cpp now takes bool rdna4 and defaults to enabled on VK_DRIVER_ID_INTEL_OPEN_SOURCE_MESA or rdna4 && driver == VK_DRIVER_ID_AMD_PROPRIETARY (requiring dynamic_indexing, with RX_VK_GM_LOOP override intact).
  • pipelines: build_graphics() in gpu/vk/vk_draw.cpp computes mesh_opt inline (self-contained for tests/test_fallback_pipeline_state.py), defaulting to true on RDNA 4 when RX_VK_MESH_OPT is unset or empty while preserving VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT on GCN and RDNA 1-3 and leaving fallback_compute_pipelines() unchanged from main.
  • tests: updated tests/test_global_table_loop.py and tests/test_radv_mesh_optimizer.py (both keeping RUN_ALL_ARGS = ["--cxx", "{cxx}"] for real C++ compilation/execution) to verify is_rdna4() + RDNA 4 defaults, GCN/RDNA 1-3/RADV/NVIDIA/Intel preservation, and RX_VK_GM_LOOP / RX_VK_MESH_OPT overrides.

Measurements

Verdict: isolated in-game smoke run on this PR @ d79a0580 (with zero env overrides) confirmed storage buffer tables searched in loops active automatically and 0 unoptimized task/mesh logs (96 >300-present windows: 185.2 avg / 230.3 median FPS; 98 GPU time windows: 1.82 ms avg / 0.40 ms median); interleaved 2+2 runs against main @ e41de662 still pending.

Baseline: single-session isolated reference on this PR @ d79a0580 (first cold cache rebuild run, zero longshot_env.txt) vs earlier nightly-316-a0be15b3 (3e664cdd) baseline; replace the pending 2+2 median cells with interleaved runs on main @ e41de662 vs this PR @ d79a0580 before removing WIP:.
Hardware: Windows 11, AMD Radeon RX 9060 XT (16 GB, driver 26.10.1 LLPC, id 1002:7590), 16 logical CPUs, 32 GB RAM
Scene: gameplay benchmark / save run (1280x720 swapchain, FSR 4 Quality, >300 presents log windows)
Method: longshot_log.txt FPS/GPU time summaries (>300 presents and GPU time lines); 2 interleaved runs each on main and this PR (median) needed to finalize
How to reproduce: launch with default environment (no RX_VK_GM_LOOP or RX_VK_MESH_OPT overrides) after initial shader cache warm-up

Before: main @ e41de662 After: this PR @ d79a0580
mean / median FPS (>300 presents) [pending 2+2; nightly-316 ref: 87.0 / 60.0] [pending 2+2; isolated ref: 185.2 / 230.3 (96 windows)]
mean / median GPU time (ms) [pending 2+2; nightly-316 ref: 7.11 / 8.60] [pending 2+2; isolated ref: 1.82 / 0.40 (98 windows)]
warm start-up (s) [pending 2+2; nightly-316 ref: 9.9] [pending warm 2+2 after cache rebuild]

Flags and settings

No new flags added; changes the default on AMD RDNA 4 for two existing environment switches.

Flag What it is Before this PR After this PR Effect Helps / doesn't help / untested Recommendation
RX_VK_GM_LOOP Search global-memory SSBO tables in a DontUnroll loop Off by default on AMD; on only for Intel Mesa On by default on AMD RDNA 4 proprietary LLPC (and Intel Mesa); off elsewhere Shrinks SPIR-V size and driver compile time on RDNA 4 Helps: AMD RDNA 4 LLPC, Intel Mesa. Untested: RDNA 1-3 proprietary, RADV Leave unset (default on for RDNA 4 proprietary and Intel Mesa)
RX_VK_MESH_OPT Allow driver optimizer on AMD Task/Mesh pipelines Off by default on all non-RADV AMD GPUs On by default on AMD RDNA 4; off on GCN and RDNA 1-3 Removes DISABLE_OPTIMIZATION_BIT on RDNA 4 Task/Mesh shaders Helps: AMD RDNA 4. Doesn't help/risky: RDNA 2 (RX 6600 hangs) Leave unset (default on for RDNA 4, off for RDNA 1-3)

Testing

Tested: on this PR @ d79a0580 (Windows 11, clang++.exe): 13/13 targeted C++ and Python checks passed (test_fallback_pipeline_state, test_quick_pipelines, test_utf8_paths, test_amd_subgroup_profiles, test_driver_faults, test_vendor_fixes, test_fallback_size_policy, test_radv_mesh_optimizer, test_global_table_loop, test_doc_anchors, test_mesh_fallback, test_mesh_fallback_failed_once, test_intel_quick_compute); scripts/check_third_party.py passed; longshot_vk.dll built cleanly (llvm-mingw, 0 failed). Isolated in-game run on RX 9060 XT (zero longshot_env.txt) verified storage buffer tables searched in loops active, 0 unoptimized task/mesh fallback logs, 185.2 avg / 230.3 median FPS, 1.82 ms avg / 0.40 ms median GPU time, and 0 render-thread catch-ups. The 3 unrelated Windows clang++ failures seen in an earlier --changed main run (test_fsr_uniform_ownership.py, test_replay_write_order.py, test_vk_occlusion_queries.py) were directly reproduced (0 passed, 3 failed) on unmodified main @ e41de662.

Not tested: interleaved 2+2 warm benchmark against main @ e41de662, full Linux build/suite, RDNA 4 on Linux RADV, and RDNA 2 regression check.

Must be tested:

  • Windows, AMD RX 9000 series (RDNA 4) proprietary driver: warm up, then run 2+2 interleaved main @ e41de662 vs this PR @ d79a0580 in the same scene with default settings (no RX_VK_GM_LOOP or RX_VK_MESH_OPT overrides), expecting storage buffer tables searched in loops, no unoptimized Task/Mesh fallback log, higher FPS, and lower GPU frame time (Test Farm: @Beanstalk Please compare this PR against main e41de662 on Windows with an AMD Radeon RX 9000-series GPU and proprietary driver using default settings without RX_VK_GM_LOOP or RX_VK_MESH_OPT overrides, warm up then run main/PR/main/PR in the same scene and report frame-time, FPS and preparation results)
  • Windows, AMD RX 6600 / RDNA 2 proprietary driver: play Kokiri Forest with default settings, expecting VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT to remain active and no device lost (Test Farm: @Beanstalk Please test on Windows with an AMD RX 6000 / RDNA 2 GPU on proprietary drivers in Kokiri Forest, confirming the log still prints task and mesh programs built without the driver's optimizer and no device lost occurs)
  • Linux, AMD RDNA 4 (radv): run tests/run_all.py and a gameplay smoke test, expecting unchanged behavior and all tests passing (Test Farm: @Beanstalk Please test on Linux with RADV by running python -I -B tests/run_all.py and a gameplay smoke test)

Risks

What could break: an AMD RDNA 4 driver regression with optimized Task/Mesh pipelines or dynamically indexed SSBO tables.

Turning it off: set RX_VK_GM_LOOP=0 and RX_VK_MESH_OPT=0, or revert the commit.

Compatibility: global_table_loop is part of translator_stamp(), so on AMD RDNA 4 proprietary drivers the first launch after updating invalidates and rebuilds longshot_programs.bin and longshot_vk_pipelines.bin once; all other GPUs keep existing caches untouched.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure. (pending isolated 2+2 runs on main @ e41de662 vs this PR @ d79a0580; keep WIP until measured locally or on Test Farm)
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks. Not ticked yet: The main-versus-PR comparison is still pending, and the first-launch cache rebuild cost is named but not measured.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (13 targeted checks passed on d79a0580 and 3 unrelated failures from earlier --changed main reproduced on main @ e41de662; full Windows/Linux suite run pending before removing WIP:).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • Numbers from the same PC, scene and settings, at least 2 interleaved runs each, the median reported. (pending isolated 2+2 runs; keep WIP until collected)
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (llvm-mingw Windows build and test_utf8_paths.py passed; Linux build untested locally and requested on Test Farm)
**Type:** perf · **Risk:** low · **Tested on:** Windows 11, AMD Radeon RX 9060 XT (isolated in-game run + unit/C++ checks on `d79a0580`; awaiting interleaved 2+2 `main` vs `PR` runs) · **Needs:** Windows, RDNA 4 / RDNA 2; Linux, RDNA 4 (RADV) ## Why On AMD RDNA 4 GPUs running AMD's proprietary Windows driver (LLPC), unrolled storage buffer lookup tables in global-memory access helpers generate huge SPIR-V shaders (>100k instructions), and Task/Mesh pipelines are built with `VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT` by default. Enabling the storage table loop and the driver's mesh shader optimizer specifically on AMD RDNA 4 (`RX 9` / `GFX12`) avoids those slow unoptimized paths while leaving GCN, RDNA 1-3, RADV, Intel, NVIDIA, and compute fallback behavior unchanged. ## What changed Added an RDNA 4 detection helper and scoped both `global_table_loop` (on AMD proprietary) and the default `mesh_opt` flag in `build_graphics()` to RDNA 4 GPUs, preserving environment variable overrides, compute fallback policy, and existing test-extraction boundaries. - device: `is_rdna4()` in `gpu/vk/vk_internal.h` matches AMD (`0x1002`) devices whose `deviceName` contains `RX 9` or `GFX12` (matching `auto_profile()` in `gpu/vk/vk_main.cpp`). - coopmat: `table_loop_wanted()` in `gpu/vk/vk_coopmat.cpp` now takes `bool rdna4` and defaults to enabled on `VK_DRIVER_ID_INTEL_OPEN_SOURCE_MESA` or `rdna4 && driver == VK_DRIVER_ID_AMD_PROPRIETARY` (requiring `dynamic_indexing`, with `RX_VK_GM_LOOP` override intact). - pipelines: `build_graphics()` in `gpu/vk/vk_draw.cpp` computes `mesh_opt` inline (self-contained for `tests/test_fallback_pipeline_state.py`), defaulting to `true` on RDNA 4 when `RX_VK_MESH_OPT` is unset or empty while preserving `VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT` on GCN and RDNA 1-3 and leaving `fallback_compute_pipelines()` unchanged from `main`. - tests: updated `tests/test_global_table_loop.py` and `tests/test_radv_mesh_optimizer.py` (both keeping `RUN_ALL_ARGS = ["--cxx", "{cxx}"]` for real C++ compilation/execution) to verify `is_rdna4()` + RDNA 4 defaults, GCN/RDNA 1-3/RADV/NVIDIA/Intel preservation, and `RX_VK_GM_LOOP` / `RX_VK_MESH_OPT` overrides. ## Measurements **Verdict:** isolated in-game smoke run on `this PR @ d79a0580` (with zero env overrides) confirmed `storage buffer tables searched in loops` active automatically and `0` unoptimized task/mesh logs (96 >300-present windows: 185.2 avg / 230.3 median FPS; 98 GPU time windows: 1.82 ms avg / 0.40 ms median); interleaved 2+2 runs against `main @ e41de662` still pending. Baseline: single-session isolated reference on `this PR @ d79a0580` (first cold cache rebuild run, zero `longshot_env.txt`) vs earlier `nightly-316-a0be15b3` (`3e664cdd`) baseline; replace the pending 2+2 median cells with interleaved runs on `main @ e41de662` vs `this PR @ d79a0580` before removing `WIP:`. Hardware: Windows 11, AMD Radeon RX 9060 XT (16 GB, driver 26.10.1 LLPC, id 1002:7590), 16 logical CPUs, 32 GB RAM Scene: gameplay benchmark / save run (1280x720 swapchain, FSR 4 Quality, >300 presents log windows) Method: `longshot_log.txt` FPS/GPU time summaries (`>300 presents` and `GPU time` lines); 2 interleaved runs each on `main` and `this PR` (median) needed to finalize How to reproduce: launch with default environment (no `RX_VK_GM_LOOP` or `RX_VK_MESH_OPT` overrides) after initial shader cache warm-up | | Before: main @ e41de662 | After: this PR @ d79a0580 | |---|---|---| | mean / median FPS (>300 presents) | [pending 2+2; `nightly-316` ref: 87.0 / 60.0] | [pending 2+2; isolated ref: 185.2 / 230.3 (96 windows)] | | mean / median GPU time (ms) | [pending 2+2; `nightly-316` ref: 7.11 / 8.60] | [pending 2+2; isolated ref: 1.82 / 0.40 (98 windows)] | | warm start-up (s) | [pending 2+2; `nightly-316` ref: 9.9] | [pending warm 2+2 after cache rebuild] | ### Flags and settings No new flags added; changes the default on AMD RDNA 4 for two existing environment switches. | Flag | What it is | Before this PR | After this PR | Effect | Helps / doesn't help / untested | Recommendation | |---|---|---|---|---|---|---| | `RX_VK_GM_LOOP` | Search global-memory SSBO tables in a `DontUnroll` loop | Off by default on AMD; on only for Intel Mesa | On by default on AMD RDNA 4 proprietary LLPC (and Intel Mesa); off elsewhere | Shrinks SPIR-V size and driver compile time on RDNA 4 | Helps: AMD RDNA 4 LLPC, Intel Mesa. Untested: RDNA 1-3 proprietary, RADV | Leave unset (default on for RDNA 4 proprietary and Intel Mesa) | | `RX_VK_MESH_OPT` | Allow driver optimizer on AMD Task/Mesh pipelines | Off by default on all non-RADV AMD GPUs | On by default on AMD RDNA 4; off on GCN and RDNA 1-3 | Removes `DISABLE_OPTIMIZATION_BIT` on RDNA 4 Task/Mesh shaders | Helps: AMD RDNA 4. Doesn't help/risky: RDNA 2 (RX 6600 hangs) | Leave unset (default on for RDNA 4, off for RDNA 1-3) | ## Testing **Tested:** on `this PR @ d79a0580` (Windows 11, `clang++.exe`): 13/13 targeted C++ and Python checks passed (`test_fallback_pipeline_state`, `test_quick_pipelines`, `test_utf8_paths`, `test_amd_subgroup_profiles`, `test_driver_faults`, `test_vendor_fixes`, `test_fallback_size_policy`, `test_radv_mesh_optimizer`, `test_global_table_loop`, `test_doc_anchors`, `test_mesh_fallback`, `test_mesh_fallback_failed_once`, `test_intel_quick_compute`); `scripts/check_third_party.py` passed; `longshot_vk.dll` built cleanly (`llvm-mingw`, `0 failed`). Isolated in-game run on RX 9060 XT (zero `longshot_env.txt`) verified `storage buffer tables searched in loops` active, `0` unoptimized task/mesh fallback logs, 185.2 avg / 230.3 median FPS, 1.82 ms avg / 0.40 ms median GPU time, and 0 render-thread catch-ups. The 3 unrelated Windows `clang++` failures seen in an earlier `--changed main` run (`test_fsr_uniform_ownership.py`, `test_replay_write_order.py`, `test_vk_occlusion_queries.py`) were directly reproduced (`0 passed, 3 failed`) on unmodified `main @ e41de662`. **Not tested:** interleaved 2+2 warm benchmark against `main @ e41de662`, full Linux build/suite, RDNA 4 on Linux RADV, and RDNA 2 regression check. **Must be tested:** - Windows, AMD RX 9000 series (RDNA 4) proprietary driver: warm up, then run 2+2 interleaved `main @ e41de662` vs `this PR @ d79a0580` in the same scene with default settings (no `RX_VK_GM_LOOP` or `RX_VK_MESH_OPT` overrides), expecting `storage buffer tables searched in loops`, no unoptimized Task/Mesh fallback log, higher FPS, and lower GPU frame time (Test Farm: @Beanstalk Please compare this PR against main e41de662 on Windows with an AMD Radeon RX 9000-series GPU and proprietary driver using default settings without RX_VK_GM_LOOP or RX_VK_MESH_OPT overrides, warm up then run main/PR/main/PR in the same scene and report frame-time, FPS and preparation results) - Windows, AMD RX 6600 / RDNA 2 proprietary driver: play Kokiri Forest with default settings, expecting `VK_PIPELINE_CREATE_DISABLE_OPTIMIZATION_BIT` to remain active and no device lost (Test Farm: @Beanstalk Please test on Windows with an AMD RX 6000 / RDNA 2 GPU on proprietary drivers in Kokiri Forest, confirming the log still prints `task and mesh programs built without the driver's optimizer` and no device lost occurs) - Linux, AMD RDNA 4 (`radv`): run `tests/run_all.py` and a gameplay smoke test, expecting unchanged behavior and all tests passing (Test Farm: @Beanstalk Please test on Linux with RADV by running `python -I -B tests/run_all.py` and a gameplay smoke test) ## Risks **What could break:** an AMD RDNA 4 driver regression with optimized Task/Mesh pipelines or dynamically indexed SSBO tables. **Turning it off:** set `RX_VK_GM_LOOP=0` and `RX_VK_MESH_OPT=0`, or revert the commit. **Compatibility:** `global_table_loop` is part of `translator_stamp()`, so on AMD RDNA 4 proprietary drivers the first launch after updating invalidates and rebuilds `longshot_programs.bin` and `longshot_vk_pipelines.bin` once; all other GPUs keep existing caches untouched. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [ ] Measurements has a verdict, or one line saying why there is nothing to measure. (pending isolated 2+2 runs on `main @ e41de662` vs `this PR @ d79a0580`; keep WIP until measured locally or on Test Farm) - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. Not ticked yet: The main-versus-PR comparison is still pending, and the first-launch cache rebuild cost is named but not measured. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [ ] `python -I -B tests/run_all.py` passes (13 targeted checks passed on `d79a0580` and 3 unrelated failures from earlier `--changed main` reproduced on `main @ e41de662`; full Windows/Linux suite run pending before removing `WIP:`). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [ ] Numbers from the same PC, scene and settings, at least 2 interleaved runs each, the median reported. (pending isolated 2+2 runs; keep WIP until collected) - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [ ] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (`llvm-mingw` Windows build and `test_utf8_paths.py` passed; Linux build untested locally and requested on Test Farm)
perf(vk): enable storage table loop and mesh optimizer on AMD RDNA 4
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
beanstalk/approval waiting for a BigBean's 👍 on the request
PR description / Description follows the template (pull_request_target) Successful in 3s
d79a0580ba
Author
First-time contributor

Tested in game: Windows 11, AMD Radeon RX 9060 XT (26.10.1): default env (no overrides), storage buffer tables searched in loops active, 0 unoptimized mesh logs, 185.2 avg / 230.3 med FPS, 1.82 ms avg / 0.40 ms med GPU

Tested in game: Windows 11, AMD Radeon RX 9060 XT (26.10.1): default env (no overrides), storage buffer tables searched in loops active, 0 unoptimized mesh logs, 185.2 avg / 230.3 med FPS, 1.82 ms avg / 0.40 ms med GPU
Author
First-time contributor

@Beanstalk Please compare this PR against main e41de662 on Windows with an AMD Radeon RX 9000-series GPU and proprietary driver using default settings without RX_VK_GM_LOOP or RX_VK_MESH_OPT overrides, warm up then run main/PR/main/PR in the same scene and report frame-time, FPS and preparation results

@Beanstalk Please compare this PR against main e41de662 on Windows with an AMD Radeon RX 9000-series GPU and proprietary driver using default settings without RX_VK_GM_LOOP or RX_VK_MESH_OPT overrides, warm up then run main/PR/main/PR in the same scene and report frame-time, FPS and preparation results
Member

@gmourao only members of BigBeans can start the farm. One of them can approve this request by reacting 👍 to it or to this comment.

@gmourao only members of `BigBeans` can start the farm. One of them can approve this request by reacting 👍 to it or to this comment.
Owner

Brought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).

  • Tested on my own PC: ticked: Testing's Tested: an isolated in-game run on Windows 11, RX 9060 XT, matching the author's in-game comment.
  • Nothing gets worse that I know of: not ticked: The main-versus-PR comparison is still pending, and the first-launch cache rebuild cost is named but not measured. Measure that cost and state it in Risks, then tick it.
Brought up to the [ready-for-review standard](https://git.magicbean.dev/MagicBeanDev/Longshot/src/branch/main/CONTRIBUTING.md#ready-for-review-out-of-wip) (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know). - *Tested on my own PC*: ticked: Testing's Tested: an isolated in-game run on Windows 11, RX 9060 XT, matching the author's in-game comment. - *Nothing gets worse that I know of*: not ticked: The main-versus-PR comparison is still pending, and the first-launch cache rebuild cost is named but not measured. Measure that cost and state it in Risks, then tick it.
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
beanstalk/approval waiting for a BigBean's 👍 on the request
PR description / Description follows the template (pull_request_target) Successful in 3s
This pull request is marked as a work in progress.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'perf/vk-rdna4-table-loop-mesh-opt:gmourao-perf/vk-rdna4-table-loop-mesh-opt'
git switch 'gmourao-perf/vk-rdna4-table-loop-mesh-opt'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1308
No description provided.