WIP: fix(vk): a pipeline is drawn only with the program object it was built from #1297

Draft
TrashPanda wants to merge 2 commits from TrashPanda/Longshot:fix/pipe-by-program into main
Contributor

Type: fix · Risk: medium · Tested on: Linux, game-free only · Needs: NVIDIA, Lake Hylia, in the game

Why

A pipeline's key names its program by code and variant hash, and two program objects can share both. The draw then ran one program's shaders under the other's layout, descriptors and constants. With the scene's lit programs a light loop read garbage for its count and the GPU never finished the draw: the picture stopped, then the device was lost, near water on NVIDIA. Hookshot reproduced it at Lake Hylia, six runs of six, and none with this fix.

Ported from Hookshot 65e2cb91 (NotRexed, from pixl27's 8b1e96ad): git.notrexed.dev/Hookshot/Hookshot@65e2cb91d2

The tracker was searched for RX_VK_PIPE_BY_PROGRAM and "pipe by program": no pull request or issue is this fix. Nearby Lake Hylia reports (#317, #1193) are other crashes.

How to reproduce

Seen on: Hookshot's report: NVIDIA, Lake Hylia. Not yet run on Longshot.
Settings and switches: defaults (RX_VK_PIPE_BY_PROGRAM unset, so the fix is on).
Steps: play at Lake Hylia, near the water, several times.
Expected: the picture keeps drawing.
Actual: on Hookshot's main, the device was lost, six runs of six. Longshot main still shares a pipeline by key alone, which is the same cause.

What changed

A pipeline is drawn only with the program object it was built from. A draw whose object differs gets a pipeline of its own. RX_VK_PIPE_BY_PROGRAM=0 shares by the key alone, as before.

  • renderer: PipeEntry in gpu/vk/vk_draw.cpp keeps the program object. graphics_pipeline refuses an entry built for a different object. pipeline_keep_ready stores that object, and only that object takes the kept pipeline (vk_pipelines.h, vk_programs.cpp, the precompile).
  • test: tests/test_pipe_by_program.py reads those sites. tests/precompile_pipeline_cleanup_test.cpp forward-declares Program so the cut still compiles.
  • docs: RX_VK_PIPE_BY_PROGRAM in docs/development.md.

Measurements

Verdict: the game-free check fails before the fix and passes here. Nothing in the game has been measured. The upstream Lake Hylia count (6/6 device lost, 0/6 with the fix) is Hookshot's, not a Longshot run.

Hardware: Linux, no GPU run.
Scene: none.
Method: python -I -B tests/test_pipe_by_program.py on the test commit and on this head.
How to reproduce: check out ccff9189 (the test alone, on main f88e6e3a) and run the command; then this head.

Before: main @ f88e6e3a plus the test @ ccff9189 After: this PR @ 29406ea9
tests/test_pipe_by_program.py fails: PipeEntry does not keep the program object it was built from PASS
AssertionError: PipeEntry does not keep the program object it was built from
PASS: a pipeline is drawn only with the program object it was built from

Removing the prog field and putting it back was checked on the earlier base: the test failed for that reason, then passed. The rebase onto f88e6e3a did not change those lines.

tests/test_precompile_pipeline_cleanup.py and tests/test_quick_pipelines.py pass here. They compile the PipeEntry cut. The full tests/run_all.py has not been run.

Flags and settings

One switch, on unless set off.

Flag What it is Before this PR After this PR Effect Helps / doesn't help / untested Recommendation
RX_VK_PIPE_BY_PROGRAM Draw a pipeline only with the program object it was built from absent (shared by key) on unless =0 A second object with the same key gets its own pipeline Untested in Longshot. Hookshot: Lake Hylia, NVIDIA, 6/6 device lost before, none after On for everyone. =0 is the old sharing

Testing

Tested: Linux, game-free. tests/test_pipe_by_program.py fails on the test commit and passes on 29406ea9. The precompile-cleanup and quick-pipeline cuts compile and pass.

Not tested: the game, any GPU, Windows, a full tests/run_all.py. This PC is not running the game. Opened with --force because Joey asked, so the Test Farm can run Lake Hylia.

Must be tested:

  • NVIDIA, Lake Hylia (Windows or Linux): play near the water several times, expecting the picture to keep drawing and no device loss. A log line vk: pipeline ... was made for another program object means the fix took the new path. RX_VK_PIPE_BY_PROGRAM=0 is the comparison if the picture looks wrong. Test Farm: @Beanstalk NVIDIA, Lake Hylia, near the water, several runs, expecting no device loss.

Risks

What could break: a draw can build a second pipeline when two program objects share a key. A wrong match would change which shaders run, or spend extra pipelines. The fast path already keyed its one-draw cache by the program object's address; this is the shared cache.

Turning it off: RX_VK_PIPE_BY_PROGRAM=0.

Compatibility: nothing in saves or options. A pipeline made for a second object is not written into the noted list (its key holds an address). MKWVK_API_VERSION is unchanged.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named). Not run yet. The three checks named above passed.
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value.
  • A game-free test added for the fix, failing on main and passing here.
  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Docs updated.
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. The renderer was not built. The PipeEntry cuts compiled on Linux.
**Type:** fix · **Risk:** medium · **Tested on:** Linux, game-free only · **Needs:** NVIDIA, Lake Hylia, in the game ## Why A pipeline's key names its program by code and variant hash, and two program objects can share both. The draw then ran one program's shaders under the other's layout, descriptors and constants. With the scene's lit programs a light loop read garbage for its count and the GPU never finished the draw: the picture stopped, then the device was lost, near water on NVIDIA. Hookshot reproduced it at Lake Hylia, six runs of six, and none with this fix. Ported from Hookshot `65e2cb91` (NotRexed, from pixl27's `8b1e96ad`): https://git.notrexed.dev/Hookshot/Hookshot/commit/65e2cb91d216678b3c296e78a1d93e7502751473 The tracker was searched for `RX_VK_PIPE_BY_PROGRAM` and "pipe by program": no pull request or issue is this fix. Nearby Lake Hylia reports (#317, #1193) are other crashes. ## How to reproduce **Seen on:** Hookshot's report: NVIDIA, Lake Hylia. Not yet run on Longshot. **Settings and switches:** defaults (`RX_VK_PIPE_BY_PROGRAM` unset, so the fix is on). **Steps:** play at Lake Hylia, near the water, several times. **Expected:** the picture keeps drawing. **Actual:** on Hookshot's main, the device was lost, six runs of six. Longshot main still shares a pipeline by key alone, which is the same cause. ## What changed A pipeline is drawn only with the program object it was built from. A draw whose object differs gets a pipeline of its own. `RX_VK_PIPE_BY_PROGRAM=0` shares by the key alone, as before. - renderer: `PipeEntry` in `gpu/vk/vk_draw.cpp` keeps the program object. `graphics_pipeline` refuses an entry built for a different object. `pipeline_keep_ready` stores that object, and only that object takes the kept pipeline (`vk_pipelines.h`, `vk_programs.cpp`, the precompile). - test: `tests/test_pipe_by_program.py` reads those sites. `tests/precompile_pipeline_cleanup_test.cpp` forward-declares `Program` so the cut still compiles. - docs: `RX_VK_PIPE_BY_PROGRAM` in `docs/development.md`. ## Measurements **Verdict:** the game-free check fails before the fix and passes here. Nothing in the game has been measured. The upstream Lake Hylia count (6/6 device lost, 0/6 with the fix) is Hookshot's, not a Longshot run. Hardware: Linux, no GPU run. Scene: none. Method: `python -I -B tests/test_pipe_by_program.py` on the test commit and on this head. How to reproduce: check out `ccff9189` (the test alone, on main `f88e6e3a`) and run the command; then this head. | | Before: main @ f88e6e3a plus the test @ ccff9189 | After: this PR @ 29406ea9 | |---|---|---| | `tests/test_pipe_by_program.py` | fails: PipeEntry does not keep the program object it was built from | PASS | ``` AssertionError: PipeEntry does not keep the program object it was built from PASS: a pipeline is drawn only with the program object it was built from ``` Removing the `prog` field and putting it back was checked on the earlier base: the test failed for that reason, then passed. The rebase onto `f88e6e3a` did not change those lines. `tests/test_precompile_pipeline_cleanup.py` and `tests/test_quick_pipelines.py` pass here. They compile the `PipeEntry` cut. The full `tests/run_all.py` has not been run. ### Flags and settings One switch, on unless set off. | Flag | What it is | Before this PR | After this PR | Effect | Helps / doesn't help / untested | Recommendation | |---|---|---|---|---|---|---| | `RX_VK_PIPE_BY_PROGRAM` | Draw a pipeline only with the program object it was built from | absent (shared by key) | on unless `=0` | A second object with the same key gets its own pipeline | Untested in Longshot. Hookshot: Lake Hylia, NVIDIA, 6/6 device lost before, none after | On for everyone. `=0` is the old sharing | ## Testing **Tested:** Linux, game-free. `tests/test_pipe_by_program.py` fails on the test commit and passes on `29406ea9`. The precompile-cleanup and quick-pipeline cuts compile and pass. **Not tested:** the game, any GPU, Windows, a full `tests/run_all.py`. This PC is not running the game. Opened with `--force` because Joey asked, so the Test Farm can run Lake Hylia. **Must be tested:** - NVIDIA, Lake Hylia (Windows or Linux): play near the water several times, expecting the picture to keep drawing and no device loss. A log line `vk: pipeline ... was made for another program object` means the fix took the new path. `RX_VK_PIPE_BY_PROGRAM=0` is the comparison if the picture looks wrong. Test Farm: @Beanstalk NVIDIA, Lake Hylia, near the water, several runs, expecting no device loss. ## Risks **What could break:** a draw can build a second pipeline when two program objects share a key. A wrong match would change which shaders run, or spend extra pipelines. The fast path already keyed its one-draw cache by the program object's address; this is the shared cache. **Turning it off:** `RX_VK_PIPE_BY_PROGRAM=0`. **Compatibility:** nothing in saves or options. A pipeline made for a second object is not written into the noted list (its key holds an address). `MKWVK_API_VERSION` is unchanged. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [ ] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). Not run yet. The three checks named above passed. - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Switches documented (docs/development.md; the README for a menu row) and shipped at their recommended value. - [x] A game-free test added for the fix, failing on `main` and passing here. - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Docs updated. - [ ] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. The renderer was not built. The PipeEntry cuts compiled on Linux.
Two program objects can share a pipeline key. On main the draw takes that
pipeline for either object, which is the NVIDIA device loss near water.
This check fails until the entry keeps the program it was built from.

Ported-from: 65e2cb91d2
Co-authored-by: NotRexed <[email protected]>
Co-authored-by: pixl27 <[email protected]>
Assisted-by: Grok 4.7
fix(vk): a pipeline is drawn only with the program object it was built from
Some checks failed
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 5s
beanstalk/approval approved by futondestroyer (reviewed)
beanstalk/nvidia 2/1 fail
29406ea9d1
A pipeline key names a program by code and variant hash, so two program
objects shared one pipeline and a draw ran one program's shaders under the
other's layout. Near water on NVIDIA that lost the device. The entry now
keeps the object it was built from; a draw whose object differs gets its
own pipeline. RX_VK_PIPE_BY_PROGRAM=0 shares by the key alone, as before.

Ported-from: 65e2cb91d2
Co-authored-by: NotRexed <[email protected]>
Co-authored-by: pixl27 <[email protected]>
Assisted-by: Grok 4.7
Author
Contributor

@Beanstalk NVIDIA, Lake Hylia, near the water, several runs. Expect the picture to keep drawing and no device loss. A log line "vk: pipeline ... was made for another program object" means this fix took the new path. RX_VK_PIPE_BY_PROGRAM=0 is the old sharing if the picture looks wrong. Not run in the game yet; Joey asked for this pull request so the farm can take that run.

@Beanstalk NVIDIA, Lake Hylia, near the water, several runs. Expect the picture to keep drawing and no device loss. A log line "vk: pipeline ... was made for another program object" means this fix took the new path. RX_VK_PIPE_BY_PROGRAM=0 is the old sharing if the picture looks wrong. Not run in the game yet; Joey asked for this pull request so the farm can take that run.
Member

@TrashPanda only members of BigBeans can start the farm. One of them can approve this request by reacting 👍 to it or to this comment.

@TrashPanda only members of `BigBeans` can start the farm. One of them can approve this request by reacting 👍 to it or to this comment.
Collaborator

Possibly related, for context:

  • PR #801 WIP: feat(vk): vertex input as dynamic state, so one pipeline serves every vertex layout of a program (RX_VK_DYNAMIC_VERTEX_INPUT, opt-in) — Open Vulkan pipeline change also edits shared pipeline-key and draw paths; review for code overlap.
Possibly related, for context: - PR #801 WIP: feat(vk): vertex input as dynamic state, so one pipeline serves every vertex layout of a program (RX_VK_DYNAMIC_VERTEX_INPUT, opt-in) — Open Vulkan pipeline change also edits shared pipeline-key and draw paths; review for code overlap.
Member

Beanstalk test farm

Commit 29406ea · tier reviewed · approved by futondestroyer (👍 on TrashPanda's request) · dashboard

What will be tested · AI plan (gpt-6.1-terra)

On NVIDIA, three runs per build will teleport to Lake Hylia and exercise the water area. The plan compares pictures and frame times with main, checks that frames continue presenting, and fails on device loss, crashes, major frame-time regressions, or large visual differences. The new-path log line will be recorded if it appears, but its absence will not fail the test because the collision may not occur. The game runs take approximately 40 minutes per tester.

  • Where: nvidia (1-2 reports).
  • lake-water: from a new save, then teleport to Lake Hylia, take the picture lake-arrival to compare with main, move the stick, measure water for 30 s (after 5 s warm-up), take the picture lake-after to compare with main; 3 runs on each side.
  • Measured: crashes, frame times, stutters and hitches, the game's log.
  • The PR fails if: it crashes; or a picture differs from main by more than 15%; or frame time (p99) is more than 30% above main; or forbidden log lines is above 0.
  • Time: about 41 min of game runs per tester (6 game starts), plus the two builds.

Done (started 01:54 UTC, last report 03:52 UTC). Comment @Beanstalk to run it again.

Target Reports Crash Frame p99 (ms) vs main VRAM peak (MB) vs main Result
nvidia · 1: windows+nvidia+nvidia-proprietary+dgpu NVIDIA GeForce RTX 4070, 621.1.0; 2: linux+nvidia+nvidia-proprietary+dgpu NVIDIA GeForce RTX 3080 Ti, 620.70.6 2/1 1 2 3 PR runs 20.8 vs 20.1 (+3%) — fail ⚠ outlier

Measurements · nvidia

Verdict: fail on nvidia (2/1 report): lake-water crash; lake-water screenshot.max_diff failed.

Hardware: 1: windows+nvidia+nvidia-proprietary+dgpu NVIDIA GeForce RTX 4070, 621.1.0 13th Gen Intel(R) Core(TM) i7-13700F, 32 GB RAM; 2: linux+nvidia+nvidia-proprietary+dgpu NVIDIA GeForce RTX 3080 Ti, 620.70.6 AMD Ryzen 9 3900X 12-Core Processor, 48 GB RAM
Scene: lake-water, from a new save; each cell's settings and switches as the table names them
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); lake-water: 3 game starts a side, water 30 s after 5 s warm-up; each number the median of the runs, then of 2 reports
How to reproduce: the farm's plan above (@Beanstalk on this PR runs it again)

Before: main @ f88e6e3 After: this PR @ 29406ea
lake-water · water · frame time (p99) (ms) 20.1 20.8 (+3%)
lake-water · forbidden log lines 0.0 0.0

Flags and settings

None: the plan varied no setting, switch or build option.

Markdown for the PR description
## Measurements

**Verdict:** fail on nvidia (2/1 report): `lake-water crash`; `lake-water screenshot.max_diff` failed.

Hardware: 1: windows+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 4070, 621.1.0` `13th Gen Intel(R) Core(TM) i7-13700F, 32 GB RAM`; 2: linux+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 3080 Ti, 620.70.6` `AMD Ryzen 9 3900X 12-Core Processor, 48 GB RAM`  
Scene: lake-water, from a new save; each cell's settings and switches as the table names them  
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); lake-water: 3 game starts a side, water 30 s after 5 s warm-up; each number the median of the runs, then of 2 reports  
How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again)

| | Before: main @ f88e6e3 | After: this PR @ 29406ea |
|---|---|---|
| lake-water · water · frame time (p99) (ms) | 20.1 | 20.8 (+3%) |
| lake-water · forbidden log lines | 0.0 | 0.0 |

### Flags and settings

None: the plan varied no setting, switch or build option.
<!-- beanstalk:sticky --> ### Beanstalk test farm Commit `29406ea` · tier **reviewed** · approved by futondestroyer (👍 on TrashPanda's request) · [dashboard](https://beanstalk.magicbean.dev/prs/1297) **What will be tested** · AI plan (`gpt-6.1-terra`) On NVIDIA, three runs per build will teleport to Lake Hylia and exercise the water area. The plan compares pictures and frame times with main, checks that frames continue presenting, and fails on device loss, crashes, major frame-time regressions, or large visual differences. The new-path log line will be recorded if it appears, but its absence will not fail the test because the collision may not occur. The game runs take approximately 40 minutes per tester. - **Where:** nvidia (1-2 reports). - **lake-water:** from a new save, then teleport to Lake Hylia, take the picture lake-arrival to compare with main, move the stick, measure water for 30 s (after 5 s warm-up), take the picture lake-after to compare with main; 3 runs on each side. - **Measured:** crashes, frame times, stutters and hitches, the game's log. - **The PR fails if:** it crashes; or a picture differs from main by more than 15%; or frame time (p99) is more than 30% above main; or forbidden log lines is above 0. - **Time:** about 41 min of game runs per tester (6 game starts), plus the two builds. Done (started 01:54 UTC, last report 03:52 UTC). Comment `@Beanstalk` to run it again. | Target | Reports | Crash | Frame p99 (ms) vs main | VRAM peak (MB) vs main | Result | | --- | --- | --- | --- | --- | --- | | nvidia · 1: windows+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 4070, 621.1.0`; 2: linux+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 3080 Ti, 620.70.6` | 2/1 [1](https://beanstalk.magicbean.dev/reports/rp_98824ee07d8f7169) [2](https://beanstalk.magicbean.dev/reports/rp_1694de6e1b6228de) | 3 PR runs | 20.8 vs 20.1 (+3%) | — | fail ⚠ outlier | #### Measurements · nvidia **Verdict:** fail on nvidia (2/1 report): `lake-water crash`; `lake-water screenshot.max_diff` failed. Hardware: 1: windows+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 4070, 621.1.0` `13th Gen Intel(R) Core(TM) i7-13700F, 32 GB RAM`; 2: linux+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 3080 Ti, 620.70.6` `AMD Ryzen 9 3900X 12-Core Processor, 48 GB RAM` Scene: lake-water, from a new save; each cell's settings and switches as the table names them Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); lake-water: 3 game starts a side, water 30 s after 5 s warm-up; each number the median of the runs, then of 2 reports How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again) | | Before: main @ f88e6e3 | After: this PR @ 29406ea | |---|---|---| | lake-water · water · frame time (p99) (ms) | 20.1 | 20.8 (+3%) | | lake-water · forbidden log lines | 0.0 | 0.0 | ### Flags and settings None: the plan varied no setting, switch or build option. <details><summary>Markdown for the PR description</summary> ```markdown ## Measurements **Verdict:** fail on nvidia (2/1 report): `lake-water crash`; `lake-water screenshot.max_diff` failed. Hardware: 1: windows+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 4070, 621.1.0` `13th Gen Intel(R) Core(TM) i7-13700F, 32 GB RAM`; 2: linux+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 3080 Ti, 620.70.6` `AMD Ryzen 9 3900X 12-Core Processor, 48 GB RAM` Scene: lake-water, from a new save; each cell's settings and switches as the table names them Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); lake-water: 3 game starts a side, water 30 s after 5 s warm-up; each number the median of the runs, then of 2 reports How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again) | | Before: main @ f88e6e3 | After: this PR @ 29406ea | |---|---|---| | lake-water · water · frame time (p99) (ms) | 20.1 | 20.8 (+3%) | | lake-water · forbidden log lines | 0.0 | 0.0 | ### Flags and settings None: the plan varied no setting, switch or build option. ``` </details>
Author
Contributor

The farm's Lake Hylia run (report 1: Windows, RTX 4070; report 2: Linux, RTX 3080 Ti), read run by run:

  • Crashes are not only on this side. On Windows, main crashed or hung in 2 of 3 runs and this PR in 2 of 3 (PR run 2 exited 0xC0000005). On Linux, one PR run hung of 3 and no main run did. Neither log tail shows a device loss or the new-path line vk: pipeline ... was made for another program object.
  • Frame time p99 is within the limit (+3%).
  • The pictures differ from main by 0.20 to 0.45 on both machines, over the 0.15 limit. I cannot see the pictures (they need a sign-in), so I can't yet say whether that is this fix drawing differently or the water and the camera differing from run to run.

To tell those apart, the same scene with the fix off on this build would show the noise floor:

@Beanstalk NVIDIA, Lake Hylia water as before, three cells: main, this PR, and this PR with RX_VK_PIPE_BY_PROGRAM=0. If the PR with the switch off differs from main as much as the PR does, the picture difference is the scene's, not this fix's. Count crashes and hangs per cell, and record whether the line vk: pipeline ... was made for another program object appears.

The farm's Lake Hylia run (report 1: Windows, RTX 4070; report 2: Linux, RTX 3080 Ti), read run by run: - Crashes are not only on this side. On Windows, main crashed or hung in 2 of 3 runs and this PR in 2 of 3 (PR run 2 exited `0xC0000005`). On Linux, one PR run hung of 3 and no main run did. Neither log tail shows a device loss or the new-path line `vk: pipeline ... was made for another program object`. - Frame time p99 is within the limit (+3%). - The pictures differ from main by 0.20 to 0.45 on both machines, over the 0.15 limit. I cannot see the pictures (they need a sign-in), so I can't yet say whether that is this fix drawing differently or the water and the camera differing from run to run. To tell those apart, the same scene with the fix off on this build would show the noise floor: @Beanstalk NVIDIA, Lake Hylia water as before, three cells: main, this PR, and this PR with `RX_VK_PIPE_BY_PROGRAM=0`. If the PR with the switch off differs from main as much as the PR does, the picture difference is the scene's, not this fix's. Count crashes and hangs per cell, and record whether the line `vk: pipeline ... was made for another program object` appears.
Member

@TrashPanda only members of BigBeans can start the farm. One of them can approve this request by reacting 👍 to it or to this comment.

@TrashPanda only members of `BigBeans` can start the farm. One of them can approve this request by reacting 👍 to it or to this comment.
Some checks failed
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 5s
beanstalk/approval approved by futondestroyer (reviewed)
beanstalk/nvidia 2/1 fail
This pull request is marked as a work in progress.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/pipe-by-program:TrashPanda-fix/pipe-by-program'
git switch 'TrashPanda-fix/pipe-by-program'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1297
No description provided.