WIP: docs: the readme's work/ffx-sdk path, and the RTX 5090 pipeline list's note says what its build changed #1166
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1166
Loading…
Reference in a new issue
No description provided.
Delete branch "TrashPanda/Longshot:docs/readme-release-notes"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: docs · Risk: low · Tested on: Linux, RTX 4070 Ti (game-free checks) · Needs: none
Why
The readme showed the default FFX SDK folder with a form feed in its name, and a shipped pipeline list's note did not say what its build was.
Restored from Hookshot 2553, Hookshot 2703, by Dukenheimer, RoblesLeo, and split out of #284 so it can be reviewed and merged on its own.
What changed
Two text fixes, nothing else.
Commits, each with its original author and message:
c2c77ea0fix: readme's work/ffx-sdk, and the build log names an FSR 4 tick without AMD's license (RoblesLeo)Follow-up to https://github.com/NotRexed/Hookshot/pull/1866's review.
HOOKSHOT_FFX_SDKfolder readwork<0x0C>fx-sdk(a\fhad turned into a form feed). It readswork/ffx-sdknow.for AMD's license still builds with FSR 4 and fetches nothing, as
before. The build log now says so in one line: "AMD's license not
accepted yet: tick AMD FSR 4 again to have its runtime fetched".
tests/test_ffx_sdk.py's source check covers the line.Ran locally on Windows:
test_ffx_sdk,test_make_game_ngx,test_builder_dlss_updateanddotnet buildof the Builder, allpassing.
🤖 Generated with Claude Code
Co-authored-by: Claude Opus 5.5 [email protected]
Co-authored-by: NotRexed [email protected]
Ported to Longshot: only the readme fix. Longshot's builder is command line only (#181), so the Builder window's
log line and its source check are left out.
Restored-from: https://github.com/NotRexed/Hookshot/pull/2553
47115d72build(release): the RTX 5090 fork list's note says what its build changed (a follow-up to Hookshot PR 2143) (Dukenheimer)Follow-up to https://github.com/NotRexed/Hookshot/pull/2143, which merged before I could answer Joey-Magnus's and
hckrman101's question about
brett-d-rtx-5090-fork-fg-2x. This changesonly that list's note, to say what its build was.
The "fork" was local builds of main at
0828863(9 Nov), plus changesthat don't touch what goes into a record: DLSS-NR and an FXAA option in
the window-scaling pass, a sampler cache and its descriptor-reuse check,
a texture budget, menu rows and a voice feature. There are no changes to
shader translation, program variants, target formats or draw state.
python -I nx2/pipeline_states.py checkpasses. The list itself isunchanged.
Refs https://github.com/NotRexed/Hookshot/issues/2034, https://github.com/NotRexed/Hookshot/pull/2143
Co-authored-by: Copilot App [email protected]
Co-authored-by: NotRexed [email protected]
Restored-from: https://github.com/NotRexed/Hookshot/pull/2703
Measurements
Verdict: nothing to measure: a correctness fix off the frame path, covered by game-free checks.
Flags and settings
None.
Testing
Tested: On Linux (kernel 7.0), RTX 4070 Ti,
main@71b1edd8, this PR @47115d72:the checks that read the changed files (tests/run_all.py --changed origin/main)pass. The full suite (tests/run_all.py) has not been run on this branch yet; a comment will follow when it has.Not tested: Nothing to run. Opened as work in progress until it runs in the game.
Must be tested:
Risks
What could break: nothing.
Turning it off: revert the commit.
Compatibility: Nothing changes.
Checklist
Everyone
type(scope): description) of the status line's type.can't be run by hand is in Testing's Not testable by hand, with why.
in Risks.
main.third_party/untouched (a new folder with aPROVENANCE.mdinstead).python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).When it applies
Assisted-by:/Co-Authored-By:trailers.Tested in game: Linux (Ubuntu 26.04.1, kernel 7.0.0-43), RTX 4070 Ti 12 GB, NVIDIA 595.99.02, Ryzen 7 9800X3D: this branch built together with the other 18 split from #218 and #284-#288, merged onto main @
71b1edd8(make_game.py --update, build v3.0.0-rc.5-82-g5952bb3d), then played by a scripted tour through the control bridge (scripts/memtour.py: a save loaded, Zora's Domain, the Market, Hyrule Field and Death Mountain Trail, 40 s each with walking and camera swings). All 4 stops reached, a clean quit, and no device loss or Vulkan error in the log. Docs and a list's note only; the build and the game ran with them.Brought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.