docs: the workflow names the forge, CI and the Test Farm as they are after the move #1145
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1145
Loading…
Reference in a new issue
No description provided.
Delete branch "TrashPanda/Longshot:docs/workflow-current-forge"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: docs · Risk: low · Tested on: Linux, game-free checks only · Needs: none
Why
A newcomer reading the workflow is told things that stopped being true at the move: AGENTS.md says there is no CI
(there is, and fork PRs wait for a label), workflow.md calls GitHub issues the record and leaves out the Test Farm,
CONTRIBUTING.md names a skill that doesn't exist, and the worklist's bare
#Nnumbers are Hookshot's but now link tounrelated Longshot items, while Hookshot's GitHub repository no longer opens at all.
What changed
The four pages now describe the forge, CI and the Test Farm as they are, and say where Hookshot's old numbers live.
workflow lint, guide screenshots, third-party); the Python suite and SPIR-V fixtures are a manual run of the
CIworkflow. CircleCI runs the path-selected game-free checks, and a fork waits for a maintainer's
ci: approvedlabel. Running
tests/run_all.pybefore opening stays.the archived mirror with the same numbers; the Test Farm's comment and checks are a source; the CI row names both
systems.
#Nare Hookshot's; a row someone touches links them by full URL onMagicBeanDev/Hookshot. The rows themselves are not re-scored here./magicbean:batch-reviewis/magicbean:review(Tooling's skill).Measurements
Verdict: docs only, nothing to measure: the doc checks pass on main and with this PR.
Hardware: Ubuntu 26.04, Ryzen 7 9800X3D, 30 GB RAM, RTX 4070 Ti (not used: game-free checks)
Scene: none, no game run; the doc checks
Method:
run_all.py doconce on main and once on this branch (deterministic, so one run each)How to reproduce:
python3 -I -B tests/run_all.py doc71b1edd8f9001d46run_all.py doc(test_doc_anchors,test_linux_docker_packages)Flags and settings
None.
Testing
Tested: on Linux (Ubuntu 26.04): the doc checks above; every new link opens (the forge's issues, the Hookshot
mirror's issue 993 and PR 2843, beanstalk.magicbean.dev). The whole
python -I -B tests/run_all.pyhas the sameresult as on main on this PC: 16 checks fail on a clean main too (
test_walk_key,test_lift_lookups,test_make_game_cacheand others; GCC 15 and Python 3.14 here, newer than CI's), none of them reads these pages.Not tested: nothing the game runs changed.
Must be tested: None.
Risks
What could break: nothing the game runs.
Turning it off: revert the commit.
Compatibility: Nothing changes.
Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named).third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.WIP: docs: the workflow names the forge, CI and the Test Farm as they are after the moveto docs: the workflow names the forge, CI and the Test Farm as they are after the moveBasic code-only review of
5c1e0a710c; informational feedback, with final approval left to another reviewer.One small documentation correction:
AGENTS.md:81–83says Forgejo'sCIand CircleCI run the game-free checks on every PR. In.forgejo/workflows/ci.yml:65,179, the Python suite and SPIR-V fixtures are restricted toworkflow_dispatch; automatic Forgejo CI runs the light checks. CircleCI's same-repository PR workflow also selects suites by changed paths. Theci: approvedlabel described indocs/ci.mdauthorizes CircleCI's fork pipeline, rather than all Forgejo checks.Please distinguish those paths so a contributor does not interpret a green light-check result as evidence that the full suite ran. Suggested wording: “Forgejo runs light PR checks; CircleCI runs the applicable game-free checks. Forks need a maintainer's
ci: approvedlabel for CircleCI. Forgejo's full suites remain manually dispatched.” Keep the localrun_all.pyrequirement as written.The remaining changes consistently point newcomers to the current issue tracker, Test Farm and review skill. The author reports both documentation checks passing before and after, with pre-existing full-suite failures disclosed. This is documentation only; no game validation is needed for these edits.
No tests or builds run.
The CI sentence in AGENTS.md was wrong, as the review said. On current main, Forgejo's automatic pull-request jobs are the light ones: the title, the description, workflow lint, guide screenshots and third-party. In
.forgejo/workflows/ci.ymlthe Python suite and the SPIR-V fixtures run only onworkflow_dispatch. CircleCI's gate runs the game-free checks the changed paths select (docs/ci.md); a fork waits forci: approvedbefore that runs.AGENTS.md now says that, in
f9001d46.python -I -B tests/run_all.py docon that commit: 2 passed. The description's After column namesf9001d46.The branch is still based on main
71b1edd8, 19 commits behind current maindf6180c3. This commit sits on the existing one; the history was not rewritten. Approval still needs another reviewer.Follow-up on
f9001d464d568f25d06e4250c41d2482f6a82322: the CI wording issue in my earlier note is resolved.The change since that note is confined to the
AGENTS.mdparagraph. It now distinguishes Forgejo's light PR checks, CircleCI's applicable checks and fork label, and the manually dispatched Python/SPIR-V suites. I checked it against the workflow conditions and CircleCI routing at this head; the localrun_all.pyrequirement remains intact. No further actionable finding in this documentation follow-up.Read-only check; no tests or builds run. The author reports the two documentation checks passing at this head; I have not independently reproduced them.
This is an ordinary follow-up note, not an approval; final review remains with another reviewer.
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.