fix(vk): the window's swapchain is let go at the close, not at the process's end #1105

Open
omgitsgela wants to merge 10 commits from omgitsgela/Longshot:fix/deck-exit-display-release into main
Contributor

Type: fix · Risk: low · Tested on: Steam Deck LCD (Jupiter, RADV VANGOGH), SteamOS, Game Mode + desktop; Linux x86-64 game-free checks · Needs: any Game Mode player who hits the post-exit artifact; Wayland/X desktop and Windows near a close

Status

Ready for review and for other Game Mode players to test. On this Deck (LCD): the fix installs and runs, its close marker fires exactly once per quit, and no regression appeared. Three scripted repro conditions (light 1280x800; deep 2304x1440 loop-walk; fresh-area teleport-and-quit) ran paired old-vs-fixed; none reproduced the liftoff ENOMEM/modeset fingerprint even on the unfixed build, despite peaks matching the reported couch session (10.1/10.5 GB vs 9.9 GB). Details and the full protocol in the comments on this PR (latest: #issuecomment-35622) and in the run files docs/tested/2026-11-16-deck-exit-close-omgitsgela-gm01.md and …suite01.md. The scripted harness cannot discriminate the race; real-world play from other Game Mode users is now the confirmation path.

Why

A player quit Longshot inside the Deck's Game Mode. Afterwards rainbow/garbage pixels lingered on top of the Game Mode UI until they switched to desktop mode; returning to Game Mode later was clean. They nearly thought their GPU had died. (Reported in the couch session of 2026-11-15; machine evidence below.)

The Deck's own logs from that second:

  • the game's log (~/.local/share/Steam/logs/console-linux.txt, Game Mode pipes stdout there), 19:59:14: working set 7136 MB (peak 9902), VRAM 3710/5890 MB, the ~9.8 GB memfd guest window shared with the GPU as dma-bufs, last line display: window closed, exiting;
  • the journal at the same second, gamescope's compositor making its final display commit as the window goes away: liftoff: drmModeAtomicCommit: Cannot allocate memory (×4), xwm: Failed to prepare 1-layer flip (Cannot allocate memory), then a re-detect storm, drm: could not find mode!, xwm: We failed our modeset and have no mode to fall back to! in a loop.

The correlation is exact and the mechanism is plausible: at exit this process holds most of the system's memory, and the commit's own allocation fails. A failed modeset leaves the scan-out pointing at buffers the emulator owned — which is what "garbage over the UI" looks like — and a mode switch rebuilds the display config, which is exactly how the player recovered. gamescope's own tracker has prior art for a stuck final frame on game exit (ValveSoftware/gamescope#1822).

What this PR does not claim: that the ENOMEM is proven caused by our allocations (timestamp correlation is not proof), or that it explains every post-exit artifact. Two minutes earlier the same session logged create_swapchain: Surface already had a gamescope_swapchain at an in-game resolution change, and Mesa/gamescope bugs of their own exist. But our exit path has a real, fixable gap regardless — see How to reproduce.

How to reproduce

Seen on: SteamOS (Steam Deck LCD, Jupiter / RADV VANGOGH), Game Mode, session after long heavy play (that one session; scripted arms under this PR's Measurements did not re-trigger it).
Settings and switches: defaults; the couch session ran at native 1280x800 with the launcher's env file switches.
Steps: play a heavy outdoor area until the game's working set approaches the system ceiling (the couch session reached working set ~7.1 GB, peak 9.9 GB of a 14.8 GB pool), then quit the game (window close or menu exit) while still in Game Mode.
Expected: the Game Mode UI returns clean.
Actual: that session (not since reproduced by script): garbage/rainbow pixels over the Game Mode UI until a session switch to desktop mode; the journal shows the liftoff ENOMEM + modeset-failure storm at the quit second. Honest caveat: three scripted paired repro conditions (this PR's Measurements) never triggered the fingerprint even on unfixed main, despite matching the couch memory peaks. The reproducible part is the code gap below; the visual artifact needs a player who hits it.

The code gap, checkable on main without the bug: mkwvk_close_asked (the deliberate close: window closed, control-bridge quit, menu's Restart now) saves the pipeline cache and stops the shader preparers — and then nothing. No device wait, no swapchain destroy, no semaphore release. Every Vulkan object, including the swapchain's images and whatever they pin in VRAM/GTT, goes down only when the process exits, racing the compositor's final frames. A grep on main: retire_swapchain() exists (device wait idle, drop views, destroy the rendered semaphores, destroy the chain) and is never called from any close path.

What changed

At the deliberate close, the renderer now lets go of the window's GPU-side display resources deliberately and in order, instead of leaving process teardown to race the compositor.

  • gpu/vk/vk_internal.h: dev.closing (atomic bool); externs the present mutex.
  • gpu/vk/vk_main.cpp (mkwvk_close_asked): after preparers stop and caches save — set closing, take present_image_mu (every present, direct or frame-generated, is under it), drain the presenter thread, then retire_swapchain() under dev.present_mu — the same lock order present_image itself uses, so no present is mid-acquire on an image being destroyed. Logs the swapchain is let go once, so support can verify the path fired.
  • gpu/vk/vk_main.cpp (start): the FIRST swapchain — made while the renderer starts, before any present — takes the same lock and checks the flag first, on both the SDL path and the Windows path (hos_win runs the renderer on its own thread, so the window's close can be asked while the initial chain is being made). A window already closing gets no chain; the review's second pass confirmed the ordering matches the close's exactly.
  • gpu/vk/vk_replay.cpp (present_image): returns before touching the swapchain while closing — the window is going away and making a chain again would take the screen back from the compositor mid-transition (the flag discipline the old comment in vk_main.cpp warned about: a chain taken from under a frame mid-acquire is a lost device).
  • Host side untouched: host/hos_relaunch.c's close ordering is already right (rx_close_asked → finish → exit). Close is deliberately not the lost-surface path: when the compositor dies on its own, invalidate_lost_surface stays the route, and its retire is already gated — a close over an already-lost window waits and destroys nothing (retire_swapchain's own first line), now pinned by a fixture case.
  • tests/test_present_semaphores.py: the fixture compiles the real present_image prefix and retire_swapchain, and (the review's ask) extracts the close's wiring and start's guard verbatim from the sources and runs them: deleting either block from vk_main.cpp, or the closing check from the guard, now fails the test (mutation-checked). New cases: a close retires a live chain (device idled, chain destroyed in order), no present makes a chain after, a closing window gets no initial chain, and a close over an already-lost window waits and destroys nothing.

Measurements

Verdict: no fps or memory change by design (the release happens at exit); the fix's close marker fires exactly once per quit on Deck Game-Mode arms; the game-free suite is at parity (no new failures; main lost two since this branch's earlier base); the scripted harness cannot discriminate the bug (see Why's caveat), so the artifact's disappearance awaits a player who hits it.

Hardware: Steam Deck LCD (Jupiter, RADV VANGOGH), SteamOS current, AMD Custom APU 0405, 16 GB.
Scene: Castle Town / Market_Child via the control bridge's teleport, Game Mode, native output; deep arm at HOS_OUTPUT_RES=2304x1440.
Method: three paired scripted rounds (light 1280x800; deep 2304x1440 loop-walk; teleport-to-fresh-area and quit while the census is high), old vs fixed runtimes side by side, journal + game-log captures at the quit second; the game-free suite run side by side on the same Deck the same day (worktrees, tests/run_all.py).
How to reproduce: the runtime wrappers (scripts/dev_packs.py pack/rt over one base), /home/deck/src/Longshot/scripts/longshot_ctl.py teleport with the event gate ("event": false) and arrival check; full protocol in #issuecomment-35527 and #issuecomment-35622; run files in docs/tested/.

Before: main @ a5b112b6 After: this PR @ 08a3bd21
close marker the swapchain is let go per quit (Game Mode arms) 0 1 (every arm)
liftoff ENOMEM/modeset fingerprint, scripted 0/3 rounds (despite peaks 10,149–10,487 MB ≥ couch 9,902) 0/3 rounds
game-free suite, host (this VM), same day 574 passed, 18 failed, 100 skipped 576 passed, 16 failed, 100 skipped (the 16 are a strict subset of main's 18; the named set is under Testing)
game-free suite, Deck, same day (earlier heads) 581 passed, 19 failed, 77 skipped 581 passed, 19 failed, 77 skipped — identical totals and failure names (docs/tested/…suite01.md)
stream-arm working set at the quit second 4,963 → 3,712 MB (census climbing) 5,139 MB
peak, stream round 10,149 MB 8,391 MB
[rt-fix/longshot_vk.so] grep -ac "the swapchain is let go" = 1   (rt-main: 0)
fix binary sha256: 802801621747ed780ff533a26f634d1ca5a52e4fe016b30c17e854740e0f6bcb

Flags and settings

None. No switch, menu row, ini key or build flag is added or changed; the release is unconditional on the deliberate-close path.

Testing

Tested: tests/test_present_semaphores.py (new close/guard cases, verbatim source extraction, mutation-checked) on this branch; tests/test_tested_configurations.py for the run files; game-free suite side-by-side on the Deck and side-by-side against origin/main on this host; installed as a Deck runtime and run in Game Mode three paired rounds — clean launches, clean exits, close marker once per quit, no regression; desktop-mode launches unaffected in the same campaign.

Not tested: Windows (the guard is in the Windows path but no Windows hardware here); HDR and V-Sync rows near a close; frame generation on during a close; Wayland/X desktop sessions. No local hardware for the first; the rest were not exercised by the scripted arms.

Must be tested:

  • any Steam Deck Game Mode user (Test Farm: @Beanstalk steamdeck): play a heavy area to a high working set, quit, watch the Game Mode UI — expecting clean return, and in journalctl --since -2min no liftoff: drmModeAtomicCommit: Cannot allocate memory / modeset storm at the quit second (with the fix, the game's log should end with the swapchain is let go before display: window closed, exiting).
  • Linux desktop, Wayland and X (Test Farm: @Beanstalk linux): close a window mid-session and at the menu's Restart now — expecting the relaunched game's window renders normally, and a close during a slow startup (long shader prepare) exits without a black hang.
  • Windows, any GPU (Test Farm: @Beanstalk windows): quit normally, expecting a clean process exit and no hang at close.

Risks

What could break: a present racing the retire — closed by taking present_image_mu and draining the presenter before retire_swapchain(), under the same lock order present_image uses; a late present after close — the closing guard makes it a no-op rather than a recreate; a close racing the first chain — start() takes the close's lock and checks its flag, both platforms. A missed wait would show as a validation error or device-lost at exit, which the Deck arms did not produce.
Turning it off: revert the commit (no switch to forget).
Compatibility: Nothing changes for saves, ini, caches, or the vk ABI; the only new player-visible behavior is the log line.

Issues

See ValveSoftware/gamescope#1822 (stuck final frame on game exit — same compositor surface, prior art). See #904 (rainbow artifacts too, but Polaris RX 580 on Windows after a cutscene: different mechanism). See #1043 (WIP presenter-thread swapchain sync — shared ground; if it merges first, rebase and reconcile the retire sequence). See #716 only in spirit: same Deck, different subsystem.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named). On this host: 16 failures, all build-tool checks — test_linux_update, test_make_game_cache, test_bug_report_defaults, test_crt_options, test_dlss_feature_size, test_failed_compile_keeps_objects, test_guest_imported, test_lift_lookups, test_link_skip, test_missing_nup, test_mods_size_table, test_pending_guest_import, test_run_all_changed, test_walk, test_walk_key, test_vk_occlusion_queries — every one also fails on origin/main checked out side by side the same day (main's 18 include these plus test_bug_report and test_hardware_report; none is renderer code and none touches this PR's files).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • A game-free test added for the fix, failing on main and passing here. (test_present_semaphores.py's close cases fail on main: the close wiring they extract verbatim is not there.)
  • A check under tests/ that reads changed source updated in this PR, not weakened. (The fixture now extracts the close wiring and the startup guard verbatim from vk_main.cpp; mutation-checked: deleting either fails.)
  • A file in docs/tested/ for each new measured run (format in docs/tested-configurations.md).
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (Renderer built for Windows with llvm-mingw in CI on this branch's head.)
  • Docs updated.
**Type:** fix · **Risk:** low · **Tested on:** Steam Deck LCD (Jupiter, RADV VANGOGH), SteamOS, Game Mode + desktop; Linux x86-64 game-free checks · **Needs:** any Game Mode player who hits the post-exit artifact; Wayland/X desktop and Windows near a close ## Status Ready for review and for other Game Mode players to test. On this Deck (LCD): the fix installs and runs, its close marker fires exactly once per quit, and no regression appeared. Three scripted repro conditions (light 1280x800; deep 2304x1440 loop-walk; fresh-area teleport-and-quit) ran paired old-vs-fixed; **none reproduced the liftoff ENOMEM/modeset fingerprint even on the unfixed build**, despite peaks matching the reported couch session (10.1/10.5 GB vs 9.9 GB). Details and the full protocol in the comments on this PR (latest: #issuecomment-35622) and in the run files `docs/tested/2026-11-16-deck-exit-close-omgitsgela-gm01.md` and `…suite01.md`. The scripted harness cannot discriminate the race; real-world play from other Game Mode users is now the confirmation path. ## Why A player quit Longshot inside the Deck's Game Mode. Afterwards rainbow/garbage pixels lingered **on top of the Game Mode UI** until they switched to desktop mode; returning to Game Mode later was clean. They nearly thought their GPU had died. (Reported in the couch session of 2026-11-15; machine evidence below.) The Deck's own logs from that second: - the game's log (`~/.local/share/Steam/logs/console-linux.txt`, Game Mode pipes stdout there), 19:59:14: working set **7136 MB (peak 9902)**, VRAM 3710/5890 MB, the ~9.8 GB memfd guest window shared with the GPU as dma-bufs, last line `display: window closed, exiting`; - the journal at the **same second**, gamescope's compositor making its final display commit as the window goes away: `liftoff: drmModeAtomicCommit: Cannot allocate memory` (×4), `xwm: Failed to prepare 1-layer flip (Cannot allocate memory)`, then a re-detect storm, `drm: could not find mode!`, `xwm: We failed our modeset and have no mode to fall back to!` in a loop. The correlation is exact and the mechanism is plausible: at exit this process holds most of the system's memory, and the commit's *own* allocation fails. A failed modeset leaves the scan-out pointing at buffers the emulator owned — which is what "garbage over the UI" looks like — and a mode switch rebuilds the display config, which is exactly how the player recovered. gamescope's own tracker has prior art for a stuck final frame on game exit (ValveSoftware/gamescope#1822). What this PR does **not** claim: that the ENOMEM is proven caused by our allocations (timestamp correlation is not proof), or that it explains every post-exit artifact. Two minutes earlier the same session logged `create_swapchain: Surface already had a gamescope_swapchain` at an in-game resolution change, and Mesa/gamescope bugs of their own exist. But our exit path has a real, fixable gap regardless — see How to reproduce. ## How to reproduce **Seen on:** SteamOS (Steam Deck LCD, Jupiter / RADV VANGOGH), Game Mode, session after long heavy play (that one session; scripted arms under this PR's Measurements did not re-trigger it). **Settings and switches:** defaults; the couch session ran at native 1280x800 with the launcher's env file switches. **Steps:** play a heavy outdoor area until the game's working set approaches the system ceiling (the couch session reached working set ~7.1 GB, peak 9.9 GB of a 14.8 GB pool), then quit the game (window close or menu exit) while still in Game Mode. **Expected:** the Game Mode UI returns clean. **Actual:** that session (not since reproduced by script): garbage/rainbow pixels over the Game Mode UI until a session switch to desktop mode; the journal shows the liftoff ENOMEM + modeset-failure storm at the quit second. **Honest caveat:** three scripted paired repro conditions (this PR's Measurements) never triggered the fingerprint even on unfixed main, despite matching the couch memory peaks. The reproducible part is the code gap below; the visual artifact needs a player who hits it. The code gap, checkable on main without the bug: `mkwvk_close_asked` (the deliberate close: window closed, control-bridge quit, menu's Restart now) saves the pipeline cache and stops the shader preparers — and then nothing. No device wait, no swapchain destroy, no semaphore release. Every Vulkan object, including the swapchain's images and whatever they pin in VRAM/GTT, goes down only when the process exits, racing the compositor's final frames. A grep on main: `retire_swapchain()` exists (device wait idle, drop views, destroy the rendered semaphores, destroy the chain) and is never called from any close path. ## What changed At the deliberate close, the renderer now lets go of the window's GPU-side display resources deliberately and in order, instead of leaving process teardown to race the compositor. - `gpu/vk/vk_internal.h`: `dev.closing` (atomic bool); externs the present mutex. - `gpu/vk/vk_main.cpp` (`mkwvk_close_asked`): after preparers stop and caches save — set `closing`, take `present_image_mu` (every present, direct or frame-generated, is under it), drain the presenter thread, then `retire_swapchain()` under `dev.present_mu` — the same lock order `present_image` itself uses, so no present is mid-acquire on an image being destroyed. Logs `the swapchain is let go` once, so support can verify the path fired. - `gpu/vk/vk_main.cpp` (`start`): the FIRST swapchain — made while the renderer starts, before any present — takes the same lock and checks the flag first, on both the SDL path and the Windows path (`hos_win` runs the renderer on its own thread, so the window's close can be asked while the initial chain is being made). A window already closing gets no chain; the review's second pass confirmed the ordering matches the close's exactly. - `gpu/vk/vk_replay.cpp` (`present_image`): returns before touching the swapchain while `closing` — the window is going away and making a chain again would take the screen back from the compositor mid-transition (the flag discipline the old comment in `vk_main.cpp` warned about: a chain taken from under a frame mid-acquire is a lost device). - Host side untouched: `host/hos_relaunch.c`'s close ordering is already right (`rx_close_asked` → finish → exit). Close is deliberately *not* the lost-surface path: when the compositor dies on its own, `invalidate_lost_surface` stays the route, and its retire is already gated — a close over an already-lost window waits and destroys nothing (`retire_swapchain`'s own first line), now pinned by a fixture case. - `tests/test_present_semaphores.py`: the fixture compiles the real `present_image` prefix and `retire_swapchain`, and (the review's ask) extracts the close's wiring and start's guard **verbatim from the sources** and runs them: deleting either block from `vk_main.cpp`, or the closing check from the guard, now fails the test (mutation-checked). New cases: a close retires a live chain (device idled, chain destroyed in order), no present makes a chain after, a closing window gets no initial chain, and a close over an already-lost window waits and destroys nothing. ## Measurements **Verdict:** no fps or memory change by design (the release happens at exit); the fix's close marker fires exactly once per quit on Deck Game-Mode arms; the game-free suite is at parity (no new failures; main lost two since this branch's earlier base); the scripted harness cannot discriminate the bug (see Why's caveat), so the artifact's disappearance awaits a player who hits it. Hardware: Steam Deck LCD (Jupiter, RADV VANGOGH), SteamOS current, AMD Custom APU 0405, 16 GB. Scene: Castle Town / Market_Child via the control bridge's teleport, Game Mode, native output; deep arm at `HOS_OUTPUT_RES=2304x1440`. Method: three paired scripted rounds (light 1280x800; deep 2304x1440 loop-walk; teleport-to-fresh-area and quit while the census is high), old vs fixed runtimes side by side, journal + game-log captures at the quit second; the game-free suite run side by side on the same Deck the same day (worktrees, `tests/run_all.py`). How to reproduce: the runtime wrappers (`scripts/dev_packs.py pack/rt` over one base), `/home/deck/src/Longshot/scripts/longshot_ctl.py` teleport with the event gate (`"event": false`) and arrival check; full protocol in #issuecomment-35527 and #issuecomment-35622; run files in `docs/tested/`. | | Before: main @ a5b112b6 | After: this PR @ 08a3bd21 | |---|---|---| | close marker `the swapchain is let go` per quit (Game Mode arms) | 0 | 1 (every arm) | | liftoff ENOMEM/modeset fingerprint, scripted | 0/3 rounds (despite peaks 10,149–10,487 MB ≥ couch 9,902) | 0/3 rounds | | game-free suite, host (this VM), same day | 574 passed, 18 failed, 100 skipped | 576 passed, 16 failed, 100 skipped (the 16 are a strict subset of main's 18; the named set is under Testing) | | game-free suite, Deck, same day (earlier heads) | 581 passed, 19 failed, 77 skipped | 581 passed, 19 failed, 77 skipped — identical totals and failure names (docs/tested/…suite01.md) | | stream-arm working set at the quit second | 4,963 → 3,712 MB (census climbing) | 5,139 MB | | peak, stream round | 10,149 MB | 8,391 MB | ``` [rt-fix/longshot_vk.so] grep -ac "the swapchain is let go" = 1 (rt-main: 0) fix binary sha256: 802801621747ed780ff533a26f634d1ca5a52e4fe016b30c17e854740e0f6bcb ``` ### Flags and settings None. No switch, menu row, ini key or build flag is added or changed; the release is unconditional on the deliberate-close path. ## Testing **Tested:** `tests/test_present_semaphores.py` (new close/guard cases, verbatim source extraction, mutation-checked) on this branch; `tests/test_tested_configurations.py` for the run files; game-free suite side-by-side on the Deck and side-by-side against `origin/main` on this host; installed as a Deck runtime and run in Game Mode three paired rounds — clean launches, clean exits, close marker once per quit, no regression; desktop-mode launches unaffected in the same campaign. **Not tested:** Windows (the guard is in the Windows path but no Windows hardware here); HDR and V-Sync rows near a close; frame generation on during a close; Wayland/X desktop sessions. No local hardware for the first; the rest were not exercised by the scripted arms. **Must be tested:** - any Steam Deck Game Mode user (Test Farm: @Beanstalk steamdeck): play a heavy area to a high working set, quit, watch the Game Mode UI — expecting clean return, and in `journalctl --since -2min` no `liftoff: drmModeAtomicCommit: Cannot allocate memory` / modeset storm at the quit second (with the fix, the game's log should end with `the swapchain is let go` before `display: window closed, exiting`). - Linux desktop, Wayland and X (Test Farm: @Beanstalk linux): close a window mid-session and at the menu's **Restart now** — expecting the relaunched game's window renders normally, and a close during a slow startup (long shader prepare) exits without a black hang. - Windows, any GPU (Test Farm: @Beanstalk windows): quit normally, expecting a clean process exit and no hang at close. ## Risks **What could break:** a present racing the retire — closed by taking `present_image_mu` and draining the presenter before `retire_swapchain()`, under the same lock order `present_image` uses; a late present after close — the `closing` guard makes it a no-op rather than a recreate; a close racing the first chain — start() takes the close's lock and checks its flag, both platforms. A missed wait would show as a validation error or device-lost at exit, which the Deck arms did not produce. **Turning it off:** revert the commit (no switch to forget). **Compatibility:** Nothing changes for saves, ini, caches, or the vk ABI; the only new player-visible behavior is the log line. ## Issues See ValveSoftware/gamescope#1822 (stuck final frame on game exit — same compositor surface, prior art). See #904 (rainbow artifacts too, but Polaris RX 580 on Windows after a cutscene: different mechanism). See #1043 (WIP presenter-thread swapchain sync — shared ground; if it merges first, rebase and reconcile the retire sequence). See #716 only in spirit: same Deck, different subsystem. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). On this host: 16 failures, all build-tool checks — `test_linux_update`, `test_make_game_cache`, `test_bug_report_defaults`, `test_crt_options`, `test_dlss_feature_size`, `test_failed_compile_keeps_objects`, `test_guest_imported`, `test_lift_lookups`, `test_link_skip`, `test_missing_nup`, `test_mods_size_table`, `test_pending_guest_import`, `test_run_all_changed`, `test_walk`, `test_walk_key`, `test_vk_occlusion_queries` — every one also fails on `origin/main` checked out side by side the same day (main's 18 include these plus `test_bug_report` and `test_hardware_report`; none is renderer code and none touches this PR's files). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] A game-free test added for the fix, failing on `main` and passing here. (`test_present_semaphores.py`'s close cases fail on main: the close wiring they extract verbatim is not there.) - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. (The fixture now extracts the close wiring and the startup guard verbatim from `vk_main.cpp`; mutation-checked: deleting either fails.) - [x] A file in `docs/tested/` for each new measured run (format in `docs/tested-configurations.md`). - [x] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. (Renderer built for Windows with llvm-mingw in CI on this branch's head.) - [x] Docs updated.
On the Steam Deck's Game Mode, the compositor reprograms the display right
as the game's window goes away. After a long run had the emulator holding
most of the system's memory, that commit's own allocation failed (liftoff:
drmModeAtomicCommit: Cannot allocate memory), the modeset failed, and the
player saw the last frames as garbage over the Game Mode UI until a mode
switch rebuilt the display. Nothing on our side was released before exit:
the swapchain's images (its VRAM), the rendered semaphores, and an idle
device all went down with the process, racing the compositor's final
frames. mkwvk_close_asked now drains the presenters and retires the
swapchain on purpose, and a dev.closing flag keeps present_image from
making a chain again after that (the lost-surface path stays for when the
compositor dies on its own).
test(vk): the close retires the chain, and no present makes a new one after
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
08f2ca3256
The present-semaphores fixture carries the real present_image prefix and
retire_swapchain: the new closing guard is checked there, with the retire
asserted to idle the device and destroy the chain in order.
feat(vk): the close says in the log when it let the swapchain go
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
138390a82b
A player's log should show the release happened (the Deck's Game Mode pipes
the game's stdout to Steam's log): one line, only when a chain existed.
Author
Contributor

Test run, Deck (Steam Deck LCD, SteamOS, clang): the full game-free suite side by side.

  • main tip a5b112b6: 577 passed, 15 failed, 74 skipped.
  • This branch at 6f20d7bd: 576 passed, the same 15 failed, 74 skipped — test_bug_report, test_bug_report_defaults, test_crt_options, test_failed_compile_keeps_objects, test_guest_imported, test_hardware_report, test_linux_preflight, test_linux_update, test_make_game_cache, test_missing_nup, test_mods_size_table, test_pending_guest_import, test_run_all_changed, test_vk_occlusion_queries, test_walk_key — each name fails on main too, so nothing here is introduced by this change. (The 577/576 pass delta is exactly tests/test_dev_build.py: main tip added it with #1095, and this branch is based on the commit before; it is not a test this branch fails.)
  • tests/test_present_semaphores.py passes on this branch with the new close cases: PASS: a close retires the chain with the device idled, and no present makes a new one after.
  • Note on an earlier number I posted in the description: the first fix commit DID fail test_present_semaphores — honestly my fault, the fixture carries the real present_image prefix and needed the new field; the second commit fixed it. The suite was then re-run in full as above.

A third commit (138390a8) adds one log line at the close so a player's log shows the swapchain was let go (the Deck pipes the game's stdout into Steam's log; this makes the fix observable in the field). It does not change behavior beyond the line.

Hardware check in flight: this Deck is building the exact PR head as a runtime pack, then a paired Game Mode exit test — the build the couch glitch came from, current main, and this fix — launching, playing, quitting through the control bridge, and reading gamescope's journal for the drmModeAtomicCommit: Cannot allocate memory fingerprint at the quit second. Result will land here either way it goes.

**Test run, Deck (Steam Deck LCD, SteamOS, clang): the full game-free suite side by side.** - `main` tip `a5b112b6`: 577 passed, 15 failed, 74 skipped. - This branch at `6f20d7bd`: 576 passed, **the same 15 failed**, 74 skipped — `test_bug_report`, `test_bug_report_defaults`, `test_crt_options`, `test_failed_compile_keeps_objects`, `test_guest_imported`, `test_hardware_report`, `test_linux_preflight`, `test_linux_update`, `test_make_game_cache`, `test_missing_nup`, `test_mods_size_table`, `test_pending_guest_import`, `test_run_all_changed`, `test_vk_occlusion_queries`, `test_walk_key` — each name fails on `main` too, so nothing here is introduced by this change. (The 577/576 pass delta is exactly `tests/test_dev_build.py`: `main` tip added it with #1095, and this branch is based on the commit before; it is not a test this branch fails.) - `tests/test_present_semaphores.py` passes on this branch with the new close cases: `PASS: a close retires the chain with the device idled, and no present makes a new one after`. - Note on an earlier number I posted in the description: the first fix commit DID fail `test_present_semaphores` — honestly my fault, the fixture carries the real `present_image` prefix and needed the new field; the second commit fixed it. The suite was then re-run in full as above. A third commit (`138390a8`) adds one log line at the close so a player's log shows the swapchain was let go (the Deck pipes the game's stdout into Steam's log; this makes the fix observable in the field). It does not change behavior beyond the line. Hardware check in flight: this Deck is building the exact PR head as a runtime pack, then a paired Game Mode exit test — the build the couch glitch came from, current main, and this fix — launching, playing, quitting through the control bridge, and reading gamescope's journal for the `drmModeAtomicCommit: Cannot allocate memory` fingerprint at the quit second. Result will land here either way it goes.
Merge remote-tracking branch 'origin/main' into fix/deck-exit-display-release
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
e8d02b226b
Author
Contributor

Hardware update from the paired Game-Mode runs (Deck LCD, Steam session, same user save, same quit path):

Deep run at the couch's memory condition — the arms matched the glitch session's peak and both exited clean:

arm build working-set peak working set at the quit second liftoff/modeset fingerprint close marker
olddeep a4821d56 (the build the glitch happened on) 10,487 MB ~3.5 GB 0 n/a
fixdeep PR head (merged with main 6c8d6e6a → e8d02b22) 9,392 MB ~3.9 GB 0 1 (the swapchain is let go in the game log)

Method: HOS_OUTPUT_RES=2304x1440 via systemd-run --setenv (the couch session ran at that picture size; the log line boot: widescreen: picture 2304x1440 proves it applied), patient boot wait through the ~216 s shader re-preparation the new resolution triggers, then the walk, then ctl quit. Full scripts + hooks live on the Deck at ~/longshot-investigation/deck-gm-exit-{ab,deep,stream}.sh, documented so anyone can re-run them identically.

What this tells us. The old build's peak (10,487 MB) matches the glitch session's 9,902 MB — so the deep condition reproduces the size of the allocation. But the scripted exits stayed clean because a loop walk warms caches: by the quit second the working set had settled to ~3.5 GB, while the couch session held 7,136 MB at the exit second — the player was mid-streaming when they quit. The compositor ENOMEM is a race at the exit second: it needs a high working set at the moment of exit, not just a high peak.

Third arm, running now: teleport into a fresh area (Market_Child, flood the streaming pools on demand) and quit within ~100 s while the working-set census is still climbing — the couch's exact situation manufactured on schedule. Same two arms (old glitch build, then this PR's runtime). If old-now reproduces and fix-now doesn't, that's the clean on-demand discrimination reviewers asked for; if both stay clean, the honest claim stays "evidence chain + fixture proof, no on-demand repro" and the PR text will say so.

Suite state unchanged: same 15 pre-existing Deck failures on both main and this branch; the new close-guard case passes at the current head.

Provenance note: the delegated adversarial review of this change is blocked — the review provider has returned HTTP 429 (resets ~Nov 19). The fix has had an inline adversarial pass instead, and I'd genuinely value a human second read on the lock order in mkwvk_close_asked (present_image_mu → drain → present_mu) against PR #1043's presenter-thread changes, which touch the same paths from the other side.

Hardware update from the paired Game-Mode runs (Deck LCD, Steam session, same user save, same quit path): **Deep run at the couch's memory condition — the arms matched the glitch session's peak and both exited clean:** | arm | build | working-set peak | working set at the quit second | liftoff/modeset fingerprint | close marker | |---|---|---|---|---|---| | olddeep | `a4821d56` (the build the glitch happened on) | **10,487 MB** | ~3.5 GB | 0 | n/a | | fixdeep | PR head (merged with main `6c8d6e6a` → `e8d02b22`) | 9,392 MB | ~3.9 GB | 0 | 1 (`the swapchain is let go` in the game log) | Method: `HOS_OUTPUT_RES=2304x1440` via systemd-run `--setenv` (the couch session ran at that picture size; the log line `boot: widescreen: picture 2304x1440` proves it applied), patient boot wait through the ~216 s shader re-preparation the new resolution triggers, then the walk, then `ctl quit`. Full scripts + hooks live on the Deck at `~/longshot-investigation/deck-gm-exit-{ab,deep,stream}.sh`, documented so anyone can re-run them identically. **What this tells us.** The old build's peak (10,487 MB) matches the glitch session's 9,902 MB — so the deep condition reproduces the *size* of the allocation. But the scripted exits stayed clean because a loop walk warms caches: by the quit second the working set had settled to ~3.5 GB, while the couch session held **7,136 MB at the exit second** — the player was mid-streaming when they quit. The compositor ENOMEM is a race at the exit second: it needs a *high working set at the moment of exit*, not just a high peak. **Third arm, running now:** teleport into a fresh area (`Market_Child`, flood the streaming pools on demand) and quit within ~100 s while the working-set census is still climbing — the couch's exact situation manufactured on schedule. Same two arms (old glitch build, then this PR's runtime). If old-now reproduces and fix-now doesn't, that's the clean on-demand discrimination reviewers asked for; if both stay clean, the honest claim stays "evidence chain + fixture proof, no on-demand repro" and the PR text will say so. Suite state unchanged: same 15 pre-existing Deck failures on both main and this branch; the new close-guard case passes at the current head. Provenance note: the delegated adversarial review of this change is blocked — the review provider has returned HTTP 429 (resets ~Nov 19). The fix has had an inline adversarial pass instead, and I'd genuinely value a human second read on the lock order in `mkwvk_close_asked` (present_image_mu → drain → present_mu) against PR #1043's presenter-thread changes, which touch the same paths from the other side.
Author
Contributor

Hardware campaign, final scripted round: the exit fingerprint does not reproduce even on the unfixed build

Third condition tried (deck-gm-exit-stream.sh, staged on the Deck under ~/longshot-investigation/), now finished. Protocol, documented for reproduction: HOS_OUTPUT_RES=2304x1440 (the couch picture size), Game-Mode session environment read from the Steam process, same user save, bridge teleport to Market_Child (fresh-area flood), walk ~100 s into it, then quit while the working-set census is still climbing. One correction the first round forced: the game refuses teleports while an event plays (teleport check: … event playing 1) and the ctl client can still exit 0 — the script now polls --json status for "event":false before teleporting, and both arms below actually reached their condition.

arm build peak working set at the quit second close marker liftoff/modeset fingerprint
oldstream rt-main (a4821d56, unfixed) 10,149 MB 4,963 → 3,712 MB, census climbing 0 (as expected) 0
fixstream rt-fix (head 138390a8) 8,391 MB 5,139 MB 1 0

So across three scripted conditions and four paired runs — light 1280x800, deep 2304x1440 loop-walk, and fresh-area teleport-and-quit — the liftoff ENOMEM/modeset fingerprint never appeared on the unfixed build either, despite peaks matching the couch session (10.1 GB vs the user's 9.9 GB) and comparable working sets at the exit second. The scripted Game-Mode harness cannot discriminate this race; I'm closing that path rather than burning more Deck sessions on cosmetic variants.

What remains supporting the change:

  • the mechanism gap is real in the source: mkwvk_close_asked returned without ever letting go of the swapchain or its images, so gamescope kept importing the exiting game's buffers — and gamescope's own tracker has this exact stuck-final-frame/failure family (#1822), with PR #1042/#1043 work circling swapchain lifetime at close;
  • the couch session's own log is a same-second match (working set 7,136 MB / peak 9,902 MB / 9.8 GB guest memfd shared as dma-bufs → liftoff: drmModeAtomicCommit: Cannot allocate memory ×4, failed flip, failed modeset with no fallback), and it shows a mid-session swapchain re-creation two minutes earlier — the game re-handed buffers while gamescope was busy;
  • the fix is defensive by construction: on close, drain the presenter, retire the chain, destroy the images under the device lock, and refuse late present_image calls that would resurrect it. On hardware the marker fires once per close and neither arm regressed; suites are green (Deck comparison posted earlier: fix = main − 1 test, the test_dev_build.py main added via #1095).

Honest status: the one user report stands as the only observation of the glitch; scripted repro attempts (including a stronger one than the reported session in peak terms) do not show it. The change makes the renderer do at close what it should always have done, and matches upstream's direction. Moving this PR out of WIP for review; if the race needs gamescope-side cooperation to fix fully (#1822), that's complementary, not competing.

## Hardware campaign, final scripted round: the exit fingerprint does not reproduce even on the unfixed build Third condition tried (`deck-gm-exit-stream.sh`, staged on the Deck under `~/longshot-investigation/`), now finished. Protocol, documented for reproduction: `HOS_OUTPUT_RES=2304x1440` (the couch picture size), Game-Mode session environment read from the Steam process, same user save, bridge **teleport to `Market_Child`** (fresh-area flood), walk ~100 s into it, then quit while the working-set census is still climbing. One correction the first round forced: **the game refuses teleports while an event plays** (`teleport check: … event playing 1`) and the ctl client can still exit 0 — the script now polls `--json status` for `"event":false` before teleporting, and both arms below actually reached their condition. | arm | build | peak | working set at the quit second | close marker | liftoff/modeset fingerprint | |---|---|---|---|---|---| | oldstream | `rt-main` (`a4821d56`, unfixed) | **10,149 MB** | 4,963 → 3,712 MB, census climbing | 0 (as expected) | **0** | | fixstream | `rt-fix` (head `138390a8`) | 8,391 MB | 5,139 MB | **1** | 0 | So across three scripted conditions and four paired runs — light 1280x800, deep 2304x1440 loop-walk, and fresh-area teleport-and-quit — **the liftoff ENOMEM/modeset fingerprint never appeared on the unfixed build either**, despite peaks matching the couch session (10.1 GB vs the user's 9.9 GB) and comparable working sets at the exit second. The scripted Game-Mode harness cannot discriminate this race; I'm closing that path rather than burning more Deck sessions on cosmetic variants. What remains supporting the change: - the mechanism gap is real in the source: `mkwvk_close_asked` returned without ever letting go of the swapchain or its images, so gamescope kept importing the exiting game's buffers — and gamescope's own tracker has this exact stuck-final-frame/failure family (#1822), with PR #1042/#1043 work circling swapchain lifetime at close; - the couch session's own log is a same-second match (working set 7,136 MB / peak 9,902 MB / 9.8 GB guest memfd shared as dma-bufs → `liftoff: drmModeAtomicCommit: Cannot allocate memory` ×4, failed flip, failed modeset with no fallback), and it shows a mid-session swapchain **re-creation** two minutes earlier — the game re-handed buffers while gamescope was busy; - the fix is defensive by construction: on close, drain the presenter, retire the chain, destroy the images under the device lock, and refuse late `present_image` calls that would resurrect it. On hardware the marker fires once per close and neither arm regressed; suites are green (Deck comparison posted earlier: fix = main − 1 test, the `test_dev_build.py` main added via #1095). Honest status: the one user report stands as the only observation of the glitch; scripted repro attempts (including a stronger one than the reported session in peak terms) do not show it. The change makes the renderer do at close what it should always have done, and matches upstream's direction. Moving this PR out of WIP for review; if the race needs gamescope-side cooperation to fix fully (#1822), that's complementary, not competing.
omgitsgela changed title from WIP: fix(vk): the window's swapchain is let go at the close, not at the process's end to fix(vk): the window's swapchain is let go at the close, not at the process's end 2026-11-16 13:10:24 +00:00
Author
Contributor

Description brought current: status now states the real hardware state (three paired scripted rounds, fingerprint never observed even unfixed, close marker clean on the fix; protocol in comments 35527/35622); the suite section replaced with the side-by-side Deck numbers actually posted (34873); 'must still be tested' now asks players who hit the glitch to confirm the fingerprint stops with the fix installed, since scripted repro cannot discriminate.

Description brought current: status now states the real hardware state (three paired scripted rounds, fingerprint never observed even unfixed, close marker clean on the fix; protocol in comments 35527/35622); the suite section replaced with the side-by-side Deck numbers actually posted (34873); 'must still be tested' now asks players who *hit* the glitch to confirm the fingerprint stops with the fix installed, since scripted repro cannot discriminate.
Merge remote-tracking branch 'origin/main' into fix/deck-exit-display-release
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 3s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
66412d3341
fix(vk): the first swapchain is made under the close's lock, both platforms
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 5s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
af9574d24f
The close (mkwvk_close_asked) can be asked while the renderer is still coming
up: SDL runs it on the window's thread, hos_win runs the renderer on its own.
present_image's closing guard covers presents, but start() made the initial
chain outside any lock: a close during startup could destroy images the
creation was publishing, or let the chain appear after the retire. start() now
takes present_image_mu and checks dev.closing first, the close's own order.

test_present_semaphores: the fixture runs the close's wiring (the flag, the
drain, the retire under both locks) and start's guard extracted verbatim from
the source, and pins that both platforms' initial chains carry the guard;
deleting or unwiring either block in the source now fails the test (mutation
checked: close wiring out, guard out, closing-check out: each fails).
Merge remote-tracking branch 'origin/main' into fix/deck-exit-display-release
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
85709e3df4
test(vk): a close over an already-lost window waits and destroys nothing
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
62b859381c
The review's second pass asked whether mkwvk_close_asked could wait on a dead
device when the lost-surface path already let the chain go. It cannot:
retire_swapchain's own first line is 'if (!dev.swapchain) return;' — the
retire is gated on a chain actually being held. Nothing in the sources
changed; what was missing was the pin. The fixture's close_now (the close's
wiring, verbatim) now runs over a window whose chain the lost path destroyed,
and asserts no vkDeviceWaitIdle fired, no swapchain destroy fired, and the
closing flag still went up. Mutation-checked: with the retire's null guard
removed the case fails (exit 42 path), with it in place the suite passes.
docs(tested): #1105's Deck runs as run files
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
34fe030e5d
Two campaigns on the Deck LCD, one per CONTRIBUTING's rule that a measured
run gets its own docs/tested file: the game-free suite side-by-side on Deck
hardware (main and this branch, same day, identical totals and failure-name
lists), and the three paired Game-Mode exit rounds (close marker once per
quit on every fix arm, the gamescope fingerprint unreproduced on either side
despite matching the couch session's memory peaks). Format-checked with
tests/test_tested_configurations.py.
omgitsgela force-pushed fix/deck-exit-display-release from 34fe030e5d
Some checks failed
PR description / Description follows the template (pull_request_target) Failing after 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 08a3bd214e
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 3s
2026-11-16 19:39:16 +00:00
Compare
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 3s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/deck-exit-display-release:omgitsgela-fix/deck-exit-display-release'
git switch 'omgitsgela-fix/deck-exit-display-release'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1105
No description provided.