fix(website): tell the launcher's version from the game's #1055
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1055
Loading…
Reference in a new issue
No description provided.
Delete branch "HumanBean/Longshot:fix/website-launcher-version"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Type: fix · Risk: low · Tested on: Linux, local build (wrangler dev) · Needs: none
Why
The launcher and Longshot, the game it builds, have separate version numbers (the launcher is at v1.0.0-rc.9, Longshot at v3.0.0-rc.5), and the website shows the launcher's tag on its own, with nothing saying which product it belongs to or that the game is numbered differently. Fixes LongshotLauncher#135 (in the launcher's repository, so it is closed by hand on merge).
How to reproduce
Seen on: any OS and browser, longshot.magicbean.dev
Settings and switches: defaults
Steps: open the front page and the install page, and look for the version numbers
Expected: each version says whose it is: the launcher's (v1.0.0-rc.9) or the game's, Longshot's (v3.0.0-rc.5)
Actual: the front page shows "Release candidate launcher: v1.0.0-rc.9" and nothing about Longshot's version; the download page's buttons show a bare "v1.0.0-rc.9"
What changed
The front page's download section now lists both version numbers, each named for what it is. The install and download pages say that the version they show is the launcher's, separate from Longshot's.
website/src/components/LongshotHome.astro): a Launcher / Game list in the release section. The launcher row is filled in from/download/launcher/versions.json. The game row shows the stable Longshot, or the newest publishedv*release from the build-time feed when there is no stable release yet, linked to its release notes. This replaces "The latest Longshot is …", which showed only once a stable release existed, so it never appeared.installLauncherStatusinwebsite/src/lib/launcher-channel.ts): "Release candidate launcher: v1.0.0-rc.9" becomes "Longshot Launcher v1.0.0-rc.9 · release candidate". It now fills every[data-launcher-status], the hero's and the list's.website/src/repo-docs/format-install.ts): a plain line under "Available now: Longshot Launcher …" says this is the launcher's own version.website/worker/index.ts): a sentence that the versions on the page are the launcher's, and the big button's tag reads "Launcher v…".tests/launcher-channel.test.ts(status text, both slots),tests/download.test.ts,tests/repo-docs.test.ts.Screenshots
Before: main, as deployed on longshot.magicbean.dev. After: this PR @
a83b88f6, localastro build+wrangler dev(live release data).After, light and at phone width (390 px):
Measurements
Nothing to measure: the website's wording, not the game.
Flags and settings
None
Testing
Tested: built the site (
astro build) and served it withwrangler dev, Linux, Chromium: front, install and download pages in dark, light and at 390 px. The screenshots above are from that run, with the live launcher release list.Not tested: the website's checks (
node --test tests/*.test.ts) andtests/run_all.py. Not run on this PC; CI runs them.Must be tested: None
Risks
What could break: the front page's version list if the feed has no
v*release (it then shows just "Longshot", no tag), or if versions.json fails (the launcher row keeps its link to the launcher's releases).Turning it off: revert the commit
Compatibility: Nothing changes
Checklist
Everyone
type(scope): description) of the status line's type.main.python -I -B tests/run_all.pypasses (any failure that also fails onmainis named). Not run on this PC; left to CI.third_party/untouched (a new folder with aPROVENANCE.mdinstead).When it applies
Assisted-by:/Co-Authored-By:trailers.🤖 Generated with Claude Code
Screenshots added: before (deployed main) and after (this PR @
a83b88f6) for the front, install and download pages, plus light and 390 px views.Added How to reproduce.
WIP: fix(website): tell the launcher's version from the game'sto fix(website): tell the launcher's version from the game's