WIP: fix(cache): ignore NaN retention settings #1022

Draft
NitnekLeBorgne wants to merge 1 commit from NitnekLeBorgne/Longshot-contributions:fix/object-store-nan-retention-20261116 into main
Contributor

Type: fix · Risk: low · Tested on: Linux and native Windows CLI, game-free Python/filesystem checks (GPU unused) · Needs: no remaining Windows public-fixture gate; production use remains untested

Why

A cache retention setting of NaN currently becomes zero instead of using the default. An otherwise reusable, two-day-old object held only by the shared store is then deleted unnecessarily. This can cause avoidable recompilation; no incorrect game output or reported player incident is claimed.

The parent searched the public corpus (265 issues, title/body; 230 complete public PR file lists) and admitted these two paths with no production/test intersection. No matching issue is claimed, and this is not a guarantee about private work.

How to reproduce

Seen on: Linux; GPU and driver unused.
Settings and switches: LONGSHOT_OBJ_STORE_DAYS=NaN, LONGSHOT_OBJ_STORE_GB=8; alternatively days 14 and GB NaN.
Steps: run python -I -B tests/test_object_store_retention_values.py. The test authors a small .o placeholder in its own temporary namespace, timestamps it two days before an explicit now, and calls the real prune function. No human cache or compiled game object is touched.
Expected: use the default 14 days or 8 GiB for NaN; preserve this object and report (0, 0) removed/freed.
Actual: pinned main reports (1, 48) and deletes the object, because max(0.0, float("NaN")) yields zero.

What changed

NaN now uses the existing default, just like an unparseable word. Finite limits and existing infinite-limit semantics are preserved.

  • nx2/object_store.py, _number: parse once, detect math.isnan, otherwise retain the existing nonnegative clamp. No catch-all exception handling.
  • New tests/test_object_store_retention_values.py: six discovered tests exercise actual temporary filesystem pruning, both NaN settings, NaN spelling variants for GB, default age expiry, finite zero/negative/positive/fractional limits, invalid-word/empty fallback, and positive/negative infinities. Verify removed counts, freed bytes, existence and retained bytes.
  • No existing test, runner, build/cache integration, runtime, shader, API, or third-party code changed.

Measurements

Verdict: the observed accidental NaN eviction is fixed; correctness change only, so there is no performance measurement or median claim.

Flags and settings

No new settings or changed shipping defaults. Only invalid NaN handling changes for existing cache settings:

Flag What it is Before this PR After this PR Effect Helps / doesn't help / untested Recommendation
LONGSHOT_OBJ_STORE_DAYS Store-only object retention age Default 14; NaN becomes 0 Default 14; NaN falls back to 14 Avoids accidental age eviction Real-file Linux and native Windows fixture tests Keep existing default
LONGSHOT_OBJ_STORE_GB Store-only size budget Default 8; NaN becomes 0 Default 8; NaN falls back to 8 Avoids accidental size eviction Real-file Linux and native Windows fixture tests Keep existing default

Parser results for positive and negative infinity remain unchanged. This PR does not claim to fix other nonfinite behavior or introduce a new retention policy.

Testing

  • Windows CLI fixture checks completed: python -I -B tests/test_object_store_retention_values.py -v passes all six methods (with their filesystem subcases); unchanged python -I -B tests/test_object_store.py exits 0. The latter is one top-level assertion script, not additional unittest methods. Tests ran in an accented path (épreuve) with private D: temporary files and no human cache access.

Tested: commit 84b9eba764179bd391eca21131491303041de174, tree 8df089da2be7bf8f94668ffce5b238d96da7ad12, direct parent d9486a0846e90905e2ee0bdc4a0d6df96c547c87.

  • Strict vertical TDD for the shared parser invariant: one initial real-filesystem NaN-days test, RED with exactly one assertion failure on untouched production; minimal shared-parser edit; immediate GREEN. Initial exact test bytes, SHA-256, production SHA-256, executable/cwd/argv and pre-run UTC are retained. The shared fix also covers GB; GB and compatibility controls were added after that GREEN, not represented as a second pre-edit TDD cycle.
  • All six final tests pass. Supplementary final-test execution against the pinned original module in memory confirms the NaN-days and five NaN-GB subcases fail while finite/infinity/default-expiry controls pass; this supplementary run is not the original TDD RED.
  • Unchanged tests/test_object_store.py passes. Normal discovery lists the new test.
  • Normal full python -I -B tests/run_all.py --jobs 3: 538 passed, 22 failed, 92 skipped, 652 checks, native exit 1, 256.5460848270013 seconds wall time. No selection/skip override, isolated HOME/XDG/TMP, baseline-identical PATH, no compiler hiding; four C++ checks pass.
  • Frozen baseline reused, not rerun: 537 passed, 22 failed, 92 skipped, 651 checks. Every existing status, failure case ID and skip reason matches; only the new passing check was added.
  • Strict failure-signature comparator stays false. Two retained diagnostics (test_bug_report.py, test_hardware_report.py) contain different absolute missing sibling Tooling paths. A separate literal replacement of only those exact paths makes them equal. All 22 signatures then match; no blanket claim that the baseline failures are upstream bugs, no CI-green claim.
  • Full tracked source hashes and POSIX modes unchanged before/after; every other parent tree entry and mode unchanged. Native full index/history retained. .bat checkout CRLF conversion explicitly checked, not mislabeled full blob-byte equivalence.
  • Heavy flock held, 3 GiB memory/disk reserves monitored; actual minima in the retained samples. Own process group verified absent after exit.
  • No AGENTS.md materialized; its original opaque index/tree entry preserved. Two unchanged SwitchesRemoved methods additionally pass with the public blob supplied only in memory. This is normal source-only runner qualification, not exact-tree hosted CI.

Existing baseline failures retained:

  • tests/test_appimage_player_build.py
  • tests/test_bake_portability.py
  • tests/test_bug_report.py
  • tests/test_crash_dialog.py
  • tests/test_crt_options.py
  • tests/test_env_on.py
  • tests/test_guest_imported.py
  • tests/test_hardware_report.py
  • tests/test_lift_cleanup_error.py
  • tests/test_link_skip.py
  • tests/test_linux_update.py
  • tests/test_make_game_cache.py
  • tests/test_missing_nup.py
  • tests/test_mods_size_table.py
  • tests/test_options_budget_once.py
  • tests/test_pending_guest_import.py
  • tests/test_pipeline_tour.py
  • tests/test_readback_late.py
  • tests/test_run_all_changed.py
  • tests/test_vk_occlusion_queries.py
  • tests/test_vk_pgo.py
  • tests/test_walk_key.py

Not tested: a real human cache, a game or GPU runtime, remote CI. These are game-free cache retention changes; game/GPU testing is not invented as an acceptance gate. No auth/API/push/publication action occurred.

Must be tested: None for the public-fixture regression; the Windows CLI checks above are complete. Production use and the other exclusions under Not tested remain unqualified.

Risks

What could break: a user who intentionally entered NaN to mean immediate eviction instead receives documented defaults. Explicit zero remains immediate eviction for non-recent unlinked objects; negative finite values retain their clamp. Recent-object and hard-link protections are untouched.

Turning it off: revert the commit.

Compatibility: no format, key, ABI, save, shader, runtime or shipping-default changes. Valid finite limits and parser infinity results are unchanged; no human cache was touched.

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the public tracker and complete public PR file lists searched; parent scope adopted, no matching issue claimed).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why. Not ticked yet: Testing's Tested names only game-free Windows CLI checks, and the change touches nx2/, which the game runs.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main at frozen intake (d9486a0846e90905e2ee0bdc4a0d6df96c547c87). Public main has since advanced; no rebase to that later tip is claimed. Relevant source closure is checked again before publication, without transferring full-suite results to another tree.
  • python -I -B tests/run_all.py qualified against its exact pinned-main baseline: native exit 1 is preserved, all 22 existing failures are named above, and no new failure or changed skip status was found. This does not assert a wholly passing suite.
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
    Existing settings and shipping defaults are unchanged; the new-switch documentation checklist item does not apply. This fixes the parser handling of invalid NaN values only.
  • A game-free test added for the fix, failing on main and passing here.

Source export scope: unchanged gpu/build-shadertool.bat has the recorded .gitattributes LF-to-CRLF conversion. Candidate production and test files match native Git blobs; source/modes are unchanged across each run. Tooling is absent in the isolated runner context: two corresponding failure messages require only an exact sibling-path substitution; the original strict comparison remains false. This is not hosted-CI or literal exact-tree equivalence.

Windows qualification caveats: Native CPython 3.14.7 used a new independent copy of an existing pinned-dependency runtime, not a venv or a replacement product runner. Each candidate used its own full frozen-head public Git-blob export (2652 tree entries; 2651 files materialized; AGENTS.md kept opaque and never materialized). Production/test SHA-256 and all exported file bytes were verified before/after; Git modes remain metadata, not a claim of POSIX permission semantics on NTFS. Normal public test sources and commands were unchanged. Full stdout/stderr and exact native executable/argv/cwd/exit records are retained. A post-test harness assertion exited 1 because five CPython encoding bytecode cache files appeared only in the new owned runtime copy; independent readback confirmed no existing runtime file changed, the original runtime stayed byte-identical, and all test invocations exited 0. No full Windows suite, real compiler, game, GUI, hosted CI or publication qualification is claimed. Existing Linux full-suite results above are unchanged and are not transferred to Windows.

**Type:** fix · **Risk:** low · **Tested on:** Linux and native Windows CLI, game-free Python/filesystem checks (GPU unused) · **Needs:** no remaining Windows public-fixture gate; production use remains untested ## Why A cache retention setting of `NaN` currently becomes zero instead of using the default. An otherwise reusable, two-day-old object held only by the shared store is then deleted unnecessarily. This can cause avoidable recompilation; no incorrect game output or reported player incident is claimed. The parent searched the public corpus (265 issues, title/body; 230 complete public PR file lists) and admitted these two paths with no production/test intersection. No matching issue is claimed, and this is not a guarantee about private work. ## How to reproduce **Seen on:** Linux; GPU and driver unused. **Settings and switches:** `LONGSHOT_OBJ_STORE_DAYS=NaN`, `LONGSHOT_OBJ_STORE_GB=8`; alternatively days `14` and GB `NaN`. **Steps:** run `python -I -B tests/test_object_store_retention_values.py`. The test authors a small `.o` placeholder in its own temporary namespace, timestamps it two days before an explicit `now`, and calls the real `prune` function. No human cache or compiled game object is touched. **Expected:** use the default 14 days or 8 GiB for NaN; preserve this object and report `(0, 0)` removed/freed. **Actual:** pinned main reports `(1, 48)` and deletes the object, because `max(0.0, float("NaN"))` yields zero. ## What changed NaN now uses the existing default, just like an unparseable word. Finite limits and existing infinite-limit semantics are preserved. - `nx2/object_store.py`, `_number`: parse once, detect `math.isnan`, otherwise retain the existing nonnegative clamp. No catch-all exception handling. - New `tests/test_object_store_retention_values.py`: six discovered tests exercise actual temporary filesystem pruning, both NaN settings, NaN spelling variants for GB, default age expiry, finite zero/negative/positive/fractional limits, invalid-word/empty fallback, and positive/negative infinities. Verify removed counts, freed bytes, existence and retained bytes. - No existing test, runner, build/cache integration, runtime, shader, API, or third-party code changed. ## Measurements **Verdict:** the observed accidental NaN eviction is fixed; correctness change only, so there is no performance measurement or median claim. ### Flags and settings No new settings or changed shipping defaults. Only invalid NaN handling changes for existing cache settings: | Flag | What it is | Before this PR | After this PR | Effect | Helps / doesn't help / untested | Recommendation | |---|---|---|---|---|---|---| | `LONGSHOT_OBJ_STORE_DAYS` | Store-only object retention age | Default 14; NaN becomes 0 | Default 14; NaN falls back to 14 | Avoids accidental age eviction | Real-file Linux and native Windows fixture tests | Keep existing default | | `LONGSHOT_OBJ_STORE_GB` | Store-only size budget | Default 8; NaN becomes 0 | Default 8; NaN falls back to 8 | Avoids accidental size eviction | Real-file Linux and native Windows fixture tests | Keep existing default | Parser results for positive and negative infinity remain unchanged. This PR does not claim to fix other nonfinite behavior or introduce a new retention policy. ## Testing - Windows CLI fixture checks completed: `python -I -B tests/test_object_store_retention_values.py -v` passes all six methods (with their filesystem subcases); unchanged `python -I -B tests/test_object_store.py` exits 0. The latter is one top-level assertion script, not additional unittest methods. Tests ran in an accented path (`épreuve`) with private D: temporary files and no human cache access. **Tested:** commit `84b9eba764179bd391eca21131491303041de174`, tree `8df089da2be7bf8f94668ffce5b238d96da7ad12`, direct parent `d9486a0846e90905e2ee0bdc4a0d6df96c547c87`. - Strict vertical TDD for the shared parser invariant: one initial real-filesystem NaN-days test, RED with exactly one assertion failure on untouched production; minimal shared-parser edit; immediate GREEN. Initial exact test bytes, SHA-256, production SHA-256, executable/cwd/argv and pre-run UTC are retained. The shared fix also covers GB; GB and compatibility controls were added after that GREEN, not represented as a second pre-edit TDD cycle. - All six final tests pass. Supplementary final-test execution against the pinned original module in memory confirms the NaN-days and five NaN-GB subcases fail while finite/infinity/default-expiry controls pass; this supplementary run is not the original TDD RED. - Unchanged `tests/test_object_store.py` passes. Normal discovery lists the new test. - Normal full `python -I -B tests/run_all.py --jobs 3`: **538 passed, 22 failed, 92 skipped**, 652 checks, native exit **1**, 256.5460848270013 seconds wall time. No selection/skip override, isolated HOME/XDG/TMP, baseline-identical PATH, no compiler hiding; four C++ checks pass. - Frozen baseline reused, not rerun: **537 passed, 22 failed, 92 skipped**, 651 checks. Every existing status, failure case ID and skip reason matches; only the new passing check was added. - Strict failure-signature comparator stays **false**. Two retained diagnostics (`test_bug_report.py`, `test_hardware_report.py`) contain different absolute missing sibling Tooling paths. A separate literal replacement of only those exact paths makes them equal. All 22 signatures then match; no blanket claim that the baseline failures are upstream bugs, no CI-green claim. - Full tracked source hashes and POSIX modes unchanged before/after; every other parent tree entry and mode unchanged. Native full index/history retained. `.bat` checkout CRLF conversion explicitly checked, not mislabeled full blob-byte equivalence. - Heavy flock held, 3 GiB memory/disk reserves monitored; actual minima in the retained samples. Own process group verified absent after exit. - No `AGENTS.md` materialized; its original opaque index/tree entry preserved. Two unchanged SwitchesRemoved methods additionally pass with the public blob supplied only in memory. This is normal source-only runner qualification, not exact-tree hosted CI. Existing baseline failures retained: - `tests/test_appimage_player_build.py` - `tests/test_bake_portability.py` - `tests/test_bug_report.py` - `tests/test_crash_dialog.py` - `tests/test_crt_options.py` - `tests/test_env_on.py` - `tests/test_guest_imported.py` - `tests/test_hardware_report.py` - `tests/test_lift_cleanup_error.py` - `tests/test_link_skip.py` - `tests/test_linux_update.py` - `tests/test_make_game_cache.py` - `tests/test_missing_nup.py` - `tests/test_mods_size_table.py` - `tests/test_options_budget_once.py` - `tests/test_pending_guest_import.py` - `tests/test_pipeline_tour.py` - `tests/test_readback_late.py` - `tests/test_run_all_changed.py` - `tests/test_vk_occlusion_queries.py` - `tests/test_vk_pgo.py` - `tests/test_walk_key.py` **Not tested:** a real human cache, a game or GPU runtime, remote CI. These are game-free cache retention changes; game/GPU testing is not invented as an acceptance gate. No auth/API/push/publication action occurred. **Must be tested:** None for the public-fixture regression; the Windows CLI checks above are complete. Production use and the other exclusions under Not tested remain unqualified. ## Risks **What could break:** a user who intentionally entered NaN to mean immediate eviction instead receives documented defaults. Explicit zero remains immediate eviction for non-recent unlinked objects; negative finite values retain their clamp. Recent-object and hard-link protections are untouched. **Turning it off:** revert the commit. **Compatibility:** no format, key, ABI, save, shader, runtime or shipping-default changes. Valid finite limits and parser infinity results are unchanged; no human cache was touched. ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the public tracker and complete public PR file lists searched; parent scope adopted, no matching issue claimed). - [ ] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. Not ticked yet: Testing's Tested names only game-free Windows CLI checks, and the change touches nx2/, which the game runs. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main` at frozen intake (`d9486a0846e90905e2ee0bdc4a0d6df96c547c87`). Public main has since advanced; no rebase to that later tip is claimed. Relevant source closure is checked again before publication, without transferring full-suite results to another tree. - [x] `python -I -B tests/run_all.py` qualified against its exact pinned-main baseline: native exit 1 is preserved, all 22 existing failures are named above, and no new failure or changed skip status was found. This does not assert a wholly passing suite. - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. Existing settings and shipping defaults are unchanged; the new-switch documentation checklist item does not apply. This fixes the parser handling of invalid NaN values only. - [x] A game-free test added for the fix, failing on `main` and passing here. Source export scope: unchanged gpu/build-shadertool.bat has the recorded .gitattributes LF-to-CRLF conversion. Candidate production and test files match native Git blobs; source/modes are unchanged across each run. Tooling is absent in the isolated runner context: two corresponding failure messages require only an exact sibling-path substitution; the original strict comparison remains false. This is not hosted-CI or literal exact-tree equivalence. **Windows qualification caveats:** Native CPython 3.14.7 used a new independent copy of an existing pinned-dependency runtime, not a venv or a replacement product runner. Each candidate used its own full frozen-head public Git-blob export (2652 tree entries; 2651 files materialized; `AGENTS.md` kept opaque and never materialized). Production/test SHA-256 and all exported file bytes were verified before/after; Git modes remain metadata, not a claim of POSIX permission semantics on NTFS. Normal public test sources and commands were unchanged. Full stdout/stderr and exact native executable/argv/cwd/exit records are retained. A post-test harness assertion exited 1 because five CPython encoding bytecode cache files appeared only in the new owned runtime copy; independent readback confirmed no existing runtime file changed, the original runtime stayed byte-identical, and all test invocations exited 0. No full Windows suite, real compiler, game, GUI, hosted CI or publication qualification is claimed. Existing Linux full-suite results above are unchanged and are not transferred to Windows.
fix(object-store): use default retention for NaN values
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 6s
84b9eba764
Keep finite clamping and infinite limits unchanged; NaN falls back to the
existing default instead of silently becoming zero and evicting objects.

Assisted-by: Hermes Agent (OpenAI GPT-6.1-sol)
Co-Authored-By: Claudia (OpenAI GPT-6.1-sol)
NitnekLeBorgne changed title from WIP: fix(cache): ignore NaN retention settings to fix(cache): ignore NaN retention settings 2026-11-16 03:00:32 +00:00
Member

Code-only review of 84b9eba764; informational findings, with final approval left to another reviewer.

No introduced correctness defect found. The shared parser now rejects NaN before the nonnegative clamp, preserving the 14-day / 8-GB defaults instead of turning invalid input into immediate eviction. Finite limits, infinities, recent-object protection and hard-link protection retain their existing behavior.

The new tests exercise real temporary files through prune(), checking removal counts, bytes and surviving contents. Reverting the NaN guard would break the two-day retention cases; the 15-day case also checks that invalid input does not disable age expiry. I read both changed files, the full pruning implementation and existing object-store tests. The tests' filesystem changes stay inside their temporary fixtures.

The PR reports Linux and native Windows fixture passes, plus a Linux full-suite comparison with 22 baseline failures explicitly retained. I did not reproduce those results or run tests, builds or game code. No overlapping open change to this implementation was found in the supplied inventory; the fix is not already present in the inspected main revision.

Code-only review of 84b9eba764179bd391eca21131491303041de174; informational findings, with final approval left to another reviewer. No introduced correctness defect found. The shared parser now rejects NaN before the nonnegative clamp, preserving the 14-day / 8-GB defaults instead of turning invalid input into immediate eviction. Finite limits, infinities, recent-object protection and hard-link protection retain their existing behavior. The new tests exercise real temporary files through `prune()`, checking removal counts, bytes and surviving contents. Reverting the NaN guard would break the two-day retention cases; the 15-day case also checks that invalid input does not disable age expiry. I read both changed files, the full pruning implementation and existing object-store tests. The tests' filesystem changes stay inside their temporary fixtures. The PR reports Linux and native Windows fixture passes, plus a Linux full-suite comparison with 22 baseline failures explicitly retained. I did not reproduce those results or run tests, builds or game code. No overlapping open change to this implementation was found in the supplied inventory; the fix is not already present in the inspected main revision.
Owner

Brought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).

  • Tested on my own PC: not ticked: Testing's Tested names only game-free Windows CLI checks, and the change touches nx2/, which the game runs. Run it yourself on your PC (in the game, for a change the game runs) and say where and what you saw in Testing's Tested; or, when the fix's own case can't be run by hand, add a **Not testable by hand:** line saying why and what stands in for it. Then tick it.
  • Nothing gets worse that I know of: ticked: Measurements gives a verdict that this is a correctness fix, and Risks names its only behaviour cost.

It goes back to WIP until Tested on my own PC can be ticked; pr ready it again then.

Brought up to the [ready-for-review standard](https://git.magicbean.dev/MagicBeanDev/Longshot/src/branch/main/CONTRIBUTING.md#ready-for-review-out-of-wip) (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know). - *Tested on my own PC*: not ticked: Testing's Tested names only game-free Windows CLI checks, and the change touches nx2/, which the game runs. Run it yourself on your PC (in the game, for a change the game runs) and say where and what you saw in Testing's *Tested*; or, when the fix's own case can't be run by hand, add a `**Not testable by hand:**` line saying why and what stands in for it. Then tick it. - *Nothing gets worse that I know of*: ticked: Measurements gives a verdict that this is a correctness fix, and Risks names its only behaviour cost. It goes back to WIP until *Tested on my own PC* can be ticked; `pr ready` it again then.
HumanBean changed title from fix(cache): ignore NaN retention settings to WIP: fix(cache): ignore NaN retention settings 2026-11-17 20:37:09 +00:00
Some checks are pending
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 6s
This pull request is marked as a work in progress.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'fix/object-store-nan-retention-20261116:NitnekLeBorgne-fix/object-store-nan-retention-20261116'
git switch 'NitnekLeBorgne-fix/object-store-nan-retention-20261116'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1022
No description provided.