fix(docs): the Steam Deck page names places neutrally, and docs changes run the site's checks #1016

Merged
HumanBean merged 1 commit from HumanBean/Longshot:fix/site-steam-deck-names into main 2026-11-16 02:50:06 +00:00
Owner

Type: fix · Risk: low · Tested on: Linux (docs and workflow only) · Needs: none

Why

The website hasn't deployed from main since the Steam Deck page landed (#968). The site check (website/scripts/check-site.ts) refuses a build whose published text names the game's places, and the page named three of them: Kokiri Village, Hyrule Town and Hyrule Field. So /install/steam-deck/ fails the check, and the deploy with it. Earlier fixes such as #731 only rewrite names in the progress items made from players' issues, not in pages the site builds from docs/.

#968 merged without the check ever running on it, because the Website workflow ran only for changes to website/ and the tested-run sources, not for the other docs the site publishes.

How to reproduce

Seen on: Linux, Node 24 (the website build; no game involved)
Settings and switches: defaults
Steps: on main, cd website && npm ci && npm run build && node scripts/check-site.ts
Expected: "Site check passed"
Actual: /install/steam-deck/: game branding remains in published text, exit code 1, so the Website job doesn't deploy

What changed

The page now uses neutral names, and a docs change now runs the site's build and checks, both on its PR and on its push to main.

  • docs/steam-deck-playbook.md: "the starting village's benchmark save", "the castle town" (twice), "the main outdoor area", in line with the wording website/src/lib/public-copy.ts uses for these places.
  • .forgejo/workflows/website.yml: the push and pull_request paths cover docs/** and CONTRIBUTING.md (the sources website/src/content-pages.ts publishes, and the guide images), instead of only docs/tested-configurations.md and docs/tested/**. A docs merge also deploys right away now, instead of waiting for the hourly rebuild.

Measurements

Nothing to measure: a docs and workflow change.

Flags and settings

None

Testing

Tested: before this branch, a build of main at 343a1dfa failed node scripts/check-site.ts with only /install/steam-deck/: game branding remains in published text. On this branch, the check's GAME_BRANDING regex finds nothing left in docs/steam-deck-playbook.md. To get the site back up, main as it was just before #968 (0407ae24) was built, passed the site check and was deployed by hand with wrangler. python -I -B tests/run_all.py: left to CI.

Not tested: the site build and check on this branch. This PR comes from a fork, so the Website job runs on it once a maintainer adds the preview label.

Must be tested:

  • Website job (label preview): the build and npm run check pass, expecting "Site check passed" with /install/steam-deck/ among the pages (Test Farm not needed: the job runs on the label)

Risks

What could break: more Website runs, one for each docs PR from a branch of Longshot and each docs merge to main. Each is a preview upload or a deploy of main.

Turning it off: revert the commit

Compatibility: Nothing changes

Issues

See #968

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named). Left to CI.
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Docs updated.

🤖 Generated with Claude Code

**Type:** fix · **Risk:** low · **Tested on:** Linux (docs and workflow only) · **Needs:** none ## Why The website hasn't deployed from main since the Steam Deck page landed ([#968](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/968)). The site check (`website/scripts/check-site.ts`) refuses a build whose published text names the game's places, and the page named three of them: Kokiri Village, Hyrule Town and Hyrule Field. So `/install/steam-deck/` fails the check, and the deploy with it. Earlier fixes such as [#731](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/731) only rewrite names in the progress items made from players' issues, not in pages the site builds from `docs/`. #968 merged without the check ever running on it, because the Website workflow ran only for changes to `website/` and the tested-run sources, not for the other docs the site publishes. ## How to reproduce **Seen on:** Linux, Node 24 (the website build; no game involved) **Settings and switches:** defaults **Steps:** on main, `cd website && npm ci && npm run build && node scripts/check-site.ts` **Expected:** "Site check passed" **Actual:** `/install/steam-deck/: game branding remains in published text`, exit code 1, so the Website job doesn't deploy ## What changed The page now uses neutral names, and a docs change now runs the site's build and checks, both on its PR and on its push to main. - `docs/steam-deck-playbook.md`: "the starting village's benchmark save", "the castle town" (twice), "the main outdoor area", in line with the wording `website/src/lib/public-copy.ts` uses for these places. - `.forgejo/workflows/website.yml`: the push and pull_request `paths` cover `docs/**` and `CONTRIBUTING.md` (the sources `website/src/content-pages.ts` publishes, and the guide images), instead of only `docs/tested-configurations.md` and `docs/tested/**`. A docs merge also deploys right away now, instead of waiting for the hourly rebuild. ## Measurements Nothing to measure: a docs and workflow change. ### Flags and settings None ## Testing **Tested:** before this branch, a build of main at `343a1dfa` failed `node scripts/check-site.ts` with only `/install/steam-deck/: game branding remains in published text`. On this branch, the check's `GAME_BRANDING` regex finds nothing left in `docs/steam-deck-playbook.md`. To get the site back up, main as it was just before #968 (`0407ae24`) was built, passed the site check and was deployed by hand with wrangler. `python -I -B tests/run_all.py`: left to CI. **Not tested:** the site build and check on this branch. This PR comes from a fork, so the Website job runs on it once a maintainer adds the `preview` label. **Must be tested:** - Website job (label `preview`): the build and `npm run check` pass, expecting "Site check passed" with `/install/steam-deck/` among the pages (Test Farm not needed: the job runs on the label) ## Risks **What could break:** more Website runs, one for each docs PR from a branch of Longshot and each docs merge to main. Each is a preview upload or a deploy of main. **Turning it off:** revert the commit **Compatibility:** Nothing changes ## Issues See [#968](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/968) ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [ ] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). Left to CI. - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Docs updated. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(docs): the Steam Deck page names places neutrally, and docs changes run the site's checks
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 6s
Website / Website on Cloudflare (pull_request_target) Has been skipped
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 10s
CI / Workflow lint (actionlint) (pull_request) Successful in 12s
Third-party parts / As their notes say (pull_request) Successful in 14s
PR description / Description follows the template (pull_request_target) Failing after 4s
b3291c0695
The site check rejects game names in published text, and the Steam Deck page
(#968) named three places, so every deploy from main failed. The Website workflow
didn't run on docs-only changes, so #968 merged without the check seeing it: it
now runs for docs/ and CONTRIBUTING.md, which the site publishes.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
HumanBean changed title from WIP: fix(docs): the Steam Deck page names places neutrally, and docs changes run the site's checks to fix(docs): the Steam Deck page names places neutrally, and docs changes run the site's checks 2026-11-16 02:49:55 +00:00
HumanBean deleted branch fix/site-steam-deck-names 2026-11-16 02:50:06 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1016
No description provided.