test(checks): 99 more checks cut with srccut, not a copy of their own #949

Open
zeldaootr wants to merge 1 commit from zeldaootr/Longshot:tests-source-cut into main
Contributor

Summary

Nothing a player would notice: this is about the game-free checks. #27 gave the checks one cutter, tests/srccut.py, and moved 78 of them to it; main still had over a hundred checks under tests/ with their own copy of the plain brace counter (under the names block, function, body or cut), which counts braces in comments and strings and stops with a bare ValueError when a function is renamed. This PR moves 98 of them to srccut; every cut they make is the text the old counter cut. (The title and the commit say 99: the 99th, tests/test_program_load_wait.py, was moved on main meanwhile, so main's file stands and this PR no longer touches it.)

This PR first opened with a cutter of its own (tests/source_cut.py), written before #27 merged. That module is gone from it: one cutter is the point.

Read first:

  • 97 checks under tests/: their copy of the plain counter removed; they put tests/ on the path and import block (as function, body or cut where that was the copy's name). A mechanical change, made by a script, one commit. Only copies that are the plain counter exactly (their syntax trees compared, names aside) were moved. Where main's newer import blocks (sys, the tests/ path, menu_model_fixture, from #1774) were already there, they stay and the srccut import follows them.
  • tests/test_nvn_null_pool.py, tests/test_nvn_tex_builder_guard.py: both caught ValueError for a marker an older --source lacks, which srccut does not raise (it stops the check); they ask whether the marker is there first.
  • Not moved:
    • 8 with the plain counter whose marker is in the source more than once, where srccut stops and the old counter took the first silently: test_invalidate_vcore, test_multiwait_wake, test_png_publication, test_predict_sees_loaded, test_prepared_stamps, test_program_cache_cleanup, test_program_cache_index, test_prompts_live. Each needs a look, as #27 says of its 13.
    • 8 with no ROOT line to anchor the import on (5 under nx2/), and nx2/test_coop_spirv.py, so that this PR touches only tests/.
    • the checks whose cutter is not the plain counter (an index instead of a marker, a tail to include).

See #27

Testing

Tested: on Linux x86-64 (Ryzen 7 5700U; clang 23.1.5, g++, glslang, spirv-val, the Vulkan and SPIR-V headers), in the PC's job queue, at this head (c3970f89c on main 068fb8ebe): the 98 moved checks by name (103 checks: a few names are the start of others'), on main 068fb8ebe and here with SRCCUT_CHECK_NAIVE=1: 90 passed and 13 failed on both, the same 13: test_capture_readback_visibility, test_damage_debug_menu, test_linux_pressure, test_mods_size_table, test_portable_setup_start, test_portable_setup_transaction, test_present_aspect_vulkan, test_present_source_crop, test_present_thread, test_psychov35_fsr3_fg, test_readback_timeout_source, test_setup_runtime_paths, test_vk_occlusion_queries (three of them Windows-only checks a full run skips on Linux; test_present_aspect_vulkan needs a Vulkan device). tests/test_srccut.py passes. the 112 checks that read its files (run_all.py --changed forge/main): 102 passed, 10 failed, 4 skipped (Windows-only, or a Vulkan 1.3 device), the 10 failing on main too; and the whole python3 -I -B tests/run_all.py (not --strict) here and on main 068fb8ebe, back to back in the same environment: here 781 passed, 61 failed, 28 skipped; main 782 passed, 60 failed, 28 skipped. Every check that fails here fails on main too, but test_prepare_stall, a timed check that failed here in the loaded 16-way run and passes alone (twice); main's failures are this PC's environment (tools, modules and timing). Nothing runs in the game: the PR touches only checks under tests/.

Rebased since onto main 1780fbe0c (head ef370f132): one of the 98, tests/test_parallel_small_cb.py, is gone because main deleted it with the parallel replay it tested (#1763), so 97 are moved. The whole tests/run_all.py in the job queue at ef370f132 and at main 1780fbe0c: 773 passed, 71 failed, 28 skipped on both; the failing names are the same after tests/test_job_queue.py (failed here only) and tests/test_pipeline_cache_save.py (failed on main only) each passed on both sides when run again alone. The 12 moved checks that fail, fail on main for the same reason. SRCCUT_CHECK_NAIVE=1 was not run again at this head; the numbers below are from c3970f89c.

The 59 checks that fail both here (c3970f89c) and on main 068fb8ebe

test_appimage_player_build, test_bug_report_defaults, test_capture_read_once, test_capture_readback_visibility, test_crash_dialog, test_crt_options, test_damage_debug_menu, test_dev_ab, test_dev_packs, test_discover, test_display_startup_failure, test_dlss_feature_size, test_draw_stream_visibility, test_failed_compile_keeps_objects, test_frame_overlap, test_fsr3fi_hud_layer, test_fsr_image_retirement, test_fsr_uniform_ownership, test_guest_imported, test_high_fps_fixes, test_host_guest_writes, test_hud_layout_row, test_libc_hooks, test_lift_cache, test_lift_lookups, test_linux_preflight, test_linux_pressure, test_linux_tools, test_linux_update, test_log_open_failure, test_make_game_cache, test_make_game_ngx, test_mise_build, test_missing_nup, test_mods_list, test_mods_size_table, test_ngx_sdk, test_nonuniform_image_arrays, test_parallel_init_order, test_pending_guest_import, test_pipeline_play_cache, test_prepare_cache_save, test_present_queue_default, test_present_source_crop, test_present_thread, test_profiling_mode, test_psychov35_fsr3_fg, test_readback_timeout_source, test_replay_write_order, test_slow_frames, test_song_note_cue, test_staging_burst, test_texel_buffer_ownership, test_thinlto_tls, test_upscaler_rows, test_vcore_escape, test_vk_occlusion_queries, test_walk, test_walk_key

Still to test:

  • Windows, any GPU: python -I -B tests/run_all.py, expecting the same results as on main (by hand, or CI where it runs the checks on Windows)

Measurements

Verdict: nothing changes but where the checks get their cutter: the moved checks pass and fail exactly as on main, and with SRCCUT_CHECK_NAIVE=1 every cut srccut makes is also made by the old counter and compared: none differs in the 90 checks that pass (a difference would stop the check). Nothing to measure in the game.

Setup: Linux x86-64, Ryzen 7 5700U; no game run; the 98 moved checks by name through tests/run_all.py --jobs 5, once on main and once here with SRCCUT_CHECK_NAIVE=1 (SRCCUT_CHECK_NAIVE=1 python3 -I -B tests/run_all.py <the moved checks' names>), in the PC's job queue

Before: main @ 068fb8ebe After, SRCCUT_CHECK_NAIVE=1: this PR @ c3970f89c
the moved checks by name: passed / failed / skipped 90 / 13 / 0 90 / 13 / 0, the same 13
cuts that differ from the old counter's (no srccut in them) 0 (a difference stops the check; the 13 that fail fail the same on main)
Before (main 068fb8ebe):                     90 passed, 13 failed, 0 skipped in 123 s (linux, 5 at once)
After (c3970f89c, SRCCUT_CHECK_NAIVE=1):     90 passed, 13 failed, 0 skipped in 121 s (linux, 5 at once)

Risks

A moved check whose marker comes to be in its source twice now stops and says so, where its own counter took the first. It touches 97 checks other open pull requests may touch, a few lines each at the import block: whichever lands second rebases, and this one's commit is made again by its script. A revert is enough to undo it. A player notices nothing: no game file, save, longshot_options.ini or cache changes.

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit.
  • Tested on my own PC, in the game for a change the game runs, as Testing says. [not a change the game runs: the checks, on Linux]
  • mise run test passes (any failure that also fails on main is named).
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested. [Windows not run]
  • Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers"). [none: it changes no code the game runs]
  • Approved in review, every comment answered. [no review yet]
  • CI passes on the head; on current main, measured again or a comment says why the numbers still hold. [measured again on main 068fb8ebe; the head is not pushed yet, so CI has not run on it]
## Summary Nothing a player would notice: this is about the game-free checks. https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/27 gave the checks one cutter, `tests/srccut.py`, and moved 78 of them to it; main still had over a hundred checks under `tests/` with their own copy of the plain brace counter (under the names `block`, `function`, `body` or `cut`), which counts braces in comments and strings and stops with a bare `ValueError` when a function is renamed. This PR moves 98 of them to `srccut`; every cut they make is the text the old counter cut. (The title and the commit say 99: the 99th, `tests/test_program_load_wait.py`, was moved on main meanwhile, so main's file stands and this PR no longer touches it.) This PR first opened with a cutter of its own (`tests/source_cut.py`), written before https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/27 merged. That module is gone from it: one cutter is the point. Read first: - 97 checks under `tests/`: their copy of the plain counter removed; they put `tests/` on the path and import `block` (as `function`, `body` or `cut` where that was the copy's name). A mechanical change, made by a script, one commit. Only copies that are the plain counter exactly (their syntax trees compared, names aside) were moved. Where main's newer import blocks (`sys`, the `tests/` path, `menu_model_fixture`, from https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1774) were already there, they stay and the `srccut` import follows them. - `tests/test_nvn_null_pool.py`, `tests/test_nvn_tex_builder_guard.py`: both caught `ValueError` for a marker an older `--source` lacks, which `srccut` does not raise (it stops the check); they ask whether the marker is there first. - Not moved: - 8 with the plain counter whose marker is in the source more than once, where `srccut` stops and the old counter took the first silently: `test_invalidate_vcore`, `test_multiwait_wake`, `test_png_publication`, `test_predict_sees_loaded`, `test_prepared_stamps`, `test_program_cache_cleanup`, `test_program_cache_index`, `test_prompts_live`. Each needs a look, as https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/27 says of its 13. - 8 with no `ROOT` line to anchor the import on (5 under `nx2/`), and `nx2/test_coop_spirv.py`, so that this PR touches only `tests/`. - the checks whose cutter is not the plain counter (an index instead of a marker, a tail to include). See https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/27 ## Testing **Tested:** on Linux x86-64 (Ryzen 7 5700U; clang 23.1.5, g++, glslang, spirv-val, the Vulkan and SPIR-V headers), in the PC's job queue, at this head (c3970f89c on main 068fb8ebe): the 98 moved checks by name (103 checks: a few names are the start of others'), on main 068fb8ebe and here with `SRCCUT_CHECK_NAIVE=1`: 90 passed and 13 failed on both, the same 13: `test_capture_readback_visibility`, `test_damage_debug_menu`, `test_linux_pressure`, `test_mods_size_table`, `test_portable_setup_start`, `test_portable_setup_transaction`, `test_present_aspect_vulkan`, `test_present_source_crop`, `test_present_thread`, `test_psychov35_fsr3_fg`, `test_readback_timeout_source`, `test_setup_runtime_paths`, `test_vk_occlusion_queries` (three of them Windows-only checks a full run skips on Linux; `test_present_aspect_vulkan` needs a Vulkan device). `tests/test_srccut.py` passes. the 112 checks that read its files (`run_all.py --changed forge/main`): 102 passed, 10 failed, 4 skipped (Windows-only, or a Vulkan 1.3 device), the 10 failing on main too; and the whole `python3 -I -B tests/run_all.py` (not `--strict`) here and on main 068fb8ebe, back to back in the same environment: here 781 passed, 61 failed, 28 skipped; main 782 passed, 60 failed, 28 skipped. Every check that fails here fails on main too, but `test_prepare_stall`, a timed check that failed here in the loaded 16-way run and passes alone (twice); main's failures are this PC's environment (tools, modules and timing). Nothing runs in the game: the PR touches only checks under `tests/`. Rebased since onto main 1780fbe0c (head ef370f132): one of the 98, `tests/test_parallel_small_cb.py`, is gone because main deleted it with the parallel replay it tested (https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1763), so 97 are moved. The whole `tests/run_all.py` in the job queue at ef370f132 and at main 1780fbe0c: 773 passed, 71 failed, 28 skipped on both; the failing names are the same after `tests/test_job_queue.py` (failed here only) and `tests/test_pipeline_cache_save.py` (failed on main only) each passed on both sides when run again alone. The 12 moved checks that fail, fail on main for the same reason. `SRCCUT_CHECK_NAIVE=1` was not run again at this head; the numbers below are from c3970f89c. <details><summary>The 59 checks that fail both here (c3970f89c) and on main 068fb8ebe</summary> `test_appimage_player_build`, `test_bug_report_defaults`, `test_capture_read_once`, `test_capture_readback_visibility`, `test_crash_dialog`, `test_crt_options`, `test_damage_debug_menu`, `test_dev_ab`, `test_dev_packs`, `test_discover`, `test_display_startup_failure`, `test_dlss_feature_size`, `test_draw_stream_visibility`, `test_failed_compile_keeps_objects`, `test_frame_overlap`, `test_fsr3fi_hud_layer`, `test_fsr_image_retirement`, `test_fsr_uniform_ownership`, `test_guest_imported`, `test_high_fps_fixes`, `test_host_guest_writes`, `test_hud_layout_row`, `test_libc_hooks`, `test_lift_cache`, `test_lift_lookups`, `test_linux_preflight`, `test_linux_pressure`, `test_linux_tools`, `test_linux_update`, `test_log_open_failure`, `test_make_game_cache`, `test_make_game_ngx`, `test_mise_build`, `test_missing_nup`, `test_mods_list`, `test_mods_size_table`, `test_ngx_sdk`, `test_nonuniform_image_arrays`, `test_parallel_init_order`, `test_pending_guest_import`, `test_pipeline_play_cache`, `test_prepare_cache_save`, `test_present_queue_default`, `test_present_source_crop`, `test_present_thread`, `test_profiling_mode`, `test_psychov35_fsr3_fg`, `test_readback_timeout_source`, `test_replay_write_order`, `test_slow_frames`, `test_song_note_cue`, `test_staging_burst`, `test_texel_buffer_ownership`, `test_thinlto_tls`, `test_upscaler_rows`, `test_vcore_escape`, `test_vk_occlusion_queries`, `test_walk`, `test_walk_key` </details> **Still to test:** - Windows, any GPU: `python -I -B tests/run_all.py`, expecting the same results as on `main` (by hand, or CI where it runs the checks on Windows) ## Measurements **Verdict:** nothing changes but where the checks get their cutter: the moved checks pass and fail exactly as on `main`, and with `SRCCUT_CHECK_NAIVE=1` every cut `srccut` makes is also made by the old counter and compared: none differs in the 90 checks that pass (a difference would stop the check). Nothing to measure in the game. Setup: Linux x86-64, Ryzen 7 5700U; no game run; the 98 moved checks by name through `tests/run_all.py --jobs 5`, once on `main` and once here with `SRCCUT_CHECK_NAIVE=1` (`SRCCUT_CHECK_NAIVE=1 python3 -I -B tests/run_all.py <the moved checks' names>`), in the PC's job queue | | Before: main @ 068fb8ebe | After, SRCCUT_CHECK_NAIVE=1: this PR @ c3970f89c | |---|---|---| | the moved checks by name: passed / failed / skipped | 90 / 13 / 0 | 90 / 13 / 0, the same 13 | | cuts that differ from the old counter's | (no srccut in them) | 0 (a difference stops the check; the 13 that fail fail the same on main) | ``` Before (main 068fb8ebe): 90 passed, 13 failed, 0 skipped in 123 s (linux, 5 at once) After (c3970f89c, SRCCUT_CHECK_NAIVE=1): 90 passed, 13 failed, 0 skipped in 121 s (linux, 5 at once) ``` ## Risks A moved check whose marker comes to be in its source twice now stops and says so, where its own counter took the first. It touches 97 checks other open pull requests may touch, a few lines each at the import block: whichever lands second rebases, and this one's commit is made again by its script. A revert is enough to undo it. A player notices nothing: no game file, save, `longshot_options.ini` or cache changes. ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. - [x] Tested on my own PC, in the game for a change the game runs, as Testing says. [not a change the game runs: the checks, on Linux] - [x] `mise run test` passes (any failure that also fails on `main` is named). - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. ### Ready to merge - [ ] Everything in Still to test has run, its results in Tested. [Windows not run] - [x] Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers"). [none: it changes no code the game runs] - [ ] Approved in review, every comment answered. [no review yet] - [ ] CI passes on the head; on current `main`, measured again or a comment says why the numbers still hold. [measured again on main 068fb8ebe; the head is not pushed yet, so CI has not run on it]
zeldaootr force-pushed tests-source-cut from 3b64e7a5aa
Some checks failed
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to 3c8c941bb4
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
2026-11-15 22:47:31 +00:00
Compare
Author
Contributor

Description moved to the current template. Each commit's subject is a Conventional Commit now (the branch is 3c8c941b; no change to the files).

Description moved to the current template. Each commit's subject is a Conventional Commit now (the branch is 3c8c941b; no change to the files).
zeldaootr force-pushed tests-source-cut from 3c8c941bb4
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 4s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
to 9622b74ce7
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 11s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-15 23:09:30 +00:00
Compare
Author
Contributor

Reworked: #27 merged its own cutter, tests/srccut.py, while this was open, so this PR no longer adds one. It now moves 99 more checks with the plain counter onto srccut (branch 9622b74c on main a8a30c22), each cut compared with the old counter's (SRCCUT_CHECK_NAIVE=1).

Reworked: #27 merged its own cutter, `tests/srccut.py`, while this was open, so this PR no longer adds one. It now moves 99 more checks with the plain counter onto `srccut` (branch 9622b74c on main a8a30c22), each cut compared with the old counter's (`SRCCUT_CHECK_NAIVE=1`).
zeldaootr changed title from WIP: test(checks): one source cutter for the checks, not a copy in each to WIP: test(checks): 99 more checks cut with srccut, not a copy of their own 2026-11-15 23:10:04 +00:00
zeldaootr changed title from WIP: test(checks): 99 more checks cut with srccut, not a copy of their own to test(checks): 99 more checks cut with srccut, not a copy of their own 2026-11-15 23:10:18 +00:00
Owner

Brought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).

  • Tested on my own PC: ticked: Testing's Tested: the author ran the moved checks on Linux and lists the six that fail on main.
  • Nothing gets worse that I know of: ticked: Measurements gives check times and says nothing to measure in the game, and Risks names no cost.
Brought up to the [ready-for-review standard](https://git.magicbean.dev/MagicBeanDev/Longshot/src/branch/main/CONTRIBUTING.md#ready-for-review-out-of-wip) (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know). - *Tested on my own PC*: ticked: Testing's Tested: the author ran the moved checks on Linux and lists the six that fail on main. - *Nothing gets worse that I know of*: ticked: Measurements gives check times and says nothing to measure in the game, and Risks names no cost.
zeldaootr force-pushed tests-source-cut from 9622b74ce7
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 11s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 8fb917cae9
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 9s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-18 12:30:19 +00:00
Compare
Author
Contributor

Rebased onto main 430eef4f2 (it conflicted in two checks). tests/test_program_load_wait.py was already moved to srccut on main, so main's text stands and this PR no longer touches it; tests/test_setup_tool_merge.py keeps main's newer comment. tests/run_all.py on Linux at this head and on main 430eef4f2 in the same environment: the same checks fail on both.

Rebased onto main 430eef4f2 (it conflicted in two checks). `tests/test_program_load_wait.py` was already moved to `srccut` on main, so main's text stands and this PR no longer touches it; `tests/test_setup_tool_merge.py` keeps main's newer comment. `tests/run_all.py` on Linux at this head and on main 430eef4f2 in the same environment: the same checks fail on both.
zeldaootr force-pushed tests-source-cut from 8fb917cae9
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 9s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to aebe1c185e
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 7s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-19 01:08:49 +00:00
Compare
Author
Contributor

Rebased onto main 8fde50a21 (one conflict, tests/test_threaded_rendering.py: main rewrote the check, so main's file stands with only the counter swapped for the srccut import). All 98 touched files differ from main's by that swap alone, apart from the two intended changes. tests/run_all.py on Linux at this head and on main 8fde50a21 in the same environment (742 passed / 52 failed here, 743 / 51 on main): two checks failed here only in the loaded full run and both pass twice alone.

Rebased onto main 8fde50a21 (one conflict, tests/test_threaded_rendering.py: main rewrote the check, so main's file stands with only the counter swapped for the srccut import). All 98 touched files differ from main's by that swap alone, apart from the two intended changes. tests/run_all.py on Linux at this head and on main 8fde50a21 in the same environment (742 passed / 52 failed here, 743 / 51 on main): two checks failed here only in the loaded full run and both pass twice alone.
zeldaootr force-pushed tests-source-cut from aebe1c185e
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 7s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 895e9f81dc
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 10s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-19 22:49:19 +00:00
Compare
Author
Contributor

Rebased onto main 0de25c3e4 (head 895e9f81d). Main's menu-model refactor (#1774) added import sys, the tests/ path and menu_model_fixture to the import blocks of test_auto_settings, test_damage_debug_menu, test_intel_compiles_auto and test_threaded_rendering, where this PR puts its srccut import: each keeps main's lines and adds the srccut import after them, with sys imported once at the top. Otherwise the commit is as before; a full run here (789 passed, 57 failed) fails nothing that passes on main 0de25c3e4 (788 / 58).

Rebased onto main 0de25c3e4 (head 895e9f81d). Main's menu-model refactor (https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1774) added `import sys`, the `tests/` path and `menu_model_fixture` to the import blocks of `test_auto_settings`, `test_damage_debug_menu`, `test_intel_compiles_auto` and `test_threaded_rendering`, where this PR puts its `srccut` import: each keeps main's lines and adds the `srccut` import after them, with `sys` imported once at the top. Otherwise the commit is as before; a full run here (789 passed, 57 failed) fails nothing that passes on main 0de25c3e4 (788 / 58).
zeldaootr force-pushed tests-source-cut from 895e9f81dc
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 10s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to c3970f89c7
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 7s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
CI / Website build and checks (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-20 03:39:50 +00:00
Compare
Author
Contributor

Rebased onto main 068fb8ebe, the docs and tools revamp (head c3970f89c), with no conflict: the commit is the same as before (git range-diff: =). The description now follows the new template; it counts 98 moved checks, since test_program_load_wait was moved on main earlier and this PR no longer touches it (the title and commit still say 99). The moved checks were run again on main 068fb8ebe and here with SRCCUT_CHECK_NAIVE=1, and the full game-free run fails nothing here that main doesn't also fail on this PC.

Rebased onto main 068fb8ebe, the docs and tools revamp (head c3970f89c), with no conflict: the commit is the same as before (`git range-diff`: `=`). The description now follows the new template; it counts 98 moved checks, since `test_program_load_wait` was moved on main earlier and this PR no longer touches it (the title and commit still say 99). The moved checks were run again on main 068fb8ebe and here with `SRCCUT_CHECK_NAIVE=1`, and the full game-free run fails nothing here that main doesn't also fail on this PC.
Author
Contributor

Rebased onto main 1780fbe0c (head ef370f132). One conflict: main deleted tests/test_parallel_small_cb.py with the parallel replay it tested (#1763), so that file is dropped here and 97 checks are moved, not 98. The whole tests/run_all.py gives the same result here and on main 1780fbe0c (773 passed, 71 failed, 28 skipped; the same failing names once two timing-sensitive checks were run again alone). SRCCUT_CHECK_NAIVE=1 was not run again at this head.

Rebased onto main 1780fbe0c (head ef370f132). One conflict: main deleted `tests/test_parallel_small_cb.py` with the parallel replay it tested (https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1763), so that file is dropped here and 97 checks are moved, not 98. The whole `tests/run_all.py` gives the same result here and on main 1780fbe0c (773 passed, 71 failed, 28 skipped; the same failing names once two timing-sensitive checks were run again alone). `SRCCUT_CHECK_NAIVE=1` was not run again at this head.
zeldaootr force-pushed tests-source-cut from c3970f89c7
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 7s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
CI / Website build and checks (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to ef370f1327
Some checks failed
PR description / Description follows the template (pull_request_target) Has been cancelled
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
CI / Website build and checks (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-20 09:14:05 +00:00
Compare
Author
Contributor

Rebased onto main 8859673e4 (head 9e1cfdde1). One conflict, in tests/test_collect_wide.py, which main rewrote: main's new cases are kept as they are, and its own copy of the brace counter is replaced by the srccut import as in the other moved checks. That check passes here after the rebase (x86-64, SSE2 and AVX2 walks). The rest of the checks were not run again at this head.

Rebased onto main 8859673e4 (head 9e1cfdde1). One conflict, in `tests/test_collect_wide.py`, which main rewrote: main's new cases are kept as they are, and its own copy of the brace counter is replaced by the `srccut` import as in the other moved checks. That check passes here after the rebase (x86-64, SSE2 and AVX2 walks). The rest of the checks were not run again at this head.
zeldaootr force-pushed tests-source-cut from ef370f1327
Some checks failed
PR description / Description follows the template (pull_request_target) Has been cancelled
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
CI / Website build and checks (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 9e1cfdde17
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 11s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
CI / Website build and checks (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
2026-11-20 19:54:57 +00:00
Compare
Author
Contributor

Rebased onto main bca5fab96 (head 2dc39cd12); the commit applied without a conflict. Twenty-five of the moved checks, run here and on main bca5fab96, give the same result on both; the rest were not run again at this head.

Rebased onto main bca5fab96 (head 2dc39cd12); the commit applied without a conflict. Twenty-five of the moved checks, run here and on main bca5fab96, give the same result on both; the rest were not run again at this head.
zeldaootr force-pushed tests-source-cut from 9e1cfdde17
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 11s
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
CI / Website build and checks (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to 2dc39cd128
Some checks are pending
CI / Website build and checks (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 16s
2026-11-20 23:00:22 +00:00
Compare
Some checks are pending
CI / Website build and checks (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Blocked by required conditions
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Blocked by required conditions
CI / Conventional Commit title (pull_request) Blocked by required conditions
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Blocked by required conditions
CI / Workflow lint (actionlint) (pull_request) Blocked by required conditions
Guide screenshots / Guide images and local UI source review (pull_request) Blocked by required conditions
Third-party parts / As their notes say (pull_request) Blocked by required conditions
Third-party parts / The same as upstream (pull_request) Blocked by required conditions
Website / Website on Cloudflare (pull_request) Blocked by required conditions
PR description / Description follows the template (pull_request_target) Successful in 16s
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
Some workflows are waiting to be reviewed.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'tests-source-cut:zeldaootr-tests-source-cut'
git switch 'zeldaootr-tests-source-cut'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!949
No description provided.