WIP: feat(builder): accept .nx archives (NXFormat) as the game files #685

Draft
nussico wants to merge 1 commit from nussico/Longshot:builder/nx-format into main
First-time contributor

Type: feat · Risk: low · Tested on: Windows 11, RTX 2070 · Needs: Linux, any GPU

Why

Players who keep their game as a .nx file (NXFormat, github.com/fab918/nxformat, made with nxconvert pack-nup) have to convert it back to a .nup or to folders before Longshot can build. With this PR the builder takes the .nx directly.

What changed

make_game.py now reads a .nx archive wherever it reads a .nup: it tells the two apart by the file's first bytes and runs a new reader for the .nx. The reader reuses nup.py's extraction, so path checks, progress and the damaged-.zs list behave the same, and every file is checked against its SHA-256 in the archive.

  • nx2: nx2/nxar.py (class Nx and a CLI like nup.py's) reads NX 0.2 and 0.3 archives holding exefs/romfs trees. A .nx holding NCA files (nxconvert pack) is refused with a message saying how to convert it. nx2/test_nxar.py builds archives from the spec, game-free.
  • nx2: nx2/nup.py: the step after extraction (plain NSOs, ZBIC) moved into plain_modules(), which nxar.py calls too. The .nup path is unchanged.
  • make_game: package_script() in nx2/make_game.py picks nx2/nxar.py or nx2/nup.py by the NXAR magic, in check() and in main()'s extraction; --nup and --game help mention .nx. Test: tests/test_make_game_package_script.py.
  • game files: .gitignore ignores *.nx and scripts/release.py's NOT_A_RELEASE_FILE refuses .nx (a .nx is a whole dump); CONTRIBUTING lists it with the game files.
  • docs: README (game copy section and command line), website/src/content/docs/requirements.mdx (its copy) and docs/development.md.

The launcher's side (finding, browsing and dropping .nx files) is a separate PR on LongshotLauncher, and needs a Longshot release with this change.

Measurements

Nothing to measure in the game: this changes only how the builder reads the game file; the build it makes and the game are unchanged (see Testing for the extraction check and its speed).

Flags and settings

None

Testing

Tested: On Windows 11 build 26300 (llvm-mingw 20260616), with my own copy, the same code in Hookshot's tree (this PR is that change with Longshot's names). The game files never left my PC.

  • The .nx and the .nup of the same game hold the same 186,592 files by path, size and SHA-256, with byte-identical exefs and build id e0f3ccfa.
  • Every file of the .nx decoded and SHA-256-checked: 26.27 GB in 158 s from disk (166 MB/s).
  • make_game.py --check --nup <file.nx>: "This is the version ... supports (build e0f3ccfa)."
  • A build from the .nx extracted all 186,592 files, made main a plain NSO and translated 100% of the code. The game it built starts and plays (NVIDIA GeForce RTX 2070, driver 32.0.16.2101).
  • In this tree: nx2/test_nxar.py and tests/test_make_game_package_script.py pass. python -I -B tests/run_all.py: 504 passed, 19 failed, 72 skipped; the same 19 fail on main @ 53f96d7 on this PC: test_appimage_player_build, test_cpm_discovery, test_cpp_preflight, test_crash_dialog, test_cv_signal_race, test_env_on, test_fpx_sticky, test_lift_cleanup_error, test_linux_preflight, test_make_game_cache, test_make_game_prepare, test_missing_nup, test_oot_state_tap, test_readback_late, test_spawn_emit, test_tested_configurations, test_vk_pgo, test_vram_budget_row, test_walk_key.

Not tested: A build from this Longshot branch in the game (only Hookshot's tree with the same change); Linux (I have no Linux PC).

Must be tested:

  • Linux, any GPU: run python -I nx2/make_game.py --check --nup <your .nx> and then a build with --nup <your .nx> (a .nx made from your .nup with nxconvert pack-nup), expecting the check to report build e0f3ccfa and the game to start (by hand: a tester with a .nx, since the farm's copies are .nup).

Risks

What could break: Only a file starting with NXAR goes to the new reader; every .nup still goes to nup.py, whose extraction is unchanged except that its last step moved into a function.

Turning it off: revert the commit.

Compatibility: Nothing changes for a player who builds from a .nup or folders: no saves, options, caches or vk ABI touched.

Issues

Fixes #411

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why. Not ticked yet: The in-game build ran from Hookshot's tree, and the PR says this Longshot branch was not built and run in the game.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • A check under tests/ that reads changed source updated in this PR, not weakened.
  • Docs updated.
**Type:** feat · **Risk:** low · **Tested on:** Windows 11, RTX 2070 · **Needs:** Linux, any GPU ## Why Players who keep their game as a `.nx` file (NXFormat, github.com/fab918/nxformat, made with `nxconvert pack-nup`) have to convert it back to a `.nup` or to folders before Longshot can build. With this PR the builder takes the `.nx` directly. ## What changed `make_game.py` now reads a `.nx` archive wherever it reads a `.nup`: it tells the two apart by the file's first bytes and runs a new reader for the `.nx`. The reader reuses `nup.py`'s extraction, so path checks, progress and the damaged-`.zs` list behave the same, and every file is checked against its SHA-256 in the archive. - nx2: `nx2/nxar.py` (class `Nx` and a CLI like `nup.py`'s) reads NX 0.2 and 0.3 archives holding exefs/romfs trees. A `.nx` holding NCA files (`nxconvert pack`) is refused with a message saying how to convert it. `nx2/test_nxar.py` builds archives from the spec, game-free. - nx2: `nx2/nup.py`: the step after extraction (plain NSOs, ZBIC) moved into `plain_modules()`, which `nxar.py` calls too. The `.nup` path is unchanged. - make_game: `package_script()` in `nx2/make_game.py` picks `nx2/nxar.py` or `nx2/nup.py` by the NXAR magic, in `check()` and in `main()`'s extraction; `--nup` and `--game` help mention `.nx`. Test: `tests/test_make_game_package_script.py`. - game files: `.gitignore` ignores `*.nx` and `scripts/release.py`'s `NOT_A_RELEASE_FILE` refuses `.nx` (a `.nx` is a whole dump); CONTRIBUTING lists it with the game files. - docs: README (game copy section and command line), `website/src/content/docs/requirements.mdx` (its copy) and `docs/development.md`. The launcher's side (finding, browsing and dropping `.nx` files) is a separate PR on LongshotLauncher, and needs a Longshot release with this change. ## Measurements Nothing to measure in the game: this changes only how the builder reads the game file; the build it makes and the game are unchanged (see Testing for the extraction check and its speed). ### Flags and settings None ## Testing **Tested:** On Windows 11 build 26300 (llvm-mingw 20260616), with my own copy, the same code in Hookshot's tree (this PR is that change with Longshot's names). The game files never left my PC. - The `.nx` and the `.nup` of the same game hold the same 186,592 files by path, size and SHA-256, with byte-identical exefs and build id `e0f3ccfa`. - Every file of the `.nx` decoded and SHA-256-checked: 26.27 GB in 158 s from disk (166 MB/s). - `make_game.py --check --nup <file.nx>`: "This is the version ... supports (build e0f3ccfa)." - A build from the `.nx` extracted all 186,592 files, made `main` a plain NSO and translated 100% of the code. The game it built starts and plays (NVIDIA GeForce RTX 2070, driver 32.0.16.2101). - In this tree: `nx2/test_nxar.py` and `tests/test_make_game_package_script.py` pass. `python -I -B tests/run_all.py`: 504 passed, 19 failed, 72 skipped; the same 19 fail on `main` @ 53f96d7 on this PC: test_appimage_player_build, test_cpm_discovery, test_cpp_preflight, test_crash_dialog, test_cv_signal_race, test_env_on, test_fpx_sticky, test_lift_cleanup_error, test_linux_preflight, test_make_game_cache, test_make_game_prepare, test_missing_nup, test_oot_state_tap, test_readback_late, test_spawn_emit, test_tested_configurations, test_vk_pgo, test_vram_budget_row, test_walk_key. **Not tested:** A build from this Longshot branch in the game (only Hookshot's tree with the same change); Linux (I have no Linux PC). **Must be tested:** - Linux, any GPU: run `python -I nx2/make_game.py --check --nup <your .nx>` and then a build with `--nup <your .nx>` (a `.nx` made from your `.nup` with `nxconvert pack-nup`), expecting the check to report build e0f3ccfa and the game to start (by hand: a tester with a `.nx`, since the farm's copies are `.nup`). ## Risks **What could break:** Only a file starting with `NXAR` goes to the new reader; every `.nup` still goes to `nup.py`, whose extraction is unchanged except that its last step moved into a function. **Turning it off:** revert the commit. **Compatibility:** Nothing changes for a player who builds from a `.nup` or folders: no saves, options, caches or vk ABI touched. ## Issues Fixes #411 ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [ ] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. Not ticked yet: The in-game build ran from Hookshot's tree, and the PR says this Longshot branch was not built and run in the game. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] A check under `tests/` that reads changed source updated in this PR, not weakened. - [x] Docs updated.
feat(builder): accept .nx archives (NXFormat) as the game files
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 17s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
012546faae
HumanBean force-pushed builder/nx-format from 012546faae
Some checks failed
PR description / Description follows the template (pull_request_target) Successful in 17s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Conventional Commit title (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been cancelled
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been cancelled
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been cancelled
CI / Workflow lint (actionlint) (pull_request) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Has been cancelled
Third-party parts / As their notes say (pull_request) Has been cancelled
Third-party parts / The same as upstream (pull_request) Has been cancelled
Website / Website on Cloudflare (pull_request) Has been cancelled
to c9d3ac620f
Some checks failed
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 5s
CI / Workflow lint (actionlint) (pull_request) Successful in 8s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 9s
Third-party parts / As their notes say (pull_request) Successful in 15s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 12s
2026-11-15 18:46:26 +00:00
Compare
Owner

Rebased onto main @ 7bacf846: no conflicts. No tests were run here; the test boxes stay yours.

Rebased onto `main` @ 7bacf846: no conflicts. No tests were run here; the test boxes stay yours.
Member

Hi @nussico, I've been helping this land. Here's what I found, and a branch you can take whole or in parts: madebyjordan:builder/nx-format-rebased.

On that branch

  1. f1651fad: your commit, rebased onto main @ 6d72ca93. It now conflicts with main in nx2/make_game.py, but only in the docstring: main gained --romfs-from. I kept both lines and wrote ".nup or .nx" in the new one. No code changes.
  2. 5e5ee079 feat(builder): the game's name and icon from a .nx archive too. #857 (merged after this PR was written) names the exe and the window after the game, from nx2/game_title.py, which read only a .nup. With a .nx it got "not a NUP package", and the game ended up as "Longshot" with no icon. Nx now keeps the catalog and the media region, and reads the application's title and icon (SPEC.md §4 and §5: the icon's SHA-256 is checked; a damaged one is left out). game_title.from_nup tells a .nx by its NXAR magic, as your package_script does. nx2/test_nxar.py covers it.
  3. d2948c31 fix(prompts): the game's own size table when the romfs holds the base game's too (a .nx). See below. It changes nx2/prompt_assets.py and host/prompts.c, with tests/test_prompt_size_table_version.py (new) and a case in tests/test_mods_size_table.py.

The finding: a .nx's update holds the base game's files too

nxconvert pack-nup makes an update a view in which it "shadows individual RomFS/data paths; other base files remain available" (its CLI.md, NUP migration). On my real .nx of the 1.1.1 dump, the newest title has 225 files more than the .nup's update (62 MB). Nothing is missing and no size differs. They're the base game's versions of files the update renamed: *.Product.100.* beside the update's .Product.110/.111.

One of them reaches the game. prompt_assets.size_table makes prompts/rsizetable.zs from the size table whose name sorts first, which is ResourceSizeTable.Product.100 (the base game's). host/prompts.c then serves that file when the game opens its own Product.111. On the real build from the .nx, the served table matched Product.100 in 219,207 of 219,208 entries. Product.111 has 868 entries that Product.100 lacks, and 47 that are larger. The game drops a file larger than its entry, so a .nx build would have run 1.1.1 with 1.0.0's sizes. I didn't run the game with the bad table, so the effect in play is unobserved.

d2948c31 takes the name that sorts last (the newest version, the one the game opens), in both prompt_assets.game_table_name and host/prompts.c game_table, which must agree. With a single table, as from a .nup, nothing changes. After the fix, the same build's table matched Product.111 in 219,967 of 219,968 entries (the other is the font's raised entry).

Two smaller effects of the extra files, not fixed:

  • text_assets.py also rewords the base game's Mals/*.Product.100.sarc.zs. That's extra files in texts/, but the game asks by exact name.
  • shader_census.py walks Shader/ and will see the base game's four .bfsha files. I didn't check what that adds to the shader list.

Tested

Windows 11, RX 6700 XT, with a .nx I made from my own 25.62 GB .nup using nxconvert 1.0.4 pack-nup --platform switch2 (375 s). nxconvert check-nup passed: 372,812 files, 25.58 GB verified.

  • make_game.py --check --nup <file.nx>: "This is the version Longshot supports (build e0f3ccfa)", in 18 s. A cut-short copy: "the .nx file is incomplete ...". A file of zeros: "not a NUP package".
  • A full build from the .nx on this branch (llvm-mingw, shaders left to the first start):
    • read: 186,813 files, 26.34 GB, main made a plain NSO
    • "the game's name: The Legend of Zelda: Ocarina of Time (Longshot), its icon: yes"
    • translate 156 s, compile 27 min, @@done
    • rebuilt with d2948c31 in 92 s
  • nx2/test_nxar.py (with the name/icon checks), tests/test_make_game_package_script.py, tests/test_prompt_size_table_version.py and the nx2/test_nup_* checks pass. Without each fix, its new checks fail.
  • python -I -B tests/run_all.py on 5e5ee079: 235 passed, 69 failed, 418 skipped. That run had no C++ compiler on its PATH. Main @ 6d72ca93 on the same PC: 232 passed, 70 failed. No failure is new.

Not tested:

  • The game itself from the .nx build. I set up a short start, but the folder was removed before it got its turn. It's on my list.
  • Linux: tests/test_mods_size_table.py's folder cases (including the new one) run only there.

One question

nxar.py's refusal of an NCA-holding .nx says to run nxconvert extract <file.nx> <new folder> and pick the folder with romfs and exefs. nxconvert's help describes extract as "every snapshot as a dump: base, updates/, dlc/...". Does it really give romfs/exefs folders for such an archive? I couldn't check without a DNSP. The launcher's wording in MagicBeanDev/LongshotLauncher#159 only suggests nxconvert pack-nup or picking the .nup.

Taking it

The whole branch, with your commit as you wrote it plus the two on top:

git fetch https://git.magicbean.dev/madebyjordan/Longshot.git builder/nx-format-rebased
git checkout builder/nx-format && git reset --hard FETCH_HEAD && git push --force-with-lease

Or only my two commits, on your branch after you rebase it yourself:

git fetch https://git.magicbean.dev/madebyjordan/Longshot.git builder/nx-format-rebased
git cherry-pick 5e5ee079 d2948c31

The launcher side of the error messages is MagicBeanDev/LongshotLauncher#159: a .nx that can't be read was shown as "the check stopped before it could tell anything", because GameCheck didn't know "nxar.py stopped".

Hi @nussico, I've been helping this land. Here's what I found, and a branch you can take whole or in parts: `madebyjordan:builder/nx-format-rebased`. ## On that branch 1. **f1651fad: your commit, rebased onto main @ 6d72ca93.** It now conflicts with main in `nx2/make_game.py`, but only in the docstring: main gained `--romfs-from`. I kept both lines and wrote ".nup or .nx" in the new one. No code changes. 2. **5e5ee079 feat(builder): the game's name and icon from a .nx archive too.** #857 (merged after this PR was written) names the exe and the window after the game, from `nx2/game_title.py`, which read only a `.nup`. With a `.nx` it got "not a NUP package", and the game ended up as "Longshot" with no icon. `Nx` now keeps the catalog and the media region, and reads the application's title and icon (SPEC.md §4 and §5: the icon's SHA-256 is checked; a damaged one is left out). `game_title.from_nup` tells a `.nx` by its `NXAR` magic, as your `package_script` does. `nx2/test_nxar.py` covers it. 3. **d2948c31 fix(prompts): the game's own size table when the romfs holds the base game's too (a .nx).** See below. It changes `nx2/prompt_assets.py` and `host/prompts.c`, with `tests/test_prompt_size_table_version.py` (new) and a case in `tests/test_mods_size_table.py`. ## The finding: a .nx's update holds the base game's files too `nxconvert pack-nup` makes an update a view in which it "shadows individual RomFS/data paths; other base files remain available" (its CLI.md, *NUP migration*). On my real `.nx` of the 1.1.1 dump, the newest title has **225 files more than the `.nup`'s update** (62 MB). Nothing is missing and no size differs. They're the base game's versions of files the update renamed: `*.Product.100.*` beside the update's `.Product.110`/`.111`. One of them reaches the game. `prompt_assets.size_table` makes `prompts/rsizetable.zs` from the size table whose name sorts first, which is `ResourceSizeTable.Product.100` (the base game's). `host/prompts.c` then serves that file when the game opens its own `Product.111`. On the real build from the `.nx`, the served table matched `Product.100` in 219,207 of 219,208 entries. `Product.111` has 868 entries that `Product.100` lacks, and 47 that are larger. The game drops a file larger than its entry, so a `.nx` build would have run 1.1.1 with 1.0.0's sizes. I didn't run the game with the bad table, so the effect in play is unobserved. d2948c31 takes the name that sorts last (the newest version, the one the game opens), in both `prompt_assets.game_table_name` and `host/prompts.c` `game_table`, which must agree. With a single table, as from a `.nup`, nothing changes. After the fix, the same build's table matched `Product.111` in 219,967 of 219,968 entries (the other is the font's raised entry). Two smaller effects of the extra files, not fixed: - `text_assets.py` also rewords the base game's `Mals/*.Product.100.sarc.zs`. That's extra files in `texts/`, but the game asks by exact name. - `shader_census.py` walks `Shader/` and will see the base game's four `.bfsha` files. I didn't check what that adds to the shader list. ## Tested Windows 11, RX 6700 XT, with a `.nx` I made from my own 25.62 GB `.nup` using nxconvert 1.0.4 `pack-nup --platform switch2` (375 s). `nxconvert check-nup` passed: 372,812 files, 25.58 GB verified. - `make_game.py --check --nup <file.nx>`: "This is the version Longshot supports (build e0f3ccfa)", in 18 s. A cut-short copy: "the .nx file is incomplete ...". A file of zeros: "not a NUP package". - **A full build from the `.nx` on this branch** (llvm-mingw, shaders left to the first start): - read: 186,813 files, 26.34 GB, `main` made a plain NSO - "the game's name: The Legend of Zelda: Ocarina of Time (Longshot), its icon: yes" - translate 156 s, compile 27 min, `@@done` - rebuilt with d2948c31 in 92 s - `nx2/test_nxar.py` (with the name/icon checks), `tests/test_make_game_package_script.py`, `tests/test_prompt_size_table_version.py` and the `nx2/test_nup_*` checks pass. Without each fix, its new checks fail. - `python -I -B tests/run_all.py` on 5e5ee079: 235 passed, 69 failed, 418 skipped. That run had no C++ compiler on its PATH. Main @ 6d72ca93 on the same PC: 232 passed, 70 failed. No failure is new. **Not tested:** - **The game itself from the `.nx` build.** I set up a short start, but the folder was removed before it got its turn. It's on my list. - **Linux:** `tests/test_mods_size_table.py`'s folder cases (including the new one) run only there. ## One question `nxar.py`'s refusal of an NCA-holding `.nx` says to run `nxconvert extract <file.nx> <new folder>` and pick the folder with romfs and exefs. nxconvert's help describes `extract` as "every snapshot as a dump: base, updates/<version>, dlc/...". Does it really give romfs/exefs folders for such an archive? I couldn't check without a DNSP. The launcher's wording in MagicBeanDev/LongshotLauncher#159 only suggests `nxconvert pack-nup` or picking the `.nup`. ## Taking it The whole branch, with your commit as you wrote it plus the two on top: ``` git fetch https://git.magicbean.dev/madebyjordan/Longshot.git builder/nx-format-rebased git checkout builder/nx-format && git reset --hard FETCH_HEAD && git push --force-with-lease ``` Or only my two commits, on your branch after you rebase it yourself: ``` git fetch https://git.magicbean.dev/madebyjordan/Longshot.git builder/nx-format-rebased git cherry-pick 5e5ee079 d2948c31 ``` The launcher side of the error messages is MagicBeanDev/LongshotLauncher#159: a `.nx` that can't be read was shown as "the check stopped before it could tell anything", because `GameCheck` didn't know "nxar.py stopped".
Owner

Brought up to the ready-for-review standard (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know).

  • Tested on my own PC: not ticked: The in-game build ran from Hookshot's tree, and the PR says this Longshot branch was not built and run in the game. Run it yourself on your PC (in the game, for a change the game runs) and say where and what you saw in Testing's Tested; or, when the fix's own case can't be run by hand, add a **Not testable by hand:** line saying why and what stands in for it. Then tick it.
  • Nothing gets worse that I know of: ticked: Measurements says there is nothing to measure in the game, and Risks names no speed, latency or memory cost.
Brought up to the [ready-for-review standard](https://git.magicbean.dev/MagicBeanDev/Longshot/src/branch/main/CONTRIBUTING.md#ready-for-review-out-of-wip) (#1454): the checklist's Everyone list has two new boxes, added here from what this PR's description and comments show (please check they match what you know). - *Tested on my own PC*: not ticked: The in-game build ran from Hookshot's tree, and the PR says this Longshot branch was not built and run in the game. Run it yourself on your PC (in the game, for a change the game runs) and say where and what you saw in Testing's *Tested*; or, when the fix's own case can't be run by hand, add a `**Not testable by hand:**` line saying why and what stands in for it. Then tick it. - *Nothing gets worse that I know of*: ticked: Measurements says there is nothing to measure in the game, and Risks names no speed, latency or memory cost.
Some checks failed
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 5s
CI / Workflow lint (actionlint) (pull_request) Successful in 8s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 9s
Third-party parts / As their notes say (pull_request) Successful in 15s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 12s
This pull request has changes conflicting with the target branch.
  • nx2/make_game.py
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u 'builder/nx-format:nussico-builder/nx-format'
git switch 'nussico-builder/nx-format'
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!685
No description provided.