fix(check): a .nx that can't be read is the file's, said in plain words #159
No reviewers
Labels
No labels
area/build
area/install
area/saves
area/tooling
area/ui
area/updates
ci: approved
good first issue
gpu/amd
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
platform/linux
platform/steam-deck
platform/windows
priority
critical
priority
high
priority
low
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/LongshotLauncher!159
Loading…
Reference in a new issue
No description provided.
Delete branch "madebyjordan/LongshotLauncher:fix/nx-check-errors"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When the check of a
.nxfails, the launcher calls it "an error nobody expected" ("The check stopped before it could tell anything about this file: nxar.py stopped ...") instead of saying what is wrong with the file and what to do. The builder reads a.nxwith its own reader,nx2/nxar.py(MagicBeanDev/Longshot#685), and its failures start "nxar.py stopped", whichGameCheckdidn't know. This follows #77, which made the launcher find, browse and drop.nxfiles.What changed
Core/MakeGameRun.cs,GameCheck.FileFailures: "nxar.py stopped", "not a .nx archive" and ".nx file" are the file's, as nup.py's are. An incomplete or damaged.nxnow gets the same words as a.nup("This file is incomplete ...", "This file is damaged ...")..nxthat doesn't start withNXARgoes to nup.py and gets "not a NUP package"..nxholding the game as NCA files (nxconvert packfrom a DNSP or DXCI) is refused by the builder. It now says so, and what to do: make the.nxfrom the.nupwithnxconvert pack-nup, or pick the.nup..nup/.nxwhere it had.nup(as #77 did). The new text is translated into every full catalog, right after the renamed one rather than at the end.files-nx-not-usable, a.nxholding NCA files and a damaged one, each classed byGameCheck.Ofas a real check would be.Screenshots
In the comment below:
files-nx-not-usablewith this change, and the same scene drawn with main'sCore/.Testing
Windows 11, .NET SDK 10.0.404, on main @
676e300.tests/launcher_core/ScreenChecks.cs,GameCheckChecks: four rows with nxar.py's words (incomplete, damaged, NCA files, not a.nx). The incomplete one is copied from a real run of MagicBeanDev/Longshot#685'smake_game.py --checkon a cut-short copy of a.nxmade with nxconvert 1.0.4pack-nup; the others are nxar.py's messages as its source writes them. With main'sCore/the checks fail at the renamed row.python -I tests/test_launcher_core.py: on Windows the run stops beforeScreenCheckson main too (the CRLF fixtures andShellLinkChecks, see #121). SoGameCheckCheckswas also run first in a local copy and passed. The full run is CI's, on Linux.python -I scripts/translations.py: no text of this PR is missing or left over. It still exits 1 for the 30 texts each catalog already lacks on main.dotnet build App -c Release: 0 warnings, 0 errors.tools/screenshotsdraws the new scene..nx, and Linux.Merge order: any time. Until MagicBeanDev/Longshot#685 is in a release, no builder says "nxar.py", and nothing changes for a
.nup.🤖 Generated with Claude Code
From
tools/screenshots(drawn on Windows, so the scene's Linux paths show with backslashes):With this PR:

The same scene drawn with main's

Core/: the file is "Not checked" and the reason is nxar.py's own text.Description: Testing now says which nxar.py message came from a real run (the incomplete one) and which are from its source.