fix(website): the download page's logo and favicon load, it looks like the site, and it links the docs #257

Merged
HumanBean merged 1 commit from HumanBean/Longshot:fix/download-page into main 2026-11-13 18:08:28 +00:00
Owner

Why

https://longshot.magicbean.dev/download/ shows a broken image where its logo should be, and has no favicon: it asks for /logo.webp and /favicon-32.png, which the site never had. It also looked like a different site (a brown theme, no header) and didn't point to the install guide or help.

What changed

  • website: page() in website/worker/index.ts, the shell of every /download page:
    • the logo and favicon come from /branding/longshot.png, the site's own logo;
    • the site's colours (src/styles/theme.css), in its dark and light themes, following the theme picked on the site (Starlight's starlight-theme in localStorage) or else the system's;
    • a header like the site's: the logo linking home, and Get started, Requirements, Help, About;
    • a footer with the bring-your-own-copy note and the release page.
  • website: downloadPage(): a Then list after the buttons linking Requirements, Get started, Antivirus and SmartScreen, and Help; the README link is replaced by those site pages; the channels are cards.

The channel rules, the redirects and every URL under /download are unchanged.

Flags and settings

None.

Measurements

Not a performance change. What counts is whether the page's images load.

main: fbd42024 (the live site, 2026-11-13)
this PR: fix/download-page @ 6749d5d0
Hardware: n/a (a web page)
Scene: https://longshot.magicbean.dev/download/
Method: the image URLs each version's HTML asks for, fetched from the live site with curl
How to reproduce: curl -sI https://longshot.magicbean.dev/logo.webp, and the same for each URL below

main @ fbd42024 this PR @ 6749d5d0
logo (/logo.webp → /branding/longshot.png) 404 200
favicon (/favicon-32.png → /branding/longshot.png) 404 200
links to the site's docs 0 (one to the README on Forgejo) 8 (header 4, Then 4)

Testing

Tested: the Worker rendered /download offline (Node, stubbed caches with an rc and a nightly), screenshotted in headless Chromium at 1200 px dark and at 390 px light: logo, header, buttons, Then list and channel cards render; no horizontal scroll at phone width. The live page's 404s for /logo.webp and /favicon-32.png checked with curl; /branding/longshot.png answers 200.

Not tested: the deployed Worker (the preview upload from website.yml will show it); npm run check in website/ and python -I -B tests/run_all.py not run on this PC.

Needs other testers: None.

Screenshots

main @ fbd42024, the live page (dark, 1200 px): the logo is a broken image

main

this PR @ 6749d5d0, dark, 1200 px

this PR, dark

this PR @ 6749d5d0, light, 390 px (a phone)

this PR, phone, light

Risk and rollback

Only the HTML of the /download pages changes; the download links are untouched. Reverting the commit is enough.

Issues

None.

Checklist

For everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description).
  • Rebased on current main.
  • python -I -B tests/run_all.py run and passing (any failure that also fails on main is named above). Not run on this PC: needs someone to run it (and npm run check in website/).
  • Tested in the game, or what wasn't is named under Testing.
  • Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests).
  • Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported. (A website change: nothing to measure, rendered and screenshotted instead.)
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

If applicable

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Screenshots for a change that shows on screen.

🤖 Generated with Claude Code

## Why https://longshot.magicbean.dev/download/ shows a broken image where its logo should be, and has no favicon: it asks for `/logo.webp` and `/favicon-32.png`, which the site never had. It also looked like a different site (a brown theme, no header) and didn't point to the install guide or help. ## What changed - website: `page()` in `website/worker/index.ts`, the shell of every `/download` page: - the logo and favicon come from `/branding/longshot.png`, the site's own logo; - the site's colours (`src/styles/theme.css`), in its dark and light themes, following the theme picked on the site (Starlight's `starlight-theme` in localStorage) or else the system's; - a header like the site's: the logo linking home, and Get started, Requirements, Help, About; - a footer with the bring-your-own-copy note and the release page. - website: `downloadPage()`: a **Then** list after the buttons linking Requirements, Get started, Antivirus and SmartScreen, and Help; the README link is replaced by those site pages; the channels are cards. The channel rules, the redirects and every URL under `/download` are unchanged. ## Flags and settings None. ## Measurements Not a performance change. What counts is whether the page's images load. main: fbd42024 (the live site, 2026-11-13) this PR: fix/download-page @ 6749d5d0 Hardware: n/a (a web page) Scene: https://longshot.magicbean.dev/download/ Method: the image URLs each version's HTML asks for, fetched from the live site with curl How to reproduce: `curl -sI https://longshot.magicbean.dev/logo.webp`, and the same for each URL below | | main @ fbd42024 | this PR @ 6749d5d0 | |---|---|---| | logo (`/logo.webp` → `/branding/longshot.png`) | 404 | 200 | | favicon (`/favicon-32.png` → `/branding/longshot.png`) | 404 | 200 | | links to the site's docs | 0 (one to the README on Forgejo) | 8 (header 4, Then 4) | ## Testing **Tested:** the Worker rendered `/download` offline (Node, stubbed `caches` with an rc and a nightly), screenshotted in headless Chromium at 1200 px dark and at 390 px light: logo, header, buttons, Then list and channel cards render; no horizontal scroll at phone width. The live page's 404s for `/logo.webp` and `/favicon-32.png` checked with curl; `/branding/longshot.png` answers 200. **Not tested:** the deployed Worker (the preview upload from `website.yml` will show it); `npm run check` in `website/` and `python -I -B tests/run_all.py` not run on this PC. **Needs other testers:** None. ## Screenshots main @ fbd42024, the live page (dark, 1200 px): the logo is a broken image ![main](https://git.magicbean.dev/attachments/10219704-f0c4-467d-a6a7-1cac4710648f) this PR @ 6749d5d0, dark, 1200 px ![this PR, dark](https://git.magicbean.dev/attachments/31691b4a-e57a-4649-8ce2-47d234e7a93b) this PR @ 6749d5d0, light, 390 px (a phone) ![this PR, phone, light](https://git.magicbean.dev/attachments/99daaac3-c891-469b-beaa-7ad74ba5ab33) ## Risk and rollback Only the HTML of the `/download` pages changes; the download links are untouched. Reverting the commit is enough. ## Issues None. ## Checklist ### For everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`). - [x] Rebased on current `main`. - [ ] `python -I -B tests/run_all.py` run and passing (any failure that also fails on `main` is named above). Not run on this PC: needs someone to run it (and `npm run check` in `website/`). - [x] Tested in the game, or what wasn't is named under Testing. - [x] Testing filled in: what was tested, what wasn't, and what needs other testers (with test requests). - [x] Measured: main and this PR at named commits, on the same PC, scene and settings, at least 2 interleaved runs each, the median reported. (A website change: nothing to measure, rendered and screenshotted instead.) - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### If applicable - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Screenshots for a change that shows on screen. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(website): the download page's logo and favicon load, it looks like the site, and it links the docs
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 3s
CI / Workflow lint (actionlint) (pull_request) Successful in 5s
Third-party parts / As their notes say (pull_request) Successful in 5s
PR description / Description follows the template (pull_request_target) Failing after 3s
Website / Website on Cloudflare (pull_request_target) Has been skipped
6749d5d0d3
The page asked for /logo.webp and /favicon-32.png, which the site never had: both 404ed.
It now uses /branding/longshot.png, the site's colours and light/dark themes (and the theme
picked on the site), the site's header links, and a 'Then' list linking Requirements, Get
started, Antivirus and Help.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
HumanBean changed title from WIP: fix(website): the download page's logo and favicon load, it looks like the site, and it links the docs to fix(website): the download page's logo and favicon load, it looks like the site, and it links the docs 2026-11-13 18:08:17 +00:00
HumanBean deleted branch fix/download-page 2026-11-13 18:08:28 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!257
No description provided.