fix(host): a start where Vulkan lists no GPU ends at once, and the window after it says why #2102

Merged
HumanBean merged 4 commits from llun/Longshot:fix/no-gpu-start into main 2026-11-21 19:13:39 +00:00
Member

Summary

A Linux player got a black window with the game's sound playing and no picture. Their log: vk: GPU device: the saved card (10de:2d05:0) is not here, no vk: device N: line at all, then vk: no Vulkan 1.3 GPU, pick_device failed, display: the renderer did not start: the window stays black, and the game went on (vi: ... frames presented, 240 fps, nothing drawn). The Vulkan loader listed no GPU: the player was on CachyOS's rt-bore kernel, a real-time (PREEMPT_RT) one, with NVIDIA's driver not loaded. A standard kernel fixed it.

Two things made that hard to find, and this changes both:

  • The game ends at once when the renderer doesn't start. On main it plays on behind a black window, with its sound, until the player closes it, and only then does the window after it (#593) say what went wrong. Now renderer_main (Linux) and display_main (Windows) log the line the crash window reads, flush the log, close the run's marker as a clean end and exit with code 1: the start-failure window comes up right away. On Linux, a close already claimed during startup takes precedence over reporting a startup failure.
  • That window names the cause when Vulkan lists no GPU at all. pick_device now logs vk: no Vulkan device (cause <key>): ... when the loader lists nothing. On Linux it asks the PC (gpu/vk/compat/longshot_no_gpu.h, reading /sys and /proc): an NVIDIA card with no other graphics card and complete PCI information: NVIDIA's module not loaded on a real-time kernel (nvidia-rt), not loaded on another kernel (nvidia-unloaded), or loaded with no Vulkan device (nvidia-vulkan). Mixed cards, incomplete PCI information and other cases stay not known (unknown, also all of Windows). The graphics cards' PCI ids go in the line. The crash window reads the line back and says, for the real-time case, that a driver compatibility or loading issue is possible and suggests checking the driver and module logs and trying a supported driver or a standard kernel. A start where devices are listed but none has Vulkan 1.3 keeps its message.

The player docs' Linux start section (docs/user/common-issues.md) gets the real-time kernel case.

On main: start the game with Vulkan showing no device (on Windows VK_LOADER_VENDOR_ID_FILTER=0x1234, a vendor no GPU has): a black window, the game running behind it, and "Update your graphics driver" once it is closed.

Read first: host/posix/display_sdl.c renderer_main, host/display.c display_main, gpu/vk/compat/longshot_no_gpu.h, host/hos_crash_dialog.h (hos_crash_log_line, hos_crash_cause, hos_crash_cause_text), gpu/vk/vk_main.cpp pick_device.

See #821, #1682.

Testing

Tested: Windows 11, RTX 5080, NVIDIA 621.24; this PR on main @ 049a4a45 (with #2098), built with dev.py pack and run through the job queue, windowed. The before side is the shared base eee3e1d5 (dev.py rt --empty): display.c, display_sdl.c, pick_device and the crash window's causes and texts are the same there as on 049a4a45.

  • Vulkan showing no device (VK_LOADER_VENDOR_ID_FILTER=0x1234, a vendor no GPU has): before, a black window, vi: 5616 frames presented after 30 s, the game running until closed, then the window with "Vulkan didn't start on your graphics card. Update your graphics driver". Here: vk: no Vulkan device (cause unknown): no Vulkan driver lists a GPU, display: the renderer did not start: the game ends, and the window after it says why, exit code 1 in under a second, and the window at once: "Vulkan found no graphics card: no graphics driver with Vulkan is installed or loaded ..." (pictures in a comment).
  • A normal start here: the RTX 5080 listed and chosen, the game drawn (Hyrule Field from the save), 75 s, then a close request: stop: close work done, exit code 0, no window after it.
  • The head is that commit rebased onto main @ d76d202f (#1989, which touches none of this PR's files): the test passes again there.
  • tests/test_no_gpu_start.py (new) fails on main (the renderer's failure leaves the game running) and passes here, with clang++ 23.1.5 (llvm-mingw) on Windows and gcc 13 on Ubuntu 24.04 (WSL), where the probe reads PCI folders named as Linux names them (0000:01:00.0). With the crash window's cause mapping broken back, it fails again.
  • Linux compile: host/posix/display_sdl.c and host/hos_crash_dialog.c with gcc 13 -fsyntax-only -Wall -Wextra on Ubuntu 24.04 (WSL): no error or warning in them (a broken copy of display_sdl.c does fail, so the check reaches the code). Not compiled on Linux: gpu/vk/vk_main.cpp (no Vulkan headers there); its Linux branch is the one call longshot_no_gpu_probe("", &why), whose header the test compiles on Linux.
  • mise run test's suite (tests/run_all.py) on Windows, on this branch before its rebase onto 049a4a45 (#2098, #1767 and #1892 came in; the new test passes again after it): 712 passed, 85 failed, 135 skipped; all 85 fail on main too (run again there, 0 passed), among them the 25 that read this PR's files (listed under Risks); test_crash_dialog.py's log-stage section passes here and on main, its verdict section fails the same way on both (Windows: a crash record case before the Vulkan ones).

Still to test:

  • Linux, NVIDIA: start with VK_LOADER_VENDOR_ID_FILTER=0x1234, expecting vk: no Vulkan device (cause nvidia-vulkan): NVIDIA's module is loaded, but no Vulkan driver lists a GPU; graphics cards 10de:xxxx on a system with only an NVIDIA graphics card and complete PCI information, the game ending at once, and the window naming it (@Beanstalk Linux NVIDIA: start with VK_LOADER_VENDOR_ID_FILTER=0x1234 in longshot_env.txt; the game should end at once with "NVIDIA's kernel module is loaded, but Vulkan found no graphics card")
  • Linux, NVIDIA on a real-time kernel (linux-cachyos-rt-bore): the player's own case, expecting cause nvidia-rt and guidance to check the driver and kernel module logs and try a supported driver or a standard kernel (by hand: the player who reported it)
  • Linux, Steam Deck or AMD: a normal start still goes on (@Beanstalk Steam Deck: a normal start to the title screen)

Measurements

Verdict: fixed: a start with no GPU listed ends at once and says why, instead of a black window with sound; the test fails on main and passes here.

Setup: Windows 11, RTX 5080, NVIDIA 621.24; windowed start with VK_LOADER_VENDOR_ID_FILTER=0x1234; the game's log and exit code, and the window after it. Baseline for the game runs: the shared base eee3e1d5, whose display code, pick_device and crash window causes and texts are those of main @ 049a4a45.

Before: main @ 049a4a45 (game runs: base eee3e1d5) After: this PR @ 57eb44ef (head a4d79341: the same, rebased)
tests/test_no_gpu_start.py fails: the renderer did not start and the game went on passes (3 parts)
no GPU listed: the game runs behind a black window until closed (5616 frames presented in 30 s) ends at once, exit code 1
the window after it "Vulkan didn't start ... Update your graphics driver" "Vulkan found no graphics card ..." (on Linux, the cause)
a normal start the GPU listed, frames presented the same

Measured with this PR on main @ 049a4a45. The head is rebased onto main @ d76d202f, whose one new commit (#1989, FSR 4 model selection) touches none of this PR's files: the runs still hold.

Before (base eee3e1d5):
[hos host] vk: no Vulkan 1.3 GPU
[hos host] vk: pick_device failed
[hos host] rx: mkwvk_init returned NULL: nothing is drawn
[hos host] display: no renderer: the window stays black
[hos Presentation Thread] vi: 5616 frames presented (240.0 fps over the last 5.0 s, interval 1)
[hos host] display: window closed, exiting
After (this PR @ 57eb44ef):
[hos host] vk: no Vulkan device (cause unknown): no Vulkan driver lists a GPU
[hos host] vk: no Vulkan 1.3 GPU
[hos host] vk: pick_device failed
[hos host] rx: mkwvk_init returned NULL: nothing is drawn
[hos host] display: the renderer did not start: the game ends, and the window after it says why
(exit code 1)

Risks

  • A start whose renderer fails now ends instead of leaving a black window with sound. Nothing is drawn either way; the window after it says why at once. Under gamescope (no crash window) the game ends and Steam's game mode comes back. #1682 (HDR under gamescope, the swapchain refused) ends too now, instead of freezing; its own fix is apart from this. No switch: a revert is enough.
  • The Linux probe reads a few small files under /sys and /proc, only when no device is listed. It names an NVIDIA cause only when an NVIDIA card is present, no other graphics card is found and PCI information is complete; anything else stays "not known", with the generic "found no graphics card".
  • The crash window's causes gain four values after the others, so the existing numbers are unchanged.
  • Checks that fail on this Windows PC, on main too: test_appimage_player_build, test_auto_handheld, test_build_long_paths, test_compile_retry_jobs, test_compile_stops_on_exception, test_crash_dialog, test_crash_record, test_dev_build, test_dev_packs, test_display_startup_failure, test_failed_compile_keeps_objects, test_fpx_sticky, test_game_menu_mouse_buttons, test_lift_cache, test_linux_preflight, test_make_game_ngx, test_menu_text_field, test_mise_build, test_mods_list, test_perf_report, test_prepare_cache_save, test_present_ahead, test_renderer_new_handler, test_renhdrum, test_vfpx_elem.

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit.
  • Tested on my own PC, in the game for a change the game runs, as Testing says.
  • mise run test passes (any failure that also fails on main is named).
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • A fix: a game-free test that fails on main and passes on the current head.
  • A check under tests/ that reads changed source is updated, not weakened. (None needed a change: those that read these files pass here as on main, and those that fail on this Windows PC fail on main too, test_crash_dialog.py's log-stage section passing on both.)
  • Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths.
  • Screenshots of the same spot on main and here, for a change that shows on screen.
  • Docs updated.
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

Ready to merge

  • Everything in Still to test has run, its results in Tested.
  • Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers").
  • Approved in review, every comment answered.
  • CI passes on the head; on current main, measured again or a comment says why the numbers still hold.

🤖 Generated with Claude Code

## Summary A Linux player got a black window with the game's sound playing and no picture. Their log: `vk: GPU device: the saved card (10de:2d05:0) is not here`, no `vk: device N:` line at all, then `vk: no Vulkan 1.3 GPU`, `pick_device failed`, `display: the renderer did not start: the window stays black`, and the game went on (`vi: ... frames presented`, 240 fps, nothing drawn). The Vulkan loader listed no GPU: the player was on CachyOS's rt-bore kernel, a real-time (PREEMPT_RT) one, with NVIDIA's driver not loaded. A standard kernel fixed it. Two things made that hard to find, and this changes both: - **The game ends at once when the renderer doesn't start.** On `main` it plays on behind a black window, with its sound, until the player closes it, and only then does the window after it (#593) say what went wrong. Now `renderer_main` (Linux) and `display_main` (Windows) log the line the crash window reads, flush the log, close the run's marker as a clean end and exit with code 1: the start-failure window comes up right away. On Linux, a close already claimed during startup takes precedence over reporting a startup failure. - **That window names the cause when Vulkan lists no GPU at all.** `pick_device` now logs `vk: no Vulkan device (cause <key>): ...` when the loader lists nothing. On Linux it asks the PC (`gpu/vk/compat/longshot_no_gpu.h`, reading `/sys` and `/proc`): an NVIDIA card with no other graphics card and complete PCI information: NVIDIA's module not loaded on a real-time kernel (`nvidia-rt`), not loaded on another kernel (`nvidia-unloaded`), or loaded with no Vulkan device (`nvidia-vulkan`). Mixed cards, incomplete PCI information and other cases stay not known (`unknown`, also all of Windows). The graphics cards' PCI ids go in the line. The crash window reads the line back and says, for the real-time case, that a driver compatibility or loading issue is possible and suggests checking the driver and module logs and trying a supported driver or a standard kernel. A start where devices are listed but none has Vulkan 1.3 keeps its message. The player docs' Linux start section (`docs/user/common-issues.md`) gets the real-time kernel case. **On `main`:** start the game with Vulkan showing no device (on Windows `VK_LOADER_VENDOR_ID_FILTER=0x1234`, a vendor no GPU has): a black window, the game running behind it, and "Update your graphics driver" once it is closed. Read first: `host/posix/display_sdl.c` `renderer_main`, `host/display.c` `display_main`, `gpu/vk/compat/longshot_no_gpu.h`, `host/hos_crash_dialog.h` (`hos_crash_log_line`, `hos_crash_cause`, `hos_crash_cause_text`), `gpu/vk/vk_main.cpp` `pick_device`. See #821, #1682. ## Testing **Tested:** Windows 11, RTX 5080, NVIDIA 621.24; this PR on `main` @ 049a4a45 (with #2098), built with `dev.py pack` and run through the job queue, windowed. The before side is the shared base eee3e1d5 (`dev.py rt --empty`): `display.c`, `display_sdl.c`, `pick_device` and the crash window's causes and texts are the same there as on 049a4a45. - Vulkan showing no device (`VK_LOADER_VENDOR_ID_FILTER=0x1234`, a vendor no GPU has): before, a black window, `vi: 5616 frames presented` after 30 s, the game running until closed, then the window with "Vulkan didn't start on your graphics card. Update your graphics driver". Here: `vk: no Vulkan device (cause unknown): no Vulkan driver lists a GPU`, `display: the renderer did not start: the game ends, and the window after it says why`, exit code 1 in under a second, and the window at once: "Vulkan found no graphics card: no graphics driver with Vulkan is installed or loaded ..." (pictures in a comment). - A normal start here: the RTX 5080 listed and chosen, the game drawn (Hyrule Field from the save), 75 s, then a close request: `stop: close work done`, exit code 0, no window after it. - The head is that commit rebased onto `main` @ d76d202f (#1989, which touches none of this PR's files): the test passes again there. - `tests/test_no_gpu_start.py` (new) fails on `main` (the renderer's failure leaves the game running) and passes here, with clang++ 23.1.5 (llvm-mingw) on Windows and gcc 13 on Ubuntu 24.04 (WSL), where the probe reads PCI folders named as Linux names them (`0000:01:00.0`). With the crash window's cause mapping broken back, it fails again. - Linux compile: `host/posix/display_sdl.c` and `host/hos_crash_dialog.c` with gcc 13 `-fsyntax-only -Wall -Wextra` on Ubuntu 24.04 (WSL): no error or warning in them (a broken copy of `display_sdl.c` does fail, so the check reaches the code). Not compiled on Linux: `gpu/vk/vk_main.cpp` (no Vulkan headers there); its Linux branch is the one call `longshot_no_gpu_probe("", &why)`, whose header the test compiles on Linux. - `mise run test`'s suite (`tests/run_all.py`) on Windows, on this branch before its rebase onto 049a4a45 (#2098, #1767 and #1892 came in; the new test passes again after it): 712 passed, 85 failed, 135 skipped; all 85 fail on `main` too (run again there, 0 passed), among them the 25 that read this PR's files (listed under Risks); `test_crash_dialog.py`'s log-stage section passes here and on `main`, its verdict section fails the same way on both (Windows: a crash record case before the Vulkan ones). **Still to test:** - Linux, NVIDIA: start with `VK_LOADER_VENDOR_ID_FILTER=0x1234`, expecting `vk: no Vulkan device (cause nvidia-vulkan): NVIDIA's module is loaded, but no Vulkan driver lists a GPU; graphics cards 10de:xxxx` on a system with only an NVIDIA graphics card and complete PCI information, the game ending at once, and the window naming it (@Beanstalk Linux NVIDIA: start with `VK_LOADER_VENDOR_ID_FILTER=0x1234` in longshot_env.txt; the game should end at once with "NVIDIA's kernel module is loaded, but Vulkan found no graphics card") - Linux, NVIDIA on a real-time kernel (`linux-cachyos-rt-bore`): the player's own case, expecting `cause nvidia-rt` and guidance to check the driver and kernel module logs and try a supported driver or a standard kernel (by hand: the player who reported it) - Linux, Steam Deck or AMD: a normal start still goes on (@Beanstalk Steam Deck: a normal start to the title screen) ## Measurements **Verdict:** fixed: a start with no GPU listed ends at once and says why, instead of a black window with sound; the test fails on `main` and passes here. Setup: Windows 11, RTX 5080, NVIDIA 621.24; windowed start with `VK_LOADER_VENDOR_ID_FILTER=0x1234`; the game's log and exit code, and the window after it. Baseline for the game runs: the shared base eee3e1d5, whose display code, `pick_device` and crash window causes and texts are those of `main` @ 049a4a45. | | Before: main @ 049a4a45 (game runs: base eee3e1d5) | After: this PR @ 57eb44ef (head a4d79341: the same, rebased) | |---|---|---| | `tests/test_no_gpu_start.py` | fails: the renderer did not start and the game went on | passes (3 parts) | | no GPU listed: the game | runs behind a black window until closed (5616 frames presented in 30 s) | ends at once, exit code 1 | | the window after it | "Vulkan didn't start ... Update your graphics driver" | "Vulkan found no graphics card ..." (on Linux, the cause) | | a normal start | the GPU listed, frames presented | the same | Measured with this PR on `main` @ 049a4a45. The head is rebased onto `main` @ d76d202f, whose one new commit (#1989, FSR 4 model selection) touches none of this PR's files: the runs still hold. ``` Before (base eee3e1d5): [hos host] vk: no Vulkan 1.3 GPU [hos host] vk: pick_device failed [hos host] rx: mkwvk_init returned NULL: nothing is drawn [hos host] display: no renderer: the window stays black [hos Presentation Thread] vi: 5616 frames presented (240.0 fps over the last 5.0 s, interval 1) [hos host] display: window closed, exiting After (this PR @ 57eb44ef): [hos host] vk: no Vulkan device (cause unknown): no Vulkan driver lists a GPU [hos host] vk: no Vulkan 1.3 GPU [hos host] vk: pick_device failed [hos host] rx: mkwvk_init returned NULL: nothing is drawn [hos host] display: the renderer did not start: the game ends, and the window after it says why (exit code 1) ``` ## Risks - **A start whose renderer fails now ends** instead of leaving a black window with sound. Nothing is drawn either way; the window after it says why at once. Under gamescope (no crash window) the game ends and Steam's game mode comes back. #1682 (HDR under gamescope, the swapchain refused) ends too now, instead of freezing; its own fix is apart from this. No switch: a revert is enough. - **The Linux probe** reads a few small files under `/sys` and `/proc`, only when no device is listed. It names an NVIDIA cause only when an NVIDIA card is present, no other graphics card is found and PCI information is complete; anything else stays "not known", with the generic "found no graphics card". - The crash window's causes gain four values after the others, so the existing numbers are unchanged. - Checks that fail on this Windows PC, on `main` too: `test_appimage_player_build`, `test_auto_handheld`, `test_build_long_paths`, `test_compile_retry_jobs`, `test_compile_stops_on_exception`, `test_crash_dialog`, `test_crash_record`, `test_dev_build`, `test_dev_packs`, `test_display_startup_failure`, `test_failed_compile_keeps_objects`, `test_fpx_sticky`, `test_game_menu_mouse_buttons`, `test_lift_cache`, `test_linux_preflight`, `test_make_game_ngx`, `test_menu_text_field`, `test_mise_build`, `test_mods_list`, `test_perf_report`, `test_prepare_cache_save`, `test_present_ahead`, `test_renderer_new_handler`, `test_renhdrum`, `test_vfpx_elem`. ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. - [x] Tested on my own PC, in the game for a change the game runs, as Testing says. - [x] `mise run test` passes (any failure that also fails on `main` is named). - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [ ] A fix: a game-free test that fails on `main` and passes on the current head. - [x] A check under `tests/` that reads changed source is updated, not weakened. (None needed a change: those that read these files pass here as on `main`, and those that fail on this Windows PC fail on `main` too, `test_crash_dialog.py`'s log-stage section passing on both.) - [x] Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. - [x] Screenshots of the same spot on `main` and here, for a change that shows on screen. - [x] Docs updated. - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. ### Ready to merge - [ ] Everything in Still to test has run, its results in Tested. - [ ] Tier 1 hardware it can affect is tested (docs/dev/standards.md, "Hardware tiers"). - [ ] Approved in review, every comment answered. - [ ] CI passes on the head; on current `main`, measured again or a comment says why the numbers still hold. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Fails on main: the renderer's failure leaves the game running behind a black window, with
its sound, until the player closes it; and nothing asks the PC why no GPU was listed.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
The renderer's failure ends the game (Linux renderer_main, Windows display_main) instead of
leaving it running behind a black window with its sound. When Vulkan lists no device at all,
pick_device logs why where Linux says (gpu/vk/compat/longshot_no_gpu.h): an NVIDIA card with
NVIDIA's driver not loaded on a real-time kernel (PREEMPT_RT), not loaded on another kernel,
or loaded with no Vulkan device. The crash window reads that line and names the cause.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
docs(user): NVIDIA on a real-time Linux kernel: no graphics card for Vulkan, a standard kernel fixes it
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 24s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 31s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 34s
CI / Workflow lint (actionlint) (pull_request) Successful in 39s
Third-party parts / As their notes say (pull_request) Successful in 41s
CI / Website build and checks (pull_request) Has been cancelled
57eb44ef41
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Member

Tested in game: Windows 11, RTX 5080, NVIDIA 621.24, this PR on main 049a4a45 (dev.py pack, job queue, windowed). With Vulkan showing no device (VK_LOADER_VENDOR_ID_FILTER=0x1234): 'vk: no Vulkan device (cause unknown)', 'display: the renderer did not start: the game ends ...', exit code 1 in under a second, and the start-failure window at once with 'Vulkan found no graphics card'. Before (base eee3e1d5): a black window with the game running until closed. A normal start: the RTX 5080 chosen, the game drawn for 75 s, closed with exit code 0 and no window after it.

Tested in game: Windows 11, RTX 5080, NVIDIA 621.24, this PR on main 049a4a45 (dev.py pack, job queue, windowed). With Vulkan showing no device (VK_LOADER_VENDOR_ID_FILTER=0x1234): 'vk: no Vulkan device (cause unknown)', 'display: the renderer did not start: the game ends ...', exit code 1 in under a second, and the start-failure window at once with 'Vulkan found no graphics card'. Before (base eee3e1d5): a black window with the game running until closed. A normal start: the RTX 5080 chosen, the game drawn for 75 s, closed with exit code 0 and no window after it.
Author
Member

Pictures: Windows 11, RTX 5080, Vulkan showing no device (VK_LOADER_VENDOR_ID_FILTER=0x1234).

Before (base eee3e1d5): 15 s in, the game running behind a black window, and the window after it once it was closed:

a black window, the game running behind it
Vulkan didn't start ... Update your graphics driver

After (this PR @ 57eb44ef): the game ended in under a second (exit code 1) and this came up at once:

Vulkan found no graphics card

Pictures: Windows 11, RTX 5080, Vulkan showing no device (`VK_LOADER_VENDOR_ID_FILTER=0x1234`). **Before** (base eee3e1d5): 15 s in, the game running behind a black window, and the window after it once it was closed: ![a black window, the game running behind it](https://git.magicbean.dev/attachments/f0433130-a9d8-433c-81cb-0203d8abbfb4) ![Vulkan didn't start ... Update your graphics driver](https://git.magicbean.dev/attachments/765305c5-3ad8-48ae-b3f9-37cb6b06c3de) **After** (this PR @ 57eb44ef): the game ended in under a second (exit code 1) and this came up at once: ![Vulkan found no graphics card](https://git.magicbean.dev/attachments/c3e39f2d-7f88-44f9-892c-a3f43fca1fe6)
llun force-pushed fix/no-gpu-start from 57eb44ef41
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 24s
Website / Website on Cloudflare (pull_request_target) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 31s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 34s
CI / Workflow lint (actionlint) (pull_request) Successful in 39s
Third-party parts / As their notes say (pull_request) Successful in 41s
CI / Website build and checks (pull_request) Has been cancelled
to a4d79341bd
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 23s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 37s
CI / Workflow lint (actionlint) (pull_request) Successful in 40s
Third-party parts / As their notes say (pull_request) Successful in 44s
PR description / Description follows the template (pull_request_target) Successful in 19s
CI / Website build and checks (pull_request) Has been cancelled
2026-11-21 18:54:09 +00:00
Compare
Author
Member

Rebased onto main @ d76d202f (#1989, which touches none of this PR's files): head a4d79341, tests/test_no_gpu_start.py passes again. Linux: the test passes with gcc 13 on Ubuntu 24.04 (WSL), and host/posix/display_sdl.c and host/hos_crash_dialog.c compile there with -Wall -Wextra and no error or warning; the Host code box is ticked.

Rebased onto main @ d76d202f (#1989, which touches none of this PR's files): head a4d79341, tests/test_no_gpu_start.py passes again. Linux: the test passes with gcc 13 on Ubuntu 24.04 (WSL), and host/posix/display_sdl.c and host/hos_crash_dialog.c compile there with -Wall -Wextra and no error or warning; the Host code box is ticked.
Author
Member

Description: the box for checks that read changed source (none needed a change), and why the runs on 049a4a45 hold on d76d202f.

Description: the box for checks that read changed source (none needed a change), and why the runs on 049a4a45 hold on d76d202f.
llun changed title from WIP: fix(host): a start where Vulkan lists no GPU ends at once, and the window after it says why to fix(host): a start where Vulkan lists no GPU ends at once, and the window after it says why 2026-11-21 18:54:49 +00:00
Author
Member

CI: Guide screenshots / Guide images and local UI source review fails on main too (scripts/check_guide_screenshots.py --review-sources on main d76d202f: 19 issues, settings-graphics.png's sources changed since its reviewed revision; #2095 recaptures it). This PR adds none: its run lists a subset of main's, no file of this PR among them.

CI: Guide screenshots / Guide images and local UI source review fails on main too (`scripts/check_guide_screenshots.py --review-sources` on main d76d202f: 19 issues, settings-graphics.png's sources changed since its reviewed revision; #2095 recaptures it). This PR adds none: its run lists a subset of main's, no file of this PR among them.
Owner
@review
BeanBot left a comment

Recommendation: Request changes. The Windows no-device run shows that the game now exits promptly, but a Linux close during renderer startup can be mistaken for a failure and interrupt cleanup. The Linux diagnosis also states causes more confidently than the evidence supports, and the test does not exercise the renderer’s new diagnostic call.

The change ends a visible game whose renderer cannot start and adds a more specific no-device message. It improves the demonstrated Windows case, but needs a safe close path and more reliable Linux diagnosis.

@fix will do (7)

  1. L1 host/posix/display_sdl.c:215: A player can close the window while the renderer starts: rx_close_asked sets the renderer’s closing flag and performs cache and worker cleanup, while start can return 0 because that flag is set. (more on the line)
  2. L2 gpu/vk/compat/longshot_no_gpu.h:88: The probe treats any NVIDIA PCI card plus an absent nvidia module as proof that NVIDIA’s driver caused the failure. (more on the line)
  3. L3 host/hos_crash_dialog.h:500: The message says NVIDIA’s driver cannot run on any PREEMPT_RT kernel, but that conclusion does not follow from an unloaded module and NVIDIA’s open kernel modules support real-time kernels in supported configurations. (more on the line)
  4. L4 tests/test_no_gpu_start.py:225: The test constructs the diagnostic line by calling the probe directly; it never exercises pick_device. (more on the line)
  5. L5 (minor) tests/test_no_gpu_start.py:249: This C test selects CXX and forces it into C mode, so a configured CC is ignored both directly and through run_all. (more on the line)
  6. L6 (minor) tests/test_no_gpu_start.py:217: On Windows the synthetic probe reads the temporary directory through narrow fopen and stat. (more on the line)
  7. L8: The check Guide screenshots / Guide images and local UI source review (pull_request) fails on this head and passes on the base branch: Failing after 37s.

Before merging, for the author (1) (a run, a measurement or a decision; it doesn't hold the recommendation)

  • L7 (minor) gpu/vk/compat/longshot_no_gpu.h:64: The reported Linux NVIDIA real-time-kernel failure and the normal Steam Deck or AMD startup have not been exercised in game. (more on the line)

Checks: Still running: CI / Website build and checks (pull_request).

More: does it help, other systems, switches, what was read

Does it help: Yes for the tested Windows visible-window case: the author reports that the base continued behind a black window for 30 seconds, while this branch exited with code 1 in under a second and showed the failure window. The reported Linux NVIDIA real-time-kernel case has not yet been run.

Other systems: Linux NVIDIA failure and normal Steam Deck or AMD startup remain untested in game. Headless startup uses a separate path that still ignores renderer failure. Closing a Linux window while startup is in progress can race the new exit with renderer cleanup.

Switches: No runtime switches added, changed or removed. LONGSHOT_NO_GPU_KEYS_ONLY is a compile-time header selector, default undefined.

Reviewed: a4d79341bd against d76d202f51: Read the repository rules, contribution standards, PR template, commits, diff, new header and test, and the affected startup, crash-dialog, renderer and shutdown paths. Skimmed the remaining portions of the large changed code files and existing test runner; did not inspect screenshots or generated files. The optional docs/review-checklist.md and sibling Tooling checkout were absent.; nothing run (a code review).

Checked and fine:

  • The commits include AI-assistance trailers.
  • No game-derived files, generated shader files, renderer API changes or third-party changes appear in the diff.
  • The Windows no-device and normal-start runs are reported with their hardware and observed outcomes.
  • The crash-dialog cause values are appended, preserving the existing numeric values.

Testing: Read-only review; no project code, tests or builds were run. The supplied CI result has a head-only failure that the bot will report separately, and the website check is still running.

Overlaps and merge order: No overlapping pull request established from the supplied material.


Automated code review by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** The Windows no-device run shows that the game now exits promptly, but a Linux close during renderer startup can be mistaken for a failure and interrupt cleanup. The Linux diagnosis also states causes more confidently than the evidence supports, and the test does not exercise the renderer’s new diagnostic call. The change ends a visible game whose renderer cannot start and adds a more specific no-device message. It improves the demonstrated Windows case, but needs a safe close path and more reliable Linux diagnosis. **`@fix` will do (7)** 1. **L1** `host/posix/display_sdl.c:215`: A player can close the window while the renderer starts: rx_close_asked sets the renderer’s closing flag and performs cache and worker cleanup, while start can return 0 because that flag is set. (more on the line) 2. **L2** `gpu/vk/compat/longshot_no_gpu.h:88`: The probe treats any NVIDIA PCI card plus an absent nvidia module as proof that NVIDIA’s driver caused the failure. (more on the line) 3. **L3** `host/hos_crash_dialog.h:500`: The message says NVIDIA’s driver cannot run on any PREEMPT_RT kernel, but that conclusion does not follow from an unloaded module and NVIDIA’s open kernel modules support real-time kernels in supported configurations. (more on the line) 4. **L4** `tests/test_no_gpu_start.py:225`: The test constructs the diagnostic line by calling the probe directly; it never exercises pick_device. (more on the line) 5. **L5** (minor) `tests/test_no_gpu_start.py:249`: This C test selects CXX and forces it into C mode, so a configured CC is ignored both directly and through run_all. (more on the line) 6. **L6** (minor) `tests/test_no_gpu_start.py:217`: On Windows the synthetic probe reads the temporary directory through narrow fopen and stat. (more on the line) 7. **L8**: The check `Guide screenshots / Guide images and local UI source review (pull_request)` fails on this head and passes on the base branch: Failing after 37s. **Before merging, for the author (1)** (a run, a measurement or a decision; it doesn't hold the recommendation) - **L7** (minor) `gpu/vk/compat/longshot_no_gpu.h:64`: The reported Linux NVIDIA real-time-kernel failure and the normal Steam Deck or AMD startup have not been exercised in game. (more on the line) **Checks:** Still running: `CI / Website build and checks (pull_request)`. <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Yes for the tested Windows visible-window case: the author reports that the base continued behind a black window for 30 seconds, while this branch exited with code 1 in under a second and showed the failure window. The reported Linux NVIDIA real-time-kernel case has not yet been run. **Other systems:** Linux NVIDIA failure and normal Steam Deck or AMD startup remain untested in game. Headless startup uses a separate path that still ignores renderer failure. Closing a Linux window while startup is in progress can race the new exit with renderer cleanup. **Switches:** No runtime switches added, changed or removed. LONGSHOT_NO_GPU_KEYS_ONLY is a compile-time header selector, default undefined. **Reviewed:** a4d79341bdad against d76d202f5165: Read the repository rules, contribution standards, PR template, commits, diff, new header and test, and the affected startup, crash-dialog, renderer and shutdown paths. Skimmed the remaining portions of the large changed code files and existing test runner; did not inspect screenshots or generated files. The optional docs/review-checklist.md and sibling Tooling checkout were absent.; nothing run (a code review). **Checked and fine:** - The commits include AI-assistance trailers. - No game-derived files, generated shader files, renderer API changes or third-party changes appear in the diff. - The Windows no-device and normal-start runs are reported with their hardware and observed outcomes. - The crash-dialog cause values are appended, preserving the existing numeric values. **Testing:** Read-only review; no project code, tests or builds were run. The supplied CI result has a head-only failure that the bot will report separately, and the website check is still running. **Overlaps and merge order:** No overlapping pull request established from the supplied material. </details> --- <sub>Automated code review by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
@ -0,0 +61,4 @@
}
// What the PC says: root "" for its own /sys and /proc, a folder that holds sys/ and proc/ for a test, NULL for nothing
static inline void longshot_no_gpu_probe(const char *root, LongshotNoGpu *g) {
memset(g, 0, sizeof *g);
Member

L7 (minor): The reported Linux NVIDIA real-time-kernel failure and the normal Steam Deck or AMD startup have not been exercised in game. Run the stated cases and record the resulting exit, diagnosis and normal startup before merge.

**L7** (minor): The reported Linux NVIDIA real-time-kernel failure and the normal Steam Deck or AMD startup have not been exercised in game. Run the stated cases and record the resulting exit, diagnosis and normal startup before merge.
@ -0,0 +85,4 @@
}
if (d) closedir(d);
if (g->nvidia_card)
g->cause = g->nvidia_loaded ? LONGSHOT_NO_GPU_NVIDIA_VULKAN : g->realtime ? LONGSHOT_NO_GPU_NVIDIA_RT
Member

L2: The probe treats any NVIDIA PCI card plus an absent nvidia module as proof that NVIDIA’s driver caused the failure. On a hybrid laptop using its AMD or Intel GPU, an unused NVIDIA card can be present while a missing or filtered Mesa Vulkan driver is the actual problem; the dialog instead tells the player to install NVIDIA’s driver or change kernels. Treat these observations as possibilities unless the affected device and driver are established, and retain generic troubleshooting for ambiguous systems.

**L2**: The probe treats any NVIDIA PCI card plus an absent nvidia module as proof that NVIDIA’s driver caused the failure. On a hybrid laptop using its AMD or Intel GPU, an unused NVIDIA card can be present while a missing or filtered Mesa Vulkan driver is the actual problem; the dialog instead tells the player to install NVIDIA’s driver or change kernels. Treat these observations as possibilities unless the affected device and driver are established, and retain generic troubleshooting for ambiguous systems.
@ -483,0 +497,4 @@
return "Vulkan found no graphics card: no graphics driver with Vulkan is installed or loaded. Install or update your "
"graphics driver and restart your PC: Longshot needs a graphics card and driver with Vulkan 1.3.";
case HOS_CAUSE_NVIDIA_RT:
return "NVIDIA's driver isn't loaded: this Linux kernel is a real-time one (PREEMPT_RT), which NVIDIA's driver doesn't "
Member

L3: The message says NVIDIA’s driver cannot run on any PREEMPT_RT kernel, but that conclusion does not follow from an unloaded module and NVIDIA’s open kernel modules support real-time kernels in supported configurations. A player with an unrelated installation or module-loading failure is directed to replace their kernel. Describe the detected combination as a possible compatibility issue and give driver-specific troubleshooting; correct the same absolute claim in the Linux documentation and log text.

**L3**: The message says NVIDIA’s driver cannot run on any PREEMPT_RT kernel, but that conclusion does not follow from an unloaded module and NVIDIA’s open kernel modules support real-time kernels in supported configurations. A player with an unrelated installation or module-loading failure is directed to replace their kernel. Describe the detected combination as a possible compatibility issue and give driver-specific troubleshooting; correct the same absolute claim in the Linux documentation and log text.
@ -209,0 +212,4 @@
void hos_crash_clean_end(void);
hos_crash_clean_end();
ExitProcess(1);
}
Member

L1: A player can close the window while the renderer starts: rx_close_asked sets the renderer’s closing flag and performs cache and worker cleanup, while start can return 0 because that flag is set. This branch then logs a startup failure and exits the process concurrently, potentially interrupting that cleanup and showing a failure dialog for an intentional quit. Coordinate the close and startup threads and let the close path finish when startup was cancelled.

**L1**: A player can close the window while the renderer starts: rx_close_asked sets the renderer’s closing flag and performs cache and worker cleanup, while start can return 0 because that flag is set. This branch then logs a startup failure and exits the process concurrently, potentially interrupting that cleanup and showing a failure dialog for an intentional quit. Coordinate the close and startup threads and let the close path finish when startup was cancelled.
@ -0,0 +214,4 @@
compile_c(cxx, tmp / "dialog.c", dialog, ROOT / "host")
for name, (files, want) in PCS.items():
root = tmp / ("pc-" + name)
root.mkdir()
Member

L6 (minor): On Windows the synthetic probe reads the temporary directory through narrow fopen and stat. If the temporary path contains characters outside the active Windows code page, Python creates the files but the probe cannot open them, so the test fails on a supported user profile. Use a Windows Unicode-capable file path for the fixture or arrange an ASCII-only temporary root.

**L6** (minor): On Windows the synthetic probe reads the temporary directory through narrow fopen and stat. If the temporary path contains characters outside the active Windows code page, Python creates the files but the probe cannot open them, so the test fails on a supported user profile. Use a Windows Unicode-capable file path for the fixture or arrange an ASCII-only temporary root.
@ -0,0 +222,4 @@
if not line.startswith("no Vulkan device (cause %s)" % want):
raise SystemExit("FAIL: %s: the line does not start with its cause: %r" % (name, line))
cards = "1002:744c" if name == "amd" else "10de:2d05" if files else ""
if cards not in line or "10de:22eb" in line or "8086:7ae0" in line:
Member

L4: The test constructs the diagnostic line by calling the probe directly; it never exercises pick_device. Removing the new probe and log call from vk_main.cpp would still let this test pass, leaving the crash window unable to identify the reported Linux case. Exercise the actual no-device enumeration path with Vulkan stand-ins and assert that its emitted line reaches the dialog.

**L4**: The test constructs the diagnostic line by calling the probe directly; it never exercises pick_device. Removing the new probe and log call from vk_main.cpp would still let this test pass, leaving the crash window unable to identify the reported Linux case. Exercise the actual no-device enumeration path with Vulkan stand-ins and assert that its emitted line reaches the dialog.
@ -0,0 +246,4 @@
def main():
parser = argparse.ArgumentParser(description=__doc__)
parser.add_argument("--cxx", default=os.environ.get("CXX", "clang++"))
Member

L5 (minor): This C test selects CXX and forces it into C mode, so a configured CC is ignored both directly and through run_all. A machine with its supported C compiler in CC but no usable C++ driver fails or skips the check. Accept and pass the runner’s {cc}, and honour CC for direct runs.

**L5** (minor): This C test selects CXX and forces it into C mode, so a configured CC is ignored both directly and through run_all. A machine with its supported C compiler in CC but no usable C++ driver fails or skips the check. Accept and pass the runner’s {cc}, and honour CC for direct runs.
Author
Member
@fix
fix(host): coordinate renderer startup failure and improve GPU diagnostics
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 19s
PR description / Description follows the template (pull_request_target) Has been cancelled
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 29s
CI / Workflow lint (actionlint) (pull_request) Successful in 31s
Third-party parts / As their notes say (pull_request) Successful in 38s
CI / Website build and checks (pull_request) Failing after 48s
9b3babba15
As the review on #2102 asked.
BeanBot left a comment

Recommendation: Approve. The reported NVIDIA real-time-kernel failure and a normal Steam Deck or AMD startup still need in-game verification. The Windows no-device run showed the game exiting promptly with a useful message. Nothing blocking is left: what remains is for the author before merging (below). Recommend approval; not approved on the forge.

What @fix changed
I changed this pull request: the new head is 9b3babba15. I edited its description to match the change.

Changed

  • Cancelled renderer startup: Coordinated startup failure and close callers in host/rx_backend.c:613 and host/posix/display_sdl.c:208, and added cancellation coverage.
  • Ambiguous GPU diagnosis: gpu/vk/compat/longshot_no_gpu.h:69 keeps hybrid or incomplete observations generic; host/hos_crash_dialog.h:496 presents driver states as troubleshooting clues.
  • Real-time kernel guidance: Updated the log, dialog, and docs/user/common-issues.md:101 to describe possible compatibility or loading issues and driver-specific troubleshooting.
  • Honor the C compiler: tests/test_no_gpu_start.py:31 accepts the runner's CC and honors CC directly; the C probe and dialog checks can run without a C++ compiler.
  • Windows fixture paths: tests/test_no_gpu_start.py:312 places the fixture under the ASCII-only Windows Public directory, avoiding Unicode user temporary paths. Tests were not run, as requested.
  • Require enumeration-to-dialog integration in tests/test_no_gpu_start.py:31: Removed the direct-probe fallback, require a C++ compiler, and declare it to the test runner. Tests were not run as instructed.

Not done

  • Guide screenshot source review: The recorded review revision eee321b64a is absent from the checkout, so the affected sources and guide could not be compared. The author must review them and update the review hashes.

Nothing was built or run: the checks run again on the new head.

Ends a failed renderer startup instead of leaving the game running behind a black window, and adds Linux-specific diagnostic guidance. The probe and startup coordination add code, with the affected Linux hardware paths still awaiting in-game runs.

Before merging, for the author (1) (a run, a measurement or a decision; it doesn't hold the recommendation)

  • L7 (minor) gpu/vk/compat/longshot_no_gpu.h:64: The reported Linux NVIDIA real-time-kernel failure and the normal Steam Deck or AMD startup have not been exercised in game. Run the stated cases and record the resulting exit, diagnosis and normal startup before merge.

Checks: they run again on this head (Guide screenshots / Guide images and local UI source review (pull_request) failed on the last one); a failure shows on the pull request.

Also noticed (4; not asked for, not blocking)
  • The PR description still states the former definitive NVIDIA real-time-kernel diagnosis and quotes the former dialog wording.
  • A configured but unavailable CXX makes the test fail even when CC is usable.
  • A Windows installation whose PUBLIC path is missing, non-ASCII or not writable cannot use the fixture root.
  • The description's Linux diagnosis wording is broader than the probe, which leaves the cause unknown when another graphics card is present or PCI information is incomplete.
More: does it help, other systems, switches, what was read

Does it help: Unproven for the reported Linux case. On Windows, the author reports that a no-device start changed from 5,616 frames behind a black window over 30 seconds to exit code 1 in under a second with a diagnostic window.

Other systems: Windows no-device and normal starts were reported working. Linux NVIDIA real-time-kernel failure and normal Steam Deck or AMD startup remain untested in game; gamescope exits without a crash window.

Switches: None added, changed, or removed.

Reviewed: 9b3babba15 against d76d202f51: Read the diff, GPU probe and new test; reviewed the relevant startup, crash-dialog and caller excerpts, repository rules, PR template, description and recorded runs. Other changed code files were not read in full; no review checklist file was found.; nothing run (a code review).

Checked and fine:

  • The probe keeps mixed or incomplete PCI observations generic.
  • The reported Windows run covers both a no-device failure and a normal startup.

Testing: No commands from the project or tests were run. The author reports prior Windows and Linux fixture results; CI has not run on this head.

Overlaps and merge order: none found


Automated code review by BeanBot (gpt-6.1-terra), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.

**Recommendation: Approve.** The reported NVIDIA real-time-kernel failure and a normal Steam Deck or AMD startup still need in-game verification. The Windows no-device run showed the game exiting promptly with a useful message. Nothing blocking is left: what remains is for the author before merging (below). Recommend approval; not approved on the forge. **What `@fix` changed** I changed this pull request: the new head is 9b3babba1560. I edited its description to match the change. **Changed** - **Cancelled renderer startup**: Coordinated startup failure and close callers in host/rx_backend.c:613 and host/posix/display_sdl.c:208, and added cancellation coverage. - **Ambiguous GPU diagnosis**: gpu/vk/compat/longshot_no_gpu.h:69 keeps hybrid or incomplete observations generic; host/hos_crash_dialog.h:496 presents driver states as troubleshooting clues. - **Real-time kernel guidance**: Updated the log, dialog, and docs/user/common-issues.md:101 to describe possible compatibility or loading issues and driver-specific troubleshooting. - **Honor the C compiler**: tests/test_no_gpu_start.py:31 accepts the runner's CC and honors CC directly; the C probe and dialog checks can run without a C++ compiler. - **Windows fixture paths**: tests/test_no_gpu_start.py:312 places the fixture under the ASCII-only Windows Public directory, avoiding Unicode user temporary paths. Tests were not run, as requested. - **Require enumeration-to-dialog integration in tests/test_no_gpu_start.py:31**: Removed the direct-probe fallback, require a C++ compiler, and declare it to the test runner. Tests were not run as instructed. **Not done** - **Guide screenshot source review**: The recorded review revision eee321b64a0ad410ef8b17d564e2c75414586724 is absent from the checkout, so the affected sources and guide could not be compared. The author must review them and update the review hashes. Nothing was built or run: the checks run again on the new head. Ends a failed renderer startup instead of leaving the game running behind a black window, and adds Linux-specific diagnostic guidance. The probe and startup coordination add code, with the affected Linux hardware paths still awaiting in-game runs. **Before merging, for the author (1)** (a run, a measurement or a decision; it doesn't hold the recommendation) - **L7** (minor) `gpu/vk/compat/longshot_no_gpu.h:64`: The reported Linux NVIDIA real-time-kernel failure and the normal Steam Deck or AMD startup have not been exercised in game. Run the stated cases and record the resulting exit, diagnosis and normal startup before merge. **Checks:** they run again on this head (`Guide screenshots / Guide images and local UI source review (pull_request)` failed on the last one); a failure shows on the pull request. <details> <summary>Also noticed (4; not asked for, not blocking)</summary> - The PR description still states the former definitive NVIDIA real-time-kernel diagnosis and quotes the former dialog wording. - A configured but unavailable CXX makes the test fail even when CC is usable. - A Windows installation whose PUBLIC path is missing, non-ASCII or not writable cannot use the fixture root. - The description's Linux diagnosis wording is broader than the probe, which leaves the cause unknown when another graphics card is present or PCI information is incomplete. </details> <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Unproven for the reported Linux case. On Windows, the author reports that a no-device start changed from 5,616 frames behind a black window over 30 seconds to exit code 1 in under a second with a diagnostic window. **Other systems:** Windows no-device and normal starts were reported working. Linux NVIDIA real-time-kernel failure and normal Steam Deck or AMD startup remain untested in game; gamescope exits without a crash window. **Switches:** None added, changed, or removed. **Reviewed:** 9b3babba1560 against d76d202f5165: Read the diff, GPU probe and new test; reviewed the relevant startup, crash-dialog and caller excerpts, repository rules, PR template, description and recorded runs. Other changed code files were not read in full; no review checklist file was found.; nothing run (a code review). **Checked and fine:** - The probe keeps mixed or incomplete PCI observations generic. - The reported Windows run covers both a no-device failure and a normal startup. **Testing:** No commands from the project or tests were run. The author reports prior Windows and Linux fixture results; CI has not run on this head. **Overlaps and merge order:** none found </details> --- <sub>Automated code review by BeanBot (gpt-6.1-terra), asked for by BeanBot, after its fix. Nothing was run; a maintainer decides.</sub>
HumanBean deleted branch fix/no-gpu-start 2026-11-21 19:13:39 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!2102
No description provided.