fix(hid): Link rolls again when A is pressed while running forward: the Npad state carries no stick direction bits #2017

Merged
HumanBean merged 2 commits from HumanBean/Longshot:fix/no-stick-bits-roll into main 2026-11-21 06:42:12 +00:00
Owner

Summary

Since #1684 (merged 11-19), Link often does not roll when A is pressed while running forward: tap A a few times while running forward and he keeps running; holding A sometimes unsticks it. Backward and to the sides still roll.

#1684 ORed the sticks' direction pseudo-buttons (bits 16-23) into every Npad state the game reads, on the reading that "the game reads the axes, not these bits". The game does read them. Its own controllers have 28 bits: the left stick's directions at 20-23 and the right's at 24-27, which they work out from the axes and write over each update. Npad bits below 20 are kept as buttons, and 16-19 there are the D-pad. With the left stick pushed forward (Npad bit 17, StickLUp), the game saw a D-pad bit held while A was pressed, and did not roll.

This writes the buttons alone again: stick_buttons and its call in npad_states go, and so does tests/test_stick_buttons.py, which checked that the bits were there. Nothing on main reads the bits; #1684 added them for a mod on another branch, which can get stick directions from the axes.

Read host/nn_hid.c npad_states and tests/input_background_test.c packet().

To see it on main: run forward in the field and tap A every 100-200 ms; most taps keep Link running instead of rolling.

See #1684.

Testing

Tested: CachyOS (Linux 7.3.3), NVIDIA GeForce RTX 3090, driver 620.70, Nintendo Switch Pro Controller over SDL, uncapped (65-80 fps), DLSS Quality, Hyrule Field and Kokiri Forest, main @ 6e1521a7 built as a pack:

  • With an input log (local only), every A press reached the game as A plus StickLUp (0x20001) with the stick at about (-1500, 32700); Sprint's mask stayed 0 and Link's driven-body carry (#1740) never ran. Taps while running forward did not roll.
  • The same build with the stick bits left out of the state (a local switch skipping exactly the line this PR removes): the game got 0x1 for A with the stick forward, 238 presses, and forward rolls worked every time.
  • The same build with the bits back on (control run, 148 presses, 101 of them forward with StickLUp): forward rolls failed again.
  • A probe in the game's controller update (local only) read its controllers' layout: 28 bits, left stick group at bit 20, right at 24.
  • This branch @ b8c04c1c, built as a pack and run through the job queue (65 s, Switch Pro Controller, DLSS, uncapped): run forward tapping A, Link rolls as he should (by hand); the game closed normally.

The game-free test: tests/test_input_background.py's harness runs the real npad_states and now expects each state's buttons alone, whatever the sticks. Its frame-clock cases (frame-hold, wall, zero, empty) press A with the left stick fully forward, so on main the state carries 0x20001 and the check fails; here it carries 0x1. A new case, stick-directions, pushes each stick all the way in each direction and diagonal with A held and presses each D-pad button with the stick forward: the buttons alone, and the D-pad still reaches the state. It was not run on this PC (tests are left to CI here).

Still to test:

  • Windows, a controller: run forward and tap A quickly, expecting a roll at each tap (@Beanstalk windows, a controller, run forward in Hyrule Field tapping A)
  • Steam Deck: the same with its built-in controls, expecting a roll at each tap (@Beanstalk deck)
  • Keyboard: hold W and tap E, expecting a roll at each tap (by hand)

Measurements

Verdict: forward rolls work again: with the stick bits left out, every forward A tap rolled; with them in, the taps kept Link running.

Setup: CachyOS (Linux 7.3.3), RTX 3090, NVIDIA 620.70, Switch Pro Controller over SDL, uncapped (65-80 fps), DLSS Quality, Hyrule Field; A tapped every 100-200 ms while running forward; the game's received word from a local input log, the roll seen by hand.

Before: main @ 6e1521a7 main @ 6e1521a7, the removed line skipped (local switch) main @ 6e1521a7, control (line back on) After: this PR @ b8c04c1c
Word the game got for A, stick forward 0x20001 0x1 0x20001 (not logged)
Forward A taps that rolled few (most kept running) all (238 presses) few (101 forward presses) all (by hand, 65 s run)

The PR head after review (d0a74ffe, 35db3bf9) changes only the test; host/ is the same as b8c04c1c.

Risks

Code that read bits 16-23 from the game's Npad state sees them clear again, as before #1684. Nothing on main does. A revert brings back the roll bug. Players notice nothing after updating except that forward rolls work.

Checklist

Ready for review

  • One topic, on current main; the title is a Conventional Commit.
  • Tested on my own PC, in the game for a change the game runs, as Testing says.
  • mise run test passes (any failure that also fails on main is named). (not run on this PC; for CI)
  • Measured against main, or Measurements says why there is nothing to measure.
  • No game files, build output or hand-edited generated files; third_party/ untouched; nothing GPL-incompatible.

When it applies

  • A fix: a game-free test that fails on main and passes here. (written as two commits, test then fix; not run on this PC, for CI)
  • A check under tests/ that reads changed source is updated, not weakened.
  • Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. (Linux: built as a pack; Windows: the change only removes a static function and its one call, nothing platform-specific)
  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.

🤖 Generated with Claude Code

## Summary Since #1684 (merged 11-19), Link often does not roll when A is pressed while running **forward**: tap A a few times while running forward and he keeps running; holding A sometimes unsticks it. Backward and to the sides still roll. #1684 ORed the sticks' direction pseudo-buttons (bits 16-23) into every Npad state the game reads, on the reading that "the game reads the axes, not these bits". The game does read them. Its own controllers have 28 bits: the left stick's directions at 20-23 and the right's at 24-27, which they work out from the axes and write over each update. Npad bits below 20 are kept as buttons, and 16-19 there are the D-pad. With the left stick pushed forward (Npad bit 17, StickLUp), the game saw a D-pad bit held while A was pressed, and did not roll. This writes the buttons alone again: `stick_buttons` and its call in `npad_states` go, and so does `tests/test_stick_buttons.py`, which checked that the bits were there. Nothing on `main` reads the bits; #1684 added them for a mod on another branch, which can get stick directions from the axes. Read `host/nn_hid.c` `npad_states` and `tests/input_background_test.c` `packet()`. To see it on `main`: run forward in the field and tap A every 100-200 ms; most taps keep Link running instead of rolling. See #1684. ## Testing **Tested:** CachyOS (Linux 7.3.3), NVIDIA GeForce RTX 3090, driver 620.70, Nintendo Switch Pro Controller over SDL, uncapped (65-80 fps), DLSS Quality, Hyrule Field and Kokiri Forest, `main` @ 6e1521a7 built as a pack: - With an input log (local only), every A press reached the game as A plus StickLUp (`0x20001`) with the stick at about (-1500, 32700); Sprint's mask stayed 0 and Link's driven-body carry (#1740) never ran. Taps while running forward did not roll. - The same build with the stick bits left out of the state (a local switch skipping exactly the line this PR removes): the game got `0x1` for A with the stick forward, 238 presses, and forward rolls worked every time. - The same build with the bits back on (control run, 148 presses, 101 of them forward with StickLUp): forward rolls failed again. - A probe in the game's controller update (local only) read its controllers' layout: 28 bits, left stick group at bit 20, right at 24. - This branch @ b8c04c1c, built as a pack and run through the job queue (65 s, Switch Pro Controller, DLSS, uncapped): run forward tapping A, Link rolls as he should (by hand); the game closed normally. The game-free test: `tests/test_input_background.py`'s harness runs the real `npad_states` and now expects each state's buttons alone, whatever the sticks. Its frame-clock cases (`frame-hold`, `wall`, `zero`, `empty`) press A with the left stick fully forward, so on `main` the state carries `0x20001` and the check fails; here it carries `0x1`. A new case, `stick-directions`, pushes each stick all the way in each direction and diagonal with A held and presses each D-pad button with the stick forward: the buttons alone, and the D-pad still reaches the state. It was not run on this PC (tests are left to CI here). **Still to test:** - Windows, a controller: run forward and tap A quickly, expecting a roll at each tap (@Beanstalk windows, a controller, run forward in Hyrule Field tapping A) - Steam Deck: the same with its built-in controls, expecting a roll at each tap (@Beanstalk deck) - Keyboard: hold W and tap E, expecting a roll at each tap (by hand) ## Measurements **Verdict:** forward rolls work again: with the stick bits left out, every forward A tap rolled; with them in, the taps kept Link running. Setup: CachyOS (Linux 7.3.3), RTX 3090, NVIDIA 620.70, Switch Pro Controller over SDL, uncapped (65-80 fps), DLSS Quality, Hyrule Field; A tapped every 100-200 ms while running forward; the game's received word from a local input log, the roll seen by hand. | | Before: main @ 6e1521a7 | main @ 6e1521a7, the removed line skipped (local switch) | main @ 6e1521a7, control (line back on) | After: this PR @ b8c04c1c | |---|---|---|---|---| | Word the game got for A, stick forward | `0x20001` | `0x1` | `0x20001` | (not logged) | | Forward A taps that rolled | few (most kept running) | all (238 presses) | few (101 forward presses) | all (by hand, 65 s run) | The PR head after review (d0a74ffe, 35db3bf9) changes only the test; `host/` is the same as b8c04c1c. ## Risks Code that read bits 16-23 from the game's Npad state sees them clear again, as before #1684. Nothing on `main` does. A revert brings back the roll bug. Players notice nothing after updating except that forward rolls work. ## Checklist ### Ready for review - [x] One topic, on current `main`; the title is a Conventional Commit. - [x] Tested on my own PC, in the game for a change the game runs, as Testing says. - [ ] `mise run test` passes (any failure that also fails on `main` is named). (not run on this PC; for CI) - [x] Measured against `main`, or Measurements says why there is nothing to measure. - [x] No game files, build output or hand-edited generated files; `third_party/` untouched; nothing GPL-incompatible. ### When it applies - [ ] A fix: a game-free test that fails on `main` and passes here. (written as two commits, test then fix; not run on this PC, for CI) - [x] A check under `tests/` that reads changed source is updated, not weakened. - [x] Host code builds on Windows (llvm-mingw) and Linux, with UTF-8 paths. (Linux: built as a pack; Windows: the change only removes a static function and its one call, nothing platform-specific) - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
The harness's packet() expected the buttons plus the sticks' direction bits (#1684). The game's own controllers read
bits 16-19 as the D-pad, so the left stick pushed forward (bit 17) held one, and A pressed while running forward did not
roll. The frame-clock cases press A with the stick fully forward; on main the state carries 0x20001 and they fail.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
fix(hid): Link rolls again when A is pressed while running forward: the Npad state carries no stick direction bits
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 16s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 26s
CI / Workflow lint (actionlint) (pull_request) Successful in 27s
Third-party parts / As their notes say (pull_request) Successful in 31s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Website build and checks (pull_request) Failing after 51s
PR description / Description follows the template (pull_request_target) Failing after 13s
b8c04c1ce4
#1684 ORed the sticks' direction pseudo-buttons (bits 16-23) into every Npad state the game reads. The game's own
controllers (28 bits, the left stick's group at 20-23 and the right's at 24-27, worked out from the axes) keep the Npad
bits below 20 as buttons, where 16-19 are the D-pad: the left stick pushed forward (bit 17) held one, and A pressed while
running forward did not roll, mostly when A was tapped quickly. Backward and to the sides still rolled.

npad_states writes the buttons alone again; stick_buttons and tests/test_stick_buttons.py, which checked the bits were
there, go. tests/test_input_background.py's harness (the previous commit) expects no direction bits.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Author
Owner

Tested in game: CachyOS (Linux 7.3.3), RTX 3090, NVIDIA 620.70, Switch Pro Controller, uncapped, Hyrule Field: on main 6e1521a7 taps of A while running forward did not roll (the game got A + StickLUp, 0x20001); the same build with exactly this line's stick bits left out gave 0x1 and every forward roll worked (238 presses); bits back on, the rolls failed again. This branch builds as a pack.

Tested in game: CachyOS (Linux 7.3.3), RTX 3090, NVIDIA 620.70, Switch Pro Controller, uncapped, Hyrule Field: on main 6e1521a7 taps of A while running forward did not roll (the game got A + StickLUp, 0x20001); the same build with exactly this line's stick bits left out gave 0x1 and every forward roll worked (238 presses); bits back on, the rolls failed again. This branch builds as a pack.
BeanBot left a comment

Recommendation: Request changes. Removing the synthetic stick bits restored forward rolls in the Linux A/B. The required regression harness can fail before checking the fix on a Clang-only setup or when it inherits a mouse setting.

The Npad writer sends the mapped buttons and stick axes without synthesizing direction bits. This removes the false D-pad input that blocked forward rolls and deletes the helper that produced it. Mods that read stick directions from bits 16–23 lose those inputs and need to derive them from the axes.

@fix will do (7)

  1. L1 tests/test_input_background.py:40: The replacement regression test hardcodes GCC in both the suite declaration and the standalone default. On a Windows llvm-mingw setup with CC pointing to clang and no gcc on PATH, the suite can skip or fail this check before reading a packet. Honor CC unless --cc is explicit, use a GCC or Clang fallback, and remove the suite's hardcoded override.
  2. L2 tests/test_input_background.py:132: The fixture still inherits HOS_MOUSE_NATIVE, which overrides the mouse mode set by its cases. With HOS_MOUSE_NATIVE=0, menu-side-buttons takes the mouse-as-stick path before the menu opens, the motion spy reports no capture, and the Mouse 4 assertion fails independently of the Npad fix. Clear HOS_MOUSE_NATIVE from the fixture environment.
  3. L3 (minor) tests/test_input_background.py:172: The live-input cases pass an absolute temporary path to a fixture that uses narrow getenv and fopen without the game's Windows UTF-8 manifest. With TEMP under a directory containing characters outside the system code page, the fixture can fail to reopen the file Python created. Launch the fixture from its temporary directory and pass an ASCII relative filename, or link the existing UTF-8 manifest.
  4. L4 (minor) tests/input_background_test.c:172: The test describes a contract for both sticks, but the fixture always expects right-stick Y to be zero. Reintroducing just StickRDown would pass, including the direction used by the mod that prompted #1684. Add full deflections in each direction for both sticks and include a real D-pad press to verify that it still reaches the state.
  5. L5 (minor): Measurements says there is nothing to measure, but the standards treat before-and-after bug evidence as the measurement for a fix. Move the reported A/B result into Measurements, label 6e1521a7 and the local line-bypass variant, and add the PR-head result when available. Restore the applicable Windows/Linux host-build checkbox and leave it open until verified.
  6. L8: The check Guide screenshots / Guide images and local UI source review (pull_request) fails on this head and passes on the base branch: Failing after 26s.
  7. L9: The check CI / Website build and checks (pull_request) fails on this head and passes on the base branch: Failing after 51s.

For the author (2) (a run, a measurement or a decision)

  • L6 (minor) tests/test_input_background.py:126: The description predicts the fixture result, but supplies no run of the test-only commit or the head. (more on the line)
  • L7 (minor) host/nn_hid.c:1458: The in-game result comes from a local Linux variant. Before merge, verify forward A taps on the PR head with a Windows controller, the Steam Deck's built-in controls and the keyboard, and exercise the real D-pad and right-stick camera during those runs.
More: does it help, other systems, switches, what was read

Does it help: Yes for the reproduced Linux case. On the same CachyOS, RTX 3090 and Switch Pro Controller setup, the author reports 238 successful forward rolls on main 6e1521a7 with the removed line bypassed. Re-enabling it reproduced the failure, and 101 of 148 control presses were forward with StickLUp set. The tested revision has the same HID source as the merge base. The PR head was reported to build as a pack. No performance gain is claimed.

Other systems: SDL, XInput, the Deck, keyboard, mouse-as-stick, scripted input and the control bridge share the Npad writer. All five Npad styles take the same change. The diff leaves the axis writes, physical D-pad mapping, Sprint processing, ocarina remapping and the cheat button snapshot in their existing positions. Renderer, GPU-driver, audio, save and build paths have no direct change. Windows controller, Steam Deck and keyboard gameplay still need confirmation. The off-branch mod's R plus right-stick-down combo loses its direction bit.

Switches: None. The local A/B switch does not ship.

Reviewed: b8c04c1ce4 against 2b3de5b27a: Read host/nn_hid.c, tests/input_background_test.c, tests/test_input_background.py and the deleted tests/test_stick_buttons.py in full, along with the two PR commits, AGENTS.md, CONTRIBUTING.md, the developer standards, the fix-with-test guidance and the Forgejo template. No docs/review-checklist.md was present. Traced Npad entry points, the control bridge, cheat and Sprint consumers, the guest range helper, the fixture runner and local main history. Read the PR report, comment and supplied CI results. Skimmed related source checks and CI configuration. Unrelated archived runs and translations were outside the diff.; nothing run (a code review).

Checked and fine:

  • The test-only commit retains the production helper, so the forward input reaches the new packet assertion with the old extra bit. Both returned states are checked.
  • The production edit removes only a calculation on local input data. It adds no shared state, allocation, resource lifetime, guest write or file operation.
  • The old positive test for synthetic bits has no remaining references. Both commits carry AI co-author trailers.
  • The diff contains no game-derived files, generated files, third-party edits, shader changes, switch table changes or renderer API changes.

Testing: Read-only review. git diff --check passed. No builds, tests or project scripts were run during review. The author reported the Linux A/B and PR-head pack build. The supplied CI has two head-only failures, which the bot tracks separately.

Overlaps and merge order: No competing open change was visible in the checkout. #1684 is the merged change being reversed. Local main is 85a59e6f8 and has no intervening edits to the four changed files.


Automated code review by BeanBot (gpt-6.2-sol), on the pull request's opening. Nothing was run; a maintainer decides.

**Recommendation: Request changes.** Removing the synthetic stick bits restored forward rolls in the Linux A/B. The required regression harness can fail before checking the fix on a Clang-only setup or when it inherits a mouse setting. The Npad writer sends the mapped buttons and stick axes without synthesizing direction bits. This removes the false D-pad input that blocked forward rolls and deletes the helper that produced it. Mods that read stick directions from bits 16–23 lose those inputs and need to derive them from the axes. **`@fix` will do (7)** 1. **L1** `tests/test_input_background.py:40`: The replacement regression test hardcodes GCC in both the suite declaration and the standalone default. On a Windows llvm-mingw setup with CC pointing to clang and no gcc on PATH, the suite can skip or fail this check before reading a packet. Honor CC unless --cc is explicit, use a GCC or Clang fallback, and remove the suite's hardcoded override. 2. **L2** `tests/test_input_background.py:132`: The fixture still inherits HOS_MOUSE_NATIVE, which overrides the mouse mode set by its cases. With HOS_MOUSE_NATIVE=0, menu-side-buttons takes the mouse-as-stick path before the menu opens, the motion spy reports no capture, and the Mouse 4 assertion fails independently of the Npad fix. Clear HOS_MOUSE_NATIVE from the fixture environment. 3. **L3** (minor) `tests/test_input_background.py:172`: The live-input cases pass an absolute temporary path to a fixture that uses narrow getenv and fopen without the game's Windows UTF-8 manifest. With TEMP under a directory containing characters outside the system code page, the fixture can fail to reopen the file Python created. Launch the fixture from its temporary directory and pass an ASCII relative filename, or link the existing UTF-8 manifest. 4. **L4** (minor) `tests/input_background_test.c:172`: The test describes a contract for both sticks, but the fixture always expects right-stick Y to be zero. Reintroducing just StickRDown would pass, including the direction used by the mod that prompted #1684. Add full deflections in each direction for both sticks and include a real D-pad press to verify that it still reaches the state. 5. **L5** (minor): Measurements says there is nothing to measure, but the standards treat before-and-after bug evidence as the measurement for a fix. Move the reported A/B result into Measurements, label 6e1521a7 and the local line-bypass variant, and add the PR-head result when available. Restore the applicable Windows/Linux host-build checkbox and leave it open until verified. 6. **L8**: The check `Guide screenshots / Guide images and local UI source review (pull_request)` fails on this head and passes on the base branch: Failing after 26s. 7. **L9**: The check `CI / Website build and checks (pull_request)` fails on this head and passes on the base branch: Failing after 51s. **For the author (2)** (a run, a measurement or a decision) - **L6** (minor) `tests/test_input_background.py:126`: The description predicts the fixture result, but supplies no run of the test-only commit or the head. (more on the line) - **L7** (minor) `host/nn_hid.c:1458`: The in-game result comes from a local Linux variant. Before merge, verify forward A taps on the PR head with a Windows controller, the Steam Deck's built-in controls and the keyboard, and exercise the real D-pad and right-stick camera during those runs. <details> <summary>More: does it help, other systems, switches, what was read</summary> **Does it help:** Yes for the reproduced Linux case. On the same CachyOS, RTX 3090 and Switch Pro Controller setup, the author reports 238 successful forward rolls on main 6e1521a7 with the removed line bypassed. Re-enabling it reproduced the failure, and 101 of 148 control presses were forward with StickLUp set. The tested revision has the same HID source as the merge base. The PR head was reported to build as a pack. No performance gain is claimed. **Other systems:** SDL, XInput, the Deck, keyboard, mouse-as-stick, scripted input and the control bridge share the Npad writer. All five Npad styles take the same change. The diff leaves the axis writes, physical D-pad mapping, Sprint processing, ocarina remapping and the cheat button snapshot in their existing positions. Renderer, GPU-driver, audio, save and build paths have no direct change. Windows controller, Steam Deck and keyboard gameplay still need confirmation. The off-branch mod's R plus right-stick-down combo loses its direction bit. **Switches:** None. The local A/B switch does not ship. **Reviewed:** b8c04c1ce4a6 against 2b3de5b27a77: Read host/nn_hid.c, tests/input_background_test.c, tests/test_input_background.py and the deleted tests/test_stick_buttons.py in full, along with the two PR commits, AGENTS.md, CONTRIBUTING.md, the developer standards, the fix-with-test guidance and the Forgejo template. No docs/review-checklist.md was present. Traced Npad entry points, the control bridge, cheat and Sprint consumers, the guest range helper, the fixture runner and local main history. Read the PR report, comment and supplied CI results. Skimmed related source checks and CI configuration. Unrelated archived runs and translations were outside the diff.; nothing run (a code review). **Checked and fine:** - The test-only commit retains the production helper, so the forward input reaches the new packet assertion with the old extra bit. Both returned states are checked. - The production edit removes only a calculation on local input data. It adds no shared state, allocation, resource lifetime, guest write or file operation. - The old positive test for synthetic bits has no remaining references. Both commits carry AI co-author trailers. - The diff contains no game-derived files, generated files, third-party edits, shader changes, switch table changes or renderer API changes. **Testing:** Read-only review. git diff --check passed. No builds, tests or project scripts were run during review. The author reported the Linux A/B and PR-head pack build. The supplied CI has two head-only failures, which the bot tracks separately. **Overlaps and merge order:** No competing open change was visible in the checkout. #1684 is the merged change being reversed. Local main is 85a59e6f8 and has no intervening edits to the four changed files. </details> --- <sub>Automated code review by BeanBot (gpt-6.2-sol), on the pull request's opening. Nothing was run; a maintainer decides.</sub>
@ -120,3 +124,3 @@
block(hid, "static int walk_percent("), block(hid, "static void move_keys_stick("),
block(hid, "static int flight_jump_shortcut("), read, block(hid, "static uint64_t stick_buttons("),
block(hid, "static int flight_jump_shortcut("), read,
block(hid, "static void npad_states(")))
Member

L6 (minor): The description predicts the fixture result, but supplies no run of the test-only commit or the head. Record the test-only commit failing the button-word assertion and the fixed head passing the fixture on Linux and Windows.

**L6** (minor): The description predicts the fixture result, but supplies no run of the test-only commit or the head. Record the test-only commit failing the button-word assertion and the fixed head passing the fixture on Linux and Windows.
Member
@fix
Member

I didn't fix this pull request: docs/user/images/guide/settings-graphics.png isn't a UTF-8 text file. Nothing was pushed.


Automated fix by BeanBot (gpt-6.1-terra), asked for by llun. Nothing was run; a maintainer decides.

I didn't fix this pull request: docs/user/images/guide/settings-graphics.png isn't a UTF-8 text file. Nothing was pushed. --- <sub>Automated fix by BeanBot (gpt-6.1-terra), asked for by llun. Nothing was run; a maintainer decides.</sub>
HumanBean changed title from WIP: fix(hid): Link rolls again when A is pressed while running forward: the Npad state carries no stick direction bits to fix(hid): Link rolls again when A is pressed while running forward: the Npad state carries no stick direction bits 2026-11-21 06:22:09 +00:00
HumanBean force-pushed fix/no-stick-bits-roll from b8c04c1ce4
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 16s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 26s
CI / Workflow lint (actionlint) (pull_request) Successful in 27s
Third-party parts / As their notes say (pull_request) Successful in 31s
Website / Website on Cloudflare (pull_request_target) Has been skipped
CI / Website build and checks (pull_request) Failing after 51s
PR description / Description follows the template (pull_request_target) Failing after 13s
to 35db3bf910
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 15s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 24s
CI / Workflow lint (actionlint) (pull_request) Successful in 27s
PR description / Description follows the template (pull_request_target) Failing after 15s
Third-party parts / As their notes say (pull_request) Successful in 31s
CI / Website build and checks (pull_request) Has been cancelled
2026-11-21 06:27:33 +00:00
Compare
Author
Owner

Review answered, at d0a74ffe (test) and 35db3bf9 (fix):

  • L4, done: a new case, stick-directions, pushes each stick all the way in each direction and diagonal with A held, and presses each D-pad button with the left stick forward. Each state must carry the buttons alone, and the D-pad must still reach it. The bridge fake's sticks now reach the state, and packet4() checks the right stick's Y too, so reintroducing StickRDown alone fails. It is folded into the test commit, which still comes before the fix.
  • L5, done: the A/B is now in Measurements (main, the line skipped, the control, this PR), and the host-build box is added and ticked (Linux built; on Windows the change only removes a static function and its one call).
  • L8 and L9, not this PR: Guide screenshots and Website build and checks fail the same way on #1961, #1723 and #1945, so they are broken on main, not by this diff.
  • L1, L2 and L3, left out: the harness's compiler default, its HOS_MOUSE_NATIVE inheritance and UTF-8 temporary paths predate this PR and don't touch the Npad word. They belong in a change of their own.
  • L6: the test is not run on this PC; it is left to CI.
  • L7: Windows and the Steam Deck stay in Still to test, for the Test Farm. The keyboard was checked by hand on Linux.
Review answered, at d0a74ffe (test) and 35db3bf9 (fix): - **L4, done:** a new case, `stick-directions`, pushes each stick all the way in each direction and diagonal with A held, and presses each D-pad button with the left stick forward. Each state must carry the buttons alone, and the D-pad must still reach it. The bridge fake's sticks now reach the state, and `packet4()` checks the right stick's Y too, so reintroducing StickRDown alone fails. It is folded into the test commit, which still comes before the fix. - **L5, done:** the A/B is now in Measurements (main, the line skipped, the control, this PR), and the host-build box is added and ticked (Linux built; on Windows the change only removes a static function and its one call). - **L8 and L9, not this PR:** Guide screenshots and Website build and checks fail the same way on #1961, #1723 and #1945, so they are broken on `main`, not by this diff. - **L1, L2 and L3, left out:** the harness's compiler default, its `HOS_MOUSE_NATIVE` inheritance and UTF-8 temporary paths predate this PR and don't touch the Npad word. They belong in a change of their own. - **L6:** the test is not run on this PC; it is left to CI. - **L7:** Windows and the Steam Deck stay in Still to test, for the Test Farm. The keyboard was checked by hand on Linux.
Author
Owner

Correction to the reply above: the keyboard was not confirmed separately. The by-hand run of this PR on Linux was with the Switch Pro Controller; the keyboard (W, then E for A) stays in Still to test, by hand.

Correction to the reply above: the keyboard was not confirmed separately. The by-hand run of this PR on Linux was with the Switch Pro Controller; the keyboard (W, then E for A) stays in Still to test, by hand.
HumanBean force-pushed fix/no-stick-bits-roll from 35db3bf910
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
CI / Conventional Commit title (pull_request) Successful in 15s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 24s
CI / Workflow lint (actionlint) (pull_request) Successful in 27s
PR description / Description follows the template (pull_request_target) Failing after 15s
Third-party parts / As their notes say (pull_request) Successful in 31s
CI / Website build and checks (pull_request) Has been cancelled
to 39ac2e5c08
Some checks failed
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
Website / Website on Cloudflare (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Failing after 35s
CI / Conventional Commit title (pull_request) Successful in 36s
CI / Workflow lint (actionlint) (pull_request) Successful in 54s
Guide screenshots / Guide images and local UI source review (pull_request) Successful in 53s
Third-party parts / As their notes say (pull_request) Successful in 1m0s
CI / Website build and checks (pull_request) Successful in 2m38s
2026-11-21 06:39:56 +00:00
Compare
HumanBean deleted branch fix/no-stick-bits-roll 2026-11-21 06:42:14 +00:00
Author
Owner
@fix
Member

I didn't fix this pull request: it isn't open.


Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.

I didn't fix this pull request: it isn't open. --- <sub>Automated fix by BeanBot (gpt-6.1-terra), asked for by HumanBean. Nothing was run; a maintainer decides.</sub>
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!2017
No description provided.