test(menu): cover missing NFC callbacks and live scan status #1838
No reviewers
Labels
No labels
area/accessibility
area/audio
area/input
area/install
area/menu
area/renderer
area/saves
area/tooling
area/upscaling
beanstalk: approved
beanstalk: failed
beanstalk: needs approval
beanstalk: running
beanstalk: tested
ci: approved
good first issue
gpu/amd
gpu/igpu
gpu/intel
gpu/nvidia
help wanted
kind
bug
kind
chore
kind
docs
kind
feature
kind
performance
kind
question
needs measurements
platform/linux
platform/macos
platform/steam-deck
platform/windows
preview
priority
critical
priority
high
priority
low
regression
risk
high
risk
low
risk
medium
status
blocked
status
confirmed
status
duplicate
status
invalid
status
needs-info
status
wontfix
ci: approved
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
MagicBeanDev/Longshot!1838
Loading…
Reference in a new issue
No description provided.
Delete branch "posihdun/Longshot:fix/startup-nfc-hint"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
I added missing-callback and live-status coverage to the NFC scan hint test.
A host can exist without an NFC scan callback. The test now checks that hint enumeration still ends in that case. It also checks that the live status remains available in scan states 1 through 6 and absent in states 0 and 7.
The existing bounded enumeration test is kept. No game or renderer code changes remain in this PR. I kept the runtime fix merged in #1815 after comparing both builds on my Arc B580.
Testing
Tested: Ubuntu 24.04.5, Linux kernel 7.3.1-070301-generic, Intel Arc B580 12 GB, Mesa 26.2.6, Ryzen 7 5800XT, 32 GB RAM.
068fb8ebstartup-loop implementation and passes on current main and this head.The earlier full-suite run finished with 790 passes, 64 failures and 17 skips. I reran the 63 failed checks on main
08994a9eand the PR branch: the same 63 fail on both, each selected rerun taking 74 seconds. The remaining failure,tests/test_vbytes.py, also times out on main after 600.1 seconds when run alone with the same limit. All 64 failures from the earlier suite run are therefore accounted for on main; no full-suite pass is claimed.The 63 failed checks reproduced on main
tests/test_appimage_player_build.pytests/test_bug_report_defaults.pytests/test_capture_read_once.pytests/test_capture_readback_visibility.pytests/test_control.pytests/test_crash_dialog.pytests/test_crash_record.pytests/test_crt_options.pytests/test_damage_debug_menu.pytests/test_dev_ab.pytests/test_dev_packs.pytests/test_display_startup_failure.pytests/test_dlss_feature_size.pytests/test_draw_stream_visibility.pytests/test_failed_compile_keeps_objects.pytests/test_frame_overlap.pytests/test_fsr3fi_hud_layer.pytests/test_fsr_image_retirement.pytests/test_fsr_uniform_ownership.pytests/test_guest_imported.pytests/test_heart_containers.pytests/test_high_fps_fixes.pytests/test_host_guest_writes.pytests/test_hud_layout_row.pytests/test_libc_hooks.pytests/test_lift_cache.pytests/test_linux_preflight.pytests/test_linux_pressure.pytests/test_linux_tools.pytests/test_linux_update.pytests/test_log_open_failure.pytests/test_longshot_ctl.pytests/test_make_game_ngx.pytests/test_mise_build.pytests/test_missing_nup.pytests/test_mods_list.pytests/test_mods_size_table.pytests/test_ngx_sdk.pytests/test_nonuniform_image_arrays.pytests/test_oot_state_tap.pytests/test_parallel_init_order.pytests/test_pending_guest_import.pytests/test_perf_report.pytests/test_pipeline_play_cache.pytests/test_pipeline_tour.pytests/test_prepare_cache_save.pytests/test_present_queue_default.pytests/test_present_source_crop.pytests/test_present_thread.pytests/test_profiling_mode.pytests/test_program_cache_reader.pytests/test_psychov35_fsr3_fg.pytests/test_readback_timeout_source.pytests/test_replay_write_order.pytests/test_seed_reader.pytests/test_slow_frames.pytests/test_song_note_cue.pytests/test_staging_burst.pytests/test_texel_buffer_ownership.pytests/test_upscaler_rows.pytests/test_vcore_escape.pytests/test_vk_occlusion_queries.pytests/test_walk_key.pyI ran the checks on Linux. No Windows build or physical NFC scan is claimed. The final change only extends the game-free test and does not change the reader or platform code.
Still to test: None for the final test-only change.
Measurements
Nothing to measure: the final diff only adds test coverage. It does not change game performance, startup, memory use or cache behavior.
Risks
A test failure could block checks if the expected scan-state contract changes. The source is compiled with stub host callbacks, without a game, GPU, controller or physical tag. The existing bounded enumeration check is preserved. No game files, options, saves or cache formats change.
Checklist
Ready for review
main; the title is a Conventional Commit.mise run testpasses (any failure that also fails onmainis named).main, or Measurements says why there is nothing to measure.third_party/untouched; nothing GPL-incompatible.When it applies
tests/that reads changed source is updated, not weakened.Assisted-by:/Co-Authored-By:trailers.Ready to merge
Platform: Linux. Please add
platform/linux; my account receives HTTP 403 when setting repository labels.Tested in game: Ubuntu 24.04.5, Intel Arc B580, Mesa 26.2.6: rebuilt and installed the renderer, verified startup progressed into rendered game frames with the existing caches; player confirmed working now. Closed cleanly through the control bridge.
Possibly related, for context:
Checked current main: merged PR #1815 (
08994a9e) already fixes this same startup loop and preserves the live-status measurement variant. This PR is superseded; it should not replace that implementation. The Arc B580 run here confirmed the diagnosed loop was removed. Also reviewed the suite log: 790 passes and 63 failures recorded, 17 declared skips, no final summary; no full-suite pass or Windows/NFC hardware validation is claimed.@BeanIssues wrote in #1838 (comment):
resolving merge conflicts,I am keep their and my work robobean!
I merged main and resolved the conflict in tests/test_nfc_scan_hint.py. I kept the bounded enumeration test and added coverage for a missing scan callback and unchanged live scan status. GCC, Clang, the existing paragraph test and Ruff pass. I reran all 63 recorded suite failures on main
08994a9eand my branch: the same 63 checks fail on both. I completed the source and test comparison against #1815; an in-game A/B remains untested. My system is Linux kernel 7.3.1-070301-generic, Ubuntu 24.04.5, Mesa 26.2.6 and Arc B580. Please add platform/linux; my account receives HTTP 403 when setting labels. I am keeping this PR open and WIP. Windows and physical NFC checks are not claimed.WIP: fix(menu): stop startup hanging on NFC scan hintsto WIP: test(menu): cover missing NFC callbacks and live scan statusI finished the comparison on my Linux B580 system. Current main and the earlier PR renderer both started successfully in two alternating runs each, with no demonstrated startup benefit from the stricter runtime cutoff. I kept main's runtime behavior and reduced this PR to the additional NFC test coverage. The final diff only changes tests/test_nfc_scan_hint.py. GCC, Clang, Ruff and the affected-check runner pass. A deliberately broken live-status implementation fails the new assertion. The same 63 failed suite checks reproduce on main, and test_vbytes.py also times out on main after 600.1 seconds. I have recorded all 64 baseline failures in the description. The PR is ready for review. Please approve the waiting workflows and add platform/linux; my account cannot set the label.
WIP: test(menu): cover missing NFC callbacks and live scan statusto test(menu): cover missing NFC callbacks and live scan status