fix(menu): the Scan row's help lines end, so a Linux window starts and the menu opens again #1815

Merged
HumanBean merged 1 commit from mooki/Longshot:fix-nfc-scan-hint-loop into main 2026-11-20 03:57:13 +00:00
Member

Type: fix · Risk: low · Tested on: Linux, RTX 4090 · Needs: Windows, any GPU

TL;DR

Since the menu rows moved into modules (#1774), on Linux the game never gets past its start-up screen in a window, and a windowless run stops presenting at its first Insert. The menu's help-box sizing asks the NFC "Scan tag on controller" row for its help lines one after another until one says nothing, and on a Linux host that row always has another: the render thread loops at 100%. The row now has its two documented lines and then none. With it, the window starts and the scripted Insert opens the menu.

Breakdown

  • Who it helps: everyone who runs the game on Linux, in a window or windowless, and every menu pull request proved on Linux.
  • What was wrong: measure_help (new in #1774) calls a button's hint for line 0, 1, 2 and so on until it returns nothing; nfc_scan_says answered every line with a text when the host's scan state was not "none", and the non-Windows host reports state 5 always. The menu's glyph baking draws the page once at start-up, so a window loops before the game's first frame.
  • What changes: nfc_scan_says returns nothing from line 2 on (line 0 the longest text, line 1 the one now, as its comment already said), and a new check runs the menu's loop against it for every scan state.
  • What does not change: the row's help text in every state, the Windows reader, every other row, and the menu's layout.
  • How it was checked: the new check fails on main and passes here; a window on Linux and a windowless run with a scripted Insert both stalled on main and ran on this change.
  • What is still open: Windows, a real run; a scan finished on Windows (see Risks).
  • Risk: low: one early return in one function.

Why

#1774 added a loop to measure_help (gpu/vk/vk_menu.cpp) that asks a button's hint for line k = 0, 1, 2, ... until it returns nullptr, so that the help box keeps the height of the tallest line (the Bug report's once saved, the Scan row's). The Scan row's hint, nfc_scan_says (gpu/vk/menu/nfc.cpp), returns a text for every k once host->nfc_scan(0) is not 0. A non-Windows host answers 5 ("no Switch 2 Pro Controller over USB") always (host/nn_nfp.c), so on Linux the count never ends. Before #1774 only the line being shown was asked for, so nothing looped.

measure_help runs whenever the menu page is drawn for a new width, and prebake (gpu/vk/vk_menu.cpp) draws the page once into a scratch list while the menu is closed, so the first open has no glyphs to bake. In a window that happens on the start-up screen's thread before the game's first frame; windowless, the menu is drawn only once it is opened (with the menu stream, RX_VK_SHOT_MENU=1). Main did not build on Linux after #1774 until the include fix, so no Linux build of it could have shown this.

How to reproduce

Seen on: Arch Linux, Hyprland (Wayland), RTX 4090 (NVIDIA 615.78), main at 0de25c3e4a plus the one-commit include fix that main needs to build on Linux (its own pull request)
Settings and switches: (window) defaults; (windowless) a start from a disposable save with RX_VK_SHOT_MENU=1 and RX_VK_MENU_SCRIPT=25:INS,28:TABR,29:TABR,31:ESC (Insert 25 s after the first presented frame, two tabs right, Esc)
Steps: (window) start the game in a window on Linux; (windowless) start it as above and wait for the 25 s mark
Expected: the window shows the start-up screen and then the game; windowless, the menu opens at the Insert and the game keeps presenting
Actual: window: the compositor never maps the window, the game presents one frame in 80 s (the log says "start-up: the window is not being shown"), no fatal, crash or device-lost line. Windowless: the present trace ends exactly at the Insert (5460 frames over 25.0 s, none after) and the game ends only at its wall. In both, one thread is at 100% CPU for the rest of the run, always in the same place: ImFontCalcWordWrapPositionEx called from draw_options (where measure_help is inlined), draw_menu, then in the window prebake, menu_record, present_image and the start-up screen's thread, windowless menu_record_image, do_present, replay_thread_main.

What changed

nfc_scan_says ends its list: line 0 is the longest text, line 1 the one for the scan's state now, and nothing after, which is the order its comment and hn_nfc already follow.

  • gpu/vk/menu/nfc.cpp: one early return, if (variant > 1) return nullptr;, and the comment says why.
  • tests/test_nfc_scan_hint.py: compiles the function from the source with a stub host and runs the menu's loop with a bound, for no host and every scan state 0 to 7 (state 5 is the Linux host's).

Measurements

Verdict: nothing to measure for speed: one early return in a function called once per menu draw; the table is the stall it removes.

Hardware: Linux 7.2, RTX 4090 (NVIDIA driver 615.78), Core i9-13900K
Scene: the game started from a disposable save in the Kokiri Forest, windowless with the scripted Insert at 25 s, and in a window for 80 s
Method: the same script, options and save on both builds, one start each, in the side lane (beside another game); the builds are main with the include fix and this PR's commit on top of it
How to reproduce: the Steps above with the build of each commit

Before: main @ 0de25c3e4a After: this PR @ 7e4cf257d2
Windowless: frames presented, last at 5460, at 25.0 s (the Insert); none after 10906, at 112.4 s (the end of the run); the longest gap 0.39 s, in a map load
Windowless: menu pictures after the Insert none (no frame was drawn) the Graphics tab at 28 s and the Gameplay tab after the two tab presses
Windowless: render thread after the Insert 100% CPU for the rest of the run, the same stack in three samples 35% CPU over 54 s of play
Window: frames presented in 80 s 0 on the swapchain, 1 by the game 9173 on the swapchain, the game at 120 fps
Window: shown by the compositor no, the game's log says it is not shown yes
Window: render thread 100% CPU from the first second, the same stack twice 24% CPU, never in measure_help in two stack samples

The builds measured are main with the include fix (8a1fc7d5c1) and this PR's commit on top of it (78d40349c7, v3.0.0-rc.8-71-g78d40349c7): the include fix touches only gpu/vk/menu/pipeline_list.cpp, this PR only gpu/vk/menu/nfc.cpp and its check.

Flags and settings

None.

Testing

Tested: on Linux (RTX 4090): the new check fails on main and passes on this head; the 72 game-free checks that read the menu or NFC sources ran through the idle gate on main and on this head, 68 pass with 4 failing on main (the new check and test_bug_report_defaults, test_damage_debug_menu, test_upscaler_rows) and 69 pass with the same 3 failing here; the file passes the Windows-target syntax check (x86_64-w64-mingw32-clang++ -std=c++20 -fsyntax-only -Wall -Wextra); the build above started once windowless with the script above and once in a window, each from the same save and options as the run on main: the menu opened at the Insert, went to the Gameplay tab and closed, the game kept presenting to the end and went on from the title to the game, and the window was shown and presented 9173 frames, fatal=0 crash=0 devlost=0 nocore=0 kernel=0 nvrm=0 in both. The other hint functions of gpu/vk/menu were read for the same shape (every hint(v, k) ends: the table ones return nothing from k = 1, the others are bounded) and none other can answer every k.

Not tested: a Windows build and run; the menu opened by hand in a window on Linux (the window run's scripted Insert falls on the start-up screen, so what it shows is that presents continue, not a picture of the menu); the whole suite.

Must be tested:

  • Windows, any GPU: by hand, build this head, open the Insert menu on the NFC tab, press Scan tag on controller (no reader plugged in is fine), close and open the menu again and change Menu size, expecting the menu to keep drawing each time

Risks

What could break: the Scan row's line is the same in every state; only the loop's end changes. A Windows build that depends on a further line (a variant above 1) would lose it, and nothing reads one: measure_help and the row's own drawing ask for lines 0 and -1. On Windows the scan state is not reset after a scan (scan_state in host/nn_nfp.c), so before this change any recompute of the help height after a scan (a menu size change, a new window width, a saved pipeline list) would have looped the same way; that is read from the code, not run, and is why Windows is in Must be tested.

Turning it off: revert the commit.

Compatibility: Nothing changes.

Issues

See #1774

Checklist

Everyone

  • One topic.
  • The title is a Conventional Commit (type(scope): description) of the status line's type.
  • Why gives the reason plainly and links the issues that fit (the tracker searched).
  • Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what
    can't be run by hand is in Testing's Not testable by hand, with why.
  • Measurements has a verdict, or one line saying why there is nothing to measure.
  • Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and
    in Risks.
  • Testing names what was tested, what wasn't, and what must still be tested, where and how.
  • Rebased on current main.
  • python -I -B tests/run_all.py passes (any failure that also fails on main is named).
  • No game files, dumps, build output or generated files.
  • third_party/ untouched (a new folder with a PROVENANCE.md instead).
  • The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled.

When it applies

  • AI assistance recorded with Assisted-by: / Co-Authored-By: trailers.
  • Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths.

New on this forge; not opened on GitHub.

**Type:** fix · **Risk:** low · **Tested on:** Linux, RTX 4090 · **Needs:** Windows, any GPU ## TL;DR Since the menu rows moved into modules (#1774), on Linux the game never gets past its start-up screen in a window, and a windowless run stops presenting at its first Insert. The menu's help-box sizing asks the NFC "Scan tag on controller" row for its help lines one after another until one says nothing, and on a Linux host that row always has another: the render thread loops at 100%. The row now has its two documented lines and then none. With it, the window starts and the scripted Insert opens the menu. ## Breakdown - **Who it helps:** everyone who runs the game on Linux, in a window or windowless, and every menu pull request proved on Linux. - **What was wrong:** `measure_help` (new in #1774) calls a button's hint for line 0, 1, 2 and so on until it returns nothing; `nfc_scan_says` answered every line with a text when the host's scan state was not "none", and the non-Windows host reports state 5 always. The menu's glyph baking draws the page once at start-up, so a window loops before the game's first frame. - **What changes:** `nfc_scan_says` returns nothing from line 2 on (line 0 the longest text, line 1 the one now, as its comment already said), and a new check runs the menu's loop against it for every scan state. - **What does not change:** the row's help text in every state, the Windows reader, every other row, and the menu's layout. - **How it was checked:** the new check fails on main and passes here; a window on Linux and a windowless run with a scripted Insert both stalled on main and ran on this change. - **What is still open:** Windows, a real run; a scan finished on Windows (see Risks). - **Risk:** low: one early return in one function. ## Why #1774 added a loop to `measure_help` (`gpu/vk/vk_menu.cpp`) that asks a button's hint for line k = 0, 1, 2, ... until it returns nullptr, so that the help box keeps the height of the tallest line (the Bug report's once saved, the Scan row's). The Scan row's hint, `nfc_scan_says` (`gpu/vk/menu/nfc.cpp`), returns a text for every k once `host->nfc_scan(0)` is not 0. A non-Windows host answers 5 ("no Switch 2 Pro Controller over USB") always (`host/nn_nfp.c`), so on Linux the count never ends. Before #1774 only the line being shown was asked for, so nothing looped. `measure_help` runs whenever the menu page is drawn for a new width, and `prebake` (`gpu/vk/vk_menu.cpp`) draws the page once into a scratch list while the menu is closed, so the first open has no glyphs to bake. In a window that happens on the start-up screen's thread before the game's first frame; windowless, the menu is drawn only once it is opened (with the menu stream, `RX_VK_SHOT_MENU=1`). Main did not build on Linux after #1774 until the include fix, so no Linux build of it could have shown this. ## How to reproduce **Seen on:** Arch Linux, Hyprland (Wayland), RTX 4090 (NVIDIA 615.78), main at `0de25c3e4a` plus the one-commit include fix that main needs to build on Linux (its own pull request) **Settings and switches:** (window) defaults; (windowless) a start from a disposable save with `RX_VK_SHOT_MENU=1` and `RX_VK_MENU_SCRIPT=25:INS,28:TABR,29:TABR,31:ESC` (Insert 25 s after the first presented frame, two tabs right, Esc) **Steps:** (window) start the game in a window on Linux; (windowless) start it as above and wait for the 25 s mark **Expected:** the window shows the start-up screen and then the game; windowless, the menu opens at the Insert and the game keeps presenting **Actual:** window: the compositor never maps the window, the game presents one frame in 80 s (the log says "start-up: the window is not being shown"), no fatal, crash or device-lost line. Windowless: the present trace ends exactly at the Insert (5460 frames over 25.0 s, none after) and the game ends only at its wall. In both, one thread is at 100% CPU for the rest of the run, always in the same place: `ImFontCalcWordWrapPositionEx` called from `draw_options` (where `measure_help` is inlined), `draw_menu`, then in the window `prebake`, `menu_record`, `present_image` and the start-up screen's thread, windowless `menu_record_image`, `do_present`, `replay_thread_main`. ## What changed `nfc_scan_says` ends its list: line 0 is the longest text, line 1 the one for the scan's state now, and nothing after, which is the order its comment and `hn_nfc` already follow. - `gpu/vk/menu/nfc.cpp`: one early return, `if (variant > 1) return nullptr;`, and the comment says why. - `tests/test_nfc_scan_hint.py`: compiles the function from the source with a stub host and runs the menu's loop with a bound, for no host and every scan state 0 to 7 (state 5 is the Linux host's). ## Measurements **Verdict:** nothing to measure for speed: one early return in a function called once per menu draw; the table is the stall it removes. Hardware: Linux 7.2, RTX 4090 (NVIDIA driver 615.78), Core i9-13900K Scene: the game started from a disposable save in the Kokiri Forest, windowless with the scripted Insert at 25 s, and in a window for 80 s Method: the same script, options and save on both builds, one start each, in the side lane (beside another game); the builds are main with the include fix and this PR's commit on top of it How to reproduce: the Steps above with the build of each commit | | Before: main @ 0de25c3e4a | After: this PR @ 7e4cf257d2 | |---|---|---| | Windowless: frames presented, last at | 5460, at 25.0 s (the Insert); none after | 10906, at 112.4 s (the end of the run); the longest gap 0.39 s, in a map load | | Windowless: menu pictures after the Insert | none (no frame was drawn) | the Graphics tab at 28 s and the Gameplay tab after the two tab presses | | Windowless: render thread after the Insert | 100% CPU for the rest of the run, the same stack in three samples | 35% CPU over 54 s of play | | Window: frames presented in 80 s | 0 on the swapchain, 1 by the game | 9173 on the swapchain, the game at 120 fps | | Window: shown by the compositor | no, the game's log says it is not shown | yes | | Window: render thread | 100% CPU from the first second, the same stack twice | 24% CPU, never in `measure_help` in two stack samples | The builds measured are main with the include fix (`8a1fc7d5c1`) and this PR's commit on top of it (`78d40349c7`, `v3.0.0-rc.8-71-g78d40349c7`): the include fix touches only `gpu/vk/menu/pipeline_list.cpp`, this PR only `gpu/vk/menu/nfc.cpp` and its check. ### Flags and settings None. ## Testing **Tested:** on Linux (RTX 4090): the new check fails on main and passes on this head; the 72 game-free checks that read the menu or NFC sources ran through the idle gate on main and on this head, 68 pass with 4 failing on main (the new check and `test_bug_report_defaults`, `test_damage_debug_menu`, `test_upscaler_rows`) and 69 pass with the same 3 failing here; the file passes the Windows-target syntax check (`x86_64-w64-mingw32-clang++ -std=c++20 -fsyntax-only -Wall -Wextra`); the build above started once windowless with the script above and once in a window, each from the same save and options as the run on main: the menu opened at the Insert, went to the Gameplay tab and closed, the game kept presenting to the end and went on from the title to the game, and the window was shown and presented 9173 frames, fatal=0 crash=0 devlost=0 nocore=0 kernel=0 nvrm=0 in both. The other hint functions of `gpu/vk/menu` were read for the same shape (every `hint(v, k)` ends: the table ones return nothing from k = 1, the others are bounded) and none other can answer every k. **Not tested:** a Windows build and run; the menu opened by hand in a window on Linux (the window run's scripted Insert falls on the start-up screen, so what it shows is that presents continue, not a picture of the menu); the whole suite. **Must be tested:** - Windows, any GPU: by hand, build this head, open the Insert menu on the NFC tab, press Scan tag on controller (no reader plugged in is fine), close and open the menu again and change Menu size, expecting the menu to keep drawing each time ## Risks **What could break:** the Scan row's line is the same in every state; only the loop's end changes. A Windows build that depends on a further line (a variant above 1) would lose it, and nothing reads one: `measure_help` and the row's own drawing ask for lines 0 and -1. On Windows the scan state is not reset after a scan (`scan_state` in `host/nn_nfp.c`), so before this change any recompute of the help height after a scan (a menu size change, a new window width, a saved pipeline list) would have looped the same way; that is read from the code, not run, and is why Windows is in Must be tested. **Turning it off:** revert the commit. **Compatibility:** Nothing changes. ## Issues See #1774 ## Checklist ### Everyone - [x] One topic. - [x] The title is a Conventional Commit (`type(scope): description`) of the status line's type. - [x] Why gives the reason plainly and links the issues that fit (the tracker searched). - [x] Tested on my own PC where it runs (in the game, for a change the game runs), as Testing's Tested says; what can't be run by hand is in Testing's Not testable by hand, with why. - [x] Measurements has a verdict, or one line saying why there is nothing to measure. - [x] Nothing gets worse that I know of: any cost (speed, latency, memory, a setup that worked before) is measured and in Risks. - [x] Testing names what was tested, what wasn't, and what must still be tested, where and how. - [x] Rebased on current `main`. - [x] `python -I -B tests/run_all.py` passes (any failure that also fails on `main` is named). - [x] No game files, dumps, build output or generated files. - [x] `third_party/` untouched (a new folder with a `PROVENANCE.md` instead). - [x] The license is OK: GPL-3.0-or-later, nothing incompatible and nothing decompiled. ### When it applies - [x] AI assistance recorded with `Assisted-by:` / `Co-Authored-By:` trailers. - [x] Host code builds on both Windows (llvm-mingw) and Linux, with UTF-8 paths. --- New on this forge; not opened on GitHub.
fix(menu): the Scan row's help lines end, so the menu's first open no longer spins on Linux
Some checks reported errors
CI / Python source checks (ubuntu-24.04, part 1/2) (pull_request) Has been skipped
CI / Python source checks (ubuntu-24.04, part 2/2) (pull_request) Has been skipped
CI / SPIR-V fixtures (global narrow load/store, direct surface atomics, F2I immediate) (pull_request) Has been skipped
Third-party parts / The same as upstream (pull_request) Has been skipped
PR description / Description follows the template (pull_request_target) Successful in 14s
Website / Website on Cloudflare (pull_request_target) Has been skipped
Third-party parts / As their notes say (pull_request) Successful in 17s
Guide screenshots / Guide images and local UI source review (pull_request) Failing after 17s
CI / Conventional Commit title (pull_request) Successful in 10s
CI / Workflow lint (actionlint) (pull_request) Successful in 17s
beanstalk/windows 1/1 pass
beanstalk/linux 0/1 pass, 2 error
beanstalk/approval approved by mooki (reviewed)
7e4cf257d2
measure_help sizes the help box by asking a button's hint for line 0, 1, 2, ... until nullptr (#1633). The NFC Scan row's
nfc_scan_says answered every line with a text whenever the host's scan state was not "none", and a non-Windows host reports
state 5 always (host/nn_nfp.c): the count never ended, the render thread spun at 100% at the menu's first open and the game
stopped presenting (seen on a headless Linux run with a scripted Insert, on main and on three pull requests ported to it).
It now has its two documented lines (0 the longest, 1 the one now) and nullptr after.

tests/test_nfc_scan_hint.py compiles the function from the source with a stub host, for no host and every scan state, and
runs the menu's loop with a bound; it fails before this change and passes after.

Assisted-by: Claude Sonnet 5.5
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Author
Member

Since the menu model (#1774) a Linux game does not get past its start-up screen in a window, and a windowless run stops presenting at its first Insert: measure_help asks a button's hint for line 0, 1, 2 and so on until it returns nothing, and the Scan tag on controller row (nfc_scan_says) answers every line on a Linux host, whose scan state is always 5. The render thread loops at 100% there (ImFontCalcWordWrapPositionEx from draw_options, read from the running game); in a window it is prebake drawing the page once at start-up.
This PR gives the row its two documented lines and nothing after (one early return in gpu/vk/menu/nfc.cpp), with a check that runs the menu's loop against the real function for no host and every scan state: it fails on main and passes here.
On Linux (RTX 4090) a window of main stayed unmapped with one frame presented in 80 s, and with this change it was shown and presented 9173 frames; the same scripted Insert at 25 s windowless stopped presenting on main (last frame 5460) and kept presenting with this change (10906 frames, the menu drawn on the Graphics and Gameplay tabs). The other hint functions of the menu were read for the same shape and none can answer every line.
Windows is not tested: the scan state is not reset there after a scan, so it may loop the same way after a Scan press; please try that by hand.

Since the menu model (#1774) a Linux game does not get past its start-up screen in a window, and a windowless run stops presenting at its first Insert: `measure_help` asks a button's hint for line 0, 1, 2 and so on until it returns nothing, and the Scan tag on controller row (`nfc_scan_says`) answers every line on a Linux host, whose scan state is always 5. The render thread loops at 100% there (`ImFontCalcWordWrapPositionEx` from `draw_options`, read from the running game); in a window it is `prebake` drawing the page once at start-up. This PR gives the row its two documented lines and nothing after (one early return in `gpu/vk/menu/nfc.cpp`), with a check that runs the menu's loop against the real function for no host and every scan state: it fails on main and passes here. On Linux (RTX 4090) a window of main stayed unmapped with one frame presented in 80 s, and with this change it was shown and presented 9173 frames; the same scripted Insert at 25 s windowless stopped presenting on main (last frame 5460) and kept presenting with this change (10906 frames, the menu drawn on the Graphics and Gameplay tabs). The other hint functions of the menu were read for the same shape and none can answer every line. Windows is not tested: the scan state is not reset there after a scan, so it may loop the same way after a Scan press; please try that by hand.
mooki changed title from WIP: fix(menu): the Scan row's help lines end, so a Linux window starts and the menu opens again to fix(menu): the Scan row's help lines end, so a Linux window starts and the menu opens again 2026-11-19 23:00:54 +00:00
Member

Possibly related, for context:

  • PR #1184 fix(prompts): texts already on screen follow a new face at once (the HUD's item button) — Unrelated prompt-face update; same general menu area only
  • PR #280 feat(nfc): NFC tags from the player's own dumps, with an NFC tab in the Insert menu — Introduced the NFC scan hint function changed here
Possibly related, for context: - PR #1184 fix(prompts): texts already on screen follow a new face at once (the HUD's item button) — Unrelated prompt-face update; same general menu area only - PR #280 feat(nfc): NFC tags from the player's own dumps, with an NFC tab in the Insert menu — Introduced the NFC scan hint function changed here
Author
Member

@Beanstalk

@Beanstalk
Member

Beanstalk test farm

Commit 7e4cf25 · tier reviewed · approved by mooki · dashboard

What will be tested · AI plan (gpt-6.1-terra)

On Linux and Windows, this plan opens the menu windowlessly from the Kokiri starting save, changes tabs, closes it, and checks that presentation continues. Each tester runs one start per build, taking roughly 12 minutes; menu screenshots and frame times are compared with main. A crash, stalled presentation, menu image difference, or substantial frame-time regression fails the test; main may itself stall on Linux. The automated sequence does not press the NFC Scan row or test a physical reader.

  • Where: linux (1-2 reports), windows (1-2 reports).
  • menu-presentation: from the repository's save kokiri-start (switches RX_VK_SHOT_MENU=1, RX_VK_MENU_SCRIPT=5:INS,8:TABR,9:TABR,12:ESC), then take the picture menu-open to compare with main, take the picture menu-tabs to compare with main, measure after-menu for 10 s (after 0 s warm-up); 1 run on each side.
  • Measured: crashes, frame times, stutters and hitches.
  • The PR fails if: it crashes; or a picture differs from main by more than 5%; or frame time (p99) is more than 20% above main.
  • Time: about 11 min of game runs per tester (2 game starts), plus the two builds.

Done (started 2026-11-19 23:01 UTC, last report 2026-11-19 23:07 UTC). Comment @Beanstalk to run it again.

Target Reports Crash Frame p99 (ms) vs main VRAM peak (MB) vs main Result
linux · 1: linux+amd+radv+dgpu AMD Radeon RX 9070 XT (RADV GFX1201), 26.2.6; 2: linux+amd+radv+dgpu AMD Radeon RX 7900 XTX (RADV NAVI31), 26.2.7 2/1 1 2 none — — error
windows · 1: windows+nvidia+nvidia-proprietary+dgpu NVIDIA GeForce RTX 3050 Ti Laptop GPU, 621.24.0; 2: windows+amd+amd-proprietary+dgpu AMD Radeon RX 9060 XT, 2.0.416 2/1 1 2 none 19.0 vs 19.0 (−0%) — pass

Measurements · linux

Verdict: could not be judged on linux (2/1 report).

Hardware: 1: linux+amd+radv+dgpu AMD Radeon RX 9070 XT (RADV GFX1201), 26.2.6 11th Gen Intel(R) Core(TM) i9-11900KB @ 3.30GHz, 32 GB RAM; 2: linux+amd+radv+dgpu AMD Radeon RX 7900 XTX (RADV NAVI31), 26.2.7 AMD Ryzen 7 5800X3D 8-Core Processor, 64 GB RAM
Scene: menu-presentation, from the repository's save kokiri-start (RX_VK_SHOT_MENU=1, RX_VK_MENU_SCRIPT=5:INS,8:TABR,9:TABR,12:ESC); each cell's settings and switches as the table names them
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); menu-presentation: 1 game start a side, after-menu 10 s after 0 s warm-up; each number the median of the runs, then of 2 reports
How to reproduce: the farm's plan above (@Beanstalk on this PR runs it again)

Nothing was measured: no metric came back.

Flags and settings

None: the plan varied no setting, switch or build option.

Markdown for the PR description
## Measurements

**Verdict:** could not be judged on linux (2/1 report).

Hardware: 1: linux+amd+radv+dgpu `AMD Radeon RX 9070 XT (RADV GFX1201), 26.2.6` `11th Gen Intel(R) Core(TM) i9-11900KB @ 3.30GHz, 32 GB RAM`; 2: linux+amd+radv+dgpu `AMD Radeon RX 7900 XTX (RADV NAVI31), 26.2.7` `AMD Ryzen 7 5800X3D 8-Core Processor, 64 GB RAM`  
Scene: menu-presentation, from the repository's save kokiri-start (RX_VK_SHOT_MENU=1, RX_VK_MENU_SCRIPT=5:INS,8:TABR,9:TABR,12:ESC); each cell's settings and switches as the table names them  
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); menu-presentation: 1 game start a side, after-menu 10 s after 0 s warm-up; each number the median of the runs, then of 2 reports  
How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again)

Nothing was measured: no metric came back.

### Flags and settings

None: the plan varied no setting, switch or build option.

Measurements · windows

Verdict: pass on windows (2/1 report): no rule failed and no PR run crashed.

Hardware: 1: windows+nvidia+nvidia-proprietary+dgpu NVIDIA GeForce RTX 3050 Ti Laptop GPU, 621.24.0 AMD Ryzen 7 5800H with Radeon Graphics, 16 GB RAM; 2: windows+amd+amd-proprietary+dgpu AMD Radeon RX 9060 XT, 2.0.416 AMD Ryzen 5 5600 6-Core Processor, 32 GB RAM
Scene: menu-presentation, from the repository's save kokiri-start (RX_VK_SHOT_MENU=1, RX_VK_MENU_SCRIPT=5:INS,8:TABR,9:TABR,12:ESC); each cell's settings and switches as the table names them
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); menu-presentation: 1 game start a side, after-menu 10 s after 0 s warm-up; each number the median of the runs, then of 2 reports
How to reproduce: the farm's plan above (@Beanstalk on this PR runs it again)

Before: main @ 0de25c3 After: this PR @ 7e4cf25
menu-presentation · after-menu · frame time (p99) (ms) 19.0 19.0 (−0%)

Flags and settings

None: the plan varied no setting, switch or build option.

Markdown for the PR description
## Measurements

**Verdict:** pass on windows (2/1 report): no rule failed and no PR run crashed.

Hardware: 1: windows+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 3050 Ti Laptop GPU, 621.24.0` `AMD Ryzen 7 5800H with Radeon Graphics, 16 GB RAM`; 2: windows+amd+amd-proprietary+dgpu `AMD Radeon RX 9060 XT, 2.0.416` `AMD Ryzen 5 5600 6-Core Processor, 32 GB RAM`  
Scene: menu-presentation, from the repository's save kokiri-start (RX_VK_SHOT_MENU=1, RX_VK_MENU_SCRIPT=5:INS,8:TABR,9:TABR,12:ESC); each cell's settings and switches as the table names them  
Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); menu-presentation: 1 game start a side, after-menu 10 s after 0 s warm-up; each number the median of the runs, then of 2 reports  
How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again)

| | Before: main @ 0de25c3 | After: this PR @ 7e4cf25 |
|---|---|---|
| menu-presentation · after-menu · frame time (p99) (ms) | 19.0 | 19.0 (−0%) |

### Flags and settings

None: the plan varied no setting, switch or build option.
<!-- beanstalk:sticky --> ### Beanstalk test farm Commit `7e4cf25` · tier **reviewed** · approved by mooki · [dashboard](https://beanstalk.magicbean.dev/prs/1815) **What will be tested** · AI plan (`gpt-6.1-terra`) On Linux and Windows, this plan opens the menu windowlessly from the Kokiri starting save, changes tabs, closes it, and checks that presentation continues. Each tester runs one start per build, taking roughly 12 minutes; menu screenshots and frame times are compared with main. A crash, stalled presentation, menu image difference, or substantial frame-time regression fails the test; main may itself stall on Linux. The automated sequence does not press the NFC Scan row or test a physical reader. - **Where:** linux (1-2 reports), windows (1-2 reports). - **menu-presentation:** from the repository's save `kokiri-start` (switches `RX_VK_SHOT_MENU=1`, `RX_VK_MENU_SCRIPT=5:INS,8:TABR,9:TABR,12:ESC`), then take the picture menu-open to compare with main, take the picture menu-tabs to compare with main, measure after-menu for 10 s (after 0 s warm-up); 1 run on each side. - **Measured:** crashes, frame times, stutters and hitches. - **The PR fails if:** it crashes; or a picture differs from main by more than 5%; or frame time (p99) is more than 20% above main. - **Time:** about 11 min of game runs per tester (2 game starts), plus the two builds. Done (started 2026-11-19 23:01 UTC, last report 2026-11-19 23:07 UTC). Comment `@Beanstalk` to run it again. | Target | Reports | Crash | Frame p99 (ms) vs main | VRAM peak (MB) vs main | Result | | --- | --- | --- | --- | --- | --- | | linux · 1: linux+amd+radv+dgpu `AMD Radeon RX 9070 XT (RADV GFX1201), 26.2.6`; 2: linux+amd+radv+dgpu `AMD Radeon RX 7900 XTX (RADV NAVI31), 26.2.7` | 2/1 [1](https://beanstalk.magicbean.dev/reports/rp_03ffe8b5239d0691) [2](https://beanstalk.magicbean.dev/reports/rp_4448733bc5b84920) | none | — | — | error | | windows · 1: windows+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 3050 Ti Laptop GPU, 621.24.0`; 2: windows+amd+amd-proprietary+dgpu `AMD Radeon RX 9060 XT, 2.0.416` | 2/1 [1](https://beanstalk.magicbean.dev/reports/rp_e73d0a3bbbf360cb) [2](https://beanstalk.magicbean.dev/reports/rp_4e09296d061a65d9) | none | 19.0 vs 19.0 (−0%) | — | pass | #### Measurements · linux **Verdict:** could not be judged on linux (2/1 report). Hardware: 1: linux+amd+radv+dgpu `AMD Radeon RX 9070 XT (RADV GFX1201), 26.2.6` `11th Gen Intel(R) Core(TM) i9-11900KB @ 3.30GHz, 32 GB RAM`; 2: linux+amd+radv+dgpu `AMD Radeon RX 7900 XTX (RADV NAVI31), 26.2.7` `AMD Ryzen 7 5800X3D 8-Core Processor, 64 GB RAM` Scene: menu-presentation, from the repository's save kokiri-start (RX_VK_SHOT_MENU=1, RX_VK_MENU_SCRIPT=5:INS,8:TABR,9:TABR,12:ESC); each cell's settings and switches as the table names them Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); menu-presentation: 1 game start a side, after-menu 10 s after 0 s warm-up; each number the median of the runs, then of 2 reports How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again) Nothing was measured: no metric came back. ### Flags and settings None: the plan varied no setting, switch or build option. <details><summary>Markdown for the PR description</summary> ```markdown ## Measurements **Verdict:** could not be judged on linux (2/1 report). Hardware: 1: linux+amd+radv+dgpu `AMD Radeon RX 9070 XT (RADV GFX1201), 26.2.6` `11th Gen Intel(R) Core(TM) i9-11900KB @ 3.30GHz, 32 GB RAM`; 2: linux+amd+radv+dgpu `AMD Radeon RX 7900 XTX (RADV NAVI31), 26.2.7` `AMD Ryzen 7 5800X3D 8-Core Processor, 64 GB RAM` Scene: menu-presentation, from the repository's save kokiri-start (RX_VK_SHOT_MENU=1, RX_VK_MENU_SCRIPT=5:INS,8:TABR,9:TABR,12:ESC); each cell's settings and switches as the table names them Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); menu-presentation: 1 game start a side, after-menu 10 s after 0 s warm-up; each number the median of the runs, then of 2 reports How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again) Nothing was measured: no metric came back. ### Flags and settings None: the plan varied no setting, switch or build option. ``` </details> #### Measurements · windows **Verdict:** pass on windows (2/1 report): no rule failed and no PR run crashed. Hardware: 1: windows+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 3050 Ti Laptop GPU, 621.24.0` `AMD Ryzen 7 5800H with Radeon Graphics, 16 GB RAM`; 2: windows+amd+amd-proprietary+dgpu `AMD Radeon RX 9060 XT, 2.0.416` `AMD Ryzen 5 5600 6-Core Processor, 32 GB RAM` Scene: menu-presentation, from the repository's save kokiri-start (RX_VK_SHOT_MENU=1, RX_VK_MENU_SCRIPT=5:INS,8:TABR,9:TABR,12:ESC); each cell's settings and switches as the table names them Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); menu-presentation: 1 game start a side, after-menu 10 s after 0 s warm-up; each number the median of the runs, then of 2 reports How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again) | | Before: main @ 0de25c3 | After: this PR @ 7e4cf25 | |---|---|---| | menu-presentation · after-menu · frame time (p99) (ms) | 19.0 | 19.0 (−0%) | ### Flags and settings None: the plan varied no setting, switch or build option. <details><summary>Markdown for the PR description</summary> ```markdown ## Measurements **Verdict:** pass on windows (2/1 report): no rule failed and no PR run crashed. Hardware: 1: windows+nvidia+nvidia-proprietary+dgpu `NVIDIA GeForce RTX 3050 Ti Laptop GPU, 621.24.0` `AMD Ryzen 7 5800H with Radeon Graphics, 16 GB RAM`; 2: windows+amd+amd-proprietary+dgpu `AMD Radeon RX 9060 XT, 2.0.416` `AMD Ryzen 5 5600 6-Core Processor, 32 GB RAM` Scene: menu-presentation, from the repository's save kokiri-start (RX_VK_SHOT_MENU=1, RX_VK_MENU_SCRIPT=5:INS,8:TABR,9:TABR,12:ESC); each cell's settings and switches as the table names them Method: the Beanstalk test farm: main and this PR built and run on the same PC in one session, game starts alternating (ABBA); menu-presentation: 1 game start a side, after-menu 10 s after 0 s warm-up; each number the median of the runs, then of 2 reports How to reproduce: the farm's plan above (`@Beanstalk` on this PR runs it again) | | Before: main @ 0de25c3 | After: this PR @ 7e4cf25 | |---|---|---| | menu-presentation · after-menu · frame time (p99) (ms) | 19.0 | 19.0 (−0%) | ### Flags and settings None: the plan varied no setting, switch or build option. ``` </details>
futondestroyer left a comment

Verdict: Request changes. The Scan help loop fix looks sound. The readiness evidence needs a full-suite result and a Linux run with a buildable control.

Reviewed mooki’s 7e4cf257 against 0de25c3e. The finite help-line iteration addresses the reported startup/reopen loop. Please report the full game-free suite outcome, naming failures reproduced on main and any skips, rather than counting focused checks as a full-suite pass.

The earlier Linux farm controls failed before gameplay because the pipeline-list module lacked POSIX includes. Rebase onto main containing the include fix and rerun Linux on an exact buildable pair. Start a new game, open Insert, switch tabs, close it and confirm the game continues presenting. Separately on Windows, manually visit the Scan row/help, close and reopen Insert, and resize the window. Keep that manual result separate from the farm startup check.

Credit to the Windows Beanstalk testers: the RTX 3050 Ti Laptop and RX 9060 XT passed the scripted route, with p99 19.0 ms on each side in the summary. That route did not establish the manual Scan/reopen/resize check.

**Verdict: Request changes.** The Scan help loop fix looks sound. The readiness evidence needs a full-suite result and a Linux run with a buildable control. Reviewed mooki’s `7e4cf257` against `0de25c3e`. The finite help-line iteration addresses the reported startup/reopen loop. Please report the full game-free suite outcome, naming failures reproduced on main and any skips, rather than counting focused checks as a full-suite pass. The earlier Linux farm controls failed before gameplay because the pipeline-list module lacked POSIX includes. Rebase onto main containing [the include fix](https://git.magicbean.dev/MagicBeanDev/Longshot/pulls/1807) and rerun Linux on an exact buildable pair. Start a new game, open Insert, switch tabs, close it and confirm the game continues presenting. Separately on Windows, manually visit the Scan row/help, close and reopen Insert, and resize the window. Keep that manual result separate from the farm startup check. Credit to the Windows Beanstalk testers: the RTX 3050 Ti Laptop and RX 9060 XT passed the scripted route, with p99 19.0 ms on each side in the summary. That route did not establish the manual Scan/reopen/resize check.
Member

Tested on a second setup: RTX 3060 Laptop GPU (6 GB), NVIDIA 620.70.06, CachyOS (Linux 7.3.4), KDE Plasma Wayland, two screens (HDMI 1080p 75 Hz primary, laptop panel 1080p 300 Hz), fullscreen. It fixes #1834.

Before and after are the same game folder (nightly-596-2692a6e3) with only bin/longshot_vk.so changed. "After" is that renderer built from 2692a6e3 with this PR's commit cherry-picked on top (dev_build.py vk).

nightly-596 as shipped with this PR
Window mapped by KWin no (no window for the game's pid, 5 of 5 starts) yes, 1920x1080 fullscreen on the primary screen
Start-up screen progress lines (vk: start-up: pipelines N of M) none every 10 s, through 98%
start-up: the window is not being shown yes no
Game's frames none seen presented (present texture ... rendered), the shaders took 246.7 s
CPU while stuck two host threads at ~80% for the whole start normal

No fatal, crash or device-lost lines.

Tested on a second setup: **RTX 3060 Laptop GPU (6 GB), NVIDIA 620.70.06, CachyOS (Linux 7.3.4), KDE Plasma Wayland, two screens (HDMI 1080p 75 Hz primary, laptop panel 1080p 300 Hz), fullscreen.** It fixes #1834. Before and after are the same game folder (nightly-596-2692a6e3) with only `bin/longshot_vk.so` changed. "After" is that renderer built from `2692a6e3` with this PR's commit cherry-picked on top (`dev_build.py vk`). | | nightly-596 as shipped | with this PR | |---|---|---| | Window mapped by KWin | no (no window for the game's pid, 5 of 5 starts) | yes, 1920x1080 fullscreen on the primary screen | | Start-up screen progress lines (`vk: start-up: pipelines N of M`) | none | every 10 s, through 98% | | `start-up: the window is not being shown` | yes | no | | Game's frames | none seen | presented (`present texture ... rendered`), the shaders took 246.7 s | | CPU while stuck | two host threads at ~80% for the whole start | normal | No fatal, crash or device-lost lines.
HumanBean deleted branch fix-nfc-scan-hint-loop 2026-11-20 03:57:13 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
5 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
MagicBeanDev/Longshot!1815
No description provided.